GNU bug report logs - #23964
25.1.50; `+' no longer works on images in Gnus article buffers

Previous Next

Full log

Message #17 received at 23964 <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: larsi <at> gnus.org
Cc: 23964 <at> debbugs.gnu.org
Subject: Re: bug#23964: 25.1.50;
 `+' no longer works on images in Gnus article buffers
Date: Fri, 22 Jul 2016 20:08:42 +0900

[Message part 1 (text/plain, inline)]

On Thu, 21 Jul 2016 17:46:18 +0900, Katsumi Yamaoka wrote:
> I realized `+' works for some html mails but doesn't for others.

I'm not quite sure this is the right approach, but I seem to have
found the cause and the solution.  `shr-image-fetched', that
`shr-tag-img' calls, overrides the keymap text property on an
image with the value that was there before inserting the image,
that is, nil.  Could you please test this patch?

[Message part 2 (text/x-patch, inline)]

--- shr.el~	2016-07-21 08:35:17.668496000 +0000
+++ shr.el	2016-07-22 11:05:56.349491100 +0000
@@ -937,7 +937,7 @@
 		(while properties
 		  (let ((type (pop properties))
 			(value (pop properties)))
-		    (unless (memq type '(display image-size))
+		    (unless (memq type '(display image-size keymap))
 		      (put-text-property start (point) type value))))))))))
     (kill-buffer image-buffer)))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.