From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 15:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23957@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146833859127227 (code B ref -1); Tue, 12 Jul 2016 15:50:03 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jul 2016 15:49:51 +0000 Received: from localhost ([127.0.0.1]:48558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMzwU-000754-9H for submit@debbugs.gnu.org; Tue, 12 Jul 2016 11:49:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMroC-0007RQ-2t for submit@debbugs.gnu.org; Tue, 12 Jul 2016 03:08:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMro4-0007RE-FN for submit@debbugs.gnu.org; Tue, 12 Jul 2016 03:08:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMro4-0007R3-Br for submit@debbugs.gnu.org; Tue, 12 Jul 2016 03:08:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMro0-000092-PS for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 03:08:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMrnw-0007Q6-FD for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 03:08:31 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:43536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMrnv-0007Pi-T2 for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 03:08:28 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :subject:date:message-id:mime-version:content-type; s=dkim1; bh= s8/A1xxHwyrntv1s7dcYTw08RO8=; b=tZexzsmrEtOkie0ROPBOY3VG5tL3huXI TVAjFCsY7/aR6UhN4cq+bl0RYOcifhzEmCV9DYhheqU7MWkqCGkuEkLZZsOxK5+k HiaNEataxQ6kwMO7zRgob1Wnc69v0fLrF7MA1+fwfKEHjqN6sNJKT14faI7oaDUV HXqj2VRgQghkUv7TzcZ8zhJjwlT2PORZEHbXshBslIz6Nq+O1KyOglmBhUBxYjVO PLLGpoeVzQoQGEkN3tMmDBa7ccr9bB0vT/paqKUGADVdjcuPBemgjlrx89nwxS0P xiVGKmrVOdYvdKNTOlBLv2Zk4RrKMrr9WO6/GoNiYtLMHJYPAyDRAQ== Received: (qmail 18268 invoked by uid 0); 12 Jul 2016 07:08:22 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=qj+5K26SnHL8OsVUgawHzBKPx7ngpSJ9ylbQQK/Ws+DdCBFHN7R0B/YhSsPcKrKsWt3QGtOx2wo/MW1jur7YlQ==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 07:08:22 -0000 From: Robert Cochran Date: Tue, 12 Jul 2016 00:08:18 -0700 Message-ID: <87k2gr49lp.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Tue, 12 Jul 2016 11:49:49 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain Hello bug-gnu-emacs, I was looking through the C portions of the Emacs source for fun, and noticed a FIXME. I've wanted to start hacking on Emacs, the C portions in specific, so I jumped right in. My patch, attached, does the following: * The function definition in src/data.c for fboundp has been removed, along with the corresponding defsubr in syms_of_data, as suggested in the FIXME * All places where Ffboundp is used in the C code has been replaced with Fsymbol_function * A defalias form that makes fboundp an alias of symbol-function has been inserted into lisp/subr.el * In lisp/emacs-lisp/byte-run.el, and also lisp/loadup.el before loading lisp/subr.el, all instances of fboundp have been replaced with symbol-function * All other instances of fboundp have been left alone For anyone interested, I have a copy of the Emacs repository with the patch applied here: https://gitlab.com/RobertCochran/emacs/tree/alias-fboundp I understand that the FSF requires a copyright assignment for non-trivial patches made to Emacs, and this is likely considered non-trivial. I am perfectly happy to do so, but require guidance on how to accomplish it. On that topic, how can I go about this process so that I automatically perform the appropriate assignments for each contribution? Please do offer suggestions and improvements for any deficiency in my patch. Thanks, ~Robert Cochran --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Make-fboundp-an-alias-for-symbol-function.patch Content-Description: fboundp alias patch >From 0e3a73b1821c154bd20121c0d903109226f5fe7b Mon Sep 17 00:00:00 2001 From: Robert Cochran Date: Sun, 10 Jul 2016 20:28:17 -0700 Subject: [PATCH] Make fboundp an alias for symbol-function fboundp is similar enough to symbol-function that they are reasonably interchangeable. Following the advice of the FIXME by fboundp's definition, it has been removed as an independent function and is now defined as an alias of symbol-function in lisp/subr.el. In the C code, Ffboundp has been replaced with Fsymbol_function. In lisp/emacs-lisp/byte-run.el and lisp/loadup.el, instances of fboundp used before loading lisp/subr.el have been replaced with symbol-function. All other uses have been unchanged, as fboundp gains a definition after loading lisp/subr.el. * lisp/emacs-lisp/byte-run.el (defmacro): Use symbol-function instead of fboundp. * lisp/loadup.el: Use symbol-function instead of fboundp when adding to the load-path during bootstrap. * lisp/subr.el: Make fboundp an alias for symbol-function. * src/data.c (fboundp): Remove. (syms_of_data): Remove defsubr for fboundp. * src/coding.c (find-operation-coding-system): * src/composite.c (run_composition_function): * src/doc.c (Snarf-documentation): * src/fileio.c (substitute-in-file-name, insert-file-contents, choose_write_coding_system): * src/fns.c (secure_hash): * src/gtkutil.c (update_frame_tool_bar): * src/keyboard.c (command_loop_1, access_keymap_keyremap): * src/lisp.h (maybe_gc): * src/lread.c (load, readevalloop): * src/minibuf.c (read_minibuf, get_minibuffer): * src/process.c (finish_after_tls_connection): * src/syntax.c (scan_words): * src/xdisp.c (message_dolog): * src/xfaces.c (tty_lookup_color, defined_color): Use Fsymbol_function instead of Ffboundp. --- lisp/emacs-lisp/byte-run.el | 6 +++--- lisp/loadup.el | 2 +- lisp/subr.el | 1 + src/coding.c | 2 +- src/composite.c | 2 +- src/data.c | 10 ---------- src/doc.c | 2 +- src/fileio.c | 8 ++++---- src/fns.c | 2 +- src/gtkutil.c | 2 +- src/keyboard.c | 4 ++-- src/lisp.h | 2 +- src/lread.c | 6 +++--- src/minibuf.c | 4 ++-- src/process.c | 2 +- src/syntax.c | 4 ++-- src/xdisp.c | 2 +- src/xfaces.c | 6 +++--- 18 files changed, 29 insertions(+), 38 deletions(-) diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 818c268..1abfa43 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -212,9 +212,9 @@ The return value is undefined. (if (and ;; If lisp-mode hasn't been loaded, there's no reason ;; to flush. - (fboundp 'lisp--el-font-lock-flush-elisp-buffers) - (or (not (fboundp name)) ;; new macro - (and (fboundp name) ;; existing macro + (symbol-function 'lisp--el-font-lock-flush-elisp-buffers) + (or (not (symbol-function name)) ;; new macro + (and (symbol-function name) ;; existing macro (member `(function-put ',name 'no-font-lock-keyword ',(get name 'no-font-lock-keyword)) declarations)))) diff --git a/lisp/loadup.el b/lisp/loadup.el index 5c16464..bb38669 100644 --- a/lisp/loadup.el +++ b/lisp/loadup.el @@ -61,7 +61,7 @@ ;; FIXME this is irritatingly fragile. (equal (nth 4 command-line-args) "unidata-gen.el") (equal (nth 7 command-line-args) "unidata-gen-files") - (if (fboundp 'dump-emacs) + (if (symbol-function 'dump-emacs) (string-match "src/bootstrap-emacs" (nth 0 command-line-args)) t)) (let ((dir (car load-path))) diff --git a/lisp/subr.el b/lisp/subr.el index cf84d8b..edffd00 100644 --- a/lisp/subr.el +++ b/lisp/subr.el @@ -68,6 +68,7 @@ For more information, see Info node `(elisp)Declaring Functions'." (defalias 'not 'null) (defalias 'sxhash 'sxhash-equal) +(defalias 'fboundp 'symbol-function) (defmacro noreturn (form) "Evaluate FORM, expecting it not to return. diff --git a/src/coding.c b/src/coding.c index 29c90f0..abf5eda 100644 --- a/src/coding.c +++ b/src/coding.c @@ -9877,7 +9877,7 @@ usage: (find-operation-coding-system OPERATION ARGUMENTS...) */) return Qnil; if (! NILP (Fcoding_system_p (val))) return Fcons (val, val); - if (! NILP (Ffboundp (val))) + if (! NILP (Fsymbol_function (val))) { /* We use call1 rather than safe_call1 so as to get bug reports about functions called here diff --git a/src/composite.c b/src/composite.c index 8aa6974..4e19e06 100644 --- a/src/composite.c +++ b/src/composite.c @@ -473,7 +473,7 @@ run_composition_function (ptrdiff_t from, ptrdiff_t to, Lisp_Object prop) && find_composition (to, -1, &start, &end, &prop, Qnil) && !composition_valid_p (start, end, prop)) to = end; - if (!NILP (Ffboundp (func))) + if (!NILP (Fsymbol_function (func))) call2 (func, make_number (from), make_number (to)); } diff --git a/src/data.c b/src/data.c index 71da916..c7e0f7e 100644 --- a/src/data.c +++ b/src/data.c @@ -629,15 +629,6 @@ global value outside of any lexical scope. */) return (EQ (valcontents, Qunbound) ? Qnil : Qt); } -/* FIXME: Make it an alias for function-symbol! */ -DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0, - doc: /* Return t if SYMBOL's function definition is not void. */) - (register Lisp_Object symbol) -{ - CHECK_SYMBOL (symbol); - return NILP (XSYMBOL (symbol)->function) ? Qnil : Qt; -} - DEFUN ("makunbound", Fmakunbound, Smakunbound, 1, 1, 0, doc: /* Make SYMBOL's value be void. Return SYMBOL. */) @@ -3654,7 +3645,6 @@ syms_of_data (void) defsubr (&Smakunbound); defsubr (&Sfmakunbound); defsubr (&Sboundp); - defsubr (&Sfboundp); defsubr (&Sfset); defsubr (&Sdefalias); defsubr (&Ssetplist); diff --git a/src/doc.c b/src/doc.c index 6ffdad1..4965b76 100644 --- a/src/doc.c +++ b/src/doc.c @@ -651,7 +651,7 @@ the same file name is found in the `doc-directory'. */) /* Attach a docstring to a function? */ else if (p[1] == 'F') { - if (!NILP (Ffboundp (sym))) + if (!NILP (Fsymbol_function (sym))) store_function_docstring (sym, pos + end + 1 - buf); } else if (p[1] == 'S') diff --git a/src/fileio.c b/src/fileio.c index b1f9d3c..1498882 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -1718,7 +1718,7 @@ those `/' is discarded. */) /* See if any variables are substituted into the string. */ - if (!NILP (Ffboundp (Qsubstitute_env_in_file_name))) + if (!NILP (Fsymbol_function (Qsubstitute_env_in_file_name))) { Lisp_Object name = (!substituted ? filename @@ -4358,7 +4358,7 @@ by calling `format-decode', which see. */) if (set_coding_system) Vlast_coding_system_used = coding_system; - if (! NILP (Ffboundp (Qafter_insert_file_set_coding))) + if (! NILP (Fsymbol_function (Qafter_insert_file_set_coding))) { insval = call2 (Qafter_insert_file_set_coding, make_number (inserted), visit); @@ -4551,7 +4551,7 @@ choose_write_coding_system (Lisp_Object start, Lisp_Object end, Lisp_Object file { val = Vcoding_system_for_write; if (coding_system_require_warning - && !NILP (Ffboundp (Vselect_safe_coding_system_function))) + && !NILP (Fsymbol_function (Vselect_safe_coding_system_function))) /* Confirm that VAL can surely encode the current region. */ val = call5 (Vselect_safe_coding_system_function, start, end, list2 (Qt, val), @@ -4610,7 +4610,7 @@ choose_write_coding_system (Lisp_Object start, Lisp_Object end, Lisp_Object file } if (!force_raw_text - && !NILP (Ffboundp (Vselect_safe_coding_system_function))) + && !NILP (Fsymbol_function (Vselect_safe_coding_system_function))) { /* Confirm that VAL can surely encode the current region. */ val = call5 (Vselect_safe_coding_system_function, diff --git a/src/fns.c b/src/fns.c index 270dfb4..7a34d95 100644 --- a/src/fns.c +++ b/src/fns.c @@ -4917,7 +4917,7 @@ secure_hash (Lisp_Object algorithm, Lisp_Object object, Lisp_Object start, } if (!force_raw_text - && !NILP (Ffboundp (Vselect_safe_coding_system_function))) + && !NILP (Fsymbol_function (Vselect_safe_coding_system_function))) /* Confirm that VAL can surely encode the current region. */ coding_system = call4 (Vselect_safe_coding_system_function, make_number (b), make_number (e), diff --git a/src/gtkutil.c b/src/gtkutil.c index 88e6d30..6b7d187 100644 --- a/src/gtkutil.c +++ b/src/gtkutil.c @@ -4818,7 +4818,7 @@ update_frame_tool_bar (struct frame *f) } specified_file = file_for_image (image); - if (!NILP (specified_file) && !NILP (Ffboundp (Qx_gtk_map_stock))) + if (!NILP (specified_file) && !NILP (Fsymbol_function (Qx_gtk_map_stock))) stock = call1 (Qx_gtk_map_stock, specified_file); if (CONSP (stock)) diff --git a/src/keyboard.c b/src/keyboard.c index 653f527..b87bd83 100644 --- a/src/keyboard.c +++ b/src/keyboard.c @@ -1353,7 +1353,7 @@ command_loop_1 (void) /* If it has changed current-menubar from previous value, really recompute the menubar from the value. */ if (! NILP (Vlucid_menu_bar_dirty_flag) - && !NILP (Ffboundp (Qrecompute_lucid_menubar))) + && !NILP (Fsymbol_function (Qrecompute_lucid_menubar))) call0 (Qrecompute_lucid_menubar); Vthis_command = Qnil; @@ -8697,7 +8697,7 @@ access_keymap_keyremap (Lisp_Object map, Lisp_Object key, Lisp_Object prompt, /* Handle a symbol whose function definition is a keymap or an array. */ - if (SYMBOLP (next) && !NILP (Ffboundp (next)) + if (SYMBOLP (next) && !NILP (Fsymbol_function (next)) && (ARRAYP (XSYMBOL (next)->function) || KEYMAPP (XSYMBOL (next)->function))) next = Fautoload_do_load (XSYMBOL (next)->function, next, Qnil); diff --git a/src/lisp.h b/src/lisp.h index e0eb52a..fba56a4 100644 --- a/src/lisp.h +++ b/src/lisp.h @@ -4680,7 +4680,7 @@ maybe_gc (void) INLINE bool functionp (Lisp_Object object) { - if (SYMBOLP (object) && !NILP (Ffboundp (object))) + if (SYMBOLP (object) && !NILP (Fsymbol_function (object))) { object = Findirect_function (object, Qt); diff --git a/src/lread.c b/src/lread.c index ecd4827..6cd3b5a 100644 --- a/src/lread.c +++ b/src/lread.c @@ -1344,7 +1344,7 @@ Return t if the file exists and loads successfully. */) unbind_to (count, Qnil); /* Run any eval-after-load forms for this file. */ - if (!NILP (Ffboundp (Qdo_after_load_evaluation))) + if (!NILP (Fsymbol_function (Qdo_after_load_evaluation))) call1 (Qdo_after_load_evaluation, hist_file_name) ; xfree (saved_doc_string); @@ -1787,7 +1787,7 @@ readevalloop (Lisp_Object readcharfun, bool first_sexp = 1; Lisp_Object macroexpand = intern ("internal-macroexpand-for-load"); - if (NILP (Ffboundp (macroexpand)) + if (NILP (Fsymbol_function (macroexpand)) /* Don't macroexpand in .elc files, since it should have been done already. We actually don't know whether we're in a .elc file or not, so we use circumstantial evidence: .el files normally go through @@ -1828,7 +1828,7 @@ readevalloop (Lisp_Object readcharfun, /* Try to ensure sourcename is a truename, except whilst preloading. */ if (NILP (Vpurify_flag) && !NILP (sourcename) && !NILP (Ffile_name_absolute_p (sourcename)) - && !NILP (Ffboundp (Qfile_truename))) + && !NILP (Fsymbol_function (Qfile_truename))) sourcename = call1 (Qfile_truename, sourcename) ; LOADHIST_ATTACH (sourcename); diff --git a/src/minibuf.c b/src/minibuf.c index 57eea05..ee6b435 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -672,7 +672,7 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, bset_keymap (current_buffer, map); /* Turn on an input method stored in INPUT_METHOD if any. */ - if (STRINGP (input_method) && !NILP (Ffboundp (Qactivate_input_method))) + if (STRINGP (input_method) && !NILP (Fsymbol_function (Qactivate_input_method))) call1 (Qactivate_input_method, input_method); run_hook (Qminibuffer_setup_hook); @@ -801,7 +801,7 @@ get_minibuffer (EMACS_INT depth) reset_buffer (XBUFFER (buf)); record_unwind_current_buffer (); Fset_buffer (buf); - if (!NILP (Ffboundp (intern ("minibuffer-inactive-mode")))) + if (!NILP (Fsymbol_function (intern ("minibuffer-inactive-mode")))) call0 (intern ("minibuffer-inactive-mode")); else Fkill_all_local_variables (); diff --git a/src/process.c b/src/process.c index bdbdefa..4189e45 100644 --- a/src/process.c +++ b/src/process.c @@ -3088,7 +3088,7 @@ finish_after_tls_connection (Lisp_Object proc) Lisp_Object contact = p->childp; Lisp_Object result = Qt; - if (!NILP (Ffboundp (Qnsm_verify_connection))) + if (!NILP (Fsymbol_function (Qnsm_verify_connection))) result = call3 (Qnsm_verify_connection, proc, Fplist_get (contact, QChost), diff --git a/src/syntax.c b/src/syntax.c index f8d987b..260ea92 100644 --- a/src/syntax.c +++ b/src/syntax.c @@ -1455,7 +1455,7 @@ scan_words (register ptrdiff_t from, register EMACS_INT count) /* Now CH0 is a character which begins a word and FROM is the position of the next character. */ func = CHAR_TABLE_REF (Vfind_word_boundary_function_table, ch0); - if (! NILP (Ffboundp (func))) + if (! NILP (Fsymbol_function (func))) { pos = call2 (func, make_number (from - 1), make_number (end)); if (INTEGERP (pos) && from < XINT (pos) && XINT (pos) <= ZV) @@ -1505,7 +1505,7 @@ scan_words (register ptrdiff_t from, register EMACS_INT count) /* Now CH1 is a character which ends a word and FROM is the position of it. */ func = CHAR_TABLE_REF (Vfind_word_boundary_function_table, ch1); - if (! NILP (Ffboundp (func))) + if (! NILP (Fsymbol_function (func))) { pos = call2 (func, make_number (from), make_number (beg)); if (INTEGERP (pos) && BEGV <= XINT (pos) && XINT (pos) < from) diff --git a/src/xdisp.c b/src/xdisp.c index 14d6f8f..b6e8cf8 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -10116,7 +10116,7 @@ message_dolog (const char *m, ptrdiff_t nbytes, bool nlflag, bool multibyte) bool newbuffer = NILP (Fget_buffer (Vmessages_buffer_name)); Fset_buffer (Fget_buffer_create (Vmessages_buffer_name)); if (newbuffer - && !NILP (Ffboundp (intern ("messages-buffer-mode")))) + && !NILP (Fsymbol_function (intern ("messages-buffer-mode")))) call0 (intern ("messages-buffer-mode")); bset_undo_list (current_buffer, Qt); diff --git a/src/xfaces.c b/src/xfaces.c index 0a1315d..145c8ea 100644 --- a/src/xfaces.c +++ b/src/xfaces.c @@ -844,7 +844,7 @@ tty_lookup_color (struct frame *f, Lisp_Object color, XColor *tty_color, { Lisp_Object frame, color_desc; - if (!STRINGP (color) || NILP (Ffboundp (Qtty_color_desc))) + if (!STRINGP (color) || NILP (Fsymbol_function (Qtty_color_desc))) return false; XSETFRAME (frame, f); @@ -875,7 +875,7 @@ tty_lookup_color (struct frame *f, Lisp_Object color, XColor *tty_color, a standard color, we just give up and use TTY_COLOR. */ if ((!STRINGP (XCAR (color_desc)) || NILP (Fstring_equal (color, XCAR (color_desc)))) - && !NILP (Ffboundp (Qtty_color_standard_values))) + && !NILP (Fsymbol_function (Qtty_color_standard_values))) { /* Look up STD_COLOR separately. */ rgb = call1 (Qtty_color_standard_values, color); @@ -964,7 +964,7 @@ defined_color (struct frame *f, const char *color_name, XColor *color_def, Lisp_Object tty_color_name (struct frame *f, int idx) { - if (idx >= 0 && !NILP (Ffboundp (Qtty_color_by_index))) + if (idx >= 0 && !NILP (Fsymbol_function (Qtty_color_by_index))) { Lisp_Object frame; Lisp_Object coldesc; -- 2.7.4 --=-=-=-- From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 16:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Cochran , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146834001629560 (code B ref 23957); Tue, 12 Jul 2016 16:14:02 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 16:13:36 +0000 Received: from localhost ([127.0.0.1]:48576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN0JT-0007gi-Rf for submit@debbugs.gnu.org; Tue, 12 Jul 2016 12:13:36 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:32409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN0JS-0007gR-Bb for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 12:13:34 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CGDQuF004029 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 16:13:26 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u6CGDQa6001392 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 16:13:26 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u6CGDPM7025481; Tue, 12 Jul 2016 16:13:25 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 12 Jul 2016 16:13:25 +0000 (UTC) From: Drew Adams References: <87k2gr49lp.fsf@cochranmail.com> In-Reply-To: <87k2gr49lp.fsf@cochranmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) Why would we do this? It is not backward compatible, since `fboundp' returns t if there is a function value and `symbol-function' returns that function value. This will break any code that depends on getting t or nil. What is the point of this "fix"? From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 17:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams , Robert Cochran , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.14683452245465 (code B ref 23957); Tue, 12 Jul 2016 17:41:01 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 17:40:24 +0000 Received: from localhost ([127.0.0.1]:48611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN1fT-0001Q5-MV for submit@debbugs.gnu.org; Tue, 12 Jul 2016 13:40:23 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:33614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN1fS-0001Pr-NQ for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 13:40:23 -0400 Received: by mail-lf0-f52.google.com with SMTP id b199so20129248lfe.0 for <23957@debbugs.gnu.org>; Tue, 12 Jul 2016 10:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=m52CkeFmQXbUPiDHK0AVPpERo5cdNwyAgfgbfqsPsCE=; b=Zc2Y901nwLKGjD3HBpGEgbuT/ITR1lJlcO4C43XvpNI/ShLEGII5NTePf5EfgK2Ah6 fdPlomoMgaFCHBd5o0/C33OdsaUOs1jgDAdLp8RsiDm2qgHIE6ma4jG8NvE1fHCkOvQI JhrrInnyinbs7ad5EZIwH4AqPKXKLYF+AteRSKtczP1adq5+HxSaTqPgHe8m+v2ym6ah ajOrxC4XowLjcm4x1Nx/4upmsADVoIiva4eIshbfvBaWZlZQrU7F4oZ2sj6Gamu9RvHq ZH2kmWeWMHc/YBR/psRlWrONbqUQIm1AEoTMlpBMKyrbS9r738Rhdlj5ncK4EEq8w343 WwFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=m52CkeFmQXbUPiDHK0AVPpERo5cdNwyAgfgbfqsPsCE=; b=Wm6HqazFoylW2AdBljeMy+BZIEUyUCQWzradVbvGEYl4FRN0624cBYNtFghpbfJ33J rE8hxDGPa8McsOqIPK8Yxl8Q9vO70pfJzwDiSN6lK8JS9msPqIDA46K7SmA73ef2KeJ1 WNizmeax5jn8CldTUtrQaoTVAkbvxQQjbPZ8Pnmc44PXt6CzW5OWNMKQgewIfln4dijm b5JpQqep4CwEA2H17TEAkvV1WRuCh9QXq2y1GEqu8tzQtpwRq3WIA6A5MdZ3qafYqrQS P2hgp1j+YQBg2Qu1cfcPvGWK8u5nz6nH7Q9FD0Cv5SFWDhr9ZvHzFMn8pgHGnvQYQKtz 6IEQ== X-Gm-Message-State: ALyK8tJMf4Wv/wHdLw/rNsa0LKcgkXDQI9OUOdgzxDUR6ggY8Wj/r/tZZCBO+B4xVqA6KcLfZKlTOpuqqMkvWQ== X-Received: by 10.25.33.194 with SMTP id h185mr1861589lfh.110.1468345216799; Tue, 12 Jul 2016 10:40:16 -0700 (PDT) MIME-Version: 1.0 References: <87k2gr49lp.fsf@cochranmail.com> In-Reply-To: From: Philipp Stephani Date: Tue, 12 Jul 2016 17:40:06 +0000 Message-ID: Content-Type: multipart/alternative; boundary=001a114013b20e1bc5053773c37c X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --001a114013b20e1bc5053773c37c Content-Type: text/plain; charset=UTF-8 Drew Adams schrieb am Di., 12. Juli 2016 um 18:14 Uhr: > It is not backward compatible, since `fboundp' returns t if > there is a function value and `symbol-function' returns that > function value. This will break any code that depends on > getting t or nil. > And the docstring of `fboundp' does specify that it returns t (not just non-nil), so this is indeed a breaking chance. I'd suggest to simply remove the FIXME instead. --001a114013b20e1bc5053773c37c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


Drew A= dams <drew.adams@oracle.com= > schrieb am Di., 12. Juli 2016 um 18:14=C2=A0Uhr:
It is not backward compatible, since `fboundp' retur= ns t if
there is a function value and `symbol-function' returns that
function value.=C2=A0 This will break any code that depends on
getting t or nil.

And the docstring of `fboundp' does sp= ecify that it returns t (not just non-nil), so this is indeed a breaking ch= ance.

I'd suggest to simply remove the FIXME i= nstead.=C2=A0
--001a114013b20e1bc5053773c37c-- From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 17:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.14683457786380 (code B ref 23957); Tue, 12 Jul 2016 17:50:02 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 17:49:38 +0000 Received: from localhost ([127.0.0.1]:48624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN1oQ-0001eq-7r for submit@debbugs.gnu.org; Tue, 12 Jul 2016 13:49:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:31121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN1oO-0001eZ-Ai for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 13:49:36 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CHnSYe008767 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 17:49:29 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u6CHnSWL007553 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 17:49:28 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u6CHnHRZ030571; Tue, 12 Jul 2016 17:49:28 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 12 Jul 2016 17:49:17 +0000 (UTC) From: Drew Adams References: <87k2gr49lp.fsf@cochranmail.com> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > And the docstring of `fboundp' does specify that it returns t > (not just non-nil), so this is indeed a breaking chance. Yes, I meant to add that. Thx. > I'd suggest to simply remove the FIXME instead. I'd be somewhat curious about who wrote it and why. Maybe there is something else that could be done to satisfy whatever the perceived need was. From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 19:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835072321788 (code B ref 23957); Tue, 12 Jul 2016 19:13:02 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 19:12:03 +0000 Received: from localhost ([127.0.0.1]:48695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN36B-0005fM-2l for submit@debbugs.gnu.org; Tue, 12 Jul 2016 15:12:03 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:32997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN369-0005eo-9o for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 15:12:01 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=JduiYtD6NKnjC+qXhZY0B3Gulo4=; b=ycU1+ PUM22klu4URh4JvGKi2jsXbWSYIkNZrguzthuV1Mu0iLrHx7m8nEojycobsO7k31 XaYnLPpE9K1G8Yazo2Grg2etyuhxCZ3uc13VKWB1jPhJSY+TL9+Gdh8FUDzncr+E Kc1pRltFfBNAlrIds9GE6o7LwbgmbgsZFSCjdDRg7LiKFS0E/e55J5FEREl5IdNI ejTSZ5z/mXn3bE7PXaYRz+M9zoCPYkex6S0xGO6T31UFgYft0Rhml1BdwVN7ODeD JqL3lBNCMnfI1WL892oEqHpwEOuSGpCtPcinfjtcc/UlbIoAscDOhjlYz3cDUvLM /PKD5UnJTLgq4bNOQ== Received: (qmail 9195 invoked by uid 0); 12 Jul 2016 19:11:57 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=mTFntIG71Iquj892AZNJ5Q9zzJRGCJzmi3N9gCNo4q1yqWiI/nNvHSOy1shV4E9vR+gyxYeqHETpLY50k4i9Yw==; Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 19:11:57 -0000 From: Robert Cochran References: <87k2gr49lp.fsf@cochranmail.com> Date: Tue, 12 Jul 2016 12:11:53 -0700 In-Reply-To: (Drew Adams's message of "Tue, 12 Jul 2016 17:49:17 +0000 (UTC)") Message-ID: <87eg6yvfgm.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) I didn't put too much thought into reading the FIXME; I figured that someone smarter than myself knew what they were doing when requesting the change. I'd personally argue that anyone making an explicit check for t, or anything that particularly needs t rather than any true value is just asking for lossage, but I can see why people would disagree with that assertion. FWIW, In every placed I changed occurrences of fboundp to symbol-function, both in Lisp and C, used only the truthiness of the return rather than explicitly checking for t. I also ran the test suite with and without my patch applied, and noticed no difference in the number of failing tests. Anyways, I'm willing to toss this patch and do something else if that is the general consensus. Thanks, ~Robert Cochran From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Sora Firestorm Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org, Stefan Monnier Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835193123889 (code B ref 23957); Tue, 12 Jul 2016 19:33:01 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 19:32:11 +0000 Received: from localhost ([127.0.0.1]:48739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3Pe-0006DE-I6 for submit@debbugs.gnu.org; Tue, 12 Jul 2016 15:32:10 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:33028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3Eg-0005tM-Fu for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 15:20:51 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:in-reply-to:references:date:message-id:mime-version :content-type; s=dkim1; bh=YQe1YFo5f2v1LNyQGef1an1ijKo=; b=Pbox7 39n5V+16fiUbIwQ0Ist95T1bA1XOlW5bLqjqPaLm0TCM4VdnZjU8JVTUYZbhWyqW urXgZOjqAlYVxiQ/7caEcYrMWV/N7erobEuLYxkoMA6tYiHm/pNPG9usMlfXZb6c zeYs+0Vh98s5Di4Tm9MGwQJPTd2N3B6IEbG9L0yOWXwb/LNGqierJ/ESDXvjqtZU 6a42Ry+fqmahMaSqXiZorLFqetIF+mWwlyCYKfq3bMYzO/dleiXLSeV7L5wle5+Z jMxu/sU4zP8i9QO+0Us65sGi2wGtpqw0B342kYQe7nSYH0jxfJ6vlvWzM79+0OgV pcBUSuLkhFigTuXXQ== Received: (qmail 9570 invoked by uid 0); 12 Jul 2016 19:20:48 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=JJetM8kCbY64OUpv5Oe85lRcDFlgiteQcS8idhFFuLksWb9ONduf760bwPX5G6TgSwRKDDYosCLryhew7iVZqw==; Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 19:20:48 -0000 From: Sora Firestorm In-Reply-To: (Drew Adams's message of "Tue, 12 Jul 2016 17:49:17 +0000 (UTC)") References: <87k2gr49lp.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) Date: Tue, 12 Jul 2016 12:20:47 -0700 Message-ID: <8760savf1s.fsf@cochranmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 12 Jul 2016 15:32:07 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: >> I'd suggest to simply remove the FIXME instead. > > I'd be somewhat curious about who wrote it and why. Maybe > there is something else that could be done to satisfy whatever > the perceived need was. I just did a blame for that line, and it lead back to commit eadf1faa ("Conflate Qnil and Qunbound for `symbol-function'.") by Stefan Monnier (CC'd). From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 20:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Cochran Cc: Philipp Stephani , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835402927131 (code B ref 23957); Tue, 12 Jul 2016 20:08:01 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 20:07:09 +0000 Received: from localhost ([127.0.0.1]:48751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3xV-00073X-4V for submit@debbugs.gnu.org; Tue, 12 Jul 2016 16:07:09 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35809) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN3xT-00073K-TC for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 16:07:08 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CK6xhA028100 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 20:06:59 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u6CK6xoL000516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 20:06:59 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u6CK6wbI029597; Tue, 12 Jul 2016 20:06:58 GMT MIME-Version: 1.0 Message-ID: <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> Date: Tue, 12 Jul 2016 20:06:54 +0000 (UTC) From: Drew Adams References: <87k2gr49lp.fsf@cochranmail.com> <87eg6yvfgm.fsf@cochranmail.com> In-Reply-To: <87eg6yvfgm.fsf@cochranmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > I didn't put too much thought into reading the FIXME; Nor did I. ;-) > I figured that someone smarter than myself knew what they were > doing when requesting the change. Yes, no doubt s?he had a good reason. Or at least a reason. But apparently it was not recorded, so we can only wonder or guess. My guess is that the person just figured that, like `member', people can use `symbol-function' as a general Boolean - which is true. But `fboundp' has been around forever, and there is no telling what code might expect its value to be either `t' or `nil'. And if someone really wants to use `symbol-function' to either get the function or test whether there is one, s?he can already do that. > I'd personally argue that anyone making an explicit check for t, or > anything that particularly needs t rather than any true value is just > asking for lossage, but I can see why people would disagree with that > assertion. It doesn't matter what we might think of such a check. The point is that such checks might exist, and there is really no good reason (that I can see) for breaking such code. Again: anyone can already use `symbol-function' to get the desired effect, and its name speaks much better to the combined behavior desired in that case. > FWIW, In every placed I changed occurrences of fboundp to > symbol-function, both in Lisp and C, used only the truthiness > of the return rather than explicitly checking for t. That's irrelevant (IMO). The code that GNU distributes with Emacs is but a small part of the Emacs-Lisp code that is out there. > I also ran the test suite with and without my patch applied, > and noticed no difference in the number of failing tests. Again - you were testing in the tiny GNU Emacs distributed-code sandbox. The Emacs world is a much bigger box. > Anyways, I'm willing to toss this patch and do something else > if that is the general consensus. I can't speak for the consensus, but that would be my hope. And thanks for pitching in! Sorry to seem so critical of a first foray into helping. From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 20:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Sora Firestorm Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org, Stefan Monnier Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835421127415 (code B ref 23957); Tue, 12 Jul 2016 20:11:01 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 20:10:11 +0000 Received: from localhost ([127.0.0.1]:48756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN40R-000786-Ka for submit@debbugs.gnu.org; Tue, 12 Jul 2016 16:10:11 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN40Q-00077u-7R for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 16:10:10 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6CKA3Ev032342 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2016 20:10:03 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u6CKA2Z6011345 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 12 Jul 2016 20:10:02 GMT Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u6CKA0Hb031075; Tue, 12 Jul 2016 20:10:00 GMT MIME-Version: 1.0 Message-ID: <7fd05844-b6aa-4c8b-9c84-97fb56acbcde@default> Date: Tue, 12 Jul 2016 20:10:00 +0000 (UTC) From: Drew Adams References: <87k2gr49lp.fsf@cochranmail.com> <8760savf1s.fsf@cochranmail.com> In-Reply-To: <8760savf1s.fsf@cochranmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > >> I'd suggest to simply remove the FIXME instead. > > > > I'd be somewhat curious about who wrote it and why. Maybe > > there is something else that could be done to satisfy whatever > > the perceived need was. >=20 > I just did a blame for that line, and it lead back to commit eadf1faa > ("Conflate Qnil and Qunbound for `symbol-function'.") by Stefan Monnier > (CC'd). Yes, well, perhaps Stefan will chime in with the reason(s) for it. But to my mind the simple action "Conflate Qnil and Qunbound for `symbol-function'" sounds like it is about doing something to `symbol-function' rather than doing something to `fboundp'. It is the behavior (hence meaning) of `fboundp' that changes if you set it as an alias for `symbol-function'. The latter's behavior does not change. From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 20:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philipp Stephani Cc: Robert Cochran , 23957@debbugs.gnu.org, Drew Adams Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146835574829909 (code B ref 23957); Tue, 12 Jul 2016 20:36:01 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 20:35:48 +0000 Received: from localhost ([127.0.0.1]:48783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN4PD-0007mL-RB for submit@debbugs.gnu.org; Tue, 12 Jul 2016 16:35:47 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN4PC-0007m7-33 for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 16:35:46 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CtCwA731xV/3mcpUVcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEBBgEBAQEeizqFBQeELQWzP4FFI2GDMyKCeAEBAQ X-IPAS-Result: A0CtCwA731xV/3mcpUVcgxCEAsEMCYdLBAICgTw5FAEBAQEBAQGBCkEFg10BAQMBViMFCwsOJhIUGA0kiDcIzyMBAQEBBgEBAQEeizqFBQeELQWzP4FFI2GDMyKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247628100" Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 12 Jul 2016 16:35:41 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7D8E164405; Tue, 12 Jul 2016 16:35:40 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87k2gr49lp.fsf@cochranmail.com> Date: Tue, 12 Jul 2016 16:35:40 -0400 In-Reply-To: (Philipp Stephani's message of "Tue, 12 Jul 2016 17:40:06 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > And the docstring of `fboundp' does specify that it returns t (not just > non-nil), so this is indeed a breaking chance. > I'd suggest to simply remove the FIXME instead. FWIW, the reason why I put a FIXME instead of making this change, is that I wasn't sure indeed exactly how to make such a change. I expect 99% of the uses of fboundp don't care about the distinction between t and other non-nil values. And at least 90% of the remaining 1% is probably ill-advised to rely on this distinction. But the benefit of redefining fboundp as an alias rather than as its own function is probably too small to justify risking such breakage. Stefan From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 23:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Drew Adams Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146836459611538 (code B ref 23957); Tue, 12 Jul 2016 23:04:02 +0000 Received: (at 23957) by debbugs.gnu.org; 12 Jul 2016 23:03:16 +0000 Received: from localhost ([127.0.0.1]:48888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN6hv-000302-RE for submit@debbugs.gnu.org; Tue, 12 Jul 2016 19:03:16 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:34093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN6hu-0002zs-1c for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 19:03:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=AB5OfXVpdiFWLiatEtf6QgRG5FQ=; b=mrApZ v55lCRiHvzoXEDcc651fYeDiTXtcLnYY17PccTNcj/ViNmPcctsuV83YZBAV8sY7 tfAANwpY1TGGmed96wsXgH+JzT7Sd5uyWb8fkwzqlrsW7YM1Gop/s44FGWoIV/kO k7jKbnrQ5AuozffGU5uXmngA7y5mjRxbGLh2hEfpIIB6seUSWDWGAU1IdomTTPZx axdhuh38/KfeNLI8W8+EO8AZKhokISHaiVyzKqPjYqp/q0+nkpNPKsUvAFVNs1UW GjvJNLHWwDAIgw7JDwupZXiycLXS3R89ti2vFh6ZXeGI+9tQAWViLDQ6/AGzBUs4 +0Uq6blySZcxts1gQ== Received: (qmail 19250 invoked by uid 0); 12 Jul 2016 23:03:11 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=DxPqJ3lSntjreTVMriLLhpSw69OHsqwEAti+RLexnWfFgIp7YSRH2DREECh3mzP+DSPqJUXE4v6m0oWe2mzMbQ==; Received: from 74-93-99-217-washington.hfc.comcastbusiness.net (HELO SoraLaptop) (robert@cochranmail.com@74.93.99.217) by mail.cochrantribe.org with ESMTPA; 12 Jul 2016 23:03:11 -0000 From: Robert Cochran References: <87k2gr49lp.fsf@cochranmail.com> <87eg6yvfgm.fsf@cochranmail.com> <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> Date: Tue, 12 Jul 2016 16:02:57 -0700 In-Reply-To: <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> (Drew Adams's message of "Tue, 12 Jul 2016 20:06:54 +0000 (UTC)") Message-ID: <87d1miqx26.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: >> I'd personally argue that anyone making an explicit check for t, or >> anything that particularly needs t rather than any true value is just >> asking for lossage, but I can see why people would disagree with that >> assertion. > > It doesn't matter what we might think of such a check. The point > is that such checks might exist, and there is really no good > reason (that I can see) for breaking such code. Again: anyone > can already use `symbol-function' to get the desired effect, and > its name speaks much better to the combined behavior desired in > that case. >> FWIW, In every placed I changed occurrences of fboundp to >> symbol-function, both in Lisp and C, used only the truthiness >> of the return rather than explicitly checking for t. > > That's irrelevant (IMO). The code that GNU distributes with > Emacs is but a small part of the Emacs-Lisp code that is out > there. > >> I also ran the test suite with and without my patch applied, >> and noticed no difference in the number of failing tests. > > Again - you were testing in the tiny GNU Emacs distributed-code > sandbox. The Emacs world is a much bigger box. Fair enough. I was never going to cast a net big enough to hit everything. I agree with Stefan that most functions will be behave fine in the face of the change, but given his hesitation, I'm not going to push it. You guys know better than I do. >> Anyways, I'm willing to toss this patch and do something else >> if that is the general consensus. > > I can't speak for the consensus, but that would be my hope. And > thanks for pitching in! Sorry to seem so critical of a first foray > into helping. Nah, don't worry about. I was expecting /something/ to snag my patch. You clearly expressed your concerns about my changes, and we were able to discuss and be civil. Best I can ask for, really. In the end, I'll end up doing a cleanup of some sort, even if all that is is removing the FIXME. I've been hearing about how there are less and less people that understand the C core of Emacs, so I'm aiming to help by becoming one of those people. Barring any extreme levels of inter-personal friction in getting things accomplished, I'm hopefully just getting started with this. Thanks, ~Robert Cochran From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2016 02:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Cochran Cc: Philipp Stephani , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146837610228624 (code B ref 23957); Wed, 13 Jul 2016 02:16:02 +0000 Received: (at 23957) by debbugs.gnu.org; 13 Jul 2016 02:15:02 +0000 Received: from localhost ([127.0.0.1]:48920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN9hV-0007RV-RW for submit@debbugs.gnu.org; Tue, 12 Jul 2016 22:15:02 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:42314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bN9hU-0007R4-EK for 23957@debbugs.gnu.org; Tue, 12 Jul 2016 22:15:00 -0400 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u6D2Eq2J014014 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2016 02:14:53 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u6D2Eqou017412 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2016 02:14:52 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u6D2EpUm028350; Wed, 13 Jul 2016 02:14:52 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 12 Jul 2016 19:14:50 -0700 (PDT) From: Drew Adams References: <87k2gr49lp.fsf@cochranmail.com> <87eg6yvfgm.fsf@cochranmail.com> <382b03a2-dac4-4459-96ba-c8bdbe02ae57@default> <87d1miqx26.fsf@cochranmail.com> In-Reply-To: <87d1miqx26.fsf@cochranmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0021.oracle.com [156.151.31.71] X-Spam-Score: -3.6 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > I've been hearing about how there are less and less people that > understand the C core of Emacs, so I'm aiming to help by becoming one of > those people. Barring any extreme levels of inter-personal friction in > getting things accomplished, I'm hopefully just getting started with > this. That is excellent. There are some really knowledgeable and experienced Emacs C developers here (who are likewise for Emacs Lisp development). I expect it would be a great project and a great way to learn, to help with this. There are also others who, like yourself, are tackling this fresh. Thank you. From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2016 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Philipp Stephani , Robert Cochran , 23957@debbugs.gnu.org, Drew Adams Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.146838811920922 (code B ref 23957); Wed, 13 Jul 2016 05:36:02 +0000 Received: (at 23957) by debbugs.gnu.org; 13 Jul 2016 05:35:19 +0000 Received: from localhost ([127.0.0.1]:48964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNCpL-0005RN-Ea for submit@debbugs.gnu.org; Wed, 13 Jul 2016 01:35:19 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:35005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNCpJ-0005RD-8m for 23957@debbugs.gnu.org; Wed, 13 Jul 2016 01:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=FshmmNFUfc0VqRmjrus3R30o34M=; b=sPR6F 6qb+HN1jKaUtZF1rWiPSvdZX/ijXTPOpnDdweGmEM85mSR1zijjc5XjJj3ITOkUY V50ZeN7JE1TId9j/EVuFHPs28lJQAtINzthmq3uKO/gX/LOPoNNLspvea6QJKJTP FY3TKiBWX7f6zh4RmD5THGfOg3oPtzQsLy3UNaZz8sopuMJrOpuVc4Xbh22hOKru YN77XthRKlnGqcvDuIsT08a1PrLwLKfmnbaDyqpaG6aqMk7j73Q4/eZAU9XVhtts g6iDGDtOlEm1MentpGj6ar5c1DI+Wa52sgwYcANZjV544FbFPiC0oE24sUnF4N+5 N1fxwCUqYbhV5viSw== Received: (qmail 28355 invoked by uid 0); 13 Jul 2016 05:35:14 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=Fr9seYbhkqWuPZzAKRHRw9/SjBp98Xoj7IqVv3lsXYctTM0OEFv/sCw+ZD+zImttcrZJKUNCgDoV3VqKX+PpUA==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 13 Jul 2016 05:35:14 -0000 From: Robert Cochran References: <87k2gr49lp.fsf@cochranmail.com> Date: Tue, 12 Jul 2016 22:35:08 -0700 In-Reply-To: (Stefan Monnier's message of "Tue, 12 Jul 2016 16:35:40 -0400") Message-ID: <87twfuumlv.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > I expect 99% of the uses of fboundp don't care about the distinction > between t and other non-nil values. And at least 90% of the remaining > 1% is probably ill-advised to rely on this distinction. But the benefit > of redefining fboundp as an alias rather than as its own function is > probably too small to justify risking such breakage. So then, is it generally agreed upon that I submit a new patch that merely strips the FIXME, or does this need more discussion? Trying to make sure I'm not jumping the gun by confirming before I do so. Thanks, ~Robert Cochran From unknown Fri Aug 15 18:09:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23957: [PATCH] Make fboundp an alias for symbol-function Resent-From: Robert Cochran Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jul 2016 22:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23957 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Cochran Cc: Philipp Stephani , Stefan Monnier , Drew Adams , 23957@debbugs.gnu.org Received: via spool by 23957-submit@debbugs.gnu.org id=B23957.14685368344416 (code B ref 23957); Thu, 14 Jul 2016 22:54:02 +0000 Received: (at 23957) by debbugs.gnu.org; 14 Jul 2016 22:53:54 +0000 Received: from localhost ([127.0.0.1]:51847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNpVx-00019A-QD for submit@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:53 -0400 Received: from mail.workgrouplinux.net ([207.195.177.82]:40972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNpVv-00018v-TG for 23957@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:52 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=simple; d=cochranmail.com; h=from:to :cc:subject:references:date:in-reply-to:message-id:mime-version :content-type; s=dkim1; bh=ndnUipGcZXwXzvWhjzzm+Fc4lWY=; b=EGuzl 94qU2UgI+q2xdO8sattCvt/ZkUD34/2HCrC4g82Hh21pRdqHQ875t61wqRBEYupo eceF82DawjUJmu6EdO80I2yk6mX2gBncQxnYubusZQN/9VzN1WgUz39YPJd5mlaT OuVpRIaLhpraRwYa5bycC+XfnLBJ4m8zW0EDj1HzqpOR/oBglIuWO53ssbLPhZF+ fFLtDPOJPHCvu38Q8DsDHNFXTItXaaFq/1J/rPEL3x1zFA+QCmTQduVHGJNg2rE9 pU9/oCNR+2tzh6jpxpWY/dukmHmO4f3PPI5psG2mDkBMEQMaA/xEIhrYx2gs9zFL GmrogE8lA/zHQ054g== Received: (qmail 17527 invoked by uid 0); 14 Jul 2016 22:53:49 -0000 Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=private; d=cochranmail.com; b=DJzv14PA7lWrwlwnNmjG+irsCIZpn0VxqdLsHft1EaGffGzQ7RaJ43qewInZLMEuO9b111cqZ1g4geHNPmGfuw==; Received: from 131-191-86-130.as.clicknet.org (HELO SoraLaptop) (robert@cochranmail.com@131.191.86.130) by mail.cochrantribe.org with ESMTPA; 14 Jul 2016 22:53:49 -0000 From: Robert Cochran References: <87k2gr49lp.fsf@cochranmail.com> <87twfuumlv.fsf@cochranmail.com> Date: Thu, 14 Jul 2016 15:53:48 -0700 In-Reply-To: <87twfuumlv.fsf@cochranmail.com> (Robert Cochran's message of "Tue, 12 Jul 2016 22:35:08 -0700") Message-ID: <87inw7q1ab.fsf@cochranmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Submitted a patch to remove the FIXME as Bug#23988 ~Robert Cochran From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 14 18:53:21 2016 Received: (at control) by debbugs.gnu.org; 14 Jul 2016 22:53:21 +0000 Received: from localhost ([127.0.0.1]:51844 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNpVR-00018A-GD for submit@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNpVQ-00017r-6j for control@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNpVK-0005Jg-Eq for control@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNpVK-0005JL-BX for control@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:14 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bNpVI-00034B-UE for control@debbugs.gnu.org; Thu, 14 Jul 2016 18:53:13 -0400 Subject: control message for bug 23988 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Thu, 14 Jul 2016 18:53:12 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) forcemerge 23957 23988 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 16 21:44:19 2016 Received: (at control) by debbugs.gnu.org; 17 Jul 2016 01:44:19 +0000 Received: from localhost ([127.0.0.1]:54148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOb7z-0006ar-8F for submit@debbugs.gnu.org; Sat, 16 Jul 2016 21:44:19 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:33401) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOb7x-0006ac-97; Sat, 16 Jul 2016 21:44:17 -0400 Received: by mail-io0-f195.google.com with SMTP id y195so8788752iod.0; Sat, 16 Jul 2016 18:44:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=S1YReBV9Nsk1cIm9FRkvBwnVX3ZVmk89CS12FagxFm0=; b=xT9YU+TUP/IoucFhDh2GkIwp9vfGYaYBUgdOo3qu269Oexxt+RuzqLEJhgGrzYPW5Q CSCJirsAD0B9kYoLM4vx4OmfAyrNS+soz0ZTDnzN/sHLafUDJJfQA9tkTqh9qa+2iTMV vjMaNpnbEI3UbOcOHcDKelueOc+KChqX3tPLqAiQP1+EbhPi+3ZA6DwE30FT+IeUxMhQ PS7czgqMGTTaRzPw36K8dd2t4awdSILIzDl7jALw1fI6dYxHMiZurJoPcJyJhhOad6Ft swb//4UO+7aiD5aRT0MMkHPsZ2BUJgnWYx7iYjQyrmGbcn7q0DhIBvrKmBHbeQI3Babp Mwcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=S1YReBV9Nsk1cIm9FRkvBwnVX3ZVmk89CS12FagxFm0=; b=YEFsd1ThYPMIl9QwXmDBD06eFKUgpwa7EtlgI5PFBbB8XRZ31Wo7JJSSuc15Ic/c+h WwKQ5UIybsHUfVZdCUqfNPTaEWWWIlUqXVi05GhepPiAE7sSBTWAlyvoLlPpYalmhvcb y1ugxwvJtfrNzIK0el1230tnFqLEyxnTUkbRwromCi2IVbWH+U0xdY9BvzH8DF4lY+Dh qURHVqUctthq4M0/Sog5dfyOMcsDM3gTcLurNqhGEarj9e6Wp2pSp0bfFjRi/S+4s3C3 9iR4O5f/kHRFq1c0Ddd8nd5wfALLP6J6Z5/pOZ/lXF8st4ZhEBvnQh7JbvxMjly8bWYC QVaQ== X-Gm-Message-State: ALyK8tKWaHn6hB2rVILZb5vds0tXRm2XxZyGpXC1m5DEpGVV7EFB5A5+yy+3/8gWXgYnIg== X-Received: by 10.107.22.6 with SMTP id 6mr27801375iow.128.1468719851837; Sat, 16 Jul 2016 18:44:11 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id q84sm2037651itd.16.2016.07.16.18.44.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Jul 2016 18:44:11 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function References: <871t2vrg1q.fsf@cochranmail.com> <83lh1374ry.fsf@gnu.org> <87zipik7f9.fsf@cochranmail.com> <83r3au5aw5.fsf@gnu.org> Date: Sat, 16 Jul 2016 21:44:11 -0400 In-Reply-To: <83r3au5aw5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2016 09:56:26 +0300") Message-ID: <878tx1dono.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control Cc: 23988@debbugs.gnu.org, Robert Cochran X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 23988 fixed close 23988 25.1 quit Eli Zaretskii writes: >> From: Robert Cochran >> Cc: Robert Cochran , 23988@debbugs.gnu.org >> Date: Fri, 15 Jul 2016 12:50:02 -0700 >> >> That's a good point. I have attached a new patch that summarizes the >> discussion. > > LGTM, thanks. Can someone please push this to the emacs-25 branch? Pushed as 9356fe2 (fixed a missing double space). I marked as "Copyright-paperwork-exempt: yes", since in the Bug #23957 Robert said > I understand that the FSF requires a copyright assignment for > non-trivial patches made to Emacs [...] > I am perfectly happy to do so, but require guidance on how > to accomplish it. On that topic, how can I go about this process so that > I automatically perform the appropriate assignments for each > contribution? You can fill out the form here with program name "Emacs", and send email to the address it mentions: http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=doc/Copyright/request-assign.program;hb=HEAD You'll receive further instructions (signing a document and such).