GNU bug report logs - #23954
25.1.50; Unexpected failing test

Previous Next

Full log

Message #17 received at 23954 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 23954 <at> debbugs.gnu.org, Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#23954: 25.1.50; Unexpected failing test
Date: Thu, 21 Jul 2016 21:42:40 +0900 (JST)

On Thu, 21 Jul 2016, Glenn Morris wrote:

>
> It's bad to have persistently failing tests, because it can mask new failures.
> (eg several xref tests started failing in
> http://hydra.nixos.org/build/37558515, but there was no notification
> email due to this pre-existing failure.)
>
> So please consider applying your change to fix this.
Thanks for the replay.
> I see it is similar to what turn-on-font-lock does, so if explicitly
> turning on font-lock in this test also fixes it, that might be better.
Yeah, for our purposes it is the same: set `char-property-alias-alist'
to '((face font-lock-face)).

I am going to apply following patch:

diff --git a/test/lisp/erc/erc-track-tests.el 
b/test/lisp/erc/erc-track-tests.el
index 24dfcfb..7cf3ef7 100644
--- a/test/lisp/erc/erc-track-tests.el
+++ b/test/lisp/erc/erc-track-tests.el
@@ -24,6 +24,7 @@

 (require 'ert)
 (require 'erc-track)
+(require 'font-core)

 (ert-deftest erc-track--shorten-aggressive-nil ()
   "Test non-aggressive erc track buffer name shortening."
@@ -107,9 +108,12 @@
 (ert-deftest erc-track--erc-faces-in ()
   "`erc-faces-in' should pick up both 'face and 'font-lock-face 
properties."
   (let ((str0 "is bold")
-        (str1 "is bold")
-        ;;(char-property-alias-alist '((face font-lock-face)))
-        )
+        (str1 "is bold"))
+    ;; Turn on Font Lock mode: this initialize 
`char-property-alias-alist'
+    ;; to '((face font-lock-face)).  Note that `font-lock-mode' don't
+    ;; turn on the mode if the test is run on batch mode or if the
+    ;; buffer name starts with ?\s (Bug#23954).
+    (unless font-lock-mode (font-lock-default-function 1))
     (put-text-property 3 (length str0) 'font-lock-face
                        '(bold erc-current-nick-face) str0)
     (put-text-property 3 (length str1) 'face

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.