GNU bug report logs - #23949
25.0.95; Regression in handling error caused by (string-match-p "." nil)

Previous Next

Package: emacs;

Reported by: Kaushal Modi <kaushal.modi <at> gmail.com>

Date: Mon, 11 Jul 2016 20:13:02 UTC

Severity: normal

Tags: fixed

Merged with 16294, 24166

Found in versions 25.0.95, 24.3.50

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #77 received at 23949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 23949 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, kaushal.modi <at> gmail.com
Subject: Re: bug#23949: 25.0.95;
 Regression in handling error caused by (string-match-p "." nil)
Date: Wed, 13 Jul 2016 18:17:24 +0300

> From: Andreas Schwab <schwab <at> suse.de>
> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>,  23949 <at> debbugs.gnu.org,  kaushal.modi <at> gmail.com
> Date: Wed, 13 Jul 2016 17:03:22 +0200
> 
> > (defsubst string-match-p (regexp string &optional start)
> >   "\
> > Same as `string-match' except this function does not change the match data."
> >   (condition-case err
> >       (let ((inhibit-changing-match-data t))
> > 	(string-match regexp string start))
> >     (error (signal (car err) (cdr err)))))
> 
> This optimizes for the rare case that string-match throws an error.
> Better would be to bind inhibit-changing-match-data in call_debugger.

Fine, let's do that, then.

Thanks.
This bug report was last modified 8 years and 168 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.