From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 11:06:18 2016 Received: (at submit) by debbugs.gnu.org; 11 Jul 2016 15:06:18 +0000 Received: from localhost ([127.0.0.1]:46988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMcmo-0004Ni-4n for submit@debbugs.gnu.org; Mon, 11 Jul 2016 11:06:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMcmm-0004NP-PP for submit@debbugs.gnu.org; Mon, 11 Jul 2016 11:06:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMcmg-0005Ii-Uu for submit@debbugs.gnu.org; Mon, 11 Jul 2016 11:06:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMcmg-0005IX-Rg for submit@debbugs.gnu.org; Mon, 11 Jul 2016 11:06:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMcmf-0005nd-PX for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2016 11:06:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMcmZ-0005GL-Q8 for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2016 11:06:08 -0400 Received: from mail-pa0-x231.google.com ([2607:f8b0:400e:c03::231]:33206) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMcmZ-0005GC-Gp for bug-gnu-emacs@gnu.org; Mon, 11 Jul 2016 11:06:03 -0400 Received: by mail-pa0-x231.google.com with SMTP id ks6so10656342pab.0 for ; Mon, 11 Jul 2016 08:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:subject:date:message-id:mime-version; bh=UHnNd7kyehNhAHvBxMwjBnChTMcmvQyaxRSz6FazhtA=; b=HN+01CZ0VtfjYOBNK6XHI6Hr41pj8evfXeBHYEGxIhESltYngLAykqYZE3UgGOeZvC gOTUUpHaobym72tohpbm4dkGddwrg93Jumbg+tryV+6tUQgNittyaLlP/IQHsHHwxysK 7yDL9SzZWMGWSrmPBodgwJ7jgDO4qb7t6kLuI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=UHnNd7kyehNhAHvBxMwjBnChTMcmvQyaxRSz6FazhtA=; b=P8j52iV4KIwx6Svmyxns62ZSbdY/4/ng+m1SlfCyrpPVDgyV7PaGfzaCK1qdsn4i9s UEV9hC4nwI51oXUsys7MbQ6mswCZaV9zE38cgqzmQM/C0Y6not6g/XfSSseozVdWadPD L2C8PCIBEceixIZ3XQ4Qv7fdzl09HIley7w8w7wd72uhW+vIksSPCzQLn4UNClTVNOtv Fe+uGB8ww/6fg5PcYEUy3lG9QiXFBzIcucA54xzTrTxqUZMC/+APvM+mJJmwwgxzA2LJ xlZRe3gEAkkQ+1M2In9fHUWtWdrhm+85I/L229uGOtersohirPwhoSi7w6BK7AMatQkm /EaA== X-Gm-Message-State: ALyK8tLbcGg2MFPfTOTtziF6JjNRYMI5QHQq5fK3Ek8SzW2Cz30OsRNCypqmdyswgXcrJQ== X-Received: by 10.66.161.73 with SMTP id xq9mr35534284pab.6.1468249562321; Mon, 11 Jul 2016 08:06:02 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id x68sm4878234pfb.88.2016.07.11.08.05.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 08:06:00 -0700 (PDT) From: Teodor Zlatanov To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Date: Mon, 11 Jul 2016 11:05:55 -0400 Message-ID: <87k2gs8bak.fsf@lifelogs.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I've published the proposed changes to the Gnus Cloud code in the branch `scratch/gnus-cloud' and would like to request a code review. It's a single commit which I've tested over the last 2 weeks with the help of other Gnus users. I'll add documentation if the code is acceptable. Thank you Ted From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 13 10:20:34 2016 Received: (at 23945) by debbugs.gnu.org; 13 Jul 2016 14:20:34 +0000 Received: from localhost ([127.0.0.1]:49915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNL1Z-0002q7-Q4 for submit@debbugs.gnu.org; Wed, 13 Jul 2016 10:20:34 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:36369) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bNL1U-0002pq-ED for 23945@debbugs.gnu.org; Wed, 13 Jul 2016 10:20:28 -0400 Received: by mail-pf0-f172.google.com with SMTP id t190so19194384pfb.3 for <23945@debbugs.gnu.org>; Wed, 13 Jul 2016 07:20:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=zT0xtenanwI5lujmvDuGlKAytZNooDc25w7ldKUbbLo=; b=fRfucoc2Hji/Qs0Yd+uIMK9Fnp4aXSZ56CZgla8kOA9IgiY14nHcOEHDEKRRdDEpCJ Fs9rP61iiM76GBlMNJHduhM+T7akfK9YXvp5iwI3FE04zmubNNtanAqgrzy1Q9gzGoKS F6HJBatI3ItXfdIJEpXJYi0HDUzCLcxNHtBQA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=zT0xtenanwI5lujmvDuGlKAytZNooDc25w7ldKUbbLo=; b=IOQz1oDjkc8tvoJVcGP3emdeaSw3ZF1uEPu+BVhevN0qBjobaVcwy/cwOskl349390 +cLP+29XD3z0CktAeuZLjVj1SUIVpuzOyQffbGUPc8r2/rq6yEFbP7ZeOQJEuSZZtMjH oUv+ugkcE9JllcdWGeRWSDNSfC+iegBzKtjgBQjQKYhetHQ4cXEOcGCM3Ly2YAovX14P qfuegJnp7CD4FxkHMJphDYuCsBt8MLPUyhDEyT2b7A/R2oSCXFu03CMS1zdNGfi3g0fF J5fc6TwOEF2It8urPKnD8PjmfV47s+mCcjMnH2WwvKKx8XGdwk4Hb1WM803AVlzNxLZj GDCg== X-Gm-Message-State: ALyK8tL+WzavBr1boFcZuTiQ1Yf6kxX94KLtWE9rl1/c7ibTYici+Ajq///GBJFOPNbkUw== X-Received: by 10.98.37.71 with SMTP id l68mr3962858pfl.38.1468419618425; Wed, 13 Jul 2016 07:20:18 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id sk4sm5643027pac.16.2016.07.13.07.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Jul 2016 07:20:17 -0700 (PDT) From: Ted Zlatanov To: 23945@debbugs.gnu.org, Lars Magne Ingebrigtsen Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87k2gs8bak.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 13 Jul 2016 10:20:12 -0400 In-Reply-To: <87k2gs8bak.fsf@lifelogs.com> (Teodor Zlatanov's message of "Mon, 11 Jul 2016 11:05:55 -0400") Message-ID: <87wpkpwrfn.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov wrote: TZ> I've published the proposed changes to the Gnus Cloud code in the branch TZ> `scratch/gnus-cloud' and would like to request a code review. It's a TZ> single commit which I've tested over the last 2 weeks with the help of TZ> other Gnus users. TZ> I'll add documentation if the code is acceptable. Lars? You look like a good reviewer. There is one piece I remembered was missing: making the cloud host persistent. After restarting Gnus, you have to set the gnus-cloud-method with `gnus-server-toggle-cloud-method-server' again. How would you suggest to save that, with a defcustom in gnus-cloud or in the individual server's parameters? Right now it's just (defvar gnus-cloud-method nil "The IMAP select method used to store the cloud data.") If I save it in the individual server's parameters there's a possibility that two servers will have the cloud host flag accidentally. Ted From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 18 10:08:32 2016 Received: (at 23945) by debbugs.gnu.org; 18 Jul 2016 14:08:33 +0000 Received: from localhost ([127.0.0.1]:55857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9Dh-0007OX-4o for submit@debbugs.gnu.org; Mon, 18 Jul 2016 10:08:32 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9Db-0007OH-Rd for 23945@debbugs.gnu.org; Mon, 18 Jul 2016 10:08:27 -0400 Received: by mail-pf0-f182.google.com with SMTP id y134so39063315pfg.0 for <23945@debbugs.gnu.org>; Mon, 18 Jul 2016 07:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=eqz84qDDzUreErdmFMVlQ9zdpKH9guHyDcKlVfyv8/o=; b=ZTeUPjP1ukMHIt7njk0mjg6pOeTYis4UWoqBKGHtyUKs7kYdLG56GxEAoim21M8qLy zMTBl/BYiGjJZDFj0KnEbIgfJDfp5RlyJZZjOxei7bkFC9In56jmNbI4BT1FNrJy5blG Vd3F9TJHMeHA8r9VuEzdNf3KDKfcEmiFp2qfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=eqz84qDDzUreErdmFMVlQ9zdpKH9guHyDcKlVfyv8/o=; b=afwLlLHhYAJNrLMr6+D3x+oycTQKpuspHmcrqkwUYOd/qwLiMoJhEsLOJNZG2KV33w AiJZ/CyhzQVq2OjVBqESjOq6IbgxD3aNEbSLqZc58v1QoWawfaJD+z9Oh9nKEwINThb7 8lDO53EWuqNT7dYcUwE07onOAwhgwi9JcGVq9EPBBqrEMZLOfelFFpALl9y2RwL/6hEo xrL+GrNCoXwY3C1+fR9WtTnXMN8vOGfKgTd9DXipmg6rIxniREzCFQx5nZlFr8naXSPn AW3LGLueed7ZSGxlyXOZy+GJJR6r3/mBjO1BkxOvDtnOpYaHHLo1NeEsX1ATjF0TDSbD 9ZaQ== X-Gm-Message-State: ALyK8tJMlgjhAG5mvI14yvU635aGTjp2+7pO4+RXyL0JIcY+dkZQInneeNnaUFIGVm7k+Q== X-Received: by 10.98.54.134 with SMTP id d128mr30310080pfa.150.1468850897874; Mon, 18 Jul 2016 07:08:17 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id v126sm5527568pfb.60.2016.07.18.07.08.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 07:08:16 -0700 (PDT) From: Ted Zlatanov To: 23945@debbugs.gnu.org Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 18 Jul 2016 10:08:12 -0400 In-Reply-To: <87wpkpwrfn.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 13 Jul 2016 10:20:12 -0400") Message-ID: <877fcjt4xf.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 Cc: Lars Magne Ingebrigtsen X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, 13 Jul 2016 10:20:12 -0400 Ted Zlatanov wrote: TZ> On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov wrote: TZ> I've published the proposed changes to the Gnus Cloud code in the branch TZ> `scratch/gnus-cloud' and would like to request a code review. It's a TZ> single commit which I've tested over the last 2 weeks with the help of TZ> other Gnus users. TZ> I'll add documentation if the code is acceptable. TZ> There is one piece I remembered was missing: making the cloud host TZ> persistent. I converted `gnus-cloud-method' to a defcustom and added the necessary code to set it, resolving this question. Since no one has been interested in reviewing this code, I will merge it tomorrow. Ted From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 18 19:18:16 2016 Received: (at 23945) by debbugs.gnu.org; 18 Jul 2016 23:18:16 +0000 Received: from localhost ([127.0.0.1]:56084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPHnk-0005Ts-EZ for submit@debbugs.gnu.org; Mon, 18 Jul 2016 19:18:16 -0400 Received: from mail-it0-f52.google.com ([209.85.214.52]:35119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPHni-0005Te-Po for 23945@debbugs.gnu.org; Mon, 18 Jul 2016 19:18:15 -0400 Received: by mail-it0-f52.google.com with SMTP id u186so80242534ita.0 for <23945@debbugs.gnu.org>; Mon, 18 Jul 2016 16:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=9vudXXdBJDuhnfOHAV/gAjAET9PNMvVf4JvOuNH/x+Q=; b=XAWnmM4ejoBYOI3MVpOfkVuPodTycdkQzD73rPAvZJmY1PvotEhQM4erNbfItmJQ/V NGuMmBtQbDIoGoqN+rTDxd0F71PDDBHX8sAk4nF3ItiQ8HoUfeHQijTkfuA3ytPYJyKF R8t1xKuGCAMhVr2IPP1JxmCsecTEP032jAut6cxD56a5WWUgMgyI5Zu8w2bly3Qn1DCy tWGlR55VZ8yJkFifk/GvXWUiZr5yqsdzKjyBAtEfj5JE0PbuiEZNOWQ7sF3AtewmOylc 5Yc4p6mlDpRIvl4efGAalyM0TcV11X74o7elSaF6+q5y7MI88kqMiPI2mLNyb/FoOuaZ vwNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=9vudXXdBJDuhnfOHAV/gAjAET9PNMvVf4JvOuNH/x+Q=; b=FmjT5cFEM6hTCOLAXGwITDtcf8gekpRDB/LQ+xdZzp8AmxivAHOHbFzzjizvbDE2aY U5Q4UVF+8A3B6o/vhaBGfQZ2LhAYqIaOO8Vl5sHmLxwomP7hm2ya33/8vdBH3gH2CuwV sMOtucCGqtX07Otc1HGxNiNpHq9KVdfPILY3BTT2cDS3kHFI6HhxrTtNRUJ9opqdOAvo +NTQSJtnTV4RZALt7YSnkBGxTGc69GC0qGIBmAGZ2Xa6PpSrJCSI9DVSvIEDrztXX/Eo L0zwjMyOS+e+Jn93PcgnookY2Fc0Vlt+dwkCiSbl7SzRJqHc/ZHA1my61nbEKmeEpgUx E8ow== X-Gm-Message-State: ALyK8tJnERs65Qmr3BcWjisKprROmwNrsl5+p9w539Fg/+a1LwoDNW7cCB6xoTh2lv0SwA== X-Received: by 10.36.230.5 with SMTP id e5mr959732ith.92.1468883889113; Mon, 18 Jul 2016 16:18:09 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id b66sm1487416itd.0.2016.07.18.16.18.08 for <23945@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 16:18:08 -0700 (PDT) From: npostavs@users.sourceforge.net To: 23945@debbugs.gnu.org Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> Date: Mon, 18 Jul 2016 19:18:09 -0400 In-Reply-To: <877fcjt4xf.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 18 Jul 2016 10:08:12 -0400") Message-ID: <87r3aqcz7y.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ted Zlatanov writes: > On Wed, 13 Jul 2016 10:20:12 -0400 Ted Zlatanov wrote: > > TZ> On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov wrote: > TZ> I've published the proposed changes to the Gnus Cloud code in the branch > TZ> `scratch/gnus-cloud' and would like to request a code review. It's a > TZ> single commit which I've tested over the last 2 weeks with the help of > TZ> other Gnus users. > > TZ> I'll add documentation if the code is acceptable. > > TZ> There is one piece I remembered was missing: making the cloud host > TZ> persistent. > > I converted `gnus-cloud-method' to a defcustom and added the necessary > code to set it, resolving this question. > > Since no one has been interested in reviewing this code, I will merge it > tomorrow. Perhaps this is partly because I'm not familiar with the code (or what "Gnus Cloud" is), but it seems to me that you're missing a good summary line explaining what any of these changes are for. The bug title and commit message summary line mentions only "Gnus Cloud work". What "work"? This feels actively reviewer-hostile. The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better (at least we can tell it's about UI), though adding 20 or so "Merge branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't help much either. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 19 10:50:22 2016 Received: (at 23945) by debbugs.gnu.org; 19 Jul 2016 14:50:22 +0000 Received: from localhost ([127.0.0.1]:57430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPWLm-0000tv-78 for submit@debbugs.gnu.org; Tue, 19 Jul 2016 10:50:22 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPWLj-0000th-Hq for 23945@debbugs.gnu.org; Tue, 19 Jul 2016 10:50:20 -0400 Received: by mail-pf0-f182.google.com with SMTP id y134so8119828pfg.0 for <23945@debbugs.gnu.org>; Tue, 19 Jul 2016 07:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=DwnUuls0eaRoFuhetWJOc0C41fiCm4nsfLMwiafpls4=; b=OuJhJrkOS6vK4rqabZFeywvUnEBNdYICnUDxSSj+rtfDx8uO1GQxh6sQH0kaIsSV4Q e2w8V94xpK+8yrImVG2JtJYMacS+hj9pqu8eRq5ItD473bGat6OSXNlMt5tRqHekwswb fmINp2LPTXrZTSmtl5WOBz8xJb2lABcy3v828= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=DwnUuls0eaRoFuhetWJOc0C41fiCm4nsfLMwiafpls4=; b=DFK6pOgGvOoqzL2dMbKpgrpzpf59YxfgiZI8H636MJOKWx2E0C8MfHZZvO+AYlWsjW pqFNJkFHMFcxwyN9KgjG4Zc33EfXKDO8krhZ621d/U6OsEm5+iVLf9RbYfg9LucFj7BU /OKqUq3yNpmA+GDzsW2yuYBSnPIfJRC1YG42sdv/jTmvTwK+UDpbLH59xWdOd3/JswUN YqiL8SPwJ59TPFklI/dzy0wdI8tO1ag5OUnTELKUHfjUbUf1IjgxbNhfgREJERBpdd3z doSO2glmxq6jaqIbQFDGhgWsc6O8hlxwMuXr2V2K6GYTEC6LTKvW39ATdloWecCQWVk4 o9gg== X-Gm-Message-State: ALyK8tIAsvriTgj0dH2riXoTr5rBcw58UQE6woOi7FKRfeYL9zhKywDnSGhjmhFVZo3jUw== X-Received: by 10.98.101.198 with SMTP id z189mr55746365pfb.53.1468939813666; Tue, 19 Jul 2016 07:50:13 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id lf11sm5347560pab.17.2016.07.19.07.50.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 07:50:12 -0700 (PDT) From: Ted Zlatanov To: npostavs@users.sourceforge.net Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> <87r3aqcz7y.fsf@users.sourceforge.net> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 19 Jul 2016 10:50:07 -0400 In-Reply-To: <87r3aqcz7y.fsf@users.sourceforge.net> (npostavs's message of "Mon, 18 Jul 2016 19:18:09 -0400") Message-ID: <87eg6pr8bk.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 Cc: 23945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 18 Jul 2016 19:18:09 -0400 npostavs@users.sourceforge.net wrote: >> I converted `gnus-cloud-method' to a defcustom and added the necessary >> code to set it, resolving this question. >> >> Since no one has been interested in reviewing this code, I will merge it >> tomorrow. n> Perhaps this is partly because I'm not familiar with the code (or what n> "Gnus Cloud" is), but it seems to me that you're missing a good summary n> line explaining what any of these changes are for. The bug title and n> commit message summary line mentions only "Gnus Cloud work". What n> "work"? This feels actively reviewer-hostile. You're right. The history of this work goes back at least 4 years in the Gnus mailing list so I was hoping Lars or someone else familiar with that history would jump in. You can start with the most recent log of work I did: http://thread.gmane.org/gmane.emacs.gnus.general/85543/focus=87091 I will write docs for the feature, but simply wasn't sure about some key aspects of it that depended on the code. Please note I did add docstrings for most of the functions, especially the interactive ones. But I agree that's no excuse for a lack of good commit messages. n> The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better n> (at least we can tell it's about UI), though adding 20 or so "Merge n> branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't n> help much either. Well, that's an issue with the source code repo. I've mentioned it before. Here's my rant: I merge the master branch often because I have been using the gnus-cloud branch and want to make sure it's not broken against master. I also test and use many other new features. I really don't want to start working outside the master branch. But I can't rebase and push again, because the repo doesn't support non-fast-forward pushes. I have to delete and recreate the branch (notification emails x2, and a little bit of manual labor). But also every time I do a push with merges, notification e-mails come out for my changes plus everything merged. I can't win either way. So the bottom line for me is, I'd really like notification e-mails not to go out for "scratch/*" branches, or to be able to do a non-fast-forward push to my scratch branch. Since neither is possible, I'm doing the best I can for now. I am strongly considering using Github next time (Git supports multiple remotes for a branch, so this is not too hard) and saving myself all this trouble. You can use `git log --no-merges' meanwhile to filter out those merge commits. Sorry for the inconvenience. Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 19 16:15:47 2016 Received: (at 23945) by debbugs.gnu.org; 19 Jul 2016 20:15:47 +0000 Received: from localhost ([127.0.0.1]:57649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPbQh-0003Vl-IF for submit@debbugs.gnu.org; Tue, 19 Jul 2016 16:15:47 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:35397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPbQf-0003VX-4H for 23945@debbugs.gnu.org; Tue, 19 Jul 2016 16:15:45 -0400 Received: by mail-pa0-f42.google.com with SMTP id iw10so10100077pac.2 for <23945@debbugs.gnu.org>; Tue, 19 Jul 2016 13:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=EaqAqawPIzB0sg4rhalRfKE+MjncENQGnxpEackhn2E=; b=BWZIdCN1dHI/yB94ezJMMURhJufTZnQiF3L78klkxXA0OX+lvYnn+Vaw4dckHbN1oo lf1Aj7c8UDsGhSRKvoaEgL6LgyWVf8WRd/Kt1qPpDf6Oo7e9vEzGrG7VTHrjxvleunIK wwyRT6rvSfIuRgksIQpIuQkKJdUWn82GXRttE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=EaqAqawPIzB0sg4rhalRfKE+MjncENQGnxpEackhn2E=; b=LCGmdMW20cz/eERGbMEryijr0TnjrPzFzYb0c8B8kBH59hx1IJw1cdwnYkIT7Ugo/z z+2LRDLkOEXhp9OQSi5rtRyeIhZM91wX8PUEtZQObg2yIvT8iR33Ks7yK5uKwXrjJhm4 m/CMciYXyjfYULRVPKphhd9eyHWrelxl+KpAeJ24lUmjVfDcyMF8pgDfJ6p+FZrzQPjR bVtTNdjOk9cAGxt70cd37Th5d7/sY4uTu9Ao+5FSfIzUyWVFZOWHNO1WUaquzGWkBzWL 9eOGSihR/8yU6F3/v9xeJY+EwsaaWBzHA+sZqS3HnhGoFBGK9RwqpYJTP0qFe1gEUDw+ DNoQ== X-Gm-Message-State: ALyK8tKnRe5/t2nWUG2SM6GUbk8kZMEOo27fRKDrL54CF3S8qdiZKUdoo0dsvcjyIak70A== X-Received: by 10.66.86.170 with SMTP id q10mr57048518paz.105.1468959339339; Tue, 19 Jul 2016 13:15:39 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id c82sm6961029pfb.72.2016.07.19.13.15.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Jul 2016 13:15:38 -0700 (PDT) From: Ted Zlatanov To: npostavs@users.sourceforge.net Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> <87r3aqcz7y.fsf@users.sourceforge.net> <87eg6pr8bk.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 19 Jul 2016 16:15:33 -0400 In-Reply-To: <87eg6pr8bk.fsf@lifelogs.com> (Ted Zlatanov's message of "Tue, 19 Jul 2016 10:50:07 -0400") Message-ID: <8760s1qt96.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 Cc: 23945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 19 Jul 2016 10:50:07 -0400 Ted Zlatanov wrote: TZ> You're right. The history of this work goes back at least 4 years in the TZ> Gnus mailing list so I was hoping Lars or someone else familiar with TZ> that history would jump in. You can start with the most recent log of TZ> work I did: TZ> http://thread.gmane.org/gmane.emacs.gnus.general/85543/focus=87091 TZ> I will write docs for the feature, but simply wasn't sure about some key TZ> aspects of it that depended on the code. I rebased and added docs for this feature. So now there's just three commits in the scratch/gnus-cloud branch. Let me know, based on the docs, what the commit message should say. I can't think of a good summary, since the work is really widespread in order to make this package useful. Thanks Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 19 21:36:22 2016 Received: (at 23945) by debbugs.gnu.org; 20 Jul 2016 01:36:22 +0000 Received: from localhost ([127.0.0.1]:57738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPgQw-0003Ca-Ap for submit@debbugs.gnu.org; Tue, 19 Jul 2016 21:36:22 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:34299) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPgQt-0003CM-7W for 23945@debbugs.gnu.org; Tue, 19 Jul 2016 21:36:20 -0400 Received: by mail-oi0-f42.google.com with SMTP id l65so51187942oib.1 for <23945@debbugs.gnu.org>; Tue, 19 Jul 2016 18:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=fxUq+xkjZMJfS9IxaQ/4pAI/pQRASCgTqdq0IXmi6R4=; b=iAFV4/tD9Jh81gN1Ag7De1pGvmVXLW6jXp/zIE0VBUtIiz/4E7eTuyrCgRleYmndmK YSkYz5v9+5LHt9QHkuySE7v8kAPUzEwk1IPy4EX6uAJPgH6hoNCAFV9UGzTIZxOceIVp 5rWfNPr0GrjZRvMUQcn57rL/wwrQ+6bVAehEexEVEqDLORaBjVP90hfs/azKPGZAp9ua /QO8D5HJr4TPTg+grQWT7SmrIZYQPDpkeoivfTWwAco+pF/6rVycTjsUz9w76JhejBCL IXru1+D0XFltWRwmVdBZbP3rbL53RYsIAFZlZyaka8a9kxiUp/AJsu9FyH2wFw6u6R8R QdiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=fxUq+xkjZMJfS9IxaQ/4pAI/pQRASCgTqdq0IXmi6R4=; b=HznUO+yc0XSK1A3JjQXe/qAbqDpGLkL36v9hC7/b4sbVo47Vi4bA17Qs3DdgGTWQpo m0jnAh0iMmHFqPayjW6Y+dIQqzLn4D3wMM9OqDv40CHi7TMB9g36DnHsBZVlupwqRTR0 A1HMw55BGjyy6aMOvSdC9BmhX5ohqppyHh2u9N56yfUuMUxK5yeqbRwTdT8TUQ5VpX37 niDA544c75kk7Mo0ik3uWdDdP/ec15K8IpGwfMNus9LLuZhGXYZUCk5QFK2xFH6do0jE l/EOs0+nPYkAqBhNZy8XTW4+bJKynZhM6kSMF6qOPz4NAiNpsBUub8d6e7S07mcs155w fcpg== X-Gm-Message-State: ALyK8tIXEGTYei6PZtnv6TFaz+eJ1SetvPYMzN0RRYGBrS2DWk6VjtdwXPXEck4hDKYZj5H0Fx9PW6vDkgC8IA== X-Received: by 10.202.199.199 with SMTP id x190mr20063042oif.35.1468978573665; Tue, 19 Jul 2016 18:36:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.7.161 with HTTP; Tue, 19 Jul 2016 18:36:12 -0700 (PDT) In-Reply-To: <8760s1qt96.fsf@lifelogs.com> References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> <87r3aqcz7y.fsf@users.sourceforge.net> <87eg6pr8bk.fsf@lifelogs.com> <8760s1qt96.fsf@lifelogs.com> From: Noam Postavsky Date: Tue, 19 Jul 2016 21:36:12 -0400 X-Google-Sender-Auth: rgPmwNV4Pa6omWUyTnn4ecPOjgE Message-ID: Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud To: Ted Zlatanov Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945 Cc: 23945@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Jul 19, 2016 at 4:15 PM, Ted Zlatanov wrote: > On Tue, 19 Jul 2016 10:50:07 -0400 Ted Zlatanov wrote: > > TZ> You're right. The history of this work goes back at least 4 years in the > TZ> Gnus mailing list so I was hoping Lars or someone else familiar with > TZ> that history would jump in. You can start with the most recent log of > TZ> work I did: > > TZ> http://thread.gmane.org/gmane.emacs.gnus.general/85543/focus=87091 > > TZ> I will write docs for the feature, but simply wasn't sure about some key > TZ> aspects of it that depended on the code. > > I rebased and added docs for this feature. So now there's just three > commits in the scratch/gnus-cloud branch. > > Let me know, based on the docs, what the commit message should say. I > can't think of a good summary, since the work is really widespread in > order to make this package useful. Maybe something like "Bring gnus-cloud.el into working order", I gather from that thread that it was broken before, right? That's still not very descriptive but it looks like there's just a lot of little changes that aren't really tied together. Perhaps it would be better broken up into more commits (though that's probably not worth the trouble at this point). From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 20 08:56:06 2016 Received: (at 23945-done) by debbugs.gnu.org; 20 Jul 2016 12:56:06 +0000 Received: from localhost ([127.0.0.1]:57985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPr2k-0007LT-0w for submit@debbugs.gnu.org; Wed, 20 Jul 2016 08:56:06 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:35693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPr2i-0007Ky-7f for 23945-done@debbugs.gnu.org; Wed, 20 Jul 2016 08:56:04 -0400 Received: by mail-pa0-f49.google.com with SMTP id iw10so18221135pac.2 for <23945-done@debbugs.gnu.org>; Wed, 20 Jul 2016 05:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version; bh=japEqVlgv8wz+FhP/LB0zu9/BSAqNWGWHV82mfv9zL8=; b=Bo2njPDbtgqH27WbEaXiybRFwLWxcMt0m5QxGnNIyalYdBVJH8xYfKid5L51wYALRj cgYymTMTerp22lvwdP0tjFlYEoQselTYcSZQu3zGZKs5MCQJmaESWHmHNekDs8HaGeVK JAL1QPGjAe2kqFCdWuRtfxoWA8Jt8qqGi2HvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version; bh=japEqVlgv8wz+FhP/LB0zu9/BSAqNWGWHV82mfv9zL8=; b=hfcoCR3j1FbrByU5yQ5S5akYPwINLy1u23VyLYRqg0qD97KNwNVNlpfj3ba1hmGh1+ QCiKu5dcunYnPstNFrISUnGouFo+82XaYm9MT5w8Pb+9vHau6MW79oup6ame6T+Ozrog 05h4LQiF61Tc/VkVfayPU0+Nja55IYPYRnAU3hl3WmlvPV9jTQU5PWstQSRPunB2wXyr qTdVdHVhJMJ8qodvHsUgOM3jdbKd2kZkCnNodeQ6dCWPm2jsADHyUp8iI0dyqkMbyK3K euH+ybtnDedNIbk2VGM1L3AnNTkeO0M82tbLw0u+s9CS1i2Bx5ItLRbzhq5Z9rjnZIRe K95A== X-Gm-Message-State: ALyK8tKX6nB6mNSgmVskXa/M7D4V6gcyWVJ27Po/HuScIWNuo41OsTzKUVCSO7T0SsaY9w== X-Received: by 10.66.41.133 with SMTP id f5mr76037566pal.70.1469019358408; Wed, 20 Jul 2016 05:55:58 -0700 (PDT) Received: from flea (c-98-229-60-157.hsd1.ma.comcast.net. [98.229.60.157]) by smtp.gmail.com with ESMTPSA id g27sm4742278pfd.47.2016.07.20.05.55.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 05:55:57 -0700 (PDT) From: Ted Zlatanov To: Noam Postavsky Subject: Re: bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87k2gs8bak.fsf@lifelogs.com> <87wpkpwrfn.fsf@lifelogs.com> <877fcjt4xf.fsf@lifelogs.com> <87r3aqcz7y.fsf@users.sourceforge.net> <87eg6pr8bk.fsf@lifelogs.com> <8760s1qt96.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Wed, 20 Jul 2016 08:55:53 -0400 In-Reply-To: (Noam Postavsky's message of "Tue, 19 Jul 2016 21:36:12 -0400") Message-ID: <87h9bkbh9i.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23945-done Cc: 23945-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 19 Jul 2016 21:36:12 -0400 Noam Postavsky wrote: NP> On Tue, Jul 19, 2016 at 4:15 PM, Ted Zlatanov wrote: >> Let me know, based on the docs, what the commit message should say. I >> can't think of a good summary, since the work is really widespread in >> order to make this package useful. NP> Maybe something like "Bring gnus-cloud.el into working order", I NP> gather from that thread that it was broken before, right? That's still NP> not very descriptive but it looks like there's just a lot of little NP> changes that aren't really tied together. Perhaps it would be better NP> broken up into more commits (though that's probably not worth the NP> trouble at this point). All right... I squashed with the message you suggested. It's pushed so I'll call this review done. Ted From unknown Mon Aug 18 02:37:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 18 Aug 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator