From unknown Sat Aug 09 15:18:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Resent-From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2016 23:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23938@debbugs.gnu.org Cc: Paul Eggert X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146819364611788 (code B ref -1); Sun, 10 Jul 2016 23:35:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Jul 2016 23:34:06 +0000 Received: from localhost ([127.0.0.1]:45748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMOEf-000344-QX for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:34:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMOEe-00033Y-IF for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMOEY-0003wZ-8F for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:33:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOEY-0003wU-4l for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:33:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOEV-0005tp-Rs for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMOER-0003vT-Lr for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:54 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOER-0003ue-CC for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:51 -0400 Received: from [192.168.1.82] ([109.24.225.43]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0MYoaY-1bqaGg3anS-00VT7y; Mon, 11 Jul 2016 01:33:45 +0200 From: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Message-ID: <5782DB52.1060806@live.com> Date: Mon, 11 Jul 2016 01:33:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N" X-Provags-ID: V03:K0:O3qyItWRzyQXx7NKYWzKKY2JoJSwEjmW5l0VxOm8cwEx522MmIo ohlc3rVM61tp1a0bzrtATvbh7ezf/5XdrzhTRe9ahhTXQDcIfU3CrE+oQxNqjs35vhDnX4R UmNISKkfd19n/Z5xyEn7Ko3Jitq3czMio0laeiL+ApCyiUtMryHxmeXn/wSwvu0vTnanB3n 8eEf7p0JGkWKtu2tSQWBA== X-UI-Out-Filterresults: notjunk:1;V01:K0:S2C1PMkBUnA=:eGfFS3XFRskOr5ZfbxEjG8 tBa7tRaEJfhmEnY81j6Zyuaamr1Y1Qnar1JTzARjMq1wb33pMJJXC7EAxUFFht2AHNIGgGBqT Z43Ke40Xzm11neuIkFgDLhYa1yIvc7stRi1/hTcweSPJThzh55yiCQF3N8iXHQXb6MSS1C+iA dsxzRWLPg+aT78X/wO0GtLM/SqxkKqe9LmlCq2+9hHuWulk2VHxH7LaVyRxBg/JwEDvpssrBk nD6txfcT383IZ3WZI2vmxdf0iQQtkLTl3XYKDINHQgnRWR+FuRIrpcL99ryj1xCSuqR2BDa+k uYjZqLUE7LGQulW9J6yHKkhgCInoaheatPieL0rCavWGnfJyzrrl8eqEQh3NGl77vsRsEx8qb Reb5MTsvINmAKeOkbKbqe09HtS5bTgZ7+CafWm3iGKucZaBx+4qETuPlh4sjs48QYyROveONU QxXp1FqGemir/g2LKcxFeKmnN2hI5TTEwvQ23qdMvV0kcIDA16Ek2U6aw5GK7jxsCJgbZdN67 aqkEIhTQLgXz+xEHppFMJLh5eHuz6icndJfK3Be1CxROnh8yYlL1OZ12l3L9xYMEY0Ah3auEO pL/n82ocbWUxfJnfkrKQUT2Z1gtnRsIn4ySAC4mL5PfhRZpdWmj0VEeVbzlSEvr5MACFscXav DPdY6SzlLqeFlliqGXzv6h4/0ItigAvBkzz44Zlvo/LMkZ8LO0QLuq1mt5mujO6Z0LUQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N Content-Type: multipart/mixed; boundary="UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Cc: Paul Eggert Message-ID: <5782DB52.1060806@live.com> Subject: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master --UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd"= =2E On master, it displays "b" and "d" on top of each other. (with-current-buffer (get-buffer-create "*test*") (erase-buffer) (fundamental-mode) (insert "test") (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d)) (pop-to-buffer (current-buffer))) Bisecting points to the following commit: 237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit commit 237244bbd5ce753bcdf79634561de515bd76c687 Author: Paul Eggert Date: Mon May 30 16:09:25 2016 -0700 Omit IF_LINT code that no longer seems needed Nowadays GCC is smarter, or the Emacs code has mutated, or both, and now is as good a time as any to remove uses of IF_LINT that now seem to be unnecessary. (...) The small test case is courtesy of Artur; we both noticed the issue while= using his (awesome) =E2=80=98nameless=E2=80=99 package; see https://gith= ub.com/Malabarba/Nameless/issues/15 for details on the issue that prompte= d the investigation. Cheers, Cl=C3=A9ment. In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2016-06-26 built on clem-w50-mint Repository revision: 431437b6593320dc5a7a8aac9c911c778a656117 Windowing system distributor 'The X.Org Foundation', version 11.0.1150100= 0 System Description: Linux Mint 17.3 Rosa --UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT-- --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXgttSAAoJEPqg+cTm90wjjJAP/3DwKp+Rbh6f2f2VY9UzRsTp dx9H1mI8+bxXbHmRq3fJdIWFbIbgtjbPO9iUBny/26VV1VhfjqYYUcNJRrp28YCb O3lqGKBrRzJyfzwezHfCWBoW0KVoQwAwCPpmEBIiWj6M8qHOQ5s9c2vz4e38d4+G sjWeRQIGyxHcscRmRoscaj7/ZdD0B9m1CJ0FcHwlJE1OOcdKfuDo7jrGfVBvK4ot zmCHOT3dbV8q6beW79zNYnhklNQWwyduY4nZtXAhd6i+RCSHVYB2e+lxYmcTRSwa aZ/+4kEPXScEjO865yto/UhfEFr17JS/0YjbCStHkkJ/XDqESyM0fpcE2/CRtBCP qWVXPeZptueOSquYsEeMpkjsbnrU5fenBNABGgA5e769LsRnA+/yePYvRDHr4GmI A2FF5QVGfeBGPhHFUp/+V/cDorTl7CtNCvKbZAIDYP398sGbYVHtk02Ew2kUzR5h 6XqQci6+jWCaGW+fx3wQaG3Pj2martJrIiC8BZU1uH1LgxcgokKV4iZKe67xy6bj CQwBfnc5EeFWypK7OUe7ZG2TNnUEWHRyuBefkQHlnmmWzD3Y4Feygrin8LNCklNB qQC241HJzhkyJALEegAb2ljZqX+Axb2c0u73LQof1DhsrwvE3hJWbMsxeUaPszGF gaa/YPHUuqj4QYhSFrfZ =o+5z -----END PGP SIGNATURE----- --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N-- From unknown Sat Aug 09 15:18:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Subject: bug#23938: closed (Re: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master) Message-ID: References: <5783AB19.3020706@cs.ucla.edu> <5782DB52.1060806@live.com> X-Gnu-PR-Message: they-closed 23938 X-Gnu-PR-Package: emacs Reply-To: 23938@debbugs.gnu.org Date: Mon, 11 Jul 2016 14:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1468246862-12270-1" This is a multi-part message in MIME format... ------------=_1468246862-12270-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of co= mposed characters on master which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23938@debbugs.gnu.org. --=20 23938: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23938 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1468246862-12270-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23938-done) by debbugs.gnu.org; 11 Jul 2016 14:20:26 +0000 Received: from localhost ([127.0.0.1]:46937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMc4P-0003Ae-WD for submit@debbugs.gnu.org; Mon, 11 Jul 2016 10:20:26 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMc4O-0003AP-M2 for 23938-done@debbugs.gnu.org; Mon, 11 Jul 2016 10:20:25 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CC1C616149F; Mon, 11 Jul 2016 07:20:18 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mxArNnIj1r77; Mon, 11 Jul 2016 07:20:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0F932161493; Mon, 11 Jul 2016 07:20:18 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id k4ZHeWG1o6Zy; Mon, 11 Jul 2016 07:20:17 -0700 (PDT) Received: from [192.168.1.64] (171.213.196.77.rev.sfr.net [77.196.213.171]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0CD9616148E; Mon, 11 Jul 2016 07:20:16 -0700 (PDT) Subject: Re: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master To: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= , 23938-done@debbugs.gnu.org References: <5782DB52.1060806@live.com> From: Paul Eggert Message-ID: <5783AB19.3020706@cs.ucla.edu> Date: Mon, 11 Jul 2016 16:20:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <5782DB52.1060806@live.com> Content-Type: multipart/mixed; boundary="------------030005070506080900040501" X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 23938-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) This is a multi-part message in MIME format. --------------030005070506080900040501 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for tracking that bug down and for the reproducible test case. It was a typo in that refactoring commit; sorry about that. I installed the attached patch into master to fix things. --------------030005070506080900040501 Content-Type: text/x-patch; name="0001-Fix-composition-bug-caused-by-off-by-1-typo.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-composition-bug-caused-by-off-by-1-typo.patch" >From 8cb5ab5cf48362ea64c6463a8aabc4892c5352f7 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 11 Jul 2016 16:14:33 +0200 Subject: [PATCH] Fix composition bug caused by off-by-1 typo * src/xdisp.c (x_produce_glyphs): Fix off-by-one typo when computing composition glyph (Bug#23938). --- src/xdisp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xdisp.c b/src/xdisp.c index d5ffb25..14d6f8f 100644 --- a/src/xdisp.c +++ b/src/xdisp.c @@ -27369,8 +27369,8 @@ x_produce_glyphs (struct it *it) eassume (0 < glyph_len); /* See Bug#8512. */ do - c = COMPOSITION_GLYPH (cmp, --glyph_len); - while (c == '\t' && 0 < glyph_len); + c = COMPOSITION_GLYPH (cmp, glyph_len - 1); + while (c == '\t' && 0 < --glyph_len); bool right_padded = glyph_len < cmp->glyph_len; for (i = 0; i < glyph_len; i++) -- 2.5.5 --------------030005070506080900040501-- ------------=_1468246862-12270-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 10 Jul 2016 23:34:06 +0000 Received: from localhost ([127.0.0.1]:45748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMOEf-000344-QX for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:34:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMOEe-00033Y-IF for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:34:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMOEY-0003wZ-8F for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:33:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOEY-0003wU-4l for submit@debbugs.gnu.org; Sun, 10 Jul 2016 19:33:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45828) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOEV-0005tp-Rs for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMOER-0003vT-Lr for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:54 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:55529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMOER-0003ue-CC for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 19:33:51 -0400 Received: from [192.168.1.82] ([109.24.225.43]) by mrelayeu.kundenserver.de (mreue002) with ESMTPSA (Nemesis) id 0MYoaY-1bqaGg3anS-00VT7y; Mon, 11 Jul 2016 01:33:45 +0200 To: bug-gnu-emacs@gnu.org From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= Subject: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Message-ID: <5782DB52.1060806@live.com> Date: Mon, 11 Jul 2016 01:33:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N" X-Provags-ID: V03:K0:O3qyItWRzyQXx7NKYWzKKY2JoJSwEjmW5l0VxOm8cwEx522MmIo ohlc3rVM61tp1a0bzrtATvbh7ezf/5XdrzhTRe9ahhTXQDcIfU3CrE+oQxNqjs35vhDnX4R UmNISKkfd19n/Z5xyEn7Ko3Jitq3czMio0laeiL+ApCyiUtMryHxmeXn/wSwvu0vTnanB3n 8eEf7p0JGkWKtu2tSQWBA== X-UI-Out-Filterresults: notjunk:1;V01:K0:S2C1PMkBUnA=:eGfFS3XFRskOr5ZfbxEjG8 tBa7tRaEJfhmEnY81j6Zyuaamr1Y1Qnar1JTzARjMq1wb33pMJJXC7EAxUFFht2AHNIGgGBqT Z43Ke40Xzm11neuIkFgDLhYa1yIvc7stRi1/hTcweSPJThzh55yiCQF3N8iXHQXb6MSS1C+iA dsxzRWLPg+aT78X/wO0GtLM/SqxkKqe9LmlCq2+9hHuWulk2VHxH7LaVyRxBg/JwEDvpssrBk nD6txfcT383IZ3WZI2vmxdf0iQQtkLTl3XYKDINHQgnRWR+FuRIrpcL99ryj1xCSuqR2BDa+k uYjZqLUE7LGQulW9J6yHKkhgCInoaheatPieL0rCavWGnfJyzrrl8eqEQh3NGl77vsRsEx8qb Reb5MTsvINmAKeOkbKbqe09HtS5bTgZ7+CafWm3iGKucZaBx+4qETuPlh4sjs48QYyROveONU QxXp1FqGemir/g2LKcxFeKmnN2hI5TTEwvQ23qdMvV0kcIDA16Ek2U6aw5GK7jxsCJgbZdN67 aqkEIhTQLgXz+xEHppFMJLh5eHuz6icndJfK3Be1CxROnh8yYlL1OZ12l3L9xYMEY0Ah3auEO pL/n82ocbWUxfJnfkrKQUT2Z1gtnRsIn4ySAC4mL5PfhRZpdWmj0VEeVbzlSEvr5MACFscXav DPdY6SzlLqeFlliqGXzv6h4/0ItigAvBkzz44Zlvo/LMkZ8LO0QLuq1mt5mujO6Z0LUQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N Content-Type: multipart/mixed; boundary="UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT" From: =?UTF-8?Q?Cl=c3=a9ment_Pit--Claudel?= To: bug-gnu-emacs@gnu.org Cc: Paul Eggert Message-ID: <5782DB52.1060806@live.com> Subject: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master --UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi all, Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd"= =2E On master, it displays "b" and "d" on top of each other. (with-current-buffer (get-buffer-create "*test*") (erase-buffer) (fundamental-mode) (insert "test") (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d)) (pop-to-buffer (current-buffer))) Bisecting points to the following commit: 237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit commit 237244bbd5ce753bcdf79634561de515bd76c687 Author: Paul Eggert Date: Mon May 30 16:09:25 2016 -0700 Omit IF_LINT code that no longer seems needed Nowadays GCC is smarter, or the Emacs code has mutated, or both, and now is as good a time as any to remove uses of IF_LINT that now seem to be unnecessary. (...) The small test case is courtesy of Artur; we both noticed the issue while= using his (awesome) =E2=80=98nameless=E2=80=99 package; see https://gith= ub.com/Malabarba/Nameless/issues/15 for details on the issue that prompte= d the investigation. Cheers, Cl=C3=A9ment. In GNU Emacs 25.1.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.10.8) of 2016-06-26 built on clem-w50-mint Repository revision: 431437b6593320dc5a7a8aac9c911c778a656117 Windowing system distributor 'The X.Org Foundation', version 11.0.1150100= 0 System Description: Linux Mint 17.3 Rosa --UfWNUX9oQ4WXXt89fhtve0Dak05VIS1NT-- --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXgttSAAoJEPqg+cTm90wjjJAP/3DwKp+Rbh6f2f2VY9UzRsTp dx9H1mI8+bxXbHmRq3fJdIWFbIbgtjbPO9iUBny/26VV1VhfjqYYUcNJRrp28YCb O3lqGKBrRzJyfzwezHfCWBoW0KVoQwAwCPpmEBIiWj6M8qHOQ5s9c2vz4e38d4+G sjWeRQIGyxHcscRmRoscaj7/ZdD0B9m1CJ0FcHwlJE1OOcdKfuDo7jrGfVBvK4ot zmCHOT3dbV8q6beW79zNYnhklNQWwyduY4nZtXAhd6i+RCSHVYB2e+lxYmcTRSwa aZ/+4kEPXScEjO865yto/UhfEFr17JS/0YjbCStHkkJ/XDqESyM0fpcE2/CRtBCP qWVXPeZptueOSquYsEeMpkjsbnrU5fenBNABGgA5e769LsRnA+/yePYvRDHr4GmI A2FF5QVGfeBGPhHFUp/+V/cDorTl7CtNCvKbZAIDYP398sGbYVHtk02Ew2kUzR5h 6XqQci6+jWCaGW+fx3wQaG3Pj2martJrIiC8BZU1uH1LgxcgokKV4iZKe67xy6bj CQwBfnc5EeFWypK7OUe7ZG2TNnUEWHRyuBefkQHlnmmWzD3Y4Feygrin8LNCklNB qQC241HJzhkyJALEegAb2ljZqX+Axb2c0u73LQof1DhsrwvE3hJWbMsxeUaPszGF gaa/YPHUuqj4QYhSFrfZ =o+5z -----END PGP SIGNATURE----- --QRFJCSMtwXOtWsGhfED34dcF99CI5Kb5N-- ------------=_1468246862-12270-1-- From unknown Sat Aug 09 15:18:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2016 14:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Cc: eggert@cs.ucla.edu, 23938-done@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23938-done@debbugs.gnu.org id=D23938.146824691612384 (code D ref 23938); Mon, 11 Jul 2016 14:22:01 +0000 Received: (at 23938-done) by debbugs.gnu.org; 11 Jul 2016 14:21:56 +0000 Received: from localhost ([127.0.0.1]:46944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMc5s-0003Dg-Bp for submit@debbugs.gnu.org; Mon, 11 Jul 2016 10:21:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMc5r-0003DR-Ds for 23938-done@debbugs.gnu.org; Mon, 11 Jul 2016 10:21:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMc5h-000336-Rl for 23938-done@debbugs.gnu.org; Mon, 11 Jul 2016 10:21:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMc5e-00032W-13; Mon, 11 Jul 2016 10:21:42 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3801 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMc5b-0007jw-L9; Mon, 11 Jul 2016 10:21:40 -0400 Date: Mon, 11 Jul 2016 17:21:20 +0300 Message-Id: <838tx8dzmn.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <5782DB52.1060806@live.com> (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel on Mon, 11 Jul 2016 01:33:38 +0200) References: <5782DB52.1060806@live.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Clément Pit--Claudel > Date: Mon, 11 Jul 2016 01:33:38 +0200 > Cc: Paul Eggert > > Running the following in Emacs 24 and 25-rc pops a buffer displaying "bd". On master, it displays "b" and "d" on top of each other. > > (with-current-buffer (get-buffer-create "*test*") > (erase-buffer) > (fundamental-mode) > (insert "test") > (compose-region (point-min) (point-max) '(?b (Br . Bl) ?d)) > (pop-to-buffer (current-buffer))) > > Bisecting points to the following commit: > > 237244bbd5ce753bcdf79634561de515bd76c687 is the first bad commit > commit 237244bbd5ce753bcdf79634561de515bd76c687 > Author: Paul Eggert > Date: Mon May 30 16:09:25 2016 -0700 > > Omit IF_LINT code that no longer seems needed > > Nowadays GCC is smarter, or the Emacs code has mutated, or both, > and now is as good a time as any to remove uses of IF_LINT that > now seem to be unnecessary. > (...) Thanks, fixed. From unknown Sat Aug 09 15:18:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2016 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , =?UTF-8?Q?Cl=C3=A9ment?= Pit--Claudel Cc: 23938-done@debbugs.gnu.org Received: via spool by 23938-done@debbugs.gnu.org id=D23938.146824779413880 (code D ref 23938); Mon, 11 Jul 2016 14:37:01 +0000 Received: (at 23938-done) by debbugs.gnu.org; 11 Jul 2016 14:36:34 +0000 Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMcK2-0003bn-J9 for submit@debbugs.gnu.org; Mon, 11 Jul 2016 10:36:34 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMcK0-0003bY-Vd for 23938-done@debbugs.gnu.org; Mon, 11 Jul 2016 10:36:33 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 668E6161491; Mon, 11 Jul 2016 07:36:27 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MBb2gxtGqzDy; Mon, 11 Jul 2016 07:36:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1ABF416149D; Mon, 11 Jul 2016 07:36:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bW9CbRhfqyxq; Mon, 11 Jul 2016 07:36:26 -0700 (PDT) Received: from [192.168.1.64] (171.213.196.77.rev.sfr.net [77.196.213.171]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E1E20161491; Mon, 11 Jul 2016 07:36:23 -0700 (PDT) References: <5782DB52.1060806@live.com> <838tx8dzmn.fsf@gnu.org> From: Paul Eggert Message-ID: <5783AEE3.9060101@cs.ucla.edu> Date: Mon, 11 Jul 2016 16:36:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <838tx8dzmn.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) On 07/11/2016 04:21 PM, Eli Zaretskii wrote: > Thanks, fixed. Amusingly enough, you and I independently installed exactly the same code patch, byte-for-byte, nearly simultaneously. There is no difference between commits 4ba2946369cb19dfeb258839add0658c742c12a1 and 10cfb736e2d32bd2604dc93a979ce136473b5944, and Git silently merged the two when you merged your commit into master. I don't know whether to worry about our duplicative work or to re-tell the famous war story about Ritchie and Thompson; see, for example, page 4 of: McIlroy MD. Remarks for Japan Prize award ceremony for Dennis Ritchie. 2011-05-19, Murray Hill, NJ. http://www.cs.dartmouth.edu/~doug/dmr.pdf From unknown Sat Aug 09 15:18:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jul 2016 15:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Paul Eggert Cc: clement.pitclaudel@live.com, 23938@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23938-submit@debbugs.gnu.org id=B23938.146824952016744 (code B ref 23938); Mon, 11 Jul 2016 15:06:01 +0000 Received: (at 23938) by debbugs.gnu.org; 11 Jul 2016 15:05:20 +0000 Received: from localhost ([127.0.0.1]:46984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMclr-0004M0-QY for submit@debbugs.gnu.org; Mon, 11 Jul 2016 11:05:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMclq-0004Lk-8x for 23938@debbugs.gnu.org; Mon, 11 Jul 2016 11:05:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMclf-00057B-JI for 23938@debbugs.gnu.org; Mon, 11 Jul 2016 11:05:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMclf-00055Q-GT; Mon, 11 Jul 2016 11:05:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3839 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMclY-0005Kh-31; Mon, 11 Jul 2016 11:05:01 -0400 Date: Mon, 11 Jul 2016 18:04:36 +0300 Message-Id: <83mvlocj23.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <5783AEE3.9060101@cs.ucla.edu> (message from Paul Eggert on Mon, 11 Jul 2016 16:36:19 +0200) References: <5782DB52.1060806@live.com> <838tx8dzmn.fsf@gnu.org> <5783AEE3.9060101@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > Cc: 23938-done@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 11 Jul 2016 16:36:19 +0200 > > On 07/11/2016 04:21 PM, Eli Zaretskii wrote: > > Thanks, fixed. > > Amusingly enough, you and I independently installed exactly the same > code patch, byte-for-byte, nearly simultaneously. There is no difference > between commits 4ba2946369cb19dfeb258839add0658c742c12a1 and > 10cfb736e2d32bd2604dc93a979ce136473b5944, and Git silently merged the > two when you merged your commit into master. Yep. It happens.