GNU bug report logs - #23933
25.1.50; Run a buffer-local hook with mapc

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <tino.calancha <at> gmail.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: kifer <at> cs.stonybrook.edu, 23933 <at> debbugs.gnu.org
Subject: bug#23933: 25.1.50; Run a buffer-local hook with mapc
Date: Sun, 10 Jul 2016 17:44:00 +0300

> From: Tino Calancha <tino.calancha <at> gmail.com>
> Date: Sun, 10 Jul 2016 19:18:33 +0900 (JST)
> Cc: kifer <at> cs.stonybrook.edu
> 
> --- a/lisp/vc/ediff-util.el
> +++ b/lisp/vc/ediff-util.el
> @@ -2522,7 +2522,8 @@ ediff-really-quit
>   			    (frame-selected-window warp-frame))
>   			  2 1))
> 
> -  (mapc #'funcall after-quit-hook-internal)
> +  ;; after-quit-hook-internal is buffer-local; see 
> `ediff-filegroup-action'.
> +  (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal)
>     ))

Thanks, but why do we use mapc to run hooks?  We used to have
run-hooks there.

Stefan, why did you make that change?  The log message says just "use
lexical-binding"; is something wrong with run-hooks and
lexical-binding living together?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.