GNU bug report logs - #23933
25.1.50; Run a buffer-local hook with mapc

Previous Next

Full log

Message #28 received at 23933 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, tino.calancha <at> gmail.com,
 kifer <at> cs.stonybrook.edu, 23933 <at> debbugs.gnu.org
Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc
Date: Sun, 10 Jul 2016 13:12:12 -0400

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> after-quit-hook-internal is a variable, not a hook.
>> Then how come it includes t in its value?
>
> [...] Maybe because the value of that var was copied from the value
> of an actual hook.

Yes:

(defun ediff-really-quit (reverse-default-keep-variants)
  ...
   (let (...
         (after-quit-hook-internal ediff-after-quit-hook-internal)

And as mentioned in the patch, ediff-filegroup-action calls add-hook
with non-nil LOCAL on ediff-after-quit-hook-internal.

-  (mapc #'funcall after-quit-hook-internal)
+  ;; after-quit-hook-internal is buffer-local; see `ediff-filegroup-action'.
+  (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal)
   ))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.