From unknown Mon Aug 11 02:13:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23933 <23933@debbugs.gnu.org> To: bug#23933 <23933@debbugs.gnu.org> Subject: Status: 25.1.50; Run a buffer-local hook with mapc Reply-To: bug#23933 <23933@debbugs.gnu.org> Date: Mon, 11 Aug 2025 09:13:49 +0000 retitle 23933 25.1.50; Run a buffer-local hook with mapc reassign 23933 emacs submitter 23933 Tino Calancha severity 23933 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 06:18:49 2016 Received: (at submit) by debbugs.gnu.org; 10 Jul 2016 10:18:49 +0000 Received: from localhost ([127.0.0.1]:44608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMBp3-0004G2-IG for submit@debbugs.gnu.org; Sun, 10 Jul 2016 06:18:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56978) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMBp2-0004Fo-DP for submit@debbugs.gnu.org; Sun, 10 Jul 2016 06:18:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMBow-00050A-9D for submit@debbugs.gnu.org; Sun, 10 Jul 2016 06:18:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMBow-0004zw-62 for submit@debbugs.gnu.org; Sun, 10 Jul 2016 06:18:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMBou-00082y-0K for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 06:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMBos-0004yV-0Y for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 06:18:38 -0400 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:36361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMBor-0004yR-PP for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2016 06:18:37 -0400 Received: by mail-pa0-x234.google.com with SMTP id hu1so13183483pad.3 for ; Sun, 10 Jul 2016 03:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:message-id:user-agent:mime-version; bh=c4Ltn1OJHAvG16iOBvk9P+J+lUwYyerYCXJ3K7Hp4wE=; b=aatPDVMwCD9ODOlOQP+JYNgK8LqsHx0/UiCOsO6ImAZFhPY0mcVEPT95wbCVdbDLJg 9UZ4oKt8OzMvmlnBmivDI0FToN+nDSG+WM+n9RYsvoac67Ny39hTtQAJXujqNGATSO5D XIs0QHZHQrCYc4SFAs+41vDz/8hO5/OD1mUM3VnEJbhFLCYTp4yfqR4TeZcreKqRmrqi nR20wiRU3L9NEkocnSLl3Sd7ZaNRgUdL6ZQIgUL4x0kKdosp14EU3SWBNFgzf5xzZFTz IAQzb6bdD+v1M+2yiMCQ3vqQ2tam0G9dDtPyowZ2jqiGYuftnhYy9Y7lVhEi617yrdeY vYRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:message-id:user-agent :mime-version; bh=c4Ltn1OJHAvG16iOBvk9P+J+lUwYyerYCXJ3K7Hp4wE=; b=YFLOWYzonohq7QfDqTO5/m368Zo+G2WHAEyVMchWYyUdnuDvzciGjwoRPrI8F7J7He RorQ60c0nln272bj316sTZDzTBdRqh3bq8d9Rw9hS80lF+6ETzX5G/35hbNNURuC3UgV OCJTpAnJnIg0nQqVBn8ll0DUyrajGPWR4JpF76sLNj3Te82P/ou4i5kiXIjK5DmDU2Ge rKUwYBE/xd7hu8nvrpX1gKUIn6xQ8wiAB0CUdAdfDdYiIqCBj5YiF8MLmObx6UgCf5VZ mnPsWYM0+UrcKIncTPEybZOHJ7KLl9pMPOMtOth6l/etD7b4SeLypxTxhXqp1DTBSSCR O0FQ== X-Gm-Message-State: ALyK8tJLXWCYu3l9XNqOJUad2W7fXs7XEig3hjxS31vlP4CDR0rz/qB4ZjOsMno+ZDwO3Q== X-Received: by 10.66.175.45 with SMTP id bx13mr25181893pac.23.1468145917114; Sun, 10 Jul 2016 03:18:37 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id d130sm2105884pfd.80.2016.07.10.03.18.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 03:18:36 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 10 Jul 2016 19:18:33 +0900 (JST) X-X-Sender: calancha@calancha-pc To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Run a buffer-local hook with mapc Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-449062787-1468145916=:28079" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: kifer@cs.stonybrook.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --8323329-449062787-1468145916=:28079 Content-Type: text/plain; format=flowed; charset=ISO-8859-7 Content-Transfer-Encoding: 8BIT Prevent calling (funcall t) when running a buffer-local hook as (mapc #'funcall LOCAL-HOOK). emacs -Q /tmp M-! for f in foo bar foo-new bar-new; do echo $f>/tmp/$f;done RET M-! for f in foo bar; do diff -u /tmp/$f /tmp/${f}-new >> /tmp/patch;done RET M-x epatch RET n patch RET C-k RET y n v q y ;; funcall: Symbol¢s function definition is void: t ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From de693cda8c6a174149b523fb4adcfae6d28bc202 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 10 Jul 2016 18:02:16 +0900 Subject: [PATCH] Run a buffer-local hook with mapc * lisp/vc/ediff-util.el (ediff-really-quit): Avoid to apply funcall on 't' (Bug#23933). --- lisp/vc/ediff-util.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a6b88d5..3d2b9a3 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -2522,7 +2522,8 @@ ediff-really-quit (frame-selected-window warp-frame)) 2 1)) - (mapc #'funcall after-quit-hook-internal) + ;; after-quit-hook-internal is buffer-local; see `ediff-filegroup-action'. + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) )) ;; Returns frame under mouse, if this frame is not a minibuffer -- 2.8.1 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; In GNU Emacs 25.1.50.5 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) of 2016-07-10 Repository revision: 466ee1b3ea76425d201b5d59950e88251870c836 Ediff 2.81.5 of July 4, 2013; --8323329-449062787-1468145916=:28079-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 06:20:52 2016 Received: (at control) by debbugs.gnu.org; 10 Jul 2016 10:20:52 +0000 Received: from localhost ([127.0.0.1]:44613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMBr2-0004K3-1u for submit@debbugs.gnu.org; Sun, 10 Jul 2016 06:20:52 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:34439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMBr0-0004Jo-P0 for control@debbugs.gnu.org; Sun, 10 Jul 2016 06:20:51 -0400 Received: by mail-pa0-f48.google.com with SMTP id fi15so12413223pac.1 for ; Sun, 10 Jul 2016 03:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=syk1IlfacX9lH36fVwXVOPck0/KDU+79pBgDKmpNy5s=; b=c2++P7wp2uo11yFzYeWw2Rd4nXICsxtIEZD26oCpvRBjNheVr7Ly1RBTxuX6yKotVD 6iJ9ZaHLbvtOQ/sbJL8n2AmeKn3LqUd3G3b3oYf5ge4EwXY6zX8dkRb5yO/ZFs9bWsB0 qbMs9MRKcsoV+62vbUpDAZtTF5HqvIXotBxIpbNt9/ZSMCzXWs/VyPHaJshQqmTAbRNx LsP17+7cOP+aoOFg9B1yw5zNdSQilUnkPp6O03SFDaDzyvPFPBfkHF00ILjd00WdVTIM PvASFbGln5W5rIxHi+BcTw6LUA3VNriXj03ronn5m7OF16BwwvjtJPSESKUaz+JmIbrs QoJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=syk1IlfacX9lH36fVwXVOPck0/KDU+79pBgDKmpNy5s=; b=USUU7BixvZ6HTW/2w4NNCkHeLsStfpALytB/dLjnZxBB96T6/mKSJiFwsdJxL39Ky8 2QDJahpS8u3uR1IUGj0G0ISw+MdrOYq5qUrLCtrMDdpuaOPEOxXyRk9hSvztMKaZk9gI VGeuCbPSF7ImyiWqch6M0yjwAjCIiXxQc1Jfx1WmHes1YTUYBGV68kQQPOHDo47oNRaR koIA+0QOc2N6qkNG/J0J9w//qvBMfKubkCWM5GQV5MaMcg/CB799wPsiocGwSgUBHX+z 5lovo0Ky3Pb3AtW9Vf/uzMrw/7gR4i4gxnDu+Tg3cDsjuMhXgcFZC+eMUlYu95d3tQ6o uQ8A== X-Gm-Message-State: ALyK8tLb34kts/Hx2+dM3sC/MehYd/clyrgkXNuOi40vMIBmqo9/7eJ14WAQUoinP1wXNw== X-Received: by 10.66.118.169 with SMTP id kn9mr25181436pab.109.1468146044899; Sun, 10 Jul 2016 03:20:44 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id x68sm1916757pfb.88.2016.07.10.03.20.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 03:20:44 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 10 Jul 2016 19:20:41 +0900 (JST) X-X-Sender: calancha@calancha-pc To: control@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 23933 minor [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.48 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.48 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: severity 23933 minor [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.48 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.48 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid severity 23933 minor From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 10:44:20 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 14:44:20 +0000 Received: from localhost ([127.0.0.1]:45227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMFxz-0007EB-La for submit@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMFxy-0007Dz-4V for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMFxs-0007qu-7f for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 10:44:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMFxn-0007pf-KC; Sun, 10 Jul 2016 10:44:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2854 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMFxl-0006ya-6B; Sun, 10 Jul 2016 10:44:05 -0400 Date: Sun, 10 Jul 2016 17:44:00 +0300 Message-Id: <83d1mlft8v.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha , Stefan Monnier In-reply-to: (message from Tino Calancha on Sun, 10 Jul 2016 19:18:33 +0900 (JST)) Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Sun, 10 Jul 2016 19:18:33 +0900 (JST) > Cc: kifer@cs.stonybrook.edu > > --- a/lisp/vc/ediff-util.el > +++ b/lisp/vc/ediff-util.el > @@ -2522,7 +2522,8 @@ ediff-really-quit > (frame-selected-window warp-frame)) > 2 1)) > > - (mapc #'funcall after-quit-hook-internal) > + ;; after-quit-hook-internal is buffer-local; see > `ediff-filegroup-action'. > + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) > )) Thanks, but why do we use mapc to run hooks? We used to have run-hooks there. Stefan, why did you make that change? The log message says just "use lexical-binding"; is something wrong with run-hooks and lexical-binding living together? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 11:19:04 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 15:19:04 +0000 Received: from localhost ([127.0.0.1]:45305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMGVb-0002v6-Q2 for submit@debbugs.gnu.org; Sun, 10 Jul 2016 11:19:03 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:58633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMGVa-0002ub-1h for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 11:19:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BCFgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAR6LOoUFB4QtBbM/gUUjhBQigngBAQE X-IPAS-Result: A0BCFgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEEViMQCzQSFBgNJIg/zyMBAQEBAQEEAQEBAR6LOoUFB4QtBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247254624" Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 10 Jul 2016 11:18:56 -0400 Received: by pastel.home (Postfix, from userid 20848) id 27286629E6; Sun, 10 Jul 2016 11:18:56 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc Message-ID: References: <83d1mlft8v.fsf@gnu.org> Date: Sun, 10 Jul 2016 11:18:56 -0400 In-Reply-To: <83d1mlft8v.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2016 17:44:00 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> - (mapc #'funcall after-quit-hook-internal) >> + ;; after-quit-hook-internal is buffer-local; see `ediff-filegroup-action'. >> + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) >> )) > Thanks, but why do we use mapc to run hooks? We used to have > run-hooks there. after-quit-hook-internal is a variable, not a hook. A hook is a symbol whose symbol-value slot holds a list of functions; this happens to match a dynamically-bound variable, but not a lexically-bound variable. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 11:55:40 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 15:55:40 +0000 Received: from localhost ([127.0.0.1]:45334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMH51-0005PU-TN for submit@debbugs.gnu.org; Sun, 10 Jul 2016 11:55:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMH50-0005PI-RU for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 11:55:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMH4u-00047i-JE for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 11:55:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMH4q-00047J-Tw; Sun, 10 Jul 2016 11:55:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2902 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMH4o-0000Jf-IY; Sun, 10 Jul 2016 11:55:27 -0400 Date: Sun, 10 Jul 2016 18:55:21 +0300 Message-Id: <8337nhfpxy.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sun, 10 Jul 2016 11:18:56 -0400) Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Stefan Monnier > Cc: Tino Calancha , 23933@debbugs.gnu.org, kifer@cs.stonybrook.edu > Date: Sun, 10 Jul 2016 11:18:56 -0400 > > >> - (mapc #'funcall after-quit-hook-internal) > >> + ;; after-quit-hook-internal is buffer-local; see `ediff-filegroup-action'. > >> + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) > >> )) > > Thanks, but why do we use mapc to run hooks? We used to have > > run-hooks there. > > after-quit-hook-internal is a variable, not a hook. Then how come it includes t in its value? > A hook is a symbol whose symbol-value slot holds a list of functions; > this happens to match a dynamically-bound variable, but not > a lexically-bound variable. So you are saying we should convert that variable to a hook? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 11:57:10 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 15:57:10 +0000 Received: from localhost ([127.0.0.1]:45338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMH6U-0005Rx-A8 for submit@debbugs.gnu.org; Sun, 10 Jul 2016 11:57:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMH6S-0005Ri-Ut for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 11:57:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMH6N-0004Il-2i for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 11:57:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMH6J-0004IS-Bm; Sun, 10 Jul 2016 11:56:59 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2903 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMH6I-0000Zi-AJ; Sun, 10 Jul 2016 11:56:58 -0400 Date: Sun, 10 Jul 2016 18:56:53 +0300 Message-Id: <831t31fpve.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sun, 10 Jul 2016 11:18:56 -0400) Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Stefan Monnier > Cc: Tino Calancha , 23933@debbugs.gnu.org, kifer@cs.stonybrook.edu > Date: Sun, 10 Jul 2016 11:18:56 -0400 > > A hook is a symbol whose symbol-value slot holds a list of functions; > this happens to match a dynamically-bound variable, but not > a lexically-bound variable. Maybe I misunderstand this, but are you saying a hook (and run-hooks) cannot be used in a file that uses lexical-binding? If so, we had better documented that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:02:05 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:02:05 +0000 Received: from localhost ([127.0.0.1]:45447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMI7I-0000Gt-Mc for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:02:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:30590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMI7G-0000BM-Rv for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:02:03 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A5FgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fsz+BRSOEFCKCeAEBAQ X-IPAS-Result: A0A5FgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PBEBAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fsz+BRSOEFCKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247279722" Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 10 Jul 2016 13:01:57 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0A33E64151; Sun, 10 Jul 2016 13:01:56 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> Date: Sun, 10 Jul 2016 13:01:55 -0400 In-Reply-To: <8337nhfpxy.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2016 18:55:21 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> after-quit-hook-internal is a variable, not a hook. > Then how come it includes t in its value? A variable can very well hold a list with t inside. As to why/where was this t added, I don't know. It's probably a good idea to try and track it down. Maybe because the value of that var was copied from the value of an actual hook. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:02:50 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:02:50 +0000 Received: from localhost ([127.0.0.1]:45450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMI82-0000Hs-2P for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:02:50 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:6881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMI80-0000Hg-CB for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:02:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0BCFgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fsz+BRSOEFCKCeAEBAQ X-IPAS-Result: A0BCFgA731xV/3mcpUVcgxCEAoVVwD6CTQQCAoE8PRABAQEBAQEBgQpBBYNdAQEDAVYjEAs0EhQYDSSINwjPIwEBAQEBAQQBAQEBHos6hQUHhC0Fsz+BRSOEFCKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247279762" Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 10 Jul 2016 13:02:42 -0400 Received: by pastel.home (Postfix, from userid 20848) id C927B64151; Sun, 10 Jul 2016 13:02:42 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc Message-ID: References: <83d1mlft8v.fsf@gnu.org> <831t31fpve.fsf@gnu.org> Date: Sun, 10 Jul 2016 13:02:42 -0400 In-Reply-To: <831t31fpve.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2016 18:56:53 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> A hook is a symbol whose symbol-value slot holds a list of functions; >> this happens to match a dynamically-bound variable, but not >> a lexically-bound variable. > Maybe I misunderstand this, but are you saying a hook (and run-hooks) > cannot be used in a file that uses lexical-binding? If so, we had > better documented that. No, the issue is simply that `run-hooks' takes a symbol as argument. You can do (run-hooks ') because (symbol-value ') works, but you can't do (run-hooks ') because (symbol-value ') won't work. Using `run-hooks' on a let-bound variable is just a bad idea (just like mixing let-binding and buffer-local binding on the same variable is asking for trouble). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:12:21 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:12:21 +0000 Received: from localhost ([127.0.0.1]:45469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIHF-0000Vy-4z for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:12:21 -0400 Received: from mail-io0-f176.google.com ([209.85.223.176]:34393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIHE-0000Vl-7A for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:12:20 -0400 Received: by mail-io0-f176.google.com with SMTP id q83so19361829iod.1 for <23933@debbugs.gnu.org>; Sun, 10 Jul 2016 10:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lpGEGr/14yc/T+JqK0RPffDZD0crbJ0n03Jq7TV/1Sk=; b=JKQqDbzkG+ZrbzA95vET3ywTPSj5mHBToDEUUzmsNZnc4USvsV3JSqRhztfhioKh2H ZthCdph4jRsP2nwz6UWNxvQhNyzf5fiuVrefAQ4jIK2k4FaiBoMPQWrGP/uHCJVopwXw V0f6UTGFS9jw1XiYxcVaFu9HL6b6eNpkZCe0W2zrRsvIdqnF5R+qe5Sa7Y/DHi29ZQS7 NCqXuaEKloc2D5syK3QF5EHI9cKQMgLepTtdnyksGpavqLVxUjSSnCGi1DeiF+7/fD19 39C8Il1oy8iJBWzdiRn+3xkWZpLA3aijISnaNbGe23hGjYR5AhxUeVJnFELYXDfSsUl8 jO1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=lpGEGr/14yc/T+JqK0RPffDZD0crbJ0n03Jq7TV/1Sk=; b=adz6ypPo+0B/9FOYgZxlkSTR5FPgEy5r6lCaQAWKuqsgevlmTGtpjmz76cHTn8igjA HPGPos8bDlUXqHjA877tUp0dAS/1bG5ogE9JlFh44Cf+n1DcvlFXzEFAfDtojEK2xHH0 fRQwvgU0up3IDwyVfsGxuXisu6QtSU00KFyXZzUKY5Y4oAEOaRu+df3T4M9uVdnOYRrE rc8qXzgUQls1lywUdbx3cCZUopy+nOkReChbP5u8fPyNtfu5RmaK3/ZHlQ/u4KdPqYST lPq86G5uBNDzASk1c2ipzyZ5ALECJvCV0XQAK0PJwGSZXDQP0bgc9ydKFZ4WjOrAWRwF VwKA== X-Gm-Message-State: ALyK8tJh89hig1J2UvZV6EqHPlGWe6ristMYwxL1bd6fy2rTAd5dh4Dp3bcaf1y4HV9Bdg== X-Received: by 10.107.132.144 with SMTP id o16mr16427928ioi.37.1468170734712; Sun, 10 Jul 2016 10:12:14 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id l1sm5845994ite.4.2016.07.10.10.12.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 10:12:14 -0700 (PDT) From: npostavs@users.sourceforge.net To: Stefan Monnier Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> Date: Sun, 10 Jul 2016 13:12:12 -0400 In-Reply-To: (Stefan Monnier's message of "Sun, 10 Jul 2016 13:01:55 -0400") Message-ID: <87furhh0yb.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: Eli Zaretskii , tino.calancha@gmail.com, kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: >>> after-quit-hook-internal is a variable, not a hook. >> Then how come it includes t in its value? > > [...] Maybe because the value of that var was copied from the value > of an actual hook. Yes: (defun ediff-really-quit (reverse-default-keep-variants) ... (let (... (after-quit-hook-internal ediff-after-quit-hook-internal) And as mentioned in the patch, ediff-filegroup-action calls add-hook with non-nil LOCAL on ediff-after-quit-hook-internal. - (mapc #'funcall after-quit-hook-internal) + ;; after-quit-hook-internal is buffer-local; see `ediff-filegroup-action'. + (mapc (lambda (f) (or (eq f t) (funcall f))) after-quit-hook-internal) )) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:16:05 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:16:05 +0000 Received: from localhost ([127.0.0.1]:45481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIKr-0000ci-4V for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:16:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIKp-0000c0-JB for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:16:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMIKj-00066M-Mn for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:15:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMIKg-00063U-0C; Sun, 10 Jul 2016 13:15:54 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3122 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMIKe-0004e1-CV; Sun, 10 Jul 2016 13:15:52 -0400 Date: Sun, 10 Jul 2016 20:15:46 +0300 Message-Id: <83poqle7nh.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-reply-to: (message from Stefan Monnier on Sun, 10 Jul 2016 13:01:55 -0400) Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Stefan Monnier > Cc: tino.calancha@gmail.com, 23933@debbugs.gnu.org, kifer@cs.stonybrook.edu > Date: Sun, 10 Jul 2016 13:01:55 -0400 > > >> after-quit-hook-internal is a variable, not a hook. > > Then how come it includes t in its value? > > A variable can very well hold a list with t inside. As to why/where was > this t added, I don't know. It's probably a good idea to try and track > it down. Maybe because the value of that var was copied from the value > of an actual hook. Tino, can you figure out why t is there? Perhaps the solution is simply to remove it? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:32:04 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:32:04 +0000 Received: from localhost ([127.0.0.1]:45521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIaJ-00014O-VY for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:32:04 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIaI-00013u-9m for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:32:02 -0400 Received: by mail-pf0-f175.google.com with SMTP id i123so27921780pfg.0 for <23933@debbugs.gnu.org>; Sun, 10 Jul 2016 10:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=2uKmMvsesJ1q7VuaUZxSZgbujUiDy1MAZCLlnhgNxnI=; b=jQYfdhKIaiD4TpHsf8lRV2sz0GARilQ4YDzoGwFq/MpWhZr2cqm8mTDye5dMrD+Nk9 IB5qONeATifhJ1RUdjLL4xRUEia5zlN4e7XdNmLnrl+S5g6Ms4cduOkmpME8cbH3Kt9Q 8Z5b8jNSFtNacQUGAgBrrdeDsz+qFsMCZfm5vSnHvMrHuyrVGDK9g1Gq1AUfXdSQI2xS mMubj6pVDaopz7Kho/8lnFm1tXw1tu2DpHhQzOPfPkLvykTlyImIBEj6OOSZJq4ZRoZY yTzA0cLByLw/eLJxfUA4TPjJjM9AEcwsykRqYk6KGv2JrRPa5EZvsOw9OOBgS7L3L3zg 5isw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=2uKmMvsesJ1q7VuaUZxSZgbujUiDy1MAZCLlnhgNxnI=; b=D9JmZQG5HYqMM08dxUVxJ9uq7oxDcJ8WP70rCrGApMb/QiwkKPxtQVqGE3ihsoVJk8 psx4TCzvnbkocA788iRZ7d/OkvGhaHeUGvyspwAOyVCUElpyEbCTE8OCo3t7kuiF1d6b I17eLIRTbT5qrpULqU7cFqi2crBVyabCplxaZnAsQz/iCexQX6EjqYVGy/61xnImTCfh 5/Rw+cENXADCBHsS1mNbLpWyydDiQ/O+XFePAOuk7AfmmsbrgUdcIgZwNpoQeAyDLpbp ke8eD+dlJjAViLJ612tLV33Nq2O4OkJFjV7DXjQ0vRind8MYFbOkPAHqlXAsHtsSzJ2j 5LCA== X-Gm-Message-State: ALyK8tLOOotvzeMzpOuwFgq2C3cuS3lQuxR1SrPRmq1uVsvFyQ7KJLMw8qPai/6yeaZFvA== X-Received: by 10.98.65.2 with SMTP id o2mr27999027pfa.97.1468171916746; Sun, 10 Jul 2016 10:31:56 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id o68sm3845571pfb.18.2016.07.10.10.31.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 10:31:56 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 11 Jul 2016 02:31:52 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc In-Reply-To: <83poqle7nh.fsf@gnu.org> Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <83poqle7nh.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: npostavs@users.sourceforge.net, kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, Stefan Monnier , tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 10 Jul 2016, Eli Zaretskii wrote: > Tino, can you figure out why t is there? Perhaps the solution is > simply to remove it? Just explained in previous e-mail by Noam. I have tried another approach: drop the let binding and call run-hooks over the actual hook, as follows: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a6b88d5..b50ac6d 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -2439,7 +2439,6 @@ ediff-really-quit ;; restore buffer mode line id's in buffer-A/B/C (let ((control-buffer ediff-control-buffer) (meta-buffer ediff-meta-buffer) - (after-quit-hook-internal ediff-after-quit-hook-internal) (session-number ediff-meta-session-number) ;; suitable working frame (warp-frame (if (and (ediff-window-display-p) (eq ediff-grab-mouse t)) @@ -2522,7 +2521,7 @@ ediff-really-quit (frame-selected-window warp-frame)) 2 1)) - (mapc #'funcall after-quit-hook-internal) + (run-hooks 'ediff-after-quit-hook-internal) )) ;; Returns frame under mouse, if this frame is not a minibuffer ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; but it doesn't work: the meta-buffer is not shown. I prefer my initial patch which behaves the same as before adding the lexical-binding. Tino From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:41:59 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:41:59 +0000 Received: from localhost ([127.0.0.1]:45525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIju-0001Hy-UE for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:41:59 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:32825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIjt-0001Hk-85 for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:41:57 -0400 Received: by mail-oi0-f52.google.com with SMTP id u201so120413663oie.0 for <23933@debbugs.gnu.org>; Sun, 10 Jul 2016 10:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3T8eq5yQYdY3o/8Pnyb98W0x0tavr1g0twIaP00XF6U=; b=HcazYricXZVEHY7YBLeQLVRLe9/mBmGvWLcNj/YEwD5HeCu1eHPTE24zXcBGaDcofB MD8SuyyI2mHy9MAYOCpCxLXDLna/aSX4p3/dc4x34h3IcbUbTLGzJJNcEFIqYHy9T0ug RK5Rn/O4qMIPJcKWl4SWbjtQ5XgXEvb8H9w2Fum7rcch1VaZooAZ8vKc64/MMkHCQYMo aaVMATZ/kMVPmOxsW42KH19DqDzsuidV3MxLmql18KT6QvFHVffY2Wxq+9GhZcOqmQRV aruY8nIcZK/noLiHvoejryPwy+9vROopTSldmUo76pwo1lIqqV4bUB4fZZKemXgG5gOw xdQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3T8eq5yQYdY3o/8Pnyb98W0x0tavr1g0twIaP00XF6U=; b=Dy7elNSpbPOwvTLrzRgo+/DonqQR/qNcZvMID+8FVe0eVP1USQtcpp9/jrbk7lZ0dh bC4xp+vkE1GqHMxjU7E3V5M8uJqOFBEKDP/rHlA6D+yTPUgL4YlOQTLfXn2q29PSOcxv wn3n8gXe7tKfmt5tAfIka6mo/PBdL4iNBQmzywYhTMj7xRwOVzAuNvj9/ZR+cW3m0TD3 s7PiZn2JRs9pUo7XXifKV5Jpbc6SX1Wl3scnj0RSbpOPujCimEsfWCfO58Brt5hbFQsl QbyEzwXKnk3hXI+n093d28fKyxi4XkLF3awULaxoHm6rhjV3S3Rp4vX6j41tPx8c3Tca 76ag== X-Gm-Message-State: ALyK8tLZ4lu85fNa3uplnlpJ5CwIB7pVYJEHtCN41Sjws5SJmyHWP4hVR3KyDcjERUNGN+lkBE8r+0x4Jh6AaQ== X-Received: by 10.157.36.227 with SMTP id z90mr8891228ota.124.1468172511553; Sun, 10 Jul 2016 10:41:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.4.197 with HTTP; Sun, 10 Jul 2016 10:41:51 -0700 (PDT) In-Reply-To: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <83poqle7nh.fsf@gnu.org> From: Noam Postavsky Date: Sun, 10 Jul 2016 13:41:51 -0400 X-Google-Sender-Auth: s-YLPj5TX_gJS-LVYKgKKhWC7a8 Message-ID: Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc To: Tino Calancha Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: Eli Zaretskii , kifer@cs.stonybrook.edu, Stefan Monnier , 23933@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Jul 10, 2016 at 1:31 PM, Tino Calancha wrote: > I have tried another approach: drop the let binding > and call run-hooks over the actual hook, as follows: [...] > but it doesn't work: the meta-buffer is not shown. > I prefer my initial patch which behaves the same as before > adding the lexical-binding. The easiest fix might be to just make after-quit-hook-internal a dynamic variable (i.e., declare it with defvar). But perhaps better is to stop using add-hook for ediff-after-quit-hook-internal, and just use push. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 13:52:42 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 17:52:42 +0000 Received: from localhost ([127.0.0.1]:45560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIuH-0001ZA-TP for submit@debbugs.gnu.org; Sun, 10 Jul 2016 13:52:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMIuG-0001Yv-OW for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:52:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMIuA-0006Eq-SN for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 13:52:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMItt-0006A3-TG; Sun, 10 Jul 2016 13:52:17 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3284 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMItr-0004Y8-Nw; Sun, 10 Jul 2016 13:52:16 -0400 Date: Sun, 10 Jul 2016 20:52:07 +0300 Message-Id: <83k2gte5yw.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Mon, 11 Jul 2016 02:31:52 +0900 (JST)) Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <83poqle7nh.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23933 Cc: npostavs@users.sourceforge.net, kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, monnier@iro.umontreal.ca, tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Mon, 11 Jul 2016 02:31:52 +0900 (JST) > cc: Stefan Monnier , tino.calancha@gmail.com, > 23933@debbugs.gnu.org, kifer@cs.stonybrook.edu, > npostavs@users.sourceforge.net > > > Tino, can you figure out why t is there? Perhaps the solution is > > simply to remove it? > Just explained in previous e-mail by Noam. > I have tried another approach: drop the let binding > and call run-hooks over the actual hook, as follows: Can't we simply remove the t? If not, why not? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 14:14:59 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 18:14:59 +0000 Received: from localhost ([127.0.0.1]:45599 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMJFr-00027J-2P for submit@debbugs.gnu.org; Sun, 10 Jul 2016 14:14:59 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:35497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMJFq-00026u-2j for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 14:14:58 -0400 Received: by mail-pf0-f176.google.com with SMTP id c2so28384335pfa.2 for <23933@debbugs.gnu.org>; Sun, 10 Jul 2016 11:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=0Z0kx/SeqmB38QCmpXVJcuq5VakO1PDUREbrVAhG9A0=; b=RG0sc5/GdgPfgSY2jpeYdRSWzhf+e98VvuJ3ttEppVxVlw0e4m9vxyjFo7qv6q6MZJ ftuNybUVwMdRMzty2IvcOOveNT/tYupMxUzNJXzvHeBT9MCs2kTE1NpMoSpmLzVGuVZo zHp5KGDmmS5EJjZfoYWJdjBXw+OYSiO9grwurYybwBeAjo5Oa7idFibkbSJyvVVlH7iG SZl8MNQzVNrZH6X3CGPTZlLk/ZRdZvdm0hWHCyQxowA3jOOVKCJeZUoEE+JuO+CIBycy Hucws/W4RPY5y00RoixJcOXXyifMUSLQ9Ughxx4f0XtUjnv+epMTGy3zzF4LKgrFRzWF xMPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=0Z0kx/SeqmB38QCmpXVJcuq5VakO1PDUREbrVAhG9A0=; b=bjUK6Q5QO6kJYbFwGGRqtg4NZ/1yO78PH0M306e68/9EjNHL6H7E3noblSj0DJ5FTF e2pSvDf4Ie2vHfl0atMqmfxuvZayVbwDCVAlr8bDbOlj0gaZmPTtAD19D+56PAoNIvxY w9zZOYuvn1zDDHk+mjbwrouBE+QA9HpxMy1f05xu8Nbzp0G871XfOwIcIE9wYBPLQY53 D31Dy3qSt5VimWec4yiOcutCPUh/Cc+rRDC9Ku5ngk4VRfhzy6LqZ5FQAXXDm/7Kb5Cc tq757evyJHh0wFycEb2TvAc6bTd28aXQSMcBAIoskVuMwHNf2WBs6+jb9QU7TsJK1iid u6Xg== X-Gm-Message-State: ALyK8tLWh4HbqP36R3MoaGpxNnrKx/g/27Lo19i08Nnla9nd3MB5c2bYDh0dETParZ3rVA== X-Received: by 10.98.33.138 with SMTP id o10mr27899015pfj.151.1468174492421; Sun, 10 Jul 2016 11:14:52 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id b7sm1360980pat.27.2016.07.10.11.14.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 Jul 2016 11:14:51 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Mon, 11 Jul 2016 03:14:48 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc In-Reply-To: <83k2gte5yw.fsf@gnu.org> Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <83poqle7nh.fsf@gnu.org> <83k2gte5yw.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: npostavs@users.sourceforge.net, kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, monnier@iro.umontreal.ca, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 10 Jul 2016, Eli Zaretskii wrote: > Can't we simply remove the t? If not, why not? Yes, we can and it is more readable: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/lisp/vc/ediff-util.el b/lisp/vc/ediff-util.el index a6b88d5..f98c2f4 100644 --- a/lisp/vc/ediff-util.el +++ b/lisp/vc/ediff-util.el @@ -2522,7 +2522,7 @@ ediff-really-quit (frame-selected-window warp-frame)) 2 1)) - (mapc #'funcall after-quit-hook-internal) + (mapc #'funcall (delq t after-quit-hook-internal)) )) ;; Returns frame under mouse, if this frame is not a minibuffer ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; I also tried Noam suggestion about using push instead of add-hook on ediff-after-quit-hook-internal, that works also OK: ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; diff --git a/lisp/vc/ediff-mult.el b/lisp/vc/ediff-mult.el index 7f0db5d..a092218 100644 --- a/lisp/vc/ediff-mult.el +++ b/lisp/vc/ediff-mult.el @@ -1904,13 +1904,12 @@ ediff-filegroup-action file1 file2 ;; provide startup hooks `(list (lambda () - (add-hook - 'ediff-after-quit-hook-internal + (push (lambda () (if (ediff-buffer-live-p ,(current-buffer)) (ediff-show-meta-buffer ,(current-buffer) ,session-number))) - nil 'local) + ediff-after-quit-hook-internal) (setq ediff-meta-buffer ,(current-buffer) ediff-meta-session-number ,session-number) @@ -1933,15 +1932,14 @@ ediff-filegroup-action file1 ;; provide startup hooks `(list (lambda () - (add-hook - 'ediff-after-quit-hook-internal + (push (lambda () (if (ediff-buffer-live-p ,(current-buffer)) (ediff-show-meta-buffer ,(current-buffer) ,session-number))) - nil 'local) + ediff-after-quit-hook-internal) (setq ediff-meta-buffer ,(current-buffer) ediff-meta-session-number ,session-number) @@ -1962,15 +1960,14 @@ ediff-filegroup-action file1 file2 ;; provide startup hooks `(list (lambda () - (add-hook - 'ediff-after-quit-hook-internal + (push (lambda () (if (ediff-buffer-live-p ,(current-buffer)) (ediff-show-meta-buffer ,(current-buffer) ,session-number))) - nil 'local) + ediff-after-quit-hook-internal) (setq ediff-meta-buffer ,(current-buffer) ediff-meta-session-number ,session-number) @@ -1991,15 +1988,14 @@ ediff-filegroup-action file1 file2 file3 ;; arrange startup hooks `(list (lambda () - (add-hook - 'ediff-after-quit-hook-internal + (push (lambda () (if (ediff-buffer-live-p ,(current-buffer)) (ediff-show-meta-buffer ,(current-buffer) ,session-number))) - nil 'local) + ediff-after-quit-hook-internal) (setq ediff-merge-store-file ,(if (ediff-nonempty-string-p merge-autostore-dir) ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; What aproach looks better? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 14:28:22 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 18:28:22 +0000 Received: from localhost ([127.0.0.1]:45613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMJSo-0002SD-7x for submit@debbugs.gnu.org; Sun, 10 Jul 2016 14:28:22 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:39356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMJSm-0002S4-Cw for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 14:28:20 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3rncDL50Fqz3hjV6; Sun, 10 Jul 2016 20:28:18 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3rncDL3kbgzvkHt; Sun, 10 Jul 2016 20:28:18 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id BzptZuyJCNf2; Sun, 10 Jul 2016 20:28:17 +0200 (CEST) X-Auth-Info: 1kdLHOokXK0u0tgTnmmQd5dbfszqSgQILcfL+dWRK0HUtuYEJhT2Jb4pSBxnfAff Received: from igel.home (ppp-88-217-3-50.dynamic.mnet-online.de [88.217.3.50]) by mail.mnet-online.de (Postfix) with ESMTPA; Sun, 10 Jul 2016 20:28:17 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 19EDE2C2D79; Sun, 10 Jul 2016 20:28:17 +0200 (CEST) From: Andreas Schwab To: Eli Zaretskii Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc References: <83d1mlft8v.fsf@gnu.org> <831t31fpve.fsf@gnu.org> X-Yow: I want DUSTIN HOFFMAN!! .. I want LIBERACE!! YOW!! Date: Sun, 10 Jul 2016 20:28:17 +0200 In-Reply-To: <831t31fpve.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2016 18:56:53 +0300") Message-ID: <87inwd2vr2.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org, Stefan Monnier , tino.calancha@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Maybe I misunderstand this, but are you saying a hook (and run-hooks) > cannot be used in a file that uses lexical-binding? A hook is always a global variable. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 10 17:12:35 2016 Received: (at 23933) by debbugs.gnu.org; 10 Jul 2016 21:12:35 +0000 Received: from localhost ([127.0.0.1]:45714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMM1j-0006Ox-0j for submit@debbugs.gnu.org; Sun, 10 Jul 2016 17:12:35 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:44035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMM1h-0006Oj-Rp for 23933@debbugs.gnu.org; Sun, 10 Jul 2016 17:12:34 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA2IWwjPIwEBAQEBAQQBAQEBHos6hQUHFoQXBbM/gUUjhBQigngBAQE X-IPAS-Result: A0CXDQA731xV/3mcpUVcgxCEAsEVhH6CTQQCAoE8OxIBAQEBAQEBgQpBBYNdAQEDAVYjBQsLNBIUGA2IWwjPIwEBAQEBAQQBAQEBHos6hQUHFoQXBbM/gUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="247347534" Received: from 69-165-156-121.dsl.teksavvy.com (HELO pastel.home) ([69.165.156.121]) by ironport2-out.teksavvy.com with ESMTP; 10 Jul 2016 17:12:27 -0400 Received: by pastel.home (Postfix, from userid 20848) id EBDBE64151; Sun, 10 Jul 2016 17:12:27 -0400 (EDT) From: Stefan Monnier To: npostavs@users.sourceforge.net Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <87furhh0yb.fsf@users.sourceforge.net> Date: Sun, 10 Jul 2016 17:12:27 -0400 In-Reply-To: <87furhh0yb.fsf@users.sourceforge.net> (npostavs's message of "Sun, 10 Jul 2016 13:12:12 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 23933 Cc: Eli Zaretskii , tino.calancha@gmail.com, kifer@cs.stonybrook.edu, 23933@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (defun ediff-really-quit (reverse-default-keep-variants) > ... > (let (... > (after-quit-hook-internal ediff-after-quit-hook-internal) > And as mentioned in the patch, ediff-filegroup-action calls add-hook > with non-nil LOCAL on ediff-after-quit-hook-internal. And there we have a problem. When t is encountered in the buffer-local part of ediff-after-quit-hook-internal, it means to run the global part of ediff-after-quit-hook-internal, but when we copy the list to after-quit-hook-internal, this link is broken and run-hooks can't know that a t in after-quit-hook-internal means to run the functions found in the global part of ediff-after-quit-hook-internal. Or looked at it another way, this let-binding does not copy the whole content of the hook, only the buffer-local part of it which is not sufficient when the hook has a buffer-local value as well as a non-nil global value. Most likely it works OK in practice because ediff-after-quit-hook-internal typically has a nil global binding. It might make sense to use something like: ;; FIXME: Here we ignore the global part of the ;; ediff-after-quit-hook-internal hook. (after-quit-hook-internal (remq t ediff-after-quit-hook-internal)) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 12:03:12 2016 Received: (at 23933) by debbugs.gnu.org; 11 Jul 2016 16:03:12 +0000 Received: from localhost ([127.0.0.1]:47042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdfr-0005s7-P2 for submit@debbugs.gnu.org; Mon, 11 Jul 2016 12:03:11 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:32770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdfp-0005ru-MN for 23933@debbugs.gnu.org; Mon, 11 Jul 2016 12:03:09 -0400 Received: by mail-pa0-f45.google.com with SMTP id ks6so11080860pab.0 for <23933@debbugs.gnu.org>; Mon, 11 Jul 2016 09:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=jtAH9v5ImmrlAHPf8n0yitptFWL1PatPa/mRoEwwTfw=; b=EC2tNRvXejpo6PqdRrnjTqjsjJ3vBIMJVXPgPnqXAtM3lkOq50wnGJB3hD8KDqY20h NbfHp7OZd2YI9bEI6QTEsmi4D8ByV/fnV9RWLIOKiEuUMdC70h2fZIAtX14qEnMDO4Up 3A4vfqeqKCbXjrjw6RL3RAXBANJr0sPOgfHELJPxOrEfKrdB4C/qbZqPAbOKly8cyY2F WPBJ8Ok5MF35IkJaizIUFwxtuESYZR7GvYq/4q/qL9mWyzGf7HFoYMtQjsB8J9RzE2JR 6+2lJTWSEMmkO7anJpOgyvCWqtdc68LREWbz8u66ZXABNFhKTRYJpnUiqJ5Nyg1XH/Hx wyZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=jtAH9v5ImmrlAHPf8n0yitptFWL1PatPa/mRoEwwTfw=; b=Te763WfqoxMaImP6pDH9nBlmOpy1I0t7Qs7pQ6/A6jaCkE/vjIuO7G6mjSyxn5jXnm +bAirMC/krfMuEolYu91bYKbhnEOk0MdhmIJf1hs15dX56ra82On8NDVlad4CNcbroKp o4TFItuzVme+FD8nruQRKAmoP5oRIlkSHOgcoIeF5E7qQIt8rpKBrS0tOE1FBecnjeUU wEP/+C4l8OJnWRlLTW+giVBjdtTexiCUZUOm6id7Gh/MpcczwP+stWeCqdC8TkPziv2b /kPTcsdjx/btckOngYh+OJ/q6S7Bw1/zMC2Q2R5qPQJurDK3B5aVxAYIeB6fQIZswZK3 j7vA== X-Gm-Message-State: ALyK8tIk+IZ7SnSxTgTfeahDvodURoKn9FaVBXgmRCeXVsIzJNGtebU8J6JXBC2EiPvcWw== X-Received: by 10.66.164.227 with SMTP id yt3mr25564227pab.117.1468252983736; Mon, 11 Jul 2016 09:03:03 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id a20sm5431333pfa.27.2016.07.11.09.03.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 09:03:03 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 12 Jul 2016 01:02:59 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Stefan Monnier Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc In-Reply-To: Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <87furhh0yb.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: Eli Zaretskii , 23933@debbugs.gnu.org, tino.calancha@gmail.com, kifer@cs.stonybrook.edu, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 10 Jul 2016, Stefan Monnier wrote: > It might make sense to use something like: > > ;; FIXME: Here we ignore the global part of the > ;; ediff-after-quit-hook-internal hook. > (after-quit-hook-internal (remq t ediff-after-quit-hook-internal)) Thank you very much Stefan for the detailed comments; they really help me to understand deeply the issue. I have pushed your suggested patch to the master branch. Thanks also to Noam and Eli to helping fixing this bug. Tino From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 12:06:01 2016 Received: (at 23933) by debbugs.gnu.org; 11 Jul 2016 16:06:01 +0000 Received: from localhost ([127.0.0.1]:47046 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdib-0005wE-74 for submit@debbugs.gnu.org; Mon, 11 Jul 2016 12:06:01 -0400 Received: from mail-pf0-f178.google.com ([209.85.192.178]:32968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdiY-0005vz-W4 for 23933@debbugs.gnu.org; Mon, 11 Jul 2016 12:05:59 -0400 Received: by mail-pf0-f178.google.com with SMTP id i123so37202543pfg.0 for <23933@debbugs.gnu.org>; Mon, 11 Jul 2016 09:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=y34brlsxn1PQO4AG5pWeIpL7arnTG4GonhElyH5DKkE=; b=PnGKRPcX8L5HZ5A4IggINyMImKtQXY5nq+HcLtklpp2SOd8sDhC9cqev5cdSsirpTT ISEmmrzfFVoQjeGxjcpI3wmrducXHd0AIKdrT9duo5LqWfjlDg0Ss4cbGw37Tq7yoYsa Y1Po/O3FG+8aBxtLNt4XuAGFVZGs+QREOPVZW0RWFKMxAti8s+MaSBu/mmmrj6Hhieiw gyC8HXIeF8plk2UXaFqaRCPOMb+g0sV4ZEK7tLhCTJK9GNzrfbombMngtP5b603GJ3zR NxjWauN/mgXurt1zwWEmwcXZXieS1vpcUExixontLbYU5z2mhXIwr6bANEynY+UmLx1Z YG9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=y34brlsxn1PQO4AG5pWeIpL7arnTG4GonhElyH5DKkE=; b=IxNegcdlni+eDTffxZhatHBZt4RNS33tbeUU6Ne1wzuUjC7UUL4vq3Vug8Xc8qjmcp QZ02b1PiqQbAO47RgeLx1orvIedLlzXyAy9xXBkft0R8YGWVc+TcgvjYNR22RtGDR/is mkT77BxbL7ppJVmWnhpOUp54rn7wEr/d7Ylkxwacw3I6okfVFS59s7yT5HbSsr3HyvW4 3iAZqu5yb+hFTK57qL4/75PL3OJx7yhL2bej01W5/dVrrF0//NxrbL/5LL5ca6XhVDit D6ClZooGRDRSb43cMc0j+Q/Nqfbd/rb/KYExpi7vryQgaH2cW4C7eOmNMOYnnTLwwsv2 zPYw== X-Gm-Message-State: ALyK8tKNN+J0ufU6xGDkhKGvwfL9LdPbMT9MLvlXLf1B8q03GkQBi0xI5og88jtwSQ1tVw== X-Received: by 10.98.15.212 with SMTP id 81mr36280643pfp.110.1468253153192; Mon, 11 Jul 2016 09:05:53 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id a87sm5630031pfc.63.2016.07.11.09.05.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 09:05:51 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 12 Jul 2016 01:05:47 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Tino Calancha Subject: Re: bug#23933: 25.1.50; Run a buffer-local hook with mapc In-Reply-To: Message-ID: References: <83d1mlft8v.fsf@gnu.org> <8337nhfpxy.fsf@gnu.org> <87furhh0yb.fsf@users.sourceforge.net> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23933 Cc: kifer@cs.stonybrook.edu, Eli Zaretskii , 23933@debbugs.gnu.org, Stefan Monnier , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 12 Jul 2016, Tino Calancha wrote: > Thanks also to Noam and Eli to helping fixing this bug. And thanks also to Andreas. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 11 12:06:26 2016 Received: (at 23933-done) by debbugs.gnu.org; 11 Jul 2016 16:06:26 +0000 Received: from localhost ([127.0.0.1]:47050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdj0-0005xL-DB for submit@debbugs.gnu.org; Mon, 11 Jul 2016 12:06:26 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMdiy-0005x7-F9 for 23933-done@debbugs.gnu.org; Mon, 11 Jul 2016 12:06:24 -0400 Received: by mail-pa0-f51.google.com with SMTP id ks6so11106078pab.0 for <23933-done@debbugs.gnu.org>; Mon, 11 Jul 2016 09:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=mWUhlywG//e76xAhJysWreL8Bp3jO1xVeywpA/+Yzis=; b=h6REj8sOLBVnIvlmy8TjxH4FEBX+wocv6nYI06s/a7nHDLp7oWJhYs46oU0ypyOd9G jlevt7dYn8dOlELzoT/ouzV72dgf6Jgels6ay6hu6M27Z1HXoahFNszF8wyXYgHwxJKA kzxLC9K0MkBZN9myabZO+UdFJV2xoJwubciUjuGbB9q7uR2PvBm6hksRIdfh6UBR8Av4 kw+o07n/MKmhGmA0K5xbH5CWAK9IS41vSqi3qV5ODwx/Zmsj//oofYwe2gPFFVqMTvYl 40nuTczGwDdMLcR69BBhIcDCgDbq3q6S0QKCeQxxxl7i+zC9vyw8bEz2anhemfJuDu/s 9vLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=mWUhlywG//e76xAhJysWreL8Bp3jO1xVeywpA/+Yzis=; b=XRNSRwyNXbCvop13Q1RkljSTAYQHaUE5rf8SSSBdp2YZZS9PtDlKPu7JzzjjS8hh6j CVjvJxSRVjI8HRJAWwZIMI8SXYIdYneKrtmlw9CRRqg85DzRaeZG8ak2MQ8qm2uw7/AX 3N0IQK+CF3TBevXAuCTpiL1R+qsZqP3ETsGFRcURbyGxJZRUa8ZJ+Kvtt4Rr/c341frk XYNGaCj+y5OBDGBkJ8tFGW9C29QlhLuJ1oUjU0zTD4vQiS4xoVZikk8tbTFSUMiFCPr0 g3Jn0phS7nupy15dcc5yNcNBQ5X02khT73Pmh4vQTlMiV/gDxdxinKIa8SAh4CpmLyWT 1jGw== X-Gm-Message-State: ALyK8tKP7SUg0jQeb4IDFNMZAsWa1WxDWz8qAdErFVBiKCmcCl/9TS4LS/ptAG3JvafR6g== X-Received: by 10.66.232.136 with SMTP id to8mr36808884pac.130.1468253178924; Mon, 11 Jul 2016 09:06:18 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id g13sm5635768pfb.7.2016.07.11.09.06.17 for <23933-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 09:06:18 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 12 Jul 2016 01:06:16 +0900 (JST) X-X-Sender: calancha@calancha-pc To: 23933-done@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in the master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.51 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.51 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 23933-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in the master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.220.51 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.51 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Fixed in the master branch From unknown Mon Aug 11 02:13:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator