GNU bug report logs - #23917
25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out

Previous Next

Full log

Message #65 received at 23917 <at> debbugs.gnu.org (full text, mbox):

From: Alex Bennée <alex.bennee <at> linaro.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: nljlistbox2 <at> gmail.com, jwiegley <at> gmail.com, rpluim <at> gmail.com,
 me <at> lunaryorn.com, 23917 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: [O] bug#23917: Please consider making Bug #23917 a blocker for
 25.1 (was Re: org-capture: Capture template ‘g’: Match
 data clobbered by buffer modification hooks)
Date: Tue, 19 Jul 2016 18:45:44 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Alex Bennée <alex.bennee <at> linaro.org>
>> Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 23917 <at> debbugs.gnu.org, rpluim <at> gmail.com, jwiegley <at> gmail.com, nljlistbox2 <at> gmail.com
>> Date: Tue, 19 Jul 2016 18:05:37 +0100
>>
>> > Do we care that using save-match-data in every call to replace-match
>> > might mean a performance hit?  If it will, then this will again punish
>> > most of the users for the benefit of those few who (1) have
>> > buffer-modification hooks, and (2) those hooks call save-match-data.
>>
>> I care unless there is an easy way to identify which buffer modification
>> hooks are responsible so I can take steps as a user to mitigate the
>> problems.
>
> Any hook in before-change-functions or after-change-functions that
> calls save-match-data.
>
> If we care about the performance hit, we need to come up with a
> different solution for this problem (or measure the performance hit
> and convince ourselves it is not a big deal).

Thanks for the hint. So in my case it was flycheck-handle-change which
was triggering the problem:

(defun flycheck-handle-change (beg end _len)
  "Handle a buffer change between BEG and END.

BEG and END mark the beginning and end of the change text.  _LEN
is ignored.

Start a syntax check if a new line has been inserted into the
buffer."
  ;; Save and restore the match data, as recommended in (elisp)Change Hooks
  (save-match-data
    (when flycheck-mode
      ;; The buffer was changed, thus clear the idle timer
      (flycheck-clear-idle-change-timer)
      (if (string-match-p (rx "\n") (buffer-substring beg end))
          (flycheck-buffer-automatically 'new-line 'force-deferred)
        (setq flycheck-idle-change-timer
              (run-at-time flycheck-idle-change-delay nil
                           #'flycheck-handle-idle-change))))))

However it doesn't look as though it tweaks the buffer until idle timer
has run. Weird....

--
Alex Bennée

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.