GNU bug report logs - #23917
25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out

Previous Next

Full log

Message #59 received at 23917 <at> debbugs.gnu.org (full text, mbox):

From: Alex Bennée <alex.bennee <at> linaro.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23917 <at> debbugs.gnu.org, rpluim <at> gmail.com, nljlistbox2 <at> gmail.com,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, jwiegley <at> gmail.com
Subject: Re: [O] bug#23917: Please consider making Bug #23917 a blocker for
 25.1 (was Re: org-capture: Capture template ‘g’: Match
 data clobbered by buffer modification hooks)
Date: Tue, 19 Jul 2016 18:05:37 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
>> Cc: rpluim <at> gmail.com,  23917 <at> debbugs.gnu.org,  alex.bennee <at> linaro.org,  jwiegley <at> gmail.com,  nljlistbox2 <at> gmail.com
>> Date: Tue, 19 Jul 2016 12:03:51 -0400
>>
>> I guess the next best thing is:
>> - copy search_regs.start and search_regs.end before calling replace_range.
>> - use that copy when adjusting the match data.
>> Or equivalently, use save-match-data.  IOW go back to your original patch.
>> Duh!
>
> Do we care that using save-match-data in every call to replace-match
> might mean a performance hit?  If it will, then this will again punish
> most of the users for the benefit of those few who (1) have
> buffer-modification hooks, and (2) those hooks call save-match-data.

I care unless there is an easy way to identify which buffer modification
hooks are responsible so I can take steps as a user to mitigate the
problems.

--
Alex Bennée

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.