GNU bug report logs - #23917
25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out

Previous Next

Packages: emacs, org-mode;

Reported by: Robert Pluim <rpluim <at> gmail.com>

Date: Fri, 8 Jul 2016 12:43:02 UTC

Severity: normal

Tags: fixed

Found in version 25.0.95

Fixed in version 25.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #56 received at 23917 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 23917 <at> debbugs.gnu.org, rpluim <at> gmail.com, alex.bennee <at> linaro.org,
 nljlistbox2 <at> gmail.com, jwiegley <at> gmail.com
Subject: Re: Please consider making Bug #23917 a blocker for 25.1 (was Re:
 org-capture: Capture template ‘g’: Match data clobbered
 by buffer modification hooks)
Date: Tue, 19 Jul 2016 19:13:21 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: rpluim <at> gmail.com,  23917 <at> debbugs.gnu.org,  alex.bennee <at> linaro.org,  jwiegley <at> gmail.com,  nljlistbox2 <at> gmail.com
> Date: Tue, 19 Jul 2016 12:03:51 -0400
> 
> I guess the next best thing is:
> - copy search_regs.start and search_regs.end before calling replace_range.
> - use that copy when adjusting the match data.
> Or equivalently, use save-match-data.  IOW go back to your original patch.
> Duh!

Do we care that using save-match-data in every call to replace-match
might mean a performance hit?  If it will, then this will again punish
most of the users for the benefit of those few who (1) have
buffer-modification hooks, and (2) those hooks call save-match-data.
This bug report was last modified 8 years and 304 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.