GNU bug report logs -
#23917
25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out
Previous Next
Reported by: Robert Pluim <rpluim <at> gmail.com>
Date: Fri, 8 Jul 2016 12:43:02 UTC
Severity: normal
Tags: fixed
Found in version 25.0.95
Fixed in version 25.1
Done: npostavs <at> users.sourceforge.net
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Eli Zaretskii <eliz <at> gnu.org> writes:
>> From: npostavs <at> users.sourceforge.net
>> Cc: 23917 <at> debbugs.gnu.org, nljlistbox2 <at> gmail.com, jwiegley <at> gmail.com, rpluim <at> gmail.com, monnier <at> iro.umontreal.ca, alex.bennee <at> linaro.org
>> Date: Wed, 20 Jul 2016 23:00:59 -0400
>>
>> > Please also make sure bug#23869 is still fixed after this.
>>
>> Following the recipe in
>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23869#11 gives me 'Lisp
>> error: (error "Match data clobbered by buffer modification hooks")',
>> that indicates it's still fixed, right?
>
> Yes, but I thought we want to remove the error-out code. Since we now
> protect ourselves from clobbered data, we don't need that extra
> protection, and I think leaving it in place will cause false positives
> (as a few people already reported). That's because the adjustment of
> the search registers in the new function you introduce will itself
> trigger the error message, won't it?
I made the same adjustments to the saved sub_start and sub_end
variables, but I had a mistake in that adjustment which caused the false
positives. Fixed in the attached v2 patch. We could just drop the
check, though I've already found it useful to catch bugs
(https://github.com/joaotavora/yasnippet/issues/720).
If I drop the checks (see attached v3 patch), then after following the
bug#23869 recipe, I get:
## -*- Octave -*-
-module(bug).
-export([identity/1, is_even/1, size/1, reverse/1]).
[v2-0001-Adjust-match-data-before-calling-after-change-fun.patch (text/x-diff, attachment)]
[v3-0001-Adjust-match-data-before-calling-after-change-fun.patch (text/x-diff, attachment)]
This bug report was last modified 8 years and 360 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.