GNU bug report logs - #23917
25.0.95; commit 3a9d6296b35e5317c497674d5725eb52699bd3b8 causing org-capture to error out

Previous Next

Full log

Message #107 received at 23917 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: nljlistbox2 <at> gmail.com, jwiegley <at> gmail.com, rpluim <at> gmail.com,
 23917 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca, alex.bennee <at> linaro.org
Subject: Re: bug#23917: Please consider making Bug #23917 a blocker for 25.1
 (was Re: org-capture: Capture template ‘g’: Match data
 clobbered by buffer modification hooks)
Date: Thu, 21 Jul 2016 05:43:53 +0300

> From: npostavs <at> users.sourceforge.net
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  23917 <at> debbugs.gnu.org,  nljlistbox2 <at> gmail.com,  jwiegley <at> gmail.com,  rpluim <at> gmail.com,  alex.bennee <at> linaro.org
> Date: Wed, 20 Jul 2016 20:56:28 -0400
> 
> >> Maybe there's a misunderstanding.  What Noam suggested was just to
> >> move the code which adjusts search_regs.start[i] and .end[i] to before
> >> the call to replace_range.
> >
> > Oh, right, that's also an option.  It might suffer from another problem,
> > which is that the match-data will be broken while the
> > before-change-functions are run, so if there's a save-match-data there
> > we're back to square one.
> 
> Solution: adjust in between the before and after change functions.
> Patch below.  I think there shouldn't be performance problems, although
> it does add yet another flag to replace_range (by the way, I noticed
> that the MARKERS flags is never 0, so it's redundant).  I tested with
> the attached bug-23917-match-data-buffer-modhook.el.

Thanks.

Please also make sure bug#23869 is still fixed after this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.