From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 03 05:13:22 2016 Received: (at submit) by debbugs.gnu.org; 3 Jul 2016 09:13:22 +0000 Received: from localhost ([127.0.0.1]:35114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdSr-0006jp-QL for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:13:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJdSq-0006jd-QT for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:13:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJdSj-0002LY-S3 for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:13:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdSj-0002L1-Of for submit@debbugs.gnu.org; Sun, 03 Jul 2016 05:13:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35583) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdSh-0004Lv-Il for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:13:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJdSd-0002KO-9L for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:13:10 -0400 Received: from mail-pf0-x244.google.com ([2607:f8b0:400e:c00::244]:35480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJdSd-0002JN-14 for bug-gnu-emacs@gnu.org; Sun, 03 Jul 2016 05:13:07 -0400 Received: by mail-pf0-x244.google.com with SMTP id t190so13775933pfb.2 for ; Sun, 03 Jul 2016 02:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=0mo+fo21xsoP1YTx1Iy/uY7pkJe622dGQitGNLjfJ70=; b=ZK5S8SxiLsrf0zZctdUNQwWU6W0nx2ZXhG2VlFSNV36+6muufFt1aOa6GmY+1OMhWk eoQdn0w+2rxrJhBlhhhEH6VoQTIzIvpQNQttGBnwqDRdltzdEzEAkIN01vgpvP0WeBy0 PxDzp59t9pGkm3QjgZIfNUjr1gUFM1kf3bSwaqfYZgyoO9nzooXopS6sU4xU5mfWC2bT FahgA2fNiSd7r/nnH0tyQlrGmyWc8r6cW/Q1kbaGk18KGZ7vEXKGg066Oj6dbzE6CeD2 5G20iTux1ccLnvdPTgen6a5Y2ke0VmInfx776WNbeT7ubgUsdzD40Snt1/MS82ZcOojX 91rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=0mo+fo21xsoP1YTx1Iy/uY7pkJe622dGQitGNLjfJ70=; b=BsfiiY8TDdrgAmBwB/JAkGT3x6OyNpOvq+atOGdf79p1HYoM8K0vB13Vz+MQokaeDC +D9+ZlegWTFyb4XfnuPw5Zx4tInz6OvJ6u2CI56ktRIXPedKLZY0ga9m2TvgImyEsNeD Q/ywogqPddigvDGv3DzpCO0e+30Erhd56pnNI6kS0J+WNHGKnSnDtHAcCBZhlPx3cPPk ZBHc2FhNdJcywLAPx0iP8Obov/5NasK3QXwaTpyPKKqAxPpw81reJMp72KunX/uG9vnb ANK/DoVlbXL8Af1Rw7FBBeQm0z2Xy15dK2AUtdv/d1TR6ziIkoLXXxWQaKDUmLsVoCTD 0ujw== X-Gm-Message-State: ALyK8tKe0B5iECH2b4T3XzP1NsUC1WIM5s8VHOiC+v2Ds0FGA0TFiCTeN2E+E+9S2pyZgA== X-Received: by 10.98.112.196 with SMTP id l187mr12481528pfc.59.1467537185515; Sun, 03 Jul 2016 02:13:05 -0700 (PDT) Received: from calancha-pc (105018171106.wi-fi.kddi.com. [106.171.18.105]) by smtp.gmail.com with ESMTPSA id 78sm2173169pfm.43.2016.07.03.02.13.04 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jul 2016 02:13:05 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 3 Jul 2016 18:13:02 +0900 (JST) X-X-Sender: calancha@calancha-pc To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Detect aliases to built-in functions Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q F1 f search-forward-regexp RET ;; First line don't mention that the func is an alias ;; Compare, for instance, with F1 f chmod RET ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; >From 48dcc336e96bbd22250eaee7e3a46c91b7ede1a1 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Sun, 3 Jul 2016 18:01:24 +0900 Subject: [PATCH] Detect aliases to built-in functions * lisp/help-fns.el (describe-function-1): Check for aliases defined with (defalias alias (symbol-function built-in)) (Bug#23887). --- lisp/help-fns.el | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/lisp/help-fns.el b/lisp/help-fns.el index 9464c0b..e4e2333 100644 --- a/lisp/help-fns.el +++ b/lisp/help-fns.el @@ -572,13 +572,17 @@ describe-function-1 (aliased (or (symbolp def) ;; Advised & aliased function. (and advised (symbolp real-function) - (not (eq 'autoload (car-safe def)))))) + (not (eq 'autoload (car-safe def)))) + (and (subrp def) + (not (string= (subr-name def) + (symbol-name function)))))) (real-def (cond - (aliased (let ((f real-function)) - (while (and (fboundp f) - (symbolp (symbol-function f))) - (setq f (symbol-function f))) - f)) + ((and aliased (not (subrp def))) + (let ((f real-function)) + (while (and (fboundp f) + (symbolp (symbol-function f))) + (setq f (symbol-function f))) + f)) ((subrp def) (intern (subr-name def))) (t def))) (sig-key (if (subrp def) -- 2.8.1 In GNU Emacs 25.1.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) of 2016-07-03 built Repository revision: 08974112ae68aefba658a8516c8faa3374edc924 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 04 12:40:02 2016 Received: (at 23887) by debbugs.gnu.org; 4 Jul 2016 16:40:02 +0000 Received: from localhost ([127.0.0.1]:37325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bK6ug-0005A2-JH for submit@debbugs.gnu.org; Mon, 04 Jul 2016 12:40:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bK6uf-00059Z-8r for 23887@debbugs.gnu.org; Mon, 04 Jul 2016 12:40:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bK6uZ-0000Tb-FU for 23887@debbugs.gnu.org; Mon, 04 Jul 2016 12:39:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bK6uY-0000TF-4r; Mon, 04 Jul 2016 12:39:54 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bK6uW-0007nm-Hj; Mon, 04 Jul 2016 12:39:52 -0400 From: Glenn Morris To: Tino Calancha Subject: Re: bug#23887: 25.1.50; Detect aliases to built-in functions References: X-Spook: Burn FBI Bruxelles Europol Enriched Computer X-Ran: `Ii"07FYl|dM'D:59m@*4!>A3ejLoPc'5AqaAKyR[A/>"/Hts0[`vB@9](S_8=`Js8t^$V X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 04 Jul 2016 12:39:52 -0400 In-Reply-To: (Tino Calancha's message of "Sun, 3 Jul 2016 18:13:02 +0900 (JST)") Message-ID: <0furpqrvr.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23887 Cc: 23887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) Describe-function really needs some ert test writing IMO, because these cases that it gets wrong keep cropping up. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 03:25:09 2016 Received: (at 23887) by debbugs.gnu.org; 5 Jul 2016 07:25:09 +0000 Received: from localhost ([127.0.0.1]:37676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKKjF-0005xH-0k for submit@debbugs.gnu.org; Tue, 05 Jul 2016 03:25:09 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:34031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKKjE-0005x6-4A for 23887@debbugs.gnu.org; Tue, 05 Jul 2016 03:25:08 -0400 Received: by mail-pa0-f43.google.com with SMTP id bz2so65011282pad.1 for <23887@debbugs.gnu.org>; Tue, 05 Jul 2016 00:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=uK1IUBLdf8ZcusyY2TusoJmTZza2/F6pUBGFJWK5iww=; b=CtETcmQt0SYSvfMmw6sdUhWVOHES9DmBQbsdIfek9RVcFXfSxjm6m+2fIrsCs/9cJz FbPjdZ5Du8Ez4/Ssy/QSB3UaPJUHdQ4CQIFKBGwNF//OtuvnJjfGV+y+VHa0c3yobif/ W+tJXDKBDj+MYwZklR5C2vppYbJn2qS5pLjpVFXL/GyK8/TvW+kpXeyqLHfjmsbFRUwi wFlp8O2RAx+ueP9Oio0y6YEWy4O79ZXJ3HNLfGwpcH32/p50J0msxD01RZjnVmshnzEn R1cA5a+oTY6avjh+f4hhUOKlUMg00MDWyc98iWRAAAX0JXS1Qd98+vcip73cn0lJ0xIb +qnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=uK1IUBLdf8ZcusyY2TusoJmTZza2/F6pUBGFJWK5iww=; b=gLFe24XWrC7rltfjeVOmm4mxnLuxapj3IFS85TO2O/a3RXDl0XsrL4fLa3mf96sCuw 2m+JgBqGWm0h7F6Ziwo38RCATr+NmO+b5DzOEaZmvqWaNk5UlfUfa+4ZoZ5yEDYYmwE2 bPqL92zI3pxlcrkWaN74CNKhCrgGTrqvCIDczyPQocpJj/iU8ZqNOwz6L7PzxvoeDSAp coKY44lmJnMYsvQdIq7hEQ3efJS7A+J9L5Bf/UNucuXA/GxF+arn7dGjCOQb16wdNjQK GUGPwuvVyjz88iWHauvgPtQ/Y/xIVsbUHgsHZERGeIKwweW9dunbky4rXRzDTayoieaq 0mrQ== X-Gm-Message-State: ALyK8tKj+6Dzeohpme262qYYVsLOxfZ1CNC+ad1lPtPtMQUz4M30CQqP2jWuYik5+UjRaA== X-Received: by 10.66.0.74 with SMTP id 10mr29363625pac.38.1467703502238; Tue, 05 Jul 2016 00:25:02 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id 69sm2539846pfc.90.2016.07.05.00.25.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jul 2016 00:25:01 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 5 Jul 2016 16:24:58 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Glenn Morris Subject: Re: bug#23887: 25.1.50; Detect aliases to built-in functions In-Reply-To: <0furpqrvr.fsf@fencepost.gnu.org> Message-ID: References: <0furpqrvr.fsf@fencepost.gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23887 Cc: 23887@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 4 Jul 2016, Glenn Morris wrote: > > Describe-function really needs some ert test writing IMO, because these > cases that it gets wrong keep cropping up. I have added several tests to describe-function in test/lisp/help-fns-tests.el From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 11:53:51 2016 Received: (at 23887) by debbugs.gnu.org; 5 Jul 2016 15:53:51 +0000 Received: from localhost ([127.0.0.1]:38433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKSfX-0005os-AY for submit@debbugs.gnu.org; Tue, 05 Jul 2016 11:53:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKSfV-0005og-TA for 23887@debbugs.gnu.org; Tue, 05 Jul 2016 11:53:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKSfQ-0007Y1-0b for 23887@debbugs.gnu.org; Tue, 05 Jul 2016 11:53:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKSfO-0007W8-Gy; Tue, 05 Jul 2016 11:53:42 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bKSfI-0002Tw-Vc; Tue, 05 Jul 2016 11:53:37 -0400 From: Glenn Morris To: Tino Calancha Subject: Re: bug#23887: 25.1.50; Detect aliases to built-in functions References: <0furpqrvr.fsf@fencepost.gnu.org> X-Spook: sniper CID UFO COSCO mania Matamoros fraud Saudi Arabia X-Ran: !Wv\HU.m;63UQ|S1v#mz+ (Tino Calancha's message of "Tue, 5 Jul 2016 16:24:58 +0900 (JST)") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23887 Cc: 23887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) Tino Calancha wrote: > I have added several tests to describe-function in > test/lisp/help-fns-tests.el Thank you. I see you added one for this current case too? Personally I don't like to add failing tests, since it causes stuff like http://lists.gnu.org/archive/html/emacs-buildstatus/2016-07/msg00005.html which can mask unexpected failures. You could either have left it commented out till this issue was fixed, or given it ":expected-result :failed", which would prompt us to change it when this issue is fixed. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 05 12:13:54 2016 Received: (at 23887) by debbugs.gnu.org; 5 Jul 2016 16:13:54 +0000 Received: from localhost ([127.0.0.1]:38448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKSyw-0006HL-Io for submit@debbugs.gnu.org; Tue, 05 Jul 2016 12:13:54 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:36271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKSyu-0006H4-RY for 23887@debbugs.gnu.org; Tue, 05 Jul 2016 12:13:53 -0400 Received: by mail-pa0-f45.google.com with SMTP id uj8so8831629pab.3 for <23887@debbugs.gnu.org>; Tue, 05 Jul 2016 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=hzFF5VJHS7qzpqQB3CFPonqhoQZasRY0ujg5K2rKfrM=; b=RYd1wiffi0sDXckwsGKef3eQQ6HWqKkYGiWmClhysEO/3PLCSlMU4qwD99v/nroVc5 U2/kQxkI71QBOjCIZ4UbONO1TiLW3YxQZlk2G4Y46eHQRnSzlovg2DaEJUKQullMNLyR 2lyDb32KREWpTkI54UQomXPakUWkez2oLUIp0vOD+J2sF5o1l2WKW8XQH+2WAwOU/gRK q2GCcWbqhATtP2bKEsEJ6xityG5drUa3Mj3DM0goTzzcJIKM+b+nE0tushFdTm2HMAx8 qOKOoere5GUgvwLRl8E4AO1kbMPgGZMcvYxrcwve9uBr5VpL4IWt43ok9y/4cxdWbzDz bjPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=hzFF5VJHS7qzpqQB3CFPonqhoQZasRY0ujg5K2rKfrM=; b=ErRkyYxuqP5aQ6IX/RwI/DXdsUVqdfOYxtDStJ/73lHjb6me7hwYseW7qTS28uQMmc /wNu/oDMbME6tV3eGCoIXFfwq6/eaUx/FV+AshxdCB0pCJI2BliVV2lsJ5EDhKntPabv qzcWS33DTChpkJIgVDpgRgYGFjew16Q3MSye2hx02N5W+P95GCd7EHgkz5TJnhW1sQsY TGnYzEUZpz4HvCiYIAZq3GOygQUBxLzU6CJ4V0DVJkCP6iXxhkUjtxMbSzXJ8QbEl2E3 Ysg8zZWqElFvrfzxdSuUMoxesbRZGbW40asJVfCbN7dt7iUc4wOdXyejdEm45U7e9WRs 1fPw== X-Gm-Message-State: ALyK8tKJWD+D+hRHQXxuT1/H0aVt2WolOmv6PVfTz07GNQDTOQAdI2N6NL3Uhb1cGyShPg== X-Received: by 10.66.32.130 with SMTP id j2mr28163269pai.111.1467735226967; Tue, 05 Jul 2016 09:13:46 -0700 (PDT) Received: from calancha-pc (softbank126103139048.bbtec.net. [126.103.139.48]) by smtp.gmail.com with ESMTPSA id an13sm6467148pac.42.2016.07.05.09.13.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jul 2016 09:13:45 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 6 Jul 2016 01:13:42 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Glenn Morris Subject: Re: bug#23887: 25.1.50; Detect aliases to built-in functions In-Reply-To: Message-ID: References: <0furpqrvr.fsf@fencepost.gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23887 Cc: 23887@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Thank you. I see you added one for this current case too? > Personally I don't like to add failing tests, since it causes stuff like > > http://lists.gnu.org/archive/html/emacs-buildstatus/2016-07/msg00005.html > > which can mask unexpected failures. Opps! Very sorry about that :-S > You could either have left it commented out till this issue was fixed, > or given it ":expected-result :failed", which would prompt us to change > it when this issue is fixed. I have chosen the second option, addding ":expected-result :failed" Sorry for the inconvenients. Tino From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 09 06:50:55 2016 Received: (at 23887) by debbugs.gnu.org; 9 Jul 2016 10:50:55 +0000 Received: from localhost ([127.0.0.1]:43248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLpqZ-0002W6-Gm for submit@debbugs.gnu.org; Sat, 09 Jul 2016 06:50:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLpqY-0002Vt-3H for 23887@debbugs.gnu.org; Sat, 09 Jul 2016 06:50:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLpqP-0007ps-SJ for 23887@debbugs.gnu.org; Sat, 09 Jul 2016 06:50:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLpqP-0007pj-PM; Sat, 09 Jul 2016 06:50:45 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1512 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bLpqN-0006Xw-6s; Sat, 09 Jul 2016 06:50:43 -0400 Date: Sat, 09 Jul 2016 13:50:36 +0300 Message-Id: <83k2gvgk5f.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Sun, 3 Jul 2016 18:13:02 +0900 (JST)) Subject: Re: bug#23887: 25.1.50; Detect aliases to built-in functions References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 23887 Cc: 23887@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Tino Calancha > Date: Sun, 3 Jul 2016 18:13:02 +0900 (JST) > > emacs -Q > > F1 f search-forward-regexp RET > ;; First line don't mention that the func is an alias > ;; Compare, for instance, with > F1 f chmod RET > > > ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; > >From 48dcc336e96bbd22250eaee7e3a46c91b7ede1a1 Mon Sep 17 00:00:00 2001 > From: Tino Calancha > Date: Sun, 3 Jul 2016 18:01:24 +0900 > Subject: [PATCH] Detect aliases to built-in functions > > * lisp/help-fns.el (describe-function-1): Check for aliases > defined with (defalias alias (symbol-function built-in)) (Bug#23887). Thanks, please push to master (and uncomment the test that presently fails). From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 09 10:03:16 2016 Received: (at 23887-done) by debbugs.gnu.org; 9 Jul 2016 14:03:16 +0000 Received: from localhost ([127.0.0.1]:44225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLsqh-0003q0-U1 for submit@debbugs.gnu.org; Sat, 09 Jul 2016 10:03:16 -0400 Received: from mail-pa0-f41.google.com ([209.85.220.41]:36834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLsqg-0003pn-Om for 23887-done@debbugs.gnu.org; Sat, 09 Jul 2016 10:03:15 -0400 Received: by mail-pa0-f41.google.com with SMTP id hu1so8521109pad.3 for <23887-done@debbugs.gnu.org>; Sat, 09 Jul 2016 07:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:message-id:user-agent:mime-version; bh=GBuDDOYXiKTYGCGbPS6fk/he+pMZU9g/ZkvWeAnBmjw=; b=mTnxO8W/pnrPgpaSFPMV7RlrN94Qk/55WHxRQbb6swCtc/4BPmg/+WOACkiJ954bGx ypi0SbCBSgmFjXUA/vYwWdaCQvcB4IEAzISjj9DhyzzxY2o5P4/W+baWEsECSFHq56Hr XLCVFmM3wqN2Wa47A63WCXPRfoQNI8wTjTUE3Mu4StljJnTOL5Ak9EvFeRIRo8zCidh9 gak4qwAG9YtK0Ja89flmr1eEXPNh5W1gyaVRO0vaDp3vJQIMBSVvo2UK++qqGT/YoUb4 22HZS+NGncXJ636N6feztPH4v0uI/0wXO5MsjGA2pV6pQIr2uP+GSRZsDqK/BiXTjcS5 p9Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:message-id:user-agent:mime-version; bh=GBuDDOYXiKTYGCGbPS6fk/he+pMZU9g/ZkvWeAnBmjw=; b=P5xFmXEyP6KkXD9tZikXVxlLKJ4kK7iBWicmX2i863cvzmZ8RhYUdTqzu+rw/K4O35 sbztEoE4MM3SZqVuLOxdCCCQaOBPgABWwgmzyWNvDeNHtZUtC8penvrifw8Q3FtWbQxp Eo4j7FxY6riLyYMQDXJbx6sxh8QqBaFrNvwk/oHYhJlHLZ64xuUdJbr6U3LCKAiEW2pm 3DIfUJh5l2wnbCzjVoJo5zG/DeEgZTUGpG/3fMATCDa6/chJA9dv+1hX6tHNSeEuVQGD PXrhvE4e76hHeQ+V2X9UqfzoIIiOQR3uDtEk1EvNVJJYf9m+CsOjnguyUkjjkePVFZGn rX9w== X-Gm-Message-State: ALyK8tKEz2kQLTv7gjs9ZH8aDCEewoUuYFzm6BI2RdVb8r+wThXDYEtrijD2Kgf7IFQ+5w== X-Received: by 10.66.189.199 with SMTP id gk7mr19237505pac.158.1468072988778; Sat, 09 Jul 2016 07:03:08 -0700 (PDT) Received: from calancha-pc ([240f:6e:c00e:1:6875:2e94:598b:96cb]) by smtp.gmail.com with ESMTPSA id ln4sm4759985pab.38.2016.07.09.07.03.06 for <23887-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Jul 2016 07:03:07 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sat, 9 Jul 2016 23:03:04 +0900 (JST) X-X-Sender: calancha@calancha-pc To: 23887-done@debbugs.gnu.org Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.41 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.220.41 listed in wl.mailspike.net] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 23887-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Fixed in master branch [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [209.85.220.41 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.41 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (tino.calancha[at]gmail.com) 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Fixed in master branch From unknown Sun Jun 22 04:10:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 07 Aug 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator