From unknown Sat Jun 21 03:22:03 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23856 <23856@debbugs.gnu.org> To: bug#23856 <23856@debbugs.gnu.org> Subject: Status: 25.0.95; Crash on cancel print dialogue Reply-To: bug#23856 <23856@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:22:03 +0000 retitle 23856 25.0.95; Crash on cancel print dialogue reassign 23856 emacs submitter 23856 Alf Lerv=C3=A5g severity 23856 normal tag 23856 confirmed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 15:05:27 2016 Received: (at submit) by debbugs.gnu.org; 27 Jun 2016 19:05:27 +0000 Received: from localhost ([127.0.0.1]:58495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHbqZ-0006J2-Jv for submit@debbugs.gnu.org; Mon, 27 Jun 2016 15:05:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHbqX-0006Io-Hi for submit@debbugs.gnu.org; Mon, 27 Jun 2016 15:05:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHbqR-0000fw-7D for submit@debbugs.gnu.org; Mon, 27 Jun 2016 15:05:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHbqR-0000fZ-4D for submit@debbugs.gnu.org; Mon, 27 Jun 2016 15:05:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHbqO-0000L2-LC for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2016 15:05:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bHbqL-0000f9-Dq for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2016 15:05:16 -0400 Received: from mail-lf0-x236.google.com ([2a00:1450:4010:c07::236]:32850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bHbqL-0000ef-1s for bug-gnu-emacs@gnu.org; Mon, 27 Jun 2016 15:05:13 -0400 Received: by mail-lf0-x236.google.com with SMTP id f6so162346205lfg.0 for ; Mon, 27 Jun 2016 12:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lervag-net.20150623.gappssmtp.com; s=20150623; h=from:content-transfer-encoding:subject:message-id:date:to :mime-version; bh=i8RInSy3YpTNSjwGf6+Y9jyNonGlVlwJ6WrfLURVCm4=; b=lYv/30Lx3f+s+0cE6W+FkUn/fX0S0hV7ZA9HSk9cr/Nwcrk+WAN89WyCKu7U2tkkd+ KO6wA9KZqk7jCyXYm40q6HdqTvCd1rbgz0hnM0ISIDNxTHQs/yxwsnE+IYjy0tlu+R94 XFBugBes8h+GIO4X6kgP7/L4uEjWNT032hT1gQCn8e1kqio5OsPxvsNrBIMq8J88jtII DlwB9MlBY7PL2rcmmBq2w44uHIsXy9zxF2gMc2S3IUirp0vy7OYs1QrAU/jZI2xam/VJ Rr0FoaXwQHlSkjzePz2Oih95UFAXd/VpObZfEJHHzVLu+8+iXrJqTmWCOegjFtgKmV5q n/WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject :message-id:date:to:mime-version; bh=i8RInSy3YpTNSjwGf6+Y9jyNonGlVlwJ6WrfLURVCm4=; b=nOvDIZeFIF2bUQJkOyuUjR8ToG6aP1oGjmKOh4t2bvSOvvBkrOgDNdKCFgyDsde1nO 16SWyTFiskHU3gtyxnMP++awrUTpxUboLYmwAvIttO4fDz+pXZP0qLvvca3ln/7OzzUV MMucewUvkoMeLlxJkOP/9Up7ukoN1X1dzE1OI9d4FVUYN8fL3DsWGRj0Uph5TRkVi0ND GpoU4wYhY/QFXDVh1ScQvCL9B/VHXIxc8KJg01rLbqwBuYc72Nm+ttiZTVYONs9NxvZX uhheJlLx9RQpQYKucNKuZbtWwysFT0IY1a1UVS0xHKqEO9Pr7KMHR1pYw+BaJ2sHh/us VJGw== X-Gm-Message-State: ALyK8tKNORoVdP7hj6cBvomY/u7RsWYpAuCzrwQA6q4KQgXva1GWyI4F5naH20qtI0XrjA== X-Received: by 10.25.160.75 with SMTP id j72mr892919lfe.109.1467054311498; Mon, 27 Jun 2016 12:05:11 -0700 (PDT) Received: from [10.0.0.68] (ti0300a400-0892.bb.online.no. [88.89.186.134]) by smtp.gmail.com with ESMTPSA id f41sm3479966lji.19.2016.06.27.12.05.10 for (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 27 Jun 2016 12:05:10 -0700 (PDT) From: =?utf-8?Q?Alf_Lerv=C3=A5g?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: 25.0.95; Crash on cancel print dialogue Message-Id: Date: Mon, 27 Jun 2016 21:05:11 +0200 To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Occasionally I press cmd-p by mistake. When I press cancel in the print = dialogue, emacs crashes. This is annoying. Let me know if there is = anything I can do to help locate the root cause. 1. Press Cmd-P 2. Press Esc In GNU Emacs 25.0.95.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 = Version 10.9.5 (Build 13F1603)) of 2016-06-11 built on builder10-9.local Windowing system distributor 'Apple', version 10.3.1404 Configured using: 'configure --with-ns '--enable-locallisppath=3D/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp'' Configured features: NOTIFY ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LC_ALL: en_US.UTF-8 value of $LC_CTYPE: UTF-8 value of $LANG: en_NO.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. C-x C-g is undefined user-error: The mark is not set now, so there is no region user-error: No mark set in this buffer Quit Print buffer *scratch*? y Spooling...done Making completion list... [3 times] Load-path shadows: None found. Features: (shadow sort mail-extr lpr emacsbug message dired format-spec rfc822 mml mml-sec password-cache epg epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns help-mode easymenu cl-loaddefs pcase cl-lib mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win ucs-normalize term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese charscript case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 196218 11101) (symbols 48 19494 0) (miscs 40 49 299) (strings 32 15007 6042) (string-bytes 1 433033) (vectors 16 32859) (vector-slots 8 648289 6769) (floats 8 158 143) (intervals 56 218 10) (buffers 976 13)) From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 17:10:21 2016 Received: (at control) by debbugs.gnu.org; 27 Jun 2016 21:10:21 +0000 Received: from localhost ([127.0.0.1]:58538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHdnR-0001fK-25 for submit@debbugs.gnu.org; Mon, 27 Jun 2016 17:10:21 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:35780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHdnP-0001f3-8Q for control@debbugs.gnu.org; Mon, 27 Jun 2016 17:10:19 -0400 Received: by mail-wm0-f46.google.com with SMTP id v199so115460511wmv.0 for ; Mon, 27 Jun 2016 14:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:message-id:to:from:subject; bh=6EEkO4diK1gw0pgxkfKadMulfFi1lHRbTp0uY2SyycA=; b=e2nR8gVT5rNCgHsSFhwcD6EUb6kndmooLsF1mrihEvKbtEqbs7acm/HjIk1gqRj+MS 5PdPkoO82ro4+v8vVhQkMeJ1Wv4cRujjXshYcgY/MMxVBfPYM1vHq9YJKSbhIjpNMCRc 87K+Tpw2+uwuvQY/8kKPZjB314iGsCUQ/6R6krdMU5SeYYwL8UZBgkzEsRByDYHjoHWW i+feFCm6Mz1nQFneLsKK0DVDYpNEym+Gh7AUdyPOYU/kOFg9Nvq0HNJdgJPa7WpZMATI eSiPHecNIvXAfouHUV87DcEHmAR9+zJBojd42BJeCLe5XSCIiOk4sYYGAdzeFB9fCeY0 I5NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:message-id:to:from:subject; bh=6EEkO4diK1gw0pgxkfKadMulfFi1lHRbTp0uY2SyycA=; b=PVx3kYZK8d8LWLl77+5FZkIBofK1Ke1Kg4pznKlYHVimidOPAvn/o1JVyRK7REbrNW Tq0kAd3mDh4H87RVD4/SzWg4iITz3I7RPSfZTT2qtIwmHQhKV70Gbj1zC8JUqetdr14C vDI9Nr6TCDfEAhQps/oE4MbUxodjLo7RQMwv2j7mkaH3dVeIihqlYsgNLzMvepKa8axR uRbIq7m7tT3glHELuc7cmPICcDvaL5ukNsrAyltieq+Icp1A4/YuVkfd9zxzTT8jQWMC IvtqNoLut5W9lXlSA3PhvR++K4oMWBmigSKP6anGN863yHAeDxkQ7k8b0RlSiVAK01xV 9ipg== X-Gm-Message-State: ALyK8tLImqSFDf615ZS55BBiyp2ziGRDYO5xtbLlYyUl+pHQ3AL/SKoBg5VtRgWklS4ytQ== X-Received: by 10.28.26.67 with SMTP id a64mr12085299wma.70.1467061813548; Mon, 27 Jun 2016 14:10:13 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-ac92-b5d8-4ccd-40fc.holly.idiocy.org. [2001:8b0:3f8:8129:ac92:b5d8:4ccd:40fc]) by smtp.gmail.com with ESMTPSA id d137sm5396446wmd.12.2016.06.27.14.10.12 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jun 2016 14:10:13 -0700 (PDT) Date: Mon, 27 Jun 2016 22:10:08 +0100 Message-Id: To: control@debbugs.gnu.org From: Alan Third Subject: control message for bug #23856 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 23856 confirmed From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 28 12:57:18 2016 Received: (at 23856) by debbugs.gnu.org; 28 Jun 2016 16:57:18 +0000 Received: from localhost ([127.0.0.1]:59299 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHwK5-0002mF-V7 for submit@debbugs.gnu.org; Tue, 28 Jun 2016 12:57:18 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHwK3-0002m1-FK for 23856@debbugs.gnu.org; Tue, 28 Jun 2016 12:57:16 -0400 Received: by mail-wm0-f41.google.com with SMTP id 187so28580690wmz.1 for <23856@debbugs.gnu.org>; Tue, 28 Jun 2016 09:57:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+24bHho31qHx9xrEYp2mBGJVnbKK5M09ZTNpE1e65HQ=; b=fjubSRvZvdT007NXHK4lptq2/bqubkIDsWSw60MSV9qxfehRfquH0IFcb39z83UP0y N61L8kI7+3TTzaZFyz2g+8fL5cRHyDUt2GKbpVSxXFLVSPhIXuIpe/K7ocmBFL7AY3jA y7Dc1qnB6givQuieApiozwp9y393MxHJPglI8LdUFj6rt0a8BzeFZWO5YRhIw1Qi1PYk L57FfLDlCMoYIWtygQ5utHPCzBsmKZDbpVRfbWsme4AQpFhMfa/sKvQpKi+rP3P+CU7u A1Fbm9O+PH9dw0k4LogaPalZIVNqgLgRBz+qnGQhaHlkfl0qvIHGLwQ3DjHk3DyDeyW4 Sclg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=+24bHho31qHx9xrEYp2mBGJVnbKK5M09ZTNpE1e65HQ=; b=MVngmBDkNB/3ViqkJTa/eIz4IV2rvUfn333kd5fZEt7AoJwQgMUIHuFc2d+dDwJM1k ze+lV5QvskDn2iBGs7Rd23rY2hBlgi+rC7ktUh9y8IjdloZxKAzuKSIalLy6y3a54PGx hXmyi1mpLA8GI6tqzceJD22xs+RxB2KGtnZXh2jWGiXJJQof5FKCAnRpwSCbUPYLb1ly HBGcgEfz2RjAokeRA0ulyCGg9Wq4ZkOZx1zK1YBorhFUwn+26Q/TE2WXPM8yffTmMyoX Wey8iCU4gAhOKwQMjNf798eUuwRNN6AQIGcPXZy/UHb5TnokubahXoK0vFHIQEHrh2Qb lPng== X-Gm-Message-State: ALyK8tJgwlgvuhZi07UPXizgVr7iyOH+nVu9dXddqkyzRbr6F9svqYlBpwedDX3Qb7ex6w== X-Received: by 10.28.229.147 with SMTP id c141mr18008069wmh.5.1467133029562; Tue, 28 Jun 2016 09:57:09 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-ac92-b5d8-4ccd-40fc.holly.idiocy.org. [2001:8b0:3f8:8129:ac92:b5d8:4ccd:40fc]) by smtp.gmail.com with ESMTPSA id d4sm665020wjb.47.2016.06.28.09.57.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Jun 2016 09:57:08 -0700 (PDT) From: Alan Third To: Alf =?utf-8?Q?Lerv=C3=A5g?= Subject: Re: bug#23856: 25.0.95; Crash on cancel print dialogue References: Date: Tue, 28 Jun 2016 17:57:07 +0100 In-Reply-To: ("Alf \=\?utf-8\?Q\?Lerv\=C3\=A5g\=22's\?\= message of "Mon, 27 Jun 2016 21:05:11 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23856 Cc: 23856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Alf Lerv=C3=A5g writes: > Occasionally I press cmd-p by mistake. When I press cancel in the > print dialogue, emacs crashes. This is annoying. Let me know if there > is anything I can do to help locate the root cause. > > 1. Press Cmd-P > 2. Press Esc This can be triggered from any dialogue box, it seems. I eval: (x-popup-dialogue t '("moo")) and then hit esc. It doesn't crash every time, but it will after repeating a few times. It's a seg fault at line 1446 of nsmenu.m: [unwind_data->pool release]; This is Objective C's way of freeing memory and I guess that it's crashing because it's trying to release some memory that's already been freed. Maybe. * thread #1: tid =3D 0x65736, 0x00007fff8dc21af1 libobjc.A.dylib`(anonymous= namespace)::AutoreleasePoolPage::pop(void*) + 403, queue =3D 'com.apple.ma= in-thread', stop reason =3D EXC_BAD_ACCESS (code=3D1, address=3D0x10) frame #0: 0x00007fff8dc21af1 libobjc.A.dylib`(anonymous namespace)::Aut= oreleasePoolPage::pop(void*) + 403 libobjc.A.dylib`(anonymous namespace)::AutoreleasePoolPage::pop: -> 0x7fff8dc21af1 <+403>: movq 0x10(%rbx), %rax 0x7fff8dc21af5 <+407>: leaq 0x38(%rbx), %rcx 0x7fff8dc21af9 <+411>: cmpq %rcx, %rax 0x7fff8dc21afc <+414>: jne 0x7fff8dc21b1e ; <+448> --=20 Alan Third From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 29 15:32:33 2016 Received: (at 23856) by debbugs.gnu.org; 29 Jun 2016 19:32:33 +0000 Received: from localhost ([127.0.0.1]:60343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bILDt-0003t2-0J for submit@debbugs.gnu.org; Wed, 29 Jun 2016 15:32:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bILDs-0003sq-BX for 23856@debbugs.gnu.org; Wed, 29 Jun 2016 15:32:32 -0400 Received: by mail-wm0-f68.google.com with SMTP id r201so16721563wme.0 for <23856@debbugs.gnu.org>; Wed, 29 Jun 2016 12:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6NAOtwIlEDMCxSp/5zO3SCSfyiT21bufzVVSJzlyovw=; b=mjcbjVmX3w5KqV4Z/BEXzKuE2QkCwC3CDdD5Q8cbcRGmP3oAgQr+R5bXMMqr/IiwYz s9Z91mhl3nW/BzGdiu0WnAYT6SjJUGNpdbmfeXkcW8qpTBcWEYn+rQhpXM0e+75U7HE2 mT4nFxIdzX/ptChZ5Cgada7G0jb5SFYi4m1viGGFfJWHVon52aDwVM7ZxfQJmC+SBMKq desQCjkhqahyBaEqcxEDLKqyWgB8o3QuU9iD7J59fQ5yFNXxnOc5Nvydx0PwhD3uU0bc KwAWCdjguMTavbAwtI0GflsLSlp67bA5KhdT2QPgkVWNRYZYkPHm3VzfQo3I/aVicR6v /miA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=6NAOtwIlEDMCxSp/5zO3SCSfyiT21bufzVVSJzlyovw=; b=YqDIx0ZZJJCcTseTzNq7WMh8s4DptmuvGxjHDRbPFge805hMM0AsCDmEXYOp9aot6V 7gJJMH4oh8ubyFFMS0WmvTTMlHIgSw9DEtsPcuUMSNN77Q+LwRzm2xCqJjmGDCSzIFtR 3oQ9PorE90CXDxWxXcDFghCEfegZ3oJVkLLbeU1mbIGunMqt9cvZOdiliDefnfr9ylJx RfWZmWjI5QSp4qLWIObrnrlunO888UgVePxGNIDY/hYTz57A1bXHY6Q2CzhRQkdlXM9z fKdzH3QC0u4peXItVWs457CWcdQfnDxJXlKVAzfPpPHIYpE9WLRQoPue6eqUE4MXnYSb N7vQ== X-Gm-Message-State: ALyK8tKv6Wrppplhuzq6bPEznQkbb5phye6GsU+M7cu08DjulDXP4zfJ9+1XU6+HtXJERg== X-Received: by 10.28.132.149 with SMTP id g143mr5220837wmd.100.1467228745543; Wed, 29 Jun 2016 12:32:25 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-ac92-b5d8-4ccd-40fc.holly.idiocy.org. [2001:8b0:3f8:8129:ac92:b5d8:4ccd:40fc]) by smtp.gmail.com with ESMTPSA id v70sm5221555wmf.18.2016.06.29.12.32.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2016 12:32:24 -0700 (PDT) Date: Wed, 29 Jun 2016 20:32:22 +0100 From: Alan Third To: Alf =?iso-8859-1?Q?Lerv=E5g?= Subject: [PATCH] Remove separate pool for popup dialogs (bug#23856) Message-ID: <20160629193222.GA95960@breton.holly.idiocy.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23856 Cc: 23856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * src/nsmenu.m (pop_down_menu, ns_popup_dialog): Remove references to autorelease pool and Popdown_data struct. --- src/nsmenu.m | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/src/nsmenu.m b/src/nsmenu.m index 7d340e8..12af38b 100644 --- a/src/nsmenu.m +++ b/src/nsmenu.m @@ -1426,29 +1426,19 @@ - (NSRect) frame ========================================================================== */ -struct Popdown_data -{ - NSAutoreleasePool *pool; - EmacsDialogPanel *dialog; -}; - static void pop_down_menu (void *arg) { - struct Popdown_data *unwind_data = arg; + EmacsDialogPanel *panel = arg; - block_input (); if (popup_activated_flag) { - EmacsDialogPanel *panel = unwind_data->dialog; + block_input (); popup_activated_flag = 0; [panel close]; - [unwind_data->pool release]; [[FRAME_NS_VIEW (SELECTED_FRAME ()) window] makeKeyWindow]; + unblock_input (); } - - xfree (unwind_data); - unblock_input (); } @@ -1459,7 +1449,6 @@ - (NSRect) frame Lisp_Object tem, title; NSPoint p; BOOL isQ; - NSAutoreleasePool *pool; NSTRACE ("ns_popup_dialog"); @@ -1479,18 +1468,13 @@ - (NSRect) frame contents = list2 (title, Fcons (build_string ("Ok"), Qt)); block_input (); - pool = [[NSAutoreleasePool alloc] init]; dialog = [[EmacsDialogPanel alloc] initFromContents: contents isQuestion: isQ]; { ptrdiff_t specpdl_count = SPECPDL_INDEX (); - struct Popdown_data *unwind_data = xmalloc (sizeof (*unwind_data)); - - unwind_data->pool = pool; - unwind_data->dialog = dialog; - record_unwind_protect_ptr (pop_down_menu, unwind_data); + record_unwind_protect_ptr (pop_down_menu, dialog); popup_activated_flag = 1; tem = [dialog runDialogAt: p]; unbind_to (specpdl_count, Qnil); /* calls pop_down_menu */ -- I'm unsure what the purpose of this autorelease pool is. I guess it's supposed to be so that the dialog object always get released correctly, but it seems to be broken. I've just removed it, which I guess may introduce a memory leak, but I don't know how to check. -- Alan Third From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 06 10:58:19 2016 Received: (at control) by debbugs.gnu.org; 6 Jul 2016 14:58:19 +0000 Received: from localhost ([127.0.0.1]:39651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKoHL-0001GM-0N for submit@debbugs.gnu.org; Wed, 06 Jul 2016 10:58:19 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKoHJ-0001G9-Fl for control@debbugs.gnu.org; Wed, 06 Jul 2016 10:58:17 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1AF531614D0 for ; Wed, 6 Jul 2016 07:58:12 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nrI8iOzIuqC9 for ; Wed, 6 Jul 2016 07:58:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7DF2B1614D5 for ; Wed, 6 Jul 2016 07:58:11 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id n201mtljFGBv for ; Wed, 6 Jul 2016 07:58:11 -0700 (PDT) Received: from [192.168.0.35] (89-159-79-138.rev.numericable.fr [89.159.79.138]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 887081614D4 for ; Wed, 6 Jul 2016 07:58:10 -0700 (PDT) To: control@debbugs.gnu.org From: Paul Eggert Subject: Emacs bug maintenance Message-ID: <577D1C7E.4020109@cs.ucla.edu> Date: Wed, 6 Jul 2016 16:58:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) tags 23856 + patch tags 23883 + moreinfo From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 17 17:20:44 2016 Received: (at 23856-done) by debbugs.gnu.org; 17 Jul 2016 21:20:44 +0000 Received: from localhost ([127.0.0.1]:54883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOtUS-0005OS-Is for submit@debbugs.gnu.org; Sun, 17 Jul 2016 17:20:44 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOtUR-0005OG-Cb for 23856-done@debbugs.gnu.org; Sun, 17 Jul 2016 17:20:43 -0400 Received: by mail-wm0-f41.google.com with SMTP id o80so92617959wme.1 for <23856-done@debbugs.gnu.org>; Sun, 17 Jul 2016 14:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=gm4f1fSLP9VMW9NZH9C6LZHALt9xBHCG42a3JH3mWdI=; b=r62pU+4e+5Rn2k6cMfSMWS8EHp51NsK6CWFdG8gKwthzMGu6gBzlrWqDbsPwhsMMyS sfDNhA98lnaLsstIRtxnpqvlcEKomTAgjtW7NQemzxpSc7qGjSEzDc1IlpliX+dp+yXl XGyi8bKQvSLGyATWtSojSFGCkSxUZKcuAJc3waXNFZ1UYfFXM7Dxv/O0XaaaH7WSDYzi 4+E6WXFTm1pq2OHaWSz47bkYPeNefgRqedbr5CYC91g5TTSFao3acWG4vFjnCAjtjRUc ZYWNAq4S7+QWKLfGucRt5h+w/cMIMRPk2ibSlJJHac2Oa3UHCFcUnTutmuEw5EeAH4Ik txgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=gm4f1fSLP9VMW9NZH9C6LZHALt9xBHCG42a3JH3mWdI=; b=myyTP8Zf89VvkyNunk91vF8KFvklDzU9XMzMZBLyh+RQVXqtCyZji4fnYjJqWjGEsa 5CofF9NH0C7cNI1BaQOxBzmduoFDajvCGDtg1rlN4fGEe6jp5k+IjhatRp9gMwL1vjmR N8JCVsEVLyxMGHXzv8XLpccDlZUzvjuvzD9DdtkKjOSHBQ6mC4zBP9vBq20gcdGn+s83 lOEWrxpSZSidiOWq8qsYTtq11tzfxPdzkqT62zGrIlUttWxUEiHfmZ+GQTYRuO9FEeX3 QWQSnV2PAuVTIqlJMDpobaP1Baj2UCRTyqWZ3yrmt2LLjcRLd14g9y3AfyF0I1qQHc+t wnfw== X-Gm-Message-State: ALyK8tKWidflzAxa7zSbMMMjG8NVITEO+1on3idBx9pN7U5ndx30s/IQIszgtbTz2uIP0Q== X-Received: by 10.28.96.11 with SMTP id u11mr34751687wmb.5.1468790437644; Sun, 17 Jul 2016 14:20:37 -0700 (PDT) Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-5cc4-ba14-a0d0-bdac.holly.idiocy.org. [2001:8b0:3f8:8129:5cc4:ba14:a0d0:bdac]) by smtp.gmail.com with ESMTPSA id u125sm11401182wmg.22.2016.07.17.14.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Jul 2016 14:20:37 -0700 (PDT) From: Alan Third To: Alf =?utf-8?Q?Lerv=C3=A5g?= Subject: Re: bug#23856: [PATCH] Remove separate pool for popup dialogs (bug#23856) References: <20160629193222.GA95960@breton.holly.idiocy.org> Date: Sun, 17 Jul 2016 22:20:40 +0100 In-Reply-To: <20160629193222.GA95960@breton.holly.idiocy.org> (Alan Third's message of "Wed, 29 Jun 2016 20:32:22 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23856-done Cc: 23856-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Alan Third writes: > I'm unsure what the purpose of this autorelease pool is. I guess it's > supposed to be so that the dialog object always get released > correctly, but it seems to be broken. > > I've just removed it, which I guess may introduce a memory leak, but I > don't know how to check. I've tried checking this with "leaks" and it's coming back clean, so I've pushed it to master. -- Alan Third From unknown Sat Jun 21 03:22:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 15 Aug 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator