GNU bug report logs - #23825
maint: avoid md5sum.c warning from bleeding-edge gcc's -Wstrict-overflow

Previous Next

Package: coreutils;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Wed, 22 Jun 2016 14:38:02 UTC

Severity: normal

Tags: fixed

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #17 received at 23825 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Pádraig Brady
 <P <at> draigbrady.com>
Cc: 23825 <at> debbugs.gnu.org
Subject: Re: bug#23825: maint: avoid md5sum.c warning from bleeding-edge gcc's
 -Wstrict-overflow
Date: Thu, 23 Jun 2016 20:19:56 +0200
On 06/23/2016 07:29 PM, Jim Meyering wrote:
> My only reservation is barely worth mentioning: the new
> variable names, operandp and operand_lim are a bit too long for my
> taste (at least in the files where all uses are very near the
> definitions). On the other hand, they are also more readable than
> alternatives that came to mind, and in some cases are used far enough
> away from point of definition that one can justify that added length.

Exactly the thoughts that ran through my head!  I couldn't think of 
better names either.  The word "operand" came from the technical term 
used in the POSIX spec for utility arguments.  If someone else can come 
up with a better (shorter) name I'm all for using it.  In the meantime I 
installed the patch.




This bug report was last modified 6 years and 269 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.