From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2016 10:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23823@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14665903065838 (code B ref -1); Wed, 22 Jun 2016 10:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jun 2016 10:11:46 +0000 Received: from localhost ([127.0.0.1]:50352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFf8M-0001W6-B9 for submit@debbugs.gnu.org; Wed, 22 Jun 2016 06:11:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFf8K-0001Vt-HO for submit@debbugs.gnu.org; Wed, 22 Jun 2016 06:11:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFf8E-0002jc-EZ for submit@debbugs.gnu.org; Wed, 22 Jun 2016 06:11:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFf8E-0002ic-Bs for submit@debbugs.gnu.org; Wed, 22 Jun 2016 06:11:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFf8C-00054F-35 for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 06:11:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFf86-0002hb-UR for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 06:11:34 -0400 Received: from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242]:35540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFf86-0002hR-NB for bug-gnu-emacs@gnu.org; Wed, 22 Jun 2016 06:11:30 -0400 Received: by mail-pf0-x242.google.com with SMTP id t190so3753269pfb.2 for ; Wed, 22 Jun 2016 03:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:subject:message-id:user-agent:mime-version; bh=OSmsDP+mXPmuIWGqUEkbinuWW7k/LBZjC5h8jj8gqpM=; b=ru28r9svGNNXC0ofpa4Cd+CqoClZdUd1zJWGEF23yktK67n20BrpuAkWj14uwc6z3J zdHtwCvQA9tWp+khIV6EGa2GkHXUU5bd5dCsDDZm5gpswWeKJ2yKTdYQ80Vc4B51lyOS Vw/k2MxWMnP3WLec5ifiTyP702z2CBzHaz8aNZkqlPG3YfJBKMQlATSu/JjJLWzl92su AWk7cxpAoQb7DXR78I2lVC8OrltLQVPuwwPx37fIVq7wW/Cg27hcyknTUjtPdA/YuWy5 I/Wh23VCTadi2MPlLpJ7A85tVQfRBgML1uf2IjByP6EgAQLa7J8PfECSWxO0eKuiU/Fl HF+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:subject:message-id:user-agent :mime-version; bh=OSmsDP+mXPmuIWGqUEkbinuWW7k/LBZjC5h8jj8gqpM=; b=DWFP2zVJsFoZl6gbfG+WSak5ow72h9oqk0qr7pgmZ3D2EvsUy8YxkIAssypuHLlH3Q 68pfGV5azIOZ0oWOF+aVtCIRMKSb8AZ9EosM3QV3CBAI5QnEGtstBBeAlent63VgnX5n MUvcJayaZZTCPHYEDkIAcHkd1WiV1Sifpi0ZZ4EoJWnuKmcdSLV5s0tFXqPttP8bCkXc MLnPM2QaTi2WgM/gl7vvjpwv6lo7s1NNfViWl2lGpSfJp9JuJ2s2XYUU/fwWplau8jIp ZHtNIOzyhdOlh8fW0OdRo4oZXKYCbOhAw7EssPiRFYhBPKAnrjnR+OTvEGbyPnMitbYD EhvA== X-Gm-Message-State: ALyK8tJE/cpxddrTMAyupeLA57/jqSe9KGppYSmsVpzPKMOXFCup3YRjnpPsA5ZjLAg6Mw== X-Received: by 10.98.3.3 with SMTP id 3mr21411197pfd.8.1466590289709; Wed, 22 Jun 2016 03:11:29 -0700 (PDT) Received: from calancha-pc (softbank126103144234.bbtec.net. [126.103.144.234]) by smtp.gmail.com with ESMTPSA id i124sm41341403pfg.77.2016.06.22.03.11.28 for (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 03:11:29 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 22 Jun 2016 19:11:27 +0900 (JST) X-X-Sender: calancha@calancha-pc Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) ./emacs -r -Q -eval '(progn (with-temp-file "/tmp/foo" (insert "foo")) (switch-to-buffer "bar") (insert "boo"))' M-: (highlight-compare-with-file "/tmp/foo") RET C-b C-b DEL f M-: M-p RET ;; Now current buffer content equals /tmp/foo content ;; but foo is still displayed with face highlight-changes. In GNU Emacs 25.0.95.2 (x86_64-pc-linux-gnu, GTK+ Version 3.20.6) Repository revision: 829733104db073f8abd67765eae162e7360281fa ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; Following patch fixed it calling (and highlight-changes-mode (hilit-chg-clear)) each time (highlight-changes-mode 1) is called. It would be better if such reset were performed inside one hook. Any idea to do this better? >From 18251da925f8f8c6cca50b2a4f56235534c0a479 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Wed, 22 Jun 2016 18:29:13 +0900 Subject: [PATCH] Reset between highlight comparisons * lisp/hilit-chg.el (highlight-markup-buffers) (highlight-changes-mode-turn-on): Call hilit-chg-clear before performing a new comparison (Bug#23823). --- lisp/hilit-chg.el | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lisp/hilit-chg.el b/lisp/hilit-chg.el index 8f042b6..f6eae52 100644 --- a/lisp/hilit-chg.el +++ b/lisp/hilit-chg.el @@ -804,8 +804,12 @@ highlight-markup-buffers (or file-b (setq temp-b (setq file-b (ediff-make-temp-file buf-b nil)))) (set-buffer buf-a) + (when highlight-changes-mode + (hilit-chg-clear)) (highlight-changes-mode 1) (or markup-a-only (with-current-buffer buf-b + (when highlight-changes-mode + (hilit-chg-clear)) (highlight-changes-mode 1))) (setq change-info (hilit-chg-get-diff-info buf-a file-a buf-b file-b)) @@ -993,6 +997,8 @@ highlight-changes-mode-turn-on (and (not (string-match "^[ *]" (buffer-name))) (buffer-file-name)))) + (when highlight-changes-mode + (hilit-chg-clear)) (highlight-changes-mode 1)) )) -- 2.8.1 From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: Acknowledgement (25.0.95; Reset between highlight buffer/file comparisons) Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2016 10:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23823@debbugs.gnu.org Cc: Tino Calancha Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.14665909386842 (code B ref 23823); Wed, 22 Jun 2016 10:23:01 +0000 Received: (at 23823) by debbugs.gnu.org; 22 Jun 2016 10:22:18 +0000 Received: from localhost ([127.0.0.1]:50364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFfIY-0001mI-Lc for submit@debbugs.gnu.org; Wed, 22 Jun 2016 06:22:18 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFfIW-0001m4-Fr for 23823@debbugs.gnu.org; Wed, 22 Jun 2016 06:22:16 -0400 Received: by mail-pa0-f42.google.com with SMTP id bz2so15772935pad.1 for <23823@debbugs.gnu.org>; Wed, 22 Jun 2016 03:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=OtmiQw2e8dQ7JH2RiSPZpAAUU4SFdgrmmWe5TSVwC5A=; b=c7l6UX3vigiyqV/AbcvsPkt+7sYpVn1ReUyjSYRFoasSEyz6F5OOA87r/Psxdz1+oj xd2eQdZCNBAK2X9zk2xSd30CwHF2zVb9JzF9vnZpcKTimgvYWcyk/5W2kV3NdacBo01j jbwP7uqIj9pQH6fO3YjbL2KzQZekGnZpB6+rM03aYeJBjz4oYw3SSGQdqLznVefP9pl9 35qtGNZz56+EkDeo1A0QL2kiNwuvywe54JwDbph2eO0Hxb5vV6nsIfHz+v2u2WlkckL6 fuSUwfnL7oqEKVUTvqOi69e+YWyYfcWNR+XlZZhRWanLV3C3i2bQjNsWUCa2tczZNwpk P1Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=OtmiQw2e8dQ7JH2RiSPZpAAUU4SFdgrmmWe5TSVwC5A=; b=OvtElNO//2EB+EX7rZeEyclXOPaiX/5+wmsNiuV0Z8Lu23kOqj/AVqv/FZOurXeKu/ 93akSObdXEKHHFCbgkBZ1i114ULqhrCGTMAjq0AnAZWD+yGQIS+gGvABY/dF+aKsNqqe vOX79Et4rDGnGNmWYMNtbrsrAQ08PbI4kMWIsAUo5WTK9Z3t9J0O52f59U6nFaeM00rD cBkivTpvC8r0f8RF/whMOU1gG5zAYc6ySm93ssFczgbkphIvgU1/fGjq8lVR2Twz6wSa SwEKsjj6mqtv3NfRCjIp/bTFMAP932zdb0yKQh8K/qTPvleYy6aRqsf87lAJgcqU+NV1 oG0Q== X-Gm-Message-State: ALyK8tLhm5dCNLsuu+pC1uYeCVeTvExnP05lYb0udsysLnssNdSmiaZUzeQBpEQAfNlKRQ== X-Received: by 10.66.197.202 with SMTP id iw10mr34292413pac.148.1466590930787; Wed, 22 Jun 2016 03:22:10 -0700 (PDT) Received: from calancha-pc (softbank126103144234.bbtec.net. [126.103.144.234]) by smtp.gmail.com with ESMTPSA id 4sm92536250pav.33.2016.06.22.03.22.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 03:22:10 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 22 Jun 2016 19:22:07 +0900 (JST) X-X-Sender: calancha@calancha-pc In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >Following patch fixed it calling >(and highlight-changes-mode (hilit-chg-clear)) >each time >(highlight-changes-mode 1) >is called. Sorry, the patch use: (when highlight-changes-mode (hilit-chg-clear)) instead of: (and highlight-changes-mode (hilit-chg-clear)) It doesn't affect my comment: it would be better if such calls to 'hilit-chg-clear were handle automatically, instead of repeated 'by hand' each time. From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jun 2016 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Tino Calancha Cc: 23823@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.146660863520355 (code B ref 23823); Wed, 22 Jun 2016 15:18:01 +0000 Received: (at 23823) by debbugs.gnu.org; 22 Jun 2016 15:17:15 +0000 Received: from localhost ([127.0.0.1]:51305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjtz-0005IF-4d for submit@debbugs.gnu.org; Wed, 22 Jun 2016 11:17:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFjtx-0005I2-QY for 23823@debbugs.gnu.org; Wed, 22 Jun 2016 11:17:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFjtm-0001tW-E3 for 23823@debbugs.gnu.org; Wed, 22 Jun 2016 11:17:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFjtm-0001tB-Aa; Wed, 22 Jun 2016 11:17:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1871 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFjti-0005z3-Dl; Wed, 22 Jun 2016 11:16:58 -0400 Date: Wed, 22 Jun 2016 18:16:10 +0300 Message-Id: <83y45x45l1.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Tino Calancha on Wed, 22 Jun 2016 19:11:27 +0900 (JST)) References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.5 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.5 (------) > From: Tino Calancha > Date: Wed, 22 Jun 2016 19:11:27 +0900 (JST) > > ./emacs -r -Q -eval '(progn (with-temp-file "/tmp/foo" (insert "foo")) > (switch-to-buffer "bar") (insert "boo"))' > M-: (highlight-compare-with-file "/tmp/foo") RET > C-b C-b DEL f > M-: M-p RET > ;; Now current buffer content equals /tmp/foo content > ;; but foo is still displayed with face highlight-changes. What I see is 'f' in a "deleted" face. Which seems reasonable to me. Whether a change that countermands another change should count as a change is a philosophical question that AFAIK doesn't have a one-fits-all answer. From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jun 2016 00:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23823@debbugs.gnu.org Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.146664280014573 (code B ref 23823); Thu, 23 Jun 2016 00:47:02 +0000 Received: (at 23823) by debbugs.gnu.org; 23 Jun 2016 00:46:40 +0000 Received: from localhost ([127.0.0.1]:51629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFsn1-0003mz-Pe for submit@debbugs.gnu.org; Wed, 22 Jun 2016 20:46:39 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:36835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFsn1-0003mn-1x for 23823@debbugs.gnu.org; Wed, 22 Jun 2016 20:46:39 -0400 Received: by mail-pa0-f47.google.com with SMTP id wo6so21615690pac.3 for <23823@debbugs.gnu.org>; Wed, 22 Jun 2016 17:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=2ju6FcDVJbwgY19ZUmH6BizITRnuasWSfTF1+EZy3kg=; b=vmEHY+Nm3idvFapE2WH2mUnBSqjrOZ4ywTDBEwQ2JW6Z0JQnnOwqn0oJv3B6S9QqII sxvt0aSs1y9shyfxdzolY93RjTu7NnKYZf0qQuIeUgwP2NAk+Jtyt7THuflmOjVPTc7T NGfH8dOJS5+usw3YAptx1w6pcrNdsM6HCOlC9uInuNweOgQi+RvtoqWksikHRYuWIZf7 C10BiUoCPYSLIJZFGb0feQ7dRvm8Y7vCoYjThx1lekt09tCpTLvQSSSxyqz0znn54aR4 EhKr5NgYXHBHXY/MGqx3GDasHYhIpWAaxe5ZgfXHq5VLwMWAW7lNA2ROFIrL64fjXDZw 1hiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=2ju6FcDVJbwgY19ZUmH6BizITRnuasWSfTF1+EZy3kg=; b=cyqdzHIaczlEg8bLAnIdn9hAJNFWljkbXYAi/eNnfw/iKZJnN2irp1slwJI1+JLedv BF6Fb8f6X8OSmLBqKPB/RcTnOm2LsZHhKKaH/Dmr7/72375uIsMSt2lUz7M4pjGxFGqI KtSLlspXGgRbkH5F/CvvLR5TRU6kqnV0+MADP6kG4UnZgtEeo6dgh5U4TYNEfAruY53v PvxZkbLV8BpvI/HUvc/XddTPHVoHxxVYq96YySQ2n4ZZP8+qGqAhtWixpsiDWGNmQZe3 4FRmxQr619SmeTF0ElBx0ry5rAsWa4sUfjgObl07Qxbbe0UkD1QsC4B5GDaQRowwELGP SWIg== X-Gm-Message-State: ALyK8tIiCxx3BJQ88N0Xkq3plR3k2lfC4kgvBdO8p+oMAw6dbH19xShlIWFUTQKrSfPR9w== X-Received: by 10.66.65.109 with SMTP id w13mr37974198pas.142.1466642793119; Wed, 22 Jun 2016 17:46:33 -0700 (PDT) Received: from [192.168.1.51] (softbank126103144234.bbtec.net. [126.103.144.234]) by smtp.gmail.com with ESMTPSA id p129sm2332498pfb.73.2016.06.22.17.46.28 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 17:46:29 -0700 (PDT) References: <83y45x45l1.fsf@gnu.org> From: Tino Calancha Message-ID: <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> Date: Thu, 23 Jun 2016 09:46:27 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <83y45x45l1.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/23/2016 12:16 AM, Eli Zaretskii wrote: > What I see is 'f' in a "deleted" face. Which seems reasonable to me. > > Whether a change that countermands another change should count as a > change is a philosophical question that AFAIK doesn't have a > one-fits-all answer. The way i understand my example is as follows: 1) An user compare current buffer (buf-a) with file-b. ;; buf-a content: boo ;; file-b content: foo ;; they are different: new faces shown their differences. 2) The user update buf-a and perform a new comparison with file-b. ;; buf-a content: foo ;; file-b content: foo ;; same content, but is not obvious because the result of the ;; previous comparison is not removed. My point is: why don't we perform a fresh comparison in 2? From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Jun 2016 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tino Calancha Cc: 23823@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.146669551518752 (code B ref 23823); Thu, 23 Jun 2016 15:26:02 +0000 Received: (at 23823) by debbugs.gnu.org; 23 Jun 2016 15:25:15 +0000 Received: from localhost ([127.0.0.1]:52821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG6VG-0004sN-VN for submit@debbugs.gnu.org; Thu, 23 Jun 2016 11:25:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG6VG-0004sB-6w for 23823@debbugs.gnu.org; Thu, 23 Jun 2016 11:25:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG6V7-0007AQ-UB for 23823@debbugs.gnu.org; Thu, 23 Jun 2016 11:25:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG6V7-00079p-R7; Thu, 23 Jun 2016 11:25:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3134 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bG6V5-00020s-R5; Thu, 23 Jun 2016 11:25:04 -0400 Date: Thu, 23 Jun 2016 18:24:17 +0300 Message-Id: <83mvmc2aji.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> (message from Tino Calancha on Thu, 23 Jun 2016 09:46:27 +0900) References: <83y45x45l1.fsf@gnu.org> <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23823@debbugs.gnu.org > From: Tino Calancha > Date: Thu, 23 Jun 2016 09:46:27 +0900 > > My point is: why don't we perform a fresh comparison in 2? Because the first time you call highlight-compare-with-file, it turns on the highlight-changes-mode, which begins to mark changes, including the replacement of 'b' with 'f'. Why does it make sense to forget all that information? From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2016 04:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Tino Calancha , 23823@debbugs.gnu.org Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.146674298815213 (code B ref 23823); Fri, 24 Jun 2016 04:37:01 +0000 Received: (at 23823) by debbugs.gnu.org; 24 Jun 2016 04:36:28 +0000 Received: from localhost ([127.0.0.1]:53196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGIqy-0003xH-5P for submit@debbugs.gnu.org; Fri, 24 Jun 2016 00:36:28 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGIqw-0003x5-9P for 23823@debbugs.gnu.org; Fri, 24 Jun 2016 00:36:27 -0400 Received: by mail-pa0-f53.google.com with SMTP id hl6so33701293pac.2 for <23823@debbugs.gnu.org>; Thu, 23 Jun 2016 21:36:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=aoaNyrepZpVJfo5PmYiv1vnsBfaqJ0dSbOvKyi7T/mo=; b=usbiYjoBDLueXqr+E20XUwkBxA8w8ZclpazeJMeHAv4vcjTCP7mFqQWz688iIt/jgX y1C4void1P/k+6+T6vzoUzWrwbosymn+XJMBwHs/ubH8PcMbNJOTpTJD6cOPZollmGSz Ip7NtU8JwJz53g4T1obu8uBVKwt5I86TUFkWdSCNZBGFp4/wgwGB4rcGRHCWZNYGAXaS GJETKBsChJva/88om2mxN/jdnmvW3btY1QkPA5ySwqocCr8Mva2oK56NFMQkVBIZw643 dheoB9wu4WrTaVBlQpLWW1bc1Xh8oSIdAOB0e1Gh4Dv/u5j0qYu6oN+yIyusHctAvr6w AmKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=aoaNyrepZpVJfo5PmYiv1vnsBfaqJ0dSbOvKyi7T/mo=; b=gyhDpUDCCaB9H9rBpG+gWcR7yfe9J98Fyv1SCtpNnQmTKrr6vISbQ8NOc7ZswXCjUu K169KnV9HfKVBvV+zd9W4JMiFvfqZSjINLriOQ/3l8M2olqZz6RKh7LoqPWMD9N88yen 7u6r6SXvezC1Nw1kJjiYUrV/4OvhMLgxDAvu5bhkI3LqnHMQVMeh0gu6QKiiZzfjZjPe OG6QHAD2GTTPktovI9WmxWn6/JuR2mPt+tnaWmRu4EfiVb0xSiXDgS1pm4IoMNPxAN8e uEY/NZCsbcyNf2cnL1pIO1tAltbtcbYcFDYrFwJa1fZbQm/8tYIacDtKxNN93tNTH4u8 cWCw== X-Gm-Message-State: ALyK8tL0xCyTY5h3joTyKmnUoU2b4wK7t8++lYNc5SKyeGxvetNPQHeKoxEGI6JJwXZieA== X-Received: by 10.66.121.136 with SMTP id lk8mr3911677pab.51.1466742980410; Thu, 23 Jun 2016 21:36:20 -0700 (PDT) Received: from calancha-pc (softbank126103139048.bbtec.net. [126.103.139.48]) by smtp.gmail.com with ESMTPSA id 81sm3587762pfo.74.2016.06.23.21.36.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jun 2016 21:36:19 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 24 Jun 2016 13:36:17 +0900 (JST) X-X-Sender: calancha@calancha-pc In-Reply-To: <83mvmc2aji.fsf@gnu.org> Message-ID: References: <83y45x45l1.fsf@gnu.org> <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> <83mvmc2aji.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, 23 Jun 2016, Eli Zaretskii wrote: >> Cc: 23823@debbugs.gnu.org >> From: Tino Calancha >> Date: Thu, 23 Jun 2016 09:46:27 +0900 >> >> My point is: why don't we perform a fresh comparison in 2? > > Because the first time you call highlight-compare-with-file, it turns > on the highlight-changes-mode, which begins to mark changes, including > the replacement of 'b' with 'f'. Yeah, that sounds nice to me: the user is still somehow in the context of the first func. call. > Why does it make sense to forget all that information? Because the user called the function again: this may start a new context, i.e., reset the minor mode in that buffer. I imagine buf-a becaming a mess of colors with all those changes around. At some point the user may want to compare again the current status of buf-a with file-b. From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2016 07:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tino Calancha Cc: f92capac@gmail.com, 23823@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.146675209231177 (code B ref 23823); Fri, 24 Jun 2016 07:09:02 +0000 Received: (at 23823) by debbugs.gnu.org; 24 Jun 2016 07:08:12 +0000 Received: from localhost ([127.0.0.1]:53271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGLDo-00086n-Cg for submit@debbugs.gnu.org; Fri, 24 Jun 2016 03:08:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGLDm-00086Z-N0 for 23823@debbugs.gnu.org; Fri, 24 Jun 2016 03:08:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGLDc-0007Zx-H1 for 23823@debbugs.gnu.org; Fri, 24 Jun 2016 03:08:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGLDc-0007Z4-Dr; Fri, 24 Jun 2016 03:08:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3745 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bGLDX-0007AY-Ti; Fri, 24 Jun 2016 03:07:56 -0400 Date: Fri, 24 Jun 2016 10:07:11 +0300 Message-Id: <837fdf2hgg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Tino Calancha on Fri, 24 Jun 2016 13:36:17 +0900 (JST)) References: <83y45x45l1.fsf@gnu.org> <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> <83mvmc2aji.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Tino Calancha > Date: Fri, 24 Jun 2016 13:36:17 +0900 (JST) > cc: Tino Calancha , 23823@debbugs.gnu.org > > >> My point is: why don't we perform a fresh comparison in 2? > > > > Because the first time you call highlight-compare-with-file, it turns > > on the highlight-changes-mode, which begins to mark changes, including > > the replacement of 'b' with 'f'. > Yeah, that sounds nice to me: the user is still somehow in the context > of the first func. call. > > > > Why does it make sense to forget all that information? > Because the user called the function again: this may start a new context, > i.e., reset the minor mode in that buffer. But the function's doc string clearly makes that expected behavior: If the current buffer is visiting the file being compared against, it also will have its differences highlighted. The only way I can interpret that "also" part is that the changes against the file are highlighted _in_addition_ to the changes tracked by the mode. Your scenario just happens to produce a clash between these two sets of differences, and the result could be ambiguous. But what we get in fact doesn't seem unreasonable to me. > I imagine buf-a becaming a mess of colors with all those changes around. > At some point the user may want to compare again the current status of > buf-a with file-b. Well, then maybe a prefix argument to that effect could provide this as an optional behavior? From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Jun 2016 13:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Tino Calancha , 23823@debbugs.gnu.org Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.14667740169341 (code B ref 23823); Fri, 24 Jun 2016 13:14:02 +0000 Received: (at 23823) by debbugs.gnu.org; 24 Jun 2016 13:13:36 +0000 Received: from localhost ([127.0.0.1]:53512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGQvP-0002Qb-NB for submit@debbugs.gnu.org; Fri, 24 Jun 2016 09:13:35 -0400 Received: from mail-pa0-f52.google.com ([209.85.220.52]:34027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGQvN-0002QO-P8 for 23823@debbugs.gnu.org; Fri, 24 Jun 2016 09:13:34 -0400 Received: by mail-pa0-f52.google.com with SMTP id bz2so37636648pad.1 for <23823@debbugs.gnu.org>; Fri, 24 Jun 2016 06:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=CT0r6mFW6g7XJ7zaoRL6oQeTqorRc49bMzSt4xSnoE0=; b=zwyL+aBU1LHam68Bp/kIqTryz8mvrpZ8b7nFZx6J5mr7oWWt7/o21Rbw3XnCG+EE2n gtSDTk5M+D2F06g96VP+awN6gPJNXCj1jUf3D3ET2BvCo7AKBFgSCOwNTBi1LcHBJdST rog9ZIXCCxqdZl+TWMBmrRWqH4jANeD337SH1/hH3xHzzxbcwu/jsATnE8ZIV7PGBx8w TD5ClS4B3ka5DIsYjBEB8IQlQ85xTPGYwSGxZKZ65q2Ssv7QYIt+/BUu6WWNyXV+sjXl 3wCg0Vox17131PisbcBepGrshlFfgOwj6fMKW6AWBXqEO/GrMxiDljN2CGOP/65DjJKG dzmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=CT0r6mFW6g7XJ7zaoRL6oQeTqorRc49bMzSt4xSnoE0=; b=mIFa/2vGMvxaNi71ojxxWwIyJ749Sbb1Z/Q6bnbeqBWYy5MQ2MGdJGvPBcJLCow/H2 tqqnnCVRlQZSDGqc8N5qH9UzaWekT9kQEbvb8eVI5KuF4RUGBk9YTF4IeCuzFRCGtDmM 5MoHMww6+nFm+6CM/tDZP1oimeZ4OGP1LHlrZ7yB3AY/aly/EfUz/FqJDOfHpA5zvSrV OI+bm76b/B7krr+scvis7JjtTiBiyRJYfUy9yIfsHdPTTp/T8xK2++gVL5d2wIbPPsLT iXJM4kVjAdMkXd3kNXlC2zWyuszPi/BZPxod8onWoCqP6M8whsuwZe816ETFtnCQYvcD OZGA== X-Gm-Message-State: ALyK8tKjSY+G8zdhML0qSmscrvcbKO4Vr0zbnpA1McT/ORfyWWcKmSQGYv4I5BZfZPXaMg== X-Received: by 10.66.85.197 with SMTP id j5mr7500713paz.87.1466774007828; Fri, 24 Jun 2016 06:13:27 -0700 (PDT) Received: from calancha-pc (softbank126103139048.bbtec.net. [126.103.139.48]) by smtp.gmail.com with ESMTPSA id 75sm8113549pfy.32.2016.06.24.06.13.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Jun 2016 06:13:27 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Fri, 24 Jun 2016 22:13:25 +0900 (JST) X-X-Sender: calancha@calancha-pc In-Reply-To: <837fdf2hgg.fsf@gnu.org> Message-ID: References: <83y45x45l1.fsf@gnu.org> <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> <83mvmc2aji.fsf@gnu.org> <837fdf2hgg.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, 24 Jun 2016, Eli Zaretskii wrote: > But the function's doc string clearly makes that expected behavior: > > If the current buffer is visiting the file being compared against, it > also will have its differences highlighted. > > The only way I can interpret that "also" part is that the changes > against the file are highlighted _in_addition_ to the changes tracked > by the mode. Your scenario just happens to produce a clash between > these two sets of differences, and the result could be ambiguous. But > what we get in fact doesn't seem unreasonable to me. You convinced me: there is no need to reset those highlighted differences. If the user want to do that he/she could toggle eaasily the mode before calling the func. Adding a prefix argument to reset may cause accidentaly lost all the tracked differences. The comentary of this lib helps to understand the design intentions. For example when it says: ;; You can "age" different sets of changes by using ;; `highlight-changes-rotate-faces'. Each time the buffer is saved, the new differences get a different face. Following example shows the point: emacs -Q -eval "(progn (with-temp-file \"/tmp/foo\" (insert \"Hi i am foo\n\")) (find-file \"/tmp/foo\") (highlight-changes-mode 1) (add-hook 'write-file-functions 'highlight-changes-rotate-faces nil t))" M-: (progn (goto-char (point-max)) (insert "Hi foo, i am bar.\n") (highlight-compare-with-file "/tmp/foo")) RET y y M-: (progn (goto-char (point-max)) (insert "Nice to meet you foo.\n") (highlight-compare-with-file "/tmp/foo")) RET y y M-: (progn (goto-char (point-max)) (insert "Nice to meet you too, bar.\n") (highlight-compare-with-file "/tmp/foo")) RET y y ;; If we reset the buffer on each func call we will loose all this ;; psicodelic color structure :-S From unknown Fri Sep 05 08:21:56 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23823: 25.0.95; Reset between highlight buffer/file comparisons Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jun 2019 12:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23823 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Tino Calancha Cc: 23823@debbugs.gnu.org, Eli Zaretskii Received: via spool by 23823-submit@debbugs.gnu.org id=B23823.156146555319766 (code B ref 23823); Tue, 25 Jun 2019 12:26:02 +0000 Received: (at 23823) by debbugs.gnu.org; 25 Jun 2019 12:25:53 +0000 Received: from localhost ([127.0.0.1]:58857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkWH-00058k-0m for submit@debbugs.gnu.org; Tue, 25 Jun 2019 08:25:53 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkWE-00058c-IW for 23823@debbugs.gnu.org; Tue, 25 Jun 2019 08:25:50 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkWB-0007wB-J1; Tue, 25 Jun 2019 14:25:49 +0200 From: Lars Ingebrigtsen References: <83y45x45l1.fsf@gnu.org> <8b3c0970-72af-3f33-627a-e520c7708f51@gmail.com> <83mvmc2aji.fsf@gnu.org> <837fdf2hgg.fsf@gnu.org> Date: Tue, 25 Jun 2019 14:25:47 +0200 In-Reply-To: (Tino Calancha's message of "Fri, 24 Jun 2016 22:13:25 +0900 (JST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tino Calancha writes: > You convinced me: there is no need to reset those highlighted > differences. If the user want to do that he/she could toggle eaasily > the mode before calling the func. Adding a prefix argument to r [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > You convinced me: there is no need to reset those highlighted > differences. If the user want to do that he/she could toggle eaasily > the mode before calling the func. Adding a prefix argument to reset > may cause accidentaly lost all the tracked differences. If I understood this correctly, it was decided that the proposed change wasn't desirable, so I'm closing this bug report. Please reopen if I misunderstood. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 08:26:01 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 12:26:01 +0000 Received: from localhost ([127.0.0.1]:58860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkWP-000599-Ab for submit@debbugs.gnu.org; Tue, 25 Jun 2019 08:26:01 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfkWN-00058z-33 for control@debbugs.gnu.org; Tue, 25 Jun 2019 08:25:59 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hfkWK-0007wJ-J9 for control@debbugs.gnu.org; Tue, 25 Jun 2019 14:25:58 +0200 Date: Tue, 25 Jun 2019 14:25:56 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #23823 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 23823 wontfix close 23823 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23823 wontfix close 23823 quit