GNU bug report logs - #23820
25.1.50; Fix caller to ediff-setup

Previous Next

Package: emacs;

Reported by: Tino Calancha <f92capac <at> gmail.com>

Date: Wed, 22 Jun 2016 04:16:01 UTC

Severity: normal

Tags: patch

Found in version 25.1.50

Done: Tino Calancha <tino.calancha <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 23820 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Tino Calancha <f92capac <at> gmail.com>
Cc: 23820 <at> debbugs.gnu.org
Subject: Re: bug#23820: 25.1.50; Fix caller to ediff-setup
Date: Wed, 22 Jun 2016 00:33:20 -0400

On Wed, Jun 22, 2016 at 12:15 AM, Tino Calancha <f92capac <at> gmail.com> wrote:
>
> Hello,
>
> Seventh argument of ediff-setup is a hook: hilit-chg-get-diff-info
> is passing a function.

I think that argument is not a hook but just a list of functions, so
it should suffice to do

@@ -913,7 +916,7 @@ hilit-chg-get-diff-info
   (let (hilit-e hilit-x hilit-y)
     (ediff-setup buf-a file-a buf-b file-b
               nil nil   ; buf-c file-C
-              'hilit-chg-get-diff-list-hk
+              '(hilit-chg-get-diff-info-hk)
               (list (cons 'ediff-job-name 'something))
               )
     (ediff-with-current-buffer hilit-e (ediff-really-quit nil))
This bug report was last modified 8 years and 334 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.