GNU bug report logs - #23808
Emacs 25 open-network-stream, make-network-process

Previous Next

Full log

Message #22 received at 23808 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 23808 <at> debbugs.gnu.org
Subject: Re: bug#23808: Emacs 25 open-network-stream, make-network-process
Date: Thu, 11 Aug 2016 12:42:06 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> This problem was introduced by the recent async changes (Bug#23808).
> * src/process.c (Fmake_process): Move USE_SAFE_ALLOCA later,
> so that it follows the start_process_unwind unwind-protect.
> Set pid to -1 while the process is being created.
> (start_process_unwind): Omit unnecessary emacs_abort test.
> (connect_network_socket): Simplify use of counts.  Unwind
> bind_polling_period a bit earlier, so that a remove_process
> unwind-protect can be added when needed; this is the heart of
> the fix.  Undo the unwind-protect just before returning.

Seems like the right fix to me, I think?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.