GNU bug report logs - #23794
Make sort-lines respect visible lines

Previous Next

Full log

View this message in rfc822 format

From: Robert Weiner <rsw <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23794 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>, emacs-devel <emacs-devel <at> gnu.org>
Subject: bug#23794: Emacs bug #23794; sort-line behavior regressed from prior Emacs versions
Date: Sun, 19 Jun 2016 13:03:53 -0400

[Message part 1 (text/plain, inline)]

On Sun, Jun 19, 2016 at 12:55 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Robert Weiner <rsw <at> gnu.org>
> >
> > The problem with that approach is that each mode has to be aware of this
> and add a setting, really not much
> > different than each mode having its own sort function or way of calling
> a sort function. It is much more useful
> > to centralize the behavior within the sorting library, even if it adds
> some conditional complexity to the code.
>
> Not necessarily: if you set that up in outline-mode, all of its
> descendants will inherit the setting for free.
>

Ok.


>
> > Here is the suggested patch to do it this way. -- Bob
>

One other possibility that is fairly clean is to add sort-visible-*
functions to the sort library; then callers would just have to remember to
call the visible or the regular version of the function and there would be
no need for any new defcustoms.


> Thanks, I hope others will comment on this.
>

Yes.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.