From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 21:39:36 2016 Received: (at submit) by debbugs.gnu.org; 18 Jun 2016 01:39:36 +0000 Received: from localhost ([127.0.0.1]:44636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE5EW-0007Yq-3p for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:39:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32919) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE53P-0007Gl-KG for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:28:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE53J-0008RT-Mv for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:28:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49533) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE53J-0008RD-JB for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:28:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE53H-0005gH-EO for bug-hyperbole@gnu.org; Fri, 17 Jun 2016 21:28:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE53D-0008Pf-Cf for bug-hyperbole@gnu.org; Fri, 17 Jun 2016 21:27:58 -0400 Received: from m12-18.163.com ([220.181.12.18]:32947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE53C-0008Mr-Ax for bug-hyperbole@gnu.org; Fri, 17 Jun 2016 21:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=bw5Hk 203PSfGaqbiQpTbEsBidRcXPWa/45dWDqL8w/U=; b=D8zFU9u2GWJ3+gfpUnmED brbir3U6acreMVSaDJSPtGjoA5B0AqH2bLX1eGrbhe7H2oKacNdhar0IXur2h6q8 5O7N/lj8hwYuKKLt/1VEe6A9NzFmE+wsUiSkuFpjIbhh2YR4o6a9HAEe1uRA+bP9 53Jdn6dHRZDccXoQi4MnHI= Received: from tumashu (unknown [103.207.231.51]) by smtp14 (Coremail) with SMTP id EsCowEDpo0aJo2RXLu85AA--.8719S2; Sat, 18 Jun 2016 09:27:38 +0800 (CST) From: "Feng Shu" To: bug-hyperbole Subject: rolo-sort run incorrect. Date: Sat, 18 Jun 2016 09:13:08 +0800 Message-ID: <87mvmji9jv.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-CM-TRANSID: EsCowEDpo0aJo2RXLu85AA--.8719S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUDHUDDUUUU X-Originating-IP: [103.207.231.51] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiwAuM1FXlUXPPLQAAsj X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 17 Jun 2016 21:39:33 -0400 Cc: Feng Shu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Before: ---------------------------- * Feng Shu 6/17/2016 * fs 6/18/2016 --------------------------- End: --------------------------- 6/17/2016 6/18/2016 * Feng Shu * fs --------------------------- -- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 11:47:51 2016 Received: (at 23789) by debbugs.gnu.org; 18 Jun 2016 15:47:51 +0000 Received: from localhost ([127.0.0.1]:45286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEITO-0005e9-OO for submit@debbugs.gnu.org; Sat, 18 Jun 2016 11:47:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEITN-0005dr-BM for 23789@debbugs.gnu.org; Sat, 18 Jun 2016 11:47:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEITE-0001mf-MR for 23789@debbugs.gnu.org; Sat, 18 Jun 2016 11:47:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,HTML_MESSAGE, RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEITE-0001mP-JI for 23789@debbugs.gnu.org; Sat, 18 Jun 2016 11:47:40 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:33274) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEITD-00069u-0J for 23789@debbugs.gnu.org; Sat, 18 Jun 2016 11:47:39 -0400 Received: by mail-oi0-f43.google.com with SMTP id u201so156765864oie.0 for <23789@debbugs.gnu.org>; Sat, 18 Jun 2016 08:47:38 -0700 (PDT) X-Gm-Message-State: ALyK8tKrOZkxLB05oaAdZ7LK0uIV5wCtpEaF0U9cRsMIQOAKpiRWo3AYjsv0Zjm3uIG+ULUK76u8xNOci7WMsA== X-Received: by 10.202.218.65 with SMTP id r62mr3836293oig.32.1466264858124; Sat, 18 Jun 2016 08:47:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.73 with HTTP; Sat, 18 Jun 2016 08:47:08 -0700 (PDT) From: Robert Weiner Date: Sat, 18 Jun 2016 11:47:08 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Emacs 25.0.94: Patch to make sort-lines respect visible lines (fairly urgent) To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a113d48b203ea7605358f6459 Bcc: 23789@debbugs.gnu.org X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 23789 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rswgnu@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) --001a113d48b203ea7605358f6459 Content-Type: text/plain; charset=UTF-8 sort-lines calls forward-line rather than forward-visible line, so if you have emacs outline entries that are collapsed/hidden to single lines each and you try to sort them, their bodies and subtrees are sorted separately because forward-visible-line is not used. This patch fixes this problem and also unifies the calling convention of forward-visible-line with that of forward-line (allowing it to take an optional argument) leading to a cleaner calling convention. Please apply it as soon as you can as Hyperbole uses sort-lines to sort its contact manager records and right now this doesn't work. Although, sort-subr could be called directly for this application, sort-lines should work properly with both visible and invisible text and the patch is quite simple. Thanks, Bob -------- In GNU Emacs 25.0.94.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F1603)) of 2016-05-17 built on builder10-9.local Windowing system distributor 'Apple', version 10.3.1404 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp'' Configured features: NOTIFY ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix ---------------- *** sort-orig.el.gz 2016-06-18 11:31:13.000000000 -0400 --- sort.el.gz 2016-06-18 11:31:13.000000000 -0400 *************** *** 210,216 **** (goto-char (point-min)) (let ;; To make `end-of-line' and etc. to ignore fields. ((inhibit-field-text-motion t)) ! (sort-subr reverse 'forward-line 'end-of-line))))) ;;;###autoload (defun sort-paragraphs (reverse beg end) --- 210,216 ---- (goto-char (point-min)) (let ;; To make `end-of-line' and etc. to ignore fields. ((inhibit-field-text-motion t)) ! (sort-subr reverse 'forward-visible-line 'end-of-visible-line))))) ;;;###autoload (defun sort-paragraphs (reverse beg end) *** simple-orig.el.gz 2016-06-18 11:29:58.000000000 -0400 --- simple.el.gz 2016-06-18 11:29:58.000000000 -0400 *************** *** 4909,4918 **** (kill-region (point) (progn (forward-visible-line arg) (point)))))) ! (defun forward-visible-line (arg) ! "Move forward by ARG lines, ignoring currently invisible newlines only. If ARG is negative, move backward -ARG lines. If ARG is zero, move to the beginning of the current line." (condition-case nil (if (> arg 0) (progn --- 4909,4919 ---- (kill-region (point) (progn (forward-visible-line arg) (point)))))) ! (defun forward-visible-line (&optional arg) ! "Move forward by optional ARG lines (default = 1), ignoring currently invisible newlines only. If ARG is negative, move backward -ARG lines. If ARG is zero, move to the beginning of the current line." + (if (null arg) (setq arg 1)) (condition-case nil (if (> arg 0) (progn --001a113d48b203ea7605358f6459 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
sort-lines calls forward-line rather than forward-visible = line, so if
you have emacs outline entries that are collapsed/hidden to = single lines
each and you try to sort them, their bodies and subtrees ar= e sorted
separately because forward-visible-line is not used.

Thi= s patch fixes this problem and also unifies the calling convention of
fo= rward-visible-line with that of forward-line (allowing it to take an
opt= ional argument) leading to a cleaner calling convention.

Please appl= y it as soon as you can as Hyperbole uses sort-lines to sort
its contact= manager records and right now this doesn't work.=C2=A0 Although,
so= rt-subr could be called directly for this application, sort-lines
should= work properly with both visible and invisible text and the patch
is qui= te simple.

Thanks,

Bob
--------

In GNU Emacs 25.0.9= 4.1 (x86_64-apple-darwin13.4.0, NS appkit-1265.21 Version 10.9.5 (Build 13F= 1603))
=C2=A0of 2016-05-17 built on builder10-9.local
Windowing syste= m distributor 'Apple', version 10.3.1404
Configured using:
= =C2=A0'configure --with-ns '--enable-locallisppath=3D/Library/Appli= cation
=C2=A0Support/Emacs/${version}/site-lisp:/Library/Application
= =C2=A0Support/Emacs/site-lisp''

Configured features:
NOTI= FY ACL LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS

Important settings:
= =C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-coding-system: utf-8-un= ix

----------------

*** sort-orig.el.gz 2016-06-18 11:31:13.0= 00000000 -0400
--- sort.el.gz 2016-06-18 11:31:13.000000000 -0400
***= ************
*** 210,216 ****
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (goto-char = (point-min))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ;; To make `end-of-line= 9; and etc. to ignore fields.
=C2=A0 =C2=A0((inhibit-field-text-motion t= ))
! (sort-subr reverse 'forward-line 'end-of-line)))))
=C2= =A0
=C2=A0 ;;;###autoload
=C2=A0 (defun sort-paragraphs (reverse beg= end)
--- 210,216 ----
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (goto-char (point-= min))
=C2=A0 =C2=A0 =C2=A0 =C2=A0 (let ;; To make `end-of-line' and = etc. to ignore fields.
=C2=A0 =C2=A0((inhibit-field-text-motion t))
!= (sort-subr reverse 'forward-visible-line 'end-of-visible-line)))))=
=C2=A0
=C2=A0 ;;;###autoload
=C2=A0 (defun sort-paragraphs (reve= rse beg end)


*** simple-orig.el.gz 2016-06-18 11:29:58.000000000= -0400
--- simple.el.gz 2016-06-18 11:29:58.000000000 -0400
*********= ******
*** 4909,4918 ****
=C2=A0 (kill-region (point)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0(progn (forward-visible-line arg) (point))))))
=C2=A0 <= br>! (defun forward-visible-line (arg)
! =C2=A0 "Move forward by AR= G lines, ignoring currently invisible newlines only.
=C2=A0 If ARG is ne= gative, move backward -ARG lines.
=C2=A0 If ARG is zero, move to the beg= inning of the current line."
=C2=A0 =C2=A0 (condition-case nil
= =C2=A0 =C2=A0 =C2=A0 =C2=A0 (if (> arg 0)
=C2=A0 =C2=A0(progn
--- = 4909,4919 ----
=C2=A0 (kill-region (point)
=C2=A0 =C2=A0 =C2=A0 =C2= =A0(progn (forward-visible-line arg) (point))))))
=C2=A0
! (defun fo= rward-visible-line (&optional arg)
! =C2=A0 "Move forward by op= tional ARG lines (default =3D 1), ignoring currently invisible newlines onl= y.
=C2=A0 If ARG is negative, move backward -ARG lines.
=C2=A0 If ARG= is zero, move to the beginning of the current line."
+ =C2=A0 (if = (null arg) (setq arg 1))
=C2=A0 =C2=A0 (condition-case nil
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 (if (> arg 0)
=C2=A0 =C2=A0(progn
--001a113d48b203ea7605358f6459-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 17:32:00 2016 Received: (at 23789) by debbugs.gnu.org; 19 Jun 2016 21:32:00 +0000 Received: from localhost ([127.0.0.1]:46749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEkJz-00066S-S8 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 17:32:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52039) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEkJy-00066B-Ar for 23789@debbugs.gnu.org; Sun, 19 Jun 2016 17:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEkJq-0002TU-3b for 23789@debbugs.gnu.org; Sun, 19 Jun 2016 17:31:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEkJq-0002TB-11 for 23789@debbugs.gnu.org; Sun, 19 Jun 2016 17:31:50 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:35380) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEkJo-0000IK-FS for 23789@debbugs.gnu.org; Sun, 19 Jun 2016 17:31:48 -0400 Received: by mail-ob0-f178.google.com with SMTP id ot10so2171253obb.2 for <23789@debbugs.gnu.org>; Sun, 19 Jun 2016 14:31:48 -0700 (PDT) X-Gm-Message-State: ALyK8tKdLU10ZXlRx+Cnps8+jFc4ZYQLo8Tmoz0BL5vL8IFIl4afM7XQJcfp7USQ3ZvcVikbPvHrUtny8BdUiw== X-Received: by 10.157.6.3 with SMTP id 3mr6835910otn.143.1466371907819; Sun, 19 Jun 2016 14:31:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.236.73 with HTTP; Sun, 19 Jun 2016 14:31:18 -0700 (PDT) In-Reply-To: <87mvmji9jv.fsf@163.com> References: <87mvmji9jv.fsf@163.com> From: Robert Weiner Date: Sun, 19 Jun 2016 17:31:18 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: bug#23789: rolo-sort run incorrect. To: Feng Shu Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 23789 Cc: 23789@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rswgnu@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) Fixed in the next release, 5.13. Thanks for pointing this out. -- Bob On Fri, Jun 17, 2016 at 9:13 PM, Feng Shu wrote: > > Before: > > ---------------------------- > * Feng Shu > 6/17/2016 > > * fs > 6/18/2016 > --------------------------- > > End: > --------------------------- > > 6/17/2016 > 6/18/2016 > * Feng Shu > * fs > --------------------------- > From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 01 12:36:04 2016 Received: (at control) by debbugs.gnu.org; 1 Jul 2016 16:36:04 +0000 Received: from localhost ([127.0.0.1]:34079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJ1QC-0008Ie-1j for submit@debbugs.gnu.org; Fri, 01 Jul 2016 12:36:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJ1QA-0008IA-G4 for control@debbugs.gnu.org; Fri, 01 Jul 2016 12:36:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJ1Q1-0007zN-GF for control@debbugs.gnu.org; Fri, 01 Jul 2016 12:35:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33062) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJ1Q1-0007zJ-DH for control@debbugs.gnu.org; Fri, 01 Jul 2016 12:35:53 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:33013) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bJ1Pz-0006Jw-DF for control@debbugs.gnu.org; Fri, 01 Jul 2016 12:35:51 -0400 Received: by mail-oi0-f43.google.com with SMTP id u201so117734020oie.0 for ; Fri, 01 Jul 2016 09:35:51 -0700 (PDT) X-Gm-Message-State: ALyK8tIwcVXGpv6nIdQ6dEne+V1QPUFV/MBI6M5vmt3cMXfQARBIzz+GKjoKz6BlLFDgtHcnpjOey5o78NCKFw== X-Received: by 10.202.98.131 with SMTP id w125mr12755793oib.32.1467390950638; Fri, 01 Jul 2016 09:35:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.212.143 with HTTP; Fri, 1 Jul 2016 09:35:21 -0700 (PDT) From: Robert Weiner Date: Fri, 1 Jul 2016 12:35:21 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: control message for bug #23889 To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rswgnu@gmail.com Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) close 23789 5.13 From unknown Mon Aug 18 15:39:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 30 Jul 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator