From unknown Fri Aug 15 12:51:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23779 <23779@debbugs.gnu.org> To: bug#23779 <23779@debbugs.gnu.org> Subject: Status: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env Reply-To: bug#23779 <23779@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:51:50 +0000 retitle 23779 25.0.95; consing "SHELLVAR" onto process-environment doesn't = remove it from subprocess env reassign 23779 emacs submitter 23779 Noam Postavsky severity 23779 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 23:33:15 2016 Received: (at submit) by debbugs.gnu.org; 17 Jun 2016 03:33:15 +0000 Received: from localhost ([127.0.0.1]:43674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDkWx-00088H-AR for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:33:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDkWw-00087z-FJ for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:33:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDkWq-0003JB-8f for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:33:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDkWq-0003Io-5S for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:33:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDkWn-0000Iv-Vf for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 23:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDkWm-0003H1-0v for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 23:33:04 -0400 Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:36052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDkWl-0003GR-SN for bug-gnu-emacs@gnu.org; Thu, 16 Jun 2016 23:33:03 -0400 Received: by mail-oi0-x22b.google.com with SMTP id p204so99586902oih.3 for ; Thu, 16 Jun 2016 20:33:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to :content-transfer-encoding; bh=43n3edqgsLUTv6qRtWC2tqCKvGsROWLr8T8S+KNyoS8=; b=vZQRzpUK+m5qpHGudsb715kkuY00swiE5vwywMZgKEiEQYQxGlgsvhdcTdQWofa5dx 7Y5VjTjaRsprm44P/UlYKvXbxbaPaMHjjau/9TCinr6gegwiOMD/A9K+dDcS3f5Q057I vW9DUNPlugem0MCqejDIhRXPNB1yMzobbnub9p4qhxBDMhU6ZpzpqQLpP85kExdxMr/B 6zgXNcDKOJnGyFl9XX3ndF5tN7if21C9t2Fsmes/b4laXjkfIWXyqU76sbbDRsRudby1 ptLb7xbE8ENfxXNjrDWHnZs9hLhjO8BmoxSIKUHq4lczc/LnAh055LP8HyVr213i2LRK Hudw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:content-transfer-encoding; bh=43n3edqgsLUTv6qRtWC2tqCKvGsROWLr8T8S+KNyoS8=; b=VqwHSZpt5uvXWLYSy6p8U7lTp1SXr2PL9rVd/QKG85w93Uy1Hiq9o4tHPooOErUm1o QLcfvqk1jLZBTcIkrXbAghtg/MzY7svFUKnA9j6v7Yna0p8phGsRiMpArjt2lWBOprmg Cn/FdbksIDz5qEKDQH3u41ee+RbUz/OlUCZ9GvTxFeRRRLSr5Eck5LjNuwIMwFfnrlyU l7mV9De+iKaNptXYbmeS64ONyzbZXTrAQFMjJnU7pnpPqEOf2OTqFQrNT2zV7HfDDo8B tJ1SEUjv6qe+MGcE3HI+dZBoEKzMf4y20+c5Syl1FEKmoN0CThqdeDLlPkaUzVh/iM2l ThZA== X-Gm-Message-State: ALyK8tIFdIYgyklmrFK02IAOs1BLIKXI+NYI9lelgqNHUsqgFkQcbBjYEMshn2Max0kgvdkDFiAUMyq3f39uRw== X-Received: by 10.157.1.107 with SMTP id 98mr235619otu.17.1466134383195; Thu, 16 Jun 2016 20:33:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Thu, 16 Jun 2016 20:33:02 -0700 (PDT) From: Noam Postavsky Date: Thu, 16 Jun 2016 23:33:02 -0400 X-Google-Sender-Auth: 7mkQuAQzrtA5rLAO61cMsjRosHk Message-ID: Subject: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Start emacs -Q, evaluate the following lisp code (I wrote the return values after ;=3D>) (defun check-env-var (var) (catch 'ret (dolist (var=3Dval (process-lines "env")) (when (string-prefix-p var var=3Dval) (throw 'ret var=3Dval))))) (check-env-var "SHELL");=3D>"SHELL=3D/bin/bash" (let ((process-environment (copy-sequence process-environment))) (setenv "SHELL" nil) (check-env-var "SHELL"));=3D>nil (let ((process-environment (cons "SHELL" process-environment))) (check-env-var "SHELL"));=3D>"SHELL=3D/bin/bash" (let ((process-environment (cons "SHELL=3D" process-environment))) (check-env-var "SHELL"));=3D>"SHELL=3D" As you can see from the 3rd expression, contrary to its docstring, consing the env variable "SHELL" onto process-environment has no effect at all. process-environment is a variable defined in =E2=80=98C source code=E2=80= =99. Its value is [...] Documentation: List of overridden environment variables for subprocesses to inherit. Each element should be a string of the form ENVVARNAME=3DVALUE. Entries in this list take precedence to those in the frame-local environments. Therefore, let-binding =E2=80=98process-environment=E2=80=99= is an easy way to temporarily change the value of an environment variable, irrespective of where it comes from. To use =E2=80=98process-environment= =E2=80=99 to remove an environment variable, include only its name in the list, without "=3DVALUE". From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 03:11:11 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 07:11:11 +0000 Received: from localhost ([127.0.0.1]:43797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDnvr-000378-1J for submit@debbugs.gnu.org; Fri, 17 Jun 2016 03:11:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDnvp-00036v-HJ for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 03:11:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDnvf-0007TK-EU for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 03:11:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDnvf-0007TC-Au; Fri, 17 Jun 2016 03:10:59 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4164 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDnvd-0007BM-DD; Fri, 17 Jun 2016 03:10:57 -0400 Date: Fri, 17 Jun 2016 10:11:58 +0300 Message-Id: <837fdocmrl.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Thu, 16 Jun 2016 23:33:02 -0400) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Thu, 16 Jun 2016 23:33:02 -0400 > > (check-env-var "SHELL");=>"SHELL=/bin/bash" > (let ((process-environment (copy-sequence process-environment))) > (setenv "SHELL" nil) > (check-env-var "SHELL"));=>nil > (let ((process-environment (cons "SHELL" process-environment))) > (check-env-var "SHELL"));=>"SHELL=/bin/bash" > (let ((process-environment (cons "SHELL=" process-environment))) > (check-env-var "SHELL"));=>"SHELL=" > > As you can see from the 3rd expression, contrary to its docstring, > consing the env variable "SHELL" onto process-environment has no > effect at all. > > process-environment is a variable defined in ‘C source code’. > Its value is > [...] > Documentation: > List of overridden environment variables for subprocesses to inherit. > Each element should be a string of the form ENVVARNAME=VALUE. > > Entries in this list take precedence to those in the frame-local > environments. Therefore, let-binding ‘process-environment’ is an easy > way to temporarily change the value of an environment variable, > irrespective of where it comes from. To use ‘process-environment’ to > remove an environment variable, include only its name in the list, > without "=VALUE". Where does it say that you can use 'cons' or 'push', and only them, to the effect of removing the variable from the environment passed to child processes? process-environment is just a simple list, so these two functions just _add_ another member to the list, they don't remove the old member. My reading of the last sentence you cite is that you must manually remove the old member "SHELL=whatever", and _then_ add a member that has no value. Am I missing something? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 08:17:48 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 12:17:48 +0000 Received: from localhost ([127.0.0.1]:43880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDsia-0003YI-B6 for submit@debbugs.gnu.org; Fri, 17 Jun 2016 08:17:48 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:35948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDsiY-0003Y4-GL for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 08:17:46 -0400 Received: by mail-wm0-f51.google.com with SMTP id f126so86734487wma.1 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 05:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=iBKwTcH9eOZ9tjDOTmyl4LvSEMxw99DEh6CY7W2dg58=; b=FonXSvSZCDIT803mVRxW5NACk8rsIjVpcnp1V0RtnG0/BYAQJ29U6V5eJVVAcmOW0C PRPL1YmW+m5y30RnZGcuzxuaapxWcCEa7xzDZBdnvnAX3/jWQ7l/PL6j+zhh6oXW0lpa e6ZmMm5B0qCq+Rj9hl7DjD2IuTyXuX9YNJCmjVMFV2/7C0QxF/DNAB/D5Djuc8YbwE8j BELGWCns3iQDSDPh1gmVGD13mNGgzXw2wk02i+dN9noacWos/hbtZ5/IJmh6tr5njS9W NHwNgFTI9vMG0+mayTLeHZfJbYr+IdxABGoXLfBwWTPk0Xhx04U9dbrRlLvetJmS3a3t N10g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=iBKwTcH9eOZ9tjDOTmyl4LvSEMxw99DEh6CY7W2dg58=; b=A38eHJuSTT9PVC5/iPTQEBQ8G7wvFRmLJblEtzpZMrdeVSxOiXBViFETviPeEARCYH Xq5ZOAebxAZ+YB5xnZMmGydlgWcrxjPvLDI7kArDtpStx9ys/1s1r/PLhrqZ38usebh9 xD7xeXYCLhDgUWEiOKGuprAGVL0I+vaCQB46X+CZLWe7ULE+yjUV712FAgA9qJpfnOHN JyHbH84aS2AQJr1M+a1G5vho1+1A2Dxoazh8rkU52KTqnJ43C7Agm2xofsmldD6bp7pO 5rdVT2lNDVjG64GxOSAW5hHq11mjgv5wd+QDkiu8O4IEes/Q8rJN75OSZGqHK/bEv8Hh X/wQ== X-Gm-Message-State: ALyK8tLesk6512BtnCCoYC30ONjtyOdTdLdWqsuLpH2jAvSODaYmfBdYjkMK5vlykgWk2g== X-Received: by 10.194.22.169 with SMTP id e9mr2060516wjf.128.1466165860847; Fri, 17 Jun 2016 05:17:40 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id v70sm3376060wmf.18.2016.06.17.05.17.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jun 2016 05:17:40 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii , Noam Postavsky References: <837fdocmrl.fsf@gnu.org> From: Dmitry Gutov Message-ID: <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> Date: Fri, 17 Jun 2016 15:17:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <837fdocmrl.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 10:11 AM, Eli Zaretskii wrote: > Where does it say that you can use 'cons' or 'push', and only them, to > the effect of removing the variable from the environment passed to > child processes? That works with other Emacs features, such as auto-mode-alist. You can also override the values in process-environment using a cons (which strongly suggests the semantics of "first element wins"). Just not "remove" them, currently. > process-environment is just a simple list, so these > two functions just _add_ another member to the list, they don't remove > the old member. What would be the point of ever using the "only its name" form if you have to scrub process-environment of all other mentions of this variable? > My reading of the last sentence you cite is that you must manually > remove the old member "SHELL=whatever", and _then_ add a member that > has no value. If I've removed all mentions of "GIT_DIR" in there, it's already removed, and the subprocesses shouldn't see it. Why add the new member then? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 10:00:49 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:00:49 +0000 Received: from localhost ([127.0.0.1]:44380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuKH-00065S-0V for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuKE-00065C-Vy for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDuK8-0004tz-PI for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:00:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDuK8-0004tm-Gm; Fri, 17 Jun 2016 10:00:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4459 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDuK4-0000ze-K3; Fri, 17 Jun 2016 10:00:39 -0400 Date: Fri, 17 Jun 2016 17:01:23 +0300 Message-Id: <83wplnc3t8.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 15:17:38 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 15:17:38 +0300 > > On 06/17/2016 10:11 AM, Eli Zaretskii wrote: > > > Where does it say that you can use 'cons' or 'push', and only them, to > > the effect of removing the variable from the environment passed to > > child processes? > > That works with other Emacs features, such as auto-mode-alist. There should be code to make it work, it won't work by itself. (auto-mode-alist is different, because it's used entirely in Lisp. By contrast, here we must construct the C-level environment array we pass to child programs so as to remove the variable from it.) > You can also override the values in process-environment using a cons > (which strongly suggests the semantics of "first element wins"). Just > not "remove" them, currently. Looks like this never worked as intended. Does the patch below fix this? diff --git a/src/callproc.c b/src/callproc.c index db602f5..2fb5b1d 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1099,7 +1099,7 @@ add_env (char **env, char **new_env, char *string) char *p = *ep, *q = string; while (ok) { - if (*q != *p) + if (*p && *q != *p) break; if (*q == 0) /* The string is a lone variable name; keep it for now, we From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 10:13:02 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:13:02 +0000 Received: from localhost ([127.0.0.1]:44384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuW6-0006MU-5r for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:13:02 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDuW4-0006M5-8e for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:13:00 -0400 Received: by mail-wm0-f53.google.com with SMTP id f126so90770178wma.1 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 07:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=xycqBuUZHeAMj/7NOerRjwyLKFlM/hU/GQWoQrz/eXQ=; b=ZG4tQeiamQpNMb3RfeR3Jczi4IZb1SUk7ommhtxLd2VvPtTWOrPom4zSkvgZnv9POl 6HAlEo2lSzeCLHB+ifJ3NKByZgkRP/PPwAQr72jU46dZjOvPpyyQrwsKB3FeHL1VRgHF BzO5BAxSgzDwnvGcswPphHN/yxmaFmPQOTb/LZ0ghZlgg05BqRTWQeKdw+RZiSzstwFF b8m38VOS/AD1zUZSuL6avAU6gkqnR2VWZleARS37d8jCB2iTCk/OrBP/YyGQfe2H8Kf2 dVUDw2y9kcp7Twsq9OG4IyQvRnIAoTtjHWYcqiWYf3oLPRQyd0Y4wZHFX+ZVPHEoJsUI XLyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=xycqBuUZHeAMj/7NOerRjwyLKFlM/hU/GQWoQrz/eXQ=; b=de52zvlEB0BbQRVkGkBp4/NBmOGgk3sNGRRG6lHIvawz3kaMe31q+0+NZAN61jBTNB AL83CivOj32A0iC4SX6NbBqCViz1H2FwIIWMaDxARjg4P31NgRr9mMJsvXsezNWm72WX fQx1xeBnH21srYzk9/7gLJlCaMwriRnmpPVrmpDh2bZxXj6rIFR6tF5g+P86MCX8Evur UU/xojdlJO9J2aliZdI01B/gmeHT4GYFI4JYr+BVL1AX8vf3X2ky1bjABKedXQAW4I5O nOMlUFkfCp5bfswRXGZ/1fEoX70EE9qX3J2L5B/NpZt3auX+f0/IxliGdLQBzCrwFnWF QK8A== X-Gm-Message-State: ALyK8tJmbTbkCQbnTSuCAvK8tBTrE2Ha9aPbz1ZA+V+rIBAREW2rawOxitr6FECi05pDig== X-Received: by 10.194.42.69 with SMTP id m5mr2616453wjl.89.1466172774519; Fri, 17 Jun 2016 07:12:54 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id h8sm49002332wjg.9.2016.06.17.07.12.53 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 07:12:53 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Fri, 17 Jun 2016 17:12:52 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83wplnc3t8.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 05:01 PM, Eli Zaretskii wrote: > There should be code to make it work, it won't work by itself. No argument there. > Looks like this never worked as intended. Does the patch below fix > this? Looks like it does. Please push at your convenience. I wonder if we should make setenv work non-destructively now. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 10:19:00 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:19:00 +0000 Received: from localhost ([127.0.0.1]:44388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDubr-0006VN-TB for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:19:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDubn-0006V1-PF for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:18:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDube-00018p-Ke for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:18:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDube-00018h-H7; Fri, 17 Jun 2016 10:18:46 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4473 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDubb-0002pK-FJ; Fri, 17 Jun 2016 10:18:46 -0400 Date: Fri, 17 Jun 2016 17:19:28 +0300 Message-Id: <83vb17c2z3.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov , Paul Eggert , Andreas Schwab In-reply-to: (message from Dmitry Gutov on Fri, 17 Jun 2016 17:12:52 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 17:12:52 +0300 > > On 06/17/2016 05:01 PM, Eli Zaretskii wrote: > > > Looks like this never worked as intended. Does the patch below fix > > this? > > Looks like it does. Please push at your convenience. I'd like the patch to be eyeballed by a few more people. Paul, Andreas, do you see any problems with it? If not, I'd like to push it to the emacs-25 branch. > I wonder if we should make setenv work non-destructively now. Why should we do that? We have initial-environment if we need the original value. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 10:47:59 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 14:47:59 +0000 Received: from localhost ([127.0.0.1]:44397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDv3v-0007FV-Ex for submit@debbugs.gnu.org; Fri, 17 Jun 2016 10:47:59 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDv3u-0007FJ-8a for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 10:47:58 -0400 Received: by mail-wm0-f53.google.com with SMTP id m124so2818202wme.1 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 07:47:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=oHPQHJNprNV/QAGiFdjkl02O3xCL2gSKm0guZtAhCGs=; b=FLHPTkJ3Fndx1apYqFlPJ+jsr9PIL/P+IhG7PCAK8ZzLWNex4KojqyKoRbdOmODpMy 1oiw1C2mYJYRkXWCvlzeAoilYyN32f6W2NBbq9NM3o+1Mpcrkg6b5XpKUYK7iP0oHwUK ZwgwjhK+szeTPHXM6BtoL0Bi4sjO6QK32lWQ2IjaTPf6bNS2qg22c1/XQ3KSmMfxdSXI 4lqfWPpk0RXsDF46CR5lSPx44jEaZ4ZauF46ENoPpfqJgQnYwkbNbPc6kSd/cCZXGT14 kUw9wK3sK6nNPepFyM4d3jWL2YUKZWg9FGuHIJl6/5PGC6EC81QcII2GWlqlf15P664g 4Krg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=oHPQHJNprNV/QAGiFdjkl02O3xCL2gSKm0guZtAhCGs=; b=gliCj1HymilwCcJSTq5leZ3Ctn7gSbSGu2UiihD0Du7CYpowymrCkm7MzQyZ+n7mUS wW/hU3CiET36tD5xRmueb67bGZWb81oUDq+wVP7U3ysavzTjIlgGtK3mqTdb01sqC9Dr vvniK/K2Fojg0rgZOZEx180jwyoKZbwMacn9qdLKb/6hqJAKIwNIR/X+P1VmnZI9x2iv XZ7A5LWJ75V9rOCHawQ4xYkelw6IINGODT1dffePqZxgcuVzcD9tYHANhH95f3KvtBcG JG6F3NF+32Psa/hetyEw0aB3V0alTedOykueWWC+tDfh3/U/WqswiHSctXdIgKeN1yjF FW+Q== X-Gm-Message-State: ALyK8tLxCuNVoU9Yl4cuAhlx/7Q6OYLyAk0sW8FN40wAYFNO3By+DxnmkIV8zjHFMpUSsA== X-Received: by 10.194.216.232 with SMTP id ot8mr2662844wjc.131.1466174872624; Fri, 17 Jun 2016 07:47:52 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id xs9sm46246270wjc.11.2016.06.17.07.47.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 07:47:51 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii , Paul Eggert , Andreas Schwab References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> From: Dmitry Gutov Message-ID: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> Date: Fri, 17 Jun 2016 17:47:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83vb17c2z3.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 05:19 PM, Eli Zaretskii wrote: >> I wonder if we should make setenv work non-destructively now. > > Why should we do that? We have initial-environment if we need the > original value. Normally, we only want to change the environment for the duration of a command. So, what are the downsides? One the plus side: - setenv-internal will become simpler. - We won't have to cons manually anymore. The code will become a bit nicer, like: diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index f35c84d..5315e0a 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1450,7 +1450,8 @@ vc-git--call (or coding-system-for-read vc-git-log-output-coding-system)) (coding-system-for-write (or coding-system-for-write vc-git-commits-coding-system)) - (process-environment (cons "PAGER=" process-environment))) + (process-environment process-environment)) + (setenv "PAGER") (apply 'process-file vc-git-program nil buffer nil command args))) (defun vc-git--out-ok (command &rest args) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 12:52:43 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 16:52:43 +0000 Received: from localhost ([127.0.0.1]:44443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDx0d-0001po-92 for submit@debbugs.gnu.org; Fri, 17 Jun 2016 12:52:43 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:39736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDx0b-0001pg-Jv for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 12:52:42 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3rWRBc0tNdz3hjQQ; Fri, 17 Jun 2016 18:52:39 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3rWRBb4BDnzvhMQ; Fri, 17 Jun 2016 18:52:39 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id xv4Vgh1RUcPH; Fri, 17 Jun 2016 18:52:37 +0200 (CEST) X-Auth-Info: 9MvKY6bGNHdd19bBfVoHMOsR2tLswSEc1SS+8YrHK2UdwZAlOTENzGkeBMrDWyQ0 Received: from igel.home (ppp-88-217-3-98.dynamic.mnet-online.de [88.217.3.98]) by mail.mnet-online.de (Postfix) with ESMTPA; Fri, 17 Jun 2016 18:52:37 +0200 (CEST) Received: by igel.home (Postfix, from userid 1000) id 31CA22C3440; Fri, 17 Jun 2016 18:52:37 +0200 (CEST) From: Andreas Schwab To: Dmitry Gutov Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> X-Yow: We just joined the civil hair patrol! Date: Fri, 17 Jun 2016 18:52:37 +0200 In-Reply-To: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> (Dmitry Gutov's message of "Fri, 17 Jun 2016 17:47:49 +0300") Message-ID: <87porfahbe.fsf@linux-m68k.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, Eli Zaretskii , Paul Eggert , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Dmitry Gutov writes: > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index f35c84d..5315e0a 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1450,7 +1450,8 @@ vc-git--call > (or coding-system-for-read vc-git-log-output-coding-system)) > (coding-system-for-write > (or coding-system-for-write vc-git-commits-coding-system)) > - (process-environment (cons "PAGER=" process-environment))) > + (process-environment process-environment)) > + (setenv "PAGER") > (apply 'process-file vc-git-program nil buffer nil command args))) Is that in any way different from git --no-pager? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 12:55:11 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 16:55:12 +0000 Received: from localhost ([127.0.0.1]:44447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDx31-0001tU-N2 for submit@debbugs.gnu.org; Fri, 17 Jun 2016 12:55:11 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:35459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDx30-0001tI-Av for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 12:55:10 -0400 Received: by mail-wm0-f45.google.com with SMTP id v199so5400583wmv.0 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 09:55:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=bxYei+0KLdaHQ7MQ87WE572yYAKvHwHUwglFqmmEzqo=; b=RI5ci5FZTAL0sBqJcrkgzWkg/ouI6IeaIDYZkoBhT6RBnMAQvLY7/twsvbsO2+oUcY w1fpQVFmbuKrr8Ro4t2qErI19DgdxUjeIvYojg4c1e7FmS8OyJJ0ZFjJ9Z7HKACemAQ+ aqgej00m02Q/su5QcSRuBhR3q4fkTorGZleMpBkb3H7FgdFxtF/kJuRwqri9cDyPCo5G DIwNFGR/0Tn6xc8GVZx938dIpTC32xoYx88UP/Wfkp2U3X7QLGhXCWlRNVoj/AQQccAg ZPDbFMLSX7mFSlT6V4QGzuNdrW8nb1OqdAtI704xvsJ70rZg/Zks/JNeMm7jWpe3csTC KxrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=bxYei+0KLdaHQ7MQ87WE572yYAKvHwHUwglFqmmEzqo=; b=YuKn6M7zW8xinJbug0EeNHqxKrfE4d6ozkme8M0qL3/KrjZd77ZtyeZOzlmM4nuMtQ O3SnaavVWziO2o/cno/XpiptXj+Vvppx0iRDjI5AR47pXzUeeDImYbzKSXl1SI9Nb0s8 QZK4eLxo52i2yEVqqJqGKA4IVO4si40bLfZuZrk1Qq8oYy1Do/x89H/noL/HxU1vtjDM E9q/AyRVkUCE7qAtq8hUvHGJMv5tWr4bz0m+poeMGRae1TKcka17afp/cgeVnC2w9Ui2 OvqYyGXW5w3464/P4oVbuaf4IEYys7onkqOhSDZIdGwUFUvCXLWiCGGhKQnNetFNqI4j xoeQ== X-Gm-Message-State: ALyK8tILxl2cQIMVMTJ//Zo9iqeh3ZKDX8cTxw5UKkiyxN26WjuVLR88UQDLcnASPG63KQ== X-Received: by 10.194.133.135 with SMTP id pc7mr3296215wjb.49.1466182504504; Fri, 17 Jun 2016 09:55:04 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id x124sm464534wmg.24.2016.06.17.09.55.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 09:55:03 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Andreas Schwab References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> <87porfahbe.fsf@linux-m68k.org> From: Dmitry Gutov Message-ID: <4ce48f30-60d7-f332-04a3-4c2bba43cf9e@yandex.ru> Date: Fri, 17 Jun 2016 19:55:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <87porfahbe.fsf@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, Eli Zaretskii , Paul Eggert , npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 07:52 PM, Andreas Schwab wrote: > Dmitry Gutov writes: >> (or coding-system-for-read vc-git-log-output-coding-system)) >> (coding-system-for-write >> (or coding-system-for-write vc-git-commits-coding-system)) >> - (process-environment (cons "PAGER=" process-environment))) >> + (process-environment process-environment)) >> + (setenv "PAGER") >> (apply 'process-file vc-git-program nil buffer nil command args))) > > Is that in any way different from git --no-pager? The effect is likely the same. But that is beside the point: the example is not about PAGER but about setenv. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 13:05:40 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 17:05:41 +0000 Received: from localhost ([127.0.0.1]:44452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxDA-00028q-NJ for submit@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDxD8-00028c-C5 for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bDxCy-0001M6-JB for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 13:05:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41034) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bDxCy-0001Lk-Fh; Fri, 17 Jun 2016 13:05:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4548 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bDxCw-0006jr-FL; Fri, 17 Jun 2016 13:05:26 -0400 Date: Fri, 17 Jun 2016 20:06:28 +0300 Message-Id: <83twgrbv8r.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 17:47:49 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, eggert@cs.ucla.edu, schwab@linux-m68k.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 17:47:49 +0300 > > On 06/17/2016 05:19 PM, Eli Zaretskii wrote: > > >> I wonder if we should make setenv work non-destructively now. > > > > Why should we do that? We have initial-environment if we need the > > original value. > > Normally, we only want to change the environment for the duration of a > command. Now that 'push' works, why do we need setenv for that? > So, what are the downsides? That there's no way of changing the environment permanently? > - We won't have to cons manually anymore. The code will become a bit > nicer, like: > > diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el > index f35c84d..5315e0a 100644 > --- a/lisp/vc/vc-git.el > +++ b/lisp/vc/vc-git.el > @@ -1450,7 +1450,8 @@ vc-git--call > (or coding-system-for-read vc-git-log-output-coding-system)) > (coding-system-for-write > (or coding-system-for-write vc-git-commits-coding-system)) > - (process-environment (cons "PAGER=" process-environment))) > + (process-environment process-environment)) > + (setenv "PAGER") I'm not sure I see why that is nicer. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 15:01:29 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 19:01:29 +0000 Received: from localhost ([127.0.0.1]:44508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDz1F-0004vE-9M for submit@debbugs.gnu.org; Fri, 17 Jun 2016 15:01:29 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDz1D-0004uz-IF for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 15:01:27 -0400 Received: by mail-wm0-f53.google.com with SMTP id v199so562083wmv.0 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 12:01:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=nGFcL7bjvP4xjwgsma8/15dhXK4PuRbi4n/Im4tj2WY=; b=udGNYdPMsKhOKkEbhm5Y2MsyFPdKEu7aBzRTIPQalhlVJpmtSceP/DoYWjSLdq6uK8 E+hXc+5HxpyL8OZm3FIZm/K7RmWst/UnQYmTO6ASXwdnmrmEnfVBvQwvCkcH1+uMqQIE abmi1ICJwnRHVDaEzbPqV/Mvt/QkQ01CGzI2SBt3h1e18RcjVa7Uu8/TyH8I+RbuAY7g kEuhGVM/cBZ9EAH/I7S4RJVSUV0u1l8f4jd4xnosaBd1lXqcHZqdrMDfmHzEslA/hfHK uiQNtEEcih89lhnY2C/ftyQsxHFDELDyLcNVqYoL6HEhW8a3Pn4GOYyKB9zjeJelKN85 SChg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nGFcL7bjvP4xjwgsma8/15dhXK4PuRbi4n/Im4tj2WY=; b=QA5cyB5IFPNAKBfrXw0a6mHF7stt4n3o4Wy8UAbCHsNDoPbuvnVVnoDy2cNin+iEQX rjHcp8srtOY1XLSsiDRhGnDyFf9FK12lCzSh1So6Jg/8Ba5Bdcb1kJz7OB+OHek7TQcK WAUj9UF7gn4J/ONeAeE2GA6XXgDynvxAJtVhQyPNtf0ABgrljrarpqXtJOctnpK5q8Lp u4gwlSeBtRZxuE+kncHI952XPqK5aRRPfumUzxwztoxnXhishOeBHL6mjfmSkgw3uz+Q DacSYpJZEVmEcHrxdqHilbMPx+yj626AX9EZ7zaR2Ah1ndXmSItjkdLhAXbkUFMkUU9y asrQ== X-Gm-Message-State: ALyK8tKQOLst7X9Hw3GDC5SzyJVWHO4sqizW42WASQN5OCqWEeStmuk4We8tSNMb430Iww== X-Received: by 10.28.21.140 with SMTP id 134mr70116wmv.50.1466190081839; Fri, 17 Jun 2016 12:01:21 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id b77sm164990wme.0.2016.06.17.12.01.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jun 2016 12:01:20 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> <83twgrbv8r.fsf@gnu.org> From: Dmitry Gutov Message-ID: <54d442d1-0053-6966-9cd6-9540448eb31f@yandex.ru> Date: Fri, 17 Jun 2016 22:01:19 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83twgrbv8r.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, eggert@cs.ucla.edu, schwab@linux-m68k.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 08:06 PM, Eli Zaretskii wrote: > Now that 'push' works, why do we need setenv for that? So that the user doesn't have to (push "VAR=value"), or (push "VAR="), or know the difference between the latter and (push "VAR"). setenv is a better abstraction. In fact, if you use it, you don't even have to know the format of process-environment. >> So, what are the downsides? > > That there's no way of changing the environment permanently? The environment is changes as a result. It just doesn't modify the original list, and, as such, contains duplicate values for the changed variables. > I'm not sure I see why that is nicer. Do you know what value "PAGER=" assigns to the variable PAGER? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 16:09:49 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 20:09:50 +0000 Received: from localhost ([127.0.0.1]:44525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE05K-0006Y5-8v for submit@debbugs.gnu.org; Fri, 17 Jun 2016 16:09:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE05J-0006Xq-0D for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 16:09:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bE059-0001PV-Vp for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 16:09:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bE059-0001PR-Sh; Fri, 17 Jun 2016 16:09:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4652 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bE059-0005xA-0T; Fri, 17 Jun 2016 16:09:35 -0400 Date: Fri, 17 Jun 2016 23:10:37 +0300 Message-Id: <83mvmjbmpu.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <54d442d1-0053-6966-9cd6-9540448eb31f@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jun 2016 22:01:19 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> <83twgrbv8r.fsf@gnu.org> <54d442d1-0053-6966-9cd6-9540448eb31f@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, eggert@cs.ucla.edu, schwab@linux-m68k.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: eggert@cs.ucla.edu, schwab@linux-m68k.org, > npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Dmitry Gutov > Date: Fri, 17 Jun 2016 22:01:19 +0300 > > On 06/17/2016 08:06 PM, Eli Zaretskii wrote: > > > Now that 'push' works, why do we need setenv for that? > > So that the user doesn't have to (push "VAR=value"), or (push "VAR="), > or know the difference between the latter and (push "VAR"). > > setenv is a better abstraction. In fact, if you use it, you don't even > have to know the format of process-environment. We will have to agree to disagree on this one. > >> So, what are the downsides? > > > > That there's no way of changing the environment permanently? > > The environment is changes as a result. It just doesn't modify the > original list, and, as such, contains duplicate values for the changed > variables. What do I do if I do want to change the original one? > > I'm not sure I see why that is nicer. > > Do you know what value "PAGER=" assigns to the variable PAGER? Not sure what that means, or why do you ask that. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 17:26:39 2016 Received: (at 23779) by debbugs.gnu.org; 17 Jun 2016 21:26:39 +0000 Received: from localhost ([127.0.0.1]:44556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE1Hi-0008T2-RO for submit@debbugs.gnu.org; Fri, 17 Jun 2016 17:26:39 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE1Hh-0008So-KA for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 17:26:37 -0400 Received: by mail-wm0-f68.google.com with SMTP id m124so717392wme.3 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 14:26:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=58r2/zkZT0Ra6O9buSrWcxiG1CCOplCMhdXGLeV9L2k=; b=a2xcVWMf7ZRVyYecx4FwSI7qSZ6wo54ZbhCRFneo/JtPBpOCoHdOsEb9z7vqik1VEf FokLEUB9mkiQZa6dI+QwIWyy/Tvfro317ZmiYnzdOhhkshfgDO+mYp1wsFaw5q3bRH89 bI91vG8EMY/odis5XRWOfoGO41dDeJc8qPAeeMBaUmZXHlqwYDZQt+xFdOdrpp2rll/P i74Ow9P/1dMUFf2K7HkRX3s4WgAmXdGkFgNqA9i5TnjnvkACEGA0fg8IwNB7gnVNQqry QOV53QjbR0xLOq7OkUZS1SLHoVZKv5WFI9rz5KkJ8n/gv5psIuLADMomMy4muXsnVvTv SJEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=58r2/zkZT0Ra6O9buSrWcxiG1CCOplCMhdXGLeV9L2k=; b=adGFyi3+plqaJmLYNX8txR9ty9MdABsW2brN1m+SeZc1aRW/qJmr2lbPeNx+kM5stz tU1+Z69+absiDeTp86UNHJuncE1Qr8esERYli5i+9FtYMOgBpuNOXKsUMZXlcqzvRbxN He9miMdCUodH47k/wkQeyW8pAvyc5JdrYFTuqjvorqnepLFwAhPS0kYMQvJqRKuzG3Vz V4t1m6y+tbInN/V2Hve1/JTqXCJeV8XumTsvJ1sYn+rSsrZuyI/4VA97SiZHSNixYjyX bS0gn3GOH2bPbEidj6Qev3wtZVNQdremV7DmejuY0imgXA7t6tXQRSCX9OFBZQXUhyUC 9lkg== X-Gm-Message-State: ALyK8tI05TM/CI/AnxeHKo0e+axBfWCKKf3bb/tReaAgRrGMZWkacuZsbINJGB5srzDGQQ== X-Received: by 10.28.158.132 with SMTP id h126mr405914wme.43.1466198792097; Fri, 17 Jun 2016 14:26:32 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id li10sm6080111wjb.5.2016.06.17.14.26.29 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 14:26:30 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> <83twgrbv8r.fsf@gnu.org> <54d442d1-0053-6966-9cd6-9540448eb31f@yandex.ru> <83mvmjbmpu.fsf@gnu.org> From: Dmitry Gutov Message-ID: <0b5653ce-1d70-4d5c-2c28-ee8cba1f9f1c@yandex.ru> Date: Sat, 18 Jun 2016 00:26:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83mvmjbmpu.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: eggert@cs.ucla.edu, 23779@debbugs.gnu.org, schwab@linux-m68k.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/17/2016 11:10 PM, Eli Zaretskii wrote: > What do I do if I do want to change the original one? That's what I was asking: are there scenarios where someone would want to do that? If they're very exceptional, if might be fine if the caller has to manipulate the process-environment list on a lower level themselves. > Not sure what that means, or why do you ask that. Do you know which value (setq process-environment (cons "PAGER=" ...)) assigns to the environment variable PAGER? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 21:36:21 2016 Received: (at 23779) by debbugs.gnu.org; 18 Jun 2016 01:36:21 +0000 Received: from localhost ([127.0.0.1]:44631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE5BN-0007UH-8p for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:36:21 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:35190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE5BL-0007U4-F4 for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 21:36:19 -0400 Received: by mail-oi0-f43.google.com with SMTP id v7so30012399oig.2 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 18:36:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/Mwc+pXjw4NTMqGDF23WfDisAcbN874sh4iuy18Wd/g=; b=ztvBwp/ab9DzpkpJVzd3gxoW3rCSzT8foI/sgmXvvRuzZxr9nxWJaQe9YIsCoHX99c qskULMHF974QRXqkRtOUFEYDUru7onMorTItVfVOMb8/DfJ2CrJpoKVVO/clmdQwKb6g 0RXNzLWhKpDboJouJ7f/WtX8LHl4rlrm/364nl1Dw3a/S3PZcL3nB3BlJsewqh1KL2Bw ckDYaWuxnpiaIVRuvNKyhjTzi26aav8VEk1StJ6/jVougfAQIFxHTKVwPVui5YwJXTy0 iaCi+Jss3AbfC746+7VRmQxdJjURZ1yREAniPxz1zbg9+t+mFMF9BwyHmOaFL5krf2Ea Ubyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/Mwc+pXjw4NTMqGDF23WfDisAcbN874sh4iuy18Wd/g=; b=N0pcssjY/e3Xyfp7xYxSWeQ3RDJh39hCOjZjc5CzwaJhuqMGNn2MuS50d2Ujc449Sv Mke+23hIl85vHLigxqARoyjLzuNfcDN6tBxc+QbWoFue/P8zkYV1wdP/ysNLW6yjZI8K Qzi0mEvQlwiAR7uwi+SdOsA3hsQbZtNGVjTsbWOyL3A9H0QA7usZmONmBbthJFcvhGrG R1dPLGEhQL331uvc05UMlkxkdUDk/ohevWnJzN5QAQdPclu2q4nZ97Dy1T9hyI15HrdS lm0WvqkmZ5SEqLO57yD3UKzyRJdOReHVM4UJUj9HoODwrsjMClxGnWGdcWI7+jCj+xCn iGmA== X-Gm-Message-State: ALyK8tIBqzy0+OqpGxl+cucRjF+G2K+P2KKjiswgOivpayGv+jMqVNO03pB5zxKza8LMwcd8A9eVKFK7p8yTaQ== X-Received: by 10.202.195.70 with SMTP id t67mr2707068oif.88.1466213773876; Fri, 17 Jun 2016 18:36:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Fri, 17 Jun 2016 18:36:12 -0700 (PDT) In-Reply-To: <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> From: Noam Postavsky Date: Fri, 17 Jun 2016 21:36:12 -0400 X-Google-Sender-Auth: 6ywXrj7yDOg0qNskA_hvm2HFsB0 Message-ID: Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Dmitry Gutov Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, Eli Zaretskii , Paul Eggert , Andreas Schwab X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, Jun 17, 2016 at 10:47 AM, Dmitry Gutov wrote: > On 06/17/2016 05:19 PM, Eli Zaretskii wrote: > >>> I wonder if we should make setenv work non-destructively now. >> >> >> Why should we do that? We have initial-environment if we need the >> original value. > > > Normally, we only want to change the environment for the duration of a > command. So, what are the downsides? process-environment could grow without bound. Only a serious problem if some code calls setenv many times without let-binding process-environment which is probably a mistake, but still there could be code like that. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 21:44:50 2016 Received: (at 23779) by debbugs.gnu.org; 18 Jun 2016 01:44:50 +0000 Received: from localhost ([127.0.0.1]:44643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE5Ja-0007go-3N for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:44:50 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:36254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE5JX-0007ga-U3 for 23779@debbugs.gnu.org; Fri, 17 Jun 2016 21:44:48 -0400 Received: by mail-wm0-f49.google.com with SMTP id f126so7962269wma.1 for <23779@debbugs.gnu.org>; Fri, 17 Jun 2016 18:44:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=VuI9+Bet8Cd66BOBbsqhMhZ1lAy+dN0Rmfptp8XOPtE=; b=NMdJBEN/R/GnmHe8uKJjIF5zNAzHFkKtoG93zUbTEoeioYzYHnE1OK26+FiEAoGS1H DrUFyx35hatxAAL3hJ0e74eZKbFMEsup4bdcVJ5n578YGcHNYoZL4J/5TcMV+vXOwIUL ETPWsD7wXGKUd8AIuNVo7hdldKhlGz3jtm/gBiCzxaIz67OsB6oHIm118YGswBm4cJFf HH1pcjsYEeRioVLF5Ok1xy0pWig1Bm6Q3V6oAjIKXiwmvpHBStszmi1/3DLTpYlGRaqH LCWBZZAroMQnBCOrzq7I4tTIWGvTh9xaWnwBuPh0VFxJYWlxD7+oZUDaqqbup7zPXEG4 1nRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=VuI9+Bet8Cd66BOBbsqhMhZ1lAy+dN0Rmfptp8XOPtE=; b=D1tqHZXucmBNF1FdIry1F9joO4eliS9Sy+PS0aSyYFHLvOSjkCMmoRbXPqu2HYdrFY jTeqblOxd6vNHoEdf9df70L7xgvXbNokEbvHm3fnGGD3qM4WwhWTDGmx32Jl4C5nRb0c QYlwXWCjV18vY9fA+DLHRPjsWwpM52vou0SL5MyFsGXt1Q3ZHs7bg6iErEwhkXDFguza ytFEvvcHmSdmuM3RSRotAn9FBHHpA3j60n5FApa88LtlAH3dRAxiscvwqeXhOFmDrrnC 7V7C/4kaPefIKb2HxVAuuepsdV9QnquqTpWzh24Kd6mq+keAYsPFUDk16CCNsVW62Eqm RV9A== X-Gm-Message-State: ALyK8tLfcQV0y5vxaswlslGLDq9j2SKyadts/PKIKZ2hnz7KDl7tiYeQ7pGMijOMA2fm3Q== X-Received: by 10.28.66.148 with SMTP id k20mr1115639wmi.55.1466214282009; Fri, 17 Jun 2016 18:44:42 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id g4sm31049085wju.30.2016.06.17.18.44.40 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 17 Jun 2016 18:44:41 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Noam Postavsky References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> From: Dmitry Gutov Message-ID: <025581a8-21c5-4c64-73a1-9d967df5c036@yandex.ru> Date: Sat, 18 Jun 2016 04:44:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, Andreas Schwab , Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/18/2016 04:36 AM, Noam Postavsky wrote: > process-environment could grow without bound. Only a serious problem > if some code calls setenv many times without let-binding > process-environment which is probably a mistake, but still there could > be code like that. Yes, it's easy to see an artificial scenario leading to that. But is it at all probable to see one in practice? Well, anyway, I believe I've made my case about setenv. It would be nice, but far less important than getting Eli's patch in. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 03:51:14 2016 Received: (at 23779) by debbugs.gnu.org; 18 Jun 2016 07:51:14 +0000 Received: from localhost ([127.0.0.1]:44693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEB27-0007nG-6a for submit@debbugs.gnu.org; Sat, 18 Jun 2016 03:51:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEB26-0007n4-66 for 23779@debbugs.gnu.org; Sat, 18 Jun 2016 03:51:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEB1z-0003gk-Nj for 23779@debbugs.gnu.org; Sat, 18 Jun 2016 03:51:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEB1s-0003fo-DV; Sat, 18 Jun 2016 03:50:56 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1049 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEB1q-0006dq-CU; Sat, 18 Jun 2016 03:50:54 -0400 Date: Sat, 18 Jun 2016 10:51:57 +0300 Message-Id: <83fusbaq8y.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <0b5653ce-1d70-4d5c-2c28-ee8cba1f9f1c@yandex.ru> (message from Dmitry Gutov on Sat, 18 Jun 2016 00:26:28 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <91dddf53-b680-5568-cc9e-3f54859c8049@yandex.ru> <83twgrbv8r.fsf@gnu.org> <54d442d1-0053-6966-9cd6-9540448eb31f@yandex.ru> <83mvmjbmpu.fsf@gnu.org> <0b5653ce-1d70-4d5c-2c28-ee8cba1f9f1c@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: eggert@cs.ucla.edu, 23779@debbugs.gnu.org, schwab@linux-m68k.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org, > schwab@linux-m68k.org, eggert@cs.ucla.edu > From: Dmitry Gutov > Date: Sat, 18 Jun 2016 00:26:28 +0300 > > On 06/17/2016 11:10 PM, Eli Zaretskii wrote: > > > What do I do if I do want to change the original one? > > That's what I was asking: are there scenarios where someone would want > to do that? If they're very exceptional, if might be fine if the caller > has to manipulate the process-environment list on a lower level themselves. I don't think we have good means of finding that out. In general, a use case that was possible (and for many years at that) should remain possible, unless there's clear and hard evidence that it's no longer valid, something I very much doubt we have in this case. > > Not sure what that means, or why do you ask that. > > Do you know which value > > (setq process-environment (cons "PAGER=" ...)) > > assigns to the environment variable PAGER? An empty value, AFAIK. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 22:27:45 2016 Received: (at 23779) by debbugs.gnu.org; 19 Jun 2016 02:27:45 +0000 Received: from localhost ([127.0.0.1]:45523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bESSe-0007ZC-Sg for submit@debbugs.gnu.org; Sat, 18 Jun 2016 22:27:45 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bESSd-0007Yz-OJ for 23779@debbugs.gnu.org; Sat, 18 Jun 2016 22:27:44 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D8DDC1613EA; Sat, 18 Jun 2016 19:27:37 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id W8InnmR-iExU; Sat, 18 Jun 2016 19:27:36 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CA6DD1613C6; Sat, 18 Jun 2016 19:27:36 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SwyxukDcubjr; Sat, 18 Jun 2016 19:27:36 -0700 (PDT) Received: from [192.168.1.2] (host156-229-dynamic.37-79-r.retail.telecomitalia.it [79.37.229.156]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 71AD91613EA; Sat, 18 Jun 2016 19:27:35 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii , Dmitry Gutov , Andreas Schwab References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> From: Paul Eggert Message-ID: <57660314.9050907@cs.ucla.edu> Date: Sun, 19 Jun 2016 04:27:32 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <83vb17c2z3.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------070303010503000600090905" X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format. --------------070303010503000600090905 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 06/17/2016 04:19 PM, Eli Zaretskii wrote: >> Looks like it does. Please push at your convenience. > I'd like the patch to be eyeballed by a few more people. Paul, > Andreas, do you see any problems with it? If not, I'd like to push it > to the emacs-25 branch The patch is correct. The code is tricky so I'm not surprised you wanted another pair of eyes. The attached patch is a very minor tweak of your patch that made it a bit easier for me to follow. I resisted the temptation of cleaning up the surrounding code to make it more readable. I like the idea of putting this into the emacs-25 branch. (Or your patch; doesn't really matter.) --------------070303010503000600090905 Content-Type: text/x-patch; name="0001-Consing-V-into-process-environment-should-remove-V.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Consing-V-into-process-environment-should-remove-V.patc"; filename*1="h" >From ed5dabd6bb61613649f619f6f210d070812895d7 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 19 Jun 2016 03:58:37 +0200 Subject: [PATCH] Consing "V" into process-environment should remove V Problem reported by Noam Postavsky (Bug#23779). * src/callproc.c (add_env): Consider new string "FOO=BAR" to match plain "FOO" in the old proto-environment. This is a slight tweak of the fix suggested by Eli Zaretskii in http://bugs.gnu.org/23779#14 --- src/callproc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/callproc.c b/src/callproc.c index db602f5..38f3f92 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1099,7 +1099,7 @@ add_env (char **env, char **new_env, char *string) char *p = *ep, *q = string; while (ok) { - if (*q != *p) + if (*q != *p && *p) break; if (*q == 0) /* The string is a lone variable name; keep it for now, we -- 2.5.5 --------------070303010503000600090905-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 11:00:20 2016 Received: (at 23779) by debbugs.gnu.org; 19 Jun 2016 15:00:20 +0000 Received: from localhost ([127.0.0.1]:46556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEeCx-0001oJ-Pa for submit@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEeCx-0001o8-7g for 23779@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEeCo-0001vH-Pt for 23779@debbugs.gnu.org; Sun, 19 Jun 2016 11:00:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53708) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEeCo-0001uT-MZ; Sun, 19 Jun 2016 11:00:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2581 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEeCl-000553-OM; Sun, 19 Jun 2016 11:00:08 -0400 Date: Sun, 19 Jun 2016 18:01:13 +0300 Message-Id: <831t3t9q9y.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <57660314.9050907@cs.ucla.edu> (message from Paul Eggert on Sun, 19 Jun 2016 04:27:32 +0200) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net, schwab@linux-m68k.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: npostavs@users.sourceforge.net, 23779@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 19 Jun 2016 04:27:32 +0200 > > On 06/17/2016 04:19 PM, Eli Zaretskii wrote: > >> Looks like it does. Please push at your convenience. > > I'd like the patch to be eyeballed by a few more people. Paul, > > Andreas, do you see any problems with it? If not, I'd like to push it > > to the emacs-25 branch > The patch is correct. Thanks for the review. I will push the patch soon to emacs-25. > The code is tricky so I'm not surprised you wanted another pair of > eyes. Indeed. > The attached patch is a very minor tweak of your > patch that made it a bit easier for me to follow. I think I will go with my version, mainly because it will most probably be short-lived, and so is not worth optimizing. > I resisted the temptation of cleaning up the surrounding code to > make it more readable. Feel free to do that on master; I can mark the emacs-25 fix "not to be merged". From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 18:53:34 2016 Received: (at 23779) by debbugs.gnu.org; 19 Jun 2016 22:53:34 +0000 Received: from localhost ([127.0.0.1]:46776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bElaw-0007vE-Ip for submit@debbugs.gnu.org; Sun, 19 Jun 2016 18:53:34 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bElav-0007uy-2N for 23779@debbugs.gnu.org; Sun, 19 Jun 2016 18:53:33 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4EEC41613A7; Sun, 19 Jun 2016 15:53:26 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id iP7U8Memh5vW; Sun, 19 Jun 2016 15:53:25 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9B8961613C3; Sun, 19 Jun 2016 15:53:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 5SGc7jdKNwbT; Sun, 19 Jun 2016 15:53:25 -0700 (PDT) Received: from [192.168.1.2] (host100-211-dynamic.27-79-r.retail.telecomitalia.it [79.27.211.100]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0D1A81613A7; Sun, 19 Jun 2016 15:53:23 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> From: Paul Eggert Message-ID: <57672261.8090702@cs.ucla.edu> Date: Mon, 20 Jun 2016 00:53:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <831t3t9q9y.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net, schwab@linux-m68k.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On 06/19/2016 05:01 PM, Eli Zaretskii wrote: >> >I resisted the temptation of cleaning up the surrounding code to >> >make it more readable. > Feel free to do that on master; I can mark the emacs-25 fix "not to be > merged". Please don't bother. I'll merge emacs-25 to master before fiddling with this stuff on master, if I ever get around to fiddling. That's my usual practice for this sort of thing. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 10:22:11 2016 Received: (at 23779-done) by debbugs.gnu.org; 20 Jun 2016 14:22:11 +0000 Received: from localhost ([127.0.0.1]:47799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF05Y-0005vl-6J for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:22:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33119) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF05X-0005vO-8D for 23779-done@debbugs.gnu.org; Mon, 20 Jun 2016 10:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF05O-0001mz-UG for 23779-done@debbugs.gnu.org; Mon, 20 Jun 2016 10:22:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF05O-0001mn-RE; Mon, 20 Jun 2016 10:21:58 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF05M-0007ks-Ri; Mon, 20 Jun 2016 10:21:57 -0400 Date: Mon, 20 Jun 2016 17:21:03 +0300 Message-Id: <83fus87xgw.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <57672261.8090702@cs.ucla.edu> (message from Paul Eggert on Mon, 20 Jun 2016 00:53:21 +0200) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779-done Cc: npostavs@users.sourceforge.net, schwab@linux-m68k.org, 23779-done@debbugs.gnu.org, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: dgutov@yandex.ru, schwab@linux-m68k.org, npostavs@users.sourceforge.net, > 23779@debbugs.gnu.org > From: Paul Eggert > Date: Mon, 20 Jun 2016 00:53:21 +0200 > > On 06/19/2016 05:01 PM, Eli Zaretskii wrote: > >> >I resisted the temptation of cleaning up the surrounding code to > >> >make it more readable. > > Feel free to do that on master; I can mark the emacs-25 fix "not to be > > merged". > > Please don't bother. OK, thanks. Pushed as 5f37572 on the emacs-25 branch, and closing. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 09:53:50 2016 Received: (at 23779) by debbugs.gnu.org; 21 Jun 2016 13:53:50 +0000 Received: from localhost ([127.0.0.1]:48840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM7i-0004Bi-20 for submit@debbugs.gnu.org; Tue, 21 Jun 2016 09:53:50 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:34926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM7g-0004BW-HJ for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 09:53:48 -0400 Received: by mail-lb0-f179.google.com with SMTP id o4so11394156lbp.2 for <23779@debbugs.gnu.org>; Tue, 21 Jun 2016 06:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=MvygJkdrCUBjci42isgGyY1tzjo2CNXnz7kKqvjdLM8=; b=rKMMfSyB1qaSbqgsK3JsKu3/ZvdlpKgjxJZeCFWdL9DEmV/I/A5hA69qRz8W2kBzmW NBxRK0qcsL1MrAKqpmuyLQnYw3Za6MEsOB4vrud6J9r1a6Up0lJ7TVujmsg8VB5pHR1P axKA7etcTDmmB2q3VbV7PA4HO+gBneU7wgdZwDRLBqj2vgya8baISc/4u1FK0qw0UgnR 3kMws3dKhi0+TQiJBUl50kOH02KF74t1NpISNQ8YVJO71y9/jMpa2IpJdq190LVx198+ 9neLXnQpWRGJDsA82C9nPy8gt9XaLNKNzM3+juQYc3fR39tfkeZc30Xb2rdayh7AmKHL mQpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=MvygJkdrCUBjci42isgGyY1tzjo2CNXnz7kKqvjdLM8=; b=DiyKPm83cVfFMP3vqGBR/E741Wx2FsgoxRqNyKVKz0ubwDtVWl/UbBNvkewsfgv6nj UOXGl4NrSZ29bVS/kVOB1Hf5QYT+5mKU+ufML4m3nUAa5nvSVY95TXSHVtu7l3gyDlJh ykdQaO7a9uUFAZ5JCVRbFeyvmxHERTL7FPDu6MfU6MhQUVCb2b6LyRCfQ3AzVPAbA7Mi /2slg/1RKoFfnJr3tepvqIS1IFmphklkUxzfERecdJwUQ2+13jjWaYJfSaMqfO980wYc NoBsMkJWS/wMV23nWCg+jSzy+Bomgm1ardrCYdWiBIcRdqiOYntaGfcF+gSIA3nBUlz4 fMfg== X-Gm-Message-State: ALyK8tJG6KT9Z0g0h4sC/GcBREC219snz7p7wFNtp+9mrC67FQzXHmbCG/1vHoy3TMlqLQ== X-Received: by 10.194.65.5 with SMTP id t5mr6491378wjs.35.1466517222711; Tue, 21 Jun 2016 06:53:42 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id v200sm3131296wmv.4.2016.06.21.06.53.41 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 06:53:42 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: 23779@debbugs.gnu.org, eliz@gnu.org, npostavs@users.sourceforge.net References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> <83fus87xgw.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Tue, 21 Jun 2016 16:53:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83fus87xgw.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23779 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/20/2016 05:21 PM, Eli Zaretskii wrote: > OK, thanks. Pushed as 5f37572 on the emacs-25 branch, and closing. Can we fix bug#23769 along with it? The solution using process-environment looks obviously safe to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 11:22:22 2016 Received: (at 23779) by debbugs.gnu.org; 21 Jun 2016 15:22:22 +0000 Received: from localhost ([127.0.0.1]:49925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNVO-0006cs-5z for submit@debbugs.gnu.org; Tue, 21 Jun 2016 11:22:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNVN-0006ch-C4 for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 11:22:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFNVF-0006Ij-EI for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 11:22:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFNV4-0006Fb-Qp; Tue, 21 Jun 2016 11:22:02 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4935 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFNV3-0006Zu-TT; Tue, 21 Jun 2016 11:22:02 -0400 Date: Tue, 21 Jun 2016 18:21:11 +0300 Message-Id: <834m8m7el4.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Tue, 21 Jun 2016 16:53:40 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> <83fus87xgw.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Dmitry Gutov > Date: Tue, 21 Jun 2016 16:53:40 +0300 > > On 06/20/2016 05:21 PM, Eli Zaretskii wrote: > > > OK, thanks. Pushed as 5f37572 on the emacs-25 branch, and closing. > > Can we fix bug#23769 along with it? > > The solution using process-environment looks obviously safe to me. Please show a patch you have in mind. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 11:24:49 2016 Received: (at 23779) by debbugs.gnu.org; 21 Jun 2016 15:24:49 +0000 Received: from localhost ([127.0.0.1]:49929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNXl-0006gQ-Ie for submit@debbugs.gnu.org; Tue, 21 Jun 2016 11:24:49 -0400 Received: from mail-lb0-f175.google.com ([209.85.217.175]:35854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNXk-0006gD-3j for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 11:24:48 -0400 Received: by mail-lb0-f175.google.com with SMTP id ak10so13478880lbc.3 for <23779@debbugs.gnu.org>; Tue, 21 Jun 2016 08:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=QzBK7ovs6RqunZdjk4+5HyT/I/tRPJ4eGdfouuW3t7M=; b=GhFW32BAvA43jWgR5hiY5UyIHsnDoitc0LJyhN+3uKdp5klPqcP7nk38xj+YGFKMMF wmyadaW8CeS8G1kf43ocNjyXV9qVAae8mVsYHemtZIMT3mlQl7/sEssb5TKTmsYrEvHT aqT2a6s19l3loQFSR35IeKmbuVQE96uNma72YgCqKCKE0pxLWp/5rB4FCPgGdaHyN8mI JBLa1RdbZ5y/joW1KS/+61aZ6XKj/wwvwGOOWZGrgW0B2cmrQx6hV0Mxsxz9XQGP60yT Tz8/B8GXLuhIL2D3dYnpvCTx/LaXozs51svieYxO844dMpRbWxSPyfrwCnFmI8c7CFth MXvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=QzBK7ovs6RqunZdjk4+5HyT/I/tRPJ4eGdfouuW3t7M=; b=d4kPPPy8syWQKYfYJ44/bWfm3tyYo3olIJ/bEIlDI4IyqIU3iOLVtJSQUutBZDpFH9 ECZ/vlCvmobezuGL4i94gGfaPArlg2Ffl5BQ5PhsYO86sNrGLm07p0nhBXJIya2PPMTY 9HNx3EA4hkKHn31gxGEX1ndM60rh2d80a/x4VMLFI0z3RETOl453FHl+gN031QetqVWm +NIk/YZHsLSh73Ss3Avu1LG51f8Ik3pkNCffM3lfn7iSFeH8KgUCe03iu0IWo1vCtzzH fOFkwEqLYwYy4ZzHpgfmF1dNjvIyc51DF9Rr7lLbZGPN/mNfpFP2PaK+AtQKHhoIMCTY SP+A== X-Gm-Message-State: ALyK8tI9sHUGkkJAAzfQLKUQrH/nqOsvs33HJQ9SkO7G7qIHH5uaEQ8iOtKVLGvST6PZCQ== X-Received: by 10.194.88.5 with SMTP id bc5mr21958718wjb.100.1466522681907; Tue, 21 Jun 2016 08:24:41 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id x83sm3453057wmx.9.2016.06.21.08.24.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jun 2016 08:24:40 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> <83fus87xgw.fsf@gnu.org> <834m8m7el4.fsf@gnu.org> From: Dmitry Gutov Message-ID: <7564b3d6-ccda-5c41-b393-c34ef2887341@yandex.ru> Date: Tue, 21 Jun 2016 18:24:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <834m8m7el4.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/21/2016 06:21 PM, Eli Zaretskii wrote: > Please show a patch you have in mind. The one in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23769#86. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 12:13:55 2016 Received: (at 23779) by debbugs.gnu.org; 21 Jun 2016 16:13:55 +0000 Received: from localhost ([127.0.0.1]:49984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOJH-0007tC-Mr for submit@debbugs.gnu.org; Tue, 21 Jun 2016 12:13:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFOJF-0007t0-Ie for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 12:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFOJ7-00018j-Mh for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 12:13:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFOIx-00016f-HA; Tue, 21 Jun 2016 12:13:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4990 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFOIt-00073Z-MG; Tue, 21 Jun 2016 12:13:34 -0400 Date: Tue, 21 Jun 2016 19:12:28 +0300 Message-Id: <83vb125xn7.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <7564b3d6-ccda-5c41-b393-c34ef2887341@yandex.ru> (message from Dmitry Gutov on Tue, 21 Jun 2016 18:24:38 +0300) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> <83fus87xgw.fsf@gnu.org> <834m8m7el4.fsf@gnu.org> <7564b3d6-ccda-5c41-b393-c34ef2887341@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net > From: Dmitry Gutov > Date: Tue, 21 Jun 2016 18:24:38 +0300 > > On 06/21/2016 06:21 PM, Eli Zaretskii wrote: > > > Please show a patch you have in mind. > > The one in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23769#86. Looks OK to me. (For some reason, I was under the impression that it doesn't necessarily fix the problem.) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 19:05:32 2016 Received: (at 23779) by debbugs.gnu.org; 21 Jun 2016 23:05:32 +0000 Received: from localhost ([127.0.0.1]:50147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFUjc-0002RV-1y for submit@debbugs.gnu.org; Tue, 21 Jun 2016 19:05:32 -0400 Received: from mail-lf0-f44.google.com ([209.85.215.44]:34121) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFUja-0002RI-Ae for 23779@debbugs.gnu.org; Tue, 21 Jun 2016 19:05:30 -0400 Received: by mail-lf0-f44.google.com with SMTP id h129so48243544lfh.1 for <23779@debbugs.gnu.org>; Tue, 21 Jun 2016 16:05:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=0ToDjPWYcO2mfl8ijx1ikcsCOhwVRcZwTdWRH8XyS7c=; b=Y42uQqUXigQL51DbCCrVle4gSQat3aWa5RhUAGdyxJOJmeizEsKg+AF1DN5G44EuoF OXrsZfIWR+h3r4rCEFRz9C2/yVmObogEY2sWdiueNwuW9sUA/1BO/MAug19UIKnlaI1+ IDz7td8iSeG2IfybNcQ8bQAwYZDFCTPXVmYMxuhpUNSgVwqj/pX2lLYZGx7uo1DKPcdU oDnXbkdEBuxjiDnR86iUbhsEw5iMQ9ye9EJhPhAoGF2tMOND/CEZULCJQusCqRISUYK/ /j705ij2C6ZDarimFrDveYl7wI0l85Ciddw1/FlncCq9VcQh9FknUFmwhyqFehWxyWMW ZsNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=0ToDjPWYcO2mfl8ijx1ikcsCOhwVRcZwTdWRH8XyS7c=; b=U38jC/Is/P+QMsSvdyC6qQGAfeh9DTet87v9ldQLkp+qIK6hE7MvPyuxpcvSy6Wwqe JH/5BJgCSZBZ0CJy/gT3vEdNhGWjuWZwgtuzn18y9TzQvPLTtCEDDghhjlKaR70efJEN BMovTv06PU4xXPhRqCVKx/oRYtHD6Yq0xRlsL/tJ9BgWc3XHgXnCqtDkYQ+csdnbmimb Yl8cHd0NydIHoosAjw78TnmOH4S1dUIhC8slVdfhskTIna7ts7D5bZYZMUiThsjDFGlo Zc9I2gUK1/0eHRb6m6+l7cs7Wh1gxEso+0CpPgmzTXMqplrI8ettkmOyZ56vvfFkP2qE unIQ== X-Gm-Message-State: ALyK8tJvgiHwhFyBcCAJ05hNVK2vXVWEE7KqEpO61MCG/A1j6iRvaNJf1mMGYjOBI2affg== X-Received: by 10.28.163.70 with SMTP id m67mr5215646wme.38.1466550324228; Tue, 21 Jun 2016 16:05:24 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id ze10sm18871392wjb.2.2016.06.21.16.05.22 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 16:05:23 -0700 (PDT) Subject: Re: bug#23779: 25.0.95; consing "SHELLVAR" onto process-environment doesn't remove it from subprocess env To: Eli Zaretskii References: <837fdocmrl.fsf@gnu.org> <962d42ee-847c-507e-d457-2d6f9a38e955@yandex.ru> <83wplnc3t8.fsf@gnu.org> <83vb17c2z3.fsf@gnu.org> <57660314.9050907@cs.ucla.edu> <831t3t9q9y.fsf@gnu.org> <57672261.8090702@cs.ucla.edu> <83fus87xgw.fsf@gnu.org> <834m8m7el4.fsf@gnu.org> <7564b3d6-ccda-5c41-b393-c34ef2887341@yandex.ru> <83vb125xn7.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Wed, 22 Jun 2016 02:05:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: <83vb125xn7.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23779 Cc: 23779@debbugs.gnu.org, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/21/2016 07:12 PM, Eli Zaretskii wrote: >> The one in http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23769#86. > > Looks OK to me. (For some reason, I was under the impression that it > doesn't necessarily fix the problem.) It did not when it was presented. Hence the filing of this bug. From unknown Fri Aug 15 12:51:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 20 Jul 2016 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator