From unknown Sun Sep 14 03:43:08 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23750 <23750@debbugs.gnu.org> To: bug#23750 <23750@debbugs.gnu.org> Subject: Status: 25.0.95; bug in url-retrieve or json.el Reply-To: bug#23750 <23750@debbugs.gnu.org> Date: Sun, 14 Sep 2025 10:43:08 +0000 retitle 23750 25.0.95; bug in url-retrieve or json.el reassign 23750 emacs submitter 23750 Leo Liu severity 23750 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 11 22:23:07 2016 Received: (at submit) by debbugs.gnu.org; 12 Jun 2016 02:23:08 +0000 Received: from localhost ([127.0.0.1]:37527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBv3L-0007zx-OI for submit@debbugs.gnu.org; Sat, 11 Jun 2016 22:23:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBv3K-0007zF-1S for submit@debbugs.gnu.org; Sat, 11 Jun 2016 22:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBv3D-0007of-Vx for submit@debbugs.gnu.org; Sat, 11 Jun 2016 22:23:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBv3D-0007oa-SS for submit@debbugs.gnu.org; Sat, 11 Jun 2016 22:22:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBv3B-0007bX-HI for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2016 22:22:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBv35-0007oE-I3 for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2016 22:22:56 -0400 Received: from mail-pf0-x22d.google.com ([2607:f8b0:400e:c00::22d]:34148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBv35-0007ne-Af for bug-gnu-emacs@gnu.org; Sat, 11 Jun 2016 22:22:51 -0400 Received: by mail-pf0-x22d.google.com with SMTP id 62so34840110pfd.1 for ; Sat, 11 Jun 2016 19:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=jRmAXOCXbkJz+D5kq+9KS1rfAmc80Dhpghts1/YAoIw=; b=IIa9N/j7cNu3SV9O/2yovGHE40ay7laa1S+QMuYKRroOSGa3BslXhW1PiCZt9uuy2H LHudZNnr89ifRfJnyxTJw9vgBnKz0YCl8lTjdP3CJaCOusAWnrp4rFYMDvAF7lWOqLXC kp3oqWkMw1rDfEHz9L/K+40nsG+8Mwy/JVBcz0LFJqer+wpUJdr3BsVKkeIuGFyvkOsC tTAKBm2TvExLTCNhbDkVSupNd1exsCurB1yRNsTqAAbZV4djasUuiTtlLgerIkc1lYkE NdYfZ9vsSoWbhmg2Rk/bcBdmFZkPIe9SjtDYWaBe3Aibaj2y1NmIRCKuegT/adbsJi5v /qWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=jRmAXOCXbkJz+D5kq+9KS1rfAmc80Dhpghts1/YAoIw=; b=KXiy6tsaQy+hSuy13HsIo/v9W2iSYoDTfEqVVkWNeaUnIW3mqeGIokhJXwiEXS0hAl Ikbr6pdYjd2lRJXxQ+eDPv2T8j+SE2YDvYUbwk+OIqgxY1yNZRj82ywHADRcX3I09N6u BUDCScnFM16mG7TpS4JX3jgWePzWZuKwZjuXrQgH3k1OVMz2XgZe7bvxYNugYeTYs2m9 xxah6w6POnu3/B/HtnFh6GOVQU69E2R5LQXbERCH8CvA7l3jDMG8wqpmKHFHT561aSI7 smo9+ptbYohXT0vouS4XkGb3X1lwOJrvvnutvCMJWf2NDB91r2gjp3vrDd6pkufl3KO7 cRtA== X-Gm-Message-State: ALyK8tLWYcICVmFgIDEbYopkmkX+ECeQCV2t2yGitphJljiBH3g7ZQdz3iJA66v3v5ou9Q== X-Received: by 10.98.108.3 with SMTP id h3mr11926983pfc.15.1465698170116; Sat, 11 Jun 2016 19:22:50 -0700 (PDT) Received: from Zeuss-MacBook.local ([128.199.175.219]) by smtp.gmail.com with ESMTPSA id ez6sm27480639pab.12.2016.06.11.19.22.47 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 11 Jun 2016 19:22:49 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 25.0.95; bug in url-retrieve or json.el X-Debbugs-CC: Date: Sun, 12 Jun 2016 10:22:37 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I have been trying to debug an issue in TernJs=B9 on and off for a few months now and it seems the cause is some nasty bug in Emacs 25. Could someone follow the steps detailed in https://github.com/ternjs/tern/issues/719 to reproduce the issue? I have verified that the bug is not in Tern but Emacs i.e. under some circumstances emacs's URL package strips some chars in the request body which, in this case, leads to unbalanced parentheses in the JSON doc. Leo Footnotes:=20 =B9 https://github.com/ternjs/tern/issues/719 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 11:02:23 2016 Received: (at 23750) by debbugs.gnu.org; 13 Jun 2016 15:02:23 +0000 Received: from localhost ([127.0.0.1]:39127 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCTNf-00047p-0J for submit@debbugs.gnu.org; Mon, 13 Jun 2016 11:02:23 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCTNd-00047R-Ua for 23750@debbugs.gnu.org; Mon, 13 Jun 2016 11:02:22 -0400 Received: by mail-wm0-f51.google.com with SMTP id n184so82701862wmn.1 for <23750@debbugs.gnu.org>; Mon, 13 Jun 2016 08:02:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:cc:message-id:date:user-agent :mime-version:in-reply-to; bh=IayAZzqIw8D2rLsZ147q7XaFRWYyB8xJwAS+VsZcmwY=; b=iNfwNObvIwZTxZvdUz9mlMLarqxhmoK4xRGlqp/Fm8TAfjjQwcAzpq1s4iDV9JF7pb dJSipF2fzU3O+YwgYBMv4Byr4HQ3ShLGRhr315+Hfdj+s8NMwKo51Nv5k+l0C5NgirSV WDqXf3CxPOII3s6BxiXr5J/kg898zFmNFmXF3nxqg82IeLn0TKl+F2DXTzYqZry+6Wpo gVCDveQMHBOlvM6Wo874wBrZp+gAeMUxtfaP491fKhHghLE55pomXVuT6SpzQrnnPnNq OigxX2GYHwmLVTsA3SHRAJQIN73B5N6epRY29OtVtCLjNMuVWY6pmka1sofy2RUC9nzx bAMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:cc:message-id :date:user-agent:mime-version:in-reply-to; bh=IayAZzqIw8D2rLsZ147q7XaFRWYyB8xJwAS+VsZcmwY=; b=Asz0yK8zcbyRzygiQnaShNo8WqMpSfZvv1ZKNep0LIGSM64QEjSQms8Qu8ZyIySP9R I2CbETDo70/d0v2WRFHJfUVydhlDnA5NsWzLgya+bHigUdBiyan9W9+ANCaq/J0FvjPx 5XwX2jSGHkDDU3ERDxjbNwwLydizZU9zhKcVFfcLCC/Rn6pT+61Q6BzA3l0IgypXlzyw y8mHn2m5URggo1sOmaOZLYFaOfDrO+YTz50EVnWXAmmgQDHDIaWxcs8+6yrMSIqgbanP VJKbv7MvC3XcezCY2ePRMWOXMmq9t4bXvNokwyvOL1UsgMvZ18xW8Yvz3PSRU65Dy8Ts 23xg== X-Gm-Message-State: ALyK8tK8DvOzdR5Ub4Nu/oa04GhafwpYuV1gMbJbb2s/V0kyfFZV0YdtDqquf3Vgtq+GyA== X-Received: by 10.194.246.129 with SMTP id xw1mr1638555wjc.142.1465830136221; Mon, 13 Jun 2016 08:02:16 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id i74sm223186wmg.21.2016.06.13.08.02.14 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Jun 2016 08:02:15 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Leo Liu , 23750@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: Date: Mon, 13 Jun 2016 18:02:13 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------FD559A1CD007CA0220D99463" X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) This is a multi-part message in MIME format. --------------FD559A1CD007CA0220D99463 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 06/12/2016 05:22 AM, Leo Liu wrote: > ¹ https://github.com/ternjs/tern/issues/719 Investigation shows that the problem occurs when url-http-data is multibyte and (length url-http-data) differs from (length (string-as-unibyte url-http-data)), because we send a wrong value in Content-length. Changing url-http-create-request like this will make the problem more obvious for anyone else that hits it, patch attached. Stefan, did you have a particular situation in mind where this might be bad, when you wrote the FIXME? --------------FD559A1CD007CA0220D99463 Content-Type: text/x-patch; name="url-http-unibyte.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="url-http-unibyte.diff" diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 5832e92..f7ec640 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -278,14 +278,10 @@ url-http-create-request ;; We used to concat directly, but if one of the strings happens ;; to being multibyte (even if it only contains pure ASCII) then ;; every string gets converted with `string-MAKE-multibyte' which - ;; turns the 127-255 codes into things like latin-1 accented chars - ;; (it would work right if it used `string-TO-multibyte' instead). + ;; turns the 127-255 codes into things like latin-1 accented chars. ;; So to avoid the problem we force every string to be unibyte. (mapconcat - ;; FIXME: Instead of `string-AS-unibyte' we'd want - ;; `string-to-unibyte', so as to properly signal an error if one - ;; of the strings contains a multibyte char. - 'string-as-unibyte + 'string-to-unibyte (delq nil (list ;; The request --------------FD559A1CD007CA0220D99463-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 15:10:21 2016 Received: (at 23750) by debbugs.gnu.org; 13 Jun 2016 19:10:21 +0000 Received: from localhost ([127.0.0.1]:39251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCXFc-0003Ir-OU for submit@debbugs.gnu.org; Mon, 13 Jun 2016 15:10:20 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:57990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCXFX-0003Id-OD for 23750@debbugs.gnu.org; Mon, 13 Jun 2016 15:10:19 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u5DJAFNx023848; Mon, 13 Jun 2016 15:10:16 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id A5AFEAE580; Mon, 13 Jun 2016 13:55:15 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Message-ID: References: Date: Mon, 13 Jun 2016 13:55:15 -0400 In-Reply-To: (Dmitry Gutov's message of "Mon, 13 Jun 2016 18:02:13 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered TRK_NCM1=0.2, RV5705=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5705> : inlines <4928> : streams <1651430> : uri <2230089> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> =B9 https://github.com/ternjs/tern/issues/719 > Investigation shows that the problem occurs when url-http-data is multiby= te > and (length url-http-data) differs from (length (string-as-unibyte > url-http-data)), because we send a wrong value in Content-length. > Changing url-http-create-request like this will make the problem more > obvious for anyone else that hits it, patch attached. > Stefan, did you have a particular situation in mind where this might be b= ad, > when you wrote the FIXME? No, nothing in particular. Just that `string-as-unibyte` is generally synonymous with "the author is confused about how coding systems work", aka "trouble". Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 15:26:31 2016 Received: (at 23750) by debbugs.gnu.org; 13 Jun 2016 19:26:31 +0000 Received: from localhost ([127.0.0.1]:39259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCXVH-0003fj-89 for submit@debbugs.gnu.org; Mon, 13 Jun 2016 15:26:31 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCXVF-0003fX-Np for 23750@debbugs.gnu.org; Mon, 13 Jun 2016 15:26:30 -0400 Received: by mail-wm0-f42.google.com with SMTP id m124so93250616wme.1 for <23750@debbugs.gnu.org>; Mon, 13 Jun 2016 12:26:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=h4gCGUUh6XFterk4kZNUuGFBDPBm+D7Z64uTih4ftRE=; b=QXerYt1c0kzMmudgD3/x4THBrw5DUSrUc7iwRHRzHN8crWXQwz2C1aU6iYYDEw4xUC eBjuboRbJ+rb+B9fSkVdtyEyy0YFJimZXf9RYb39ec/YQXJ94cBG7sFzkL9iA6xO9xdo /ImdVydVv1eJvP9N2a/ZZIx0ARR6HPBhkuaBfhkMFqSm0mL8i1vTctT05OJDgEZ/KDZb 6yjJHjf2l0LLaSXuMcP7sOKOBTQvBUsWrJMsSJt/smWVFuH3eb1ViTZAvp133qqC0DGC q6fpib67q14+Xuga7Mz62YIPg9KLF+GdaEO15gzamqff9zjauuguSTp/2uS9AjTQIu5i 6E+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=h4gCGUUh6XFterk4kZNUuGFBDPBm+D7Z64uTih4ftRE=; b=Ji7Odf9+uehmuVY91bP8X76l/OWCvepSBJUxfCdIhMhlBXXZ9fWEaXQ20NEgaJt6oX nZJH2q2OLOqYNU9SX/5N9Vz8hJH09Dzk6VsKb2eCjmheRkLxQF97zGgqFoc8B7HttHDF fB+KwnHEzqD7M6SZ/wr7u1bZZ5f2xkcE34yso4sXUwkGZGPje+GkCCKHqdysk+XNxw5m sZsfMD1oy1aC0SPaSxf/59AMNzlT6Xrp860BuzqWGXt8J2FBT4ibGAzaZS19D/FZDuZF uV/IXeRhGPxvbXRtvLFzH/r81e1Y4gHF326Kh4hhaFEhG+agtX9BXJ7cz4V3mXmDblqJ 24GA== X-Gm-Message-State: ALyK8tKwf4Yl2Aub/VvfpMbIRAOVPQ7q593Az5W/8+X6wW+2UF+L+5ntHaZreUaVNqOahg== X-Received: by 10.28.153.138 with SMTP id b132mr1123745wme.94.1465845984098; Mon, 13 Jun 2016 12:26:24 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id lf7sm29054284wjb.23.2016.06.13.12.26.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 13 Jun 2016 12:26:23 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Stefan Monnier References: From: Dmitry Gutov Message-ID: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> Date: Mon, 13 Jun 2016 22:26:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/13/2016 08:55 PM, Stefan Monnier wrote: > No, nothing in particular. Just that `string-as-unibyte` is generally > synonymous with "the author is confused about how coding systems work", > aka "trouble". You were also the author in this case. The same commit added both the use of string-as-unibyte and the FIXME comment. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 13 20:30:11 2016 Received: (at 23750) by debbugs.gnu.org; 14 Jun 2016 00:30:11 +0000 Received: from localhost ([127.0.0.1]:39410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCcF9-0000Qj-6j for submit@debbugs.gnu.org; Mon, 13 Jun 2016 20:30:11 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:35753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCcF7-0000Qa-1Y for 23750@debbugs.gnu.org; Mon, 13 Jun 2016 20:30:10 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u5E0U7cm001144; Mon, 13 Jun 2016 20:30:08 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id D3DBDAE580; Mon, 13 Jun 2016 20:30:06 -0400 (EDT) From: Stefan Monnier To: Dmitry Gutov Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> Date: Mon, 13 Jun 2016 20:30:06 -0400 In-Reply-To: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> (Dmitry Gutov's message of "Mon, 13 Jun 2016 22:26:20 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5705=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5705> : inlines <4929> : streams <1651548> : uri <2230246> X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) >> No, nothing in particular. Just that `string-as-unibyte` is generally >> synonymous with "the author is confused about how coding systems work", >> aka "trouble". > You were also the author in this case. The same commit added both the use of > string-as-unibyte and the FIXME comment. Can't remember why I did so. My best guess is that I tried to mimick some earlier behavior. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 14:15:10 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 18:15:10 +0000 Received: from localhost ([127.0.0.1]:46628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhFW-0008Ew-E0 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 14:15:10 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhFU-0008Ej-Q6 for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:15:09 -0400 Received: by mail-wm0-f53.google.com with SMTP id v199so43992278wmv.0 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 11:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=AgZE6GYjUhLiA4nxyLcQzotijUK64g9NvJx4pDfPv0M=; b=StD+enWLf38ZsyDhcYNA8zADJNn+lyXEMJbfNUbhh+LGNy63PFVnYnR1Yo8iiaV3QK uEAMu2U3SrFW4Z0u9quLC/2QTsHgWDI5n1uV4lhPE/fVq+Xvv/IFXT/dIpI4Ag5nlZgC 1BMngrIrlqu2C1xXvW+BYGSiiqTBk1cpxsfMEboud67berjJPw1UbTZ0Kax8pwOj0oOM V47KxYy2F5YYri/G3tUYtGFjpPDBWyxKeiZKA82MRuY6wTWyy4RCuGLLZ+iSbc+/f/Lp bILhhSSaFzjB6SqlHEScrNDhq1PZuxpeDuoHI6ahVMcDxbKlUw8LFHL3qYvuSxTVmUPz ZPmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=AgZE6GYjUhLiA4nxyLcQzotijUK64g9NvJx4pDfPv0M=; b=ObRdbB6ileQDLQA4gbm0+wlCeWOqBMt8WA7/OEiRaJDW9BnINY9u0OpAA61PdSIRFl L96WDMZeT4Hy/UOQcbohrChoBW7y6x0wW1d1wJeXIgdBxT8vETQk77q0dRqKr98NDDtZ sws2tKG+0CxSO9nHPydJ5azvg7TiZMeBa0tGxsiEgmu6sLPLQNniJViX6zcjhzISc94u nQb/DrOJfCqA8/2REkjO08CP7TVtIiC76T0supg2rnwf+m2M9oUARCygFDOQsxLQbIcm 4/h/2jbDYGLfD88DQgrrgsN8NVOY9HvsKMwJQ/uAj7uyFaJJcdt+IneC40YAFR4+nUCB k7WA== X-Gm-Message-State: ALyK8tKW6P05ceAbu1mSWZqxpzSMZBLGERjFKEA5hJZFButhAQ5LhYIhRKnVA3NC7F00zg== X-Received: by 10.194.190.163 with SMTP id gr3mr10840505wjc.148.1466360098264; Sun, 19 Jun 2016 11:14:58 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id d192sm4508887wmd.14.2016.06.19.11.14.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 11:14:57 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Stefan Monnier References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> From: Dmitry Gutov Message-ID: Date: Sun, 19 Jun 2016 21:14:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Eli Zaretskii , Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/14/2016 03:30 AM, Stefan Monnier wrote: > Can't remember why I did so. My best guess is that I tried to mimick > some earlier behavior. OK, thanks anyway. I've pushed the patch to master as 2ede29575fa22eb7c265117d7511cff9fe02c606. Eli, could we have it emacs-25 as well? It's not critical, but it should make the life of our users easier to flagging problems with the usage of url-http earlier, in a more appropriate place, with an error, rather than leaving that up to them to deduce why their HTTP server truncates the request body. While the truncation bug itself is quite old, it's been exacerbated in Emacs 25 by my own цщкл to make json.el faster: one side-effect is that it doesn't \u-quote multibyte characters anymore, or at least not all of them. FWIW, I've been running with it applied to emacs-25 for the past week with no problems. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 14:26:07 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 18:26:07 +0000 Received: from localhost ([127.0.0.1]:46640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhQ7-0008WM-LN for submit@debbugs.gnu.org; Sun, 19 Jun 2016 14:26:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhQ6-0008Vu-JQ for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:26:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEhQ0-00073Q-Ju for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:26:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEhPw-00072s-Tk; Sun, 19 Jun 2016 14:25:56 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2807 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEhPv-0001CA-7c; Sun, 19 Jun 2016 14:25:56 -0400 Date: Sun, 19 Jun 2016 21:25:32 +0300 Message-Id: <83k2hl828z.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Sun, 19 Jun 2016 21:14:55 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, Leo Liu , > Eli Zaretskii > From: Dmitry Gutov > Date: Sun, 19 Jun 2016 21:14:55 +0300 > > On 06/14/2016 03:30 AM, Stefan Monnier wrote: > > > Can't remember why I did so. My best guess is that I tried to mimick > > some earlier behavior. > > OK, thanks anyway. I've pushed the patch to master as > 2ede29575fa22eb7c265117d7511cff9fe02c606. > > Eli, could we have it emacs-25 as well? It's not critical, but it should > make the life of our users easier to flagging problems with the usage of > url-http earlier, in a more appropriate place, with an error, rather > than leaving that up to them to deduce why their HTTP server truncates > the request body. I'd need a very detailed description of the bug, and why this particular solution was used. IME, neither string-to-unibyte not string-as-unibyte should ever be used in applications, their use is more often than not a sign of some basic misunderstanding of text encoding. For starters, how come 8-bit bytes wind up in that function, and what do they stand for? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 14:30:46 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 18:30:46 +0000 Received: from localhost ([127.0.0.1]:46644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhUc-0000Cr-8A for submit@debbugs.gnu.org; Sun, 19 Jun 2016 14:30:46 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhUa-0000Ce-SS for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:30:45 -0400 Received: by mail-pa0-f45.google.com with SMTP id bz2so43593844pad.1 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 11:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=TanAcduRV3yBWhjzy531cahMjA+Nni8l0IImhsbVrLU=; b=mSw1/MpDOmYK9VkT8+fQ8fJQXIcADoC4wonZI1UvmGkxtboLzNzG2dxi1czVZKSamT 4fKt40xIrVHyq85KB6sZ8PEADuVhmA6wXl/wuI4OEGCA9RSQXkAL3fKtESSXq710A73W EolEGqioWkjsphpEC2vEml1Ov1t6vRSpDCSuwDxLdfZwNYaaU9+grTvcM/4L2vEbYjtv 9hXzJckOUf3OjYOw6Y3/JGgH7CXrFnEWNTPvp/LTnRqONJ6oX4UiQVu0wYfwIB8kFbjG iRVZBJ/Tl6/MJ1em7NEBjOjuDDxj0cnn6xMUtrQETYLj9nqI+Z1NQN3ZsTQXUEVtfVzG +pCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=TanAcduRV3yBWhjzy531cahMjA+Nni8l0IImhsbVrLU=; b=K7cn9JX8Dewqs0JxxANqrm7UqOPAJL3qyC2ICQGVouV8spS5C89tVWhcU4R6InX62d lputCeGHZt8pjT4/jdq8utKf9G8+ePNi/4BwxhlbRsZ74LemyAMm2ChwGLeDe1t6yXji F1NOWD+55gdniXWx2rIXJCtpQcOUHlHnCe3NKZtr62/+koWV9SRgF9vYMiaDf34mj9Mu pAGp0H54XoVTL2c+B16i9N0JCl4bCTepkRItH7TfrDgg0FbouiG4cR7U876MF+dC4Rqf QT8jeq3hrnwi6DLkv+KnHr+pJDAyj921r2CKzGUA9xhjsgJm/ERynFG74B/+e37nLl7A F8LQ== X-Gm-Message-State: ALyK8tLbel5hzYEdNk8q1/J2jlS7juexN1UxKgtu84w6OUqziSPuUZrv1EaRMQvYtgCBmA== X-Received: by 10.66.101.136 with SMTP id fg8mr16980448pab.144.1466361038960; Sun, 19 Jun 2016 11:30:38 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id m8sm35457195pfi.27.2016.06.19.11.30.38 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Jun 2016 11:30:38 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 5DB1A9979DA; Sun, 19 Jun 2016 11:30:37 -0700 (PDT) To: Eli Zaretskii Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: <83k2hl828z.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 Jun 2016 21:25:32 +0300") Date: Sun, 19 Jun 2016 11:30:34 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Eli Zaretskii writes: >> Eli, could we have it emacs-25 as well? It's not critical, but it should >> make the life of our users easier to flagging problems with the usage of >> url-http earlier, in a more appropriate place, with an error, rather than >> leaving that up to them to deduce why their HTTP server truncates the >> request body. Bear in mind that 25.2 can be released as soon after as we want it to. If anything is "optional" at this point in time, it should be deferred. We shouldn't try to race anything into the release, just because we think users will then have to live with some minor inferior behavior for a long t= ime after. The description above certainly does not sound like something that needs to be happen for 25.1. =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXZuTKAAoJEMFE2PTxn+YwTnkMANTNJ6Ay6NRYTyqcNx0zEm8Q na+SgGJ+FN2/hHCkb0I6eMBIGapngmIeYC3oOsRYFkJHdGF45fZ2Smses46RfxHi H77vh+VUufSat1b/qgHvJL2hIN+Z51q1S5vfN2IiF+OKIo/n1Ay7JOXjjNzD151x cM+LhC7L2Th9gXbx0DyE9gxi6PcAdtza4xd9gNxuJTZqBX3bVSm33/ZKKDZIslCV di+VK+JpJ7Ys36hGkyPpGLWwx5TVUX2juprurmjoZZW7Scv0SwU9cdxUhoG1bWMU XD0hY5Mt66BD5jBfxlfOhguIhqK1m5HP3Cac2CfrzwIIkzhnM2sK1ac6P2uzJWNw u565YRM/Xl11EIGm5aV25cmRvbWajgPukT19ivpI4qqk6upEoPQbQ/1QY7/I4fqL 9XlajTAV+5Mw6tRbFBCtK2GylJRbMzK2yayikncBn8Ri/gES7EyPsRRDfZ+09R/N 3dOCzmY9Wl/PmFEB/Mv1Or+rGiYsSM4qVzrcDF4Txg== =XYdH -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 14:36:36 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 18:36:36 +0000 Received: from localhost ([127.0.0.1]:46648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhaG-0000LN-3d for submit@debbugs.gnu.org; Sun, 19 Jun 2016 14:36:36 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhaD-0000L5-IK for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:36:34 -0400 Received: by mail-wm0-f53.google.com with SMTP id r201so33947929wme.1 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 11:36:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=PyFACvqj16JCrtc6Ib266KwrChSSs92f8/S9mgmn1nA=; b=CbRFA8KFKDrokxxOKG2TeNH2IkCu2JmptXpSny/CyUkJcN5KVj13qqUNhsZ2WTwPti Sbaj0UQFWKxy2g2Iu4HFmW79rmYKxoRlR8tL3g8qQv9h0gK0+wEbMV+6ivBsRsTQ3LJC j6ALJ1LbqzUTzRw6yL1wyVEgP8sh2NPh/QHbckq4jZrHBCjK0H3lJrpHap+XbvBZbXMn CbMehqbG1FiWLg8Vc+QgsHQKHIKwPab3S/pyNtrDPdyd7IzNG9kUYyjBvYn0cglEZAtd 5wBQLfkgfUnCTmmJdNMUuexjJCgTuhxF5YndfsYeTeMmKE9QjF75bFBvBPt8qGTl6DWx zK7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=PyFACvqj16JCrtc6Ib266KwrChSSs92f8/S9mgmn1nA=; b=eQn/E9DfVZzUhsoH/5uDMwNH1jcMFJdBjQGE0Nh/CepO/an2RtqpjiTmhiS3LfmDla d3PAli7qaqAqU0s5WqO7R31XLOULqZotQvW19kUn3Y4Gq7LoVVwh5fD76xxfSj/Vn7nM 8V7r1Ao9pRIdSkeWGhMzkCzOAd6pClHKHJVhAHmZN7cE2c4UC2ysARkKQMt9olKPGTOf YYsMoKN4vf9apOQa6cySAwk2hlVkgZp5cjMLRM72td0h8MMAdHnEW1vzVrxWB+Uq8cd4 TTE1kuRY8a5X0AI5pAnW5v2WnskWYCYQOdApJItJJsjTcrhsCp3PNYJgDIOV3ljKpA6W KE3g== X-Gm-Message-State: ALyK8tLtrWElfOJiug5rUW4U32WYEqkpc0tiJ4oxtz9Y/GO55R0J354agrReokncCT1CsA== X-Received: by 10.28.69.14 with SMTP id s14mr7770110wma.49.1466361387931; Sun, 19 Jun 2016 11:36:27 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id a191sm9679659wme.5.2016.06.19.11.36.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 11:36:27 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Sun, 19 Jun 2016 21:36:25 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83k2hl828z.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/19/2016 09:25 PM, Eli Zaretskii wrote: > I'd need a very detailed description of the bug, and why this > particular solution was used. This particular bug came from this: "Content-length: " (number-to-string (length url-http-data)) Which gives wrong value when url-http-data is multibyte (it should be length in bytes). So then, the HTTP server on the other side saw the wrong body length and truncated the body when reading the request. Or something along these lines. > IME, neither string-to-unibyte not > string-as-unibyte should ever be used in applications, their use is > more often than not a sign of some basic misunderstanding of text > encoding. For starters, how come 8-bit bytes wind up in that > function, and what do they stand for? Some 8-byte encoding of the HTTP request body. Anyway, yes, the hope is that the programmer uses something like encode-coding-string to produce that value (and picks the encoding, and indicates it in the appropriate HTTP header). Then string-to-unibyte will simply be a no-op. But we need to catch the case when they don't, and this seems to be the easiest way to do this. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 14:45:34 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 18:45:34 +0000 Received: from localhost ([127.0.0.1]:46653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhiv-0000Yq-Vr for submit@debbugs.gnu.org; Sun, 19 Jun 2016 14:45:34 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEhiu-0000Ya-Dv for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 14:45:32 -0400 Received: by mail-wm0-f44.google.com with SMTP id r201so34114938wme.1 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 11:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=dI5pwT0LsD6gIBdMsk6DWKxAXM6oEkJ7bRUlb6u4z7U=; b=M5P/ewO8NkTJFPU4R7Gcxdw7i+egbbfzuWIc4zocp3f7HMYP6qtZ6scLPCK+xEMoLF BzgjrToc/+tLX/fGZik+YRfAUVGlHtam5LvYMjRdWvJKr9vbf/fFDNuF07BcL1P+mVsw 2Ot2ReQlaeJCZiWYOV7rsD8HCSW/xqA5FO9GPiyJEYQ22YNrf3FzBrmExxiVvxLw8UIA ntKzhc8lusRMf+NDmgX2XVMWloB3wgMPg2YyYyuUuqvLSJ9Kk6krQksKHTGhhaNogbd6 ddlRRveWBkYIja/WvyZoW9mk2Lo5hgLItb+xtVpmgaxsegreS1IGXdNIiYjALwv0Flwo LOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=dI5pwT0LsD6gIBdMsk6DWKxAXM6oEkJ7bRUlb6u4z7U=; b=fvAhXjS9azOJuBL+ecdaV5+0pFGlsKboP4b5aV2BeVz4EHWFHUXyLpyeAQSmb6kvMw n7Duo9Hbp4Lwjux/MykuM6Epfwq0/AEB7AYEJYo8EMDVm0xYsOUGTzTQ9mWeRbYd/8A0 kqUR8zx4VOvMSFa/IVqAK707hNGBr0ZZjqg735TierLz8ufn6zzKGr6XGBAyRbno5N78 GBxUlvXw+2+mvfSUwzSditMpXxybh8zD2+zkWlvn1qseS5z5RqncqOUmHcrb22/kqvpa QsaFMHBusshLfEIsd0G9562TTa5713sXxWR7PaW5G+dZXzGq3GV6DvmnnD6fY7CETx9/ cSnA== X-Gm-Message-State: ALyK8tL4fuyAPxYDD/n6G4E8Wf1cpIlT5FCFgVwAOXBNSIm4mZZ0rcAc5yWmSBGE04a/SA== X-Received: by 10.28.129.197 with SMTP id c188mr8211240wmd.46.1466361926795; Sun, 19 Jun 2016 11:45:26 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id w76sm9654797wmd.11.2016.06.19.11.45.25 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 11:45:26 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: John Wiegley , Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> From: Dmitry Gutov Message-ID: <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> Date: Sun, 19 Jun 2016 21:45:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/19/2016 09:30 PM, John Wiegley wrote: > Bear in mind that 25.2 can be released as soon after as we want it to. If > anything is "optional" at this point in time, it should be deferred. Let's apply the few outstanding patches and release 25.2 the next day, then? Traditionally, releases are separated by at least several months, even ones with no big changes. > We shouldn't try to race anything into the release, just because we think > users will then have to live with some minor inferior behavior for a long time > after. The description above certainly does not sound like something that > needs to be happen for 25.1. Just to be clear: the patch doesn't change the behavior of any working code. It just catches a particular kind of bug earlier than it would manifest through a cryptic behavior. Behavior which is non-trivial to debug, and thus adds to the already non-trivial effort required of a person writing an advanced language support code (using an external daemon talking over HTTP is fairly common for this these days). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 15:56:38 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 19:56:38 +0000 Received: from localhost ([127.0.0.1]:46691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEipi-0003rT-Ct for submit@debbugs.gnu.org; Sun, 19 Jun 2016 15:56:38 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:33174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEipf-0003rD-Kn for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 15:56:36 -0400 Received: by mail-pf0-f172.google.com with SMTP id i123so43050405pfg.0 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 12:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=cUGNo2nZChxtdmcnzN10VCwSSVZm4MxyBhf63MbzKxI=; b=ct+53fEtNHOCCD7yyWyxuV3SwRxpfn3TCkMgU4AFxT+lMFxKEEzRJAamztuA5q+KOC /bdv7odke+3atXydT273BAUFX2OFmQFlZVK6eoA/dVZJ5/MufMGEGHnmpSCAs7O7v7cm Z7IQtHdpCKNjnwRFNUPa2n18AZqH+PMwwwaj2TNoI/29JwFOby1+wIoRNwtMmRaJuP+P MgiESD0c3zs+GQ2mfDVPVwjRdGhpzrPIgLvLddkSs5tIDyy9JKi0Q/t2fZ9C7DGEPs1b Hl0k5AjGMnjTX4GTu1uAlL/U1dXABKWR/y49SY/5bRw0peREJlQk7tJFVxCIHd8PWsoN zT7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=cUGNo2nZChxtdmcnzN10VCwSSVZm4MxyBhf63MbzKxI=; b=Q4LiiInXQlcvhkf/EL3Otvk58XYhDWetutcAOvmjHaVUpw2YQedFzXZRoCJ6DkJQq5 Nwde5UBBvoZsKUJ39jdFFRMD6TV9ZhuCP4+NQ+KOmH+ma1+WR3824OYYSbaPbQccdzFa pqyKooKEFolAi1Aw3/hpbTPzvBopzpt6uhuV37tE1oQdOXtuoCCsrLwjDXOvKEaxAEeV 1bEX6Hzxrlz0F3WGLki34eQk39ottPBKUYepFj5pOwojucHYvOMpZyaCz8jG8YmhApSj LoVaRmGn19o/N+KzoG4h2YEffTFgNg5ORhbV7YeMjg5YAE98sfrxSQkdbajS2x11a5ky R5zw== X-Gm-Message-State: ALyK8tLZ8wgIeciIUdtqxmRZTSCTB3U1SdbZh6TaJBAmNH4LDl9RGGC/UHhVPc0lg7tvqg== X-Received: by 10.98.43.7 with SMTP id r7mr17281145pfr.65.1466366189740; Sun, 19 Jun 2016 12:56:29 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id n17sm34590765pfb.38.2016.06.19.12.56.27 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Jun 2016 12:56:27 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 05E709984F1; Sun, 19 Jun 2016 12:56:27 -0700 (PDT) To: Dmitry Gutov Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> (Dmitry Gutov's message of "Sun, 19 Jun 2016 21:45:24 +0300") Date: Sun, 19 Jun 2016 12:56:23 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Eli Zaretskii , sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Dmitry Gutov writes: > Just to be clear: the patch doesn't change the behavior of any working co= de. > It just catches a particular kind of bug earlier than it would manifest > through a cryptic behavior. > > Behavior which is non-trivial to debug, and thus adds to the already > non-trivial effort required of a person writing an advanced language supp= ort > code (using an external daemon talking over HTTP is fairly common for this > these days). I get that. But right now, if it doesn't *have* to happen, it should wait. We're thinking about cutting the release candidate in just a few days, pend= ing one issue that Eli is looking into. Any change -- and I mean _any_ change -- has the potential to introduce unforeseen effects that could delay us furth= er. =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXZvjnAAoJEMFE2PTxn+Yw2mEL/0fCyhc4bInKjFiknArnuxyD Gogv2YtVc3nrnTMaZSKrPZnvlh5KrZpX3geYBxCihtpQo9s1AdhThYNrr+kfCkWL 8R512uuj8FaA91I85goZpwbZsmJHbDj4FoIPdzlD9L+8vgtnRVR71kVxzkV2G44+ NMwgYN9mB3iSZCAG2pmDpaor3n3TBMQ2tcJcAXERh/2bYj4QzcLPh8oJZyx527D/ Z+Nkv/nVLR75ZBTlnDWOapa8+RSnwoZNPREfRV0qlBgWfgKW4/hnCyL5RK7y4XFA qleGSSpSC00McIv/81FlOve5rcgPoL/BV/m5HWNQJn4MsBCWWlZFBtM2hgmbDlyT dZ6axbvkreHhEd+5ynk2FsG+t8aXld9jN8qMiWK9RqPdrWIT/z8bnIuJzaEwWW4C /HVaGzauHT4KJeR+gpLUlqlEuafyUB3iGnsJ4xmSVLaZ7ZWlWVlmHHOiQhFIPrYd /CaFMn5VrWpjReTzi/zrvdUxDaDIPT3ftMBTjFJJYA== =ddTI -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 16:05:48 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 20:05:48 +0000 Received: from localhost ([127.0.0.1]:46695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEiya-00045O-Ab for submit@debbugs.gnu.org; Sun, 19 Jun 2016 16:05:48 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEiyX-00045B-8Z for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 16:05:45 -0400 Received: by mail-wm0-f42.google.com with SMTP id r201so35619574wme.1 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 13:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=IsFQcc2UOVxhki7Ieek6xo2uv6VF+vqRb4dlUg8OT0k=; b=zZu1Kyp2XLQfZgo43z3MiNDHanU14ZBd4fRP7MmlApajJ8u+n8rqcK2WsP/kwzfmj/ ecXBJTBoOgDERBNvB9w4i+9pZy4fYvcGpT6gyz5Yy8QxCHp5mZGkJXhpHEWUxEWr3zSR Ngt6YgnyR7na7WuZecQoT3kKG4FUKfW5ctVAhClAVTQ5tzNcHID3PSoLiEIagE4tWrjl 6URaveYNrJYGKmDrbJE22j/VHwaG2vBKItF7n1D1zNZKDpTENEKK+mqs5RIAYpjGfNwU 3kMjz9PgFJZmF+WNHzRvA+bTu62HeAW+MU2xSQnMmklFCGzD6Eq3ogaDRRzEONR++ele Up+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=IsFQcc2UOVxhki7Ieek6xo2uv6VF+vqRb4dlUg8OT0k=; b=FPNNiUHVJBcA8sVgopz29lxX+u4uXa3OxVHVdoc4pfX1ypmGA2DKis4Nq435LnIdql 36PASFA/LGHhTfcWK+YDktZcnQrMQqVUEJjzQqwmHlmmgj+XLzfg6grKfoXz5BmhDuf3 jDB1XTRWF5JeLFwdAkd92elCBW3CnoNSxgEhjqrklvh10YKR7zZt55G9b8nwOutFPn1W qvirXzdvaPIDCTL9z66vBA5kkBbA0TK9rTPlOTFiTKCXXZ8/N6/pZiR9cuapGJ8MT0ZC qQhvoYzdfprsq7rkPP9YwZaKUC/46ZWjiRyKQJ1yNEYOLY5wPrkMVlUG6okLijl1EAU8 PSGQ== X-Gm-Message-State: ALyK8tI98JMOpoOVcjJVNNxZ1cdawLX+FRrML3ZU2id448wCvhU8M8Y1q1X4lMq9YU0SQA== X-Received: by 10.28.16.193 with SMTP id 184mr8266343wmq.62.1466366739632; Sun, 19 Jun 2016 13:05:39 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id p9sm60058419wjv.21.2016.06.19.13.05.38 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 13:05:38 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: John Wiegley References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> From: Dmitry Gutov Message-ID: <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> Date: Sun, 19 Jun 2016 23:05:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/19/2016 10:56 PM, John Wiegley wrote: > We're thinking about cutting the release candidate in just a few days, pending > one issue that Eli is looking into. Any change -- and I mean _any_ change -- > has the potential to introduce unforeseen effects that could delay us further. By how much? Even if that change causes problems (which is unlikely), we'd only have to revert it, and, unless other issues have come in the meantime, we could build and release Emacs 25.1 right then, more or less. It's not like a regression there has a significant potential to obscure other problems. We've tested the current state of the URL package pretty well by now anyway. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 17:07:30 2016 Received: (at 23750) by debbugs.gnu.org; 19 Jun 2016 21:07:30 +0000 Received: from localhost ([127.0.0.1]:46712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEjwI-0005VA-FB for submit@debbugs.gnu.org; Sun, 19 Jun 2016 17:07:30 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:36340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEjwF-0005Uv-8z for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 17:07:29 -0400 Received: by mail-pf0-f180.google.com with SMTP id t190so47093096pfb.3 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 14:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=/ZR3ZyoZoZxrlVl2ddGsWxXXWy3+urEK7YDhHNG09A4=; b=yOKdSJg93QVgdh9LBi8h0olT99q4azLHw7wEEDkHVl+w4KLd8wzmQ4K5qdxjQLVZVz +FThoAyP0YPdeo3oOiS7LLSHsKFFpVfW8Fdet+G8gr2sUDwzoI14DSxecA3ndQL2gHcP 4Cz3el7OCCiLRYDDveizfw0xoq3asN7hUgfK1kzNdPodPUnlz1gVI464tLSfjvZ0fKdH OwRdU4tNz7l2rmhq8DZoBdbOB7CHWCoLTHFvggCn/l7Uw8jca0FZAOKbxYNI9l5IeVRx uDaKwAxuv50MJljZ3zy0gnsWnTO4Ies8ZxjKyGZkuqeCCOI0Glq5MhlWtDV6Ig8kd1Pb MxLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=/ZR3ZyoZoZxrlVl2ddGsWxXXWy3+urEK7YDhHNG09A4=; b=WAgsWmY86MfIVu7lN+zoJWQqYXHokp7+LOvcRysoR4RNLAQqict7Dqv8R0/Y+EWwxK dL0bDgnrYQMUoELT0hMsb4BM6lzhMgJfN2pMke6v4AKu+bZ5TOXMJkO34z77ikxR9htd lMlACgN/kB3GuofgJkFVaxZBofHk2pYwWkenp5SInnc0Vjpf6UeWNXWJxiG+wzp9MlO0 /r47RDy3qyfRIt1wHgS34XvLIRFOOMZOFIk7wZmClvnBzrCl3Zu3dcWh4XAWl+SjMT2k m2fmRmwZunVs1HP+mQa9BlLuHY3a5ieFY1YSK+pdUTg2Wni/BLxKKbC7WfOng6WY63sJ LWaQ== X-Gm-Message-State: ALyK8tJ6n8hUXcejDhtfYhfNr4c8g4bo0/n34Qx+ygb/sO3hzpkSdIHsPcxoVc2K8knh5g== X-Received: by 10.98.155.218 with SMTP id e87mr17587421pfk.13.1466370441782; Sun, 19 Jun 2016 14:07:21 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id u4sm62972220pfi.53.2016.06.19.14.07.20 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Jun 2016 14:07:20 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 0E93C9D289D; Sun, 19 Jun 2016 14:07:20 -0700 (PDT) To: Dmitry Gutov Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> (Dmitry Gutov's message of "Sun, 19 Jun 2016 23:05:37 +0300") Date: Sun, 19 Jun 2016 14:07:11 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Dmitry Gutov writes: > By how much? >=20 > Even if that change causes problems (which is unlikely), we'd only have to > revert it, and, unless other issues have come in the meantime, we could > build and release Emacs 25.1 right then, more or less. A day comes when a line has to be drawn in the sand, otherwise we could nic= kel and dime ourselves into the next century. That line is drawn; the time for 25.1 is at hand. Let's start thinking about 25.2 as we think about these ty= pes of improvements, and how we might accelerate its release so it happens in 1= -2 months time. There can be many 25.x's, without disrupting the feature work happening on master. =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXZwl/AAoJEMFE2PTxn+YwTFoL/ityDtqq+H+9Lne+/bclDUQm mcP0C3EvH6jKSkY7zBYJcYmYBUAeP0/11t71b+RuYNquxBNDIIOyJFerskgO35GN MFy8GvMOxXBsPQ7hTdd/rCS8v9uxB1059u8lSxnwV7br21PvyZJQ7SRjbhyN8x0E fUll+cJakfKwwsS/wpV6WvdUFxbSqTxBbKXH2UfT+Lz0nkdT6AwjKKeIZcE4yltH d1F/+5xQkeTusYGEc0oddPinKWxvezf8I8m8u9ovHs2sJsYxrWDkALdzXyrkCxEm TqBq2s0XhUeFCTuco8v965vkMujoHIsTnLZI95+HELchl4Cdi0AouhSTkKs5d5Ht gp6+c2B/cGf5BqCS619ZfFYbDlpQQ5jeGx8/caktTQ6UzNWI7wIYjUfpbfLniPNm 6fW7zahPkj3wvH3v76v1NpmDLAvZUHekZSiyQvWn9upm5WQdZoA+QoetQfEXNBGK Z3VUFZjdMjlj+U0QTTJnrq1OSi3jGwMIMxJtA4+prA== =p9uT -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 20:15:58 2016 Received: (at submit) by debbugs.gnu.org; 20 Jun 2016 00:15:58 +0000 Received: from localhost ([127.0.0.1]:46813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEmsg-0001Ko-Is for submit@debbugs.gnu.org; Sun, 19 Jun 2016 20:15:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEmse-0001Ka-2T for submit@debbugs.gnu.org; Sun, 19 Jun 2016 20:15:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEmsY-0002eP-38 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 20:15:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.7 required=5.0 tests=BAYES_40,FREEMAIL_FROM, FSL_HELO_BARE_IP_2,RCVD_NUMERIC_HELO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEmsY-0002eL-09 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 20:15:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEmsW-00010Q-0K for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 20:15:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEmsR-0002db-Pm for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 20:15:46 -0400 Received: from plane.gmane.org ([80.91.229.3]:39801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEmsR-0002dJ-I5 for bug-gnu-emacs@gnu.org; Sun, 19 Jun 2016 20:15:43 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1bEmsO-00085j-F2 for bug-gnu-emacs@gnu.org; Mon, 20 Jun 2016 02:15:40 +0200 Received: from 221.222.148.172 ([221.222.148.172]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Jun 2016 02:15:40 +0200 Received: from sdl.web by 221.222.148.172 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 20 Jun 2016 02:15:40 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Leo Liu Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el Date: Mon, 20 Jun 2016 08:15:26 +0800 Lines: 17 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 221.222.148.172 Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (OS X 10.11.5) Cancel-Lock: sha1:4XeCojulaRVlYuy6Dv8iPZa1p1Q= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) On 2016-06-19 21:36 +0300, Dmitry Gutov wrote: > This particular bug came from this: > > "Content-length: " (number-to-string (length url-http-data)) > > Which gives wrong value when url-http-data is multibyte (it should be > length in bytes). So then, the HTTP server on the other side saw the > wrong body length and truncated the body when reading the request. As Dmitry mentioned earlier json-encode in 25.1 produces multibyte strings and makes it easier to hit this bug when consuming JSON API's. There are three parties that are suspicious: 1) JSON API server 2) JSON.el 3) URL. It took me a while to realise it's URL's fault IOW the bug isn't easy to debug. This is somewhat related to changes brought in by 25.1. Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 21:27:00 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 01:27:00 +0000 Received: from localhost ([127.0.0.1]:46829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEnzQ-0002zc-79 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 21:27:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEnzO-0002zP-55 for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 21:26:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEnzI-0005TC-9h for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 21:26:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEnzA-0005Sq-CF; Sun, 19 Jun 2016 21:26:44 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bEnz7-0000gV-3R; Sun, 19 Jun 2016 21:26:41 -0400 From: Glenn Morris To: John Wiegley Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> X-Spook: enigma Secure Border Initiative nitrate FEMA Drug X-Ran: 5ahz0e8sQ3I7*7B!e889Snq1[IOU_9iP#aGc.)Lb2DQXr|>6}>-d: (John Wiegley's message of "Sun, 19 Jun 2016 12:56:23 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) John Wiegley wrote: > We're thinking about cutting the release candidate in just a few days Please see admin/release-process for some tasks that should happen before that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 21:28:40 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 01:28:40 +0000 Received: from localhost ([127.0.0.1]:46833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEo12-00032A-JV for submit@debbugs.gnu.org; Sun, 19 Jun 2016 21:28:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEo10-00031x-9v for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 21:28:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEo0u-0005vM-Et for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 21:28:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD, UNRESOLVED_TEMPLATE autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEo0o-0005uq-St; Sun, 19 Jun 2016 21:28:26 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bEo0n-0003Vg-5I; Sun, 19 Jun 2016 21:28:25 -0400 From: Glenn Morris To: John Wiegley Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> X-Spook: Weapons grade Task Force data haven Chemical burn Forest X-Ran: t34LqQkwAu;7C5b2;m{"Q["o(9.uoRrLHX&m/S03/.e(54`!;MuR (John Wiegley's message of "Sun, 19 Jun 2016 14:07:11 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) John Wiegley wrote: > There can be many 25.x's, without disrupting the feature work > happening on master. Then why is master STILL advertising itself as the forerunner to 25.2? Why are we closing a bunch of bugs as "fixed in 25.2" if they won't be fixed till 26.1? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 22:41:19 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 02:41:19 +0000 Received: from localhost ([127.0.0.1]:46859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEp9L-0004gg-7B for submit@debbugs.gnu.org; Sun, 19 Jun 2016 22:41:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEp9J-0004gU-E0 for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 22:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEp9D-0000I6-3A for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 22:41:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:36794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEp97-0000GI-Rr; Sun, 19 Jun 2016 22:41:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3072 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEp95-00009n-Qv; Sun, 19 Jun 2016 22:41:04 -0400 Date: Mon, 20 Jun 2016 05:40:17 +0300 Message-Id: <83h9co8twu.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Sun, 19 Jun 2016 21:36:25 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Sun, 19 Jun 2016 21:36:25 +0300 > > This particular bug came from this: > > "Content-length: " (number-to-string (length url-http-data)) > > Which gives wrong value when url-http-data is multibyte (it should be > length in bytes). So then, the HTTP server on the other side saw the > wrong body length and truncated the body when reading the request. Or > something along these lines. So this is not a bug in Emacs, but a diagnostic facility to let bugs in applications be discovered? > > IME, neither string-to-unibyte not > > string-as-unibyte should ever be used in applications, their use is > > more often than not a sign of some basic misunderstanding of text > > encoding. For starters, how come 8-bit bytes wind up in that > > function, and what do they stand for? > > Some 8-byte encoding of the HTTP request body. > > Anyway, yes, the hope is that the programmer uses something like > encode-coding-string to produce that value (and picks the encoding, and > indicates it in the appropriate HTTP header). Then string-to-unibyte > will simply be a no-op. But we need to catch the case when they don't, > and this seems to be the easiest way to do this. If this is what you need, why not simply test the payload for being a unibyte string? There a function, multibyte-string-p, for that. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 22:51:17 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 02:51:17 +0000 Received: from localhost ([127.0.0.1]:46864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEpIz-0004vG-76 for submit@debbugs.gnu.org; Sun, 19 Jun 2016 22:51:17 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEpIw-0004v2-QN for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 22:51:15 -0400 Received: by mail-wm0-f42.google.com with SMTP id r201so42110856wme.1 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 19:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=q9g0cM1csnC5aYD7OeGztnka9y4R6FEHWZi5g1JL1aM=; b=veMOF1aX+KB7Vp0VVwt6iL7n3Tmn6aVa/NCw1gFeEoOWcRp1qqbivf/IrJ+DIh8ZIf Ro585UAusj7GQiTwuD1og38DW6cZYCP/hZBsdIlGK9R7zuM0bu5e5Q+Mt2K86VhDnyMk tfyy1VjhnNWgi/wQkOB/QoE7HvY9jF53nQM4yFyFHkde5WBmoW66NhgTFHlsNIhW9cVu cC4RDxeoBVpGF0qe3fTvDx28HIGRQJ8hmvBgWmQqdTldXLZFsK6b8TIt3ceyD8US0a6J fWhEwsjCngoSJ9ZCjcVKN3dJTbu0IEHPWPGW0xIFY6+dVdQwjI2ISUj7IkWqIVJFYeLN Updw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=q9g0cM1csnC5aYD7OeGztnka9y4R6FEHWZi5g1JL1aM=; b=XzfNRczzD9glHBhvTYiJm6BX0JEkY9LnzaKEmNEfd5r18Xjwyt1YgwfYxAEFVVvOTl C3scz7qw59mdBIY8fGisw+U7grXor0QGLv4KoJ1S4ptInL2Eda++rGhHMLuTDnD5bi/n G3GT0Resk5xQocPgeqKNbVSxakecLrJjF1FyNxQy1+6xvHJYtUqTB/dJh7qfvV2LnSOG +qNP3qvbhGAga6Dwk/TH+Jfad+PWNQEDpGpnlRurP180VyYbwm1yl7V1J+AvnU7cyuFQ 2x367ePqO0FWU/ZNjECfsFb89vai02Xh9+DOFmahw41XDY1GCUnWA83XMcAyRhX+mKB5 Jvww== X-Gm-Message-State: ALyK8tJObgJEDbtwBu2yOQIEg5sradhqcbDQu1fbz2l+C/DbyaPFtt5t8DwA35WJs7qhfQ== X-Received: by 10.28.209.13 with SMTP id i13mr9315115wmg.93.1466391068811; Sun, 19 Jun 2016 19:51:08 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id m5sm913014wmm.10.2016.06.19.19.51.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Jun 2016 19:51:08 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Mon, 20 Jun 2016 05:51:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83h9co8twu.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/20/2016 05:40 AM, Eli Zaretskii wrote: > So this is not a bug in Emacs, but a diagnostic facility to let bugs > in applications be discovered? It's a bug. Accepting invalid input and behaving badly with it is definitely a bug. > If this is what you need, why not simply test the payload for being a > unibyte string? There a function, multibyte-string-p, for that. There are a lot of variables to test (see the comment above the mapconcat call). I'm fine either way, but my patch changes two characters, and yours will be longer. And you'll have to come up with the error message(s). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 19 22:58:27 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 02:58:27 +0000 Received: from localhost ([127.0.0.1]:46868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEpPv-00056K-BP for submit@debbugs.gnu.org; Sun, 19 Jun 2016 22:58:27 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:33363) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEpPt-000560-V5 for 23750@debbugs.gnu.org; Sun, 19 Jun 2016 22:58:26 -0400 Received: by mail-wm0-f53.google.com with SMTP id r190so7784020wmr.0 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 19:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=/anQuBTdqh6nvg8zUsR+aU4OPQgL4T3hPgf18Iu2Bys=; b=hnuqu85C0BmTAcCRy9rlVhnGy88T6OxVUtvNtyswAlVM6DHYeZc2lic6wYEBCNVNi2 D9vAO7AwcIIv+CJYuWpx6TFlhnDyIUrM3Z6ByeLfX0JY+e0pLt2ILyC/6z6KhF9Ba2XT IW4mCuPRCCkD35It5trtEjEIMGHT7aWQFPVLaMwrCNrYPgvzG28OwRfxU52VD6RdC+Ry TE+cveijKJKzcQ2P3SXuHpmXH5FiZVBhIwJIc7+tMd+sWfF66sOsKfS8+aZnx71Hsxg2 8GmBpc3biC8m3BrdMNeY4QURIQJRumqio+kTgNSqwb1R4rDAcGJdF04UHGrGxUARl+n1 LLUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=/anQuBTdqh6nvg8zUsR+aU4OPQgL4T3hPgf18Iu2Bys=; b=JasFf2AROa14PEG5DFKCSbY11ZaHgwjS+vT2OEBbCIP4HhSdsJasPQd+E1mRg60dut 1ydV5CndfpAUCHIUUXOORV1GPsiBFa3g9fnEAeNaZsjI4I8kyOQMK4FPay5ZYaOMgiVH zjbXMekxI48aX84weBDKix2/k6AC9TiUFNDTEv9M7k3W4K0Penqe2B6zD0XFGVG0Xxzu Y63OoT3dNOUnGvYiyUaNuDsYUCG96HzAUYKwW6qFWtvMJnNz0nsIKESfndLFmbJVCZyE RMvqD2gUSYqwlYwzVzzPVtTxtiW3CXvZOsJYXfGzxfFZuALc32+UCAIxh4IrgjIECw1j xrOA== X-Gm-Message-State: ALyK8tKjVRPZMjbrNbuUyUrjqtncqikMHDfYYRUeA1jngO3AM1HfYepfsn8OgpBfff7TbQ== X-Received: by 10.28.10.66 with SMTP id 63mr9078682wmk.54.1466391500299; Sun, 19 Jun 2016 19:58:20 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id ag3sm20544618wjc.39.2016.06.19.19.58.18 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 19 Jun 2016 19:58:19 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: John Wiegley References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> From: Dmitry Gutov Message-ID: <03c139e5-68f3-c9f3-9994-6a489baf35df@yandex.ru> Date: Mon, 20 Jun 2016 05:58:18 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Eli Zaretskii , sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/19/2016 10:56 PM, John Wiegley wrote: > We're thinking about cutting the release candidate in just a few days, pending > one issue that Eli is looking into. Do you mean bug#23779? I wouldn't call it critical (judging by the number of years it went unreported), and it's not a regression, so it doesn't make a lot of sense to fix it without taking care of the bug that resulted in it being reported (bug#23769). From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 00:22:37 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 04:22:37 +0000 Received: from localhost ([127.0.0.1]:46909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEqjM-000747-Rh for submit@debbugs.gnu.org; Mon, 20 Jun 2016 00:22:37 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:33749) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEqjL-00073u-9f for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 00:22:35 -0400 Received: by mail-pa0-f46.google.com with SMTP id b13so46693175pat.0 for <23750@debbugs.gnu.org>; Sun, 19 Jun 2016 21:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=kAi+D71AXD8gBTNk+8hqbsRVlqkMDi8vrt1kzK1fi0g=; b=e1zCBjSl/MSLE+pI+d6wdJVW9PMwlgyUmQaZTSc5lYG+DraS3vA73KynVT8k/pBsSw UJ/ED1zvWHZ50sI3JsN8g18MmGnmqJzb3282rwABQ/mn8hWMN5SBzfFanUCgrkQ1f+Ii x94Is/8ztMUMIQ6v1BfOHN03CRoJO5iuztpTF7NeEl+OzF7aWds5g+W5ov7cIUuC5FAu c31mqbhDeAwnkkBA7jgD5xrN0TEs/x219P6eVdP5pEDOuCNoTjTd45cCvLf19a4Sp6gc bUELhHvNO61+AqVwaL1f0r0FavdHzBT09lIkL/KaLSgnsZx/qBqHjj0rKJLme2cbGhlH nyUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=kAi+D71AXD8gBTNk+8hqbsRVlqkMDi8vrt1kzK1fi0g=; b=Q7vqRMgPTpHvK0C996RNRdrmQvDcjhO8o4M0nwmzk8OKkD6+bYvNE+5ZaAPegos7gy I+GCChAvaOtKcJNuO4z+ncXRbW9ibHChKxgezjaZuhhTRfhocMXotfbenOLrAIfx163b MynYUoCUrOVNLlGgbOzGbT+x882cBVU2a+ZykwoCEzUETBOpfgVsu3DmX63r5hPOq/Rx x6SegXi0gCZlaVVWgMRQhwM5Pk7glOWUbMgDHLUnG6TKonLiPHGz1h6FCtmALbZXhgyH Y+er1fZrq+DQkQ368oi4RYMHWyqvFzziw3ICJlb8iniSJDVbqmu9s/saJ0m6wZCtxorm DHUw== X-Gm-Message-State: ALyK8tKOD0l6Nc/p8y07YGGHQ9Hv4hQqOyaMzupbXSV1mxTspiH42TJyaTLc5LzYekemQw== X-Received: by 10.66.139.133 with SMTP id qy5mr19678519pab.4.1466396549393; Sun, 19 Jun 2016 21:22:29 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id k74sm71858741pfk.78.2016.06.19.21.22.28 (version=TLS1 cipher=AES128-SHA bits=128/128); Sun, 19 Jun 2016 21:22:28 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id DB2A49D6B30; Sun, 19 Jun 2016 21:22:27 -0700 (PDT) To: Glenn Morris Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: (Glenn Morris's message of "Sun, 19 Jun 2016 21:28:24 -0400") Date: Sun, 19 Jun 2016 21:22:25 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >>>>> Glenn Morris writes: > Then why is master STILL advertising itself as the forerunner to 25.2? Why > are we closing a bunch of bugs as "fixed in 25.2" if they won't be fixed > till 26.1? I guess to avoid having the reported version number in bug reports keep jumping around? Master is really working toward 26.1 at this point. Once we start working on 25.2, we should cherry-pick over all the fixes for bugs are marked "fixed in 25.2". Otherwise, they should be marked "fixed in 26.1". -- John Wiegley GPG fingerprint = 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 09:16:23 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 13:16:23 +0000 Received: from localhost ([127.0.0.1]:47211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEz3v-0004Fy-H9 for submit@debbugs.gnu.org; Mon, 20 Jun 2016 09:16:23 -0400 Received: from bouvier.getmail.no ([84.210.184.8]:39354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEz3u-0004Fk-GW for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 09:16:23 -0400 Received: from localhost (localhost [127.0.0.1]) by bouvier.getmail.no (Postfix) with ESMTP id ADA5E48F0E; Mon, 20 Jun 2016 14:39:03 +0200 (CEST) Received: from bouvier.getmail.no ([127.0.0.1]) by localhost (bouvier.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xVrcYfwxJm0s; Mon, 20 Jun 2016 14:39:03 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by bouvier.getmail.no (Postfix) with ESMTP id 3400348F07; Mon, 20 Jun 2016 14:39:03 +0200 (CEST) X-Virus-Scanned: amavisd-new at bouvier.get.c.bitbit.net Received: from bouvier.getmail.no ([127.0.0.1]) by localhost (bouvier.get.c.bitbit.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id b5Z2e0z6pyOT; Mon, 20 Jun 2016 14:39:03 +0200 (CEST) Received: from mouse (cm-84.215.1.64.getinternet.no [84.215.1.64]) by bouvier.getmail.no (Postfix) with ESMTPS id EF08548F39; Mon, 20 Jun 2016 14:39:02 +0200 (CEST) From: Lars Ingebrigtsen To: John Wiegley Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> Date: Mon, 20 Jun 2016 14:39:02 +0200 In-Reply-To: (John Wiegley's message of "Sun, 19 Jun 2016 21:22:25 -0700") Message-ID: <87vb14t4pl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Glenn Morris , sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) John Wiegley writes: >>>>>> Glenn Morris writes: > >> Then why is master STILL advertising itself as the forerunner to 25.2? Why >> are we closing a bunch of bugs as "fixed in 25.2" if they won't be fixed >> till 26.1? > > I guess to avoid having the reported version number in bug reports keep > jumping around? Master is really working toward 26.1 at this point. > > Once we start working on 25.2, we should cherry-pick over all the fixes for > bugs are marked "fixed in 25.2". Otherwise, they should be marked "fixed in > 26.1". Most bugs fixed in master are marked "fixed in 25.2" (since that is what master is announcing itself as being the forerunner to), so that doesn't make much sense, I'm afraid. Which is what Glenn is telling us, once again. I really don't understand why master hasn't been changed to say that it's the forerunner to 26.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 10:39:48 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 14:39:48 +0000 Received: from localhost ([127.0.0.1]:47822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0Md-0006MW-Te for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:39:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0Mb-0006MG-F8 for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:39:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0MU-00055P-GJ for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:39:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0MM-00051j-Cz; Mon, 20 Jun 2016 10:39:30 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3425 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF0MK-0007iX-E4; Mon, 20 Jun 2016 10:39:28 -0400 Date: Mon, 20 Jun 2016 17:38:35 +0300 Message-Id: <838ty07wno.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Mon, 20 Jun 2016 05:51:06 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Mon, 20 Jun 2016 05:51:06 +0300 This all sounds like my response is not welcome, but in that case why did you ask the question? Anyway: > So this is not a bug in Emacs, but a diagnostic facility to let bugs > in applications be discovered? > > It's a bug. Accepting invalid input and behaving badly with it is definitely a bug. No, the bug is where the invalid input is generated in the first place. Each API has its contract; if you violate the contract, you invoke undefined behavior. > If this is what you need, why not simply test the payload for being a > unibyte string? There a function, multibyte-string-p, for that. > > There are a lot of variables to test (see the comment above the mapconcat call). Looks like mapc will be able to deal with that. Or just use concat, and test the result with multibyte-string-p before sending. Or encode it with UTF-8, if it is not unibyte already. Btw, I don't think the comment which explains why we started using mapconcat is accurate these days. It was written before the move to Unicode in Emacs 23, but we stopped converting raw bytes into Latin-1 characters in Emacs 23 and later. So maybe we should just go back to using concat (with erroring out, if the result is multibyte, and/or maybe with replacing 'length' with 'string-bytes'). Bottom line: like I said, there should be no reason to use string-*-unibyte in modern Emacs code on the url-http level or higher (maybe not at all). Its use is a sign of some basic misunderstanding, or a bug elsewhere, or remnant of old problems that no longer exist. So I think we should reconsider the solution on master as well. > I'm fine either way, but my patch changes two characters, and yours will be longer. I don't think the quality of a change should be judged by the number of characters in the patch. That is a very strange criterion, to say the least. It would mean, for example, that changes with comments are worse than changes without comments, or that saving newlines in C code (which makes the code less readable) is a virtue. > And you'll have to come up with the error message(s). Are you saying you like the error message from string-to-unibyte? Cannot convert 123th character to unibyte Doesn't really strike me as something that a user or an average developer will understand. I thought you wanted something more human-readable, like Invalid multibyte text in HTTP request %s From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 10:40:07 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 14:40:07 +0000 Received: from localhost ([127.0.0.1]:47826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0Mx-0006NU-85 for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:40:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0Mw-0006Mq-7s for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:40:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0Mo-0005Dx-IW for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:40:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0Mo-0005DO-F2; Mon, 20 Jun 2016 10:39:58 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3426 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF0Mm-0007lP-MD; Mon, 20 Jun 2016 10:39:57 -0400 Date: Mon, 20 Jun 2016 17:39:04 +0300 Message-Id: <837fdj9b7b.fsf@gnu.org> From: Eli Zaretskii To: Leo Liu In-reply-to: (message from Leo Liu on Mon, 20 Jun 2016 08:15:26 +0800) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Leo Liu > Date: Mon, 20 Jun 2016 08:15:26 +0800 > > > This particular bug came from this: > > > > "Content-length: " (number-to-string (length url-http-data)) > > > > Which gives wrong value when url-http-data is multibyte (it should be > > length in bytes). So then, the HTTP server on the other side saw the > > wrong body length and truncated the body when reading the request. > > As Dmitry mentioned earlier json-encode in 25.1 produces multibyte > strings and makes it easier to hit this bug when consuming JSON API's. > There are three parties that are suspicious: 1) JSON API server 2) > JSON.el 3) URL. It took me a while to realise it's URL's fault IOW the > bug isn't easy to debug. This is somewhat related to changes brought in > by 25.1. I understand that url-http expects unibyte strings. So my suggestion is to test that, and signal an error if the requirement is violated, with an error message text that could be understood by users and developers. Alternatively, we could encode multibyte strings in UTF-8, if we want to attempt to silently cope with such strings. In any case, using string-*-unibyte functions for that is not needed, and I'm quite sure their use in this case is a left-over from an era long gone. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 10:43:48 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 14:43:48 +0000 Received: from localhost ([127.0.0.1]:47830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0QV-0006SP-Q5 for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:43:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38551) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0QT-0006SB-Vo for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:43:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0QI-00065a-NP for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:43:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0Q3-00060T-8Y; Mon, 20 Jun 2016 10:43:19 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3428 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF0Q0-0008DP-LK; Mon, 20 Jun 2016 10:43:17 -0400 Date: Mon, 20 Jun 2016 17:42:23 +0300 Message-Id: <834m8n9b1s.fsf@gnu.org> From: Eli Zaretskii To: John Wiegley In-reply-to: (message from John Wiegley on Sun, 19 Jun 2016 21:22:25 -0700) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, rgm@gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: John Wiegley > Date: Sun, 19 Jun 2016 21:22:25 -0700 > Cc: 23750@debbugs.gnu.org, Dmitry Gutov , sdl.web@gmail.com, > monnier@IRO.UMontreal.CA > > Once we start working on 25.2, we should cherry-pick over all the fixes for > bugs are marked "fixed in 25.2". I don't think this is practical. The only practical way is to cut a new release branch off master. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 10:54:33 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 14:54:33 +0000 Received: from localhost ([127.0.0.1]:47840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0av-0008JN-4r for submit@debbugs.gnu.org; Mon, 20 Jun 2016 10:54:33 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0at-0008JB-7Y for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 10:54:31 -0400 Received: by mail-wm0-f49.google.com with SMTP id r201so65639197wme.1 for <23750@debbugs.gnu.org>; Mon, 20 Jun 2016 07:54:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=puE6F8XzaIMmszW/qvW72AUsM69VHf9ISD3zoC1zZbY=; b=FFcyBL688Y7AOdtafR40R6era2NMT4quulVtoABszKN3eu2nZVoqjLErILeO4uS0H9 DItXc+7fOY1+RQxGyuCFrBI/YnwVLIGgkcGQ83eqQP8hzMWWrv6gMF+a2/LR1hnBjYZo /W+JfoHVTqip9QBxGeqSpano+MrI2ZpbGBmuOLfDaga6Eru+aPrZVKp9slKuCRpvihD7 QcjTpcX8+ishJpwP0bNYdC/CqyUAp5Wxwda5iyC3YZiz9NaMwlosxntInmfe4DWzvp/o LB53SOo8nuFjHQYBdLGdApx+1o8GP/ljXPzz+T0So8LdOKuo9mUKFWFhVGRe02PWy1zE Q1NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=puE6F8XzaIMmszW/qvW72AUsM69VHf9ISD3zoC1zZbY=; b=ODpahLHcvXtHw4LZ3SfILQCchwhMCXcW2jbqgRErhzRmcNEJkxu12Z6j52lteAM4j1 BAXUFBPfSuMGrIdWaO1YSTGFUzddMUBkQWeVpTLpzkF1i49OOAEpVlTWhitbcH5ypip5 92kXxmurSsFoEktQJs0pbbRL72YU0+/iTrid9Ylbo1JExovK8T2OU/Q5DcwFFnh8qZus C6/WS9DDfGUE28WrX/+iAQimg/jmPkz5yu1lqsOEo0fszYHO/dxdhzNtzfcNTxXSUqPO AiyEITm8U97dse9kPUtKEIJWLRqr61jPkKjY20lfgh4ATzU40PkXboZ2Y/DBtkDiIpS1 xANQ== X-Gm-Message-State: ALyK8tJME1NKDF6p/bhoTodGZzDqbbm/YzR20Boi8RcUsm687OaXyOPGwUDKssI3jmPHeA== X-Received: by 10.194.94.69 with SMTP id da5mr9301421wjb.158.1466434465506; Mon, 20 Jun 2016 07:54:25 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id r127sm7971130wmf.21.2016.06.20.07.54.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Jun 2016 07:54:24 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> From: Dmitry Gutov Message-ID: <367c9750-4aaa-e7cd-1a1a-1a61107fbb12@yandex.ru> Date: Mon, 20 Jun 2016 17:54:23 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <838ty07wno.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/20/2016 05:38 PM, Eli Zaretskii wrote: > This all sounds like my response is not welcome, but in that case why > did you ask the question? I was kind of hoping for "yes, let's get it into 25.1!"? :) > No, the bug is where the invalid input is generated in the first > place. Each API has its contract; if you violate the contract, you > invoke undefined behavior. It's a bug in the API, or bad API, if you will. It needs stricter contract, and the submitted patch added it. Or to look at it another way, the current contract allows url-http-data to be multibyte, because the requirement to the contrary is not documented anywhere that I can see. The variable is simply undocumented. >> If this is what you need, why not simply test the payload for being a >> unibyte string? There a function, multibyte-string-p, for that. >> >> There are a lot of variables to test (see the comment above the mapconcat call). > > Looks like mapc will be able to deal with that. Or just use concat, > and test the result with multibyte-string-p before sending. Or encode > it with UTF-8, if it is not unibyte already. I don't know if we want to be that permissive that we'll encode to UTF-8 silently. > Btw, I don't think the comment which explains why we started using > mapconcat is accurate these days. It was written before the move to > Unicode in Emacs 23, but we stopped converting raw bytes into Latin-1 > characters in Emacs 23 and later. So maybe we should just go back to > using concat (with erroring out, if the result is multibyte, and/or > maybe with replacing 'length' with 'string-bytes'). Better error out: the payload's encoding is something only the caller should be concerned with. Unless we're fine with the users assuming that Emacs's internal encoding is close enough to UTF-8. > Bottom line: like I said, there should be no reason to use > string-*-unibyte in modern Emacs code on the url-http level or higher > (maybe not at all). Its use is a sign of some basic misunderstanding, > or a bug elsewhere, or remnant of old problems that no longer exist. > So I think we should reconsider the solution on master as well. I don't mind. Would you advocate for having this fix on emacs-25 if I implement it the way you described? >> And you'll have to come up with the error message(s). > > Are you saying you like the error message from string-to-unibyte? > > Cannot convert 123th character to unibyte It's an order of magnitude better than what was before (no error and silent corruption), but yes, there is space for improvement. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 11:04:42 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 15:04:42 +0000 Received: from localhost ([127.0.0.1]:47848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0kk-00006d-Ee for submit@debbugs.gnu.org; Mon, 20 Jun 2016 11:04:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF0ki-00006P-Ju for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 11:04:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF0kX-0002lS-R5 for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 11:04:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF0kQ-0002jC-Dg; Mon, 20 Jun 2016 11:04:22 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3447 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF0kM-00033N-7m; Mon, 20 Jun 2016 11:04:18 -0400 Date: Mon, 20 Jun 2016 18:03:25 +0300 Message-Id: <83ziqf7via.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <367c9750-4aaa-e7cd-1a1a-1a61107fbb12@yandex.ru> (message from Dmitry Gutov on Mon, 20 Jun 2016 17:54:23 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <367c9750-4aaa-e7cd-1a1a-1a61107fbb12@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Mon, 20 Jun 2016 17:54:23 +0300 > > On 06/20/2016 05:38 PM, Eli Zaretskii wrote: > > > This all sounds like my response is not welcome, but in that case why > > did you ask the question? > > I was kind of hoping for "yes, let's get it into 25.1!"? :) I'm not that kind of guy, as you know ;-) > > Bottom line: like I said, there should be no reason to use > > string-*-unibyte in modern Emacs code on the url-http level or higher > > (maybe not at all). Its use is a sign of some basic misunderstanding, > > or a bug elsewhere, or remnant of old problems that no longer exist. > > So I think we should reconsider the solution on master as well. > > I don't mind. Would you advocate for having this fix on emacs-25 if I > implement it the way you described? A single test and an error message is safe enough to go to emacs-25, yes. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 13:16:47 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 17:16:47 +0000 Received: from localhost ([127.0.0.1]:47964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF2oY-0006RH-Qy for submit@debbugs.gnu.org; Mon, 20 Jun 2016 13:16:47 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:38904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF2oX-0006R4-QC for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 13:16:46 -0400 Received: by mail-wm0-f44.google.com with SMTP id r201so71254022wme.1 for <23750@debbugs.gnu.org>; Mon, 20 Jun 2016 10:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=C8NtJD1/lTwdD7GyDD1hiBPCuExXzXN7FgcYHltWwiE=; b=x1umqVTpfNTjAIZb1TP7MI3OAyX02yDWbRnNs4z4nRwAehiLa+8GCFEIvtE6sifPcQ AkCZvtVb3+XaaXQt9VGK3epJwl26hDzNzJ6e/GaLN8bA1W30O4E4O/XPrFrZXJOQOfL3 ofxtlsUfuP0+qaV0+7H2ooqaAFJ8zQq9ARf4+moS7OvzK3vWcuAxsdI9rnbOyxNzOKcC RoamPdfJsVYctcnRW6u+BP5PKij1eZwjazhgUKWuPCbsFqpQjaV6S3XDPH4ZUx8qzXxm ttiunGcCPM2vM+InC6jHh/nAxaxrAidN9LA6jKnfk47XFSZcZ2h6eh4BJTAVTgbXZbCd egPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=C8NtJD1/lTwdD7GyDD1hiBPCuExXzXN7FgcYHltWwiE=; b=HtQOw4HxKU9gEfx8LXcldObSGQsZB/ZQgHEIRlDitvTWN77w+BFNat7VHoO1uOBlnK /YHedS8+GZ3cBCRSb5xzKfiXR+gbb/4tVWL0BdhsfWz0N2jvajgXutuOujaylEbSwFyj qyRdSm/65CbNWmXzZOT+/O2iaZ+7+v9zzyOqF5fGiQl001fhvvCT0BxbblW0Jyj7Efvg hOLGDMTDH6lSfGdX+hFcPEbncS2LIgeX+1y2G7ntm8CCvwEAsznOzCK6Dbf0V6iApukU B61OAvqZehLELsu7h+eS24UD/k6CNY1bEQobuoiKDPKBJoJ05V8PiR3tSFaX7/mq6Ls8 wnYQ== X-Gm-Message-State: ALyK8tKh3hItQX/B7t652e781SfUv59IxEjMIEG6Oqixhh+D+EUGBrzhLsNp5n9hcWMW4w== X-Received: by 10.194.8.38 with SMTP id o6mr13347203wja.13.1466443000235; Mon, 20 Jun 2016 10:16:40 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id li10sm20039774wjb.5.2016.06.20.10.16.38 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2016 10:16:39 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> From: Dmitry Gutov Message-ID: Date: Mon, 20 Jun 2016 20:16:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <838ty07wno.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/20/2016 05:38 PM, Eli Zaretskii wrote: > Or just use concat, > and test the result with multibyte-string-p before sending. Actually, here's a reason why we might prefer not to replace string-as/to-unibyte with multibyte-string-p: string-to-unibyte works fine if the string's contents only contain ASCII/8-bit characters, even if the string itself is multibyte. But multibyte-string-p returns nil for such strings anyway. So doing like you suggest might make some (arguably not well-written) programs fail, which otherwise could function fine, provided they only operate on ASCII strings. And having a multibyte string with ASCII-only contents is fairly common when the string is produced with buffer-substring from a source code buffer. While it might be good to discourage this kind of programming practice (that doesn't handle non-ASCII text properly), it seems like this would be better for master rather that the impending release. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 16:19:25 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 20:19:25 +0000 Received: from localhost ([127.0.0.1]:48069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF5fJ-0002Gd-FJ for submit@debbugs.gnu.org; Mon, 20 Jun 2016 16:19:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF5fH-0002GO-GO for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 16:19:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bF5fB-0004de-Fc for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 16:19:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53421) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bF5f3-0004bC-Kk; Mon, 20 Jun 2016 16:19:09 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3838 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bF5f0-0006GX-7u; Mon, 20 Jun 2016 16:19:09 -0400 Date: Mon, 20 Jun 2016 23:17:59 +0300 Message-Id: <83r3br7gy0.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: (message from Dmitry Gutov on Mon, 20 Jun 2016 20:16:37 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Mon, 20 Jun 2016 20:16:37 +0300 > > On 06/20/2016 05:38 PM, Eli Zaretskii wrote: > > > Or just use concat, > > and test the result with multibyte-string-p before sending. > > Actually, here's a reason why we might prefer not to replace > string-as/to-unibyte with multibyte-string-p: string-to-unibyte works > fine if the string's contents only contain ASCII/8-bit characters, even > if the string itself is multibyte. But multibyte-string-p returns nil > for such strings anyway. We can replace the call to multibyte-string-p with a comparison of what 'length' and 'string-bytes' return. That should overcome this issue. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 16:27:14 2016 Received: (at 23750) by debbugs.gnu.org; 20 Jun 2016 20:27:15 +0000 Received: from localhost ([127.0.0.1]:48087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF5ms-0002Tc-PL for submit@debbugs.gnu.org; Mon, 20 Jun 2016 16:27:14 -0400 Received: from mail-lb0-f172.google.com ([209.85.217.172]:36147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bF5mr-0002TP-0L for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 16:27:13 -0400 Received: by mail-lb0-f172.google.com with SMTP id ak10so674595lbc.3 for <23750@debbugs.gnu.org>; Mon, 20 Jun 2016 13:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=z4mMv1Wt59yCcMrNUCXEjXp6FU9a8120JaJ0a0yOs/8=; b=qxG2d6ulXsCKcE42r/Pt9YiSUUyAUh5+UEXQ6QMyfatX05Yrjr+mFgCKYd0HJh5bPN wjGntAnLQvGtRq2pQ/q5hRVFiMchygrqCMz1eTi5/YUkSp6D07af86YLDWYNSfk/5Pmt coQ+ruiJemw8s+YCD45TK9ccDuP4zCaHLMUw91arNTZnh0yv2/QT6UBRAVXdD12Raa5u AAcxHb5l2EOmfpCQPgYBP9mFJwX88PDmzX0UI93kewDjJTo6DXJYA8T2Y2sEeBr7K+RB EUX768aidIB6o24pQQrOP/L/tWKEpp7IT9sXvBJLVp88sGkgx+nVs9qd2x2GFwORDOth nVkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=z4mMv1Wt59yCcMrNUCXEjXp6FU9a8120JaJ0a0yOs/8=; b=Y/sF+1c5+FTjuoEkinFLpAX2pL32kJ8WtWXjAJszsueLQkc0HAsRURn+xUZtVHZ4mT NRsvrE7bimYJJExje3ZKi8efjIicSkL2XSGu1mmXN+xAeYM9v6pjYeDecrJcY9uYQm03 Vpk71mK/58KrhZgDUkOY8MVK7RDwFoJGnCW8QtImMxrLjm33uWq/9B/FwpObvfgUNviS N/EUFuGU6FFpQ06gqxVrT1tCWHpwnn/po/LmY+QFTwSoo4/ciw7+4F98uHkuoju+fVbv oi3rv1uwNkI0jpsfTMiTNFb/1h39xRT5dUBW/hHiagthimuOYCyymgr9z/Wx4hVF6FDe 7jqg== X-Gm-Message-State: ALyK8tKg6+HbU2xCBKeyWMawxP9Z/4KE0bd4/iuVS2sgGA389Zry4wKPjLl7SObQX1Bhqw== X-Received: by 10.194.120.167 with SMTP id ld7mr17525204wjb.69.1466454424190; Mon, 20 Jun 2016 13:27:04 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id a4sm42606435wjq.40.2016.06.20.13.27.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 20 Jun 2016 13:27:03 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> From: Dmitry Gutov Message-ID: <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> Date: Mon, 20 Jun 2016 23:27:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83r3br7gy0.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 06/20/2016 11:17 PM, Eli Zaretskii wrote: > We can replace the call to multibyte-string-p with a comparison of > what 'length' and 'string-bytes' return. That should overcome this > issue. Why not just call string-to-unibyte? To you expect different results? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 20 22:31:11 2016 Received: (at 23750) by debbugs.gnu.org; 21 Jun 2016 02:31:11 +0000 Received: from localhost ([127.0.0.1]:48209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFBT5-0002O7-Hi for submit@debbugs.gnu.org; Mon, 20 Jun 2016 22:31:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFBT3-0002Nu-Mr for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 22:31:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFBSx-0007V1-P3 for 23750@debbugs.gnu.org; Mon, 20 Jun 2016 22:31:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFBSs-0007U8-55; Mon, 20 Jun 2016 22:30:58 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4080 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFBSq-0008PE-3u; Mon, 20 Jun 2016 22:30:56 -0400 Date: Tue, 21 Jun 2016 05:30:04 +0300 Message-Id: <83porb6zpv.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov In-reply-to: <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> (message from Dmitry Gutov on Mon, 20 Jun 2016 23:27:01 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Mon, 20 Jun 2016 23:27:01 +0300 > > On 06/20/2016 11:17 PM, Eli Zaretskii wrote: > > > We can replace the call to multibyte-string-p with a comparison of > > what 'length' and 'string-bytes' return. That should overcome this > > issue. > > Why not just call string-to-unibyte? Because (a) I don't want to see that function in our sources, ever, and (b) you don't have any control on the error message it produces, which is not appropriate for application-level checks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 09:52:09 2016 Received: (at 23750) by debbugs.gnu.org; 21 Jun 2016 13:52:10 +0000 Received: from localhost ([127.0.0.1]:48836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM65-00049R-N8 for submit@debbugs.gnu.org; Tue, 21 Jun 2016 09:52:09 -0400 Received: from mail-lb0-f174.google.com ([209.85.217.174]:35108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFM63-00049F-UH for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 09:52:08 -0400 Received: by mail-lb0-f174.google.com with SMTP id o4so11356370lbp.2 for <23750@debbugs.gnu.org>; Tue, 21 Jun 2016 06:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=uoj1ozvezmB3LVBB84I4lroUG/TEd9ihBsaEYDiAA/4=; b=d2On5OsaXdPYM0m+vt72AzBxunhYIxLS81HN8P7e3K/5mqHHp2lxgHmQ62mmSBBG+i SLuequatxrDZT7fjR518qGOLrZf+zbDqPoSUW12So186dR6uk9Dn6o0dmCL4/5p+ljxT Op37Ja8BA3XnIMiG9E0MVYDFAguIc+2RM2M//wXMUJ/1rwn49OqKK5/vW4aTrnp7jzE1 Y/8YblIgFKZWr7CbUBBSLLBIDt5j8y40OAHCXtDuysJfmTCUIGPooI2BFeDlEPdgcE6Y C75KXIiT7S3QjHLIcn/VxHo8jIGBATtYKevULzge9+o6gdCFrkxzxYA2EkRjHiQUYt/B JWIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to; bh=uoj1ozvezmB3LVBB84I4lroUG/TEd9ihBsaEYDiAA/4=; b=EgspzScntcn+/7YgXsGs+mqYFw1fMwVEKRBPBhaA78MkRZJdZSZJqA5P2cSr86mydk YcZE4Xmul78DSEMbG0qT4niroLkiNpCUB4ffGA+gWZL0cg/M6iqOuLblp84iaUI9ozhA i/Emx1WaM9PpJ0yzCiatxInRO5pcZkgBHVEOV6gRmsRyWVtskJxMqvQGZL6CG8sZbURs IMKzETISeDwq+ro3XQwiiJqeLkTcnTCTSCy5VOQbd2NbZeS3MJ1D5jrMKBKgvspxm9TF mKkCR6rYq4zRjH/DBS1vW3t0tlv1t/ZJadiJbtv0zwaEABsjZO2ZHl1xc9yYLu6s/OxU xJAw== X-Gm-Message-State: ALyK8tKXbFobr+lVIEC4b9QXEFbiF+fzGcVmbulqswRDTpGAGWG5OiyIT4C97K39tRBkMA== X-Received: by 10.194.52.74 with SMTP id r10mr19533672wjo.50.1466517121781; Tue, 21 Jun 2016 06:52:01 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id r130sm3104916wmf.20.2016.06.21.06.52.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 21 Jun 2016 06:52:00 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> From: Dmitry Gutov Message-ID: <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> Date: Tue, 21 Jun 2016 16:51:59 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <83porb6zpv.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------D9D53D7FA1120944BBD3CB51" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------D9D53D7FA1120944BBD3CB51 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 06/21/2016 05:30 AM, Eli Zaretskii wrote: > Because (a) I don't want to see that function in our sources, ever, > and (b) you don't have any control on the error message it produces, > which is not appropriate for application-level checks. Please take a look at the attachment. OK to install? I recall John saying we shouldn't push any more changes to emacs-25. --------------D9D53D7FA1120944BBD3CB51 Content-Type: text/x-patch; name="url-http-multibyte.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="url-http-multibyte.diff" diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index 5832e92..7156e6f 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -275,19 +275,7 @@ url-http-create-request ;; allows us to elide null lines directly, at the cost of making ;; the layout less clear. (setq request - ;; We used to concat directly, but if one of the strings happens - ;; to being multibyte (even if it only contains pure ASCII) then - ;; every string gets converted with `string-MAKE-multibyte' which - ;; turns the 127-255 codes into things like latin-1 accented chars - ;; (it would work right if it used `string-TO-multibyte' instead). - ;; So to avoid the problem we force every string to be unibyte. - (mapconcat - ;; FIXME: Instead of `string-AS-unibyte' we'd want - ;; `string-to-unibyte', so as to properly signal an error if one - ;; of the strings contains a multibyte char. - 'string-as-unibyte - (delq nil - (list + (concat ;; The request (or url-http-method "GET") " " (if using-proxy (url-recreate-url url-http-target-url) real-fname) @@ -365,7 +353,10 @@ url-http-create-request "\r\n" ;; Any data url-http-data)) - "")) + ;; Bug#23750 + (unless (= (string-bytes request) + (length request)) + (error "Multibyte text in HTTP request: %s" request)) (url-http-debug "Request is: \n%s" request) request)) --------------D9D53D7FA1120944BBD3CB51-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 11:20:34 2016 Received: (at 23750) by debbugs.gnu.org; 21 Jun 2016 15:20:34 +0000 Received: from localhost ([127.0.0.1]:49921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNTd-0006Zs-Qj for submit@debbugs.gnu.org; Tue, 21 Jun 2016 11:20:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFNTb-0006Zd-Is for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 11:20:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFNTT-0005o5-R8 for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 11:20:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFNT3-0005f3-Cj; Tue, 21 Jun 2016 11:19:57 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4926 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFNSy-00068q-Hi; Tue, 21 Jun 2016 11:19:54 -0400 Date: Tue, 21 Jun 2016 18:18:22 +0300 Message-Id: <8360t27ept.fsf@gnu.org> From: Eli Zaretskii To: Dmitry Gutov , John Wiegley In-reply-to: <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> (message from Dmitry Gutov on Tue, 21 Jun 2016 16:51:59 +0300) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Cc: 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > From: Dmitry Gutov > Date: Tue, 21 Jun 2016 16:51:59 +0300 > > > Because (a) I don't want to see that function in our sources, ever, > > and (b) you don't have any control on the error message it produces, > > which is not appropriate for application-level checks. > > Please take a look at the attachment. OK to install? Yes, but let's wait for John. > I recall John saying we shouldn't push any more changes to emacs-25. He did? John, this change is IMO safe for emacs-25. Is it OK to push there? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 21:08:57 2016 Received: (at 23750) by debbugs.gnu.org; 22 Jun 2016 01:08:57 +0000 Received: from localhost ([127.0.0.1]:50191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFWf3-0005LH-IR for submit@debbugs.gnu.org; Tue, 21 Jun 2016 21:08:57 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:35537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFWf2-0005L5-ET for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 21:08:56 -0400 Received: by mail-pa0-f51.google.com with SMTP id hl6so11271059pac.2 for <23750@debbugs.gnu.org>; Tue, 21 Jun 2016 18:08:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=sgZQljwqvz3DVl/NJKjnRph+WYyLKfIT95wuajo9KI0=; b=Bo9cr8uPQ++g0q5LleqnzLfWJ3RP6zAezL4ncvKxpZF0gfuJ3bJLvD248mWWGO7uqA U25PsDThaiTm/DGDzrygpzNXOUSoIztrTjyT4XNxTn4hqtnm1cVY6QaTry58uPaKJxNG IVBXvxxQybFb3a28xsLn4W98P6iJ/ZdFN7XdLBAigSr5AOJcKS0aKnHsNJ91aoMWIdSE oFiYbyO5RllzAdRTVGFQjd+i4rjBJKrwMOGCcr1pfg3YCvJqVgMoD2MNzmtciRdkqLDH Yut/UtsUjgFrfhW83zRmTZc2CobS+Vt+HfHB4hUCDnKmNsx8Q+8xf/xItLGY72ek1x0g fDkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=sgZQljwqvz3DVl/NJKjnRph+WYyLKfIT95wuajo9KI0=; b=ZaEuHefO30rjJF58zZuvdUr8INdR3SlFs7RISmuB3fZA897ZMZB1IwnxyWWy8R6Yrd iAJZKn4NxeZNPxuVX301zQLQEjeNOJL9E1aBXsLr3PPtKBtt1RFzpgJ3qITuPFo6sFg/ z2N4EGdudQDwQOZ6mS4HfthB2SH5jsTpZ0AXGy5Kp0hFJD/HJz0RWalLY8hHqZRGitlA i4U+WQvDNInE9NH7hkQ2iyFVhrZrAJwT/SISA3yWnoZd+Oo/bS4Uf4U3qo2rdM+fO/UF P7eXsAHAARF8Sf+V/jRrc/E7VjYpfJkzfUHmPlhDCNVSMUXbq0WGhqnFXMbN2xcI//Od mHSQ== X-Gm-Message-State: ALyK8tINkKtzvP+lHQeHmzhLqMB9GTp3wdME6Hrl86ynmRtvu1WjANM8hVhlqNtcsuHKGQ== X-Received: by 10.66.4.129 with SMTP id k1mr31366211pak.45.1466557730726; Tue, 21 Jun 2016 18:08:50 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id t128sm2866584pfb.14.2016.06.21.18.08.49 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 21 Jun 2016 18:08:49 -0700 (PDT) From: John Wiegley X-Google-Original-From: John Wiegley Received: by Vulcan.local (Postfix, from userid 501) id C71AD9E7159; Tue, 21 Jun 2016 18:08:48 -0700 (PDT) To: Eli Zaretskii Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: <8360t27ept.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 21 Jun 2016 18:18:22 +0300") Date: Tue, 21 Jun 2016 18:08:44 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> <8360t27ept.fsf@gnu.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Eli Zaretskii writes: > He did? John, this change is IMO safe for emacs-25. Is it OK to push ther= e? If you think it's safe, Eli, then I'm good with it. =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXaeUcAAoJEMFE2PTxn+YwyPMMANPn1ntofalAFXRkxnkPnzmk 7FsvQ896g2LVDxxSKlZHt68dpN3yV9P/IGvuF+k9QcFP9tdsF6m+bWQ9k/RvCMaI azdhSOHVwORHEnNqRxlBdPImLh08W8rMW6RAFHaBSKGkhzyO6MHeaeDw7TvFj5ef xxUbBv362e1uLyCObzfsG/c5K/GF5r8jOZngJfZmtMujzkh8PKUqKWkLFvLgqnrq 6EXKYo6rimVDFjLQL6bnrESeKTOo+4FI8VWKzWfapSbP+Fz9LHlF48jok9GVytXw Kf8BUGxmc9DKc821W6oPDz5iRL/BcDINsJBNJtf7d0lrvs2h7OC8HtCAmoOk4IP5 dr6+mUJWhMuEY/n80B6OC1QzczPKSw5XV8eMZ7QcVOrWDbJWIb+G023I5ygDWmZh EhGQwAlJu2QtEKG7aq+wTcKpUQ7C2iCQFNSD2x8jG1TI2AUYMRbO3yAZhVLpx+Sx 1DKGctifElRXm/z7NjeOLFK/OVg7JrgwjCr1cbuVBw== =vJ8Q -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 21 22:37:19 2016 Received: (at 23750) by debbugs.gnu.org; 22 Jun 2016 02:37:19 +0000 Received: from localhost ([127.0.0.1]:50213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFY2Y-0007Qc-TA for submit@debbugs.gnu.org; Tue, 21 Jun 2016 22:37:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFY2X-0007QP-Ic for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 22:37:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFY2R-0002cF-Jk for 23750@debbugs.gnu.org; Tue, 21 Jun 2016 22:37:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57570) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFY2L-0002Y2-TI; Tue, 21 Jun 2016 22:37:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1360 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bFY2J-0006eq-Sz; Tue, 21 Jun 2016 22:37:04 -0400 Date: Wed, 22 Jun 2016 05:36:13 +0300 Message-Id: <83lh1y54rm.fsf@gnu.org> From: Eli Zaretskii To: John Wiegley In-reply-to: (message from John Wiegley on Tue, 21 Jun 2016 18:08:44 -0700) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> <8360t27ept.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.5 (------) > From: John Wiegley > Cc: Dmitry Gutov , 23750@debbugs.gnu.org, monnier@IRO.UMontreal.CA, sdl.web@gmail.com > Date: Tue, 21 Jun 2016 18:08:44 -0700 > > >>>>> Eli Zaretskii writes: > > > He did? John, this change is IMO safe for emacs-25. Is it OK to push there? > > If you think it's safe, Eli, then I'm good with it. OK, thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 22 14:21:30 2016 Received: (at 23750-done) by debbugs.gnu.org; 22 Jun 2016 18:21:30 +0000 Received: from localhost ([127.0.0.1]:51431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFmmI-0001GZ-CF for submit@debbugs.gnu.org; Wed, 22 Jun 2016 14:21:30 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFmmH-0001GO-7K for 23750-done@debbugs.gnu.org; Wed, 22 Jun 2016 14:21:29 -0400 Received: by mail-wm0-f51.google.com with SMTP id r201so17585979wme.1 for <23750-done@debbugs.gnu.org>; Wed, 22 Jun 2016 11:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=TyXIJetWsMubDovvDefQgelbbR5Vg5ym7AsSYbMGU8g=; b=g0zMyjaKc95fnPFOVixxRbyW4TW4Zry5JeaH8Y4ot2C/DZiFTO8szmRXpgOjgE0GOr Man23JkoERaHl5WRGUw7d416Usy2Yb0EW8vz3nY0v7O/zmi8EjappapL3+ZDIPwGV7Ye PGJYxopE0VawyH+VGOteRhE3+VXiIvBhBL6LRAQWuUDBXv2K831c8OG9rEuWETwqwlpO zzCfC/DBppiewnYoQFkKPt6KTGZ7Q6b0++hBa9qduvMgGxB+lh4J2q2OGGn36xfHq50H gSpzQzacudMrAhLDMemu0Wips2BtQu9bM2TmNgwy4mNsP0+3/iaT6xtskr+wScdC8qrM w4Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=TyXIJetWsMubDovvDefQgelbbR5Vg5ym7AsSYbMGU8g=; b=cVBaOetFCGWUBGA+EoHJUjHYN2QDdoO8omM2M2o0ysEBKVgBigDhQvOW2wmpp7c/7w BguLkJHbelZIOilMo9lNbJmZM2XwbOs3Hnlw3A6sNGD82Tu7t3Y6DWbRIyUe0YOWbp3S DKIcu3/XdENRuE1Rf5zrLB/bIQNBuBqji16ySFcQTTNDezIrumR2PrtcjKYznTydHVLC NhAtkRmO20r+gtsVw4lygviru61iWdni3UXtkw79oMOwCOuyUDSsQ59GdxLnfk16l8yr vDDe+C3UbQ0ngv5a4aiVphIikppbZrKkuJQjQW8UWSnY9VQYoi/fjoq1TA/lTwhxigqT 86jw== X-Gm-Message-State: ALyK8tIvHYTBpUBzmd2jO6kdX4J01TEhQvVAH+UFObMzWVXTQPZdax2dUTiCH9ipygsvww== X-Received: by 10.28.94.135 with SMTP id s129mr9838578wmb.36.1466619683477; Wed, 22 Jun 2016 11:21:23 -0700 (PDT) Received: from [192.168.0.185] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id a84sm67248wma.0.2016.06.22.11.21.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Jun 2016 11:21:22 -0700 (PDT) Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el To: John Wiegley , Eli Zaretskii References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <83h9co8twu.fsf@gnu.org> <838ty07wno.fsf@gnu.org> <83r3br7gy0.fsf@gnu.org> <835e315a-e4c3-17a4-c2ee-7d8d5cc090b4@yandex.ru> <83porb6zpv.fsf@gnu.org> <7541b356-38a6-1bac-7914-3ec110d0c40b@yandex.ru> <8360t27ept.fsf@gnu.org> From: Dmitry Gutov Message-ID: <54ab468e-498c-f358-cf1e-5e3714c1b96c@yandex.ru> Date: Wed, 22 Jun 2016 21:21:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750-done Cc: 23750-done@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 06/22/2016 04:08 AM, John Wiegley wrote: > If you think it's safe, Eli, then I'm good with it. Thanks! Pushed, and closing. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 23 13:15:12 2016 Received: (at 23750) by debbugs.gnu.org; 23 Jun 2016 17:15:12 +0000 Received: from localhost ([127.0.0.1]:52925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG8Dg-0000w2-9T for submit@debbugs.gnu.org; Thu, 23 Jun 2016 13:15:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bG8Df-0000vm-0Q for 23750@debbugs.gnu.org; Thu, 23 Jun 2016 13:15:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bG8DZ-0004NE-4n for 23750@debbugs.gnu.org; Thu, 23 Jun 2016 13:15:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39951) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bG8DS-0004LO-W9; Thu, 23 Jun 2016 13:14:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bG8DQ-0006Ph-Ed; Thu, 23 Jun 2016 13:14:56 -0400 From: Glenn Morris To: John Wiegley Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> X-Spook: CID Perl-RSA Uzi Iraq Recruitment Stuck Islam X-Ran: m\{|]HHu(/{8kZ'](JyK!{o%.3^nZ{g0/%S}<1rc.KT2=cx*/n7U~2s(^ltI`*`BAnS[.l X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 23 Jun 2016 13:14:56 -0400 In-Reply-To: (John Wiegley's message of "Sun, 19 Jun 2016 21:22:25 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) John Wiegley wrote: >> Then why is master STILL advertising itself as the forerunner to 25.2? Why >> are we closing a bunch of bugs as "fixed in 25.2" if they won't be fixed >> till 26.1? > > I guess to avoid having the reported version number in bug reports keep > jumping around? Master is really working toward 26.1 at this point. This doesn't make any sense to me. (And why are you guessing? Isn't there a plan?) > Once we start working on 25.2, we should cherry-pick over all the fixes for > bugs are marked "fixed in 25.2". Otherwise, they should be marked "fixed in > 26.1". I don't think that will work well, but good luck with it. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 01 16:51:32 2016 Received: (at 23750) by debbugs.gnu.org; 1 Jul 2016 20:51:32 +0000 Received: from localhost ([127.0.0.1]:34180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJ5PM-0002Hw-VU for submit@debbugs.gnu.org; Fri, 01 Jul 2016 16:51:32 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:36312) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJ5PI-0002Hg-7y for 23750@debbugs.gnu.org; Fri, 01 Jul 2016 16:51:27 -0400 Received: by mail-pa0-f50.google.com with SMTP id zl15so1065588pab.3 for <23750@debbugs.gnu.org>; Fri, 01 Jul 2016 13:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:date:message-id:references :user-agent:mime-version; bh=E6SmZF6d+AyFS/2O7uVKT1qAcz8LLlMtcS8NjK2GSTg=; b=ckkCAcWJskSuqbq31b8SUMtDJ2Ubpht9sCKGS+Kg6TzXBf8T6SdhHVbgJz1hZOhEYb GWdCq6gsk2ov5hhBMcOHPcNeTEozp/Kf9tfXH/zK70rzmeNF95nWetpDx1bVkrIW4q5C G03KF75DHOgM4RuLj5Lnzpzfidnf5t9b7+HK4xaUrH87OY26oKmphStf/mc1u+Gs/xRs m1hOmkZL92VcnX9cu9qjdd7rJ9ATpcpgAVqGC2AXIXETw+D+pQ+ex2z87AaJrVGUDVlm PVHJ9x4TJcE8CKpFhMukcR63uwcPo7KlpdKYIiEJFQnIKY3krx5ZHy0ZRXDj8sIsksCc BQ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:date:message-id :references:user-agent:mime-version; bh=E6SmZF6d+AyFS/2O7uVKT1qAcz8LLlMtcS8NjK2GSTg=; b=Jhp3mBzgCPlb12ZskQUkgzgzlRGyZYhinuXAYQ6ezLtHlAYO9Lfui89i+F0lNs7AMo 4fLOa/6PlmD7E0ZAzwKxsbB0I+xsHBzzUSeyW6rCNMLy+z2QkEC+Qbl8BVIPCRg/uyMd mGZvaaiE8odmj9qnEMOYIid+uD3QwF+4YhZhXg1Yxu34Uo07oLA/DwxATEg2PsnYK4sM bYOuLQ//XIL2lXau1UWYCj2e2FsYzsGkROZAwZUw0yDoOSSI2VxbSEjscuohnl/wd+0B ZaZlnj/v3ltTvhk6N58wrMO0qdFUu/ErDoPcCk98/chHha29oBOo78rXxm48igCFVvb3 IZcw== X-Gm-Message-State: ALyK8tLEwCly9cD69qo9uJjQXMgM2qkEEWccvKkyfW0tCyLYGoJ6TEDUEA5De2gvYPtbJg== X-Received: by 10.66.169.39 with SMTP id ab7mr359442pac.23.1467406278092; Fri, 01 Jul 2016 13:51:18 -0700 (PDT) Received: from Vulcan.local (76-234-68-79.lightspeed.frokca.sbcglobal.net. [76.234.68.79]) by smtp.gmail.com with ESMTPSA id q1sm7621883pfi.93.2016.07.01.13.51.16 (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 01 Jul 2016 13:51:16 -0700 (PDT) From: John Wiegley X-Google-Original-From: "John Wiegley" Received: by Vulcan.local (Postfix, from userid 501) id 2E9DCF4CD5A; Fri, 1 Jul 2016 13:51:16 -0700 (PDT) To: Lars Ingebrigtsen Subject: Re: bug#23750: 25.0.95; bug in url-retrieve or json.el In-Reply-To: <87vb14t4pl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 20 Jun 2016 14:39:02 +0200") Date: Fri, 01 Jul 2016 13:49:10 -0700 Message-ID: References: <358304f6-98e1-fa10-8805-aa9b73db406a@yandex.ru> <83k2hl828z.fsf@gnu.org> <8f51ca52-d0fd-6647-cfa8-82434a3057b5@yandex.ru> <9534b2e3-d7ef-ed6a-8a0c-c4add3c618e4@yandex.ru> <87vb14t4pl.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.95 (darwin) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23750 Cc: 23750@debbugs.gnu.org, Glenn Morris , sdl.web@gmail.com, monnier@IRO.UMontreal.CA, Dmitry Gutov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable >>>>> Lars Ingebrigtsen writes: > Most bugs fixed in master are marked "fixed in 25.2" (since that is what > master is announcing itself as being the forerunner to), so that doesn't > make much sense, I'm afraid. >=20 > Which is what Glenn is telling us, once again. I really don't understand = why > master hasn't been changed to say that it's the forerunner to 26.1. The last time we had our long discussion about what the various branches me= an, the conclusion was that emacs-25 is for the next release, and master is for all other work. Most people did NOT want master to be toward the next release (25.2), as th= at leaves nowhere for changes meant for 26 only. However, this also leaves nowhere for fixes to go that are only for 25.2. B= ut since no additional branches were desired, the compromise was that both typ= es of changes will go into master, and we will be backport certain changes into emacs-25 toward 25.2 after the release. Marking a bug as "fixed in 25.2" seems wrong to me, because it implies a guarantee that the fix will get cherry picked into emacs-25 after 25.1 is released, although I highly doubt this will happen for every such fix. There is just too much work to be done. What we should do is mark every commit intended for 25.2 in a way that lets= us find them all automatically after the release, with a link to the bugs they fix so that we can safely state "fixed in 25.2". Since this hasn't happened= , I imagine it will be a very manual process, and will be missing several of th= ose fixes. This is why I personally argued for 3 branches, but it's not what the people doing the real work wanted, so this is what we have. After 25.1, we'll just have to see what happens to emacs-25 and to the bug-tracker. I imagine several of the "fixed in 25.2" bugs will need to be adjusted to "fixed in 26.1". =2D-=20 John Wiegley GPG fingerprint =3D 4710 CF98 AF9B 327B B80F http://newartisans.com 60E1 46C4 BD1A 7AC1 4BA2 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGcBAEBCgAGBQJXdtdGAAoJEMFE2PTxn+YwhVAL/1zgO12jtqNxafAa3rjuuPP9 JpBTLU3sN7DYs46JUGktr2tw5+Uqk9x+WorkP4Thr7/+6897358RdS4vXL8nZ4y5 soTJkPmPm9790FGp4yR8fTth0j4dDdu6iEBUmgpgfyLOQYJEeA4zYbSGt+Xj5F8G CvemLhLICXC7D+cFazz7c2XDCE9F5sawD+jc1d7xg69VuGEFCARu/hl3DN2s3OIz ACeSi4WLUM/tNdyNfDnaLvyEDEENyOo37OFic/g8W+/nPNXt4YE1cdGxHlFZBaVL khtH+mXHyJEIHm0Lm6NXV+Uzcnj1aJNDSElNrBuzA2Gj3zU83TBQO1vUwm3GYTJH V+aXEsbkCb5X+k7XtFXbjesU6DXa/Xg3JAnFnmi6yRsmIyl1AA1Sdq9/zxHDk3Yd zniGjwk2DzFxYJXpQBCEK6uqjFLrKg7GThVkg373xHveRva7EufdamUVpipYpzVm 3tl/PHkVfEbxBXSeQcBet2g8FMjMa0di5j/ABRJfdw== =FUkQ -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Sep 14 03:43:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 30 Jul 2016 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator