From unknown Mon Jun 16 23:28:27 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23729 <23729@debbugs.gnu.org> To: bug#23729 <23729@debbugs.gnu.org> Subject: Status: [PATCH] Remove =?UTF-8?Q?=E2=80=98ert-with-function-mocked=E2=80=99?= macro in favour of =?UTF-8?Q?=E2=80=98cl-letf=E2=80=99?= macro Reply-To: bug#23729 <23729@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:28:27 +0000 retitle 23729 [PATCH] Remove =E2=80=98ert-with-function-mocked=E2=80=99 mac= ro in favour of =E2=80=98cl-letf=E2=80=99 macro reassign 23729 emacs submitter 23729 Michal Nazarewicz severity 23729 wishlist tag 23729 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 08:45:01 2016 Received: (at submit) by debbugs.gnu.org; 8 Jun 2016 12:45:01 +0000 Received: from localhost ([127.0.0.1]:59908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAcqy-0006NO-V3 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 08:45:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAcqx-0006N9-3Q for submit@debbugs.gnu.org; Wed, 08 Jun 2016 08:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAcqq-0002Yu-92 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 08:44:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36304) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAcqq-0002Yg-5K for submit@debbugs.gnu.org; Wed, 08 Jun 2016 08:44:52 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAcqn-0004nG-Dq for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 08:44:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAcqm-0002YM-01 for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 08:44:49 -0400 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:37254) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAcql-0002Y8-EL for bug-gnu-emacs@gnu.org; Wed, 08 Jun 2016 08:44:47 -0400 Received: by mail-wm0-x22d.google.com with SMTP id k204so15360945wmk.0 for ; Wed, 08 Jun 2016 05:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=cEjlpf6/sqdO4IS4LW2LEsfMcT4EEQGLPKld8ZJOmSc=; b=fedt9QHp8NLuCLEWJvBralIh0mfvDrrM27YiJyb9927sLf3NOFyxqqVVf/UY58mJIl BHdVAcryLeJsoElkIu6ye57R00ZsMEoxOWTTZmiSbWxpid6Cpchhl8+rctch0bK6m27L mybeLGZoqftYDnmLigvgrB7wyfimGJ6bPC2cgx63NMS1rGInhv8iKMSKXAHM1m4W4JyO w1k4RT5cebcgsMbH/FlKjV7Yljr56JAvALShOVX/he1NpIKwKKF1CSdgukCSeHvdExLF 7OzGpAaSvW1wkrdg0rWZ/F2j4QEmqIiBDXUl9MBq3Gkd10FuMGZUtDQ3dN2+EMOM8WEn iEpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=cEjlpf6/sqdO4IS4LW2LEsfMcT4EEQGLPKld8ZJOmSc=; b=a+3Og4OYBV6tF0mssvJdzeQuVzwvugBb8lB4tlENd+FRur+trWziCPJxPpC9eVf7VS rrrgNPN/oHROk6VP4as4qapLmPfEdblsIhRVeCsM3Dg6yl0d+5DbezfUs8i7406w9oCq 2J89d3CFiPjdsLRdsRhqCoaldYULix2tuYVmuZ+3H6E9y6SmT/6YpJly3VXVOu4Ig9OY hH69JkenakYAL2T/32cQ3ZQFjPtuJsWYneKEs4BONdgRs1rVEglZ4wKjBgvToFFq9nze vo41rsy+15aVU7UgP1r/zy7sPnPd8BF+99gHnL+kTcCRXBEzYvu/JTwcasRfv/9shIEe i3Ew== X-Gm-Message-State: ALyK8tKF3xA51nyHbMlulo2s+UUnR4smeZaLf/8doKp7y+q9N603hxzf0IaZ72zwu3w5oc09 X-Received: by 10.195.17.138 with SMTP id ge10mr4864023wjd.94.1465389885799; Wed, 08 Jun 2016 05:44:45 -0700 (PDT) Received: from mpn.zrh.corp.google.com ([172.16.113.135]) by smtp.gmail.com with ESMTPSA id s1sm1296258wjf.43.2016.06.08.05.44.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jun 2016 05:44:45 -0700 (PDT) Received: by mpn.zrh.corp.google.com (Postfix, from userid 126942) id 238DD1E0274; Wed, 8 Jun 2016 14:44:44 +0200 (CEST) From: Michal Nazarewicz To: bug-gnu-emacs@gnu.org Subject: [PATCH] =?UTF-8?q?Remove=20=E2=80=98ert-with-function-mocked?= =?UTF-8?q?=E2=80=99=20macro=20in=20favour=20of=20=E2=80=98cl-letf?= =?UTF-8?q?=E2=80=99=20macro?= Date: Wed, 8 Jun 2016 14:44:39 +0200 Message-Id: <1465389879-14248-1-git-send-email-mina86@mina86.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) * lisp/emacs-lisp/ert-x.el (ert-with-function-mocked): Remove macro in favour of ‘cl-letf’ macro which is more generic. All existing uses are migrated accordingly. The macro has not been included in an official release yet so it should be fine to delete it. --- etc/NEWS | 3 --- lisp/emacs-lisp/ert-x.el | 40 -------------------------------- test/lisp/calendar/icalendar-tests.el | 3 +-- test/lisp/emacs-lisp/ert-x-tests.el | 43 ----------------------------------- test/lisp/gnus/message-tests.el | 2 +- test/lisp/vc/vc-bzr-tests.el | 3 +-- 6 files changed, 3 insertions(+), 91 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 1ae8ff6..d8583cf 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -418,9 +418,6 @@ by setting 'autoload-timestamps' to nil. FIXME As an experiment, nil is the current default. If no insurmountable problems before next release, it can stay that way. -** 'ert-with-function-mocked' of 'ert-x package allows mocking of functions -in unit tests. - --- ** 'gnutls-boot' now takes a parameter :complete-negotiation that says that negotiation should complete even on non-blocking sockets. diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el index 67cb102..2a2418f 100644 --- a/lisp/emacs-lisp/ert-x.el +++ b/lisp/emacs-lisp/ert-x.el @@ -285,46 +285,6 @@ ert-buffer-string-reindented (kill-buffer clone))))))) -(defmacro ert-with-function-mocked (name mock &rest body) - "Mocks function NAME with MOCK and run BODY. - -Once BODY finishes (be it normally by returning a value or -abnormally by throwing or signaling), the old definition of -function NAME is restored. - -BODY may further change the mock with `fset'. - -If MOCK is nil, the function NAME is mocked with a function -`ert-fail'ing when called. - -For example: - - ;; Regular use, function is mocked inside the BODY: - (should (eq 2 (+ 1 1))) - (ert-with-function-mocked ((+ (lambda (a b) (- a b)))) - (should (eq 0 (+ 1 1)))) - (should (eq 2 (+ 1 1))) - - ;; Macro correctly recovers from a throw or signal: - (should - (catch 'done - (ert-with-function-mocked ((+ (lambda (a b) (- a b)))) - (should (eq 0 (+ 1 1)))) - (throw 'done t))) - (should (eq 2 (+ 1 1))) -" - (declare (indent 2)) - (let ((old-var (make-symbol "old-var")) - (mock-var (make-symbol "mock-var"))) - `(let ((,old-var (symbol-function (quote ,name))) (,mock-var ,mock)) - (fset (quote ,name) - (or ,mock-var (lambda (&rest _) - (ert-fail (concat "`" ,(symbol-name name) - "' unexpectedly called."))))) - (unwind-protect - (progn ,@body) - (fset (quote ,name) ,old-var))))) - (provide 'ert-x) ;;; ert-x.el ends here diff --git a/test/lisp/calendar/icalendar-tests.el b/test/lisp/calendar/icalendar-tests.el index 20d8834..6db4222 100644 --- a/test/lisp/calendar/icalendar-tests.el +++ b/test/lisp/calendar/icalendar-tests.el @@ -32,7 +32,6 @@ ;;; Code: (require 'ert) -(require 'ert-x) (require 'icalendar) ;; ====================================================================== @@ -64,7 +63,7 @@ icalendar-tests--trim (hash (format "%d" (abs (sxhash entry-full)))) (contents "DTSTART:19640630T070100\nblahblah") (username (or user-login-name "UNKNOWN_USER"))) - (ert-with-function-mocked current-time (lambda () '(1 2 3)) + (cl-letf (((symbol-function 'current-time) (lambda () '(1 2 3)))) (should (= 77 icalendar--uid-count)) (should (string= (concat "xxx-123-77-" hash "-" username "-19640630") (icalendar--create-uid entry-full contents))) diff --git a/test/lisp/emacs-lisp/ert-x-tests.el b/test/lisp/emacs-lisp/ert-x-tests.el index a2665e7..ef8642a 100644 --- a/test/lisp/emacs-lisp/ert-x-tests.el +++ b/test/lisp/emacs-lisp/ert-x-tests.el @@ -275,49 +275,6 @@ ert--hash-table-to-alist (should (equal (c x) (lisp x)))))) -(defun ert--dummy-id (a) - "Identity function. Used for tests only." - a) - -(ert-deftest ert-with-function-mocked () - (let ((mock-id (lambda (_) 21))) - (should (eq 42 (ert--dummy-id 42))) - - (ert-with-function-mocked ert--dummy-id nil - (fset 'ert--dummy-id mock-id) - (should (eq 21 (ert--dummy-id 42)))) - (should (eq 42 (ert--dummy-id 42))) - - (ert-with-function-mocked ert--dummy-id mock-id - (should (eq 21 (ert--dummy-id 42)))) - (should (eq 42 (ert--dummy-id 42))) - - (should - (catch 'exit - (ert-with-function-mocked ert--dummy-id mock-id - (should (eq 21 (ert--dummy-id 42)))) - (throw 'exit t))) - (should (eq 42 (ert--dummy-id 42))) - - (should - (string= "Foo" - (condition-case err - (progn - (ert-with-function-mocked ert--dummy-id mock-id - (should (eq 21 (ert--dummy-id 42)))) - (user-error "Foo")) - (user-error (cadr err))))) - (should (eq 42 (ert--dummy-id 42))) - - (should - (string= "`ert--dummy-id' unexpectedly called." - (condition-case err - (ert-with-function-mocked ert--dummy-id nil - (ert--dummy-id 42)) - (ert-test-failed (cadr err))))) - (should (eq 42 (ert--dummy-id 42))))) - - (provide 'ert-x-tests) ;;; ert-x-tests.el ends here diff --git a/test/lisp/gnus/message-tests.el b/test/lisp/gnus/message-tests.el index ae34f24..13c15e3 100644 --- a/test/lisp/gnus/message-tests.el +++ b/test/lisp/gnus/message-tests.el @@ -57,7 +57,7 @@ (ert-deftest message-strip-subject-trailing-was () - (ert-with-function-mocked message-talkative-question nil + (cl-letf (((symbol-function 'message-talkative-question) nil)) (with-temp-buffer (let ((no-was "Re: Foo ") (with-was "Re: Foo \t (was: Bar ) ") diff --git a/test/lisp/vc/vc-bzr-tests.el b/test/lisp/vc/vc-bzr-tests.el index 98d176c..f27e658 100644 --- a/test/lisp/vc/vc-bzr-tests.el +++ b/test/lisp/vc/vc-bzr-tests.el @@ -25,7 +25,6 @@ ;;; Code: (require 'ert) -(require 'ert-x) (require 'vc-bzr) (require 'vc-dir) @@ -102,7 +101,7 @@ (while (vc-dir-busy) (sit-for 0.1)) (vc-dir-mark-all-files t) - (ert-with-function-mocked y-or-n-p (lambda (_) t) + (cl-letf (((symbol-function 'y-or-n-p) (lambda (_) t))) (vc-next-action nil)) (should (get-buffer "*vc-log*"))) (delete-directory homedir t)))) -- 2.8.0.rc3.226.g39d4020 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 12:06:29 2016 Received: (at 23729) by debbugs.gnu.org; 8 Jun 2016 16:06:29 +0000 Received: from localhost ([127.0.0.1]:33019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfzw-0004nA-PO for submit@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfzv-0004mw-Be for 23729@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAfzk-0006wn-Kw for 23729@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46009) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAfzD-0006kp-U1; Wed, 08 Jun 2016 12:05:43 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAfzC-0006eZ-7K; Wed, 08 Jun 2016 12:05:42 -0400 From: Glenn Morris To: Michal Nazarewicz Subject: Re: bug#23729: [PATCH] Remove =?utf-8?Q?=E2=80=98ert-with-functio?= =?utf-8?Q?n-mocked=E2=80=99?= macro in favour of =?utf-8?B?4oCYY2wtbGV0?= =?utf-8?B?ZuKAmQ==?= macro References: <1465389879-14248-1-git-send-email-mina86@mina86.com> X-Spook: Mexican army Transportation security NWO analyzer 22nd X-Ran: #9&L=E~.|lDF3;2y (Michal Nazarewicz's message of "Wed, 8 Jun 2016 14:44:39 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23729 Cc: 23729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) I see you added it in the first place? So I guess you should feel free to remove it again. :) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 12:06:19 2016 Received: (at control) by debbugs.gnu.org; 8 Jun 2016 16:06:19 +0000 Received: from localhost ([127.0.0.1]:33016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfzn-0004mn-Hj for submit@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfzl-0004mZ-Cf for control@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAfzc-0006uQ-IJ for control@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAfzc-0006u8-Eo for control@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAfzb-0006jq-19 for control@debbugs.gnu.org; Wed, 08 Jun 2016 12:06:07 -0400 Subject: control message for bug 21966 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Wed, 08 Jun 2016 12:06:07 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) block 21966 by 23729 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 13:15:33 2016 Received: (at 23729) by debbugs.gnu.org; 8 Jun 2016 17:15:33 +0000 Received: from localhost ([127.0.0.1]:33088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh4m-000886-RX for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:15:33 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh4j-00087s-U2 for 23729@debbugs.gnu.org; Wed, 08 Jun 2016 13:15:31 -0400 Received: by mail-wm0-f41.google.com with SMTP id n184so191263599wmn.1 for <23729@debbugs.gnu.org>; Wed, 08 Jun 2016 10:15:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=txirS+VKYUJvK+lfnquuH3VICjvSkZ8KtJ26r5QFhLg=; b=Phrat7fP6QJSIlY6Zp++3TOI8+eovVvX0g5y9KZr5XOpuutB7hZf7Oy+HDxqHuKdXW hcdjHDBRLdE6Qdmrr9YizNpug6LgxU7VkIH6ZWo636vWSY22ToGCVS3MG6PFCRbppLfC Ck5rZ1AlXUyqdsquF8oC+cY2Trbo6gI7VDEfzmWlJgSTA9u7zFwbdEX5oE+bLnA6ZMZZ BgQJ8y+RrgLS7EiyXArDFLCUeFP8vLmXDJyhgauTOqpn5HydfEOm09lSYDtpgtur4Ivk lgzyRg97qEPJXLxxKBfr/QpyrJMeC7/PG6n0RKRgHhBEuW1BcROGqTgr8PhtUpO/mxK4 rTFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to :organization:references:user-agent:face:date:message-id :mime-version:content-transfer-encoding; bh=txirS+VKYUJvK+lfnquuH3VICjvSkZ8KtJ26r5QFhLg=; b=SC6GlwV4G+XretbnuMM3uQLHgan0fO5ZfsqB/CdfylFwHe6WidI+qOHSLMiopH2qW8 kSSq+fO78cVh4XPIn2wsM1c8cmn41yGLcf2MSGANPnyr6xowQ8gb1KF3i6zJPnwadqWk r5+32ZnQAVwNWZEbjskit1K+0M1SLZ+aB9xrNATgvy1uOxUidLb67hZRqIparkFHJKis KfRY/ER7Cw/unUx6JW/D6ynge482CiMyNIjK7FdKjB2paTbJk9bUK1S+KYr/Vfd6UUuS eRytjx9WkB8ILUJ+PEbLMc9w6krpo3XB6vAw6N2a7BcPMu0ymMofiojPwBH/SzmPAXVK Fx3Q== X-Gm-Message-State: ALyK8tIFRPpumguQokvZa1LEBkrfXO5YFXttebSQtbvyJbFCMZ6c9soNNFVGQXsS2WEse+s+ X-Received: by 10.194.94.165 with SMTP id dd5mr5600897wjb.31.1465406124190; Wed, 08 Jun 2016 10:15:24 -0700 (PDT) Received: from mpn-glaptop ([2620:0:105f:301:a074:86fc:806:e9d]) by smtp.gmail.com with ESMTPSA id r19sm3167721wmd.3.2016.06.08.10.15.21 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Jun 2016 10:15:21 -0700 (PDT) From: Michal Nazarewicz To: Glenn Morris Subject: Re: bug#23729: [PATCH] Remove =?utf-8?Q?=E2=80=98ert-with-functio?= =?utf-8?Q?n-mocked=E2=80=99?= macro in favour of =?utf-8?B?4oCYY2wtbGV0?= =?utf-8?B?ZuKAmQ==?= macro In-Reply-To: Organization: http://mina86.com/ References: <1465389879-14248-1-git-send-email-mina86@mina86.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160608:rgm@gnu.org::5l8PJsrscsIG4O7g:0000001kwe X-Hashcash: 1:20:160608:23729@debbugs.gnu.org::As1j+54ccVCKfH9L:00000000000000000000000000000000000000008Vv+ Date: Wed, 08 Jun 2016 19:15:21 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 23729 Cc: 23729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Wed, Jun 08 2016, Glenn Morris wrote: > I see you added it in the first place? > So I guess you should feel free to remove it again. :) The write access seems to be misbehaving though (I=E2=80=99ve already tried= with the NEWS typo fix): Counting objects: 17, done. Delta compression using up to 4 threads. Compressing objects: 100% (17/17), done. Writing objects: 100% (17/17), 1.59 KiB | 0 bytes/s, done. Total 17 (delta 14), reused 0 (delta 0) error: unpack failed: unpack-objects abnormal exit To git://git.sv.gnu.org/emacs.git ! [remote rejected] ert -> master (n/a (unpacker error)) error: failed to push some refs to 'git://git.sv.gnu.org/emacs.git' --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 13:18:06 2016 Received: (at 23729) by debbugs.gnu.org; 8 Jun 2016 17:18:06 +0000 Received: from localhost ([127.0.0.1]:33092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh7G-0008CQ-92 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:18:06 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:35022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh7E-0008Bu-2l for 23729@debbugs.gnu.org; Wed, 08 Jun 2016 13:18:04 -0400 Received: by mail-wm0-f43.google.com with SMTP id v199so73521939wmv.0 for <23729@debbugs.gnu.org>; Wed, 08 Jun 2016 10:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=zN+4/rwwKGlEtbxkcbDHADZSnC0wUfCs3JzLFSq+kWM=; b=fayMj/W+CLFiUiHKy1CtvHEsnEIk0bI4n6eBofYhNbzJtowiLRgUUcYlyX7dSeglV0 T9Qwflthn/cwxdGSyMTkzmUH1a4vm69X6xIP+i11RYbRaltpxkE7enGwgW45/3YNnkVq Go3AKciI7MJEMJ3UbFc11HvC95ge0BEF7dRsfLx/9KwYYyzBlGeOkkla2Dxx6lzBCVws qdFSk4M31oXqujXGL3NaXVslQne1NaYGS4lPDYI/fSJzWC/zwx2l0v/sSNUg225CMVCD xZ7q8I0iBvQRaHBQMRiLZIy7EFTk6BQbgSaqtuY+DYw1VQyoNX0pnAoKv81tMn9K6iwH fhwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to :organization:references:user-agent:face:date:message-id :mime-version:content-transfer-encoding; bh=zN+4/rwwKGlEtbxkcbDHADZSnC0wUfCs3JzLFSq+kWM=; b=N+YJYFkvFBJI4U2Jj3Fz06uM9pY0qjJCM9RQdk6ewoniq4RdajJaJmKpTUtbl8njP8 9wjvBIaxP9f2cDghwCMy4gy/buB9NKmltk5La6HBBLhRvolTOLgvNjx5itumWiaEeIZa rWup4V/XSDY5W9+u9RNH0N5Otw+TAV0M0WSEk4rbkNhCUuvrDlFC7n+FMD7TWUN4t8a0 Y4Cf8EKc6zwI1qYYaOt8KB2KxPCjgAuTGwfZq7UHm+prJ/4Jq296oTSfapyboJ1fP17z u5lNhecYRRgo/SQiMolzonRcE92LbnrBw6yTcE4hCLSiyXhCSSFvn8FcszPyDAOrwtCJ 21iA== X-Gm-Message-State: ALyK8tLY0piFs+z05Kqrzl5o02kAFBn6y2gw/KzCQ5a3q6mdoUqgb/kQ1GNu0FJagCeIhU8y X-Received: by 10.28.131.80 with SMTP id f77mr6241801wmd.80.1465406278353; Wed, 08 Jun 2016 10:17:58 -0700 (PDT) Received: from mpn-glaptop ([2620:0:105f:301:a074:86fc:806:e9d]) by smtp.gmail.com with ESMTPSA id dl5sm2515483wjd.32.2016.06.08.10.17.57 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Jun 2016 10:17:57 -0700 (PDT) From: Michal Nazarewicz To: Glenn Morris Subject: Re: bug#23729: [PATCH] Remove =?utf-8?Q?=E2=80=98ert-with-functio?= =?utf-8?Q?n-mocked=E2=80=99?= macro in favour of =?utf-8?B?4oCYY2wtbGV0?= =?utf-8?B?ZuKAmQ==?= macro In-Reply-To: Organization: http://mina86.com/ References: <1465389879-14248-1-git-send-email-mina86@mina86.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160608:23729@debbugs.gnu.org::JAlUraram82+p1sn:00000000000000000000000000000000000000000bWk X-Hashcash: 1:20:160608:rgm@gnu.org::2KWsDIUWJt4sGvJx:0000005qdN Date: Wed, 08 Jun 2016 19:17:56 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 23729 Cc: 23729@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) > On Wed, Jun 08 2016, Glenn Morris wrote: >> I see you added it in the first place? >> So I guess you should feel free to remove it again. :) On Wed, Jun 08 2016, Michal Nazarewicz wrote: > The write access seems to be misbehaving though (I=E2=80=99ve already tri= ed with > the NEWS typo fix): Disregard, I=E2=80=99m an idiot. Got it working. > Counting objects: 17, done. > Delta compression using up to 4 threads. > Compressing objects: 100% (17/17), done. > Writing objects: 100% (17/17), 1.59 KiB | 0 bytes/s, done. > Total 17 (delta 14), reused 0 (delta 0) > error: unpack failed: unpack-objects abnormal exit > To git://git.sv.gnu.org/emacs.git > ! [remote rejected] ert -> master (n/a (unpacker error)) > error: failed to push some refs to 'git://git.sv.gnu.org/emacs.git' --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 13:20:49 2016 Received: (at 23729-done) by debbugs.gnu.org; 8 Jun 2016 17:20:49 +0000 Received: from localhost ([127.0.0.1]:33096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh9t-0008GG-Mv for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:20:49 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAh9t-0008G4-1g for 23729-done@debbugs.gnu.org; Wed, 08 Jun 2016 13:20:49 -0400 Received: by mail-wm0-f42.google.com with SMTP id m124so26631670wme.1 for <23729-done@debbugs.gnu.org>; Wed, 08 Jun 2016 10:20:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=21XSbcwW9HmSZeC0bW+6Gk/Y0C8XQnUAxiiM+ExTfEE=; b=TvVJ5W6jsZxHfE/SmlVoPwrYL3brhADew1FmKWlEZCClEfbuhnVp2IcBcJgBakfcUn vGCYb3gA+geBGC+2oMUyWSDLKPu+e3WsSUwmnairDR+Zt4Erz3UDkkj92IjFe+K+mVKe EgUFwMlMAFUHjfprqOpkbCUTtv058Sd6Weq5IPdLrHm4B17shzne9gv9zpBuwH2uJThX OIagBeG8NNZFfs56I4uefAKhg6VErBCeRp/vN1izTYr6InW42v+Gh9WDQ3aGDEBy5+NY vwJdmLRkc5598j7NbWH/AeINrkXQVUCA9Lb7HMFxv8+BYYLAnYoPhVFqIvOMjC7yMk6N mkFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:in-reply-to:organization :references:user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=21XSbcwW9HmSZeC0bW+6Gk/Y0C8XQnUAxiiM+ExTfEE=; b=dJCvHSOU2ddi2hMCfYiZ/DKnKXGV4MOwG6Lx10TXae9UUkhVxtxTTdqIOKGwk5Sm0B J+tkCg7wLFbmmfZMi6IlkOF5kMeeOTnQrRZ2DfcMY0VziwG1856+R4AVB526cDJWaBCV IXtfyCotas9k8fwSmFfaAZLDuHmfTWXrkSdvTxMEEe1Poyc/WWjsGF8oreqAoqe6PdYY ehhHE4psIpGgBQznFHxFvMJnNGmeRXKdRMXQtt/fiUQZblvv+yF83hM2RVWOT3h/xBcp 2IzMSPvsIYY7D51HvLjnNpXSGfHbOG+zA6Crztpx2nFBAIk9scp+3a+ZLY9JfntjicAt D/oA== X-Gm-Message-State: ALyK8tJNC51yWZ6w0cBjGdyCzbfr5E1U7ef4KJPT3Opl7tBeUFXDkmRYX7ifvrSnonJFit8S X-Received: by 10.194.95.66 with SMTP id di2mr5707072wjb.12.1465406443078; Wed, 08 Jun 2016 10:20:43 -0700 (PDT) Received: from mpn-glaptop ([2620:0:105f:301:a074:86fc:806:e9d]) by smtp.gmail.com with ESMTPSA id v200sm1593509wmv.4.2016.06.08.10.20.41 for <23729-done@debbugs.gnu.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Jun 2016 10:20:42 -0700 (PDT) From: Michal Nazarewicz To: 23729-done@debbugs.gnu.org Subject: Re: bug#23729: [PATCH] Remove =?utf-8?Q?=E2=80=98ert-with-functio?= =?utf-8?Q?n-mocked=E2=80=99?= macro in favour of =?utf-8?B?4oCYY2wtbGV0?= =?utf-8?B?ZuKAmQ==?= macro In-Reply-To: Organization: http://mina86.com/ References: <1465389879-14248-1-git-send-email-mina86@mina86.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160608:rgm@gnu.org::JsbtW/Xq75gWDk7O:00000011TG X-Hashcash: 1:20:160608:23729@debbugs.gnu.org::AbHM5Aww20o7Apnk:00000000000000000000000000000000000000006Qk4 Date: Wed, 08 Jun 2016 19:20:41 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 23729-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) UGF0Y2ggYXBwbGllZC4NCg0KLS0gDQpCZXN0IHJlZ2FyZHMNCuODn+ODj+OCpiDigJzwnZO28J2T svCdk7fwnZOqODbigJ0g44OK44K244Os44O044Kk44OEDQrCq0lmIGF0IGZpcnN0IHlvdSBkb27i gJl0IHN1Y2NlZWQsIGdpdmUgdXAgc2t5ZGl2aW5nwrsNCg== From unknown Mon Jun 16 23:28:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Jul 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator