GNU bug report logs - #23725
25.0.94; Org mode uses removed aliases to scroll the calendar

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23725 in the body.
You can then email your comments to 23725 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.0.94; Org mode uses removed aliases to scroll the calendar
Date: Wed, 08 Jun 2016 09:19:48 +0300

Org mode uses aliases that were removed by this commit:

  commit 3f65970414538063e38ada2a47cb4ef4f35b630e
  Author: Glenn Morris <rgm <at> gnu.org>
  Date:   Sun Oct 5 19:02:04 2014 -0700
  
      Remove calendar code obsolete since at least version 23.1

The following patch fixes the problem.

* lisp/org/org.el (org-read-date-minibuffer-local-map):
Use correct function names instead of their removed aliases.

diff --git a/lisp/org/org.el b/lisp/org/org.el
index 61bcb45..13e4a22 100644
--- a/lisp/org/org.el
+++ b/lisp/org/org.el
@@ -16296,10 +16296,10 @@ org-read-date-minibuffer-local-map
                   (message "")))
     (org-defkey map ">"
                 (lambda () (interactive)
-                  (org-eval-in-calendar '(scroll-calendar-left 1))))
+                  (org-eval-in-calendar '(calendar-scroll-left 1))))
     (org-defkey map "<"
                 (lambda () (interactive)
-                  (org-eval-in-calendar '(scroll-calendar-right 1))))
+                  (org-eval-in-calendar '(calendar-scroll-right 1))))
     (org-defkey map "\C-v"
                 (lambda () (interactive)
                   (org-eval-in-calendar


In GNU Emacs 25.0.94.8 (x86_64-unknown-linux-gnu, GTK+ Version 3.20.6)
 of 2016-06-08 built on arirop
Repository revision: 1f85b7ca034ee4f96d796d95ec86bc4fa0ba8aa3
Windowing system distributor 'Fedora Project', version 11.0.11803000
System Description:	Fedora release 24 (Twenty Four)

Message #8 received at 23725 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: 23725 <at> debbugs.gnu.org
Subject: Re: bug#23725: 25.0.94;
 Org mode uses removed aliases to scroll the calendar
Date: Wed, 08 Jun 2016 09:49:53 -0400

Ari Roponen <ari.roponen <at> gmail.com> writes:

> Org mode uses aliases that were removed by this commit:
>
>   commit 3f65970414538063e38ada2a47cb4ef4f35b630e
>   Author: Glenn Morris <rgm <at> gnu.org>
>   Date:   Sun Oct 5 19:02:04 2014 -0700
>
>       Remove calendar code obsolete since at least version 23.1

This was fixed in the upstream Org repo with 8b63dc9 (org.el: Fix
bindings of < and > for calendar scrolling, 2014-10-20), which is
included in version 8.3.

--
Kyle

Message #13 received at 23725 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: Ari Roponen <ari.roponen <at> gmail.com>, 23725 <at> debbugs.gnu.org
Subject: Re: bug#23725: 25.0.94;
 Org mode uses removed aliases to scroll the calendar
Date: Wed, 08 Jun 2016 11:42:16 -0400

Kyle Meyer wrote:

> Ari Roponen <ari.roponen <at> gmail.com> writes:
>
>> Org mode uses aliases that were removed by this commit:
>>
>>   commit 3f65970414538063e38ada2a47cb4ef4f35b630e
>>   Author: Glenn Morris <rgm <at> gnu.org>
>>   Date:   Sun Oct 5 19:02:04 2014 -0700
>>
>>       Remove calendar code obsolete since at least version 23.1
>
> This was fixed in the upstream Org repo with 8b63dc9 (org.el: Fix
> bindings of < and > for calendar scrolling, 2014-10-20), which is
> included in version 8.3.

But not included in the version included with Emacs. Please could
someone port that fix to the emacs-25 branch.

(If simple fixes don't get propagated for over a year, the system isn't
working.)

Message #18 received at 23725-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 23725-done <at> debbugs.gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>, Ari Roponen <ari.roponen <at> gmail.com>
Subject: Re: bug#23725: 25.0.94; Org mode uses removed aliases to scroll the
 calendar
Date: Wed, 8 Jun 2016 16:05:40 -0700

I installed the patch and am marking this as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.