From unknown Tue Aug 19 14:22:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23708: [PATCH] package: =?UTF-8?Q?don=E2=80=99t?= hard code port number in test Resent-From: Michal Nazarewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Jun 2016 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23708@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1465242839300 (code B ref -1); Mon, 06 Jun 2016 19:54:01 +0000 Received: (at submit) by debbugs.gnu.org; 6 Jun 2016 19:53:59 +0000 Received: from localhost ([127.0.0.1]:57074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0b0-0008WS-OX for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0az-0008WD-DL for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA0as-00046G-Qa for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,NORMAL_HTTP_TO_IP, T_DKIM_INVALID,WEIRD_PORT autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0as-000467-Ns for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0aq-0007e9-4o for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA0ak-00045e-U1 for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:47 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:36622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0ak-000454-JX for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:42 -0400 Received: by mail-wm0-x22a.google.com with SMTP id n184so107695515wmn.1 for ; Mon, 06 Jun 2016 12:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YWa9cuhTkPjaJz4Qmyk/XTG6M3zVTth5nYgC3ML9Cms=; b=hpSesSBtj2x/lEq3k91edni7pIpZTxDeXHsfbRySMhbDDwIAsICwrg1dl1OvvCMPGR zViOCjAIX2aUrKhqBIbRsTnbDPXrXPgOIKjIwLIOMlmSP0KWeGrTFdriVZAej8afIMbw MYk32rDS/Dl6+07wss5xoNIgn01kVPFtNQs0nxUcHZJY4VkGGy82S9Cp6e47+QDgOuKF rQqxOjYwLr+pAaSZ0ECa6+j9ZxcE6ym80l24GfsV5Q5CIJI405/mtVDr2XvzLInGH8Mg 8bJlRqRsBzwcXPO9CnT4uQHYIZvARe3ggEQoSVpN1MSX4N8q/ByzN2s2b8jKN9lg6HF6 d7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=YWa9cuhTkPjaJz4Qmyk/XTG6M3zVTth5nYgC3ML9Cms=; b=hTJLzlXCpNJhzFFg7sdX9cJlxU6rHogbd/Y/c0cQ4eG3jcmCFFQYMBPqqio2TtIzrK pXZI65KQpNNxI9oE6wCvPn2cPc82wgCK4CUdKbGG7ZPRpep9qU/kcT/GKi81mtY6MA0k KWWf1u+epZ0jESIdpDFIPaQuhzM7+z4bLkFw+SrDbItSXPlmoskNMdAlYAwqvBEeHfeZ j0jt6sai5XB+tY7umuiaawQTItyynzawSBjcwPD3R7uGKdclOPGGVYMfnGRl5Al4oO6m kTI8ou1Kz/NNZnjg05FLYYMOvgY263adbgh8hMrIURC9LpnrErnSYYI4mlTg7QPKgD8f fWvQ== X-Gm-Message-State: ALyK8tJcpBdmxsJpLmbPM8F7/X+BbXjcy4Z9tbNt1uhXdlZAnTJG/NvLBp6m9Y11HhoHFqXs X-Received: by 10.28.30.209 with SMTP id e200mr419628wme.90.1465242820552; Mon, 06 Jun 2016 12:53:40 -0700 (PDT) Received: from mpn.zrh.corp.google.com ([2620:0:105f:301:591a:9192:38e9:8b21]) by smtp.gmail.com with ESMTPSA id u4sm21790752wjz.4.2016.06.06.12.53.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jun 2016 12:53:38 -0700 (PDT) Received: by mpn.zrh.corp.google.com (Postfix, from userid 126942) id A9AAE1E35D5; Mon, 6 Jun 2016 21:53:37 +0200 (CEST) From: Michal Nazarewicz Date: Mon, 6 Jun 2016 21:53:33 +0200 Message-Id: <1465242813-2309-1-git-send-email-mina86@mina86.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hard coding port 8000 in package-tests.el causes the test to fail if something is already listening on that port. Change code so it uses any available port. * tests/lisp/emacs-lisp/package-tests.el (package-test-update-archives-async): Do not hard code port number and instead parse it from server’s standard output. * tests/lisp/emacs-lisp/package-resources/package-test-server.py: Do not hard code port number. Use any available one instead. --- .../package-resources/package-test-server.py | 15 ++---- test/lisp/emacs-lisp/package-tests.el | 54 ++++++++++++---------- 2 files changed, 34 insertions(+), 35 deletions(-) diff --git a/test/lisp/emacs-lisp/package-resources/package-test-server.py b/test/lisp/emacs-lisp/package-resources/package-test-server.py index 35ca820..78e40b3 100644 --- a/test/lisp/emacs-lisp/package-resources/package-test-server.py +++ b/test/lisp/emacs-lisp/package-resources/package-test-server.py @@ -1,21 +1,16 @@ -import sys +import os import BaseHTTPServer from SimpleHTTPServer import SimpleHTTPRequestHandler - HandlerClass = SimpleHTTPRequestHandler ServerClass = BaseHTTPServer.HTTPServer Protocol = "HTTP/1.0" -if sys.argv[1:]: - port = int(sys.argv[1]) -else: - port = 8000 - server_address = ('127.0.0.1', port) +os.chdir(os.path.dirname(__file__)) HandlerClass.protocol_version = Protocol -httpd = ServerClass(server_address, HandlerClass) +httpd = ServerClass(('127.0.0.1', 0), HandlerClass) -sa = httpd.socket.getsockname() -print "Serving HTTP on", sa[0], "port", sa[1], "..." +# This printed line is parsed by test code, don't change its format. +print "Serving on http://%s:%s/" % httpd.socket.getsockname() httpd.serve_forever() diff --git a/test/lisp/emacs-lisp/package-tests.el b/test/lisp/emacs-lisp/package-tests.el index c7a5cc7..4ffb173 100644 --- a/test/lisp/emacs-lisp/package-tests.el +++ b/test/lisp/emacs-lisp/package-tests.el @@ -372,31 +372,35 @@ package-test-desc-version-string (skip-unless (executable-find "python2")) ;; For some reason this test doesn't work reliably on hydra.nixos.org. (skip-unless (not (getenv "NIX_STORE"))) - (with-package-test (:basedir - package-test-data-dir - :location "http://0.0.0.0:8000/") - (let* ((package-menu-async t) - (process (start-process - "package-server" "package-server-buffer" - (executable-find "python2") - (expand-file-name "package-test-server.py")))) - (unwind-protect - (progn - (list-packages) - (should package--downloads-in-progress) - (should mode-line-process) - (should-not - (with-timeout (10 'timeout) - (while package--downloads-in-progress - (accept-process-output nil 1)) - nil)) - ;; If the server process died, there's some non-Emacs problem. - ;; Eg maybe the port was already in use. - (skip-unless (process-live-p process)) - (goto-char (point-min)) - (should - (search-forward-regexp "^ +simple-single" nil t))) - (if (process-live-p process) (kill-process process)))))) + + (with-temp-buffer + (cd package-test-data-dir) + (let ((package-menu-async t) + (process (start-process "package-server" (current-buffer) + (executable-find "python2") + (expand-file-name "package-test-server.py")))) + ;; Killing temp buffer will kill the process. + (set-process-query-on-exit-flag process nil) + + (with-package-test + (:location (with-timeout (5 (should-not 'timeout)) + (while (and (goto-char (point-min)) + (not (re-search-forward + "^Serving on \\(http://.*/\\)" nil t))) + (accept-process-output process 1)) + (match-string 1))) + (list-packages) + (should package--downloads-in-progress) + (should mode-line-process) + (should-not (with-timeout (10 'timeout) + (while package--downloads-in-progress + (accept-process-output nil 1)) + nil)) + ;; If the server process died, there's some non-Emacs problem. + ;; Eg maybe the port was already in use. + (skip-unless (process-live-p process)) + (goto-char (point-min)) + (should (search-forward-regexp "^ +simple-single" nil t)))))) (ert-deftest package-test-describe-package () "Test displaying help for a package." -- 2.8.0.rc3.226.g39d4020 From unknown Tue Aug 19 14:22:47 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Michal Nazarewicz Subject: bug#23708: closed (Re: bug#23708: [PATCH] package: =?UTF-8?Q?don=E2=80=99t?= hard code port number in test) Message-ID: References: <1465242813-2309-1-git-send-email-mina86@mina86.com> X-Gnu-PR-Message: they-closed 23708 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 23708@debbugs.gnu.org Date: Wed, 08 Jun 2016 01:27:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1465349222-27911-1" This is a multi-part message in MIME format... ------------=_1465349222-27911-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23708: [PATCH] package: don=E2=80=99t hard code port number in test which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23708@debbugs.gnu.org. --=20 23708: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23708 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1465349222-27911-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23708-done) by debbugs.gnu.org; 8 Jun 2016 01:26:35 +0000 Received: from localhost ([127.0.0.1]:59286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bASGQ-0007FY-Np for submit@debbugs.gnu.org; Tue, 07 Jun 2016 21:26:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bASGP-0007FM-8w for 23708-done@debbugs.gnu.org; Tue, 07 Jun 2016 21:26:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bASGI-0002oi-Ti for 23708-done@debbugs.gnu.org; Tue, 07 Jun 2016 21:26:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bASGI-0002oe-Qu for 23708-done@debbugs.gnu.org; Tue, 07 Jun 2016 21:26:26 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bASGH-0004ZS-V8; Tue, 07 Jun 2016 21:26:26 -0400 From: Glenn Morris To: 23708-done@debbugs.gnu.org Subject: Re: bug#23708: [PATCH] package: =?utf-8?Q?don=E2=80=99t?= hard code port number in test References: <1465242813-2309-1-git-send-email-mina86@mina86.com> X-Spook: MP5K-SD Sundevil militia Blowpipe Human to Animal AMEMB X-Ran: :rL@j1s]/Bl3$i+$daY~>cC;e0)XMFgRF~VVF5q/E`DOI]>K!xXO?{+0l_E/"*=6f{R7F8 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 07 Jun 2016 21:26:25 -0400 In-Reply-To: <1465242813-2309-1-git-send-email-mina86@mina86.com> (Michal Nazarewicz's message of "Mon, 6 Jun 2016 21:53:33 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23708-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) Version: 25.2 Thanks; I installed something similar. ------------=_1465349222-27911-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Jun 2016 19:53:59 +0000 Received: from localhost ([127.0.0.1]:57074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0b0-0008WS-OX for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA0az-0008WD-DL for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA0as-00046G-Qa for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,NORMAL_HTTP_TO_IP, T_DKIM_INVALID,WEIRD_PORT autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0as-000467-Ns for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:53:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57105) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0aq-0007e9-4o for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA0ak-00045e-U1 for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:47 -0400 Received: from mail-wm0-x22a.google.com ([2a00:1450:400c:c09::22a]:36622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA0ak-000454-JX for bug-gnu-emacs@gnu.org; Mon, 06 Jun 2016 15:53:42 -0400 Received: by mail-wm0-x22a.google.com with SMTP id n184so107695515wmn.1 for ; Mon, 06 Jun 2016 12:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=YWa9cuhTkPjaJz4Qmyk/XTG6M3zVTth5nYgC3ML9Cms=; b=hpSesSBtj2x/lEq3k91edni7pIpZTxDeXHsfbRySMhbDDwIAsICwrg1dl1OvvCMPGR zViOCjAIX2aUrKhqBIbRsTnbDPXrXPgOIKjIwLIOMlmSP0KWeGrTFdriVZAej8afIMbw MYk32rDS/Dl6+07wss5xoNIgn01kVPFtNQs0nxUcHZJY4VkGGy82S9Cp6e47+QDgOuKF rQqxOjYwLr+pAaSZ0ECa6+j9ZxcE6ym80l24GfsV5Q5CIJI405/mtVDr2XvzLInGH8Mg 8bJlRqRsBzwcXPO9CnT4uQHYIZvARe3ggEQoSVpN1MSX4N8q/ByzN2s2b8jKN9lg6HF6 d7nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=YWa9cuhTkPjaJz4Qmyk/XTG6M3zVTth5nYgC3ML9Cms=; b=hTJLzlXCpNJhzFFg7sdX9cJlxU6rHogbd/Y/c0cQ4eG3jcmCFFQYMBPqqio2TtIzrK pXZI65KQpNNxI9oE6wCvPn2cPc82wgCK4CUdKbGG7ZPRpep9qU/kcT/GKi81mtY6MA0k KWWf1u+epZ0jESIdpDFIPaQuhzM7+z4bLkFw+SrDbItSXPlmoskNMdAlYAwqvBEeHfeZ j0jt6sai5XB+tY7umuiaawQTItyynzawSBjcwPD3R7uGKdclOPGGVYMfnGRl5Al4oO6m kTI8ou1Kz/NNZnjg05FLYYMOvgY263adbgh8hMrIURC9LpnrErnSYYI4mlTg7QPKgD8f fWvQ== X-Gm-Message-State: ALyK8tJcpBdmxsJpLmbPM8F7/X+BbXjcy4Z9tbNt1uhXdlZAnTJG/NvLBp6m9Y11HhoHFqXs X-Received: by 10.28.30.209 with SMTP id e200mr419628wme.90.1465242820552; Mon, 06 Jun 2016 12:53:40 -0700 (PDT) Received: from mpn.zrh.corp.google.com ([2620:0:105f:301:591a:9192:38e9:8b21]) by smtp.gmail.com with ESMTPSA id u4sm21790752wjz.4.2016.06.06.12.53.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jun 2016 12:53:38 -0700 (PDT) Received: by mpn.zrh.corp.google.com (Postfix, from userid 126942) id A9AAE1E35D5; Mon, 6 Jun 2016 21:53:37 +0200 (CEST) From: Michal Nazarewicz To: bug-gnu-emacs@gnu.org Subject: [PATCH] =?UTF-8?q?package:=20don=E2=80=99t=20hard=20code=20po?= =?UTF-8?q?rt=20number=20in=20test?= Date: Mon, 6 Jun 2016 21:53:33 +0200 Message-Id: <1465242813-2309-1-git-send-email-mina86@mina86.com> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hard coding port 8000 in package-tests.el causes the test to fail if something is already listening on that port. Change code so it uses any available port. * tests/lisp/emacs-lisp/package-tests.el (package-test-update-archives-async): Do not hard code port number and instead parse it from server’s standard output. * tests/lisp/emacs-lisp/package-resources/package-test-server.py: Do not hard code port number. Use any available one instead. --- .../package-resources/package-test-server.py | 15 ++---- test/lisp/emacs-lisp/package-tests.el | 54 ++++++++++++---------- 2 files changed, 34 insertions(+), 35 deletions(-) diff --git a/test/lisp/emacs-lisp/package-resources/package-test-server.py b/test/lisp/emacs-lisp/package-resources/package-test-server.py index 35ca820..78e40b3 100644 --- a/test/lisp/emacs-lisp/package-resources/package-test-server.py +++ b/test/lisp/emacs-lisp/package-resources/package-test-server.py @@ -1,21 +1,16 @@ -import sys +import os import BaseHTTPServer from SimpleHTTPServer import SimpleHTTPRequestHandler - HandlerClass = SimpleHTTPRequestHandler ServerClass = BaseHTTPServer.HTTPServer Protocol = "HTTP/1.0" -if sys.argv[1:]: - port = int(sys.argv[1]) -else: - port = 8000 - server_address = ('127.0.0.1', port) +os.chdir(os.path.dirname(__file__)) HandlerClass.protocol_version = Protocol -httpd = ServerClass(server_address, HandlerClass) +httpd = ServerClass(('127.0.0.1', 0), HandlerClass) -sa = httpd.socket.getsockname() -print "Serving HTTP on", sa[0], "port", sa[1], "..." +# This printed line is parsed by test code, don't change its format. +print "Serving on http://%s:%s/" % httpd.socket.getsockname() httpd.serve_forever() diff --git a/test/lisp/emacs-lisp/package-tests.el b/test/lisp/emacs-lisp/package-tests.el index c7a5cc7..4ffb173 100644 --- a/test/lisp/emacs-lisp/package-tests.el +++ b/test/lisp/emacs-lisp/package-tests.el @@ -372,31 +372,35 @@ package-test-desc-version-string (skip-unless (executable-find "python2")) ;; For some reason this test doesn't work reliably on hydra.nixos.org. (skip-unless (not (getenv "NIX_STORE"))) - (with-package-test (:basedir - package-test-data-dir - :location "http://0.0.0.0:8000/") - (let* ((package-menu-async t) - (process (start-process - "package-server" "package-server-buffer" - (executable-find "python2") - (expand-file-name "package-test-server.py")))) - (unwind-protect - (progn - (list-packages) - (should package--downloads-in-progress) - (should mode-line-process) - (should-not - (with-timeout (10 'timeout) - (while package--downloads-in-progress - (accept-process-output nil 1)) - nil)) - ;; If the server process died, there's some non-Emacs problem. - ;; Eg maybe the port was already in use. - (skip-unless (process-live-p process)) - (goto-char (point-min)) - (should - (search-forward-regexp "^ +simple-single" nil t))) - (if (process-live-p process) (kill-process process)))))) + + (with-temp-buffer + (cd package-test-data-dir) + (let ((package-menu-async t) + (process (start-process "package-server" (current-buffer) + (executable-find "python2") + (expand-file-name "package-test-server.py")))) + ;; Killing temp buffer will kill the process. + (set-process-query-on-exit-flag process nil) + + (with-package-test + (:location (with-timeout (5 (should-not 'timeout)) + (while (and (goto-char (point-min)) + (not (re-search-forward + "^Serving on \\(http://.*/\\)" nil t))) + (accept-process-output process 1)) + (match-string 1))) + (list-packages) + (should package--downloads-in-progress) + (should mode-line-process) + (should-not (with-timeout (10 'timeout) + (while package--downloads-in-progress + (accept-process-output nil 1)) + nil)) + ;; If the server process died, there's some non-Emacs problem. + ;; Eg maybe the port was already in use. + (skip-unless (process-live-p process)) + (goto-char (point-min)) + (should (search-forward-regexp "^ +simple-single" nil t)))))) (ert-deftest package-test-describe-package () "Test displaying help for a package." -- 2.8.0.rc3.226.g39d4020 ------------=_1465349222-27911-1-- From unknown Tue Aug 19 14:22:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23708: closed ( bug#23708: [PATCH] package: =?UTF-8?Q?don=E2=80=99t?= hard code port number in test) Resent-From: Michal Nazarewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2016 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23708@debbugs.gnu.org Received: via spool by 23708-submit@debbugs.gnu.org id=B23708.146538926923572 (code B ref 23708); Wed, 08 Jun 2016 12:35:02 +0000 Received: (at 23708) by debbugs.gnu.org; 8 Jun 2016 12:34:29 +0000 Received: from localhost ([127.0.0.1]:59900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAcgm-000688-V0 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 08:34:29 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAcgl-00067w-1W for 23708@debbugs.gnu.org; Wed, 08 Jun 2016 08:34:27 -0400 Received: by mail-wm0-f46.google.com with SMTP id n184so179564526wmn.1 for <23708@debbugs.gnu.org>; Wed, 08 Jun 2016 05:34:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:subject:in-reply-to:organization:references :user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=Lgxx71vSrKJqhGUQARzBMaTBHjJskZP4hFc9pNTE8zA=; b=lglPzbDx6sjzQfKJkTM4LdOUkrh0QgoNqb7C5Z5O2UZjlAWUZh2UHB1c9AgHt8JGs2 /jyTjrBowgT9OAJ/nCIOaq6oRFiLbHHk3f1MaQhL6Qz4lUzinqf5CXX+erEcAKBspYER EnxIS7ser/Y6GhdtK5GQoOP+RoHJaddAmeuR/c9cf4ToMc92qrhhBH59Oof8aXSuJepM DCy2kvJ73Wd87fjy3g439xh6AaPgjDfnNUj5v6YaNG+MVL+TcHCk9aeb15v8nJ43uvCf PN1H/mYOQmev2gwUIopdKJS7Z2/kitZo+pICbiD/2Hmfq05ZAdbVGMEYT1HwA+beVn0u 6CZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:in-reply-to:organization :references:user-agent:face:date:message-id:mime-version :content-transfer-encoding; bh=Lgxx71vSrKJqhGUQARzBMaTBHjJskZP4hFc9pNTE8zA=; b=kdH7VPs5ePzjAD0XMqJDu8W3a0ePjjOkqTbttde/2qiJXeRK7LJA82hkkZImFBLaab nOBe/fE3C7DI5P3Jwo57z5TTj+gWfSksLdCpyjcFXquKY7wyLigst/kGY1X/hDrlYNxu mKmxJc2cV4dg3tZRe+o4dVe3W5r2Wfoe/nOWHTOKKGmzG/TkByxxqXzVx7rygjPy21P/ cSg5qsCwwmLtUgguDOlU4XrtgDtAqOEo0mr9/CJPpxqv8bV3Od1yXrBsu89MMEXPF6qT IrreaUOoJDteOOX9dNTemyhQvrg0hLtQ98O4dksZc/V1bAEu9D/TZ79F/Vw+ZlBHAoLL JYUQ== X-Gm-Message-State: ALyK8tI1z3Vy7oKN6UwgLkgGDOlqcE4nIJTwnmOYZ6+N7eyg9id3C8DDSJW1cQm9ZHn1D6Zq X-Received: by 10.28.85.3 with SMTP id j3mr8298054wmb.0.1465389260904; Wed, 08 Jun 2016 05:34:20 -0700 (PDT) Received: from mpn-glaptop ([2620:0:105f:301:a074:86fc:806:e9d]) by smtp.gmail.com with ESMTPSA id f12sm24579283wme.13.2016.06.08.05.34.19 for <23708@debbugs.gnu.org> (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 08 Jun 2016 05:34:19 -0700 (PDT) From: Michal Nazarewicz In-Reply-To: Organization: http://mina86.com/ References: <1465242813-2309-1-git-send-email-mina86@mina86.com> User-Agent: Notmuch/0.19+53~g2e63a09 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-unknown-linux-gnu) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACP0lEQVQ4T23Sv2vbQBQHcBk1xE6WyALX107VUEgmn6+ouUwpEQQ6uRjttkWP4CkBg2M0BQLBdPFZYPsyFYo7qEtKDQ7on+t7+nF2Ux8ahD587717OmNYrOvycHsZ+o2r051wHTHysAvGb8ygvgu4QWT0sCmkgZCIEnlV2X8BtyraazFGDuxhmKSQJMlwHQ7v5MHSNxmz78rfElwAa3ieVD9e+hBhjaPDDG6NgFo2f4wBMNIo5YmRtF0RyDgFjJjlMIWbnuM4x9MMfABGTlN4qgIQB4A1DEyA1BHWtfeWNUMwiVJKoqh97KrkOO+qzgluVYLvFCUKAX73nONeBr7BGMdM6Sg0kuep03VywLaIzRiVr+GAzKlpQIsAFnWAG2e6DT5WmWDiudZMIc6hYrMOmeMQK9WX0B+/RfjzL9DI7Y9/Iayn29Ci0r2i4f9gMimMSZLCDMalgQGU5hnUtqAN0OGvEmO1Wnl0C0wWSCEHnuHBqmygxdxA8oWXwbipoc1EoNR9DqOpBpOJrnr0criQab9ZT4LL+wI+K7GBQH30CrhUruilgP9DRTrhVWZCiAyILP+wiuLeCKGTD6r/nc8LOJcAwR6IBTUs+7CASw3QFZ0MdA2PI3zNziH4ZKVhXCRMBjeZ1DWMekKwDCASwExy+NQ86TaykaDAFHO4aP48y4fIcDM5yOG8GcTLbOyp8A8azjJI93JFd1EA6yN8sSxMQJWoABqniRZVykYgRXErzrdqExAoUrRb0xfRp8p2A/4XmfilTtkDZ4cAAAAASUVORK5CYII= X-Face: -TR8(rDTHy/(xl?SfWd1|3:TTgDIatE^t'vop%*gVg[kn$t{EpK(P"VQ=~T2#ysNmJKN$"yTRLB4YQs$4{[.]Fc1)*O]3+XO^oXM>Q#b^ix, O)Zbn)q[y06$`e3?C)`CwR9y5riE=fv^X@x$y?D:XO6L&x4f-}}I4=VRNwiA^t1-ZrVK^07.Pi/57c_du'& X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:160608:23708@debbugs.gnu.org::39bDRvADob8VjfC1:00000000000000000000000000000000000000002K4D Date: Wed, 08 Jun 2016 14:34:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Glenn Morris wrote: > Thanks; I installed something similar. Note that currently argument parsing in package-test-server.py is dysfunctional (passing an argument causes server_address to never be set) so while my patch would fix that (by removing that unused feature). --=20 Best regards =E3=83=9F=E3=83=8F=E3=82=A6 =E2=80=9C=F0=9D=93=B6=F0=9D=93=B2=F0=9D=93=B7= =F0=9D=93=AA86=E2=80=9D =E3=83=8A=E3=82=B6=E3=83=AC=E3=83=B4=E3=82=A4=E3=83= =84 =C2=ABIf at first you don=E2=80=99t succeed, give up skydiving=C2=BB From unknown Tue Aug 19 14:22:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23708: closed ( bug#23708: [PATCH] package: =?UTF-8?Q?don=E2=80=99t?= hard code port number in test) Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jun 2016 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michal Nazarewicz Cc: 23708@debbugs.gnu.org Received: via spool by 23708-submit@debbugs.gnu.org id=B23708.146540180418144 (code B ref 23708); Wed, 08 Jun 2016 16:04:02 +0000 Received: (at 23708) by debbugs.gnu.org; 8 Jun 2016 16:03:24 +0000 Received: from localhost ([127.0.0.1]:33012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfwx-0004ia-He for submit@debbugs.gnu.org; Wed, 08 Jun 2016 12:03:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAfww-0004iO-BJ for 23708@debbugs.gnu.org; Wed, 08 Jun 2016 12:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAfwq-0005Za-D8 for 23708@debbugs.gnu.org; Wed, 08 Jun 2016 12:03:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:45974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAfwA-0005Ks-Cy; Wed, 08 Jun 2016 12:02:34 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAfw9-0002vA-RO; Wed, 08 Jun 2016 12:02:33 -0400 From: Glenn Morris References: <1465242813-2309-1-git-send-email-mina86@mina86.com> X-Spook: S Key Abu Sayyaf condor Israel Ortega National X-Ran: L]()BaO+a-(1l+<|]bQ3e}Oy5mIu8>Le5[xq}#k0na!PAh8@P]YG2m~=:+}HKEk2WtI^H@ X-Hue: white X-Attribution: GM Date: Wed, 08 Jun 2016 12:02:33 -0400 In-Reply-To: (Michal Nazarewicz's message of "Wed, 08 Jun 2016 14:34:19 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) Michal Nazarewicz wrote: > Note that currently argument parsing in package-test-server.py is > dysfunctional (passing an argument causes server_address to never be > set) so while my patch would fix that (by removing that unused feature). (Sorry, I did not notice that you have write access.) Feel free to fix that if it bothers you. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 17 02:28:35 2016 Received: (at control) by debbugs.gnu.org; 17 Oct 2016 06:28:35 +0000 Received: from localhost ([127.0.0.1]:35945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw1PX-0001ye-7Y for submit@debbugs.gnu.org; Mon, 17 Oct 2016 02:28:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bw1PV-0001yO-Vs for control@debbugs.gnu.org; Mon, 17 Oct 2016 02:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bw1PP-0000nk-N4 for control@debbugs.gnu.org; Mon, 17 Oct 2016 02:28:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bw1PP-0000nf-Jn for control@debbugs.gnu.org; Mon, 17 Oct 2016 02:28:27 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bw1PP-0004G2-4X for control@debbugs.gnu.org; Mon, 17 Oct 2016 02:28:27 -0400 Subject: control message for bug 23708 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Mon, 17 Oct 2016 02:28:27 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) unarchive 23708 fixed 23708 26.1 notfixed 23708 25.2