From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Jun 2016 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23695@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146511834714706 (code B ref -1); Sun, 05 Jun 2016 09:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jun 2016 09:19:07 +0000 Received: from localhost ([127.0.0.1]:54882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD5-0003p8-E5 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD4-0003oe-2G for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCx-0008NJ-S6 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCx-0008ND-Ow for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:18:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCv-0007AK-Dm for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCp-0008M1-Dk for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:56 -0400 Received: from mout.gmx.net ([212.227.15.18]:50311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCp-0008Lu-2v for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:51 -0400 Received: from rosalinde ([89.245.71.113]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LfkUs-1boZJ73sOg-00pNKV for ; Sun, 05 Jun 2016 11:18:48 +0200 From: Stephen Berman Date: Sun, 05 Jun 2016 11:18:46 +0200 Message-ID: <87y46km1s9.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:BFqVnjhTvJQ37jz2hsqeWR6XleuLlpmqxRcqm4nUT+W/MlBWxtk M3IaZ9XUEOyTWITGza5hdiUhaHI7MEl8RwOhvL40HGZ0/fpNOwGtKXVFFa1bPibHvfN7CBz ftQVgDHKh+hwN90TnnjjJWLouMvxzYabniW8fA2UrSLnEXhY44Wa87KqbSfJR7UJFUlJlUc OtKoi1jlU9O7ArirHbFvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2vCupVTzOTQ=:D9Qvs5dEXuCCCbqU+gKQxX V+c42bBCiH/cZ8F1uuUicOTohoRYA1CoyGarI5vhmdMS1w/ZAh0BBeAEh/PKwkTbEmiaVrn+p 6/0TJ/fjfIhgZX/r/zWP5l1Pvm1HjNDnTWWFWU90DtwsZGDNrPdjh97dnRYh84UXWW+sEON7P pLzCh47cfBqj+T9+WBZ4CRUJnAvyHwfcZU6WvfAe2IcrKLPoz4+hGdxacJKDf2WwOTilCwGHf yjRzcox3cIcVcy8lh+IL/De2V4mY4NcXMHsVqh2U+0chZqpfayK2S9kzYj+dd2WZ9Iuq4fyXy QMncQCpw2E2pKdj0ACDBqKqHdXLB3aXTZfBhCwcesNbFGClp+0mRNjPeSi6iYdIPabSXvQxp7 RjmWxgGsgLbrH6sH+J2+EjlZEtHTtqucM+cxiqch5TqgXqHS4rthGZS9SOxZh5pri2Fae/iWL 9RIo1Nax846UapW9CzCUZRqBpyNPYSm6MLLyVK4sLGfXL5fpTRl9gbhfHO2TNs6AAlOGhvAFO NCgtxgvcGbXND/Oe+hiceZe3zgsPTIAND+oSf9idZ8j2nL3zUNhqPLnUg3ruU7wGzli8Qv9pu zGfal/TwcSK42bvj5YGqI7Vd/B4dsBRxmDBB3z3UzS28vKoJZN2h7T9CfDe4lJc72bzl8m4BO I00rW43No51Yc3iq7P2laugZEOqtTnJVaWNFJlB3lw7qhvEKGUHb79qPG903tNhEWW/7Jp1uc Q9ikNmWFfjKNaLip2FgDGzt3kQkVD8QByzP4ocmIK2v7iQjHo7s4MB053e0tKQ84NjJ/oI0VI kOHd0QI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 0. emacs -Q 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a *Completions* buffer showing functions beginning with "url-", since SPC in the minibuffer is bound to minibuffer-complete-word. 2. C-g to exit the minibuffer, then, if you have no files made by todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show RET RET RET RET RET' (accepting defaults) to create a todo file with a category and an entry. 3. Type `q' to quit todo-mode (optional) and redo step 1. => Upon typing SPC this time, instead of getting the *Completions* buffer, a space is inserted in the minibuffer after "url-". If at step 2 you already have one or more todo-files, then invoking a number of todo-mode commands, e.g. `j' to jump to another category or `C a' to add a new category, will likewise globally change the effect of all subsequent uses of SPC in the minibuffer. The patch below fixes this. I request approval to push this fix to emacs-25, since without it, todo-mode-specific behavior changes the minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, since it replaces naively implemented functionality by canonical code to temporarily change a minibuffer key binding. (Since I normally don't use SPC for minibuffer completion but just TAB, I only discovered this bug yesterday, when I was trying and failed to reproduce bug#23670 in a session in which I had already used the broken todo-mode function.) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 8e75258..f0d4bc5 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -5750,8 +5750,9 @@ todo-read-category against categories in that file; otherwise complete against all categories from `todo-category-completions-files'." ;; Allow SPC to insert spaces, for adding new category names. - (let ((map minibuffer-local-completion-map)) - (define-key map " " nil) + (let ((minibuffer-local-completion-map + (copy-keymap minibuffer-local-completion-map))) + (define-key minibuffer-local-completion-map " " 'self-insert-command) (let* ((add (eq match-type 'add)) (archive (eq match-type 'archive)) (file0 (when (and file (> (length todo-files) 1)) In GNU Emacs 25.0.94.8 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-06-05 built on rosalinde Repository revision: a5d05f447008c4a99d1b00f0af642b4a5ce4cbce Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2016 09:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23695@debbugs.gnu.org Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.146555090325159 (code B ref 23695); Fri, 10 Jun 2016 09:29:02 +0000 Received: (at 23695) by debbugs.gnu.org; 10 Jun 2016 09:28:23 +0000 Received: from localhost ([127.0.0.1]:35162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBIjn-0006Xj-3i for submit@debbugs.gnu.org; Fri, 10 Jun 2016 05:28:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:50405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBIjl-0006XW-Ji for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 05:28:21 -0400 Received: from rosalinde ([89.245.85.161]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LwF9u-1bVdCL0lsk-018648 for <23695@debbugs.gnu.org>; Fri, 10 Jun 2016 11:28:15 +0200 From: Stephen Berman References: <87y46km1s9.fsf@gmx.net> Date: Fri, 10 Jun 2016 11:28:14 +0200 In-Reply-To: <87y46km1s9.fsf@gmx.net> (Stephen Berman's message of "Sun, 05 Jun 2016 11:18:46 +0200") Message-ID: <8760thxuj5.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:vkqWvEUhgHV0rvGk1NVcdBnMkadSV2Mm/ZFObBoBW0MTfiNidVe ue4vVz0wSG5GoAsbyX+Kmd0S0CR5ax/nipuSZ9FwjExezE9UimMcNmnieNi8QUGByAU/jwV ArWVn98XUjf7eeo9q/Gf24oJoYiTykZUfzrTjrPRzSnAws0bhTTibU05si6T2eHOI6qqTAQ GNN+q8sbBojZljj2EnRIw== X-UI-Out-Filterresults: notjunk:1;V01:K0:QfkGXjUCnOI=:LkcZLbH4ngkeSOWlka/0Wh CFYCjDsl5QfxgZiRXVwbK4eKX41KMv9+japoLHynt2k8F8Kwk08qCOUJJyuO+KKnt0R8zEvg+ db2UVpiJn9jLAN9T+ceoWvhyHIKuogSrYwi+GgcuiXET9zwUXMmv1/esOTdN8mlkljAx3Gg49 AdcoqJtn3WEt3nYcLADY35g3TgYCihqj0K9Bwf5Mffo6mZ3CmijE7H/fulBLedNI+hIxRG2IG gtW13sddIJaq4e09WihklD3SEnj9zUM7tSg3ErbCPMBWpSnnoE55id3Eh4r1ii8kzphNvzc9d w0mo+6hwPZhffBsxjisDtd73HIo/IXYSbF30RQBfYAzZrlnaztpeVc9W2uOpPqkwCER5eP9fn QTooUuNQITjhA8uDbYxZBb/OdkuC9ayIsWVoS3q7RFcbycx7AbvaVAEAepRpRrkmW/rKVZt9/ yBJu6uknvFrqwZ3OIVZMaA4VynW+8wrz2JKfxyYMYow5xtQCZkmURSYbckPFMfVjOna5gE9R8 RwaT61/lfiQV+LyxJsukKDz49KovIutMiU/vCyLIjiRIKzpVsqGiOOX+W1iGIqSw27IoqEKRV DzlfxcSgUgMO84PXBpH7ImrV4SwnbHVYVa/VJ2/6qLJ2Nk3sDJCdZVlbSq3Lp8zrgmFOA5Nzy uRaRpJb7Frq5DAbwzVwJwbWC24VuQQfppdleQZ1JNbt+s8FQPJu8yea48mZClU6Jm4z8pu7ZM WSrR6h6nhp3J7LZUjjCq/qEbRSiMzYD367pFQfO4YDfk5Cbbvxsr0fcK6ULwfwyWWH7o495WO bXIWSN0 X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Sun, 05 Jun 2016 11:18:46 +0200 Stephen Berman wrote: > 0. emacs -Q > 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a > *Completions* buffer showing functions beginning with "url-", since > SPC in the minibuffer is bound to minibuffer-complete-word. > 2. C-g to exit the minibuffer, then, if you have no files made by > todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show > RET RET RET RET RET' (accepting defaults) to create a todo file with > a category and an entry. > 3. Type `q' to quit todo-mode (optional) and redo step 1. > => Upon typing SPC this time, instead of getting the *Completions* > buffer, a space is inserted in the minibuffer after "url-". > > If at step 2 you already have one or more todo-files, then invoking a > number of todo-mode commands, e.g. `j' to jump to another category or > `C a' to add a new category, will likewise globally change the effect of > all subsequent uses of SPC in the minibuffer. > > The patch below fixes this. I request approval to push this fix to > emacs-25, since without it, todo-mode-specific behavior changes the > minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, > since it replaces naively implemented functionality by canonical code to > temporarily change a minibuffer key binding. Ping! Any objections to pushing this fix to emacs-25? Steve Berman From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2016 10:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 23695@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.14655538989611 (code B ref 23695); Fri, 10 Jun 2016 10:19:02 +0000 Received: (at 23695) by debbugs.gnu.org; 10 Jun 2016 10:18:18 +0000 Received: from localhost ([127.0.0.1]:35183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJW5-0002Ux-T8 for submit@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJW5-0002Ul-6I for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBJVv-0002ra-40 for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJVv-0002rJ-0I; Fri, 10 Jun 2016 06:18:07 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4457 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBJVt-0006DN-0X; Fri, 10 Jun 2016 06:18:05 -0400 Date: Fri, 10 Jun 2016 13:18:48 +0300 Message-Id: <83h9d1pcs7.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <8760thxuj5.fsf@gmx.net> (message from Stephen Berman on Fri, 10 Jun 2016 11:28:14 +0200) References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Stephen Berman > Date: Fri, 10 Jun 2016 11:28:14 +0200 > > On Sun, 05 Jun 2016 11:18:46 +0200 Stephen Berman wrote: > > > 0. emacs -Q > > 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a > > *Completions* buffer showing functions beginning with "url-", since > > SPC in the minibuffer is bound to minibuffer-complete-word. > > 2. C-g to exit the minibuffer, then, if you have no files made by > > todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show > > RET RET RET RET RET' (accepting defaults) to create a todo file with > > a category and an entry. > > 3. Type `q' to quit todo-mode (optional) and redo step 1. > > => Upon typing SPC this time, instead of getting the *Completions* > > buffer, a space is inserted in the minibuffer after "url-". > > > > If at step 2 you already have one or more todo-files, then invoking a > > number of todo-mode commands, e.g. `j' to jump to another category or > > `C a' to add a new category, will likewise globally change the effect of > > all subsequent uses of SPC in the minibuffer. > > > > The patch below fixes this. I request approval to push this fix to > > emacs-25, since without it, todo-mode-specific behavior changes the > > minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, > > since it replaces naively implemented functionality by canonical code to > > temporarily change a minibuffer key binding. > > Ping! Any objections to pushing this fix to emacs-25? We've lived with this for the last 2 years, how come it's so urgent now? From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2016 10:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23695@debbugs.gnu.org Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.146555498911474 (code B ref 23695); Fri, 10 Jun 2016 10:37:02 +0000 Received: (at 23695) by debbugs.gnu.org; 10 Jun 2016 10:36:29 +0000 Received: from localhost ([127.0.0.1]:35192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJnh-0002z0-EX for submit@debbugs.gnu.org; Fri, 10 Jun 2016 06:36:29 -0400 Received: from mout.gmx.net ([212.227.17.22]:59580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJng-0002yo-II for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 06:36:29 -0400 Received: from rosalinde ([89.245.85.161]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MUUWN-1b2Lmn0tAR-00RLNl; Fri, 10 Jun 2016 12:36:22 +0200 From: Stephen Berman References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> <83h9d1pcs7.fsf@gnu.org> Date: Fri, 10 Jun 2016 12:36:20 +0200 In-Reply-To: <83h9d1pcs7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jun 2016 13:18:48 +0300") Message-ID: <87y46dwct7.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:9Kxjo9Qsuvk87i6G+H6Z+Rf8NGjG+crB5RJiF/PDsp6mccMnsKA Q14iXRHHLbzjb2VrBJA3Q2dIA/FQXazncc9VwH71zXRmJzWtE8DZq2T7+dKFjsJR0WkYDQt zYWXDvQEJFJ6+YsVvV+lnRJb2Scs0vZ6BxDCT+dFABgvfnGRksZh8VY9/bd8/SToNg40yj6 i9nbfJBk/bzl29V/+eorg== X-UI-Out-Filterresults: notjunk:1;V01:K0:FFyN0y0KlRk=:nIt9ybKcye1Ar2pf0wStwA kKNIOEFFUJpAwggtMNTWzs3xCKd8f6Bqxk1xG6nVqm2SY/ES4Rh36E/vwIubyKPDvAbXriRE8 0/MMUliZxWEU5Hv6+IqBeKw+RRGloeV+GyvbM/YVA3h8xqX9kIR56/eSzCdygEn6qzvZNbQQu vCo5Lwkm+Q5fHK/2CRP99owD4bSX7O5vPqcaXpzYjKEgBn8coH00jAZ+YKGBCrjRbn1lV0HoF 5+bPTsMx5Jy8YPHq/+Z/bEUBCY+tBlXx2pmQGHNKpjEye1BejndfdWokKoF0macEbcfe7u9A+ zxdw1ijQLN/JPwfcfA8PvfHCC1baB+oZx/tIZYJdLo366cvslaQ4JXgXWxN95vgrIfM03eVi7 I2H2WRP/u4O3gLLE3qEeC+7Nh0V2yPSPG23EpcMtXtHYrGsOVz72YgeYU6bHBH2xBIFChHE11 y38DRCsTpN+T5eaR9+i8OSmyESqhnaK5bTYGU673LB7lCD2SSXg1fs4zvIlIr+Ul8KFVgb6VQ TwaJKv940PJ55h5ODdwtbQrsmq/xANLgcxu8Vjo8ZS5a3NdAlhmlTxxw+F+BOi39GP3a2V7Ro 0Xd+BztyZtgHejVowzLPioQRjTzZeuX3vy7oqc22tVvQ4on9vMxfCeB244jxUvutBNB490nZW GKTk6QSlIL1p3krYmzBU3TPM0iFCqwst+6lm5FcT06l53vg3w8hh4pbNdlmzbLmcM7ulk1XiH KLvlLH0YLFm2AEAa/XL5dqeepAIvMORWqswe/1P7a5cGWQwHuNaktHl4yGWtgrOmbAQVgxeEL gTPVPE+ X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Fri, 10 Jun 2016 13:18:48 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 10 Jun 2016 11:28:14 +0200 >> >> On Sun, 05 Jun 2016 11:18:46 +0200 Stephen Berman wrote: >> >> > 0. emacs -Q >> > 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a >> > *Completions* buffer showing functions beginning with "url-", since >> > SPC in the minibuffer is bound to minibuffer-complete-word. >> > 2. C-g to exit the minibuffer, then, if you have no files made by >> > todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show >> > RET RET RET RET RET' (accepting defaults) to create a todo file with >> > a category and an entry. >> > 3. Type `q' to quit todo-mode (optional) and redo step 1. >> > => Upon typing SPC this time, instead of getting the *Completions* >> > buffer, a space is inserted in the minibuffer after "url-". >> > >> > If at step 2 you already have one or more todo-files, then invoking a >> > number of todo-mode commands, e.g. `j' to jump to another category or >> > `C a' to add a new category, will likewise globally change the effect of >> > all subsequent uses of SPC in the minibuffer. >> > >> > The patch below fixes this. I request approval to push this fix to >> > emacs-25, since without it, todo-mode-specific behavior changes the >> > minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, >> > since it replaces naively implemented functionality by canonical code to >> > temporarily change a minibuffer key binding. >> >> Ping! Any objections to pushing this fix to emacs-25? > > We've lived with this for the last 2 years, how come it's so urgent > now? It's no more urgent now than it was two years ago, it's just that I only discovered it now. And again, the bug not only affects todo-mode but completion throughout Emacs. Admittedly, the intersection of those who regularly use both todo-mode and minibuffer-complete-word is probably very small (possibly empty), but still, why release with a known bug when the fix is obvious and obviously safe? Or do you think it isn't? Steve Berman From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2016 17:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 23695@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.146592390314047 (code B ref 23695); Tue, 14 Jun 2016 17:06:02 +0000 Received: (at 23695) by debbugs.gnu.org; 14 Jun 2016 17:05:03 +0000 Received: from localhost ([127.0.0.1]:40814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCrlv-0003eV-Gx for submit@debbugs.gnu.org; Tue, 14 Jun 2016 13:05:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCrlt-0003dw-9k for 23695@debbugs.gnu.org; Tue, 14 Jun 2016 13:05:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCrlj-0002v2-By for 23695@debbugs.gnu.org; Tue, 14 Jun 2016 13:04:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCrlj-0002ur-8u; Tue, 14 Jun 2016 13:04:51 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4783 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bCrlh-0002VX-DB; Tue, 14 Jun 2016 13:04:49 -0400 Date: Tue, 14 Jun 2016 20:05:43 +0300 Message-Id: <83lh27em54.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87y46dwct7.fsf@gmx.net> (message from Stephen Berman on Fri, 10 Jun 2016 12:36:20 +0200) References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> <83h9d1pcs7.fsf@gnu.org> <87y46dwct7.fsf@gmx.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Stephen Berman > Cc: 23695@debbugs.gnu.org > Date: Fri, 10 Jun 2016 12:36:20 +0200 > > >> Ping! Any objections to pushing this fix to emacs-25? > > > > We've lived with this for the last 2 years, how come it's so urgent > > now? > > It's no more urgent now than it was two years ago, it's just that I only > discovered it now. And again, the bug not only affects todo-mode but > completion throughout Emacs. Admittedly, the intersection of those who > regularly use both todo-mode and minibuffer-complete-word is probably > very small (possibly empty), but still, why release with a known bug > when the fix is obvious and obviously safe? Or do you think it isn't? OK, please go ahead and push to emacs-25. Thanks. From unknown Tue Aug 19 21:04:04 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2016 21:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23695@debbugs.gnu.org Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.146594077625040 (code B ref 23695); Tue, 14 Jun 2016 21:47:02 +0000 Received: (at 23695) by debbugs.gnu.org; 14 Jun 2016 21:46:16 +0000 Received: from localhost ([127.0.0.1]:40911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCwA3-0006Vo-Ss for submit@debbugs.gnu.org; Tue, 14 Jun 2016 17:46:16 -0400 Received: from mout.gmx.net ([212.227.17.22]:49855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bCwA2-0006VY-G6 for 23695@debbugs.gnu.org; Tue, 14 Jun 2016 17:46:15 -0400 Received: from rosalinde ([89.245.124.22]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LrNoG-1bP4EN0jsa-0136uN; Tue, 14 Jun 2016 23:46:07 +0200 From: Stephen Berman References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> <83h9d1pcs7.fsf@gnu.org> <87y46dwct7.fsf@gmx.net> <83lh27em54.fsf@gnu.org> Date: Tue, 14 Jun 2016 23:46:06 +0200 In-Reply-To: <83lh27em54.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Jun 2016 20:05:43 +0300") Message-ID: <87twgve95t.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:WYKT2EyklUAW+ZhC/V45+pwp/Rh/3WYGpQJsxXTMg2l42EhjJQ9 +/77CX8wihKq4TbPWZQ24rghZjAlYRgb6tbpUCgTdINa6bKXKa5v1fLqc6JYH65aKvj2747 WsNQbr48fBTNzjg27W6bGXYCSK2r5Z24+ZPEYEpq6cJYrwQZX4+FmRLrjk9LhA8+sucIdLJ HueMKTyz1N+7IBeZ66cnw== X-UI-Out-Filterresults: notjunk:1;V01:K0:e7UEDFnbiuc=:PJmVv3gyueLr8iyJfRTHc8 3GckUnoyudh8iSp6Ueqx8kEzsm4+mzWLmTiTegkdTqaczJE8ehKYntRnq6adk2DSMdOzf5hxi 9vx6aDGbfCRDE09BBFalBVuW1xYeHKAlsihGx8QWU8WekOouoiF6VxucbOE3zNQxrR7J0Jajv FPMewy76U4kRpFBr8JrmcXc8PyVOBVBBm+DfraTuwA6besVD9BZeLCDfqS/Ga+mjGLrzsYT/6 TXDQbA2k48/o1LBm6oSVd5Ekvtk+vTZvZWjS5fubeUUQRzjuANcNuufjAGufbQyuvRiExpEBB vyhLM52v7CpEqvc12jn5AJiIJsZ3owGtZNJfO/GKgaGONXJ/jbpF7Jap6jPbB6Dz1Zn1PDFDL Beu2r20a0PG14CSUqGz6B+zJ2eAVP0Yf7Tkb6F+5Qed2S9zePzAIfUunPhMvrmgiW6edZB41P DFk5tu6wxR/U0PgPdQBoWxhLXiqif34ts+uXGV3WYjIjNCzTugkT3DD55f4MMeyUrE6c/G051 UCPcYsfbJlMdxZFUeRvx/VEJNVhz9USMcrDBTELxx4Eu/h2MXkaen6g/E0WURQNfGWw0DL976 xz/vG5ewtjtBXimW1Fgdy/Y3ohSybeSTFuQrj+olH1f0KreMNcsWsGd6jgd+LsySPrtb18RaR 7qJIU12KCsUKMT8igFrruyaayOG9X2iW3yMPnQ+LW8Q5e4PZQcX/TzHd3cVwiZNIpFg+96yH7 kH78VRVx6s/tC17Zw+Db4LSCHBByiYPMvq9Ev8WNe/tMGEv7nODOegZQ5ya3ZB71ylNPar9DU NhtlFsJ X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Tue, 14 Jun 2016 20:05:43 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 23695@debbugs.gnu.org >> Date: Fri, 10 Jun 2016 12:36:20 +0200 >> >> >> Ping! Any objections to pushing this fix to emacs-25? >> > >> > We've lived with this for the last 2 years, how come it's so urgent >> > now? >> >> It's no more urgent now than it was two years ago, it's just that I only >> discovered it now. And again, the bug not only affects todo-mode but >> completion throughout Emacs. Admittedly, the intersection of those who >> regularly use both todo-mode and minibuffer-complete-word is probably >> very small (possibly empty), but still, why release with a known bug >> when the fix is obvious and obviously safe? Or do you think it isn't? > > OK, please go ahead and push to emacs-25. Done in commit d7084f2. Steve Berman From unknown Tue Aug 19 21:04:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#23695: closed (Re: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word) Message-ID: References: <87eg7gb9ud.fsf@gmx.net> <87y46km1s9.fsf@gmx.net> X-Gnu-PR-Message: they-closed 23695 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 23695@debbugs.gnu.org Date: Wed, 29 Jun 2016 09:53:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1467193983-18766-1" This is a multi-part message in MIME format... ------------=_1467193983-18766-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23695: 25.0.94; todo-mode breaks minibuffer-complete-word which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23695@debbugs.gnu.org. --=20 23695: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23695 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1467193983-18766-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23695-done) by debbugs.gnu.org; 29 Jun 2016 09:52:52 +0000 Received: from localhost ([127.0.0.1]:59672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bICAu-0004sE-IS for submit@debbugs.gnu.org; Wed, 29 Jun 2016 05:52:52 -0400 Received: from mout.gmx.net ([212.227.15.19]:64287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bICAs-0004ry-IT for 23695-done@debbugs.gnu.org; Wed, 29 Jun 2016 05:52:51 -0400 Received: from rosalinde ([89.245.78.200]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M6RmV-1bWfr63eQ7-00yR1z; Wed, 29 Jun 2016 11:52:43 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> <83h9d1pcs7.fsf@gnu.org> <87y46dwct7.fsf@gmx.net> <83lh27em54.fsf@gnu.org> <87twgve95t.fsf@gmx.net> Date: Wed, 29 Jun 2016 11:52:42 +0200 In-Reply-To: <87twgve95t.fsf@gmx.net> (Stephen Berman's message of "Tue, 14 Jun 2016 23:46:06 +0200") Message-ID: <87eg7gb9ud.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:HhgG3bQnrZI/heRXbRxswOH3dc4k/nnApLqCkUg0cYCQV1R1JmC PIUvVPuKbuxXigWc7KkIcrl6RgJ4Pv8CvaI6oR8Gc8Zn72Pdclh3sKCEvb5qDBH/p5hXH2A 1HDE2Tb0IDSIsL9UjsjPMq3UOuwe76Dy97vF7D57K+8wvMM6p2ztWvKDCfGc+MFOFPNkKXe K5EPOqpkwaezb20TVZWwA== X-UI-Out-Filterresults: notjunk:1;V01:K0:RwY1yUuB3Hk=:VQtq7atYbx8rC/J/lax1IO 2EBtmUjurWichmg0KeEUhl5qtQvzM+YClyY71PCFRl7TyZwsQsuOswWUdxU3IkY+5YOESdGXA GZc0DZOde4eptGg+00+fHOwmUWUK6+fUopP4I45MIF7NtaRn0dIdyQx/bUcbfWKwmwFKDj5lo 2bn4odKCbySzaxVi9sup2HisigLMfv6aOfSkkrH7fPd/OD6J0CaLky1MOx8Nr4siipn4dgRpR 1yKimMUkg+OMFpTJI9nauXF8BlluvWS5mNtbP3XxfkJNs0m60h6azNa07QzZqoV8VolyTGqUu GVaMxVjfn4JUiLcOVId8/r4jI+gweIVQFF42oiImcnVl0Lgb4/pw5/jn0lodpovhl6MOgbXoD Y8xmQx3X93gwhRP0BlTOxPUNuUY4E8S3cLiZg4KauQAss00qGsmyOtNaRttUolXBXbSmXuu9e 2XWd6OUnsKqTUaOt+wuLlKAQvIJ0pTDowLGhXDXajKUJxfZIFAclh6GwGLmFMtB4wuoiJVva2 /HaT5sA1lN1C1O59y8SVRWmSkyQ17pLYxsWJbI+vR5n9BOcSkAtGGnTfdBrU1U+SOh9pw8BOK S3lAAKGbFgmygK/vhZS1R/OWFjOJLRZMp3dEWr9bhyFK3ijjSITlsA1QYsU8OcemfAQXErLOH 9jL5czSHIif8mdYubuZbY0qr5/XSimpqRT3oruO0MmNizcolBjOeRzYIcYv+UKL5MDJm3Dhqb k/AGaDp8bSo6QdoTqzjAS+Ih4xNbnzrzW+e36KPjmEp+nOJjlPhUwU5vfEb065brI5b4QIgsQ kDCG57P X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 23695-done Cc: 23695-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) On Tue, 14 Jun 2016 23:46:06 +0200 Stephen Berman wrote: > On Tue, 14 Jun 2016 20:05:43 +0300 Eli Zaretskii wrote: >> >> OK, please go ahead and push to emacs-25. > > Done in commit d7084f2. Now closing the bug (forgot to when I pushed the fix). Steve Berman ------------=_1467193983-18766-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 5 Jun 2016 09:19:07 +0000 Received: from localhost ([127.0.0.1]:54882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD5-0003p8-E5 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52364) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9UD4-0003oe-2G for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCx-0008NJ-S6 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:19:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCx-0008ND-Ow for submit@debbugs.gnu.org; Sun, 05 Jun 2016 05:18:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCv-0007AK-Dm for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9UCp-0008M1-Dk for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:56 -0400 Received: from mout.gmx.net ([212.227.15.18]:50311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9UCp-0008Lu-2v for bug-gnu-emacs@gnu.org; Sun, 05 Jun 2016 05:18:51 -0400 Received: from rosalinde ([89.245.71.113]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LfkUs-1boZJ73sOg-00pNKV for ; Sun, 05 Jun 2016 11:18:48 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 25.0.94; todo-mode breaks minibuffer-complete-word Date: Sun, 05 Jun 2016 11:18:46 +0200 Message-ID: <87y46km1s9.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:BFqVnjhTvJQ37jz2hsqeWR6XleuLlpmqxRcqm4nUT+W/MlBWxtk M3IaZ9XUEOyTWITGza5hdiUhaHI7MEl8RwOhvL40HGZ0/fpNOwGtKXVFFa1bPibHvfN7CBz ftQVgDHKh+hwN90TnnjjJWLouMvxzYabniW8fA2UrSLnEXhY44Wa87KqbSfJR7UJFUlJlUc OtKoi1jlU9O7ArirHbFvw== X-UI-Out-Filterresults: notjunk:1;V01:K0:2vCupVTzOTQ=:D9Qvs5dEXuCCCbqU+gKQxX V+c42bBCiH/cZ8F1uuUicOTohoRYA1CoyGarI5vhmdMS1w/ZAh0BBeAEh/PKwkTbEmiaVrn+p 6/0TJ/fjfIhgZX/r/zWP5l1Pvm1HjNDnTWWFWU90DtwsZGDNrPdjh97dnRYh84UXWW+sEON7P pLzCh47cfBqj+T9+WBZ4CRUJnAvyHwfcZU6WvfAe2IcrKLPoz4+hGdxacJKDf2WwOTilCwGHf yjRzcox3cIcVcy8lh+IL/De2V4mY4NcXMHsVqh2U+0chZqpfayK2S9kzYj+dd2WZ9Iuq4fyXy QMncQCpw2E2pKdj0ACDBqKqHdXLB3aXTZfBhCwcesNbFGClp+0mRNjPeSi6iYdIPabSXvQxp7 RjmWxgGsgLbrH6sH+J2+EjlZEtHTtqucM+cxiqch5TqgXqHS4rthGZS9SOxZh5pri2Fae/iWL 9RIo1Nax846UapW9CzCUZRqBpyNPYSm6MLLyVK4sLGfXL5fpTRl9gbhfHO2TNs6AAlOGhvAFO NCgtxgvcGbXND/Oe+hiceZe3zgsPTIAND+oSf9idZ8j2nL3zUNhqPLnUg3ruU7wGzli8Qv9pu zGfal/TwcSK42bvj5YGqI7Vd/B4dsBRxmDBB3z3UzS28vKoJZN2h7T9CfDe4lJc72bzl8m4BO I00rW43No51Yc3iq7P2laugZEOqtTnJVaWNFJlB3lw7qhvEKGUHb79qPG903tNhEWW/7Jp1uc Q9ikNmWFfjKNaLip2FgDGzt3kQkVD8QByzP4ocmIK2v7iQjHo7s4MB053e0tKQ84NjJ/oI0VI kOHd0QI X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 0. emacs -Q 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a *Completions* buffer showing functions beginning with "url-", since SPC in the minibuffer is bound to minibuffer-complete-word. 2. C-g to exit the minibuffer, then, if you have no files made by todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show RET RET RET RET RET' (accepting defaults) to create a todo file with a category and an entry. 3. Type `q' to quit todo-mode (optional) and redo step 1. => Upon typing SPC this time, instead of getting the *Completions* buffer, a space is inserted in the minibuffer after "url-". If at step 2 you already have one or more todo-files, then invoking a number of todo-mode commands, e.g. `j' to jump to another category or `C a' to add a new category, will likewise globally change the effect of all subsequent uses of SPC in the minibuffer. The patch below fixes this. I request approval to push this fix to emacs-25, since without it, todo-mode-specific behavior changes the minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, since it replaces naively implemented functionality by canonical code to temporarily change a minibuffer key binding. (Since I normally don't use SPC for minibuffer completion but just TAB, I only discovered this bug yesterday, when I was trying and failed to reproduce bug#23670 in a session in which I had already used the broken todo-mode function.) diff --git a/lisp/calendar/todo-mode.el b/lisp/calendar/todo-mode.el index 8e75258..f0d4bc5 100644 --- a/lisp/calendar/todo-mode.el +++ b/lisp/calendar/todo-mode.el @@ -5750,8 +5750,9 @@ todo-read-category against categories in that file; otherwise complete against all categories from `todo-category-completions-files'." ;; Allow SPC to insert spaces, for adding new category names. - (let ((map minibuffer-local-completion-map)) - (define-key map " " nil) + (let ((minibuffer-local-completion-map + (copy-keymap minibuffer-local-completion-map))) + (define-key minibuffer-local-completion-map " " 'self-insert-command) (let* ((add (eq match-type 'add)) (archive (eq match-type 'archive)) (file0 (when (and file (> (length todo-files) 1)) In GNU Emacs 25.0.94.8 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-06-05 built on rosalinde Repository revision: a5d05f447008c4a99d1b00f0af642b4a5ce4cbce Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix ------------=_1467193983-18766-1--