GNU bug report logs - #23649
24.5; `customize-mode'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23649 in the body.
You can then email your comments to 23649 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.5; `customize-mode'
Date: Sun, 29 May 2016 14:40:58 -0700 (PDT)

The doc string is incorrect:

1. It says, "If a prefix C-u was given..."

   Besides the fact that we write `C-u', not C-u, this is wrong because
   it suggests that the prefix arg must be a plain `C-u', that you
   cannot, for example, use `M-9', `C--', or even `C-u 3'.  It should
   just say "If a prefix arg is given..."

2. It is not true that the options you get are related to the current
   major mode, or even to any major mode.

   It would be OK to say this as a first line, if the rest of the doc
   string made clear that the options can be related to a minor mode,
   that is, MODE can name a minor, not just a major mode.

   What the doc should say is that it customizes options related to
   MODE, which can name a major or a minor mode, and that by default
   MODE is the current major mode.

   (This also takes care of specifying the argument and thus behavior
   when called from Lisp, something missing from the doc string now.)

   Example mode-string, corrected:

   "Customize options related to a major or minor mode.
By default the current major mode is used.
With a prefix argument or if the current major mode has no known group,
you are prompted for the MODE to customize."

3. The prompt is thus incorrect as well: the candidates are not
   necessarily major-mode names.  It should just say "Mode: ".

See also bugs #11299 and #11301, which have not been addressed.


In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'

Message #8 received at 23649 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 23649 <at> debbugs.gnu.org
Cc: Drew Adams <drew.adams <at> oracle.com>
Subject: 24.5; `customize-mode'
Date: Fri, 24 Jun 2016 23:14:08 -0400

[Message part 1 (text/plain, inline)]

tag 23649 + patch
quit

>   Example mode-string, corrected:
>
>    "Customize options related to a major or minor mode.
> By default the current major mode is used.
> With a prefix argument or if the current major mode has no known group,
> you are prompted for the MODE to customize."
> 3. The prompt is thus incorrect as well: the candidates are not
>    necessarily major-mode names.  It should just say "Mode: ".

Looks good to me, so I propose to push the attached patch with this
docstring (and removal of "Major" from the prompts) to emacs-25. Any
objections?

[0001-Fix-docstring-and-prompt-for-customize-mode.patch (text/x-patch, attachment)]

Message #13 received at 23649 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>, 23649 <at> debbugs.gnu.org
Subject: bug#23649: `customize-mode'
Date: Fri, 24 Jun 2016 21:25:35 -0700 (PDT)

> Looks good to me, so I propose to push the attached patch with this
> docstring (and removal of "Major" from the prompts) to emacs-25. Any
> objections?

Thanks for looking at this. However, you (or something?) removed the
bug number from the Subject line, so it took me a while to find
this thread and realize that this reply was for a bug report I filed.

Please leave the Subject lines of bug posts as they are.  Thx.

Message #16 received at 23649 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 23649 <at> debbugs.gnu.org
Subject: Re: bug#23649: 24.5; `customize-mode'
Date: Sat, 25 Jun 2016 11:03:34 +0300

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Fri, 24 Jun 2016 23:14:08 -0400
> 
> >   Example mode-string, corrected:
> >
> >    "Customize options related to a major or minor mode.
> > By default the current major mode is used.
> > With a prefix argument or if the current major mode has no known group,
> > you are prompted for the MODE to customize."
> > 3. The prompt is thus incorrect as well: the candidates are not
> >    necessarily major-mode names.  It should just say "Mode: ".
> 
> Looks good to me, so I propose to push the attached patch with this
> docstring (and removal of "Major" from the prompts) to emacs-25. Any
> objections?

No, please push to master.

Thanks.

Message #19 received at 23649 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23649 <at> debbugs.gnu.org
Subject: Re: bug#23649: 24.5; `customize-mode'
Date: Sat, 25 Jun 2016 09:08:18 -0400

On Sat, Jun 25, 2016 at 4:03 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
>> Date: Fri, 24 Jun 2016 23:14:08 -0400
>>
>> >   Example mode-string, corrected:
>> >
>> >    "Customize options related to a major or minor mode.
>> > By default the current major mode is used.
>> > With a prefix argument or if the current major mode has no known group,
>> > you are prompted for the MODE to customize."
>> > 3. The prompt is thus incorrect as well: the candidates are not
>> >    necessarily major-mode names.  It should just say "Mode: ".
>>
>> Looks good to me, so I propose to push the attached patch with this
>> docstring (and removal of "Major" from the prompts) to emacs-25. Any
>> objections?
>
> No, please push to master.

Since this only touches docstrings and prompt strings, why not push to emacs-25?

Message #22 received at 23649 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: 23649 <at> debbugs.gnu.org
Subject: Re: bug#23649: 24.5; `customize-mode'
Date: Sat, 25 Jun 2016 16:09:43 +0300

> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
> Date: Sat, 25 Jun 2016 09:08:18 -0400
> Cc: 23649 <at> debbugs.gnu.org
> 
> >> Looks good to me, so I propose to push the attached patch with this
> >> docstring (and removal of "Major" from the prompts) to emacs-25. Any
> >> objections?
> >
> > No, please push to master.
> 
> Since this only touches docstrings and prompt strings, why not push to emacs-25?

OK.

Message #27 received at 23649-done <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: 23649-done <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#23649: 24.5; `customize-mode'
Date: Sat, 25 Jun 2016 13:35:23 -0400

Version: 25.1

Pushed to emacs-25 f2536958ec711b50a0cf8714defb921193ea8ae4

Drew Adams wrote:
> Thanks for looking at this. However, you (or something?) removed the
> bug number from the Subject line, so it took me a while to find this
> thread and realize that this reply was for a bug report I filed.

Ah, I manually copied from
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23649#5 which doesn't
have the bug number in subject (because the bug nubmer was allocated
yet). At some point I should setup gnus again so I can have this set
correctly automatically.

Message #30 received at 23649-done <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>, 23649-done <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: RE: bug#23649: 24.5; `customize-mode'
Date: Sat, 25 Jun 2016 13:44:35 -0700 (PDT)

> > Thanks for looking at this. However, you (or something?) removed the
> > bug number from the Subject line, so it took me a while to find this
> > thread and realize that this reply was for a bug report I filed.
> 
> Ah, I manually copied from
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23649#5 which doesn't
> have the bug number in subject (because the bug nubmer was allocated
> yet). At some point I should setup gnus again so I can have this set
> correctly automatically.

OK; sorry if it wasn't due to something on your part.  Not a big
deal, in any case.  Thx.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.