From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 14:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 23648@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14645310753106 (code B ref -1); Sun, 29 May 2016 14:12:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2016 14:11:15 +0000 Received: from localhost ([127.0.0.1]:46529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71Qx-0000o2-33 for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71Qw-0000no-4D for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71Qp-0003zY-Vy for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Qp-0003yR-Sm for submit@debbugs.gnu.org; Sun, 29 May 2016 10:11:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Qn-0004Ke-PP for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71Ql-0003xC-Mn for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:04 -0400 Received: from mail-oi0-x22b.google.com ([2607:f8b0:4003:c06::22b]:36772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71Ql-0003x4-Hz for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 10:11:03 -0400 Received: by mail-oi0-x22b.google.com with SMTP id j1so237430848oih.3 for ; Sun, 29 May 2016 07:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to; bh=hhDwvb6rjqHVIEMUuyE+dfvPNVGh5cE6CdWa7NDkYzg=; b=FsmvDVmR5xrF4jlFtN1TtewxlfW7v9gDbzKaXwhtr0F1hijlArnVWTkOYSbE1Vn5x3 oskZXGD02GZkoPWrXsq9sWK8vqUbo9qlD7q+0WUgpXfSkdn2IciJTw9rVPc9wBkeOVMD On4KAJfKlAVRAFhp/gvsXl3m+K/siQ1J/drQfWTit0Xpp/vKYz0KzHBUsAvDHnMkyAl+ X/tXD4WEuUJdMztWbPMbd9IIIrc4U5ClKLpedbjM22WHpWUTvRARHYEp3T8z7ZmJSodG AHMdJiAAOP/ucBoO1pZn1QBsxwKLzyrvT79v/lEko81NiSOgJd2yF2JC5MIjFdH7dw7w PO+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=hhDwvb6rjqHVIEMUuyE+dfvPNVGh5cE6CdWa7NDkYzg=; b=Wh8zb6a5uIzttIa4FgTRm2nFVANU9V2QPbQike4DlLgrDXpqnmbGhIk0R8N1086/pp YWqelWyBZqiNjZvdfDR/tMgCWeSbLoX+52f0yENQ7knof9bvtRDc2fY1tYGICvOAphOf bOdO1ppPkARbDrwaGV6UZSAp1hXEtUdDc55vEwBZmC346ECJQVVdZS8kEG/E2BKOpMSL Y8pRiIZFpiC7X+oWpK4TjimsgudYc4lbYMA0KqrXqswOLM91Cw2QncF18ITANt+WTD60 XXVlHCooD9PMKQYOJ7+Eg5MpAqYBXcwUeivkfqIIg9ZJr8bhkW5mlPF5fUHeEj5icEgG iyGg== X-Gm-Message-State: ALyK8tLdHj19+sMEj5U+MNe/6XRdhXF1t+yKkbcpUO+FNWIqCj4Up6fMhqEBbdtfOxksg+tnkTTy/swRKTxF3g== MIME-Version: 1.0 X-Received: by 10.202.225.5 with SMTP id y5mr15599479oig.187.1464531062749; Sun, 29 May 2016 07:11:02 -0700 (PDT) Received: by 10.202.71.150 with HTTP; Sun, 29 May 2016 07:11:02 -0700 (PDT) Date: Sun, 29 May 2016 16:11:02 +0200 Message-ID: From: Paul Pogonyshev Content-Type: multipart/mixed; boundary=001a113d469ec22a1a0533fbb507 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a113d469ec22a1a0533fbb507 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I quite often get the following messages: Warning: Unknown defun property =E2=80=98compiler-macro=E2=80=99 in ... As far as I could trace it, the problem is indirectly caused by `define-inline'. While definition of `defun-declarations-alist' does contain `compiler-macro' in its init form, it can be removed later. E.g. when I evaluated the variable, it was not there anymore, only `gv-setter' was there. It seems this is done unintentionally by `elisp-completion-at-point': (`declare (list t (mapcar (lambda (x) (symbol-name (car x))) (delete-dups ;; FIXME: We should include some ;; docstring with each entry. (append macro-declarations-alist defun-declarations-alist))))) Here `delete-dups' destructively modifies a list that includes `defun-declarations-alist' as its tail verbatim, not as a copy. Attached patch should fix that. Paul * elisp-mode.el (elisp-completion-at-point): Fix to not alter `defun-declarations-alist' by side effect. --001a113d469ec22a1a0533fbb507 Content-Type: text/plain; charset=US-ASCII; name="xxx.diff" Content-Disposition: attachment; filename="xxx.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iosnxy600 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2VsaXNwLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rl cy9lbGlzcC1tb2RlLmVsCmluZGV4IDJhZDIyZGQuLmQ4ZjMxNjIgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL2VsaXNwLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvZWxpc3AtbW9kZS5l bApAQCAtNTMzLDkgKzUzMyw5IEBAIEl0IGNhbiBiZSBxdW90ZWQsIG9yIGJlIGluc2lkZSBhIHF1 b3RlZCBmb3JtLiIKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVs ZXRlLWR1cHMKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgOzsgRklY TUU6IFdlIHNob3VsZCBpbmNsdWRlIHNvbWUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgOzsgZG9jc3RyaW5nIHdpdGggZWFjaCBlbnRyeS4KLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGFwcGVuZAotICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbWFjcm8tZGVjbGFyYXRpb25zLWFsaXN0Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZWZ1bi1kZWNsYXJhdGlvbnMtYWxpc3Qp KSkpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXBwZW5kIG1h Y3JvLWRlY2xhcmF0aW9ucy1hbGlzdAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGRlZnVuLWRlY2xhcmF0aW9ucy1hbGlzdAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG5pbCkpKSkpCiAgICAgICAgICAgICAg ICAgICAgICAgICgoYW5kIChvciBgY29uZGl0aW9uLWNhc2UgYGNvbmRpdGlvbi1jYXNlLXVubGVz cy1kZWJ1ZykKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGd1YXJkIChzYXZlLWV4Y3Vy c2lvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaWdub3JlLWVycm9y cwo= --001a113d469ec22a1a0533fbb507-- From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 03:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Paul Pogonyshev Cc: 23648@debbugs.gnu.org Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146881084125247 (code B ref 23648); Mon, 18 Jul 2016 03:01:02 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 03:00:41 +0000 Received: from localhost ([127.0.0.1]:54969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOynQ-0006Z8-U7 for submit@debbugs.gnu.org; Sun, 17 Jul 2016 23:00:41 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:32945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bOynP-0006Yv-Dh for 23648@debbugs.gnu.org; Sun, 17 Jul 2016 23:00:39 -0400 Received: by mail-io0-f180.google.com with SMTP id 38so149014453iol.0 for <23648@debbugs.gnu.org>; Sun, 17 Jul 2016 20:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=L3sP6ZRNl4hNqEBEgbHLYv+uKzNPe6W/xNQa1bdDNGk=; b=fCnW+iUPSRuDZM+vdZC6zHp2tFWuwah9yi5JSXc8Um+84o1jehcJUShgTJQpjZTPHu CKVNdigJRT/EK0tj15rcba1t62+2Dt13jHfjJopeOPnlp/gfUUGCeDGi7kbxQCcoD0fa 9OZf4Ql2AeG3q3So7Au92MAG/ZTm9DdX/fiqxFi+6K3+Qqz2EWRKqKlA4ak7f3TAenEo YLIFfSmwPnkerkfbmhGFLZdsE8c/cOe6QxJQoP3DIjSbwjgc5kVUXdW2Bgy9uCyBqTSt NILvJapo1tCIxAK055T/jsoAd1d7aUZBEDjVv7bIqSqr4D+gWJ0OxLCndaPH7+ZvfHqU 6G5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=L3sP6ZRNl4hNqEBEgbHLYv+uKzNPe6W/xNQa1bdDNGk=; b=eVjtbkno29cMzn8b1HAv0rU8185ZF5jz5sldgt43zMlECj/YIC5UWZ0S2EDltCoXZl 4HbSoqn95h/+GTrg2TocHB4KQz1di1o+w/Kainkl42GnArfLhsEvZ02LcHXLpZ3H/Anq R++kmr85gh6lskQudoOp0IhdZlQdXlPeEa5NRDmKtYCtdTLx/zuEyGgfdnNvcPQCl4zo iILo9LgWOA9qW+cg3QiffeXSqA996ngJSskZykekUtEaRtPZDuKa1p2BZYnq1aeYKd7c rf6AFatOM/rhwoG1OeAZQ7DVNuGa+Ofl+C/U6RJfThz3SKl0AgRxQXvxKZ4vjWuC9DhO N+sg== X-Gm-Message-State: ALyK8tIk43N5nCsdtxcEbz84HQ8nHtOQWpx84MuUcyRkowJYa2y9jbcA2+ntyWtKhaL9+g== X-Received: by 10.107.197.134 with SMTP id v128mr30125397iof.178.1468810833709; Sun, 17 Jul 2016 20:00:33 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id w192sm8074162iof.24.2016.07.17.20.00.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 Jul 2016 20:00:33 -0700 (PDT) From: npostavs@users.sourceforge.net References: Date: Sun, 17 Jul 2016 23:00:33 -0400 In-Reply-To: (Paul Pogonyshev's message of "Sun, 29 May 2016 16:11:02 +0200") Message-ID: <87twfnd50u.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Paul Pogonyshev writes: > I quite often get the following messages: > > Warning: Unknown defun property =E2=80=98compiler-macro=E2=80=99 in ... > > As far as I could trace it, the problem is indirectly caused by > `define-inline'. While definition of `defun-declarations-alist' does > contain `compiler-macro' in its init form, it can be removed later. > E.g. when I evaluated the variable, it was not there anymore, only > `gv-setter' was there. > > It seems this is done unintentionally by `elisp-completion-at-point': > > (`declare > (list t (mapcar (lambda (x) (symbol-name (car x))) > (delete-dups > ;; FIXME: We should include some > ;; docstring with each entry. > (append > macro-declarations-alist > defun-declarations-alist))))) > > Here `delete-dups' destructively modifies a list that includes > `defun-declarations-alist' as its tail verbatim, not as a copy. > Attached patch should fix that. I agree with analysis and patch here. Since this just appends another nil, it should be safe for emacs-25, right? > > Paul > > * elisp-mode.el (elisp-completion-at-point): Fix to not alter > `defun-declarations-alist' by side effect. > - (append > - macro-declarations-alist > - defun-declarations-alist))))) > + (append macro-declarations-alist > + defun-declarations-alist > + nil))))) From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 14:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: 23648@debbugs.gnu.org, pogonyshev@gmail.com Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146885242330943 (code B ref 23648); Mon, 18 Jul 2016 14:34:01 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 14:33:43 +0000 Received: from localhost ([127.0.0.1]:55871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9c7-000831-0v for submit@debbugs.gnu.org; Mon, 18 Jul 2016 10:33:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bP9c3-00082g-43 for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 10:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP9bu-0006og-4U for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 10:33:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP9bu-0006oW-1K; Mon, 18 Jul 2016 10:33:30 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2667 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bP9bs-0006jB-4D; Mon, 18 Jul 2016 10:33:28 -0400 Date: Mon, 18 Jul 2016 17:33:27 +0300 Message-Id: <83wpkj10eg.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87twfnd50u.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) References: <87twfnd50u.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: npostavs@users.sourceforge.net > Date: Sun, 17 Jul 2016 23:00:33 -0400 > Cc: 23648@debbugs.gnu.org > > I agree with analysis and patch here. Since this just appends another > nil, it should be safe for emacs-25, right? I'm not sure, actually. How probable is the situation where this problem pops up? And when was the bug introduced? From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 15:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23648@debbugs.gnu.org, Paul Pogonyshev Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14688572315793 (code B ref 23648); Mon, 18 Jul 2016 15:54:01 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 15:53:51 +0000 Received: from localhost ([127.0.0.1]:55898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPArf-0001VN-1L for submit@debbugs.gnu.org; Mon, 18 Jul 2016 11:53:51 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:35221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPArc-0001V9-M0 for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 11:53:50 -0400 Received: by mail-oi0-f45.google.com with SMTP id l72so112138786oig.2 for <23648@debbugs.gnu.org>; Mon, 18 Jul 2016 08:53:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=U7a2eOHVwhfTYLXCcFdmc7FzxwCVizxIKheaoc6upM0=; b=kjH9BKL81ipPd3w/VxllTaxRLr1ZVa2hsAXld9Q69risLsUln4TTuJXQxHnpw6zCaB NFAVbmKIwf1bXoW8Q5UYb0nvjlM8AtGerVrGGuzn8RCDXndm1NhTxDkAb6F1pt3Ywl/8 TSsaI94ssbUjTDVzeTaNqLPgghGEHQqeIGExe1flD22XO39TfMdzt6yxL6VDCTxpPoqz qKXn5sl5bMajTzKCbt8XrBohentDD9oNi6O/UFpV6nuVbwEDaOYDHbDqKFlLd9R2Tx77 WDQGDMF+bYxia7VyV6+8oM3P8PIxAHYn4fVCcnIj3YbmD+EtH20XORe8fq3OpiJ7puhN NN9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=U7a2eOHVwhfTYLXCcFdmc7FzxwCVizxIKheaoc6upM0=; b=JHtt6w7wPHZ+bK2JsvHNR2Nf1WnI2e2WxtVd8p8Gs9pDaFuhDe69EbKSLSIX0J6yKS 8yksdYRDxz2pZloa9mygupmtqCGoxoW7IWV0VSG/ew5+Clbko8WknsRrLFFZBmIEW1YZ Lx6I35vp7lpk4ccYqq2+ZQ57+TtsbZLngT4yQR5OPpnqiTB2GX80l9hlriWvqLC1uoYu gm51BMA+CrWzqzAoWfqL4vD0Uwe/UN0qvbm1q0thC3Fjg/SXjZc/Iseah8NEQSMYGFT9 Z1KFC/9dNyN8bQDfp61fHtApspQW3FoxQHmIPZ+O/4huQZ1qIpe0e4lSt8oK/gf2QyYX PWiQ== X-Gm-Message-State: ALyK8tKfYqIVtmeibH4V4p4K5D5+ibmW3b99dZ4mXZLn8XNCm/uqh+a+t1fdVJls/fT1sOeWPhP2oX/+IckmcQ== X-Received: by 10.157.9.248 with SMTP id 53mr21276233otz.35.1468857223017; Mon, 18 Jul 2016 08:53:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.7.161 with HTTP; Mon, 18 Jul 2016 08:53:42 -0700 (PDT) In-Reply-To: <83wpkj10eg.fsf@gnu.org> References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> From: Noam Postavsky Date: Mon, 18 Jul 2016 11:53:42 -0400 X-Google-Sender-Auth: fLLtdIKP5pb8yGJTwTaoqmsS6NM Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jul 18, 2016 at 10:33 AM, Eli Zaretskii wrote: >> From: npostavs@users.sourceforge.net >> Date: Sun, 17 Jul 2016 23:00:33 -0400 >> Cc: 23648@debbugs.gnu.org >> >> I agree with analysis and patch here. Since this just appends another >> nil, it should be safe for emacs-25, right? > > I'm not sure, actually. How probable is the situation where this > problem pops up? It happens with 100% probability when performing completion inside a (declare ...) form. Starting from emacs -Q, put into *scratch* (defun foo () (declare (indent 1)) nil) Macroexpanding this gives: (prog1 (defalias 'foo #'(lambda nil nil)) (put 'foo 'lisp-indent-function '1)) Now move point to just after "indent" and type C-M-i (this gives message "Sole completion"), macroexpanding now gives (prog1 (defalias 'foo #'(lambda nil nil)) "Warning: Unknown defun property `indent' in foo") > And when was the bug introduced? Code seems to have been that way since it was introduced in 24.4: dd8791e9 "* lisp/emacs-lisp/lisp.el (lisp-completion-at-point): Provide specialized completion tables when completing error conditions and `declare' arguments...." From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 23648@debbugs.gnu.org, pogonyshev@gmail.com Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146886578519197 (code B ref 23648); Mon, 18 Jul 2016 18:17:02 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 18:16:25 +0000 Received: from localhost ([127.0.0.1]:55979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPD5d-0004zZ-3Q for submit@debbugs.gnu.org; Mon, 18 Jul 2016 14:16:25 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPD5b-0004zK-NA for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 14:16:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPD5T-0000OD-3N for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 14:16:18 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPD5S-0000O3-SR; Mon, 18 Jul 2016 14:16:14 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2922 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPD5P-0002hK-LA; Mon, 18 Jul 2016 14:16:14 -0400 Date: Mon, 18 Jul 2016 21:16:00 +0300 Message-Id: <83k2gi24nz.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Noam Postavsky on Mon, 18 Jul 2016 11:53:42 -0400) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Noam Postavsky > Date: Mon, 18 Jul 2016 11:53:42 -0400 > Cc: Paul Pogonyshev , 23648@debbugs.gnu.org > > > I'm not sure, actually. How probable is the situation where this > > problem pops up? > > It happens with 100% probability when performing completion inside a > (declare ...) form. Starting from emacs -Q, put into *scratch* > > (defun foo () > (declare (indent 1)) > nil) > > Macroexpanding this gives: > > (prog1 > (defalias 'foo > #'(lambda nil nil)) > (put 'foo 'lisp-indent-function '1)) > > Now move point to just after "indent" and type C-M-i (this gives > message "Sole completion"), macroexpanding now gives > > (prog1 > (defalias 'foo > #'(lambda nil nil)) > "Warning: Unknown defun property `indent' in foo") Sorry, I'm not following: what do you mean by "macroexpanding" in this context? When you wrote "when performing completion", I expected to see some simple completion gesture that leads to an error, but it sounds like I'm missing something. > > And when was the bug introduced? > > Code seems to have been that way since it was introduced in 24.4: > dd8791e9 "* lisp/emacs-lisp/lisp.el (lisp-completion-at-point): > Provide specialized > completion tables when completing error conditions and > `declare' arguments...." Thanks. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23648@debbugs.gnu.org, Paul Pogonyshev Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146886830822981 (code B ref 23648); Mon, 18 Jul 2016 18:59:01 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 18:58:28 +0000 Received: from localhost ([127.0.0.1]:56000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPDkK-0005yb-3S for submit@debbugs.gnu.org; Mon, 18 Jul 2016 14:58:28 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPDkI-0005yO-KH for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 14:58:26 -0400 Received: by mail-oi0-f45.google.com with SMTP id l65so179733124oib.1 for <23648@debbugs.gnu.org>; Mon, 18 Jul 2016 11:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=PQEydhLgQcAS0NLl0KAk2zzVbW+TB4lMd2aR4BNg3ws=; b=WAWjLyp52EDKt3s/FKz65XNELP/O2Jky6yHxPoM8lZB75c9FVFe/dqWWrmJ9SLqTfN H80HNO9nRaVMT9zcz9mxWdfEij01Vpj+ABp1Th3/6aoB2XryjTn/csd4QWc19r/QYVnh bzCYTNnAqw6p+O881mM+c4RP/RBTR226mB6y3H8LAZE7UO0AUHJymHw7X6HtbZcTvuWF qB0e6KjIBRiXnLizm75jKVS5nLvn19FZ52TRYbo+Gn6agClDD7PDgg6NbzO+OQS0OeLR PaXEWWkhLGzfTbqxe8KGI3XYLonGJW3ln8IQR6Q1MPhgYfitKSlZWLPNTd05kutyLcZ4 jq5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=PQEydhLgQcAS0NLl0KAk2zzVbW+TB4lMd2aR4BNg3ws=; b=esVvummmtu2FBC2K9dugtiF1Lqwm1ph5KlfZgBec0URxBNbQ5oq/crIOeC0YXnuSur Zh08DRuyLGrxwQivtlljMHbi1yvd+Tt5XwIG83zCSQhfxNt/48CU0RW8fESf2k+mrT/D m8UOAxnD8j2cGGWOL5xH3EPHn6fEqVBVordOx4AitzZL5XtDAWaU9i0x8DaQVfcVJl2R R6o+qu60xEdz5mCg2QRH23m39m3mIPBZ+5JByCm0jIBGODzgFZD+HK0BiYTqQ03yTo4Q 4AsPJff/j2Gt0oTvjxFMnlSNkckobi+vNtKo0GNP+4Z3yceq1DIqs0DqUMSja9AVU8Vh Bz7A== X-Gm-Message-State: ALyK8tLJu0cV5wCbakYxey/VatR91FZf3P04EPdrWUOiSh6GfCe157gLlUK3MRjcMojaU2keV9blrwnhEBLJ5A== X-Received: by 10.202.92.194 with SMTP id q185mr16102917oib.88.1468868300952; Mon, 18 Jul 2016 11:58:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.7.161 with HTTP; Mon, 18 Jul 2016 11:58:20 -0700 (PDT) In-Reply-To: <83k2gi24nz.fsf@gnu.org> References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> From: Noam Postavsky Date: Mon, 18 Jul 2016 14:58:20 -0400 X-Google-Sender-Auth: qXeDZlkfxwp-OnMcu37VdQ4nrjU Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Jul 18, 2016 at 2:16 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Mon, 18 Jul 2016 11:53:42 -0400 >> Cc: Paul Pogonyshev , 23648@debbugs.gnu.org >> >> > I'm not sure, actually. How probable is the situation where this >> > problem pops up? >> >> It happens with 100% probability when performing completion inside a >> (declare ...) form. Starting from emacs -Q, put into *scratch* >> >> (defun foo () >> (declare (indent 1)) >> nil) >> >> Macroexpanding this gives: >> >> (prog1 >> (defalias 'foo >> #'(lambda nil nil)) >> (put 'foo 'lisp-indent-function '1)) >> >> Now move point to just after "indent" and type C-M-i (this gives >> message "Sole completion"), macroexpanding now gives >> >> (prog1 >> (defalias 'foo >> #'(lambda nil nil)) >> "Warning: Unknown defun property `indent' in foo") > > Sorry, I'm not following: what do you mean by "macroexpanding" in this > context? Calling macroexpand on the defun form. The most convenient method for testing is to put point at the closing bracket of the defun, and then `M-x pp-macroexpand-last-sexp'. > When you wrote "when performing completion", I expected to > see some simple completion gesture that leads to an error, but it > sounds like I'm missing something. The simple completion gesture would be the C-M-i I mentioned, which (silently) destroys the value of defun-declarations-alist. The symptoms of the wrong value can be seen when defun is macroexpanded. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 19:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: 23648@debbugs.gnu.org, pogonyshev@gmail.com Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146886896024074 (code B ref 23648); Mon, 18 Jul 2016 19:10:01 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 19:09:20 +0000 Received: from localhost ([127.0.0.1]:56015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPDuq-0006GE-Ld for submit@debbugs.gnu.org; Mon, 18 Jul 2016 15:09:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPDup-0006G1-4q for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 15:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPDue-0004kV-Th for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 15:09:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPDue-0004kN-QQ; Mon, 18 Jul 2016 15:09:08 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2946 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPDua-0005SV-Tk; Mon, 18 Jul 2016 15:09:07 -0400 Date: Mon, 18 Jul 2016 22:08:49 +0300 Message-Id: <83inw2227y.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Noam Postavsky on Mon, 18 Jul 2016 14:58:20 -0400) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Noam Postavsky > Date: Mon, 18 Jul 2016 14:58:20 -0400 > Cc: Paul Pogonyshev , 23648@debbugs.gnu.org > > >> Now move point to just after "indent" and type C-M-i (this gives > >> message "Sole completion"), macroexpanding now gives > >> > >> (prog1 > >> (defalias 'foo > >> #'(lambda nil nil)) > >> "Warning: Unknown defun property `indent' in foo") > > > > Sorry, I'm not following: what do you mean by "macroexpanding" in this > > context? > > Calling macroexpand on the defun form. The most convenient method for > testing is to put point at the closing bracket of the defun, and then > `M-x pp-macroexpand-last-sexp'. > > > When you wrote "when performing completion", I expected to > > see some simple completion gesture that leads to an error, but it > > sounds like I'm missing something. > > The simple completion gesture would be the C-M-i I mentioned, which > (silently) destroys the value of defun-declarations-alist. The > symptoms of the wrong value can be seen when defun is macroexpanded. Sorry, I guess I'm too stupid to understand this advanced stuff. Or maybe it's too late. Thanks. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net, Paul Pogonyshev Cc: 23648@debbugs.gnu.org Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146886948724913 (code B ref 23648); Mon, 18 Jul 2016 19:19:01 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 19:18:07 +0000 Received: from localhost ([127.0.0.1]:56023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPE3K-0006Tl-Tm for submit@debbugs.gnu.org; Mon, 18 Jul 2016 15:18:07 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPE3J-0006TG-Sa for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 15:18:06 -0400 Received: by mail-wm0-f52.google.com with SMTP id o80so130712701wme.1 for <23648@debbugs.gnu.org>; Mon, 18 Jul 2016 12:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=hp58j7gXQyde/xoyWytqWXl24YKkVMCpkqqUOAbCfsY=; b=hz4ZQArz7kIsC/N/GbqPxVM47396vJkhq9pbvdIVO91PwFcwpQHrGzGWoMq5K/jmLa /zvtCm2OK0PyRj3TL3sO9K42P7ZA1dZ7BAL0jUfD9Dfv4970vSc9g4waeMisntwB50cn pdXXUby+t7DQKv3VMl6gtZdCrKwtyr2iXmiie6+2QYqIQF0B63h/K3wKv1vnqL1xk6RV +jhxwdpQTsjbseMf/0SsxundnvEe+dijj0gBP1wJOAgV4lgC/fCMFrnqVlFMEOf039KO sl1PavRM8LILD5c9z7tE1/bKUuRw21RplGdNVxnVnRsdSiY6cJyJhh9HDI/ZTc9IWYoX ErWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=hp58j7gXQyde/xoyWytqWXl24YKkVMCpkqqUOAbCfsY=; b=U8OF0FnmKsH0OWHrQsjfU49ohPXwpzbrFdgoWGh/PB4VpJNyyyviSILFuMZ3KQl7Im OsDXiMyEbsXPdTCuBpMPozEnfRwVALE1I1k/cg1IZNtYCoJ8ET6yLWpHPlvh32LGHlaJ B9HlAZavF8FEejpIzDk/OuB94Hm12RpjBsOWgXu/81+ppng/g1vbBZ7z50fLRFJHGmHF Wr+XJylTMtgOoey/qY702wtOqnv+JwbK6NutW0ClSMVwttj8MUrQf5L2/jjm5WMcJ8z8 jRiGdRT6df37S6/z9dTCbPI8q5OLCaCizAkZC8Q8YZG5JqIh6hZIPvDIRUBgShEjPNMC +fiA== X-Gm-Message-State: ALyK8tLJJSJzpZQ0CRN7S4rXiZFhftVBIxffzhShu/vp9eZOOvre9fldZi6oD6QmLUwddg== X-Received: by 10.194.229.70 with SMTP id so6mr2967879wjc.178.1468869480039; Mon, 18 Jul 2016 12:18:00 -0700 (PDT) Received: from [192.168.1.2] ([185.105.173.135]) by smtp.googlemail.com with ESMTPSA id 12sm18080789wmj.19.2016.07.18.12.17.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 12:17:59 -0700 (PDT) References: <87twfnd50u.fsf@users.sourceforge.net> From: Dmitry Gutov Message-ID: <995c1f7f-a0fa-a0bf-60f5-41a0a201fe75@yandex.ru> Date: Mon, 18 Jul 2016 22:17:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:47.0) Gecko/20100101 Thunderbird/47.0 MIME-Version: 1.0 In-Reply-To: <87twfnd50u.fsf@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 07/18/2016 06:00 AM, npostavs@users.sourceforge.net wrote: >> Here `delete-dups' destructively modifies a list that includes >> `defun-declarations-alist' as its tail verbatim, not as a copy. >> Attached patch should fix that. > > I agree with analysis and patch here. I like the patch as well. Maybe it would be better to use cl-remove-duplicates with nconc instead (the use of nil is a little non-obvious), but that would require having cl-lib loaded at runtime, and elisp-mode depending on it. In any case, the proposed patch looks safe. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jul 2016 21:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 23648@debbugs.gnu.org, pogonyshev@gmail.com, Noam Postavsky Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14688773614678 (code B ref 23648); Mon, 18 Jul 2016 21:30:02 +0000 Received: (at 23648) by debbugs.gnu.org; 18 Jul 2016 21:29:21 +0000 Received: from localhost ([127.0.0.1]:56064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPG6L-0001DN-KE for submit@debbugs.gnu.org; Mon, 18 Jul 2016 17:29:21 -0400 Received: from mout.web.de ([212.227.17.12]:61763) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPG6J-0001DA-Sc for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 17:29:20 -0400 Received: from drachen.dragon ([88.67.73.210]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0MWSBi-1bsNZA1vq6-00Xe32; Mon, 18 Jul 2016 23:28:58 +0200 From: Michael Heerdegen References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> Date: Mon, 18 Jul 2016 23:28:55 +0200 In-Reply-To: <83inw2227y.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Jul 2016 22:08:49 +0300") Message-ID: <87r3aqbppk.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.95 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:zIbWWIjyxtGpBuM7OJJdx2866WVHEIzpI9xYTzNjEOtnis0OyQj nQzbot9QeOZpKHOkAu06vaUH69PfZUkJJ3i+plbQTMTQtkC/8xERqCS68elZRaAeEbTBulm de80uQi6t1iBbMnLHwEG1Lyn4eiKO5mq8n/10QMHcAtaTADbWQROxEPur6FiD7rZEn9I7yr 6EbiVZJp4vmPuhVr1QB/Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:39lj4/FIVhM=:vvrROCU/91/9f++JIkpY7/ jZ0CXTzfApg65lehvTqCoRwF+ECSG98l+ZmANYhi3cI0qgzwDqXRfoUk1NQkdTbi4UnWazM12 lhPE8LkmTwTqFRD2g0jXfuRrwUBq5lvrDv96JjrW2sH5as8nL0hEgJr+fatVMv2SUPAfwAnfC 2VUD+FwL0rGs7Uxo47UgblSl/M9unaLTornKXnM9CcWcy33INj1P032tLsWuyNhSjBFMUlgPE G7ThmpoY8FYjAq07tb0AMt7+RxFkNQG8/NUaqtdM1UsRFOybLV2bBFm6NMuNwjeHjiECl4GaB k4yYvU1rPYMl4ElY5/Q9KLvaXoX3X2ftdvVzpGtIOIumEf2SoWhUB1DaqohmXSVYZ4wJkZPOR /IFz1XVy6B3pSXR4oGyL99wFvhHDBU+UGEW5uWiTfNpUSwHnPFuBHnAQKdzgrlJlVwn+T4wJW DNxOt4w3BXExeYgTKeQnJ0872q9JHCqFwYh8IAJuZ/RwuK93mX0245OtTXT3lk8HAzGcQnt87 PkGEnEsjbQ08K3Gloao+qXeltegtEPE7XY4fXaJSu6hzEnWLO2aSlX36rH2tC9sN4eeZOKAJh 8+VDljh/f80k/zhwrmPcchtwU4C4+Cs9Rk1wdksoi6mZql9OoXyp6m45P8WjxUG4uvdiR3Wx0 PO+z4/VetNAK9Td/stYlD1u060737ZaExoGqrL6bGUnPxKhx93fIcVF3MwqxA3q+ooUYqgLIq BmO37YlzStsCTMnixxUW/KZ6c1knuqffvwVkKU42Ii5co3FRFdYK7wfLpVi5vCPDu6FH+WDRI ftCg+L3 X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) Eli Zaretskii writes: > Sorry, I guess I'm too stupid to understand this advanced stuff. Or > maybe it's too late. I think the example uses macroexpand only to demonstrate what (obviously ill) code you will get when you compile the mentioned form after performing the completion as mentioned. Michael. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Jul 2016 02:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Michael Heerdegen Cc: 23648@debbugs.gnu.org, pogonyshev@gmail.com, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146889606614071 (code B ref 23648); Tue, 19 Jul 2016 02:42:01 +0000 Received: (at 23648) by debbugs.gnu.org; 19 Jul 2016 02:41:06 +0000 Received: from localhost ([127.0.0.1]:56147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPKy2-0003et-2n for submit@debbugs.gnu.org; Mon, 18 Jul 2016 22:41:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPKy1-0003eC-1l for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 22:41:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPKxv-00081S-6t for 23648@debbugs.gnu.org; Mon, 18 Jul 2016 22:41:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35925) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPKxr-00080k-FQ; Mon, 18 Jul 2016 22:40:55 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3161 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPKxp-0004Ec-Au; Mon, 18 Jul 2016 22:40:53 -0400 Date: Tue, 19 Jul 2016 05:40:53 +0300 Message-Id: <83d1ma1hai.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87r3aqbppk.fsf@web.de> (message from Michael Heerdegen on Mon, 18 Jul 2016 23:28:55 +0200) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Michael Heerdegen > Cc: Noam Postavsky , 23648@debbugs.gnu.org, pogonyshev@gmail.com > Date: Mon, 18 Jul 2016 23:28:55 +0200 > > Eli Zaretskii writes: > > > Sorry, I guess I'm too stupid to understand this advanced stuff. Or > > maybe it's too late. > > I think the example uses macroexpand only to demonstrate what (obviously > ill) code you will get when you compile the mentioned form after > performing the completion as mentioned. Thanks, but I'm still none the wiser about the questions I asked. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 01:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Michael Heerdegen , 23648@debbugs.gnu.org, pogonyshev@gmail.com Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146906338717777 (code B ref 23648); Thu, 21 Jul 2016 01:10:01 +0000 Received: (at 23648) by debbugs.gnu.org; 21 Jul 2016 01:09:47 +0000 Received: from localhost ([127.0.0.1]:59104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ2Uk-0004cf-Mm for submit@debbugs.gnu.org; Wed, 20 Jul 2016 21:09:46 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:33280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ2Uj-0004cT-VP for 23648@debbugs.gnu.org; Wed, 20 Jul 2016 21:09:46 -0400 Received: by mail-io0-f179.google.com with SMTP id 38so63117727iol.0 for <23648@debbugs.gnu.org>; Wed, 20 Jul 2016 18:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=zGSwl2YhMKTPiN7L9qyEmQWXALDPM/LpA6xcy0V9WGs=; b=Fl1XEZ84id25kdVrSRTNKAe1hFQ4MRscTEgzpgQJxY0w9kzXvyiNcxCqaaY4Lpsk6P U7Wx4m4buKCWB/rsSw7eGrCvopHN2qq83yRwiF3k6imOk0HhGgeDin1Q2bOqip9Kxgx1 7yDvDtNPR6/xPeht7zj2RU2aZKqheTTJAusekIxAUPIGioly1TBpM6zRXBcPRdWZUQGf 4QJgZst6zayLnnUvNsIsR/hcmY4nAb3Uy7lmdUJI0PgcLT7RSJyEWeU6ygPS2bIrS1fl JQRETWZ2ewIn6SLJV3Kv+ASayyGFhoGr+xjVV5/LMjtu5N0VvH92v0XRiEK/hL8y4dHQ +1kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version :content-transfer-encoding; bh=zGSwl2YhMKTPiN7L9qyEmQWXALDPM/LpA6xcy0V9WGs=; b=Q+iYtoq4SnH+TQVhWzZAI0c7Lew++5//aDPjCnQ9UzfDf5++MJoa82sAL38eQ6gSJi Ig1WzjGiwnMb470xPe3irlfN3THM8O7f6cn98cPBRRiemKPxOwr7zh/PIfDZy3UtxS4j X5+xsmUUIcc58GHtKkbuFJlmFomyekPIvgylI3Ihh5TJ57fa2aC6WxFaA66FW/CKlGcj 7n0pTXKoJ3vrOWvFvn2GtRNHBz8C7z+aD8dxQ9y/RTSWPw+61q/dJXknPdlUeRk//VOu lfIUIKyHQshFD2INqN3sovQI+UOFJt3jVijfDXRsriqcaevg7uI2SMlDTP237tKLVvhN 9aTw== X-Gm-Message-State: ALyK8tJdEikAN2LWS5SH2TYB4/dnDtofEN2k/l/HleVsBC4hPYnOq8RMuk6Kz5CALNh/MA== X-Received: by 10.107.163.129 with SMTP id m123mr52443221ioe.48.1469063380473; Wed, 20 Jul 2016 18:09:40 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id j12sm2590063ioi.36.2016.07.20.18.09.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 18:09:39 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> Date: Wed, 20 Jul 2016 21:09:42 -0400 In-Reply-To: <83d1ma1hai.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Jul 2016 05:40:53 +0300") Message-ID: <87a8hbdcfd.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: Michael Heerdegen >> Cc: Noam Postavsky , 23648@debbugs.gnu.= org, pogonyshev@gmail.com >> Date: Mon, 18 Jul 2016 23:28:55 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> > Sorry, I guess I'm too stupid to understand this advanced stuff. Or >> > maybe it's too late. >>=20 >> I think the example uses macroexpand only to demonstrate what (obviously >> ill) code you will get when you compile the mentioned form after >> performing the completion as mentioned. > > Thanks, but I'm still none the wiser about the questions I asked. Hmm, maybe it will be clearer like this: Evaluate: (macroexpand '(defun foo () (declare (indent 1)) nil)) ;=3D> (prog1 (defalias (quote foo) (function (lambda = nil nil))) (function-put (quote foo) (quote lisp-indent-function) (quote 1)= )) This gives the correct result (the (function-put...) part comes from the (declare (indent 1))). Now perform a completion on a declare clause, e.g., put cursor after "ind" and hit C-M-i: (declare (ind)) completes to (declare (indent)). Now evaluate the same expression as before: (macroexpand '(defun foo () (declare (indent 1)) nil)) ;=3D> (prog1 (defalias (quote foo) (function (lambda = nil nil))) "Warning: Unknown defun property =E2=80=98indent=E2=80=99 in foo= ") This give the wrong result, the (declare (indent 1)) is giving the "Warning:...". Emacs has unlearned the indent declaration. In fact it unlearned all the declarations for defun except for gv-setter, you can see this by looking at defun-declarations-alist's value. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 14:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: npostavs@users.sourceforge.net Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, pogonyshev@gmail.com Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.1469110997852 (code B ref 23648); Thu, 21 Jul 2016 14:24:02 +0000 Received: (at 23648) by debbugs.gnu.org; 21 Jul 2016 14:23:17 +0000 Received: from localhost ([127.0.0.1]:60541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQEsb-0000Dc-EA for submit@debbugs.gnu.org; Thu, 21 Jul 2016 10:23:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQEsV-0000DJ-G2 for 23648@debbugs.gnu.org; Thu, 21 Jul 2016 10:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQEsM-0001Rs-Cu for 23648@debbugs.gnu.org; Thu, 21 Jul 2016 10:23:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49293) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQEsI-0001Q7-IB; Thu, 21 Jul 2016 10:22:54 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4913 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQEsG-0006ZG-Hn; Thu, 21 Jul 2016 10:22:52 -0400 Date: Thu, 21 Jul 2016 17:22:59 +0300 Message-Id: <83d1m7yssc.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87a8hbdcfd.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: npostavs@users.sourceforge.net > Cc: Michael Heerdegen , 23648@debbugs.gnu.org, pogonyshev@gmail.com > Date: Wed, 20 Jul 2016 21:09:42 -0400 > > > Thanks, but I'm still none the wiser about the questions I asked. > > Hmm, maybe it will be clearer like this: > > Evaluate: > > (macroexpand '(defun foo () > (declare (indent 1)) > nil)) ;=> (prog1 (defalias (quote foo) (function (lambda nil > nil))) (function-put (quote foo) (quote lisp-indent-function) (quote 1))) > > This gives the correct result (the (function-put...) part comes from the > (declare (indent 1))). > > Now perform a completion on a declare clause, e.g., put cursor after > "ind" and hit C-M-i: (declare (ind)) completes to (declare (indent)). > > Now evaluate the same expression as before: > > (macroexpand '(defun foo () > (declare (indent 1)) > nil)) ;=> (prog1 (defalias (quote foo) (function (lambda nil > nil))) "Warning: Unknown defun property ‘indent’ in foo") > > This give the wrong result, the (declare (indent 1)) is giving the > "Warning:...". Emacs has unlearned the indent declaration. In fact it > unlearned all the declarations for defun except for gv-setter, you can > see this by looking at defun-declarations-alist's value. Thanks, but I think we are mis-communicating. What I need is not a demonstration of the bug in action; I already got that. What I asked for is different: > How probable is the situation where this problem pops up? And when > was the bug introduced? You already answered the second question. For the first, I expected to see something done frequently by either users or Lisp programs, which bumps into this bug. Evaluating macroexpand, twice, with completion in-between, doesn't qualify in my book as a frequent user action, I hope you will agree (even if you personally happen to use it quite a lot). So I'm still looking for the answer to the "how probable" question. I need that to make up my mind about the urgency of the fix. Thanks. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Jul 2016 21:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Michael Heerdegen , 23648@debbugs.gnu.org, Paul Pogonyshev Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14691364776333 (code B ref 23648); Thu, 21 Jul 2016 21:28:01 +0000 Received: (at 23648) by debbugs.gnu.org; 21 Jul 2016 21:27:57 +0000 Received: from localhost ([127.0.0.1]:60652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQLVd-0001e4-8K for submit@debbugs.gnu.org; Thu, 21 Jul 2016 17:27:57 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQLVb-0001dr-Dx for 23648@debbugs.gnu.org; Thu, 21 Jul 2016 17:27:55 -0400 Received: by mail-oi0-f52.google.com with SMTP id l72so136881781oig.2 for <23648@debbugs.gnu.org>; Thu, 21 Jul 2016 14:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=UMIyvJSfdyrJvdn/Q98hoSQo0piEZReNNjk/7CPFZQE=; b=wJX0n5sskFdZuToSD3x/7qtWSOGOaxP3zgYPWYCcG7Va+Udb0OLMrxvm18h3zWuUmZ CbDZ6jY1VnNIm+XgKAMXk1Kfi+MLAL/8lw10da2JtV4+vFXztKWz8RbNNF+Rf9I+O5bl vscybbNItJIMfWy6dmKB0g1kMHUFZXedt5vm3Ozm/AwzOpsGdcXWX8PWplo6idzXvWrx kDD0lkagn0ooAohufSs51QIo7uYpAJhxOsZhuZ1e5/EpSa/eMHJ+aBKt9YSAGfpgQOL1 QsiuRkC5G1U21rOdAliVFMcBlWQXazPNH8vU4m2FPnldoFca0avfwYsw6fCPcaLpUMLV wZgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=UMIyvJSfdyrJvdn/Q98hoSQo0piEZReNNjk/7CPFZQE=; b=W4ENFNcyY8J3+IodyRqvRVpGb8RKI6Zo/s5tAz9ZmiRbWqqvEYwy4tf+9hfI32UNRO wGaVFBiQHn/7ZlHdzk+TDySK6jU+1NKqzb6GWBSRx7B8ZTdchW5bwXM5jr6Nnqgtrc6d S8OCHDxVx2KGgFWdSxSxNTKoeyVCF1cWnufp1HcTjo21g2LCl5NTeamo55B7JRD0CRWf q7hbbS2fUZA+KlF5gjEQv1EiWA/wKh+zmoHOr/VWRFK3NLWGf8YIBWh6d7sFzOHDek3f /JxSf37Qowh4yt3L+VlFNA3vC7P3Kqp95r2Mte0856Ph1VHU14dqPVy/adHPut4XNjxI QXEw== X-Gm-Message-State: AEkoout7kpVex770Av3pdt6N4Z7DibtAXXEF2bQIPk3lVhlGMMa3OEJpzeFk9hspSHt/xOcSo2+wYhoReRx6Pg== X-Received: by 10.202.245.214 with SMTP id t205mr217959oih.202.1469136469672; Thu, 21 Jul 2016 14:27:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.7.161 with HTTP; Thu, 21 Jul 2016 14:27:49 -0700 (PDT) In-Reply-To: <83d1m7yssc.fsf@gnu.org> References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> From: Noam Postavsky Date: Thu, 21 Jul 2016 17:27:49 -0400 X-Google-Sender-Auth: Etm8zZskMPUnvHXqmXxa4LSn_Cg Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Jul 21, 2016 at 10:22 AM, Eli Zaretskii wrote: > Thanks, but I think we are mis-communicating. What I need is not a > demonstration of the bug in action; I already got that. What I asked > for is different: > >> How probable is the situation where this problem pops up? And when >> was the bug introduced? > > You already answered the second question. For the first, I expected > to see something done frequently by either users or Lisp programs, > which bumps into this bug. Evaluating macroexpand, twice, with > completion in-between, doesn't qualify in my book as a frequent user > action, I hope you will agree (even if you personally happen to use it > quite a lot). > > So I'm still looking for the answer to the "how probable" question. I > need that to make up my mind about the urgency of the fix. Ah, okay. The probability of a user hitting this depends on how likely they are to perform completion inside a declare form. This depends on the kind of code the user writes, so it's hard to put a number on it. Also, if the user has a package like company enabled that performs completion during idle time, then just moving point through a declare form should be enough to trigger it, so in this case it might depend also on the kind of code the user reads. If the user never opens an elisp file with declare forms, then they certainly won't hit this. Once the user has triggered the problem via completion, all compilation of defuns (e.g. during package installation/upgrade) with declare forms will be broken (as well as loading uncompiled defuns with declare forms). Admittedly only gv-expander (along with gv-setter, but that one doesn't get unlearned) is vital to correct compilation, the rest (advertised-calling-convention obsolete interactive-only pure side-effect-free compiler-macro doc-string indent) are only optimizations or advisory in nature. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2016 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Noam Postavsky Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, pogonyshev@gmail.com Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14692640894574 (code B ref 23648); Sat, 23 Jul 2016 08:55:02 +0000 Received: (at 23648) by debbugs.gnu.org; 23 Jul 2016 08:54:49 +0000 Received: from localhost ([127.0.0.1]:34188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQsht-0001Bh-Ki for submit@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQshs-0001BW-EJ for 23648@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQshm-0000NK-DF for 23648@debbugs.gnu.org; Sat, 23 Jul 2016 04:54:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQshi-0000MJ-K3; Sat, 23 Jul 2016 04:54:38 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2443 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQshg-000726-Gc; Sat, 23 Jul 2016 04:54:37 -0400 Date: Sat, 23 Jul 2016 11:54:47 +0300 Message-Id: <834m7gwx7s.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Noam Postavsky on Thu, 21 Jul 2016 17:27:49 -0400) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Noam Postavsky > Date: Thu, 21 Jul 2016 17:27:49 -0400 > Cc: Michael Heerdegen , 23648@debbugs.gnu.org, > Paul Pogonyshev > > > So I'm still looking for the answer to the "how probable" question. I > > need that to make up my mind about the urgency of the fix. > > Ah, okay. The probability of a user hitting this depends on how likely > they are to perform completion inside a declare form. This depends on > the kind of code the user writes, so it's hard to put a number on it. > Also, if the user has a package like company enabled that performs > completion during idle time, then just moving point through a declare > form should be enough to trigger it, so in this case it might depend > also on the kind of code the user reads. If the user never opens an > elisp file with declare forms, then they certainly won't hit this. > > Once the user has triggered the problem via completion, all > compilation of defuns (e.g. during package installation/upgrade) with > declare forms will be broken (as well as loading uncompiled defuns > with declare forms). Admittedly only gv-expander (along with > gv-setter, but that one doesn't get unlearned) is vital to correct > compilation, the rest (advertised-calling-convention obsolete > interactive-only pure side-effect-free compiler-macro doc-string > indent) are only optimizations or advisory in nature. OK, let's push to emacs-25. Thanks. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Jul 2016 14:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, pogonyshev@gmail.com Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.146928350220410 (code B ref 23648); Sat, 23 Jul 2016 14:19:02 +0000 Received: (at 23648) by debbugs.gnu.org; 23 Jul 2016 14:18:22 +0000 Received: from localhost ([127.0.0.1]:34973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQxl0-0005J2-HY for submit@debbugs.gnu.org; Sat, 23 Jul 2016 10:18:22 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:37466) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQxkw-0005Ii-7g; Sat, 23 Jul 2016 10:18:20 -0400 Received: by mail-it0-f44.google.com with SMTP id f6so70295534ith.0; Sat, 23 Jul 2016 07:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=C5vTULMLCuh0Fmlb13jL4YGKm1NqYWXJoBlQZU69PGE=; b=rlqXAVrWX0M2efIoymFErxjANlcdTYgt5oWde+4iDqXnwEydeTT+49/DFt6bhzWKID wOIaMhunJZ5pIanhQ8oC4OqDjIvTqWGV+ZP42qVFrsoLrGdh5SMIXIbk/2wznCKndvoh ecWcgMia7TCj9DmSieVOeEwJZzljeH3aLFOfjpFnHuy0WuAm2s/2IfI+APyVCE7H168s NfDWtyWQuSPUDhxGnDKjBAXcWV4JYVLCZanai9fptlboR1CAMwlN6YH0cAQBAryU9mL6 1tLbUyMFbjGOAhHiNwRhR45wEMHKQkO97UOckDZXrQ7N7GEcNpyMTINB6ckNXy6P5MOA jfRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=C5vTULMLCuh0Fmlb13jL4YGKm1NqYWXJoBlQZU69PGE=; b=mkjinwEErXXZ8tflOuEKYFKThU7cZ6la8VGczGFmAOVqebI9SGHNxfnK3R7UE40oyL betXRTR6QTxEiQPlGpoxZu6dyo++wysr5/RnnN3zUeMKA64agGAf8Ggb//xbzQqPystN boOP2hNIqXxplEFvkdw9u5Sd2pcJ/E7pK4QvWjhIHMerEkaC99Rjgkg20/zUaPsR/fBV 9RNuRUjK5xcMNohXlJchv1qsuWNyy4JZCkQtJImbhKTSseawxedY2n0z65ROFfyFxEZB we2MZZAWnItVowveULZrxnf2e3CWpU5yBxRr/pVjjb/X/Xs41q3Ov2N7d5OrcjuJQQNS g0yw== X-Gm-Message-State: ALyK8tLNDzsNYpXi00unjaVPFS3bmKBsPhfc5bI4wlFu0a5vBFC0isNR8RocX1nkeWmYKQ== X-Received: by 10.36.217.68 with SMTP id p65mr70158862itg.9.1469283492755; Sat, 23 Jul 2016 07:18:12 -0700 (PDT) Received: from zony (206-188-64-44.cpe.distributel.net. [206.188.64.44]) by smtp.googlemail.com with ESMTPSA id 139sm4977966itk.1.2016.07.23.07.18.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 23 Jul 2016 07:18:12 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> <834m7gwx7s.fsf@gnu.org> Date: Sat, 23 Jul 2016 10:18:14 -0400 In-Reply-To: <834m7gwx7s.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 23 Jul 2016 11:54:47 +0300") Message-ID: <87r3akbfq1.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 23648 fixed close 23648 25.1 quit Eli Zaretskii writes: > OK, let's push to emacs-25. Thanks. Push as bc4c07fc. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Paul Pogonyshev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2016 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: npostavs@users.sourceforge.net Cc: michael_heerdegen@web.de, Eli Zaretskii , 23648@debbugs.gnu.org Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14693800864175 (code B ref 23648); Sun, 24 Jul 2016 17:09:02 +0000 Received: (at 23648) by debbugs.gnu.org; 24 Jul 2016 17:08:06 +0000 Received: from localhost ([127.0.0.1]:35998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRMso-00015H-EL for submit@debbugs.gnu.org; Sun, 24 Jul 2016 13:08:06 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:36067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRMsn-00014p-FL for 23648@debbugs.gnu.org; Sun, 24 Jul 2016 13:08:05 -0400 Received: by mail-oi0-f51.google.com with SMTP id w18so224519638oiw.3 for <23648@debbugs.gnu.org>; Sun, 24 Jul 2016 10:08:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hRUWH3SoL4lmDnA7rUOTBoaxwTXZCx0NaN2MQM60wu8=; b=xHQJYn8hKMKdLcqBbO7Np57c/RHTeJndQGrplgtbfNnxLSybbbz0OlQXbQY1AsN3Io OD64X3irQFqdT+vzBXrxwsp7P2irdZHnsnl8YD6uudA5xRz+PXBuUuzXRWp1Ulg+bJ/E Yf4EHQ8w74rpwaGrhfOGk2GoCKvunDvsxkj7WNkG1nrP5eUMs4Bb3gFC6MoLe1xGtfWC Ylp7pp6EucOWGU84LKUxEB1jZoWMqWUh2e/xldQI9GdtvTemyt4wYjghhugnVF0K7Vgc NEGAWDrIAKm+4UmH9STVRhpz7hUwTUfk2CCZhiJB2IiEURSrdMGss1Cd9CYGkEwA13CG k/4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hRUWH3SoL4lmDnA7rUOTBoaxwTXZCx0NaN2MQM60wu8=; b=V7olIkXgFVPBDjw9exJXPX/GXlYyBUu/E2V9Jy+OLlLUDmVPm43kk4qx1S92iIYSi6 E9Mkw1dbajdqGBFuuTYx+SS8HN+lxMkdQD+2ppZKND+cj7sm7SNouWuQik1T6khoyfJn smQEjk0vFBgqBMAELxGlhHvPrQ6Cy+o0DA4CcBdalzqBVjeKQRgQrZK5uv8J3OjDUN9/ /6fJqOrgdL/ir61xwzumjVSEcDP1hSs3mxZsH8Ce+1em1ZHYSLrNw6vvKFBH0OmnSMX2 HqTwku9bQvmi0YTqJUCasDXkNHaPcvSrWFLCmyo3PaWCdekVf7yPm+mqHLZiWDQyKH5C dDmw== X-Gm-Message-State: AEkoouuIkmJPgRr103m9IQDzJNo4+Ej0FZKaOsSkeux6kkiq1XJRAP9JMElQr0vxvSp6v0X+7oqr31VKTKRL7A== X-Received: by 10.157.18.246 with SMTP id g109mr8003642otg.180.1469380079964; Sun, 24 Jul 2016 10:07:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.202.235.143 with HTTP; Sun, 24 Jul 2016 10:07:59 -0700 (PDT) In-Reply-To: <87r3akbfq1.fsf@users.sourceforge.net> References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> <834m7gwx7s.fsf@gnu.org> <87r3akbfq1.fsf@users.sourceforge.net> From: Paul Pogonyshev Date: Sun, 24 Jul 2016 19:07:59 +0200 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Shouldn't it be also merged to master? Paul On 23 July 2016 at 16:18, wrote: > tags 23648 fixed > close 23648 25.1 > quit > > Eli Zaretskii writes: > >> OK, let's push to emacs-25. Thanks. > > Push as bc4c07fc. From unknown Sun Jun 22 11:49:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23648: [PATCH] `defun-declarations-alist' can be unintentionally modified Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Jul 2016 17:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23648 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Paul Pogonyshev Cc: michael_heerdegen@web.de, 23648@debbugs.gnu.org, npostavs@users.sourceforge.net Reply-To: Eli Zaretskii Received: via spool by 23648-submit@debbugs.gnu.org id=B23648.14693814886204 (code B ref 23648); Sun, 24 Jul 2016 17:32:01 +0000 Received: (at 23648) by debbugs.gnu.org; 24 Jul 2016 17:31:28 +0000 Received: from localhost ([127.0.0.1]:36003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRNFQ-0001c0-F8 for submit@debbugs.gnu.org; Sun, 24 Jul 2016 13:31:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52655) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bRNFP-0001bp-Jh for 23648@debbugs.gnu.org; Sun, 24 Jul 2016 13:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRNFJ-0008Vy-L1 for 23648@debbugs.gnu.org; Sun, 24 Jul 2016 13:31:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRNFE-0008Vf-NX; Sun, 24 Jul 2016 13:31:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4077 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bRNFD-0004Vi-Et; Sun, 24 Jul 2016 13:31:16 -0400 Date: Sun, 24 Jul 2016 20:31:07 +0300 Message-Id: <8360rvuen8.fsf@gnu.org> From: Eli Zaretskii In-reply-to: (message from Paul Pogonyshev on Sun, 24 Jul 2016 19:07:59 +0200) References: <87twfnd50u.fsf@users.sourceforge.net> <83wpkj10eg.fsf@gnu.org> <83k2gi24nz.fsf@gnu.org> <83inw2227y.fsf@gnu.org> <87r3aqbppk.fsf@web.de> <83d1ma1hai.fsf@gnu.org> <87a8hbdcfd.fsf@users.sourceforge.net> <83d1m7yssc.fsf@gnu.org> <834m7gwx7s.fsf@gnu.org> <87r3akbfq1.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.3 (------) > From: Paul Pogonyshev > Date: Sun, 24 Jul 2016 19:07:59 +0200 > Cc: Eli Zaretskii , 23648@debbugs.gnu.org, michael_heerdegen@web.de > > Shouldn't it be also merged to master? It will be, when the next merge takes place.