GNU bug report logs - #23647
25.1.50; In man pages, links on hyphenated words don't work

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 23647 <at> debbugs.gnu.org
Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work
Date: Sun, 29 May 2016 17:42:13 +0300

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Date: Sun, 29 May 2016 11:52:29 +0200
> 
> O. emacs -Q
> 1. Open a man page that has a link on a hyphenated word, e.g. on my
>    system: M-x man RET signal RET, put point on the word spanning lines
>    129-130, which is displayed as `sig-
>    nalfd(2)'.
> 2. Type RET (or click mouse-1 or mouse-2) on that link.
> => The error message "Can’t find the 2 sig-nalfd manpage" is displayed.
> 
> The following patch makes the link DTRT:
> 
> diff --git a/lisp/man.el b/lisp/man.el
> index 5acf90b..5d4cacc 100644
> --- a/lisp/man.el
> +++ b/lisp/man.el
> @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel
>  			(quit-restore-window
>  			 (get-buffer-window (current-buffer) t) 'kill)
>  		      (kill-buffer (current-buffer)))
> -		    (message "Can't find the %s manpage"
> -			     (Man-page-from-arguments args)))
> +                    ;; Entries hyphenated due to the window width
> +                    ;; won't be found in the man database, so remove
> +                    ;; the hyphenation and look again.
> +		    (if (string-match "-" args)

Is it only the ASCII hyphen/minus, or could there be other characters
(e.g., if Groff/troff are invoked with some exotic -Tfoo switch)?

> This is a long-standing bug (presumably since commit
> 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although
> the fix seems safe, I suppose it's too late for emacs-25.  So if there
> are no objections, should I commit it to master, or is it ok for the
> upcoming release?

Master, please.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.