From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 09:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23647@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14645155695003 (code B ref -1); Sun, 29 May 2016 09:53:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 May 2016 09:52:49 +0000 Received: from localhost ([127.0.0.1]:45255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6xOr-0001Id-G1 for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6xOq-0001IQ-5k for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6xOk-00025y-0a for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOj-00025u-Ty for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOi-0005zB-L6 for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6xOc-00024O-Jw for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:39 -0400 Received: from mout.gmx.net ([212.227.15.19]:60974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOc-000242-9m for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:34 -0400 Received: from rosalinde ([89.245.70.247]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Leux5-1brmXQ33ux-00qi7L for ; Sun, 29 May 2016 11:52:31 +0200 From: Stephen Berman Date: Sun, 29 May 2016 11:52:29 +0200 Message-ID: <87d1o52ntu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:7Vg5clZoTYcZwSSXI6Ptbr3YbLjWnSIb2Dg7tpBIEbqJKC8WX6x C2y1dvsiVME+/eIhGsMD6qQFrJLDabJJGUnPFxt+uh9506Q3DJvBLCPAtWEfGWER+vDquXm 79bltLD/1ZVhB2P+f8EkFFnjQ6Y2ZCNKDkqtppBvtsj1+WioLvnFzvQ+1BPUXnupLPNpUli uDX9cUwH5C5Uc9vSbnRhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:TVtBqW6/QCs=:CbZXnTRm2fe+e+rEm0YW+3 eo03HbT/P3ND5fQdgORDqXhDJ6FAR5FTWgLVP0edELlUXctIj0Pm1wdqhmYjXDJI32JqGHnLE BnoL3CoPD84Vp5eqC/y6pObS+6yJf7DNxOd5p4eU9SoqB8HkZAf7VWr83w3MbTINfKtQJzfhc bFUCkRW/DCQnklc5tVeMxZtBZtCmZuggbCiyAXUbrekyprCaAaaUORQqI8S6t3uSIB9xGoFrL oj49RAyGpIYx0VC4HYy3PkoGPyjtPPtUQGzmKBepn2sh2fJ/syoxy9G5fyvDkiuNToizYYViD kla4+21iKx2wDo716uIOFkv+D0SvgOkUNZJqWfEA0UPbZVJKJe+DGWFz6nJXtmvIYaFxjRkgh Q0Csqqn+W+dmTgjWHD3sBLwDrg8rxslD80y5s8XhpeOBoh57vxMWaPrZuyLtlAFc4NR2JOUVm xV1lS0aNOObI3CIAryJzLqhX5rpb6BNRTa9h5kOGCQVWp/O1Zw5KrnuFiVgAaU1/yqc8Tilzi ZjitIMZh8C3O9/yYrZAGVB8JbEboGpaFvJSEGVet0f7NDWbdWT+kMRtDBdmU+iTWcFcHNvjSQ Jz57K+pIFLGN1drvovrf3hdxeidL81+U+SYDDQm7UT4xOviAZUpuOlgU0xmOEEC1wgY1Trx1e 3UCyOX25NIiHwtWmuHVIWyn5OfUJBgY1CwzbMlmHD0zjdhxJ+gE5HZ60CQRmo7W05xwr7WolI F/cqXJ1yQ12p+6yXXNsR328xmNL95Iov+SrC82YhJMU+CrA9b7VMAPHDtEPMYTht+ZaFHDTbH kRsldOx X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) O. emacs -Q 1. Open a man page that has a link on a hyphenated word, e.g. on my system: M-x man RET signal RET, put point on the word spanning lines 129-130, which is displayed as `sig- nalfd(2)'. 2. Type RET (or click mouse-1 or mouse-2) on that link. =3D> The error message "Can=E2=80=99t find the 2 sig-nalfd manpage" is disp= layed. The following patch makes the link DTRT: diff --git a/lisp/man.el b/lisp/man.el index 5acf90b..5d4cacc 100644 --- a/lisp/man.el +++ b/lisp/man.el @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel (quit-restore-window (get-buffer-window (current-buffer) t) 'kill) (kill-buffer (current-buffer))) - (message "Can't find the %s manpage" - (Man-page-from-arguments args))) + ;; Entries hyphenated due to the window width + ;; won't be found in the man database, so remove + ;; the hyphenation and look again. + (if (string-match "-" args) + (let ((str (replace-match "" nil nil args))) + (Man-getpage-in-background str)) + (message "Can't find the %s manpage" + (Man-page-from-arguments args)))) =20 (if Man-fontify-manpage-flag (message "%s man page formatted" This is a long-standing bug (presumably since commit 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although the fix seems safe, I suppose it's too late for emacs-25. So if there are no objections, should I commit it to master, or is it ok for the upcoming release? In GNU Emacs 25.1.50.19 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-05-28 built on rosalinde Repository revision: 4ef0fc192b8a10625053dbb9376c814e68612eb6 Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=3D-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 14:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 23647@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.14645329316360 (code B ref 23647); Sun, 29 May 2016 14:43:02 +0000 Received: (at 23647) by debbugs.gnu.org; 29 May 2016 14:42:11 +0000 Received: from localhost ([127.0.0.1]:46534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71us-0001eW-NG for submit@debbugs.gnu.org; Sun, 29 May 2016 10:42:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b71ur-0001eF-9k for 23647@debbugs.gnu.org; Sun, 29 May 2016 10:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b71ui-0000Hu-Sw for 23647@debbugs.gnu.org; Sun, 29 May 2016 10:42:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b71ui-0000Hj-QF; Sun, 29 May 2016 10:42:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b71uh-0002H4-0x; Sun, 29 May 2016 10:41:59 -0400 Date: Sun, 29 May 2016 17:42:13 +0300 Message-Id: <83eg8lx6wq.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87d1o52ntu.fsf@gmx.net> (message from Stephen Berman on Sun, 29 May 2016 11:52:29 +0200) References: <87d1o52ntu.fsf@gmx.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Stephen Berman > Date: Sun, 29 May 2016 11:52:29 +0200 > > O. emacs -Q > 1. Open a man page that has a link on a hyphenated word, e.g. on my > system: M-x man RET signal RET, put point on the word spanning lines > 129-130, which is displayed as `sig- > nalfd(2)'. > 2. Type RET (or click mouse-1 or mouse-2) on that link. > => The error message "Can’t find the 2 sig-nalfd manpage" is displayed. > > The following patch makes the link DTRT: > > diff --git a/lisp/man.el b/lisp/man.el > index 5acf90b..5d4cacc 100644 > --- a/lisp/man.el > +++ b/lisp/man.el > @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel > (quit-restore-window > (get-buffer-window (current-buffer) t) 'kill) > (kill-buffer (current-buffer))) > - (message "Can't find the %s manpage" > - (Man-page-from-arguments args))) > + ;; Entries hyphenated due to the window width > + ;; won't be found in the man database, so remove > + ;; the hyphenation and look again. > + (if (string-match "-" args) Is it only the ASCII hyphen/minus, or could there be other characters (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? > This is a long-standing bug (presumably since commit > 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although > the fix seems safe, I suppose it's too late for emacs-25. So if there > are no objections, should I commit it to master, or is it ok for the > upcoming release? Master, please. Thanks. From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 May 2016 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 23647@debbugs.gnu.org Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.146456338726915 (code B ref 23647); Sun, 29 May 2016 23:10:02 +0000 Received: (at 23647) by debbugs.gnu.org; 29 May 2016 23:09:47 +0000 Received: from localhost ([127.0.0.1]:46711 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79q7-000703-3b for submit@debbugs.gnu.org; Sun, 29 May 2016 19:09:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:59274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79q5-0006zq-Ua for 23647@debbugs.gnu.org; Sun, 29 May 2016 19:09:46 -0400 Received: from rosalinde ([89.245.70.247]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0M1n4s-1bM57r3bsw-00tmLI; Mon, 30 May 2016 01:09:38 +0200 From: Stephen Berman References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> Date: Mon, 30 May 2016 01:09:21 +0200 In-Reply-To: <83eg8lx6wq.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 May 2016 17:42:13 +0300") Message-ID: <878tys31i6.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:AA8NUDT41IV+v7/F9DewtPvJtOym7smd9zoUhK3wAVIuzCzOg9X NAZ5aEWJBtmK8AXq7bRRpBbutdPiCiE7aEhfMkJp92WsVUFzj/86knsWN3QnS0SqtIstcgT 9xto1LauPlSrZELVBgSFbc/kBE79u3Je8QL0rGU9HAlW2TK82cZtIupYhGABDK6fQdj3GkQ uBpw5pelKmnc+uw6sN65Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:7OyVZL9qqnM=:9dpAQdIXEYzX1Rd6h5gPym Eopbkg4NWndAyzNB6TN+MABYBDcTk9mW2D807l+2eRUryc5KF/9vexOoTep+cjGFK7znk+kpQ Qsty2eFtZ0z9spsHxfe9xIzC7HIJut/Wldq2gBIuoPSAjRsLUoqhqGRh6vPyxQzTw3dL2mOH0 x0N30nqaBJzeHAMmAWAaDOO/8IFNbGljZzSpVP5q6feir0ucmJCaGCAh3ghrsFpcpruW3SOWe GIN0Nh3MTcwJtdXgc87qSVmJIszIm0/0/pT5xa4P47PInjyLmiUsQVZ9/OzbidoGuAJlHDYyE wWIS8xj3UgV/bx3hitQ5pvCX6wDj4zE7MG+Far/GDOJc91vTeJz2myhQiKWV4hL6+g97GzUF/ r4lReFG5H088xLQl+/XfBHazbiLkFIROIBBsWfiIyBtz7FQ+1zZ+Unw4pX4HIm9eTcp0rxeUH kf32Z3p6FEV8+BUSf0lgi6b13cfXt/9Ekh7EvjgNyCh1rIPoId6DTq3jyEtL1eHNlnlxZq0Zf 2SdhdpW1HTMNfAnQT7PKroLlcbAFKlxZSU7qAfloQitmSGQ/n6tXGJ/OZd2BRzOsBsKaP+cN9 tgn89UJwxzyuGCzZ5HbWzAlsYtsESehCGLKKMbxGVWICKEB2Wzj0kALW7lfAUWrLmQiiyCRnP cKRL0/foTnN5aqIoCp18I7jX4YZcG/CQBD3aNvMkvj4+nsWGTqG1GIdv1XHO17pYqBwXQLAa0 G2/4+Yl90rNOq/QzecvNtGrRD1R5F+gvKX6kzJKthwZJeXtJ1zcWzADqfPl1qkKErMHpgSFoS vvV2GpQu5I3fjSt0mggT0ohdQ4b/w== X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Sun, 29 May 2016 17:42:13 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Sun, 29 May 2016 11:52:29 +0200 >>=20 >> O. emacs -Q >> 1. Open a man page that has a link on a hyphenated word, e.g. on my >> system: M-x man RET signal RET, put point on the word spanning lines >> 129-130, which is displayed as `sig- >> nalfd(2)'. >> 2. Type RET (or click mouse-1 or mouse-2) on that link. >> =3D> The error message "Can=E2=80=99t find the 2 sig-nalfd manpage" is d= isplayed. >>=20 >> The following patch makes the link DTRT: >>=20 >> diff --git a/lisp/man.el b/lisp/man.el >> index 5acf90b..5d4cacc 100644 >> --- a/lisp/man.el >> +++ b/lisp/man.el >> @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel >> (quit-restore-window >> (get-buffer-window (current-buffer) t) 'kill) >> (kill-buffer (current-buffer))) >> - (message "Can't find the %s manpage" >> - (Man-page-from-arguments args))) >> + ;; Entries hyphenated due to the window width >> + ;; won't be found in the man database, so remove >> + ;; the hyphenation and look again. >> + (if (string-match "-" args) > > Is it only the ASCII hyphen/minus, or could there be other characters > (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? That possibility didn't occur to me but according to Wikipedia, groff also outputs soft hyphens (octal 255) and indeed I see that the function Man-build-references-alist, which also removes hyphenation (in a more complicated way that doesn't seem to be needed in the present case), also takes the soft hyphen into account. That can be done here too by changing the above string-match regexp to "[-=C2=AD]". If someone knows of other possibilities allowed by [gt]roff, maybe the regexp could be further extended, or the condition reformulated as required. What do you think? >> This is a long-standing bug (presumably since commit >> 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although >> the fix seems safe, I suppose it's too late for emacs-25. So if there >> are no objections, should I commit it to master, or is it ok for the >> upcoming release? > > Master, please. Ok. I'll wait another day or two in case there's more feedback. Thanks. Steve Berman From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2016 00:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stephen Berman Cc: 23647@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.14645677751417 (code B ref 23647); Mon, 30 May 2016 00:23:01 +0000 Received: (at 23647) by debbugs.gnu.org; 30 May 2016 00:22:55 +0000 Received: from localhost ([127.0.0.1]:46720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Ays-0000Mm-UM for submit@debbugs.gnu.org; Sun, 29 May 2016 20:22:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Ayp-0000MX-JT for 23647@debbugs.gnu.org; Sun, 29 May 2016 20:22:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Ayh-0006hQ-7v for 23647@debbugs.gnu.org; Sun, 29 May 2016 20:22:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59639) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Ayh-0006hM-4p; Sun, 29 May 2016 20:22:43 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3667 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b7Ayg-0006gs-BP; Sun, 29 May 2016 20:22:42 -0400 Date: Mon, 30 May 2016 03:22:58 +0300 Message-Id: <83vb1wwg0t.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <878tys31i6.fsf@gmx.net> (message from Stephen Berman on Mon, 30 May 2016 01:09:21 +0200) References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> <878tys31i6.fsf@gmx.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Stephen Berman > Cc: 23647@debbugs.gnu.org > Date: Mon, 30 May 2016 01:09:21 +0200 > > > Is it only the ASCII hyphen/minus, or could there be other characters > > (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? > > That possibility didn't occur to me but according to Wikipedia, groff > also outputs soft hyphens (octal 255) and indeed I see that the function > Man-build-references-alist, which also removes hyphenation (in a more > complicated way that doesn't seem to be needed in the present case), > also takes the soft hyphen into account. That can be done here too by > changing the above string-match regexp to "[-­]". If someone knows of > other possibilities allowed by [gt]roff, maybe the regexp could be > further extended, or the condition reformulated as required. What do > you think? I'm not enough of a roff expert to tell, but how about asking on the Groff list? From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 May 2016 13:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 23647@debbugs.gnu.org Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.146461655821967 (code B ref 23647); Mon, 30 May 2016 13:56:02 +0000 Received: (at 23647) by debbugs.gnu.org; 30 May 2016 13:55:58 +0000 Received: from localhost ([127.0.0.1]:47691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Nfi-0005iF-CJ for submit@debbugs.gnu.org; Mon, 30 May 2016 09:55:58 -0400 Received: from mout.gmx.net ([212.227.15.18]:60575) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Nff-0005i1-S4 for 23647@debbugs.gnu.org; Mon, 30 May 2016 09:55:56 -0400 Received: from rosalinde ([89.245.103.171]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MXIcX-1b28SE3meT-00WHO8; Mon, 30 May 2016 15:55:48 +0200 From: Stephen Berman References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> <878tys31i6.fsf@gmx.net> <83vb1wwg0t.fsf@gnu.org> Date: Mon, 30 May 2016 15:55:47 +0200 In-Reply-To: <83vb1wwg0t.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 May 2016 03:22:58 +0300") Message-ID: <87a8j7tzto.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:GSSVFKCpMH2mMbsL53ZsCWA/WQrpDUU+Tap6dwyA3h/W5U57LzZ kjmKAkbqE0GXz+kzgRmqva8YANUt1pQjeITNiTKeAYdG/miG7TvgRtVSEX3U3Kqqbi8OH86 qBhSObC8JpMyK1G9Wd3EJjd9pFi+/msLVTlqbbyI9bmmENk+cF4MKdEPYcM2fF83Ddxciu4 4ElEacLv0LFuqh/RDf4mg== X-UI-Out-Filterresults: notjunk:1;V01:K0:wfrUwSH6Kjs=:sQGN240V7/t5Zg/5epcM9L h/UvBz/5J8Kthii3oPzH9fDW+Wo8FQkp2Egq8SRZeL0Gem9xgz7MWpn7/H45Qundhrab3k9Yq gCeuiMBBhwbUSwGCGjP9i6RSOoZLJUH1tdlHqZtiPA75VhohKJZeDIqm6J2R2uGUwiPlbtWjG XWkBfKE6BYTFKBguyTWnL8/gtpIWYsm8hxAgWb2dHhPXff0SymobBluU77jq8z4tTC/Bbp2P3 mS28WA+ICCfdU0kCulzZkwwW2Hlu3/FaxKm/aOXjnBS2stznZV078c6v+1Dglic9NOoA2rTGa bx7GlQIP0jtxxMlBGmmA7wndQXE/o6si5ZDQ20gw2PYIftr1IKGvDY25UVryTPZLCQzsphx99 iytOt6dS9Y2qh/0MfJX5+ijY33Y4gNQYZa/qTf50q9sFStrB6Q3M9sJG2uJSjsvcyXBYpIOjq bNIUleSxubAUvGJn8XkxryUKmfj67aNpT4RQ2xQPWWQXttT2Dflf7zkuOCRjYYFcqimgK7l0u QILim54nItybjokasl/zD3jMeM3sX/ABluOEbU3fFabQQFUc+pwIWQlCL79bVt3AHXz7Dxcz7 ubUOm7n35+j7LwRshQm6fQRt73hZcgmBpvGedVKCXmhZh5/JG4lU5nTBJBie+wwO41FamxE9b 5HbrIVk1+3IegllDBodK1uc008z36qZa9htVWsJ+7g0smp1GcTTrax0lHhjz4+9XddW8ktmXW WjIW4JN5IN1XSilJUSG4EV8gQBSpGGrFEGy/iWnuHuBpJcBSAyIVZBaTf9ZR/XddiMJFEH4Yq EytwguU X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Mon, 30 May 2016 03:22:58 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 23647@debbugs.gnu.org >> Date: Mon, 30 May 2016 01:09:21 +0200 >>=20 >> > Is it only the ASCII hyphen/minus, or could there be other characters >> > (e.g., if Groff/troff are invoked with some exotic -Tfoo switch)? >>=20 >> That possibility didn't occur to me but according to Wikipedia, groff >> also outputs soft hyphens (octal 255) and indeed I see that the function >> Man-build-references-alist, which also removes hyphenation (in a more >> complicated way that doesn't seem to be needed in the present case), >> also takes the soft hyphen into account. That can be done here too by >> changing the above string-match regexp to "[-=C2=AD]". If someone knows= of >> other possibilities allowed by [gt]roff, maybe the regexp could be >> further extended, or the condition reformulated as required. What do >> you think? > > I'm not enough of a roff expert to tell, but how about asking on the > Groff list? I did that and got this feedback from Steffen Nurpmeso: > I have been convinced that soft hyphen is a control character and > not something visual, it should be used as a =C2=ABbreak-indicator=C2=BB > rather than as a hyphenation character, interpretation of which is > left as an excercise for the processing software. I have no idea > still but would guess groff uses "hyphen minus" U+002D or hyphen > U+2010 if Unicode is possible. In a followup to another response he added: > For display purposes however i think U+00AD can't be used > directly, but will be replaced by the renderer to either nothing, > if no wrap is to be applied at the character position, or > something appropriate, like ASCII hyphen-minus or some extended > Unicode "Pd" letter, of which there are some (e.g., U+058A > ARMENIAN HYPHEN, U+1400 CANADIAN SYLLABICS HYPHEN, and more). And he also made this suggestion: > Eli Zaretskii is so active on the > Unicode list, why don't you use the Pd character class for > detecting =C2=ABhyphen=C2=BB? I guess this should cover all such things > already as of today, thanks to Werner Lemberg?! So how should we proceed from here? We could add U+2010 to the regexp in my patch, which would then be this: "[-=E2=80=90=C2=AD]" (hyphen-minus (= ASCII 45), hyphen (U+2010), soft hyphen (U+00AD) -- it seems harmless to retain the latter, given that man.el already uses it elsewhere), but if these are all included in the Unicode Pd character class along with other possible hyphen characters, maybe a different approach is required. I know nothing about the Pd character class and how to detect it with Elisp; I also don't know if doing that would lead to further changes in man.el, making this a larger undertaking. What do you suggest? Steve Berman From unknown Sun Jun 22 00:12:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jun 2016 15:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stephen Berman Cc: 23647@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 23647-submit@debbugs.gnu.org id=B23647.146505452923101 (code B ref 23647); Sat, 04 Jun 2016 15:36:01 +0000 Received: (at 23647) by debbugs.gnu.org; 4 Jun 2016 15:35:29 +0000 Received: from localhost ([127.0.0.1]:54512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Dbl-00060X-HN for submit@debbugs.gnu.org; Sat, 04 Jun 2016 11:35:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9Dbk-00060L-I3 for 23647@debbugs.gnu.org; Sat, 04 Jun 2016 11:35:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9Dba-0005Sx-AK for 23647@debbugs.gnu.org; Sat, 04 Jun 2016 11:35:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9Dba-0005Sq-73; Sat, 04 Jun 2016 11:35:18 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2805 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9DbY-00078z-GY; Sat, 04 Jun 2016 11:35:16 -0400 Date: Sat, 04 Jun 2016 18:35:46 +0300 Message-Id: <83lh2lufu5.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87a8j7tzto.fsf@gmx.net> (message from Stephen Berman on Mon, 30 May 2016 15:55:47 +0200) References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> <878tys31i6.fsf@gmx.net> <83vb1wwg0t.fsf@gnu.org> <87a8j7tzto.fsf@gmx.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Stephen Berman > Cc: 23647@debbugs.gnu.org > Date: Mon, 30 May 2016 15:55:47 +0200 > > > I'm not enough of a roff expert to tell, but how about asking on the > > Groff list? > > I did that and got this feedback from Steffen Nurpmeso: > > > I have been convinced that soft hyphen is a control character and > > not something visual, it should be used as a «break-indicator» > > rather than as a hyphenation character, interpretation of which is > > left as an excercise for the processing software. I have no idea > > still but would guess groff uses "hyphen minus" U+002D or hyphen > > U+2010 if Unicode is possible. > > In a followup to another response he added: > > > For display purposes however i think U+00AD can't be used > > directly, but will be replaced by the renderer to either nothing, > > if no wrap is to be applied at the character position, or > > something appropriate, like ASCII hyphen-minus or some extended > > Unicode "Pd" letter, of which there are some (e.g., U+058A > > ARMENIAN HYPHEN, U+1400 CANADIAN SYLLABICS HYPHEN, and more). > > And he also made this suggestion: > > > Eli Zaretskii is so active on the > > Unicode list, why don't you use the Pd character class for > > detecting «hyphen»? I guess this should cover all such things > > already as of today, thanks to Werner Lemberg?! > > So how should we proceed from here? We could add U+2010 to the regexp > in my patch, which would then be this: "[-‐­]" (hyphen-minus (ASCII 45), > hyphen (U+2010), soft hyphen (U+00AD) -- it seems harmless to retain the > latter, given that man.el already uses it elsewhere), but if these are > all included in the Unicode Pd character class along with other possible > hyphen characters, maybe a different approach is required. I know > nothing about the Pd character class and how to detect it with Elisp; I > also don't know if doing that would lead to further changes in man.el, > making this a larger undertaking. What do you suggest? I'd go with just those 3, I think the others will not be produced by Groff. Thanks. From unknown Sun Jun 22 00:12:26 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stephen Berman Subject: bug#23647: closed (Re: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work) Message-ID: References: <87ziqzq3yw.fsf@gmx.net> <87d1o52ntu.fsf@gmx.net> X-Gnu-PR-Message: they-closed 23647 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 23647@debbugs.gnu.org Date: Sun, 05 Jun 2016 11:19:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1465125542-25696-1" This is a multi-part message in MIME format... ------------=_1465125542-25696-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #23647: 25.1.50; In man pages, links on hyphenated words don't work which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 23647@debbugs.gnu.org. --=20 23647: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23647 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1465125542-25696-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 23647-done) by debbugs.gnu.org; 5 Jun 2016 11:18:12 +0000 Received: from localhost ([127.0.0.1]:54940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9W4K-0006fT-HF for submit@debbugs.gnu.org; Sun, 05 Jun 2016 07:18:12 -0400 Received: from mout.gmx.net ([212.227.17.21]:60730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9W4I-0006fH-Se for 23647-done@debbugs.gnu.org; Sun, 05 Jun 2016 07:18:11 -0400 Received: from rosalinde ([89.245.71.113]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MY4Ls-1awR9m2GY4-00UqRU; Sun, 05 Jun 2016 13:18:02 +0200 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#23647: 25.1.50; In man pages, links on hyphenated words don't work References: <87d1o52ntu.fsf@gmx.net> <83eg8lx6wq.fsf@gnu.org> <878tys31i6.fsf@gmx.net> <83vb1wwg0t.fsf@gnu.org> <87a8j7tzto.fsf@gmx.net> <83lh2lufu5.fsf@gnu.org> Date: Sun, 05 Jun 2016 13:17:59 +0200 In-Reply-To: <83lh2lufu5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Jun 2016 18:35:46 +0300") Message-ID: <87ziqzq3yw.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:79pfv7Y54bf265np2Qh2h27EmuCmIZCH/nT41PCoS66VYytjUnr 2IWNnbgcZJi/QXxlzqpKubUmZQIcddgZ5MXfnsUXonmonmR0cPh/h8YObLqCzdZKTO1zLhp qb028dD37hvS2Oy8pKlfjOKnVd0RX49oEMdsJ3an6oaYPMmfy3tpOmDvaq8dmlsO7axxKta EkoW25B+m7VIPr+5Scs5Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:1Oqwj16YkWg=:rAP6R5QvwlkYV23hPGtyut cU0gUL+360FOyocSx/3D5/ZZ0Nm6umeKMjGmTrhEke2rlQC1Kz+qTZok5AY4F0mz8CUsBomS/ c6DZf3ORH6PfME/mm2Bc5thQWSHiVvIFMXJmGUpikSdJ3hFCa+5IQHrm8LSZsrTqclp/e+F0r ae711tXsJfOLdWxE0YvcaVIcLTh+slZoLfWkGEvCUz6H9+rD/QX5QflRNPwyIFUljt1Z2zCbA yqlCiPszGG5UrG9uDQrHVtlWuv4CmPAgm/HGk60vedyp73WY9MgJ/zk6FelL5RanlZ4ChLN4r 378If6fC03iPxc9NmKTLx0th5mi1fC4bmcqdf1pviytMQCU7JmkLDk9WQJKgdDTxqEHy24WuZ jBjU2XAUQoTLsjybaIzuBjUE3GEgDroHIHcq6xJhXLaTR0VMSWvF4mE/txirekfzK6djfg5ZH FR3GKOhUGFLx/eaAYUzZ78oumEAw9aPdEmuAYWJyXrD/p3XtXSIdYfSerYp1iRSrHFd0KLQ6N zRcRTXyjY5dGF/4uZ/F8VJ6nVJy8pPzYwjfEfzq6d7Q3+Gs8kGkNtEIEyeOO8+CVHkoTUZH4j 5ATc+I+3aqiqtA4YiNzb7Ps0eeHotS2XHsCZj2NwXHR7V/z6OfC1lw4TTJKpy3e6R2FEpX2L5 xu9NWuHRIq/n9VzFDcYt39ePa5puCiyzDb28N9LocDKTX/8+o7HRD5t23EhJ0SFPRJNyvHZeI hnuhKQnBajMSv5n4ZSt8DACeW4YfCnvxtBikR9aXPVsMtOD02csDJ9q9gV/HrG4Sc7gaGjHMe WBrZbrq X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 23647-done Cc: 23647-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On Sat, 04 Jun 2016 18:35:46 +0300 Eli Zaretskii wrote: >> So how should we proceed from here? We could add U+2010 to the regexp >> in my patch, which would then be this: "[-=E2=80=90=C2=AD]" (hyphen-minu= s (ASCII 45), >> hyphen (U+2010), soft hyphen (U+00AD) -- it seems harmless to retain the >> latter, given that man.el already uses it elsewhere), but if these are >> all included in the Unicode Pd character class along with other possible >> hyphen characters, maybe a different approach is required. I know >> nothing about the Pd character class and how to detect it with Elisp; I >> also don't know if doing that would lead to further changes in man.el, >> making this a larger undertaking. What do you suggest? > > I'd go with just those 3, I think the others will not be produced by > Groff. Done in commit 75de364 on master, and closing the bug. Steve Berman ------------=_1465125542-25696-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 May 2016 09:52:49 +0000 Received: from localhost ([127.0.0.1]:45255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6xOr-0001Id-G1 for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6xOq-0001IQ-5k for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6xOk-00025y-0a for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57222) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOj-00025u-Ty for submit@debbugs.gnu.org; Sun, 29 May 2016 05:52:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOi-0005zB-L6 for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6xOc-00024O-Jw for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:39 -0400 Received: from mout.gmx.net ([212.227.15.19]:60974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6xOc-000242-9m for bug-gnu-emacs@gnu.org; Sun, 29 May 2016 05:52:34 -0400 Received: from rosalinde ([89.245.70.247]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Leux5-1brmXQ33ux-00qi7L for ; Sun, 29 May 2016 11:52:31 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 25.1.50; In man pages, links on hyphenated words don't work Date: Sun, 29 May 2016 11:52:29 +0200 Message-ID: <87d1o52ntu.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:7Vg5clZoTYcZwSSXI6Ptbr3YbLjWnSIb2Dg7tpBIEbqJKC8WX6x C2y1dvsiVME+/eIhGsMD6qQFrJLDabJJGUnPFxt+uh9506Q3DJvBLCPAtWEfGWER+vDquXm 79bltLD/1ZVhB2P+f8EkFFnjQ6Y2ZCNKDkqtppBvtsj1+WioLvnFzvQ+1BPUXnupLPNpUli uDX9cUwH5C5Uc9vSbnRhw== X-UI-Out-Filterresults: notjunk:1;V01:K0:TVtBqW6/QCs=:CbZXnTRm2fe+e+rEm0YW+3 eo03HbT/P3ND5fQdgORDqXhDJ6FAR5FTWgLVP0edELlUXctIj0Pm1wdqhmYjXDJI32JqGHnLE BnoL3CoPD84Vp5eqC/y6pObS+6yJf7DNxOd5p4eU9SoqB8HkZAf7VWr83w3MbTINfKtQJzfhc bFUCkRW/DCQnklc5tVeMxZtBZtCmZuggbCiyAXUbrekyprCaAaaUORQqI8S6t3uSIB9xGoFrL oj49RAyGpIYx0VC4HYy3PkoGPyjtPPtUQGzmKBepn2sh2fJ/syoxy9G5fyvDkiuNToizYYViD kla4+21iKx2wDo716uIOFkv+D0SvgOkUNZJqWfEA0UPbZVJKJe+DGWFz6nJXtmvIYaFxjRkgh Q0Csqqn+W+dmTgjWHD3sBLwDrg8rxslD80y5s8XhpeOBoh57vxMWaPrZuyLtlAFc4NR2JOUVm xV1lS0aNOObI3CIAryJzLqhX5rpb6BNRTa9h5kOGCQVWp/O1Zw5KrnuFiVgAaU1/yqc8Tilzi ZjitIMZh8C3O9/yYrZAGVB8JbEboGpaFvJSEGVet0f7NDWbdWT+kMRtDBdmU+iTWcFcHNvjSQ Jz57K+pIFLGN1drvovrf3hdxeidL81+U+SYDDQm7UT4xOviAZUpuOlgU0xmOEEC1wgY1Trx1e 3UCyOX25NIiHwtWmuHVIWyn5OfUJBgY1CwzbMlmHD0zjdhxJ+gE5HZ60CQRmo7W05xwr7WolI F/cqXJ1yQ12p+6yXXNsR328xmNL95Iov+SrC82YhJMU+CrA9b7VMAPHDtEPMYTht+ZaFHDTbH kRsldOx X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) O. emacs -Q 1. Open a man page that has a link on a hyphenated word, e.g. on my system: M-x man RET signal RET, put point on the word spanning lines 129-130, which is displayed as `sig- nalfd(2)'. 2. Type RET (or click mouse-1 or mouse-2) on that link. =3D> The error message "Can=E2=80=99t find the 2 sig-nalfd manpage" is disp= layed. The following patch makes the link DTRT: diff --git a/lisp/man.el b/lisp/man.el index 5acf90b..5d4cacc 100644 --- a/lisp/man.el +++ b/lisp/man.el @@ -1430,8 +1430,14 @@ Man-bgproc-sentinel (quit-restore-window (get-buffer-window (current-buffer) t) 'kill) (kill-buffer (current-buffer))) - (message "Can't find the %s manpage" - (Man-page-from-arguments args))) + ;; Entries hyphenated due to the window width + ;; won't be found in the man database, so remove + ;; the hyphenation and look again. + (if (string-match "-" args) + (let ((str (replace-match "" nil nil args))) + (Man-getpage-in-background str)) + (message "Can't find the %s manpage" + (Man-page-from-arguments args)))) =20 (if Man-fontify-manpage-flag (message "%s man page formatted" This is a long-standing bug (presumably since commit 162a12b1d7b1e985a8810bad24d068c825286f56 of Sep 13 2007), but although the fix seems safe, I suppose it's too late for emacs-25. So if there are no objections, should I commit it to master, or is it ok for the upcoming release? In GNU Emacs 25.1.50.19 (x86_64-suse-linux-gnu, GTK+ Version 3.14.15) of 2016-05-28 built on rosalinde Repository revision: 4ef0fc192b8a10625053dbb9376c814e68612eb6 Windowing system distributor 'The X.Org Foundation', version 11.0.11601000 System Description: openSUSE 13.2 (Harlequin) (x86_64) Configured using: 'configure --with-xwidgets 'CFLAGS=3D-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND DBUS GCONF GSETTINGS NOTIFY GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XWIDGETS Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix ------------=_1465125542-25696-1--