GNU bug report logs - #23640
25.1.50; Getting rid of compiler warnings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ken Brown <kbrown <at> cornell.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#23640: closed (25.1.50; Getting rid of compiler warnings)
Date: Tue, 31 May 2016 00:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 30 May 2016 20:11:53 -0400
with message-id <34f7bed1-d87c-1646-030f-bf589513d7a3 <at> cornell.edu>
and subject line Re: bug#23640: 25.1.50; Getting rid of compiler warnings
has caused the debbugs.gnu.org bug report #23640,
regarding 25.1.50; Getting rid of compiler warnings
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
23640: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=23640
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; Getting rid of compiler warnings
Date: Sat, 28 May 2016 14:40:36 -0400

Building master on Cygwin with gcc-5.3.0 yields many "control reaches
end of non-void function" warnings.  What's the best way to get rid of
these?  Should I add return statements that will never be reached, like
this?

--- a/src/frame.c
+++ b/src/frame.c
@@ -263,6 +263,8 @@ See also `frame-live-p'.  */)
       return Qns;
     default:
       emacs_abort ();
+      /* Pacify compiler.  */
+      return Qnil;
     }
 }

Ken

[Message part 3 (message/rfc822, inline)]

From: Ken Brown <kbrown <at> cornell.edu>
To: Paul Eggert <eggert <at> cs.ucla.edu>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 23640-done <at> debbugs.gnu.org, Andy Moreton <andrewjmoreton <at> gmail.com>
Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings
Date: Mon, 30 May 2016 20:11:53 -0400

On 5/30/2016 7:29 PM, Paul Eggert wrote:
> The tradition of hijacking the symbol 'lint' for GCC purposes has been
> used for many years in several GNU packages. As the problem you mention
> affects only optionally-generated warnings on non-GNU platforms, I
> suspect nobody has cared until now about the issue. Anyway, I changed
> Emacs master to use the symbol GCC_LINT instead; this should avoid the
> collision in names.

Thanks.  Closing.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.