From unknown Fri Jun 20 07:18:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23640 <23640@debbugs.gnu.org> To: bug#23640 <23640@debbugs.gnu.org> Subject: Status: 25.1.50; Getting rid of compiler warnings Reply-To: bug#23640 <23640@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:18:26 +0000 retitle 23640 25.1.50; Getting rid of compiler warnings reassign 23640 emacs submitter 23640 Ken Brown severity 23640 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 14:40:52 2016 Received: (at submit) by debbugs.gnu.org; 28 May 2016 18:40:52 +0000 Received: from localhost ([127.0.0.1]:45042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6jAK-0001nA-JV for submit@debbugs.gnu.org; Sat, 28 May 2016 14:40:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6jAI-0001my-M7 for submit@debbugs.gnu.org; Sat, 28 May 2016 14:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6jAC-00068b-Od for submit@debbugs.gnu.org; Sat, 28 May 2016 14:40:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6jAC-00068U-LZ for submit@debbugs.gnu.org; Sat, 28 May 2016 14:40:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6jAA-000129-In for bug-gnu-emacs@gnu.org; Sat, 28 May 2016 14:40:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6jA6-00066y-9l for bug-gnu-emacs@gnu.org; Sat, 28 May 2016 14:40:41 -0400 Received: from limerock03.mail.cornell.edu ([128.84.13.243]:49720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6jA6-00066u-5B for bug-gnu-emacs@gnu.org; Sat, 28 May 2016 14:40:38 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4SIebSf007699 for ; Sat, 28 May 2016 14:40:37 -0400 Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4SIeaXD024319 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Sat, 28 May 2016 14:40:37 -0400 To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Getting rid of compiler warnings From: Ken Brown Message-ID: Date: Sat, 28 May 2016 14:40:36 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Building master on Cygwin with gcc-5.3.0 yields many "control reaches end of non-void function" warnings. What's the best way to get rid of these? Should I add return statements that will never be reached, like this? --- a/src/frame.c +++ b/src/frame.c @@ -263,6 +263,8 @@ See also `frame-live-p'. */) return Qns; default: emacs_abort (); + /* Pacify compiler. */ + return Qnil; } } Ken From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 14:57:38 2016 Received: (at 23640) by debbugs.gnu.org; 28 May 2016 18:57:38 +0000 Received: from localhost ([127.0.0.1]:45049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6jQY-0002A1-2r for submit@debbugs.gnu.org; Sat, 28 May 2016 14:57:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6jQW-00029o-Mt for 23640@debbugs.gnu.org; Sat, 28 May 2016 14:57:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6jQO-0000pS-UR for 23640@debbugs.gnu.org; Sat, 28 May 2016 14:57:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6jQO-0000pH-Rc; Sat, 28 May 2016 14:57:28 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2597 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b6jQM-0006iR-JT; Sat, 28 May 2016 14:57:27 -0400 Date: Sat, 28 May 2016 21:57:29 +0300 Message-Id: <83mvnaxb6u.fsf@gnu.org> From: Eli Zaretskii To: Ken Brown In-reply-to: (message from Ken Brown on Sat, 28 May 2016 14:40:36 -0400) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Ken Brown > Date: Sat, 28 May 2016 14:40:36 -0400 > > Building master on Cygwin with gcc-5.3.0 yields many "control reaches > end of non-void function" warnings. What's the best way to get rid of > these? Should I add return statements that will never be reached, like > this? > > --- a/src/frame.c > +++ b/src/frame.c > @@ -263,6 +263,8 @@ See also `frame-live-p'. */) > return Qns; > default: > emacs_abort (); > + /* Pacify compiler. */ > + return Qnil; > } > } emacs_abort is declared with _Noreturn, so how come GCC doesn't shut up about "unreachable" code? FWIW, I'm building master with GCC 5.3.0, and don't see these warnings. From debbugs-submit-bounces@debbugs.gnu.org Sat May 28 17:48:08 2016 Received: (at 23640) by debbugs.gnu.org; 28 May 2016 21:48:08 +0000 Received: from localhost ([127.0.0.1]:45087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6m5U-000677-0W for submit@debbugs.gnu.org; Sat, 28 May 2016 17:48:08 -0400 Received: from limerock01.mail.cornell.edu ([128.84.13.241]:51209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b6m5S-00066d-Ng for 23640@debbugs.gnu.org; Sat, 28 May 2016 17:48:03 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4SLlsP0026716; Sat, 28 May 2016 17:47:55 -0400 Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4SLlquY028814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 28 May 2016 17:47:54 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> From: Ken Brown Message-ID: <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> Date: Sat, 28 May 2016 17:47:53 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <83mvnaxb6u.fsf@gnu.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/28/2016 2:57 PM, Eli Zaretskii wrote: >> From: Ken Brown >> Date: Sat, 28 May 2016 14:40:36 -0400 >> >> Building master on Cygwin with gcc-5.3.0 yields many "control reaches >> end of non-void function" warnings. What's the best way to get rid of >> these? Should I add return statements that will never be reached, like >> this? >> >> --- a/src/frame.c >> +++ b/src/frame.c >> @@ -263,6 +263,8 @@ See also `frame-live-p'. */) >> return Qns; >> default: >> emacs_abort (); >> + /* Pacify compiler. */ >> + return Qnil; >> } >> } > > emacs_abort is declared with _Noreturn, so how come GCC doesn't shut > up about "unreachable" code? It looks like the problem is the definition of _Noreturn as a macro in config.h. I'll have to figure out what's going on. Ken From debbugs-submit-bounces@debbugs.gnu.org Sun May 29 18:44:00 2016 Received: (at 23640) by debbugs.gnu.org; 29 May 2016 22:44:00 +0000 Received: from localhost ([127.0.0.1]:46691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79R9-0006Ny-Tn for submit@debbugs.gnu.org; Sun, 29 May 2016 18:44:00 -0400 Received: from limerock03.mail.cornell.edu ([128.84.13.243]:60711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b79R8-0006Nk-Ay for 23640@debbugs.gnu.org; Sun, 29 May 2016 18:43:58 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock03.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4TMhq2N002067; Sun, 29 May 2016 18:43:52 -0400 Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4TMhoCe022778 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sun, 29 May 2016 18:43:51 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> From: Ken Brown Message-ID: Date: Sun, 29 May 2016 18:43:48 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/28/2016 5:47 PM, Ken Brown wrote: > On 5/28/2016 2:57 PM, Eli Zaretskii wrote: >> emacs_abort is declared with _Noreturn, so how come GCC doesn't shut >> up about "unreachable" code? > > It looks like the problem is the definition of _Noreturn as a macro in > config.h. I'll have to figure out what's going on. That guess was wrong. The problem turns out to be that lint is defined in config.h. When lint is defined, Cygwin's defines _Noreturn to be a macro with empty expansion. I've raised the question on the Cygwin list (https://www.cygwin.com/ml/cygwin/2016-05/msg00374.html) as to whether that's a bug. Ken From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 07:40:08 2016 Received: (at 23640) by debbugs.gnu.org; 30 May 2016 11:40:09 +0000 Received: from localhost ([127.0.0.1]:46893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7LYC-0002OY-Eh for submit@debbugs.gnu.org; Mon, 30 May 2016 07:40:08 -0400 Received: from limerock04.mail.cornell.edu ([128.84.13.244]:32894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7LYA-0002O0-Uv for 23640@debbugs.gnu.org; Mon, 30 May 2016 07:40:03 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4UBdn7f006832; Mon, 30 May 2016 07:39:49 -0400 Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4UBdl2P025724 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 May 2016 07:39:48 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> From: Ken Brown Message-ID: <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> Date: Mon, 30 May 2016 07:39:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Paul Eggert , Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/29/2016 6:43 PM, Ken Brown wrote: > On 5/28/2016 5:47 PM, Ken Brown wrote: >> On 5/28/2016 2:57 PM, Eli Zaretskii wrote: >>> emacs_abort is declared with _Noreturn, so how come GCC doesn't shut >>> up about "unreachable" code? >> >> It looks like the problem is the definition of _Noreturn as a macro in >> config.h. I'll have to figure out what's going on. > > That guess was wrong. The problem turns out to be that lint is defined > in config.h. When lint is defined, Cygwin's defines > _Noreturn to be a macro with empty expansion. I've raised the question > on the Cygwin list > (https://www.cygwin.com/ml/cygwin/2016-05/msg00374.html) as to whether > that's a bug. The answer is that the Cygwin's is taken from FreeBSD, so the problem will exist there too. (I just checked the FreeBSD git repo and confirmed that the code in question is still there.) So it looks like defining lint should be disabled on Cygwin and FreeBSD, at least. Or maybe it should only be enabled on platforms where it's known that it doesn't cause problems. Paul, you're the one who introduced this. What do you think? Ken From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 10:42:07 2016 Received: (at 23640) by debbugs.gnu.org; 30 May 2016 14:42:07 +0000 Received: from localhost ([127.0.0.1]:47704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7OON-0006kH-Hx for submit@debbugs.gnu.org; Mon, 30 May 2016 10:42:07 -0400 Received: from limerock04.mail.cornell.edu ([128.84.13.244]:37103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7OOL-0006jm-9M for 23640@debbugs.gnu.org; Mon, 30 May 2016 10:42:06 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4UEfvjD002156; Mon, 30 May 2016 10:41:57 -0400 Received: from [192.168.1.5] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4UEfte6010654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 May 2016 10:41:56 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> From: Ken Brown Message-ID: Date: Mon, 30 May 2016 10:41:55 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Paul Eggert , Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/30/2016 7:39 AM, Ken Brown wrote: > On 5/29/2016 6:43 PM, Ken Brown wrote: >> On 5/28/2016 5:47 PM, Ken Brown wrote: >>> On 5/28/2016 2:57 PM, Eli Zaretskii wrote: >>>> emacs_abort is declared with _Noreturn, so how come GCC doesn't shut >>>> up about "unreachable" code? >>> >>> It looks like the problem is the definition of _Noreturn as a macro in >>> config.h. I'll have to figure out what's going on. >> >> That guess was wrong. The problem turns out to be that lint is defined >> in config.h. When lint is defined, Cygwin's defines >> _Noreturn to be a macro with empty expansion. I've raised the question >> on the Cygwin list >> (https://www.cygwin.com/ml/cygwin/2016-05/msg00374.html) as to whether >> that's a bug. > > The answer is that the Cygwin's is taken from FreeBSD, so > the problem will exist there too. (I just checked the FreeBSD git repo > and confirmed that the code in question is still there.) So it looks > like defining lint should be disabled on Cygwin and FreeBSD, at least. > Or maybe it should only be enabled on platforms where it's known that it > doesn't cause problems. > > Paul, you're the one who introduced this. What do you think? Another glitch: Removing the line in configure.ac that defines lint results in lots of 'may be used uninitialized' warnings. That's because the IF_LINT macro now suppresses all the initializations that were previously added to avoid these warnings. Question: Why bother with IF_LINT at all? Why not just unconditionally initialize the variables that gcc complains about? Ken From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 12:20:37 2016 Received: (at 23640) by debbugs.gnu.org; 30 May 2016 16:20:38 +0000 Received: from localhost ([127.0.0.1]:47752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Pvh-0000gz-NB for submit@debbugs.gnu.org; Mon, 30 May 2016 12:20:37 -0400 Received: from limerock04.mail.cornell.edu ([128.84.13.244]:40432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Pvf-0000gl-32 for 23640@debbugs.gnu.org; Mon, 30 May 2016 12:20:36 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4UGKQNs018150; Mon, 30 May 2016 12:20:27 -0400 Received: from [192.168.1.5] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4UGKOdW028919 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 May 2016 12:20:25 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> From: Ken Brown Message-ID: <0ff3a5dd-91e3-f455-0b17-88e6ba2c6802@cornell.edu> Date: Mon, 30 May 2016 12:20:24 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Paul Eggert , Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/30/2016 10:41 AM, Ken Brown wrote: > Question: Why bother with IF_LINT at all? Why not just unconditionally > initialize the variables that gcc complains about? If keeping IF_LINT is important, we could do something like this: diff --git a/configure.ac b/configure.ac index e88a3a9..f628c9a 100644 --- a/configure.ac +++ b/configure.ac @@ -997,7 +997,14 @@ AC_DEFUN gl_WARN_ADD([-Wno-pointer-sign]) fi - AC_DEFINE([lint], [1], [Define to 1 if the compiler is checking for lint.]) + case $opsys in + cygwin | freebsd) + AC_DEFINE([gcc_warnings], [1], [Define to 1 if gcc warnings are enabled.]) + ;; + *) + AC_DEFINE([lint], [1], [Define to 1 if the compiler is checking for lint.]) + ;; + esac AC_DEFINE([GNULIB_PORTCHECK], [1], [enable some gnulib portability checks]) AH_VERBATIM([GNULIB_PORTCHECK_FORTIFY_SOURCE], [/* Enable compile-time and run-time bounds-checking, and some warnings, diff --git a/src/conf_post.h b/src/conf_post.h index 5d3394f..987bcad 100644 --- a/src/conf_post.h +++ b/src/conf_post.h @@ -344,7 +344,7 @@ extern int emacs_setenv_TZ (char const *); #endif /* Use this to suppress gcc's `...may be used before initialized' warnings. */ -#ifdef lint +#if defined lint || defined gcc_warnings /* Use CODE only if lint checking is in effect. */ # define IF_LINT(Code) Code #else From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 19:29:26 2016 Received: (at 23640) by debbugs.gnu.org; 30 May 2016 23:29:26 +0000 Received: from localhost ([127.0.0.1]:47888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Wcg-0004PV-0W for submit@debbugs.gnu.org; Mon, 30 May 2016 19:29:26 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Wcd-0004PG-MQ for 23640@debbugs.gnu.org; Mon, 30 May 2016 19:29:24 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id CFAED161385; Mon, 30 May 2016 16:29:16 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Cr0mMur-HsmQ; Mon, 30 May 2016 16:29:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E11EB1613EA; Mon, 30 May 2016 16:29:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 70RQ50j98DM0; Mon, 30 May 2016 16:29:15 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BE6F0161385; Mon, 30 May 2016 16:29:15 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Ken Brown , Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <574CCCCB.7000209@cs.ucla.edu> Date: Mon, 30 May 2016 16:29:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Ken Brown wrote: > Why not just unconditionally initialize the variables that gcc complain= s about? That could make the code harder to understand. Someone who sees "int i =3D= 0;" can=20 reasonably infer that the 0 is needed, i.e., that a later part of the cod= e needs=20 the 0. Someone who sees "int i IF_LINT (=3D 0);" should be under no such = illusion. The tradition of hijacking the symbol 'lint' for GCC purposes has been us= ed for=20 many years in several GNU packages. As the problem you mention affects on= ly=20 optionally-generated warnings on non-GNU platforms, I suspect nobody has = cared=20 until now about the issue. Anyway, I changed Emacs master to use the symb= ol=20 GCC_LINT instead; this should avoid the collision in names. Please give i= t a try. The FreeBSD and Cygwin uses of 'lint' violate the C Standard. For example= : #define lint 1 #include _Noreturn int x; This program violates a constraint so the C Standard requires a compile-t= ime=20 diagnostic, but from what you say on FreeBSD and Cygwin the compiler misb= ehaves=20 and silently ignores the _Noreturn. I see that HBBroeker is independently= making=20 a similar point on the Cygwin mailing list=20 . From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 20:12:10 2016 Received: (at 23640-done) by debbugs.gnu.org; 31 May 2016 00:12:10 +0000 Received: from localhost ([127.0.0.1]:47905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XI2-0005Pa-3b for submit@debbugs.gnu.org; Mon, 30 May 2016 20:12:10 -0400 Received: from limerock02.mail.cornell.edu ([128.84.13.242]:41476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XI0-0005PF-Df for 23640-done@debbugs.gnu.org; Mon, 30 May 2016 20:12:08 -0400 X-CornellRouted: This message has been Routed already. Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u4V0BtgE001711; Mon, 30 May 2016 20:11:55 -0400 Received: from [192.168.1.3] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id u4V0Bshp011198 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 30 May 2016 20:11:54 -0400 Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Paul Eggert , Eli Zaretskii References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> <574CCCCB.7000209@cs.ucla.edu> From: Ken Brown Message-ID: <34f7bed1-d87c-1646-030f-bf589513d7a3@cornell.edu> Date: Mon, 30 May 2016 20:11:53 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <574CCCCB.7000209@cs.ucla.edu> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-PMX-Cornell-Gauge: Gauge=XXXXX X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 23640-done Cc: 23640-done@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.7 (---) On 5/30/2016 7:29 PM, Paul Eggert wrote: > The tradition of hijacking the symbol 'lint' for GCC purposes has been > used for many years in several GNU packages. As the problem you mention > affects only optionally-generated warnings on non-GNU platforms, I > suspect nobody has cared until now about the issue. Anyway, I changed > Emacs master to use the symbol GCC_LINT instead; this should avoid the > collision in names. Thanks. Closing. Ken From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 20:15:21 2016 Received: (at 23640) by debbugs.gnu.org; 31 May 2016 00:15:21 +0000 Received: from localhost ([127.0.0.1]:47912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XL7-0005Uq-I8 for submit@debbugs.gnu.org; Mon, 30 May 2016 20:15:21 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:33162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7XL6-0005Ud-1J for 23640@debbugs.gnu.org; Mon, 30 May 2016 20:15:20 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1CF211613D0; Mon, 30 May 2016 17:15:14 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xY43KH4drJLB; Mon, 30 May 2016 17:15:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1B1B21613D1; Mon, 30 May 2016 17:15:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 3F8BvZHdNvbK; Mon, 30 May 2016 17:15:13 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EE6111613D0; Mon, 30 May 2016 17:15:12 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: Ken Brown References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <574CD78E.4070401@cs.ucla.edu> Date: Mon, 30 May 2016 17:15:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Following up on the compatibility issue with 'lint' and '_Noreturn', I filed a FreeBSD bug report here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=209877 From debbugs-submit-bounces@debbugs.gnu.org Tue May 31 04:03:32 2016 Received: (at submit) by debbugs.gnu.org; 31 May 2016 08:03:32 +0000 Received: from localhost ([127.0.0.1]:48020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7eeB-0008AL-Og for submit@debbugs.gnu.org; Tue, 31 May 2016 04:03:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7ee9-0008A7-H3 for submit@debbugs.gnu.org; Tue, 31 May 2016 04:03:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7ee3-0007q6-9i for submit@debbugs.gnu.org; Tue, 31 May 2016 04:03:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7ee3-0007q1-7C for submit@debbugs.gnu.org; Tue, 31 May 2016 04:03:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50336) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7ee1-0002cC-QT for bug-gnu-emacs@gnu.org; Tue, 31 May 2016 04:03:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7edw-0007oQ-Ny for bug-gnu-emacs@gnu.org; Tue, 31 May 2016 04:03:20 -0400 Received: from plane.gmane.org ([80.91.229.3]:44428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7edw-0007oK-Gm for bug-gnu-emacs@gnu.org; Tue, 31 May 2016 04:03:16 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b7edt-00062O-OD for bug-gnu-emacs@gnu.org; Tue, 31 May 2016 10:03:13 +0200 Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 31 May 2016 10:03:13 +0200 Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 31 May 2016 10:03:13 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings Date: Tue, 31 May 2016 09:03:00 +0100 Lines: 35 Message-ID: <86bn3mbqob.fsf@gmail.com> References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> <574CCCCB.7000209@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (windows-nt) Cancel-Lock: sha1:uRc/fIcoiqxGidtRJ6zICsKC2s8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.9 (---) On Mon 30 May 2016, Paul Eggert wrote: > Ken Brown wrote: >> Why not just unconditionally initialize the variables that gcc complains about? > > That could make the code harder to understand. Someone who sees "int i = 0;" > can reasonably infer that the 0 is needed, i.e., that a later part of the code > needs the 0. Someone who sees "int i IF_LINT (= 0);" should be under no such > illusion. Surely this makes the code easier to understand, since "int i = 0;" immediately shows that the variable is always initialised, so there is no need to check that it is initialised before use on all code paths (and recheck after making any chages during maintenance). Given that the performance cost of this is likely to be unmeasurably small, the IF_LINT stuff is either unneccessary clutter, or hiding a latent bug. > The FreeBSD and Cygwin uses of 'lint' violate the C Standard. For example: > > #define lint 1 > #include > _Noreturn int x; > > This program violates a constraint so the C Standard requires a compile-time > diagnostic, but from what you say on FreeBSD and Cygwin the compiler > misbehaves and silently ignores the _Noreturn. I see that HBBroeker is > independently making a similar point on the Cygwin mailing list > . That may be so, but any codebase has to deal with the world as it is, not the ideal in one of the applicable standards. AndyM From debbugs-submit-bounces@debbugs.gnu.org Tue May 31 18:23:01 2016 Received: (at 23640) by debbugs.gnu.org; 31 May 2016 22:23:01 +0000 Received: from localhost ([127.0.0.1]:48824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7s3w-0000pG-Uq for submit@debbugs.gnu.org; Tue, 31 May 2016 18:23:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7s3v-0000p1-1t for 23640@debbugs.gnu.org; Tue, 31 May 2016 18:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7s3p-0003Ns-2T for 23640@debbugs.gnu.org; Tue, 31 May 2016 18:22:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57348) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7s3n-0003Lw-CH; Tue, 31 May 2016 18:22:51 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1b7s3l-0007V1-44; Tue, 31 May 2016 18:22:49 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Andy Moreton In-reply-to: <86bn3mbqob.fsf@gmail.com> (message from Andy Moreton on Tue, 31 May 2016 09:03:00 +0100) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <83mvnaxb6u.fsf@gnu.org> <13ba9f48-d461-5e4d-7017-20b3aec2b98c@cornell.edu> <7db1f3b9-4464-055a-626b-2a21ae7ddfa8@cornell.edu> <574CCCCB.7000209@cs.ucla.edu> <86bn3mbqob.fsf@gmail.com> Message-Id: Date: Tue, 31 May 2016 18:22:49 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] I don't think we should clutter up programs with IF_LINT. Instead, we could define a macro UNUSED with #define UNUSED 0 and write int i = UNUSED; -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 04:35:37 2016 Received: (at 23640) by debbugs.gnu.org; 1 Jun 2016 08:35:37 +0000 Received: from localhost ([127.0.0.1]:49066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b81cn-0002BP-A1 for submit@debbugs.gnu.org; Wed, 01 Jun 2016 04:35:37 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b81cl-0002BC-HG for 23640@debbugs.gnu.org; Wed, 01 Jun 2016 04:35:35 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D8B631613B6; Wed, 1 Jun 2016 01:35:29 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id EWFFfw1m35Ur; Wed, 1 Jun 2016 01:35:29 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2FDEB1613FF; Wed, 1 Jun 2016 01:35:29 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Mng1os53Mc3C; Wed, 1 Jun 2016 01:35:29 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0D6B51613B6; Wed, 1 Jun 2016 01:35:29 -0700 (PDT) To: Richard Stallman From: Paul Eggert Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings Organization: UCLA Computer Science Department Message-ID: <574E9E50.6040301@cs.ucla.edu> Date: Wed, 1 Jun 2016 01:35:28 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, Andy Moreton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > we could define a macro UNUSED with > > #define UNUSED 0 > > and write > > int i =3D UNUSED; This wouldn't be enough to handle other cases, e.g., 'IF_LINT (=3D Qnil)'= and=20 'IF_LINT (volatile)'. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 04:55:22 2016 Received: (at 23640) by debbugs.gnu.org; 1 Jun 2016 08:55:22 +0000 Received: from localhost ([127.0.0.1]:49072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b81vu-0002cN-1Z for submit@debbugs.gnu.org; Wed, 01 Jun 2016 04:55:22 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b81vs-0002cC-PE for 23640@debbugs.gnu.org; Wed, 01 Jun 2016 04:55:21 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 38E951613FF; Wed, 1 Jun 2016 01:55:15 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8kzXdqu5TalN; Wed, 1 Jun 2016 01:55:13 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D6081161406; Wed, 1 Jun 2016 01:55:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OD98UsIMj_Ho; Wed, 1 Jun 2016 01:55:13 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AE5C01613FF; Wed, 1 Jun 2016 01:55:13 -0700 (PDT) To: Andy Moreton From: Paul Eggert Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings Organization: UCLA Computer Science Department Message-ID: <574EA2F1.3070100@cs.ucla.edu> Date: Wed, 1 Jun 2016 01:55:13 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > Surely this makes the code easier to understand, since "int i =3D 0;" > immediately shows that the variable is always initialised That is a superficial form of understanding, one that could be satisfied = by=20 initializing all variables whether they need it or not. If instead we mak= e it=20 clear that the initialization is present only to work around a GCC defici= ency,=20 the reader will get a less-shallow understanding. > any codebase has to deal with the world as it is, > not the ideal in one of the applicable standards. Yes, and Emacs was changed to work around the Cygnus and FreeBSD glitches= ; see: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3Dcb379cbb7fc617f89= 7e7dbc3ce45bf99ea3d1f87 > the performance cost of this is likely to be unmeasurably small Yes, it's primarily about making the code clearer, not performance. GCC is gradually getting smarter in this area, and eventually I hope we c= an=20 remove more IF_LINT instances. I removed several instances recently; see: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D237244bbd5ce753bc= df79634561de515bd76c687 From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 16:38:04 2016 Received: (at 23640) by debbugs.gnu.org; 1 Jun 2016 20:38:04 +0000 Received: from localhost ([127.0.0.1]:50197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Ctw-0000Qx-0g for submit@debbugs.gnu.org; Wed, 01 Jun 2016 16:38:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8Ctu-0000QT-OJ for 23640@debbugs.gnu.org; Wed, 01 Jun 2016 16:38:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8Cto-00012X-Hk for 23640@debbugs.gnu.org; Wed, 01 Jun 2016 16:37:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8Ctl-0000zl-GA; Wed, 01 Jun 2016 16:37:53 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1b8Ctk-0008Ou-P9; Wed, 01 Jun 2016 16:37:52 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Paul Eggert In-reply-to: <574E9E50.6040301@cs.ucla.edu> (message from Paul Eggert on Wed, 1 Jun 2016 01:35:28 -0700) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <574E9E50.6040301@cs.ucla.edu> Message-Id: Date: Wed, 01 Jun 2016 16:37:52 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > This wouldn't be enough to handle other cases, e.g., 'IF_LINT (= Qnil)' and > 'IF_LINT (volatile)'. A macro UNUSED_LISP could handle the first. What is the reason for writing IF_LINT (volatile) instead of just volatile? -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 01 17:10:57 2016 Received: (at 23640) by debbugs.gnu.org; 1 Jun 2016 21:10:57 +0000 Received: from localhost ([127.0.0.1]:50205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8DPk-0001E3-Op for submit@debbugs.gnu.org; Wed, 01 Jun 2016 17:10:56 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:45172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8DPj-0001Dp-8x for 23640@debbugs.gnu.org; Wed, 01 Jun 2016 17:10:55 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7C8231613C6; Wed, 1 Jun 2016 14:10:49 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6rmEaGmYpMjm; Wed, 1 Jun 2016 14:10:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C97BD1613CC; Wed, 1 Jun 2016 14:10:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 83_nYLRGeFca; Wed, 1 Jun 2016 14:10:48 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AD7271613C6; Wed, 1 Jun 2016 14:10:48 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: rms@gnu.org References: <574E9E50.6040301@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> Date: Wed, 1 Jun 2016 14:10:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On 06/01/2016 01:37 PM, Richard Stallman wrote: > A macro UNUSED_LISP could handle the first. Yes, we could have separate macros for each data type requiring syntactically different initializers. Something like this, say: int n UNUSED_0; Lisp_Object obj UNUSED_Qnil; instead of the current: int n IF_LINT (= 0); Lisp_Object obj IF_LINT (= Qnil); We could easily change the code in that way. Is it worth the trouble? > What is the reason for writing IF_LINT (volatile) > instead of just volatile? Primarily, to tell the reader that the 'volatile' is not needed for correctness; it's present only to pacify a buggy compiler or lint checker. (In this case, it pacifies GCC; see GCC bug#54561.) It's basically the same reason the code uses 'IF_LINT (= 0)' rather than '= 0'. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 08:05:38 2016 Received: (at submit) by debbugs.gnu.org; 2 Jun 2016 12:05:38 +0000 Received: from localhost ([127.0.0.1]:50530 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8RNa-00005h-9v for submit@debbugs.gnu.org; Thu, 02 Jun 2016 08:05:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8RNY-00005U-Q7 for submit@debbugs.gnu.org; Thu, 02 Jun 2016 08:05:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8RNS-0007PI-Mb for submit@debbugs.gnu.org; Thu, 02 Jun 2016 08:05:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8RNS-0007Ny-JR for submit@debbugs.gnu.org; Thu, 02 Jun 2016 08:05:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8RNQ-0002Lo-EP for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 08:05:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8RNM-0007LO-6z for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 08:05:27 -0400 Received: from plane.gmane.org ([80.91.229.3]:50953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8RNM-0007L9-03 for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 08:05:24 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1b8RNK-0007h1-1n for bug-gnu-emacs@gnu.org; Thu, 02 Jun 2016 14:05:22 +0200 Received: from uk.solarflare.com ([193.34.186.16]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Jun 2016 14:05:22 +0200 Received: from andrewjmoreton by uk.solarflare.com with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 02 Jun 2016 14:05:22 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings Date: Thu, 02 Jun 2016 13:05:09 +0100 Lines: 31 Message-ID: References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: uk.solarflare.com User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.94 (windows-nt) Cancel-Lock: sha1:Xn04tS1jS0nrPpIBjuNlyT8Z9ZE= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.9 (---) On Wed 01 Jun 2016, Paul Eggert wrote: > On 06/01/2016 01:37 PM, Richard Stallman wrote: >> A macro UNUSED_LISP could handle the first. > > Yes, we could have separate macros for each data type requiring syntactically > different initializers. Something like this, say: > > int n UNUSED_0; > Lisp_Object obj UNUSED_Qnil; > > instead of the current: > > int n IF_LINT (= 0); > Lisp_Object obj IF_LINT (= Qnil); > > We could easily change the code in that way. Is it worth the trouble? > >> What is the reason for writing IF_LINT (volatile) >> instead of just volatile? > > Primarily, to tell the reader that the 'volatile' is not needed for > correctness; it's present only to pacify a buggy compiler or lint checker. (In > this case, it pacifies GCC; see GCC bug#54561.) It's basically the same reason > the code uses 'IF_LINT (= 0)' rather than '= 0'. Adding more macros that cruft up the source code to deal with a buggy compiler warning is silly. If the warning is broken and does not operate correctly, then do not enable that warning. AndyM From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 02 23:36:02 2016 Received: (at 23640) by debbugs.gnu.org; 3 Jun 2016 03:36:02 +0000 Received: from localhost ([127.0.0.1]:52225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8fty-0002wL-08 for submit@debbugs.gnu.org; Thu, 02 Jun 2016 23:36:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57189) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b8ftw-0002w2-L5 for 23640@debbugs.gnu.org; Thu, 02 Jun 2016 23:36:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8ftq-0004f1-HU for 23640@debbugs.gnu.org; Thu, 02 Jun 2016 23:35:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8ftn-0004eA-Ej; Thu, 02 Jun 2016 23:35:51 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1b8ftl-0001If-Oo; Thu, 02 Jun 2016 23:35:49 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Paul Eggert In-reply-to: <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> (message from Paul Eggert on Wed, 1 Jun 2016 14:10:48 -0700) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> Message-Id: Date: Thu, 02 Jun 2016 23:35:49 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > Yes, we could have separate macros for each data type requiring > syntactically different initializers. Something like this, say: > int n UNUSED_0; > Lisp_Object obj UNUSED_Qnil; Actually, one single macro UNUSED will work for integers and Lisp_Object: #define UNUSED = {0} int n UNUSED; Lisp_Object obj UNUSED; -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 10:45:10 2016 Received: (at 23640) by debbugs.gnu.org; 6 Jun 2016 14:45:10 +0000 Received: from localhost ([127.0.0.1]:56882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9vmA-00084f-4P for submit@debbugs.gnu.org; Mon, 06 Jun 2016 10:45:10 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9vm7-000841-Gx for 23640@debbugs.gnu.org; Mon, 06 Jun 2016 10:45:08 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AD0A31613EC; Mon, 6 Jun 2016 07:45:01 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id E33A6b1idXJ8; Mon, 6 Jun 2016 07:45:01 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F399F1613F8; Mon, 6 Jun 2016 07:45:00 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aXnzv9OxIdKw; Mon, 6 Jun 2016 07:45:00 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D436F1613EC; Mon, 6 Jun 2016 07:45:00 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: rms@gnu.org References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Mon, 6 Jun 2016 07:45:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------DE3B07DC467DC9434A54F0DD" X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) This is a multi-part message in MIME format. --------------DE3B07DC467DC9434A54F0DD Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 06/02/2016 08:35 PM, Richard Stallman wrote: > one single macro UNUSED will work for integers and Lisp_Object Yes, that works, though UNUSED is a confusing name to attach to a variable, as the variable is actually used. A better name is UNINIT, indicating that the variable is uninitialized. Similarly, NONVOLATILE could indicate that a variable is not volatile, in cases where GCC would otherwise complain. The attached patch would suffice to omit all uses of the IF_LINT macro in the Emacs source, if that's a style you prefer. --------------DE3B07DC467DC9434A54F0DD Content-Type: application/x-patch; name="0001-Replace-IF_LINT-by-NONVOLATILE-and-UNINIT.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Replace-IF_LINT-by-NONVOLATILE-and-UNINIT.patch" RnJvbSA3ZWI5NjI5OTZhYTI2YzRiYmM5OWQ3OThlYjdhNWFkZjE5NDlmM2VkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDYgSnVuIDIwMTYgMDc6NDA6MTYgLTA3MDAKU3ViamVjdDogW1BBVENI XSBSZXBsYWNlIElGX0xJTlQgYnkgTk9OVk9MQVRJTEUgYW5kIFVOSU5JVAoKKiAuZGlyLWxv Y2Fscy5lbCAoYy1tb2RlKTogQWRqdXN0IHRvIG1hY3JvIGNoYW5nZXMuCiogc3JjL2NvbmZf cG9zdC5oIChOT05WT0xBVElMRSwgVU5JTklUKTogTmV3IG1hY3JvcyAoQnVnIzIzNjQwKS4K KElGX0xJTlQpOiBSZW1vdmUuICBBbGwgdXNlcyByZXBsYWNlZCBieSB0aGUgbmV3IG1hY3Jv cy4KLS0tCiAuZGlyLWxvY2Fscy5lbCAgICAgICAgIHwgIDIgKy0KIGxpYi1zcmMvbWFrZS1k b2NmaWxlLmMgfCAgMiArLQogc3JjL2J1ZmZlci5jICAgICAgICAgICB8ICAyICstCiBzcmMv Y2hhcnNldC5jICAgICAgICAgIHwgIDIgKy0KIHNyYy9jbS5jICAgICAgICAgICAgICAgfCAg MiArLQogc3JjL2NvZGluZy5jICAgICAgICAgICB8ICA5ICsrKysrLS0tLQogc3JjL2NvbXBv c2l0ZS5jICAgICAgICB8ICAzICsrLQogc3JjL2NvbmZfcG9zdC5oICAgICAgICB8IDE2ICsr KysrKysrKysrKystLS0KIHNyYy9lZGl0Zm5zLmMgICAgICAgICAgfCAgNCArKy0tCiBzcmMv ZmlsZWlvLmMgICAgICAgICAgIHwgIDQgKystLQogc3JjL2ZvbnQuYyAgICAgICAgICAgICB8 ICAzICsrLQogc3JjL2ZvbnRzZXQuYyAgICAgICAgICB8ICAzICsrLQogc3JjL2ZyaW5nZS5j ICAgICAgICAgICB8ICAyICstCiBzcmMvZ3RrdXRpbC5jICAgICAgICAgIHwgIDMgKystCiBz cmMvaW1hZ2UuYyAgICAgICAgICAgIHwgMTEgKysrKystLS0tLS0KIHNyYy9pbmRlbnQuYyAg ICAgICAgICAgfCAgNiArKystLS0KIHNyYy9rZXlib2FyZC5jICAgICAgICAgfCAxMCArKysr LS0tLS0tCiBzcmMvbHJlYWQuYyAgICAgICAgICAgIHwgIDkgKystLS0tLS0tCiBzcmMvbWlu aWJ1Zi5jICAgICAgICAgIHwgIDIgKy0KIHNyYy9wcmludC5jICAgICAgICAgICAgfCAgMiAr LQogc3JjL3JlZ2V4LmMgICAgICAgICAgICB8ICAyICstCiBzcmMvc3ludGF4LmMgICAgICAg ICAgIHwgIDIgKy0KIHNyYy90ZXJtLmMgICAgICAgICAgICAgfCAgOCArKysrLS0tLQogc3Jj L3dpbmRvdy5jICAgICAgICAgICB8ICA4ICsrKysrLS0tCiBzcmMveGRpc3AuYyAgICAgICAg ICAgIHwgMzAgKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tCiBzcmMveGZvbnQuYyAg ICAgICAgICAgIHwgIDIgKy0KIDI2IGZpbGVzIGNoYW5nZWQsIDc5IGluc2VydGlvbnMoKyks IDcwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhLy5kaXItbG9jYWxzLmVsIGIvLmRpci1s b2NhbHMuZWwKaW5kZXggN2MxNDgwMi4uOTdlNTE4MCAxMDA2NDQKLS0tIGEvLmRpci1sb2Nh bHMuZWwKKysrIGIvLmRpci1sb2NhbHMuZWwKQEAgLTIsNyArMiw3IEBACiAgICAgICAgICAo c2VudGVuY2UtZW5kLWRvdWJsZS1zcGFjZSAuIHQpCiAgICAgICAgICAoZmlsbC1jb2x1bW4g LiA3MCkpKQogIChjLW1vZGUgLiAoKGMtZmlsZS1zdHlsZSAuICJHTlUiKQotICAgICAgICAg ICAgKGMtbm9pc2UtbWFjcm8td2l0aC1wYXJlbnMtbmFtZXMgLiAoIklGX0xJTlQiKSkpKQor ICAgICAgICAgICAgKGMtbm9pc2UtbWFjcm8tbmFtZXMgLiAoIk5PTlZPTEFUSUxFIiAiVU5J TklUIikpKSkKICAob2JqYy1tb2RlIC4gKChjLWZpbGUtc3R5bGUgLiAiR05VIikpKQogIChs b2ctZWRpdC1tb2RlIC4gKChsb2ctZWRpdC1mb250LWxvY2stZ251LXN0eWxlIC4gdCkKICAg ICAgICAgICAgICAgICAgICAobG9nLWVkaXQtc2V0dXAtYWRkLWF1dGhvciAuIHQpKSkKZGlm ZiAtLWdpdCBhL2xpYi1zcmMvbWFrZS1kb2NmaWxlLmMgYi9saWItc3JjL21ha2UtZG9jZmls ZS5jCmluZGV4IDMyZTM4MTcuLmY0NjNmMTMgMTAwNjQ0Ci0tLSBhL2xpYi1zcmMvbWFrZS1k b2NmaWxlLmMKKysrIGIvbGliLXNyYy9tYWtlLWRvY2ZpbGUuYwpAQCAtNDkxLDcgKzQ5MSw3 IEBAIHdyaXRlX2NfYXJncyAoY2hhciAqZnVuYywgY2hhciAqYnVmLCBpbnQgbWluYXJncywg aW50IG1heGFyZ3MpCiB7CiAgIGNoYXIgKnA7CiAgIGJvb2wgaW5faWRlbnQgPSBmYWxzZTsK LSAgY2hhciAqaWRlbnRfc3RhcnQgSUZfTElOVCAoPSBOVUxMKTsKKyAgY2hhciAqaWRlbnRf c3RhcnQgVU5JTklUOwogICBwdHJkaWZmX3QgaWRlbnRfbGVuZ3RoID0gMDsKIAogICBmcHV0 cyAoIihmbiIsIHN0ZG91dCk7CmRpZmYgLS1naXQgYS9zcmMvYnVmZmVyLmMgYi9zcmMvYnVm ZmVyLmMKaW5kZXggNTM0YjllNC4uNzA5N2M2ZCAxMDA2NDQKLS0tIGEvc3JjL2J1ZmZlci5j CisrKyBiL3NyYy9idWZmZXIuYwpAQCAtMzkwNyw3ICszOTA3LDcgQEAgYnVmZmVyLiAgKi8p CiAgIHN0cnVjdCBidWZmZXIgKmIsICpvYiA9IDA7CiAgIExpc3BfT2JqZWN0IG9idWZmZXI7 CiAgIHB0cmRpZmZfdCBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7Ci0gIHB0cmRpZmZfdCBu X2JlZywgbl9lbmQsIG9fYmVnIElGX0xJTlQgKD0gMCksIG9fZW5kIElGX0xJTlQgKD0gMCk7 CisgIHB0cmRpZmZfdCBuX2JlZywgbl9lbmQsIG9fYmVnIFVOSU5JVCwgb19lbmQgVU5JTklU OwogCiAgIENIRUNLX09WRVJMQVkgKG92ZXJsYXkpOwogICBpZiAoTklMUCAoYnVmZmVyKSkK ZGlmZiAtLWdpdCBhL3NyYy9jaGFyc2V0LmMgYi9zcmMvY2hhcnNldC5jCmluZGV4IDFhMTM1 ODQuLjZiZTk0MzQgMTAwNjQ0Ci0tLSBhL3NyYy9jaGFyc2V0LmMKKysrIGIvc3JjL2NoYXJz ZXQuYwpAQCAtMjQwLDcgKzI0MCw3IEBAIHN0cnVjdCBjaGFyc2V0X21hcF9lbnRyaWVzCiBz dGF0aWMgdm9pZAogbG9hZF9jaGFyc2V0X21hcCAoc3RydWN0IGNoYXJzZXQgKmNoYXJzZXQs IHN0cnVjdCBjaGFyc2V0X21hcF9lbnRyaWVzICplbnRyaWVzLCBpbnQgbl9lbnRyaWVzLCBp bnQgY29udHJvbF9mbGFnKQogewotICBMaXNwX09iamVjdCB2ZWMsIHRhYmxlIElGX0xJTlQg KD0gUW5pbCk7CisgIExpc3BfT2JqZWN0IHZlYywgdGFibGUgVU5JTklUOwogICB1bnNpZ25l ZCBtYXhfY29kZSA9IENIQVJTRVRfTUFYX0NPREUgKGNoYXJzZXQpOwogICBib29sIGFzY2lp X2NvbXBhdGlibGVfcCA9IGNoYXJzZXQtPmFzY2lpX2NvbXBhdGlibGVfcDsKICAgaW50IG1p bl9jaGFyLCBtYXhfY2hhciwgbm9uYXNjaWlfbWluX2NoYXI7CmRpZmYgLS1naXQgYS9zcmMv Y20uYyBiL3NyYy9jbS5jCmluZGV4IDRmOTRjMDcuLmUxMzU4ODkgMTAwNjQ0Ci0tLSBhL3Ny Yy9jbS5jCisrKyBiL3NyYy9jbS5jCkBAIC0zMjEsNyArMzIxLDcgQEAgY21nb3RvIChzdHJ1 Y3QgdHR5X2Rpc3BsYXlfaW5mbyAqdHR5LCBpbnQgcm93LCBpbnQgY29sKQogICAgICAgICAg ICAgbGxjb3N0LAogICAgICAgICAgICAgcmVsY29zdCwKICAgICAgICAgICAgIGRpcmVjdGNv c3Q7Ci0gICAgaW50ICAgICB1c2UgSUZfTElOVCAoPSAwKTsKKyAgICBpbnQgdXNlIFVOSU5J VDsKICAgICBjaGFyICpwOwogICAgIGNvbnN0IGNoYXIgKmRjbTsKIApkaWZmIC0tZ2l0IGEv c3JjL2NvZGluZy5jIGIvc3JjL2NvZGluZy5jCmluZGV4IGEyOGZlYzEuLjNmN2QxMTEgMTAw NjQ0Ci0tLSBhL3NyYy9jb2RpbmcuYworKysgYi9zcmMvY29kaW5nLmMKQEAgLTIzNjUsNyAr MjM2NSw4IEBAIGRlY29kZV9jb2RpbmdfZW1hY3NfbXVsZSAoc3RydWN0IGNvZGluZ19zeXN0 ZW0gKmNvZGluZykKIAogICB3aGlsZSAoMSkKICAgICB7Ci0gICAgICBpbnQgYywgaWQgSUZf TElOVCAoPSAwKTsKKyAgICAgIGludCBjOworICAgICAgaW50IGlkIFVOSU5JVDsKIAogICAg ICAgc3JjX2Jhc2UgPSBzcmM7CiAgICAgICBjb25zdW1lZF9jaGFyc19iYXNlID0gY29uc3Vt ZWRfY2hhcnM7CkBAIC0yNDEwLDcgKzI0MTEsNyBAQCBkZWNvZGVfY29kaW5nX2VtYWNzX211 bGUgKHN0cnVjdCBjb2Rpbmdfc3lzdGVtICpjb2RpbmcpCiAJfQogICAgICAgZWxzZQogCXsK LQkgIGludCBuY2hhcnMgSUZfTElOVCAoPSAwKSwgbmJ5dGVzIElGX0xJTlQgKD0gMCk7CisJ ICBpbnQgbmNoYXJzIFVOSU5JVCwgbmJ5dGVzIFVOSU5JVDsKIAkgIC8qIGVtYWNzX211bGVf Y2hhciBjYW4gbG9hZCBhIGNoYXJzZXQgbWFwIGZyb20gYSBmaWxlLCB3aGljaAogCSAgICAg YWxsb2NhdGVzIGEgbGFyZ2Ugc3RydWN0dXJlIGFuZCBtaWdodCBjYXVzZSBidWZmZXIgdGV4 dAogCSAgICAgdG8gYmUgcmVsb2NhdGVkIGFzIHJlc3VsdC4gIFRodXMsIHdlIG5lZWQgdG8g cmVtZW1iZXIgdGhlCkBAIC04NTY1LDggKzg1NjYsOCBAQCBkZXRlY3RfY29kaW5nX3N5c3Rl bSAoY29uc3QgdW5zaWduZWQgY2hhciAqc3JjLAogICBiYXNlX2NhdGVnb3J5ID0gWElOVCAo Q09ESU5HX0FUVFJfQ0FURUdPUlkgKGF0dHJzKSk7CiAgIGlmIChiYXNlX2NhdGVnb3J5ID09 IGNvZGluZ19jYXRlZ29yeV91bmRlY2lkZWQpCiAgICAgewotICAgICAgZW51bSBjb2Rpbmdf Y2F0ZWdvcnkgY2F0ZWdvcnkgSUZfTElOVCAoPSAwKTsKLSAgICAgIHN0cnVjdCBjb2Rpbmdf c3lzdGVtICp0aGlzIElGX0xJTlQgKD0gTlVMTCk7CisgICAgICBlbnVtIGNvZGluZ19jYXRl Z29yeSBjYXRlZ29yeSBVTklOSVQ7CisgICAgICBzdHJ1Y3QgY29kaW5nX3N5c3RlbSAqdGhp cyBVTklOSVQ7CiAgICAgICBpbnQgYywgaTsKICAgICAgIGJvb2wgaW5oaWJpdF9uYmQgPSBp bmhpYml0X2ZsYWcgKGNvZGluZy5zcGVjLnVuZGVjaWRlZC5pbmhpYml0X25iZCwKIAkJCQkg ICAgICAgaW5oaWJpdF9udWxsX2J5dGVfZGV0ZWN0aW9uKTsKZGlmZiAtLWdpdCBhL3NyYy9j b21wb3NpdGUuYyBiL3NyYy9jb21wb3NpdGUuYwppbmRleCA0OWIwMDAzLi5iZWYxYzVmIDEw MDY0NAotLS0gYS9zcmMvY29tcG9zaXRlLmMKKysrIGIvc3JjL2NvbXBvc2l0ZS5jCkBAIC0x MzA4LDcgKzEzMDgsOCBAQCBjb21wb3NpdGlvbl9yZXNlYXRfaXQgKHN0cnVjdCBjb21wb3Np dGlvbl9pdCAqY21wX2l0LCBwdHJkaWZmX3QgY2hhcnBvcywKIGludAogY29tcG9zaXRpb25f dXBkYXRlX2l0IChzdHJ1Y3QgY29tcG9zaXRpb25faXQgKmNtcF9pdCwgcHRyZGlmZl90IGNo YXJwb3MsIHB0cmRpZmZfdCBieXRlcG9zLCBMaXNwX09iamVjdCBzdHJpbmcpCiB7Ci0gIGlu dCBpLCBjIElGX0xJTlQgKD0gMCk7CisgIGludCBpOworICBpbnQgYyBVTklOSVQ7CiAKICAg aWYgKGNtcF9pdC0+Y2ggPCAwKQogICAgIHsKZGlmZiAtLWdpdCBhL3NyYy9jb25mX3Bvc3Qu aCBiL3NyYy9jb25mX3Bvc3QuaAppbmRleCBiZWEyYThhLi4yODJlYmEwIDEwMDY0NAotLS0g YS9zcmMvY29uZl9wb3N0LmgKKysrIGIvc3JjL2NvbmZfcG9zdC5oCkBAIC0zNDMsMTEgKzM0 MywyMSBAQCBleHRlcm4gaW50IGVtYWNzX3NldGVudl9UWiAoY2hhciBjb25zdCAqKTsKICMg ZGVmaW5lIEZMRVhJQkxFX0FSUkFZX01FTUJFUgogI2VuZGlmCiAKLS8qIFVzZSBDT0RFIG9u bHkgaWYgbGludCBjaGVja2luZyBpcyBpbiBlZmZlY3QuICAqLworLyogV2hlbiB1c2VkIGlu IHBsYWNlIG9mICd2b2xhdGlsZScsICdOT05WT0xBVElMRScgaXMgZXF1aXZhbGVudCB0byBu b3RoaW5nLAorICAgZXhjZXB0IGl0IGNham9sZXMgR0NDIGludG8gbm90IHdhcm5pbmcgaW5j b3JyZWN0bHkgdGhhdCBhIHZhcmlhYmxlIG5lZWRzIHRvCisgICBiZSB2b2xhdGlsZS4gIFRo aXMgd29ya3MgYXJvdW5kIEdDQyBidWcgNTQ1NjEuICAqLwogI2lmIGRlZmluZWQgR0NDX0xJ TlQgfHwgZGVmaW5lZCBsaW50Ci0jIGRlZmluZSBJRl9MSU5UKENvZGUpIENvZGUKKyMgZGVm aW5lIE5PTlZPTEFUSUxFIHZvbGF0aWxlCiAjZWxzZQotIyBkZWZpbmUgSUZfTElOVChDb2Rl KSAvKiBlbXB0eSAqLworIyBkZWZpbmUgTk9OVk9MQVRJTEUgLyogZW1wdHkgKi8KKyNlbmRp ZgorCisvKiAnaW50IHggVU5JTklUOycgaXMgZXF1aXZhbGVudCB0byAnaW50IHg7JywgZXhj ZXB0IGl0IGNham9sZXMgR0NDCisgICBpbnRvIG5vdCB3YXJuaW5nIGluY29ycmVjdGx5IGFi b3V0IHVzZSBvZiBhbiB1bmluaXRpYWxpemVkIHZhcmlhYmxlLiAgKi8KKyNpZiBkZWZpbmVk IEdDQ19MSU5UIHx8IGRlZmluZWQgbGludAorIyBkZWZpbmUgVU5JTklUID0gezAsfQorI2Vs c2UKKyMgZGVmaW5lIFVOSU5JVCAvKiBlbXB0eSAqLwogI2VuZGlmCiAKIC8qIGNvbmZfcG9z dC5oIGVuZHMgaGVyZSAqLwpkaWZmIC0tZ2l0IGEvc3JjL2VkaXRmbnMuYyBiL3NyYy9lZGl0 Zm5zLmMKaW5kZXggNmIwOTk2ZC4uZjI1Y2ZjYiAxMDA2NDQKLS0tIGEvc3JjL2VkaXRmbnMu YworKysgYi9zcmMvZWRpdGZucy5jCkBAIC0zMzYzLDcgKzMzNjMsNyBAQCBJdCByZXR1cm5z IHRoZSBudW1iZXIgb2YgY2hhcmFjdGVycyBjaGFuZ2VkLiAgKi8pCiAgIHB0cmRpZmZfdCBz aXplOwkJLyogU2l6ZSBvZiB0cmFuc2xhdGUgdGFibGUuICovCiAgIHB0cmRpZmZfdCBwb3Ms IHBvc19ieXRlLCBlbmRfcG9zOwogICBib29sIG11bHRpYnl0ZSA9ICFOSUxQIChCVkFSIChj dXJyZW50X2J1ZmZlciwgZW5hYmxlX211bHRpYnl0ZV9jaGFyYWN0ZXJzKSk7Ci0gIGJvb2wg c3RyaW5nX211bHRpYnl0ZSBJRl9MSU5UICg9IDApOworICBib29sIHN0cmluZ19tdWx0aWJ5 dGUgVU5JTklUOwogCiAgIHZhbGlkYXRlX3JlZ2lvbiAoJnN0YXJ0LCAmZW5kKTsKICAgaWYg KENIQVJfVEFCTEVfUCAodGFibGUpKQpAQCAtMzkxOCw3ICszOTE4LDcgQEAgc3R5bGVkX2Zv cm1hdCAocHRyZGlmZl90IG5hcmdzLCBMaXNwX09iamVjdCAqYXJncywgYm9vbCBtZXNzYWdl KQogICBwdHJkaWZmX3QgYnVmc2l6ZSA9IHNpemVvZiBpbml0aWFsX2J1ZmZlcjsKICAgcHRy ZGlmZl90IG1heF9idWZzaXplID0gU1RSSU5HX0JZVEVTX0JPVU5EICsgMTsKICAgY2hhciAq cDsKLSAgcHRyZGlmZl90IGJ1Zl9zYXZlX3ZhbHVlX2luZGV4IElGX0xJTlQgKD0gMCk7Cisg IHB0cmRpZmZfdCBidWZfc2F2ZV92YWx1ZV9pbmRleCBVTklOSVQ7CiAgIGNoYXIgKmZvcm1h dCwgKmVuZDsKICAgcHRyZGlmZl90IG5jaGFyczsKICAgLyogV2hlbiB3ZSBtYWtlIGEgbXVs dGlieXRlIHN0cmluZywgd2UgbXVzdCBwYXkgYXR0ZW50aW9uIHRvIHRoZQpkaWZmIC0tZ2l0 IGEvc3JjL2ZpbGVpby5jIGIvc3JjL2ZpbGVpby5jCmluZGV4IDlkYTBiZjAuLjhjZTljNTMg MTAwNjQ0Ci0tLSBhL3NyYy9maWxlaW8uYworKysgYi9zcmMvZmlsZWlvLmMKQEAgLTQ2ODcs NyArNDY4Nyw3IEBAIHdyaXRlX3JlZ2lvbiAoTGlzcF9PYmplY3Qgc3RhcnQsIExpc3BfT2Jq ZWN0IGVuZCwgTGlzcF9PYmplY3QgZmlsZW5hbWUsCiB7CiAgIGludCBvcGVuX2ZsYWdzOwog ICBpbnQgbW9kZTsKLSAgb2ZmX3Qgb2Zmc2V0IElGX0xJTlQgKD0gMCk7CisgIG9mZl90IG9m ZnNldCBVTklOSVQ7CiAgIGJvb2wgb3Blbl9hbmRfY2xvc2VfZmlsZSA9IGRlc2MgPCAwOwog ICBib29sIG9rOwogICBpbnQgc2F2ZV9lcnJubyA9IDA7CkBAIC00Njk1LDcgKzQ2OTUsNyBA QCB3cml0ZV9yZWdpb24gKExpc3BfT2JqZWN0IHN0YXJ0LCBMaXNwX09iamVjdCBlbmQsIExp c3BfT2JqZWN0IGZpbGVuYW1lLAogICBzdHJ1Y3Qgc3RhdCBzdDsKICAgc3RydWN0IHRpbWVz cGVjIG1vZHRpbWU7CiAgIHB0cmRpZmZfdCBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7Ci0g IHB0cmRpZmZfdCBjb3VudDEgSUZfTElOVCAoPSAwKTsKKyAgcHRyZGlmZl90IGNvdW50MSBV TklOSVQ7CiAgIExpc3BfT2JqZWN0IGhhbmRsZXI7CiAgIExpc3BfT2JqZWN0IHZpc2l0X2Zp bGU7CiAgIExpc3BfT2JqZWN0IGFubm90YXRpb25zOwpkaWZmIC0tZ2l0IGEvc3JjL2ZvbnQu YyBiL3NyYy9mb250LmMKaW5kZXggNmRiZGE0MC4uZjI4OTg5MSAxMDA2NDQKLS0tIGEvc3Jj L2ZvbnQuYworKysgYi9zcmMvZm9udC5jCkBAIC0yMjM0LDcgKzIyMzQsOCBAQCBmb250X3Nv cnRfZW50aXRpZXMgKExpc3BfT2JqZWN0IGxpc3QsIExpc3BfT2JqZWN0IHByZWZlciwKICAg c3RydWN0IGZvbnRfc29ydF9kYXRhICpkYXRhOwogICB1bnNpZ25lZCBiZXN0X3Njb3JlOwog ICBMaXNwX09iamVjdCBiZXN0X2VudGl0eTsKLSAgTGlzcF9PYmplY3QgdGFpbCwgdmVjIElG X0xJTlQgKD0gUW5pbCk7CisgIExpc3BfT2JqZWN0IHRhaWw7CisgIExpc3BfT2JqZWN0IHZl YyBVTklOSVQ7CiAgIFVTRV9TQUZFX0FMTE9DQTsKIAogICBmb3IgKGkgPSBGT05UX1dFSUdI VF9JTkRFWDsgaSA8PSBGT05UX0FWR1dJRFRIX0lOREVYOyBpKyspCmRpZmYgLS1naXQgYS9z cmMvZm9udHNldC5jIGIvc3JjL2ZvbnRzZXQuYwppbmRleCBkODc5MDFkLi44MTUyOGRlIDEw MDY0NAotLS0gYS9zcmMvZm9udHNldC5jCisrKyBiL3NyYy9mb250c2V0LmMKQEAgLTc1MCw3 ICs3NTAsOCBAQCBmb250c2V0X2ZpbmRfZm9udCAoTGlzcF9PYmplY3QgZm9udHNldCwgaW50 IGMsIHN0cnVjdCBmYWNlICpmYWNlLAogc3RhdGljIExpc3BfT2JqZWN0CiBmb250c2V0X2Zv bnQgKExpc3BfT2JqZWN0IGZvbnRzZXQsIGludCBjLCBzdHJ1Y3QgZmFjZSAqZmFjZSwgaW50 IGlkKQogewotICBMaXNwX09iamVjdCByZm9udF9kZWYsIGRlZmF1bHRfcmZvbnRfZGVmIElG X0xJTlQgKD0gUW5pbCk7CisgIExpc3BfT2JqZWN0IHJmb250X2RlZjsKKyAgTGlzcF9PYmpl Y3QgZGVmYXVsdF9yZm9udF9kZWYgVU5JTklUOwogICBMaXNwX09iamVjdCBiYXNlX2ZvbnRz ZXQ7CiAKICAgLyogVHJ5IGEgZm9udC1ncm91cCBvZiBGT05UU0VULiAqLwpkaWZmIC0tZ2l0 IGEvc3JjL2ZyaW5nZS5jIGIvc3JjL2ZyaW5nZS5jCmluZGV4IDU1ZjM3YjguLjg3ZWM5ZDEg MTAwNjQ0Ci0tLSBhL3NyYy9mcmluZ2UuYworKysgYi9zcmMvZnJpbmdlLmMKQEAgLTk1Niw3 ICs5NTYsNyBAQCB1cGRhdGVfd2luZG93X2ZyaW5nZXMgKHN0cnVjdCB3aW5kb3cgKncsIGJv b2wga2VlcF9jdXJyZW50X3ApCiAgICAgIHJvdy0+aW5kaWNhdGVfYm9iX3AgaXMgc2V0LCBz byBpdCdzIE9LIHRoYXQgdG9wX3Jvd19lbmRzX2F0X3p2X3AKICAgICAgaXMgbm90IGluaXRp YWxpemVkIGhlcmUuICBTaW1pbGFybHkgZm9yIGJvdF9pbmRfcm4sCiAgICAgIHJvdy0+aW5k aWNhdGVfZW9iX3AgYW5kIGJvdF9yb3dfZW5kc19hdF96dl9wLiAgKi8KLSAgaW50IHRvcF9y b3dfZW5kc19hdF96dl9wIElGX0xJTlQgKD0gMCksIGJvdF9yb3dfZW5kc19hdF96dl9wIElG X0xJTlQgKD0gMCk7CisgIGludCB0b3Bfcm93X2VuZHNfYXRfenZfcCBVTklOSVQsIGJvdF9y b3dfZW5kc19hdF96dl9wIFVOSU5JVDsKIAogICBpZiAody0+cHNldWRvX3dpbmRvd19wKQog ICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvc3JjL2d0a3V0aWwuYyBiL3NyYy9ndGt1dGls LmMKaW5kZXggZTc5MWU2YS4uODhlNmQzMCAxMDA2NDQKLS0tIGEvc3JjL2d0a3V0aWwuYwor KysgYi9zcmMvZ3RrdXRpbC5jCkBAIC0xODI5LDcgKzE4MjksOCBAQCB4Z19nZXRfZmlsZV93 aXRoX2Nob29zZXIgKHN0cnVjdCBmcmFtZSAqZiwKIHsKICAgY2hhciBtc2didWZbMTAyNF07 CiAKLSAgR3RrV2lkZ2V0ICpmaWxld2luLCAqd3RvZ2dsZSwgKndib3gsICp3bWVzc2FnZSBJ Rl9MSU5UICg9IE5VTEwpOworICBHdGtXaWRnZXQgKmZpbGV3aW4sICp3dG9nZ2xlLCAqd2Jv eDsKKyAgR3RrV2lkZ2V0ICp3bWVzc2FnZSBVTklOSVQ7CiAgIEd0a1dpbmRvdyAqZ3dpbiA9 IEdUS19XSU5ET1cgKEZSQU1FX0dUS19PVVRFUl9XSURHRVQgKGYpKTsKICAgR3RrRmlsZUNo b29zZXJBY3Rpb24gYWN0aW9uID0gKG11c3RtYXRjaF9wID8KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIEdUS19GSUxFX0NIT09TRVJfQUNUSU9OX09QRU4gOgpkaWZmIC0t Z2l0IGEvc3JjL2ltYWdlLmMgYi9zcmMvaW1hZ2UuYwppbmRleCAwOTkxZjU3Li4zODg2NmUw IDEwMDY0NAotLS0gYS9zcmMvaW1hZ2UuYworKysgYi9zcmMvaW1hZ2UuYwpAQCAtMTE0Miw3 ICsxMTQyLDggQEAgc3RhdGljIFJHQl9QSVhFTF9DT0xPUgogZm91cl9jb3JuZXJzX2Jlc3Qg KFhJbWFnZVB0cl9vcl9EQyB4aW1nLCBpbnQgKmNvcm5lcnMsCiAJCSAgIHVuc2lnbmVkIGxv bmcgd2lkdGgsIHVuc2lnbmVkIGxvbmcgaGVpZ2h0KQogewotICBSR0JfUElYRUxfQ09MT1Ig Y29ybmVyX3BpeGVsc1s0XSwgYmVzdCBJRl9MSU5UICg9IDApOworICBSR0JfUElYRUxfQ09M T1IgY29ybmVyX3BpeGVsc1s0XTsKKyAgUkdCX1BJWEVMX0NPTE9SIGJlc3QgVU5JTklUOwog ICBpbnQgaSwgYmVzdF9jb3VudDsKIAogICBpZiAoY29ybmVycyAmJiBjb3JuZXJzW0JPVF9D T1JORVJdID49IDApCkBAIC01ODk1LDkgKzU4OTYsOCBAQCBzdGF0aWMgYm9vbAogcG5nX2xv YWRfYm9keSAoc3RydWN0IGZyYW1lICpmLCBzdHJ1Y3QgaW1hZ2UgKmltZywgc3RydWN0IHBu Z19sb2FkX2NvbnRleHQgKmMpCiB7CiAgIExpc3BfT2JqZWN0IHNwZWNpZmllZF9maWxlOwot ICAvKiBJRl9MSU5UICh2b2xhdGlsZSkgd29ya3MgYXJvdW5kIEdDQyBidWcgNTQ1NjEuICAq LwotICBMaXNwX09iamVjdCBJRl9MSU5UICh2b2xhdGlsZSkgc3BlY2lmaWVkX2RhdGE7Ci0g IEZJTEUgKiBJRl9MSU5UICh2b2xhdGlsZSkgZnAgPSBOVUxMOworICBMaXNwX09iamVjdCBO T05WT0xBVElMRSBzcGVjaWZpZWRfZGF0YTsKKyAgRklMRSAqTk9OVk9MQVRJTEUgZnAgPSBO VUxMOwogICBpbnQgeCwgeTsKICAgcHRyZGlmZl90IGk7CiAgIHBuZ19zdHJ1Y3QgKnBuZ19w dHI7CkBAIC02NjY4LDggKzY2NjgsNyBAQCBqcGVnX2xvYWRfYm9keSAoc3RydWN0IGZyYW1l ICpmLCBzdHJ1Y3QgaW1hZ2UgKmltZywKIAkJc3RydWN0IG15X2pwZWdfZXJyb3JfbWdyICpt Z3IpCiB7CiAgIExpc3BfT2JqZWN0IHNwZWNpZmllZF9maWxlOwotICAvKiBJRl9MSU5UICh2 b2xhdGlsZSkgd29ya3MgYXJvdW5kIEdDQyBidWcgNTQ1NjEuICAqLwotICBMaXNwX09iamVj dCBJRl9MSU5UICh2b2xhdGlsZSkgc3BlY2lmaWVkX2RhdGE7CisgIExpc3BfT2JqZWN0IE5P TlZPTEFUSUxFIHNwZWNpZmllZF9kYXRhOwogICBGSUxFICp2b2xhdGlsZSBmcCA9IE5VTEw7 CiAgIEpTQU1QQVJSQVkgYnVmZmVyOwogICBpbnQgcm93X3N0cmlkZSwgeCwgeTsKZGlmZiAt LWdpdCBhL3NyYy9pbmRlbnQuYyBiL3NyYy9pbmRlbnQuYwppbmRleCAwZWY4OTAzLi41ZDdj NmFlIDEwMDY0NAotLS0gYS9zcmMvaW5kZW50LmMKKysrIGIvc3JjL2luZGVudC5jCkBAIC0x OTk1LDcgKzE5OTUsNyBAQCB3aGV0aGVyIG9yIG5vdCBpdCBpcyBjdXJyZW50bHkgZGlzcGxh eWVkIGluIHNvbWUgd2luZG93LiAgKi8pCiAgIHN0cnVjdCB0ZXh0X3BvcyBwdDsKICAgc3Ry dWN0IHdpbmRvdyAqdzsKICAgTGlzcF9PYmplY3Qgb2xkX2J1ZmZlcjsKLSAgRU1BQ1NfSU5U IG9sZF9jaGFycG9zIElGX0xJTlQgKD0gMCksIG9sZF9ieXRlcG9zIElGX0xJTlQgKD0gMCk7 CisgIEVNQUNTX0lOVCBvbGRfY2hhcnBvcyBVTklOSVQsIG9sZF9ieXRlcG9zIFVOSU5JVDsK ICAgTGlzcF9PYmplY3QgbGNvbHM7CiAgIHZvaWQgKml0ZGF0YSA9IE5VTEw7CiAKQEAgLTIw MzYsOCArMjAzNiw4IEBAIHdoZXRoZXIgb3Igbm90IGl0IGlzIGN1cnJlbnRseSBkaXNwbGF5 ZWQgaW4gc29tZSB3aW5kb3cuICAqLykKICAgICAgIGJvb2wgZGlzcF9zdHJpbmdfYXRfc3Rh cnRfcCA9IDA7CiAgICAgICBwdHJkaWZmX3QgbmxpbmVzID0gWElOVCAobGluZXMpOwogICAg ICAgaW50IHZwb3NfaW5pdCA9IDA7Ci0gICAgICBkb3VibGUgc3RhcnRfY29sIElGX0xJTlQg KD0gMCk7Ci0gICAgICBpbnQgc3RhcnRfeCBJRl9MSU5UICg9IDApOworICAgICAgZG91Ymxl IHN0YXJ0X2NvbCBVTklOSVQ7CisgICAgICBpbnQgc3RhcnRfeCBVTklOSVQ7CiAgICAgICBp bnQgdG9feCA9IC0xOwogCiAgICAgICBib29sIHN0YXJ0X3hfZ2l2ZW4gPSAhTklMUCAoY3Vy X2NvbCk7CmRpZmYgLS1naXQgYS9zcmMva2V5Ym9hcmQuYyBiL3NyYy9rZXlib2FyZC5jCmlu ZGV4IGQyOTc2Y2IuLjcxN2MwNzEgMTAwNjQ0Ci0tLSBhL3NyYy9rZXlib2FyZC5jCisrKyBi L3NyYy9rZXlib2FyZC5jCkBAIC0yMzEyLDkgKzIzMTIsNyBAQCByZWFkX2NoYXIgKGludCBj b21tYW5kZmxhZywgTGlzcF9PYmplY3QgbWFwLAogCSAgIExpc3BfT2JqZWN0IHByZXZfZXZl bnQsCiAJICAgYm9vbCAqdXNlZF9tb3VzZV9tZW51LCBzdHJ1Y3QgdGltZXNwZWMgKmVuZF90 aW1lKQogewotICAvKiBJRl9MSU5UICh2b2xhdGlsZSkgd29ya3MgYXJvdW5kIEdDQyBidWcg NTQ1NjEuICAqLwotICBMaXNwX09iamVjdCBJRl9MSU5UICh2b2xhdGlsZSkgYzsKLQorICBM aXNwX09iamVjdCBOT05WT0xBVElMRSBjOwogICBwdHJkaWZmX3Qgam1wY291bnQ7CiAgIHN5 c19qbXBfYnVmIGxvY2FsX2dldGNqbXA7CiAgIHN5c19qbXBfYnVmIHNhdmVfanVtcDsKQEAg LTg4NDMsNyArODg0MSw3IEBAIHJlYWRfa2V5X3NlcXVlbmNlIChMaXNwX09iamVjdCAqa2V5 YnVmLCBpbnQgYnVmc2l6ZSwgTGlzcF9PYmplY3QgcHJvbXB0LAogCiAgIC8qIFRoZSBsZW5n dGggb2YgdGhlIGVjaG8gYnVmZmVyIHdoZW4gd2Ugc3RhcnRlZCByZWFkaW5nLCBhbmQKICAg ICAgdGhlIGxlbmd0aCBvZiB0aGlzX2NvbW1hbmRfa2V5cyB3aGVuIHdlIHN0YXJ0ZWQgcmVh ZGluZy4gICovCi0gIHB0cmRpZmZfdCBlY2hvX3N0YXJ0IElGX0xJTlQgKD0gMCk7CisgIHB0 cmRpZmZfdCBlY2hvX3N0YXJ0IFVOSU5JVDsKICAgcHRyZGlmZl90IGtleXNfc3RhcnQ7CiAK ICAgTGlzcF9PYmplY3QgY3VycmVudF9iaW5kaW5nID0gUW5pbDsKQEAgLTg4OTEsNyArODg4 OSw3IEBAIHJlYWRfa2V5X3NlcXVlbmNlIChMaXNwX09iamVjdCAqa2V5YnVmLCBpbnQgYnVm c2l6ZSwgTGlzcF9PYmplY3QgcHJvbXB0LAogICAgICBXaGlsZSB3ZSdyZSByZWFkaW5nLCB3 ZSBrZWVwIHRoZSBldmVudCBoZXJlLiAgKi8KICAgTGlzcF9PYmplY3QgZGVsYXllZF9zd2l0 Y2hfZnJhbWU7CiAKLSAgTGlzcF9PYmplY3Qgb3JpZ2luYWxfdXBwZXJjYXNlIElGX0xJTlQg KD0gUW5pbCk7CisgIExpc3BfT2JqZWN0IG9yaWdpbmFsX3VwcGVyY2FzZSBVTklOSVQ7CiAg IGludCBvcmlnaW5hbF91cHBlcmNhc2VfcG9zaXRpb24gPSAtMTsKIAogICAvKiBHZXRzIGFy b3VuZCBNaWNyb3NvZnQgY29tcGlsZXIgbGltaXRhdGlvbnMuICAqLwpAQCAtOTAwMSw3ICs4 OTk5LDcgQEAgcmVhZF9rZXlfc2VxdWVuY2UgKExpc3BfT2JqZWN0ICprZXlidWYsIGludCBi dWZzaXplLCBMaXNwX09iamVjdCBwcm9tcHQsCiAJIHdoaWxlIHRob3NlIGFsbG93IHVzIHRv IHJlc3RhcnQgdGhlIGVudGlyZSBrZXkgc2VxdWVuY2UsCiAJIGVjaG9fbG9jYWxfc3RhcnQg YW5kIGtleXNfbG9jYWxfc3RhcnQgYWxsb3cgdXMgdG8gdGhyb3cgYXdheQogCSBqdXN0IG9u ZSBrZXkuICAqLwotICAgICAgcHRyZGlmZl90IGVjaG9fbG9jYWxfc3RhcnQgSUZfTElOVCAo PSAwKTsKKyAgICAgIHB0cmRpZmZfdCBlY2hvX2xvY2FsX3N0YXJ0IFVOSU5JVDsKICAgICAg IGludCBrZXlzX2xvY2FsX3N0YXJ0OwogICAgICAgTGlzcF9PYmplY3QgbmV3X2JpbmRpbmc7 CiAKZGlmZiAtLWdpdCBhL3NyYy9scmVhZC5jIGIvc3JjL2xyZWFkLmMKaW5kZXggOThhNGQ2 OS4uYjA4Y2UxNyAxMDA2NDQKLS0tIGEvc3JjL2xyZWFkLmMKKysrIGIvc3JjL2xyZWFkLmMK QEAgLTEwNDAsNyArMTA0MCw3IEBAIFJldHVybiB0IGlmIHRoZSBmaWxlIGV4aXN0cyBhbmQg bG9hZHMgc3VjY2Vzc2Z1bGx5LiAgKi8pCiB7CiAgIEZJTEUgKnN0cmVhbTsKICAgaW50IGZk OwotICBpbnQgZmRfaW5kZXg7CisgIGludCBmZF9pbmRleCBVTklOSVQ7CiAgIHB0cmRpZmZf dCBjb3VudCA9IFNQRUNQRExfSU5ERVggKCk7CiAgIExpc3BfT2JqZWN0IGZvdW5kLCBlZm91 bmQsIGhpc3RfZmlsZV9uYW1lOwogICAvKiBUcnVlIG1lYW5zIHdlIHByaW50ZWQgdGhlICIu ZWwgaXMgbmV3ZXIiIG1lc3NhZ2UuICAqLwpAQCAtMTE1NiwxMiArMTE1Niw3IEBAIFJldHVy biB0IGlmIHRoZSBmaWxlIGV4aXN0cyBhbmQgbG9hZHMgc3VjY2Vzc2Z1bGx5LiAgKi8pCiAj ZW5kaWYKICAgICB9CiAKLSAgaWYgKGZkIDwgMCkKLSAgICB7Ci0gICAgICAvKiBQYWNpZnkg b2xkZXIgR0NDIHdpdGggLS1lbmFibGUtZ2NjLXdhcm5pbmdzLiAgKi8KLSAgICAgIElGX0xJ TlQgKGZkX2luZGV4ID0gMCk7Ci0gICAgfQotICBlbHNlCisgIGlmICgwIDw9IGZkKQogICAg IHsKICAgICAgIGZkX2luZGV4ID0gU1BFQ1BETF9JTkRFWCAoKTsKICAgICAgIHJlY29yZF91 bndpbmRfcHJvdGVjdF9pbnQgKGNsb3NlX2ZpbGVfdW53aW5kLCBmZCk7CmRpZmYgLS1naXQg YS9zcmMvbWluaWJ1Zi5jIGIvc3JjL21pbmlidWYuYwppbmRleCA3NTgzMTYxLi43YmFkNmYw IDEwMDY0NAotLS0gYS9zcmMvbWluaWJ1Zi5jCisrKyBiL3NyYy9taW5pYnVmLmMKQEAgLTE5 NCw3ICsxOTQsNyBAQCByZWFkX21pbmlidWZfbm9uaW50ZXJhY3RpdmUgKExpc3BfT2JqZWN0 IG1hcCwgTGlzcF9PYmplY3QgaW5pdGlhbCwKICAgaW50IGM7CiAgIHVuc2lnbmVkIGNoYXIg aGlkZV9jaGFyID0gMDsKICAgc3RydWN0IGVtYWNzX3R0eSBldHR5OwotICBib29sIGV0dHlf dmFsaWQgSUZfTElOVCAoPSBmYWxzZSk7CisgIGJvb2wgZXR0eV92YWxpZCBVTklOSVQ7CiAK ICAgLyogQ2hlY2ssIHdoZXRoZXIgd2UgbmVlZCB0byBzdXBwcmVzcyBlY2hvaW5nLiAgKi8K ICAgaWYgKENIQVJBQ1RFUlAgKFZyZWFkX2hpZGVfY2hhcikpCmRpZmYgLS1naXQgYS9zcmMv cHJpbnQuYyBiL3NyYy9wcmludC5jCmluZGV4IDgzZWRiYjYuLjU1MzEyMTAgMTAwNjQ0Ci0t LSBhL3NyYy9wcmludC5jCisrKyBiL3NyYy9wcmludC5jCkBAIC0yMDMsNyArMjAzLDcgQEAg cHJpbnRfdW53aW5kIChMaXNwX09iamVjdCBzYXZlZF90ZXh0KQogc3RhdGljIHZvaWQKIHBy aW50Y2hhcl90b19zdHJlYW0gKHVuc2lnbmVkIGludCBjaCwgRklMRSAqc3RyZWFtKQogewot ICBMaXNwX09iamVjdCBkdiBJRl9MSU5UICg9IFFuaWwpOworICBMaXNwX09iamVjdCBkdiBV TklOSVQ7CiAgIHB0cmRpZmZfdCBpID0gMCwgbiA9IDE7CiAgIExpc3BfT2JqZWN0IGNvZGlu Z19zeXN0ZW0gPSBWbG9jYWxlX2NvZGluZ19zeXN0ZW07CiAgIGJvb2wgZW5jb2RlX3AgPSBm YWxzZTsKZGlmZiAtLWdpdCBhL3NyYy9yZWdleC5jIGIvc3JjL3JlZ2V4LmMKaW5kZXggZmMy YTQ2Zi4uZjkyYmNiNyAxMDA2NDQKLS0tIGEvc3JjL3JlZ2V4LmMKKysrIGIvc3JjL3JlZ2V4 LmMKQEAgLTU0NDQsNyArNTQ0NCw3IEBAIHJlX21hdGNoXzJfaW50ZXJuYWwgKHN0cnVjdCBy ZV9wYXR0ZXJuX2J1ZmZlciAqYnVmcCwgY29uc3RfcmVfY2hhciAqc3RyaW5nMSwKIAogCSAg ICAvKiBTdGFydCBvZiBhY3R1YWwgcmFuZ2VfdGFibGUsIG9yIGVuZCBvZiBiaXRtYXAgaWYg dGhlcmUgaXMgbm8KIAkgICAgICAgcmFuZ2UgdGFibGUuICAqLwotCSAgICByZV9jaGFyICpy YW5nZV90YWJsZSBJRl9MSU5UICg9IE5VTEwpOworCSAgICByZV9jaGFyICpyYW5nZV90YWJs ZSBVTklOSVQ7CiAKIAkgICAgLyogTm9uemVybyBpZiB0aGVyZSBpcyBhIHJhbmdlIHRhYmxl LiAgKi8KIAkgICAgaW50IHJhbmdlX3RhYmxlX2V4aXN0czsKZGlmZiAtLWdpdCBhL3NyYy9z eW50YXguYyBiL3NyYy9zeW50YXguYwppbmRleCAxYzNmNjQ0Li4zODNiZTIyIDEwMDY0NAot LS0gYS9zcmMvc3ludGF4LmMKKysrIGIvc3JjL3N5bnRheC5jCkBAIC0xNjMzLDcgKzE2MzMs NyBAQCBza2lwX2NoYXJzIChib29sIGZvcndhcmRwLCBMaXNwX09iamVjdCBzdHJpbmcsIExp c3BfT2JqZWN0IGxpbSwKICAgaW50IGM7CiAgIGNoYXIgZmFzdG1hcFswNDAwXTsKICAgLyog U3RvcmUgdGhlIHJhbmdlcyBvZiBub24tQVNDSUkgY2hhcmFjdGVycy4gICovCi0gIGludCAq Y2hhcl9yYW5nZXMgSUZfTElOVCAoPSBOVUxMKTsKKyAgaW50ICpjaGFyX3JhbmdlcyBVTklO SVQ7CiAgIGludCBuX2NoYXJfcmFuZ2VzID0gMDsKICAgYm9vbCBuZWdhdGUgPSAwOwogICBw dHJkaWZmX3QgaSwgaV9ieXRlOwpkaWZmIC0tZ2l0IGEvc3JjL3Rlcm0uYyBiL3NyYy90ZXJt LmMKaW5kZXggZGY1ODNjYi4uN2U2M2EwYyAxMDA2NDQKLS0tIGEvc3JjL3Rlcm0uYworKysg Yi9zcmMvdGVybS5jCkBAIC01NDgsOCArNTQ4LDggQEAgZW5jb2RlX3Rlcm1pbmFsX2NvZGUg KHN0cnVjdCBnbHlwaCAqc3JjLCBpbnQgc3JjX2xlbiwKICAgICB7CiAgICAgICBpZiAoc3Jj LT50eXBlID09IENPTVBPU0lURV9HTFlQSCkKIAl7Ci0JICBzdHJ1Y3QgY29tcG9zaXRpb24g KmNtcCBJRl9MSU5UICg9IE5VTEwpOwotCSAgTGlzcF9PYmplY3QgZ3N0cmluZyBJRl9MSU5U ICg9IFFuaWwpOworCSAgc3RydWN0IGNvbXBvc2l0aW9uICpjbXAgVU5JTklUOworCSAgTGlz cF9PYmplY3QgZ3N0cmluZyBVTklOSVQ7CiAJICBpbnQgaTsKIAogCSAgbmJ5dGVzID0gYnVm IC0gZW5jb2RlX3Rlcm1pbmFsX3NyYzsKQEAgLTYxNCw3ICs2MTQsNyBAQCBlbmNvZGVfdGVy bWluYWxfY29kZSAoc3RydWN0IGdseXBoICpzcmMsIGludCBzcmNfbGVuLAogICAgICAgZWxz ZSBpZiAoISBDSEFSX0dMWVBIX1BBRERJTkdfUCAoKnNyYykpCiAJewogCSAgR0xZUEggZzsK LQkgIGludCBjIElGX0xJTlQgKD0gMCk7CisJICBpbnQgYyBVTklOSVQ7CiAJICBMaXNwX09i amVjdCBzdHJpbmc7CiAKIAkgIHN0cmluZyA9IFFuaWw7CkBAIC0zMDk5LDcgKzMwOTksNyBA QCB0dHlfbWVudV9hY3RpdmF0ZSAodHR5X21lbnUgKm1lbnUsIGludCAqcGFuZSwgaW50ICpz ZWxpZHgsCiAgIHN0cnVjdCB0dHlfbWVudV9zdGF0ZSAqc3RhdGU7CiAgIGludCBzdGF0ZWNv dW50LCB4LCB5LCBpOwogICBib29sIGxlYXZlLCBvbmVwYW5lOwotICBpbnQgcmVzdWx0IElG X0xJTlQgKD0gMCk7CisgIGludCByZXN1bHQgVU5JTklUOwogICBpbnQgdGl0bGVfZmFjZXNb NF07CQkvKiBGYWNlIHRvIGRpc3BsYXkgdGhlIG1lbnUgdGl0bGUuICAqLwogICBpbnQgZmFj ZXNbNF0sIGJ1ZmZlcnNfbnVtX2RlbGV0ZWQgPSAwOwogICBzdHJ1Y3QgZnJhbWUgKnNmID0g U0VMRUNURURfRlJBTUUgKCk7CmRpZmYgLS1naXQgYS9zcmMvd2luZG93LmMgYi9zcmMvd2lu ZG93LmMKaW5kZXggOTlhMDcwOS4uZmUxMDI0MSAxMDA2NDQKLS0tIGEvc3JjL3dpbmRvdy5j CisrKyBiL3NyYy93aW5kb3cuYwpAQCAtMjkxMCw5ICsyOTEwLDExIEBAIHdpbmRvdy1zdGFy dCB2YWx1ZSBpcyByZWFzb25hYmxlIHdoZW4gdGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQuICAq LykKIHsKICAgc3RydWN0IHdpbmRvdyAqdywgKnIsICpzOwogICBzdHJ1Y3QgZnJhbWUgKmY7 Ci0gIExpc3BfT2JqZWN0IHNpYmxpbmcsIHB3aW5kb3csIHN3aW5kb3cgSUZfTElOVCAoPSBR bmlsKSwgZGVsdGE7Ci0gIHB0cmRpZmZfdCBzdGFydHBvcyBJRl9MSU5UICg9IDApLCBzdGFy dGJ5dGUgSUZfTElOVCAoPSAwKTsKLSAgaW50IHRvcCBJRl9MSU5UICg9IDApLCBuZXdfdG9w OworICBMaXNwX09iamVjdCBzaWJsaW5nLCBwd2luZG93LCBkZWx0YTsKKyAgTGlzcF9PYmpl Y3Qgc3dpbmRvdyBVTklOSVQ7CisgIHB0cmRpZmZfdCBzdGFydHBvcyBVTklOSVQsIHN0YXJ0 Ynl0ZSBVTklOSVQ7CisgIGludCB0b3AgVU5JTklUOworICBpbnQgbmV3X3RvcDsKICAgYm9v bCByZXNpemVfZmFpbGVkID0gZmFsc2U7CiAKICAgdyA9IGRlY29kZV92YWxpZF93aW5kb3cg KHdpbmRvdyk7CmRpZmYgLS1naXQgYS9zcmMveGRpc3AuYyBiL3NyYy94ZGlzcC5jCmluZGV4 IGQyZjBkNDkuLmQ1ODkwODAgMTAwNjQ0Ci0tLSBhL3NyYy94ZGlzcC5jCisrKyBiL3NyYy94 ZGlzcC5jCkBAIC04NTU4LDcgKzg1NTgsOCBAQCBtb3ZlX2l0X2luX2Rpc3BsYXlfbGluZV90 byAoc3RydWN0IGl0ICppdCwKICAgdm9pZCAqcHBvc19kYXRhID0gTlVMTDsKICAgYm9vbCBt YXlfd3JhcCA9IGZhbHNlOwogICBlbnVtIGl0X21ldGhvZCBwcmV2X21ldGhvZCA9IGl0LT5t ZXRob2Q7Ci0gIHB0cmRpZmZfdCBjbG9zZXN0X3BvcyBJRl9MSU5UICg9IDApLCBwcmV2X3Bv cyA9IElUX0NIQVJQT1MgKCppdCk7CisgIHB0cmRpZmZfdCBjbG9zZXN0X3BvcyBVTklOSVQ7 CisgIHB0cmRpZmZfdCBwcmV2X3BvcyA9IElUX0NIQVJQT1MgKCppdCk7CiAgIGJvb2wgc2F3 X3NtYWxsZXJfcG9zID0gcHJldl9wb3MgPCB0b19jaGFycG9zOwogCiAgIC8qIERvbid0IHBy b2R1Y2UgZ2x5cGhzIGluIHByb2R1Y2VfZ2x5cGhzLiAgKi8KQEAgLTIwNDE2LDE2ICsyMDQx NywxNiBAQCBkaXNwbGF5X2xpbmUgKHN0cnVjdCBpdCAqaXQpCiAgIHN0cnVjdCBpdCB3cmFw X2l0OwogICB2b2lkICp3cmFwX2RhdGEgPSBOVUxMOwogICBib29sIG1heV93cmFwID0gZmFs c2U7Ci0gIGludCB3cmFwX3ggSUZfTElOVCAoPSAwKTsKKyAgaW50IHdyYXBfeCBVTklOSVQ7 CiAgIGludCB3cmFwX3Jvd191c2VkID0gLTE7Ci0gIGludCB3cmFwX3Jvd19hc2NlbnQgSUZf TElOVCAoPSAwKSwgd3JhcF9yb3dfaGVpZ2h0IElGX0xJTlQgKD0gMCk7Ci0gIGludCB3cmFw X3Jvd19waHlzX2FzY2VudCBJRl9MSU5UICg9IDApLCB3cmFwX3Jvd19waHlzX2hlaWdodCBJ Rl9MSU5UICg9IDApOwotICBpbnQgd3JhcF9yb3dfZXh0cmFfbGluZV9zcGFjaW5nIElGX0xJ TlQgKD0gMCk7Ci0gIHB0cmRpZmZfdCB3cmFwX3Jvd19taW5fcG9zIElGX0xJTlQgKD0gMCks IHdyYXBfcm93X21pbl9icG9zIElGX0xJTlQgKD0gMCk7Ci0gIHB0cmRpZmZfdCB3cmFwX3Jv d19tYXhfcG9zIElGX0xJTlQgKD0gMCksIHdyYXBfcm93X21heF9icG9zIElGX0xJTlQgKD0g MCk7CisgIGludCB3cmFwX3Jvd19hc2NlbnQgVU5JTklULCB3cmFwX3Jvd19oZWlnaHQgVU5J TklUOworICBpbnQgd3JhcF9yb3dfcGh5c19hc2NlbnQgVU5JTklULCB3cmFwX3Jvd19waHlz X2hlaWdodCBVTklOSVQ7CisgIGludCB3cmFwX3Jvd19leHRyYV9saW5lX3NwYWNpbmcgVU5J TklUOworICBwdHJkaWZmX3Qgd3JhcF9yb3dfbWluX3BvcyBVTklOSVQsIHdyYXBfcm93X21p bl9icG9zIFVOSU5JVDsKKyAgcHRyZGlmZl90IHdyYXBfcm93X21heF9wb3MgVU5JTklULCB3 cmFwX3Jvd19tYXhfYnBvcyBVTklOSVQ7CiAgIGludCBjdnBvczsKICAgcHRyZGlmZl90IG1p bl9wb3MgPSBaViArIDEsIG1heF9wb3MgPSAwOwotICBwdHJkaWZmX3QgbWluX2Jwb3MgSUZf TElOVCAoPSAwKSwgbWF4X2Jwb3MgSUZfTElOVCAoPSAwKTsKKyAgcHRyZGlmZl90IG1pbl9i cG9zIFVOSU5JVCwgbWF4X2Jwb3MgVU5JTklUOwogICBib29sIHBlbmRpbmdfaGFuZGxlX2xp bmVfcHJlZml4ID0gZmFsc2U7CiAKICAgLyogV2UgYWx3YXlzIHN0YXJ0IGRpc3BsYXlpbmcg YXQgaHBvcyB6ZXJvIGV2ZW4gaWYgaHNjcm9sbGVkLiAgKi8KQEAgLTI1NTk1LDcgKzI1NTk2 LDcgQEAgZHJhd19nbHlwaHMgKHN0cnVjdCB3aW5kb3cgKncsIGludCB4LCBzdHJ1Y3QgZ2x5 cGhfcm93ICpyb3csCiAgICAgewogICAgICAgc3RydWN0IGdseXBoX3N0cmluZyAqaCwgKnQ7 CiAgICAgICBNb3VzZV9ITEluZm8gKmhsaW5mbyA9IE1PVVNFX0hMX0lORk8gKGYpOwotICAg ICAgaW50IG1vdXNlX2JlZ19jb2wgSUZfTElOVCAoPSAwKSwgbW91c2VfZW5kX2NvbCBJRl9M SU5UICg9IDApOworICAgICAgaW50IG1vdXNlX2JlZ19jb2wgVU5JTklULCBtb3VzZV9lbmRf Y29sIFVOSU5JVDsKICAgICAgIGJvb2wgY2hlY2tfbW91c2VfZmFjZSA9IGZhbHNlOwogICAg ICAgaW50IGR1bW15X3ggPSAwOwogCkBAIC0yOTcwMiwxMiArMjk3MDMsMTEgQEAgbm90ZV9t b2RlX2xpbmVfb3JfbWFyZ2luX2hpZ2hsaWdodCAoTGlzcF9PYmplY3Qgd2luZG93LCBpbnQg eCwgaW50IHksCiAgIGludCBkeCwgZHksIHdpZHRoLCBoZWlnaHQ7CiAgIHB0cmRpZmZfdCBj aGFycG9zOwogICBMaXNwX09iamVjdCBzdHJpbmcsIG9iamVjdCA9IFFuaWw7Ci0gIExpc3Bf T2JqZWN0IHBvcyBJRl9MSU5UICg9IFFuaWwpLCBoZWxwOwotCisgIExpc3BfT2JqZWN0IHBv cyBVTklOSVQ7CiAgIExpc3BfT2JqZWN0IG1vdXNlX2ZhY2U7CiAgIGludCBvcmlnaW5hbF94 X3BpeGVsID0geDsKICAgc3RydWN0IGdseXBoICogZ2x5cGggPSBOVUxMLCAqIHJvd19zdGFy dF9nbHlwaCA9IE5VTEw7Ci0gIHN0cnVjdCBnbHlwaF9yb3cgKnJvdyBJRl9MSU5UICg9IDAp OworICBzdHJ1Y3QgZ2x5cGhfcm93ICpyb3cgVU5JTklUOwogCiAgIGlmIChhcmVhID09IE9O X01PREVfTElORSB8fCBhcmVhID09IE9OX0hFQURFUl9MSU5FKQogICAgIHsKQEAgLTI5NzQ3 LDcgKzI5NzQ3LDcgQEAgbm90ZV9tb2RlX2xpbmVfb3JfbWFyZ2luX2hpZ2hsaWdodCAoTGlz cF9PYmplY3Qgd2luZG93LCBpbnQgeCwgaW50IHksCiAJCQkJICAgICAmb2JqZWN0LCAmZHgs ICZkeSwgJndpZHRoLCAmaGVpZ2h0KTsKICAgICB9CiAKLSAgaGVscCA9IFFuaWw7CisgIExp c3BfT2JqZWN0IGhlbHAgPSBRbmlsOwogCiAjaWZkZWYgSEFWRV9XSU5ET1dfU1lTVEVNCiAg IGlmIChJTUFHRVAgKG9iamVjdCkpCkBAIC0zMDMyMiw4ICszMDMyMiw4IEBAIG5vdGVfbW91 c2VfaGlnaGxpZ2h0IChzdHJ1Y3QgZnJhbWUgKmYsIGludCB4LCBpbnQgeSkKIAkgICAgewog CSAgICAgIC8qIFRoZSBtb3VzZS1oaWdobGlnaHRpbmcsIGlmIGFueSwgY29tZXMgZnJvbSBh biBvdmVybGF5CiAJCSBvciB0ZXh0IHByb3BlcnR5IGluIHRoZSBidWZmZXIuICAqLwotCSAg ICAgIExpc3BfT2JqZWN0IGJ1ZmZlciBJRl9MSU5UICg9IFFuaWwpOwotCSAgICAgIExpc3Bf T2JqZWN0IGRpc3Bfc3RyaW5nIElGX0xJTlQgKD0gUW5pbCk7CisJICAgICAgTGlzcF9PYmpl Y3QgYnVmZmVyIFVOSU5JVDsKKwkgICAgICBMaXNwX09iamVjdCBkaXNwX3N0cmluZyBVTklO SVQ7CiAKIAkgICAgICBpZiAoU1RSSU5HUCAob2JqZWN0KSkKIAkJewpkaWZmIC0tZ2l0IGEv c3JjL3hmb250LmMgYi9zcmMveGZvbnQuYwppbmRleCAwZWY2NGJlLi44ZmJlOTRjIDEwMDY0 NAotLS0gYS9zcmMveGZvbnQuYworKysgYi9zcmMveGZvbnQuYwpAQCAtNjM1LDcgKzYzNSw3 IEBAIHhmb250X2xpc3RfZmFtaWx5IChzdHJ1Y3QgZnJhbWUgKmYpCiAgIGNoYXIgKipuYW1l czsKICAgaW50IG51bV9mb250cywgaTsKICAgTGlzcF9PYmplY3QgbGlzdDsKLSAgY2hhciAq bGFzdF9mYW1pbHkgSUZfTElOVCAoPSAwKTsKKyAgY2hhciAqbGFzdF9mYW1pbHkgVU5JTklU OwogICBpbnQgbGFzdF9sZW47CiAKICAgYmxvY2tfaW5wdXQgKCk7Ci0tIAoyLjUuNQoK --------------DE3B07DC467DC9434A54F0DD-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 02:19:55 2016 Received: (at 23640) by debbugs.gnu.org; 7 Jun 2016 06:19:55 +0000 Received: from localhost ([127.0.0.1]:57347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAAMl-0002vU-93 for submit@debbugs.gnu.org; Tue, 07 Jun 2016 02:19:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAAMj-0002vF-0I for 23640@debbugs.gnu.org; Tue, 07 Jun 2016 02:19:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAAMc-0008QA-S1 for 23640@debbugs.gnu.org; Tue, 07 Jun 2016 02:19:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAAMb-0008PP-D0; Tue, 07 Jun 2016 02:19:45 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAAMa-0000Vl-Md; Tue, 07 Jun 2016 02:19:44 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Paul Eggert In-reply-to: (message from Paul Eggert on Mon, 6 Jun 2016 07:45:00 -0700) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> Message-Id: Date: Tue, 07 Jun 2016 02:19:44 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] Your patch seems reasonable to me. The reason I chose the name UNUSED is that I had in mind it would stand for just the initial value (without the =). But then I imitated the suggestion to include the =. You're right that name UNUSED is not appropriate for that. So I suggest char *ident_start = UNUSED; and so on. That should make it very clear, and the name fits what it does. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 03:15:42 2016 Received: (at 23640) by debbugs.gnu.org; 7 Jun 2016 07:15:42 +0000 Received: from localhost ([127.0.0.1]:57395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bABEk-0004HF-Hv for submit@debbugs.gnu.org; Tue, 07 Jun 2016 03:15:42 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:59828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bABEi-0004H1-Nb for 23640@debbugs.gnu.org; Tue, 07 Jun 2016 03:15:41 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C8CBD1613C1; Tue, 7 Jun 2016 00:15:34 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 37aWPfTU4MHG; Tue, 7 Jun 2016 00:15:34 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 1755C1613C3; Tue, 7 Jun 2016 00:15:34 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KNtlgwcwIO8b; Tue, 7 Jun 2016 00:15:34 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id EA397161327; Tue, 7 Jun 2016 00:15:33 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: rms@gnu.org References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <57567492.2000009@cs.ucla.edu> Date: Tue, 7 Jun 2016 00:15:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Richard Stallman wrote: > char *ident_start =3D UNUSED; That would set ident_start to zero even when GCC warnings are disabled, w= hich=20 would be a bit slower since ident_start does not need to be initialized.=20 Unfortunately there is no syntax in C for a no-op initializer, so there's= no way=20 to define UNUSED so that it initializes ident_start when GCC warnings are= =20 enabled and leaves ident_start uninitialized otherwise. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 00:00:31 2016 Received: (at 23640) by debbugs.gnu.org; 8 Jun 2016 04:00:31 +0000 Received: from localhost ([127.0.0.1]:59452 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAUfP-0007rf-LC for submit@debbugs.gnu.org; Wed, 08 Jun 2016 00:00:31 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAUfN-0007km-Rj for 23640@debbugs.gnu.org; Wed, 08 Jun 2016 00:00:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAUfH-0001iR-Oi for 23640@debbugs.gnu.org; Wed, 08 Jun 2016 00:00:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34989) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAUfG-0001i3-9q; Wed, 08 Jun 2016 00:00:22 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAUfE-0003uB-G3; Wed, 08 Jun 2016 00:00:20 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Paul Eggert In-reply-to: <57567492.2000009@cs.ucla.edu> (message from Paul Eggert on Tue, 7 Jun 2016 00:15:30 -0700) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> <57567492.2000009@cs.ucla.edu> Message-Id: Date: Wed, 08 Jun 2016 00:00:20 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > That would set ident_start to zero even when GCC warnings are disabled, which > would be a bit slower since ident_start does not need to be initialized. I guess so -- but is it a noticeable slowdown? A priori, I doubt it. If it is not significant, why worry about it? Better to write the code in the clean way. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 03:18:19 2016 Received: (at 23640) by debbugs.gnu.org; 8 Jun 2016 07:18:19 +0000 Received: from localhost ([127.0.0.1]:59657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAXkp-0005V5-6L for submit@debbugs.gnu.org; Wed, 08 Jun 2016 03:18:19 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAXkn-0005Us-EG for 23640@debbugs.gnu.org; Wed, 08 Jun 2016 03:18:17 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 470351613CE; Wed, 8 Jun 2016 00:18:10 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id XDmAfqcJBhYR; Wed, 8 Jun 2016 00:18:09 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9BAF916142E; Wed, 8 Jun 2016 00:18:09 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id a1zXWRtzcZku; Wed, 8 Jun 2016 00:18:09 -0700 (PDT) Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7DC971613CE; Wed, 8 Jun 2016 00:18:09 -0700 (PDT) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings To: rms@gnu.org References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> <57567492.2000009@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <5757C6B1.5080808@cs.ucla.edu> Date: Wed, 8 Jun 2016 00:18:09 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Richard Stallman wrote: > I guess so -- but is it a noticeable slowdown? A priori, I doubt it. You're probably right. The major effect these days would be on cache pres= sure,=20 which is tricky to measure. > If it is not significant, why worry about it? > Better to write the code in the clean way. For me it's cleaner to think of UNINIT as an attribute for a declaration,= =20 instead of thinking of UNUSED as a special expression that neither transf= ers=20 control nor has a side effect nor yields a value. It's merely a plus that= UNINIT=20 generates code that is a tiny bit smaller and faster. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 13:07:09 2016 Received: (at 23640) by debbugs.gnu.org; 8 Jun 2016 17:07:09 +0000 Received: from localhost ([127.0.0.1]:33064 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAgwe-0007uA-M5 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:07:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAgwd-0007to-0p for 23640@debbugs.gnu.org; Wed, 08 Jun 2016 13:07:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAgwX-0005sp-5V for 23640@debbugs.gnu.org; Wed, 08 Jun 2016 13:07:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47082) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAgwU-0005mS-Pl; Wed, 08 Jun 2016 13:06:58 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1bAgwS-0008OD-Sa; Wed, 08 Jun 2016 13:06:56 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Paul Eggert In-reply-to: <5757C6B1.5080808@cs.ucla.edu> (message from Paul Eggert on Wed, 8 Jun 2016 00:18:09 -0700) Subject: Re: bug#23640: 25.1.50; Getting rid of compiler warnings References: <574E9E50.6040301@cs.ucla.edu> <2b96b91c-cb05-59a5-0458-05239b26da1b@cs.ucla.edu> <57567492.2000009@cs.ucla.edu> <5757C6B1.5080808@cs.ucla.edu> Message-Id: Date: Wed, 08 Jun 2016 13:06:56 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23640 Cc: 23640@debbugs.gnu.org, andrewjmoreton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > For me it's cleaner to think of UNINIT as an attribute for a declaration, > instead of thinking of UNUSED as a special expression that neither transfers > control nor has a side effect nor yields a value. It's merely a plus that UNINIT > generates code that is a tiny bit smaller and faster. I won't shed any more bikes on this question. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From unknown Fri Jun 20 07:18:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Jul 2016 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator