From debbugs-submit-bounces@debbugs.gnu.org Thu May 26 11:34:57 2016 Received: (at submit) by debbugs.gnu.org; 26 May 2016 15:34:57 +0000 Received: from localhost ([127.0.0.1]:40670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5xJJ-0005UJ-8L for submit@debbugs.gnu.org; Thu, 26 May 2016 11:34:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5xJI-0005U7-51 for submit@debbugs.gnu.org; Thu, 26 May 2016 11:34:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5xJC-0007NH-00 for submit@debbugs.gnu.org; Thu, 26 May 2016 11:34:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5xJB-0007N3-Sx for submit@debbugs.gnu.org; Thu, 26 May 2016 11:34:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5xJ9-0007ej-PE for bug-gnu-emacs@gnu.org; Thu, 26 May 2016 11:34:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5xJ5-0007KG-It for bug-gnu-emacs@gnu.org; Thu, 26 May 2016 11:34:47 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:35692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5xJ5-0007IS-7d for bug-gnu-emacs@gnu.org; Thu, 26 May 2016 11:34:43 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 7707D726B; Fri, 27 May 2016 00:37:58 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id 086F0421C for ; Fri, 27 May 2016 00:37:58 +0900 (JST) Date: Fri, 27 May 2016 00:37:57 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: bug-gnu-emacs@gnu.org Subject: 25.1.50; Buffer in >1 window; winner-undo recover window point Message-ID: User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) For users editing same buffer in differente windows it may be useful if `winner-undo' could restaure also the window point from each window. ;; visit same file in 2 windows ./emacs -Q -mm -eval '(progn (find-file-read-only "../src/window.c") (winner-mode 1) (goto-char 1000) (split-window-right) (other-window 1) (goto-char 30500))' M-! ls ~ RET ; C-x 0 ;; C-x 1 ;;; C-x b C-c ;; `window-point' return 30500 value for both windows. ;; You may want to preserve > 2 buffr positions. ;; Following example visits different positions of the same ;; buffer in 4 windows. ./emacs -Q -mm -eval '(progn (find-file-read-only "../src/window.c") (winner-mode 1) (goto-char 1000) (split-window-right) (windmove-right 1) (goto-char 30500) (split-window-below) (windmove-down 1) (goto-char 50000) (windmove-left 1) (split-window-below) (windmove-down 1) (goto-char 250000))' ;; As before `window-point' is not preserved for all windows. In GNU Emacs 25.1.50.3 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30) of 2016-05-26 built on calancha-pc Repository revision: 16be3e90545972dec16014253a843229d5bdf388 From debbugs-submit-bounces@debbugs.gnu.org Thu May 26 12:37:39 2016 Received: (at 23621) by debbugs.gnu.org; 26 May 2016 16:37:39 +0000 Received: from localhost ([127.0.0.1]:40753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5yHy-000745-TI for submit@debbugs.gnu.org; Thu, 26 May 2016 12:37:39 -0400 Received: from calancha-ilc.kek.jp ([130.87.234.234]:49063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5yHw-00073p-C8 for 23621@debbugs.gnu.org; Thu, 26 May 2016 12:37:37 -0400 Received: by calancha-ilc.kek.jp (Postfix, from userid 500) id 01936726B; Fri, 27 May 2016 01:40:47 +0900 (JST) Received: from localhost (localhost [127.0.0.1]) by calancha-ilc.kek.jp (Postfix) with ESMTP id DF944549A; Fri, 27 May 2016 01:40:47 +0900 (JST) Date: Fri, 27 May 2016 01:40:47 +0900 (JST) From: Tino Calancha X-X-Sender: calancha@calancha-ilc.kek.jp To: 23621@debbugs.gnu.org Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (LRH 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 23621 Cc: Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Allow users editing same buffer in diferent windows to restore the window point with `winner-undo'. This report is related with Bug#4041: the behaviour of `winner-undo' just change if an user has set the option `switch-to-buffer-preserve-window-point' non-nil. Following patch restore the buffer point from deleted windows in the 2 previous examples (if `switch-to-buffer-preserve-window-point' evaluates non-nil). >From 37c088a3cc0ae303dda570e4d93195131f6a9892 Mon Sep 17 00:00:00 2001 From: Tino Calancha Date: Fri, 27 May 2016 01:27:18 +0900 Subject: [PATCH] Editing same buffer in >1 window; winner-undo enhancement Allow winner-undo to restore the buffer point from deleted windows (Bug#23621). * lisp/window.el (window--before-delete-windows): New defun. (delete-window, delete-other-windows): Use it. * lisp/winner.el (winner-set): Use marker in 'window-prev-buffers' when available and different than the value returned by 'winner-get-point'. --- lisp/window.el | 39 +++++++++++++++++++++++++++++++++++++++ lisp/winner.el | 13 +++++++++++-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/lisp/window.el b/lisp/window.el index bd5275b..7a7f9ac 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -3775,6 +3775,41 @@ window--in-subtree-p (throw 'done t) (setq parent (window-parent parent)))))))) +;; This function is called by `delete-window' and +;; `delete-other-windows' when `switch-to-buffer-preserve-window-point' +;; evaluates non-nil: it allows `winner-undo' to restore the +;; buffer point from deleted windows (Bug#23621). +(defun window--before-delete-windows (&optional window) + "Update `window-prev-buffers' before delete a window. +Optional arg WINDOW, if non-nil, update WINDOW-START and POS +in `window-prev-buffers' for all windows displaying same +buffer as WINDOW. Otherwise, update `window-prev-buffers' for +all windows. + +The new values for WINDOW-START and POS are those +returned by `window-start' and `window-point' respectively. + +This function is called only if `switch-to-buffer-preserve-window-point' +evaluates non-nil." + (dolist (win (window-list)) + (let* ((buf (window-buffer (or window win))) + (start (window-start win)) + (pos (window-point win)) + (entry (assq buf (window-prev-buffers win)))) + (cond (entry + (let ((marker (nth 2 entry))) + (unless (= pos marker) + (set-marker (nth 1 entry) start buf) + (set-marker marker pos buf)))) + (t + (let ((prev-buf (window-prev-buffers win)) + (start-m (make-marker)) + (pos-m (make-marker))) + (set-marker start-m start buf) + (set-marker pos-m pos buf) + (push (list buf start-m pos-m) prev-buf) + (set-window-prev-buffers win prev-buf))))))) + (defun delete-window (&optional window) "Delete WINDOW. WINDOW must be a valid window and defaults to the selected one. @@ -3793,6 +3828,8 @@ delete-window its frame, the last non-side window, or part of an atomic window that is its frame's root window." (interactive) + (when switch-to-buffer-preserve-window-point + (window--before-delete-windows window)) (setq window (window-normalize-window window)) (let* ((frame (window-frame window)) (function (window-parameter window 'delete-window)) @@ -3875,6 +3912,8 @@ delete-other-windows on the frame. Side windows are not deleted. If WINDOW is a side window signal an error." (interactive) + (when switch-to-buffer-preserve-window-point + (window--before-delete-windows)) (setq window (window-normalize-window window)) (let* ((frame (window-frame window)) (function (window-parameter window 'delete-other-windows)) diff --git a/lisp/winner.el b/lisp/winner.el index 9a6f5d5..2a213ab 100644 --- a/lisp/winner.el +++ b/lisp/winner.el @@ -297,8 +297,17 @@ winner-set ;; Restore points (dolist (win (winner-sorted-window-list)) (unless (and (pop alive) - (setf (window-point win) - (winner-get-point (window-buffer win) win)) + (let* ((buf (window-buffer win)) + (pos (winner-get-point (window-buffer win) win)) + (entry (assq buf (window-prev-buffers win)))) + ;; Try to restore point of buffer in the selected + ;; window (Bug#23621). + (let ((marker (nth 2 entry))) + (when (and switch-to-buffer-preserve-window-point + marker + (not (= marker pos))) + (setq pos marker)) + (setf (window-point win) pos))) (not (member (buffer-name (window-buffer win)) winner-boring-buffers))) (push win xwins))) ; delete this window -- 2.8.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 09:44:10 2019 Received: (at 23621) by debbugs.gnu.org; 25 Jun 2019 13:44:10 +0000 Received: from localhost ([127.0.0.1]:58975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflk2-00052S-12 for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:44:10 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hfljy-00052G-51 for 23621@debbugs.gnu.org; Tue, 25 Jun 2019 09:44:08 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hflju-0000SU-AE; Tue, 25 Jun 2019 15:44:04 +0200 From: Lars Ingebrigtsen To: Tino Calancha Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) References: Date: Tue, 25 Jun 2019 15:44:02 +0200 In-Reply-To: (Tino Calancha's message of "Fri, 27 May 2016 01:40:47 +0900 (JST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Tino Calancha writes: > Allow users editing same buffer in diferent windows to restore > the window point with `winner-undo'. The patch looked OK to me, but I'm not a winner user. I've applied the patch and tested superficially, but if this commit leads to problems, please revert the patch and reopen this bug report. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23621 Cc: 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > Allow users editing same buffer in diferent windows to restore > the window point with `winner-undo'. The patch looked OK to me, but I'm not a winner user. I've applied the patch and tested superficially, but if this commit leads to problems, please revert the patch and reopen this bug report. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 25 09:44:13 2019 Received: (at control) by debbugs.gnu.org; 25 Jun 2019 13:44:13 +0000 Received: from localhost ([127.0.0.1]:58978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflk5-00052j-9Z for submit@debbugs.gnu.org; Tue, 25 Jun 2019 09:44:13 -0400 Received: from quimby.gnus.org ([80.91.231.51]:49852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hflk3-00052Z-4z for control@debbugs.gnu.org; Tue, 25 Jun 2019 09:44:11 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hflk0-0000Sg-JD for control@debbugs.gnu.org; Tue, 25 Jun 2019 15:44:10 +0200 Date: Tue, 25 Jun 2019 15:44:08 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #23621 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 23621 fixed close 23621 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23621 fixed close 23621 27.1 quit From unknown Tue Jun 17 22:22:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 24 Jul 2019 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 22:46:12 2020 Received: (at control) by debbugs.gnu.org; 24 Apr 2020 02:46:12 +0000 Received: from localhost ([127.0.0.1]:56131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoLz-0000TD-Cv for submit@debbugs.gnu.org; Thu, 23 Apr 2020 22:46:11 -0400 Received: from mout.web.de ([217.72.192.78]:36713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoLt-0000SR-Jd for control@debbugs.gnu.org; Thu, 23 Apr 2020 22:46:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587696359; bh=6aIFnHOMZ2R1JW+ZG5ml81aPahHnSFc/2RGh/v1j88U=; h=X-UI-Sender-Class:From:To:Subject:Date; b=liJq5HNR2qJKln4W5R8gd6IsoOE4+cdp/ZPWUL0LzzuMiK0oHTRt7buW2OadtQeWv keRdiU5JPEpQcS7Wpg6F1XdwGc9YpLQSi7nmnDt7tizNe3qJIQhj3WRyaGhjPuOU7J b9hs+dGwSzFKCbTNXRF/dFXrGqoEGJi+zxi7JRfg= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0MKrU4-1jRoLm4848-0007I5; Fri, 24 Apr 2020 04:45:59 +0200 From: Michael Heerdegen To: control@debbugs.gnu.org Subject: unarchive 23621 Date: Fri, 24 Apr 2020 04:46:01 +0200 Message-ID: <87k125mwie.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:pkTbnGePqeYbq9AnB5XTNudQ7cissNN4uaT/P1FhSOOxh8qZINr dDi4rGJ0fUOZqfUfdbWswzN47aIQSw8AdKs6AVsY2500iHpNf9Bd5L1zQ2OrXC+uhRPJ7Wm s3oPtC9zSfIskaLPd/yQt25JGxfmQf9gJWzUknA24Rklt9/UWXGkj75IM60Bvai6PUoYEz3 cpL2Ekaj9SF2pJJpE5lAQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:e/Ar397TyOw=:bLmHtC4Ry2yk3vcNRAKn+d e7YNqsOVWLBxRalRnC+hViujKxtaC9wX1lq7jzDlBlQ/qloWjvyOOYJl5iSsdcsjCyP4sJLmT yf0PyzI1wuKYiQaHam636+VVdZF456pumRsFCU96Od4iayQgd6nkkPaLcyk/kOIZLDC/de63U ZheCwSZi5JXxUdmTpzTghkO3dSP3tqVwbtqq7iFAbFV26CSbNBHHNl5+ZdWPnDIXff5JKZEN7 JVd7d33FSmcJhxDN0W44A/ESLLe0//9Sq4yRjUwIZpiQ+U8PvlU9eZMKhmA/qts3HpYEnWZUl tiOPu/K9I/ZJZoGvWpjpoZ5qjYEuA5I4CkAaYmKIGmfr+ZdLxF+smgiSZ5Zxfh3MTbaWrYMhA 9yTF/CEGJzUFXPqnKyiHtvYGmcNG/n5FtchVWyD4W1B+KrxsVAttEK0O4mmaaUWb4RrttW4Ku JmaiS0gAJehteqzIw1BcNmI+2/aK+e/P4OSS2VtaxlTUwmC6eh/pl6BulfTR4eiflGYqfjsjg KHh5t4syrM4cUaPn+/msZNjRzW/tdStMPygAsL0M38g9ksel3vjtu3l+0e5/GVofcRQi2Wg0l Bv78VkgL0Ej4Pc2mHZa1Gk9Sn7Zw/j3m8JIINFEVBUBmUD7jXttANwjhbrBSXO5eEGaPU2ahu MOYsnOMpoPOFyIAX1Mc2S53sjjL053JsqEoqWY5oNWs39rR4xTNC+1nh8JJcwnu7FUSDs2Unt Pl5ObupEVaowpJDt4cNa+yRfEOPCTiLT2hwwGJKaMB4irC46C43I3Rc0fuRvsEndQrBldx8DD NeZJTVR4QqBfM+Nq48eym0lYt2i96T9lvFZG93bGZF3/ZZ0NXnFgmQpzH6mYcKef+SjIAusYQ p2NLvFUcSAvi5qFQy6nmbkfzZ5jEbkg9D+iFBBt9al3LvArtXvXbUhg/EWUqrezxRaJEI47yQ XRld9lC4NDIsYWY0JdMvQZ6/u6Pt7CxY+VgsN1zympfHxlf2w4V1ykLvE568F2eMCU0GYFEGJ JIolyYlB/Cz6UCZQpitUbzWTiA9fbgogofArWW7EfDhLbPuVOsDab4HTI13fY+wur4av1Gacv RyyXwtAD3HO+nmwlT0CIeZkbQn8CyvtaAOJoKaTXIakofTodUlvyiZJm6cGnK6057tSkB643T i+ulmx5hgOaWD3CzQq/AJFBlo8xZFGX88pi1sEd41k3zDFkhVdNKZFIL5sdId81YnUhb80rtd 2K9oYTR9dq21iUVbY X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) unarchive 23621 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 23 22:55:14 2020 Received: (at 23621) by debbugs.gnu.org; 24 Apr 2020 02:55:14 +0000 Received: from localhost ([127.0.0.1]:56136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoUk-0000kW-AW for submit@debbugs.gnu.org; Thu, 23 Apr 2020 22:55:14 -0400 Received: from mout.web.de ([212.227.15.3]:47507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jRoUh-0000k9-Sb for 23621@debbugs.gnu.org; Thu, 23 Apr 2020 22:55:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587696904; bh=Hr+ANAUulAfm3SDdv81CHdgQGFKau89fqA2pySgrprQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:Date:References; b=HN8HV+6bLCt0lwBhqJJAkOgjx7M64T1FvtiCM07ZeyGLwann/rZyp+9BykwwnCVzm dMEwyvWtmCdSHICHAyYTh/ZIf17tFPKWNsHatLJHQUakdtVWR9N4HYfJupAXE4R0I9 y7b2400uhamwM2XfxrmYNfxDH6UyIQ5Yf2tLCIFk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MQ5zf-1jVvER230N-005Li0; Fri, 24 Apr 2020 04:55:04 +0200 From: Michael Heerdegen To: Tino Calancha Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) In-Reply-To: (Tino Calancha's message of "Fri, 27 May 2016 01:40:47 +0900 (JST)") Date: Fri, 24 Apr 2020 03:45:56 +0200 Lines: 14 References: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Message-ID: <87eesdmw39.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:QRnwPtpQhiVQYsCgNqVae6Y6mbOdGNbzKkk6riAAcYvw8k65/At j6OMhsFunJRnNIfMIaGMf6vZXCsQlKvrZTr18gAuu7MSb5w4T0yCz8OJ0KLdWEDUAOv4c95 RthuBuGA4xHw5tgvCp0pBqHNkXNXSUuZ6y7R7dIXyTVDwrqZ7hHYKNXTUiltYVER5BMqxih USoGlQJU2jwlXU0P0M7Kw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:cW/AgorffpU=:oVuUwCuNrdIo5ZEi7PSC7d EcWKxRnY8+KRCBdEC30BctFhRX2y60s3pgOrK/kb0XDMfN192KrTGgkClAUpusocvu6DaUbyV qgw1oCbeTVfOlRhsLkmiY4rBT9VhiH5AsZcKlxKM4CQ/RCYfuZNQgDfORLAiRSaBMQ2SjCNb3 qiFrK/7kXVAcgvFT6ZgVmn1a2OxVZ48M2lin64HPDqn8XOdBBxpNDxTf78CxmTK6I2mgz2my1 lcK3vZxsCTrV+63x01rrxVI3jXIGsCizBR/8DSZ5gxx5HdRvwvcPEzGHcmP6vuFI1at9ooIcy tRWb6N1TSwhp/tytlKDlwckFUyFrXkz6u1E1Lio4JtU3x/eZfV3I4x4aSyD1YRcCjFFXxQd/k 7PwjBlhAI4vdf7+HOsrSihiW/ztBIfbUwHRgiWQzZowWNNU22U7UVOxBW+fW1F76TNzb2jZLy ZhM0Kuiy/So46t8ZGkPNoAZo2xTsTxuXFAa3YI8BuJ+ZAPy2VTG+0XtLXdkP9fErDeh+GcoBT PbEqHwOddEnScJZ0dS34TZ+fxKhAriw1q8jKiBp9HLaianyXfFzaOfr9Ki9xYdhvTng49/KFu 0XIjHkTqUxwbRZav3aZsijoluAMh8YD87rTTXFAsD8pEPeS3dE7dVMkBLa5nxYAFYx9+kg+L9 FhypRfxjIrUAh3HP6ylxk8u0EQRQ6uFcM+/qcOzgKY8GpXpa/vb5+/2z5Nm+UNcLOGiatlrP3 O442KvTO6IqyQAV6pG+ntmihq8g7869uXlmrj8vmuXraIrE602BDwjPK+OOvn7nqgh2Hix1db kkbqPgZhShsjEb6S1pJPOkbbUtXP5soIVjwJHdx9Xcw6sL3+Zy8TmqfRm0kJzslWKz14pue5e 5r5NcCT+cKVlLi5I0NlsL3qljLrzyuB0qCqEz1YSFlG4MNmu6QUOvjY5/IejPCgx/y5QaWeL0 O97feDMbRWxizTfRa8p5P7e43EV6tJ+K8tW4Os3vlhXIXGs/sIcVPdvpyqghkcbPZ11oBqoyY 0nFa73jGkuqKT1Re6pQ66+lGpZreVpRVFBNgfeMysVHv+Y2rsle7pgh545igUf4S559rUxlzn hb3fCkcXsZ4Q6YyBiP5JXQebR+ZlfATiIR/xnJntHG/CmXh/IbUOWpNKSqSJ5UN7XYj3eHOsX 5W1P5G8h+v9Vt0563AOj+JjsLTFiJ0iJ3fOH78E5k2ZiXfYDk8Hzie+o+dbCJWapUCGc4VCph dDepDhBpUKLLuwfGx X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23621 Cc: 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Tino Calancha writes: > Allow winner-undo to restore the buffer point from deleted > windows (Bug#23621). > * lisp/window.el (window--before-delete-windows): New defun. > (delete-window, delete-other-windows): Use it. Seems your patch works only partially because it actually changed `minimize-window' instead of `delete-other-windows'. Was it by mistake? I also have a question: why do we need this at all? Is it because the window configuations saved are pushed when e.g. a window is split, but only afterwards the user changes point etc, then a window is closed, and when that's undone, without the patch, the originally saved window configuration contains the initial, useless positions, because the snapshot had actually been taken "too soon"? If that is the case - we now have `compare-window-configurations' that compares modulo value of point and such. Wouldn't it be simpler to teach delete-window e.a. to update the head window configuration in the frame's entry of winner-ring-alist with the current version before a window is deleted? TIA, Michael. From unknown Tue Jun 17 22:22:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 27.1 and reopened. Date: Sat, 25 Apr 2020 03:28:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 27.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 24 23:27:51 2020 Received: (at control) by debbugs.gnu.org; 25 Apr 2020 03:27:52 +0000 Received: from localhost ([127.0.0.1]:58321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSBTr-00020T-Kc for submit@debbugs.gnu.org; Fri, 24 Apr 2020 23:27:51 -0400 Received: from mout.web.de ([212.227.17.12]:49219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jSBTp-00020F-2j for control@debbugs.gnu.org; Fri, 24 Apr 2020 23:27:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1587785263; bh=7+iJXUPkXPf0VF968wmZso/ftW4HEXGhoIITkq2/7mE=; h=X-UI-Sender-Class:From:To:Subject:Date; b=LwlrnuvWtYdrPUHFUNILg2xpbuFtS9n806/YYKNDrdTQhqrLo/bcNqSl/F6CE3+3Y Iemf6rH7IM23CuXGuvCnkM2AZaCx//Kg8XmvZp/OgltZAmshSAkovvw6mqKj9yku5u KBRLFKUlOv8Y78FnG9du64AVFDa4pSlFNwVaa2VQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.98.99.7]) by smtp.web.de (mrweb101 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M2uj4-1jB3pg3QEI-00seEY for ; Sat, 25 Apr 2020 05:27:42 +0200 From: Michael Heerdegen To: control@debbugs.gnu.org Subject: control message for bug #23621 Date: Sat, 25 Apr 2020 05:27:41 +0200 Message-ID: <87pnbwckia.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:J4pnERTc0gj3lBmq2n9GaCOz5looEERrxkmKnXZOfVUgZ5U0rl1 K+qp/O4hF9yvTgIRwWmpGOF2VqN/HSHKND/x60E5Gjna6VbgsvSADVyLKEFiDRYzEk1FxvD m+HP2fEVpyzEZ71UJSR0AcG+4GVY0HQlGe3A/es/W2CmN/CYhWSfNOgnmyp6mojhV3lOXQD WDbf+p2ZW7Vq/Zbl5p+8w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kdQf54Jxfw4=:yh/8sB9eGtmsvombaWURZA nfcxYvNlV8fCwLCAN2evfjw2zF8NxxdpLY65CDQKIGfU46xaWfoONVk61YDc5ynA6MGGzwmPb lG5f09yw4l8/daWAi5wZqwEKX24DQHn8CZLXLGIE9E5AbZKVJF2XLSweOzl74Ie3hp4JbAinH P5KPTLek7L/Dg9kKk2pvlJnIcAgucd+N6yDS+1SmhffIHjnbeGSJv+B7PcNP2pCm5cnOimFF+ eIeFfazrA6QuWWCJkhZ6wygfTpgeZXVS57ONCqI2ZXYBf7kp8KHeiEQUF6m5DCSNESRAfcfIm D8TABicL4Uqjk2IuZFochsY40nrJ7OR3ofj9sMcNOn5JIS02I3YdCyhOSRaKwCHzfFI02AUDA rvVkQkNMiz4qu0yLXVYz/Bw+cDvGS5UZCPP9g4jMJCxa2dvuw18+I2Y0vJmwXk8/jxj/mo0qE +RoE/VjsQSoC/OJMTpWEypAaJg+Fv1W4NXMOPBcqakAYi7a2Qjj09eKFgEYOrXHitcrkcYlYQ R99lG+599XvcfIaeNytrPoPkuodvPTx0p7GQM0S6tyLhfisDITiI1z0Q5RbPFMapLwUWifIL3 QGwdSIUHB2G8zHxDUcwYpWcs73tEk5eWygaHjovAY+TLZsIla8fBtmVRvVIaAFK2CyqvuvUS4 Ttbm89KL+4HbiSALGEB5clgRntBXPuJlOHcz6mZE7bLNyw6I/WMxa2Fa7GZ3cv0XTtbSq7PZ2 J/kLImzO4NIME2y4gIag8ODIsCBaHsBqwxuyFoj0YKzzE0fEx4ZT/07nPQ2oD0QAdb9olhLFs H7gRjqOhox4dpyEgtlNa1WkWnxEd5mko2l8JvQxnsG4qzqt19Hwl1O3K/ndnCxVmk/ZXAccHO pFV1MfiBGAJaTmaCeD0pDkc/LYxORV7cKmUPyeHhAQN73ts83W7eYoCws4u2EaEYTwYvCymDG E2RVSbFAd12AtQGnvC/T2whU1RGG5u+W1RiwdxM4y/okVIWPUKypZDywT1r+EOSADa1EVoVRK zSPl9NsR71DUjSGFXoU/dxklgue+YUCYUQ4QYnXXzFBx595OmMzg4bN+TdxlzNPvbHrefFrer 4tmjG/w5NLpr6DwmvedVJS9EwG6z0YeJavzrG0nVIzQYWYIOqnbzQNNIhyLbdvjhbkJyhJjSF gQphiOy3rTIR/bn7FBoEYbjvTb8de4H5LINSLtg2YmsycfOhkDbpa3eQrsynYpb5dTlEy44oe uw1EkEfpPMOsE6yB+ X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) reopen 23621 tags 23621 - fixed patch quit From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 30 22:52:32 2020 Received: (at 23621) by debbugs.gnu.org; 1 Oct 2020 02:52:32 +0000 Received: from localhost ([127.0.0.1]:33594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNohr-0003a7-SU for submit@debbugs.gnu.org; Wed, 30 Sep 2020 22:52:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNohq-0003Zv-Ax for 23621@debbugs.gnu.org; Wed, 30 Sep 2020 22:52:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=6Q1U0hzr0JL6/uHc4sRYPzMkaldKYI22ljopjmdwZXo=; b=kdwUPbwLcEbNvUjFIqCZ99c3JE RZ+/tZztm2SvYVsVnzGCWpT6KuL5bzelTEelU8PcHvLtMMHOHTIOYKbBnVk3wBX/o1jozoHPW8zkT wqzB0FFn39MJDOPzLYd3NCbcb4h/x3aX4S0C31M9ey4rCCkZyseu4IMrfBePoBQcaHKQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNohh-0001Bb-QO; Thu, 01 Oct 2020 04:52:24 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) References: <87eesdmw39.fsf@web.de> X-Now-Playing: Barbara Morgenstern's _Beide_: "Gleich is gleicher als gleich" Date: Thu, 01 Oct 2020 04:52:20 +0200 In-Reply-To: <87eesdmw39.fsf@web.de> (Michael Heerdegen's message of "Fri, 24 Apr 2020 03:45:56 +0200") Message-ID: <87lfgqu07v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: > If that is the case - we now have `compare-window-configurations' that > compares modulo value of point and such. Wouldn't it be simpler to > teach delete-window e.a. to update the head window confi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23621 Cc: Tino Calancha , 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > If that is the case - we now have `compare-window-configurations' that > compares modulo value of point and such. Wouldn't it be simpler to > teach delete-window e.a. to update the head window configuration in the > frame's entry of winner-ring-alist with the current version before a > window is deleted? Sorry, I missed this -- should 0454bfd3313c069ca395f02ab6f377a17ff44965 be reverted? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 01 18:40:36 2020 Received: (at 23621) by debbugs.gnu.org; 1 Oct 2020 22:40:36 +0000 Received: from localhost ([127.0.0.1]:38684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO7FY-0007og-Jo for submit@debbugs.gnu.org; Thu, 01 Oct 2020 18:40:36 -0400 Received: from mout.web.de ([212.227.15.4]:49187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO7FT-0007oR-U2 for 23621@debbugs.gnu.org; Thu, 01 Oct 2020 18:40:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1601592021; bh=kv+J0337Qk81UC+VydPRA4ZJCbGndwP4EMxw7+Q8Imw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Lbqgd75M6N0tC6pQkbQndEV5HEr28Oepqeu7CuLGgCvQz7IZ9RhNveISlmueiaZpN z+iBHNJ2F7RzJZ02tcbH1kjsuJI/9SE7mnMxKDv+kdpebXXsqMjd7l69Q5KFplTOVo 8IlM8/q9b2P9i7wkDWX/8MuL8REetd7vxPnExJ7Q= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([94.218.220.78]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LfzgJ-1kmBSx3FRD-00paVx; Fri, 02 Oct 2020 00:40:20 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) References: <87eesdmw39.fsf@web.de> <87lfgqu07v.fsf@gnus.org> Date: Fri, 02 Oct 2020 00:40:19 +0200 In-Reply-To: <87lfgqu07v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 01 Oct 2020 04:52:20 +0200") Message-ID: <87a6x5o9ik.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:wD6lvCQSfvwQByUbQsc5fpDYlBsCN46JQIc/P7bKLxht6MZCqNL CC1qCfYYYDV5KxGFmiIvO1w+7OTepGIgqHEcmB5MY8/gcxaLezAoEvE1BnME0XoWvIGx7ji RUNccVCi8NP9peLgqNtyTcbQw9/yihgoZPR7r7zl1/FN3/qshHdFPpx0bdqcFJ1MhTc8zFd JnafYwQV81DwjvS1+/ddQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8O/62ODaK30=:lQSBKtCsq3v/lFbWGPwjxq GZmqsNnCVhEG4XfAaa1PD+i4n/yMTtlCDgEzUdysXwzR/jC+DLjvP+1AgrWoXxYNwqDLV3Zd1 2IWYIRKdbvmP4PPpGKpAJOPld5Z69vfkj3hNoPp0bOB93F7Pud34wA+iLBAmActWRu06qe13o AcgvAHZGq+WQ70qvIn9nYGQgfakWoRtSVc6x29vOHWdPNFvTRjDpIm9YaokV0+9Jbk4BDLM1W NXm9wh+nqFBjl0ORmz9JwmSr8NwV2gagsS23UB8vDtZQu4czgvtKUBXrQ7X9fRgI0EeMU+za1 JfIXQU0vzi4R6xvYB9gj1/R6KQ6bFhcjz1TZcbLYb6DwQ62eBnseRT04Kt3kxwfSKXP7ZWntB 753mp/w1fOpWurHL77EvuinAzCRudXgrWUZohAWiwyK1plGMS8MTh9Yl0ppDidzoJzk6FwkOP 30ftsIWISlb63ksmkXClYaXpBgADnOnIp0r2a5t2kx6tpogaJh4Vglxq1PIO+QTn+orZGyrzc 0MWq7oaAyLOqZ4JX2V+4zcO2/VYGgicPx7KYxOzGLKnFKsh0b0FR/LfZiOvzDtut2nQvPJs8N FSJGqrmQhe3qM9+2IwYZYJnelUpRlC4U1Y4/UrWE4JcbsdItgcXvzZtsQLwlftXY5HyElM5+E 40DGsKL/bgqnHlgoHMzvrZX36q+wpqEWYQwa5+w8KXDGvnbT3v7PXRD0vVvXh0cJ+NrPYOiOl BpnUmlWaT4/dxw7+k2FtiHLkyDK8FZx4WKhFhMm1CLN9yMYiUj1CeLmZyXLuuCO2NwaOu1Pjz 8HHXDIU7QlwtwKknD2prSe6hAfcJiDpsMCBKIPzHNY27jzyr5oYnsFuDzuVeeNZRrKB0C6OWV nBUgA23uFOPD8wH3msVLdRrGTRWryHkjvgkz7G4Pjv/31ftmAc58+9+gy/SMSzaXfNcKfNv9B FNUkDQ7mkhQAqfkfhDDxYeXses+RQ4HSE0oHYuWxOcGFMTmF8bpjmTiZ2oK2GQjw2vbVzudca sDZ7Z/s23/wq+puJCk6yanmVQxzeA3vJHL0ruFs29AInoXeWutxWI7wvaYtPntWfHXwZP4Mls 4N7ywUIzgNGwVH1qp2Rue/MMRMWxMUJm87ziufW2wQr7WHe/RWtDFAK341DpmCImRtQWpC69V L9F3D+J81l1deN02panVcHUvHMAydO4oobjeERY6JwR8vdqFtM/LvLktlwukOKzKZvr9pMb7m gGjrMy9fQpxFN6UEigJAxpQCQ54de0yboHzpTzA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23621 Cc: Tino Calancha , 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > > If that is the case - we now have `compare-window-configurations' that > > compares modulo value of point and such. Wouldn't it be simpler to > > teach delete-window e.a. to update the head window configuration in the > > frame's entry of winner-ring-alist with the current version before a > > window is deleted? > > Sorry, I missed this -- should 0454bfd3313c069ca395f02ab6f377a17ff44965 > be reverted? I don't know much about this stuff. Would be nice to hear from Tino. Regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 18 11:01:44 2021 Received: (at 23621) by debbugs.gnu.org; 18 Apr 2021 15:01:44 +0000 Received: from localhost ([127.0.0.1]:47404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lY8vg-0002vg-Lc for submit@debbugs.gnu.org; Sun, 18 Apr 2021 11:01:44 -0400 Received: from mout.gmx.net ([212.227.15.15]:42941) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lY8vf-0002vS-B6 for 23621@debbugs.gnu.org; Sun, 18 Apr 2021 11:01:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618758096; bh=giX54k65cG9Q3fzCS6DtZs4VlxO4kbYi44vNFM0WuV8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=aqmEWxtU0o5uDlpPmnhbm1mWbCRRqiZJE5QOnHY/CoMrYdhhrrKgtE1QsvIeEes0a 35Jvco5JPHdwCfexKWH545QdzeZtJ/V3+VDMfjjHJifwZNOVowQgYgKc50FzE4HU2I sgBTT47nrbuxaU0+rF8s+54ojtCnYwBUSV5NGhkc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.1.102] ([213.162.80.178]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mnpns-1lsfqE1a94-00pPGI; Sun, 18 Apr 2021 17:01:36 +0200 Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) To: Lars Ingebrigtsen , Michael Heerdegen References: <87eesdmw39.fsf@web.de> <87lfgqu07v.fsf@gnus.org> From: martin rudalics Message-ID: <111e970b-89a2-045f-9f38-14bfc97a321f@gmx.at> Date: Sun, 18 Apr 2021 17:01:35 +0200 MIME-Version: 1.0 In-Reply-To: <87lfgqu07v.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:wIcaoxXrSQzVGcbyMVbcbfQ31NRO4hsCADF2Ug0gOcbCK+roTsl Wwlq0kw4u1J75V+4XggcItH22lVK5EQEfdXmZwjeHwAok1uG5mga6bGjL7kJpb5KLDEYsPW co+Fraaekm3tCTfEzZudrvTkwacHixBWkWrkHy2bzYCxNDI8MYDV+KRlXvEvexIh+4U4VSB lcbgJAtUqezgVjcT9Q8uA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8GDXLQy/Ggs=:NPKEpYuq2tC8wiNia25b4b t7hOinqoujnNzaB7lWfVN+xtA6Grs7c7uME4NzaIZ3fiuYpcH3L49s1+SBD5k6zkH7i8HWpo5 pyJriZc4/96g0McCFY8OYSrS+xJK+kyB9yfKektCjUok8E9Cf6YCNMV4Bgn/DxV2avDaCkO3L foXkrU+NKFs7JC47eaV40j0Vm+UegGN8HL2dS0ZzSj4wNrtV4bqnLU1VY8WFBoHYonA5xjpAO IAthLsL0VcCqCk9br6hYlOubSnRdtDqu02twbo9N+ILi3toLLgEJEdnpXsIdfGFOdLxpOzjm6 /7xBymKVAZj8zJme/uSmcQOIthqk9HUCFtCcqiHSextWuOlLz6L5xQewGE+ul9BJ1QM2RM66l 8WCnpxpPuKe+V0qn3coxLOXnAx7RBJJFH8yYQ6m0QCeEicAcpCpI74LkJFUhT1Kx6YsSGK2LI 0lu+RUN9KtEl4JmcBsb37WMsUW3ZrhA3y/ow3yEbIjsLiJuB+hrQNI55nV8YYMoZOQ/K6yY6S Dpp+jBnLk7X3UCPY6Y6IG7f2Pu0ui6F7tHE7aJ0ijL6F9TZ/jlGaVpFCwOlVShstF3mbqgO5M f17235xp4TnIv6qE+0YZ9naZXJTzfch75ozHlMLD4JDtg0bwJtxuTfFgsML2dGdHnk9VQrI/c Nn1RCnGfoH2HqE0HjjyOGnCJyocijj/rcYrri81PlD88/yckzGyYqNA8gAmxr3hyMM4QAHfOB s2azbcyDqXDWDIusr49Z0iJv7QV4Xz2kjCuJPyzJbK2qlk9GIGxPUlK2LkjswiE4HU3GwAtUW q7HBo7TG6ucunIbKaOtRetFjcWOa9xXV8kmdsL01+En6puvCNVqvUtK2FYqdH4zOtoNlO9HiN kxVl+YSaU132NeYCq9MdydoaBQNfXT+oHcl2wb/ANQFIYj8ktq6RYzTnwYMue6/B/r2+n/vxM JsWceFTeiSbvavz1bsSAqcGxQUF+Q5v8pZoniKEdHzHo7h36peKzygQIzgXVnkRgqiN62WD13 TcISHN5HqnDwSA2gaXs4eOnuj9Zkmh5WzCqp9GkHePtjTjSGxItlsiURw85Qjnw+HaNOMlAsq V5zyW6nV+MCEu/KqGXb61a9el/PoVEVMm5g3oa4IIhUi/7VDOwQOaF+0cD+srlwoBF2yVDw0q Uw1NnX6CXDfiSHEaFJcGDuZLpCGkQSRqA0P9+y73Orah6bJZRaVbK7V/fmE0DaOFIM/vk= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23621 Cc: Tino Calancha , 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Sorry, I missed this -- should 0454bfd3313c069ca395f02ab6f377a17ff44965 > be reverted? It should be reverted. Calling `window--before-delete-windows' from `minimize-window' makes no sense; it should have been called from `delete-other-windows' instead. But I am not able to tell what `window--before-delete-windows' is supposed to do. And it apparently causes Bug#47461 and I doubt that this is due to `minimize-window'. martin From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 25 13:48:12 2021 Received: (at 23621) by debbugs.gnu.org; 25 Apr 2021 17:48:12 +0000 Received: from localhost ([127.0.0.1]:43668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lairc-0002m0-7F for submit@debbugs.gnu.org; Sun, 25 Apr 2021 13:48:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laira-0002lj-BF for 23621@debbugs.gnu.org; Sun, 25 Apr 2021 13:48:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=YJb83Wkl5XomMp3raJ+ZEY/giVJrqc7GYUeDGsG4eno=; b=BU+R7BP/u5hdDVsEI4FQkE4h7Q 9ATY4PLJSyno+3gpzXjME9BmCX6KNgNAkGgN8o4wvEaSQMnESKzG7UDH4S/O92QQnEJo3Sj7HZKs+ zOBlxsQPV+NB9s7PaeoWazDXdhCXxMfxDDo7bLV34Kwb6KqUInmbSlMqL8v/U4Ry0u2w=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lairN-0000bX-Ts; Sun, 25 Apr 2021 19:48:03 +0200 From: Lars Ingebrigtsen To: martin rudalics Subject: Re: bug#23621: PATCH (25.1.50; Buffer in >1 window; winner-undo recover window point) References: <87eesdmw39.fsf@web.de> <87lfgqu07v.fsf@gnus.org> <111e970b-89a2-045f-9f38-14bfc97a321f@gmx.at> X-Now-Playing: Stephen Mallinder's _Um Dada_: "Robber" Date: Sun, 25 Apr 2021 19:47:57 +0200 In-Reply-To: <111e970b-89a2-045f-9f38-14bfc97a321f@gmx.at> (martin rudalics's message of "Sun, 18 Apr 2021 17:01:35 +0200") Message-ID: <87czuil0he.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: martin rudalics writes: >> Sorry, I missed this -- should 0454bfd3313c069ca395f02ab6f377a17ff44965 >> be reverted? > > It should be reverted. OK; now done. It wasn't a clean revert, since things had changed in this area, so I had to do it manually, and hopefully I didn't mess that up... Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23621 Cc: Michael Heerdegen , Tino Calancha , 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) martin rudalics writes: >> Sorry, I missed this -- should 0454bfd3313c069ca395f02ab6f377a17ff44965 >> be reverted? > > It should be reverted. OK; now done. It wasn't a clean revert, since things had changed in this area, so I had to do it manually, and hopefully I didn't mess that up... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 06 22:10:51 2023 Received: (at 23621) by debbugs.gnu.org; 7 Jun 2023 02:10:51 +0000 Received: from localhost ([127.0.0.1]:53309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6idO-0006zV-W1 for submit@debbugs.gnu.org; Tue, 06 Jun 2023 22:10:51 -0400 Received: from mout.web.de ([212.227.17.12]:33785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q6idM-0006zE-2C for 23621@debbugs.gnu.org; Tue, 06 Jun 2023 22:10:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1686103841; x=1686708641; i=michael_heerdegen@web.de; bh=xxGLwAWjxAbsjACMO1SxNRwF/bgvflgZISb525Qh28I=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=grj1jbtNTfKcgXfcQoLgBCrillGuqci4YOF9PZpD1FPYFVsckOvTYVKTynCDyrmii1cjwB2 dDaoJOJTCJOnsgSbuJdGAuPpnRyA2Vcta5bT2kReqwtvFb/PJ1CO1la9yfjGKqmr/SW8+GuFr PzONEXVAt+FeujKXROHRge5O+1cxbg8ETeqqXC1NvOvCPTjFwfE8Msr4X0hd3ucM12/8nyyYq JQu/CMD7y4vSX63SrqBU+LY9E+dLL/buqT7wHbYO10FJM1BJdF9mvbRZpibE/cHPdcg1cnFhw L16y0p44Cxw9rtRJFPE6DOR2k1bsHs8UoEF8d1pnPgQ4364pvExw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1M91Po-1q0gEB0uoQ-0064hs; Wed, 07 Jun 2023 04:10:41 +0200 From: Michael Heerdegen To: Tino Calancha Subject: Re: bug#23621: 25.1.50; Buffer in >1 window; winner-undo recover window point In-Reply-To: (Tino Calancha's message of "Fri, 27 May 2016 01:40:47 +0900 (JST)") References: Date: Wed, 07 Jun 2023 04:10:40 +0200 Message-ID: <87y1kwowdb.fsf_-_@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:K8kHhq5KVKEcdKnt4U0Uvx4DcOWdGKvRFkX0TNOv/S+W0THugnW UODWuNcELe9qpV1fbRu83PSoFLbq3pxlzWs0RW+ouhA6pqoewBOreXsjmfQA9um7c/nnaMd 1DIvY5AILSbjfwHqguIDDfYJKCkWetvocT2Fqu30mTsEOx1+GCF4gIxpJyMXU3hJMhU/5rg FxHskCF5QHyEQXf4nDJrA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QBPIS2mfvP8=;kWBwRbtsrGwU6kbcRgPgcdC2vD4 v4IQiLYL0zMF4cgGp0S21RZbYAs6XfzeDd9HkcEy3Re9y5+BCxbxuTfQc2ogIj6xjIt+S4Of0 7PiO4S6lgpVYKMOo7pwteJOnbxCOoicA7ydEnubQYtJ9/y2l0UmOm9zEB/x3i/DvoWef5Wa++ dKS2YYJYXvO0Inj4qTfw5NrKUipNKOtXeoIhiRLa1GoG3OYS63LaJH3bm6NcjAnoCp4bKXji5 dG1d6rEUQcZEDQTBDopLwnA+tqUE5Xw+ggJABnwL1NJZbVno05wDnOY7ipVva/V+Rb2gFrnaR ulK2eBTm3S9AaezKZ1JGACFmlRsanwWdPNsb076uV+NT5zHJNmkexfL2s4Grew/VmOhXqWG9W ali7j2yXZLH6hY0qKEO9pbBt75RREVHlJyhOeIUwCIEtbm15v/EcWhynYlBpU99oa5b/kSUHH aO9i61uqMLtZiiwxMiBIgvt/aPaH1yO7MC/nuZRY9Dt0vLU4CxEpCIBUfDHvdE/ZB4WUFxSIG H47YvxyK1KmeVTpc1/KRXM8tVhR0YRHip8vcD+7zvlwBd2+bJVeCXEwPFYppRqd4DfZGHNr29 roz+rxhP7Vh5rbpM4nJfbT+/R0W6ZCvQofeKtdOX7YN2DxNsZFGzl4j3kvy1fCWIRxGdB45HL 3LnUlHotYvErxErD0cWFMTx4ZzW4GOnDJ6HM9aJMXpM82l2iZ08zhQLBDa03Ouo/hj+NMjZLh I8aNDLujzV1xUv65zgxktjTi45Wd7G+Feb2yDTSQOpb2cwqpx+j/oxBOvS1ViewldobBEGmsN sIF6xv8QW6D/AVfM7W06/JJ4aUK/3WNVBRFP8LGUw+vfZT5xIiESNrBf4cLXSwQRXnWhAZw4S kzFKxkA9b+zv1pSLkb9Exj7h3mYZ4Cltx8g88Xy0sfBHYVQew5cuyF4SjZuRDffDy72zXHdre R77UmA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23621 Cc: 23621@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tino Calancha writes: > Subject: [PATCH] Editing same buffer in >1 window; winner-undo enhancement An alternative approach maybe: the original value of point is correctly saved in the saved window-configuration. That you get the same value of point for winner-undo in this case is a result of winner changing point in all buffers to the latest one (of saved buffer window points), AFAIU. Which is ok in most cases, but not when using multiple windows for one buffer: then you want to have the original window point. So, would it be appropriate to change the algorithm to skip changing point to be different from that of the saved window configuration when the displayed buffer is visible in multiple windows in the selected frame? Michael.