GNU bug report logs - #23617
25.1.50; Ibuffer in other window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23617 in the body.
You can then email your comments to 23617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1.50; Ibuffer in other window
Date: Thu, 26 May 2016 00:22:46 +0900 (JST)

Sometimes Ibuffer is shown in the selected window even
though OTHER-WINDOW-P non-nil.

./emacs -Q -mm -eval '(split-window-right)'
C-u M-x ibuffer RET
;; Ibuffer appears in the right hand side
RET
C-u M-x ibuffer RET
;; Again Ibuffer appears in the right hand side,
;; but this time it should appeared in the left.


In GNU Emacs 25.1.50.5 (x86_64-pc-linux-gnu, GTK+ Version 2.24.30)
Repository revision: 1ee91bf89176251f6e399c8436dca0248cdd6f6b

Message #8 received at 23617 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <f92capac <at> gmail.com>
To: 23617 <at> debbugs.gnu.org
Subject: bug#23617: PATCH (25.1.50; Ibuffer in other window)
Date: Thu, 26 May 2016 00:30:01 +0900 (JST)

From 67500ceb4a0ea5923b3b9f2e1fef4161150c7c96 Mon Sep 17 00:00:00 2001
From: Tino Calancha <f92capac <at> gmail.com>
Date: Thu, 26 May 2016 00:22:42 +0900
Subject: [PATCH] Ibuffer in other window

* lisp/ibuffer.el (ibuffer): Use other window when OTHER-WINDOW-P
non-nil (Bug#23617).
---
 lisp/ibuffer.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index dd2687c..d78a8f4 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2341,8 +2341,10 @@ ibuffer
     (setq other-window-p t))
   (let ((buf (get-buffer-create (or name "*Ibuffer*"))))
     (if other-window-p
-	(funcall (if noselect (lambda (buf) (display-buffer buf t)) #'pop-to-buffer) buf)
-      (funcall (if noselect #'display-buffer #'switch-to-buffer) buf))
+	(funcall (lambda (x) (or (and noselect (display-buffer x t))
+                                 (pop-to-buffer x t))) buf)
+      (funcall (or (and noselect #'display-buffer)
+                   #'switch-to-buffer) buf))
     (with-current-buffer buf
       (save-selected-window
 	;; We switch to the buffer's window in order to be able
-- 
2.8.1

Message #13 received at 23617-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 23617-done <at> debbugs.gnu.org
Subject: Re: bug#23617: PATCH (25.1.50; Ibuffer in other window)
Date: Tue, 07 Jun 2016 20:36:16 -0400

Version: 25.2

Thanks; applied with minor change.

Message #20 received at 23617 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: 23617 <at> debbugs.gnu.org
Subject: Re: bug#23617: PATCH (25.1.50; Ibuffer in other window)
Date: Mon, 17 Oct 2016 10:48:19 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Tue, 07 Jun 2016 20:36:16 -0400
>
> Version: 25.2
>
> Thanks; applied with minor change.

Any reason why you cherry-picked that from master to the release
branch?  IOW, why does this fix have to be in 25.2, which is supposed
to b a bug-fix only release?

Thanks.

Message #23 received at 23617 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23617 <at> debbugs.gnu.org
Subject: Re: bug#23617: PATCH (25.1.50; Ibuffer in other window)
Date: Mon, 17 Oct 2016 11:56:13 -0400

Eli Zaretskii wrote:

>> From: Glenn Morris <rgm <at> gnu.org>
>> Date: Tue, 07 Jun 2016 20:36:16 -0400
>>
>> Version: 25.2
>>
>> Thanks; applied with minor change.
>
> Any reason why you cherry-picked that from master to the release
> branch?

It's a trivial bug fix / harmless improvement, which I had marked as
fixed in 25.2, and personally I think such meta-data is important.
It was that or change the bug fixed version, frankly this was less work.
Same for the other two.

Message #26 received at 23617 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 23617 <at> debbugs.gnu.org
Subject: Re: bug#23617: PATCH (25.1.50; Ibuffer in other window)
Date: Mon, 17 Oct 2016 19:14:51 +0300

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: 23617 <at> debbugs.gnu.org
> Date: Mon, 17 Oct 2016 11:56:13 -0400
> 
> > Any reason why you cherry-picked that from master to the release
> > branch?
> 
> It's a trivial bug fix / harmless improvement, which I had marked as
> fixed in 25.2, and personally I think such meta-data is important.
> It was that or change the bug fixed version, frankly this was less work.
> Same for the other two.

If that's the reason, please revert them.  They don't fit the purpose
of the 25.2 release, which is ti be a bug-fix only release to be put
out the door as quickly as we can.

For future reference, I tried to describe what should go into emacs-25
here:

  http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html

No one objected, so I guess these should be our criteria for 25.2.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.