From unknown Sun Jun 22 00:37:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23597: 24.5; `cl-values-list' should not be an alias for `identity' Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 May 2016 00:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 23597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 23597@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.146387676923218 (code B ref -1); Sun, 22 May 2016 00:27:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 May 2016 00:26:09 +0000 Received: from localhost ([127.0.0.1]:60285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4HDc-00062Q-MU for submit@debbugs.gnu.org; Sat, 21 May 2016 20:26:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4HDa-000621-DC for submit@debbugs.gnu.org; Sat, 21 May 2016 20:26:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4HDU-0001f8-DE for submit@debbugs.gnu.org; Sat, 21 May 2016 20:26:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.8 required=5.0 tests=BAYES_50,XPRIO autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4HDU-0001d6-A7 for submit@debbugs.gnu.org; Sat, 21 May 2016 20:26:00 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4HDS-0006gz-0x for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 20:25:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4HDO-0001at-Qo for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 20:25:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:38631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4HDO-0001ZT-Hy for bug-gnu-emacs@gnu.org; Sat, 21 May 2016 20:25:54 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u4M0Pnlh020683 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 22 May 2016 00:25:49 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u4M0Pn6Z010972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 22 May 2016 00:25:49 GMT Received: from abhmp0015.oracle.com (abhmp0015.oracle.com [141.146.116.21]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u4M0PmuM031318 for ; Sun, 22 May 2016 00:25:49 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 21 May 2016 17:25:47 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.0 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Emacs Lisp does not support multiple values for its Common Lisp emulation. OK, fine. But that is not a reason for this kind of definition. `cl-values-list' should at least raise an error if its arg is not a list. That too is part of the Common Lisp definition of `values-list': "Should signal type-error if its argument is not a proper list." (cl-values-list 5) should not return 5. It should raise a wrong-type arg error. A comment in cl-lib.el says this: ;; cl-multiple-value-bind and friends simply expect the target form to ;; return the values as a list. It is not enough that `cl-multiple-value-bind' and friends expect that. They are not the only context in which `cl-value-list' can be used. `cl-values-list' is a general function on a list, and it needs to check its argument to ensure that it is a list. In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32' From unknown Sun Jun 22 00:37:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#23597: 24.5; `cl-values-list' should not be an alias for `identity' Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Jul 2019 12:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 23597@debbugs.gnu.org Received: via spool by 23597-submit@debbugs.gnu.org id=B23597.156431613827771 (code B ref 23597); Sun, 28 Jul 2019 12:16:02 +0000 Received: (at 23597) by debbugs.gnu.org; 28 Jul 2019 12:15:38 +0000 Received: from localhost ([127.0.0.1]:45887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5R-0007Dg-ST for submit@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:38 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5Q-0007Au-7k for 23597@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:36 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hri5L-0003q5-K8; Sun, 28 Jul 2019 14:15:34 +0200 From: Lars Ingebrigtsen References: Date: Sun, 28 Jul 2019 14:15:31 +0200 In-Reply-To: (Drew Adams's message of "Sat, 21 May 2016 17:25:47 -0700 (PDT)") Message-ID: <87v9vmbbj0.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > Emacs Lisp does not support multiple values for its Common Lisp > emulation. OK, fine. > > But that is not a reason for this kind of definition. > > `cl-values-list' should at least raise an error i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > Emacs Lisp does not support multiple values for its Common Lisp > emulation. OK, fine. > > But that is not a reason for this kind of definition. > > `cl-values-list' should at least raise an error if its arg is not a > list. That too is part of the Common Lisp definition of `values-list': > "Should signal type-error if its argument is not a proper list." > > (cl-values-list 5) should not return 5. It should raise a wrong-type > arg error. I agree. I've gone through the Emacs trunk to see whether tightening up the definition would lead to any problems, but all the usages are on the form (cl-multiple-value-bind (tree header tree-buffer) (cl-values-list (ebrowse-choose-tree)) which would already bug out if what's returned is not a list. So I've now made this change on the trunk. In the unlikely case that this leads to problems with out-of-tree code, we should be open to reverting it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 28 08:15:43 2019 Received: (at control) by debbugs.gnu.org; 28 Jul 2019 12:15:43 +0000 Received: from localhost ([127.0.0.1]:45890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5X-0007JL-52 for submit@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:43 -0400 Received: from quimby.gnus.org ([80.91.231.51]:54988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hri5U-0007GT-Rv for control@debbugs.gnu.org; Sun, 28 Jul 2019 08:15:41 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hri5S-0003qC-9I for control@debbugs.gnu.org; Sun, 28 Jul 2019 14:15:40 +0200 Date: Sun, 28 Jul 2019 14:15:37 +0200 Message-Id: <87tvb6bbiu.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #23597 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 23597 fixed close 23597 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23597 fixed close 23597 27.1 quit