GNU bug report logs - #23595
25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)

Previous Next

Full log

Message #98 received at 23595 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: oub <at> mat.ucm.es, 23595 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff
 fails (HG, Git, RCS)
Date: Wed, 25 May 2016 19:27:00 +0300

> Cc: oub <at> mat.ucm.es, 23595 <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Tue, 24 May 2016 23:19:05 -0700
> 
>     - Like Eli pointed out, (coding-system-get coding-system-for-read
>     :ascii-compatible-p) should work about as well. Why doesn't it?
> 
> It doesn't work for EBCDIC.

It's easy enough to exempt EBCDIC (and any other similar encodings).

>     - Shouldn't that change be in vc-coding-system-for-diff?
>     - It seems to try to fix a separate issue (whether all files use the same coding
>     system).
> 
> Yes. For emacs-25 that's probably too much, as you suggest. So we can fix the problem in vc-coding-system-for-diff. Revised (more-conservative) patch attached. 

That patch relies on subtleties of comparing unibyte and multibyte
strings, so I don't like it, even if we ignore the issue of computing
something whose result is known in advance.

I still think we can come up with a simple (and safe for emacs-25)
method of identifying the problematic encodings, and leave the general
issue of having a new attribute for master.  Can we have a patch along
those lines, please?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.