GNU bug report logs - #23595
25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)

Previous Next

Full log

Message #95 received at 23595 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: oub <at> mat.ucm.es, 23595 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff
 fails (HG, Git, RCS)
Date: Wed, 25 May 2016 19:26:06 +0300

> Cc: oub <at> mat.ucm.es, 23595 <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> Date: Tue, 24 May 2016 23:19:01 -0700
> 
>     ascii-compatible-p is not the right test,
>     the right one is mime-text-unsuitable-p; and the test should be
>     reversed, i.e. this:
> 
>       (coding-system-get CODING-SYSTEM :mime-text-unsuitable-p)
> 
>     should return nil for CODING-SYSTEM to be usable.
> 
> Better, but this wouldn't work for coding systems like ebcdic-us, which are so incompatible with ASCII that messages like "Binary files differ" would turn into gibberish. 

It's easy enough to exempt EBCDIC (and any other similar encodings).
There are only 3 of them, AFAICS.

> We could establish a new coding system property for "close enough to ASCII that most people won't mind". That would be a more-intrusive change, though. For emacs-25 I thought it'd be better to have something that is more self-contained. 

A :mime-text-unsuitable-p test augmented by a list of additional
coding-systems we find unsuitable is simple, self-contained, and safe
for emacs-25, IMO.  For master, we could add a cleaner, but more
intrusive fix.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.