GNU bug report logs - #23595
25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Eli Zaretskii <eliz <at> gnu.org>
Cc: oub <at> mat.ucm.es, 23595 <at> debbugs.gnu.org
Subject: bug#23595: 25.1.50; file with chinese/japanse chars, vc-diff fails (HG, Git, RCS)
Date: Tue, 24 May 2016 23:51:33 -0700

[Message part 1 (text/plain, inline)]

Dmitry Gutov wrote:

> - Shouldn't that change be in vc-coding-system-for-diff?
> - It seems to try to fix a separate issue (whether all files use the same coding
> system).

Yes. For emacs-25 that's probably too much, as you suggest. So we can fix the 
problem in vc-coding-system-for-diff. Revised (more-conservative) patch attached.

> - Like Eli pointed out, (coding-system-get coding-system-for-read
> :ascii-compatible-p) should work about as well. Why doesn't it?

It doesn't work for EBCDIC.

> As an aside, how did you manage to create a patch that's using tabs for
> indentation, with indent-tabs-mode bound to nil in .dir-locals.el? That's
> troubling.

I override that setting, as I find it annoying in too many cases. It's just a 
minor annoyance, but there it is.

[0001-Fix-vc-diff-problems-with-UTF-16.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.