GNU bug report logs - #23574
24.5; Overzealous underlining in emacs-nox

Previous Next

Full log

Message #73 received at 23574 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 23574 <at> debbugs.gnu.org, martin rudalics <rudalics <at> gmx.at>,
 Colin Woodbury <cwoodbury <at> azavea.com>, John Mastro <john.b.mastro <at> gmail.com>
Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox
Date: Tue, 7 Jun 2016 22:52:25 -0400

On Tue, Jun 7, 2016 at 11:55 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
>> Date: Mon, 6 Jun 2016 20:18:06 -0400
>> Cc: Colin Woodbury <cwoodbury <at> azavea.com>, martin rudalics <rudalics <at> gmx.at>, 23574 <at> debbugs.gnu.org,
>>       John Mastro <john.b.mastro <at> gmail.com>
>>
>> I think it makes sense to not do the face extension by default.
>
> Not even for the background color?  Or are you talking only about the
> underline?

Well, I was thinking mostly about underlining, but imagining a
scenario with paper again, if I'm highlighting text with a marker, I
wouldn't go to edge of the page there either.

For some applications, the intention is to colour a whole block, not
just the text. So I think it's better to let the code making the faces
have a way to indicate which scenario is intended rather than relying
on user customization.

>
>> For the case I mentioned earlier, magit isn't actually underlining
>> text, it just wants to make some horizontal lines. It would be nice to
>> have some way to ask the display engine to do this directly.
>
> There's a way of doing that which we use in the VC commit log buffer,
> I believe it uses the line-height property.  (I thought magit was
> using that as well, no?)

Yes, and it caused some problems with cursor movement that you weren't
so happy about fixing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.