From unknown Mon Jun 16 23:42:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#23574 <23574@debbugs.gnu.org> To: bug#23574 <23574@debbugs.gnu.org> Subject: Status: 24.5; Overzealous underlining in emacs-nox Reply-To: bug#23574 <23574@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:42:04 +0000 retitle 23574 24.5; Overzealous underlining in emacs-nox reassign 23574 emacs submitter 23574 Colin Woodbury severity 23574 normal tag 23574 notabug thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 13:10:43 2016 Received: (at submit) by debbugs.gnu.org; 18 May 2016 17:10:43 +0000 Received: from localhost ([127.0.0.1]:57163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b34zb-0005Bq-5N for submit@debbugs.gnu.org; Wed, 18 May 2016 13:10:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b34sn-0004yw-Oz for submit@debbugs.gnu.org; Wed, 18 May 2016 13:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b34sg-0007Md-He for submit@debbugs.gnu.org; Wed, 18 May 2016 13:03:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42317) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34sg-0007MW-E5 for submit@debbugs.gnu.org; Wed, 18 May 2016 13:03:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34sY-0005Fm-KT for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 13:03:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b34sV-0007Hb-8p for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 13:03:25 -0400 Received: from mail-io0-x232.google.com ([2607:f8b0:4001:c06::232]:34773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b34sU-0007G9-QJ for bug-gnu-emacs@gnu.org; Wed, 18 May 2016 13:03:23 -0400 Received: by mail-io0-x232.google.com with SMTP id 190so73374193iow.1 for ; Wed, 18 May 2016 10:03:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azavea.com; s=google; h=mime-version:date:message-id:subject:from:to; bh=H8lrThNpW+//a3VqAMr0Kb6T9XJ6Cozac4BbzWxsKEc=; b=ZlIyISTOtK7pF1dfEJihSNWJryE03i2R9aRZb+cPoAtEydWz/8ZtPTRj/fcoMvAFrN /oCVztciDdTligKAeMkLun5+7bbUBTgGzlOAfAdMZUNjVlMiTZudz3uKWyfLRd6tInVQ DeNNZMSks+G0zV6Nq0IBmW5g3Cjd6xC7JYFbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:date:message-id:subject:from:to; bh=H8lrThNpW+//a3VqAMr0Kb6T9XJ6Cozac4BbzWxsKEc=; b=hK9HSvRdKLBCgdKJ0NwH5Asg5Q7VLkmPxj5jgWmQySsmlSI7SSfEkkxE2AZMYFw8Ws iQ87BbR3Y7PSv44+gKxtRxZeVQgc5Zw3axb7ZQUbdSFPRB0xXVa3IRdFlqFSBUiNd9Zp q2mmKYFQAPWGaDNIz/I9BHd5TFjOb+wryyEcpMer5bG2xl2EjLNCOTQYs1p3sUkMN99o sksO0JlvYxy3dVrrDtudWQvub5TAVcXqmCfFd1PcthD06Q0qZUOkdZOYF+d+kLq7cefg sQd3cogXwr5lfLQd+DX0pwce6w9wm1tJrAedsWGWeZN22IdGyAWOsAUfuBLLnIc4OL38 mStg== X-Gm-Message-State: AOPr4FXw2cz9nrxw9o359LmUIsysdEP8WDFBUWIpVj4pRDhGGTEXy9rd4kddmiMVkh/YYwxGRf0kHGnzECpxchlz MIME-Version: 1.0 X-Received: by 10.107.2.70 with SMTP id 67mr6360270ioc.70.1463591001576; Wed, 18 May 2016 10:03:21 -0700 (PDT) Received: by 10.107.6.65 with HTTP; Wed, 18 May 2016 10:03:21 -0700 (PDT) Date: Wed, 18 May 2016 10:03:21 -0700 Message-ID: Subject: 24.5; Overzealous underlining in emacs-nox From: Colin Woodbury To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=001a11396814bf158b053320d52f X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 18 May 2016 13:10:42 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --001a11396814bf158b053320d52f Content-Type: text/plain; charset=UTF-8 I use ensime for Scala editing, and I've come across a strange display bug which is only present in `emacs -nw`, `emacsclient -nw` or just `emacs` from the `emacs-nox` package. It has to do with some very jarring underlining that occurs during ensime's "semantic highlighting". The issue does not occur in normal GUI emacs. I've contacted the ensime maintainers, and while they can reproduce the bug, they claim it isn't an ensime problem. Hence I'm here. The ensime bug report (with pictures and instructions to reproduce) can be found here: https://github.com/ensime/ensime-emacs/issues/440 Thanks for any help you can give. In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu) of 2016-05-01 on svetlemodry System Description: Arch Linux Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --without-x --without-sound 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Scala Minor modes in effect: yas-minor-mode: t company-mode: t diff-auto-refine-mode: t ensime-mode: t helm-mode: t shell-dirtrack-mode: t async-bytecomp-package-mode: t electric-pair-mode: t tooltip-mode: t electric-indent-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Wrote /home/colin/*message*-20160518-095148 C-c k is undefined C-c C-n is undefined Mark saved where search started Quit ENSIME server starting... Connecting to Swank on port 38005.. Connected to ENSIME speaking protocol 0.8.20, please wait while the project is loaded. Initializing Analyzer. Please wait... ENSIME ready. Colin, this could be the start of a beautiful program. Load-path shadows: /home/colin/.emacs.d/elpa/helm-20160517.202/helm-multi-match hides /home/colin/.emacs.d/elpa/helm-core-2\ 0160516.2343/helm-multi-match Features: (network-stream starttls tls ido vc-git ensime-company yasnippet company pcase scala-mode scala-mode-prettify-symbols scala-mode-imenu scala-mode-map scala-mode-fontlock scala-mode-indent scala-mode-paragraph scala-mode-lib image-file misearch multi-isearch shadow sort mail-extr emacsbug message idna rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils winner helm-command helm-elisp helm-eval edebug eldoc help-mode org-clock diary-lib diary-loaddefs cal-iso org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view jka-compr image-mode image org-bibtex bibtex org-bbdb org-w3m org-agenda org org-macro org-footnote org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs server ensime ensime-sbt sbt-mode sbt-mode-rgrep grep sbt-mode-comint sbt-mode-buffer sbt-mode-project sbt-mode-vars ensime-http ensime-ui ensime-semantic-highlight ensime-doc ensime-search ensime-undo ensime-startup ensime-refactor diff-mode ensime-popup ensime-notes ensime-model ensime-mode ensime-inspector imenu ensime-goto-testfile ensime-editor popup ensime-debug gdb-mi bindat gud ensime-stacktrace ensime-inf ensime-completion-util scala-mode-syntax ensime-config ensime-util ensime-client ensime-vars s ucs-normalize hideshow arc-mode archive-mode dash url-gw ensime-macros cl haskell-interactive-mode haskell-presentation-mode haskell-collapse haskell-process haskell-session json haskell-navigate-imports haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-compat haskell-complete-module noutline outline flymake etags dabbrev haskell-customize helm-mode helm-files rx image-dired tramp tramp-compat tramp-loaddefs trampver shell pcomplete format-spec dired-x dired-aux ffap thingatpt helm-buffers helm-elscreen helm-tags helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-grep helm-regexp helm-plugin helm-external helm-net browse-url xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source gnus-util time-date mm-util mail-prsvr password-cache url-vars mailcap helm-utils compile comint regexp-opt ansi-color ring helm-help helm-types helm easy-mmode cl-macs gv helm-source eieio byte-opt bytecomp byte-compile cl-extra cconv eieio-core helm-multi-match helm-lib dired helm-config helm-easymenu edmacro kmacro async-bytecomp advice help-fns async cl-loaddefs cl-lib elec-pair info tool-bar easymenu package epg-config tooltip electric uniquify ediff-hook vc-hooks lisp-float-type tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify multi-tty emacs) Memory information: ((conses 16 493230 27709) (symbols 48 45671 8) (miscs 40 936 1876) (strings 32 102177 15065) (string-bytes 1 3052221) (vectors 16 60425) (vector-slots 8 931107 9519) (floats 8 234 1600) (intervals 56 2997 0) (buffers 960 37) (heap 1024 48683 1909)) -- Colin Woodbury Geotrellis Team @ Azavea --001a11396814bf158b053320d52f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I use ensime for Scala editing, and I've come across a= strange display bug
=C2=A0which is only present in `emacs -nw`, `emacsc= lient -nw` or just `emacs` from
=C2=A0the `emacs-nox` package. It has to= do with some very jarring underlining
=C2=A0that occurs during ensime&#= 39;s "semantic highlighting". The issue does not
=C2=A0occur i= n normal GUI emacs.

=C2=A0I've contacted the ensime maintainers,= and while they can reproduce the
=C2=A0bug, they claim it isn't an = ensime problem. Hence I'm here.

=C2=A0The ensime bug report (wit= h pictures and instructions to reproduce) can be found here:
=C2=A0https://github.com= /ensime/ensime-emacs/issues/440

=C2=A0Thanks for any help you ca= n give.

=C2=A0In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu)
=C2= =A0 of 2016-05-01 on svetlemodry
=C2=A0System Description:=C2=A0=C2=A0= =C2=A0=C2=A0 Arch Linux

=C2=A0Configured using:
=C2=A0 `configure= --prefix=3D/usr --sysconfdir=3D/etc --libexecdir=3D/usr/lib
=C2=A0 --lo= calstatedir=3D/var --without-x --without-sound 'CFLAGS=3D-march=3Dx86-6= 4
=C2=A0 -mtune=3Dgeneric -O2 -pipe -fstack-protector-strong'
=C2= =A0 CPPFLAGS=3D-D_FORTIFY_SOURCE=3D2
=C2=A0 LDFLAGS=3D-Wl,-O1,--sort-com= mon,--as-needed,-z,relro'

=C2=A0Important settings:
=C2=A0=C2= =A0 value of $LANG: en_US.UTF-8
=C2=A0=C2=A0 locale-coding-system: utf-8= -unix

Major mode: Scala

=C2=A0Minor modes in effect:
=C2= =A0=C2=A0 yas-minor-mode: t
=C2=A0=C2=A0 company-mode: t
=C2=A0=C2=A0= diff-auto-refine-mode: t
=C2=A0=C2=A0 ensime-mode: t
=C2=A0=C2=A0 he= lm-mode: t
=C2=A0=C2=A0 shell-dirtrack-mode: t
=C2=A0=C2=A0 async-byt= ecomp-package-mode: t
=C2=A0=C2=A0 electric-pair-mode: t
=C2=A0=C2=A0= tooltip-mode: t
=C2=A0=C2=A0 electric-indent-mode: t
=C2=A0=C2=A0 me= nu-bar-mode: t
=C2=A0=C2=A0 file-name-shadow-mode: t
=C2=A0=C2=A0 glo= bal-font-lock-mode: t
=C2=A0=C2=A0 font-lock-mode: t
=C2=A0=C2=A0 aut= o-composition-mode: t
=C2=A0=C2=A0 auto-encryption-mode: t
=C2=A0=C2= =A0 auto-compression-mode: t
=C2=A0=C2=A0 column-number-mode: t
=C2= =A0=C2=A0 line-number-mode: t
=C2=A0=C2=A0 transient-mark-mode: t
=C2=A0Recent messages:
=C2=A0Wrote /home/colin/*message*-20160518-09514= 8
=C2=A0C-c k is undefined
=C2=A0C-c C-n is undefined
=C2=A0Mark s= aved where search started
=C2=A0Quit
=C2=A0ENSIME server starting...<= br>=C2=A0Connecting to Swank on port 38005..
=C2=A0Connected to ENSIME s= peaking protocol 0.8.20, please wait while the project is loaded.
=C2=A0= Initializing Analyzer. Please wait...
=C2=A0ENSIME ready. Colin, this co= uld be the start of a beautiful program.

=C2=A0Load-path shadows:=C2=A0/home/colin/.emacs.d/elpa/helm-20160517.202/helm-multi-match hides /= home/colin/.emacs.d/elpa/helm-core-2\
=C2=A00160516.2343/helm-multi-matc= h

=C2=A0Features:
=C2=A0(network-stream starttls tls ido vc-git e= nsime-company yasnippet company
=C2=A0pcase scala-mode scala-mode-pretti= fy-symbols scala-mode-imenu
=C2=A0scala-mode-map scala-mode-fontlock sca= la-mode-indent
=C2=A0scala-mode-paragraph scala-mode-lib image-file mise= arch multi-isearch
=C2=A0shadow sort mail-extr emacsbug message idna rfc= 822 mml mml-sec mm-decode
=C2=A0mm-bodies mm-encode mail-parse rfc2231 m= ailabbrev gmm-utils mailheader
=C2=A0sendmail rfc2047 rfc2045 ietf-drums= mail-utils winner helm-command
=C2=A0helm-elisp helm-eval edebug eldoc = help-mode org-clock diary-lib
=C2=A0diary-loaddefs cal-iso org-element o= rg-rmail org-mhe org-irc org-info
=C2=A0org-gnus org-docview doc-view jk= a-compr image-mode image org-bibtex
=C2=A0bibtex org-bbdb org-w3m org-ag= enda org org-macro org-footnote
=C2=A0org-pcomplete org-list org-faces o= rg-entities org-version ob-emacs-lisp
=C2=A0ob ob-tangle ob-ref ob-lob o= b-table ob-exp org-src ob-keys ob-comint
=C2=A0ob-core ob-eval org-compa= t org-macs org-loaddefs find-func cal-menu
=C2=A0calendar cal-loaddefs s= erver ensime ensime-sbt sbt-mode sbt-mode-rgrep
=C2=A0grep sbt-mode-comi= nt sbt-mode-buffer sbt-mode-project sbt-mode-vars
=C2=A0ensime-http ensi= me-ui ensime-semantic-highlight ensime-doc ensime-search
=C2=A0ensime-un= do ensime-startup ensime-refactor diff-mode ensime-popup
=C2=A0ensime-no= tes ensime-model ensime-mode ensime-inspector imenu
=C2=A0ensime-goto-te= stfile ensime-editor popup ensime-debug gdb-mi bindat gud
=C2=A0ensime-s= tacktrace ensime-inf ensime-completion-util scala-mode-syntax
=C2=A0ensi= me-config ensime-util ensime-client ensime-vars s ucs-normalize
=C2=A0hi= deshow arc-mode archive-mode dash url-gw ensime-macros cl
=C2=A0haskell-= interactive-mode haskell-presentation-mode haskell-collapse
=C2=A0haskel= l-process haskell-session json haskell-navigate-imports
=C2=A0haskell-co= mpile haskell-mode haskell-cabal haskell-utils
=C2=A0haskell-font-lock h= askell-indentation haskell-string
=C2=A0haskell-sort-imports haskell-lex= eme haskell-align-imports haskell-compat
=C2=A0haskell-complete-module n= outline outline flymake etags dabbrev
=C2=A0haskell-customize helm-mode = helm-files rx image-dired tramp tramp-compat
=C2=A0tramp-loaddefs trampv= er shell pcomplete format-spec dired-x dired-aux
=C2=A0ffap thingatpt he= lm-buffers helm-elscreen helm-tags helm-bookmark
=C2=A0helm-adaptive hel= m-info bookmark pp helm-locate helm-grep helm-regexp
=C2=A0helm-plugin h= elm-external helm-net browse-url xml url url-proxy
=C2=A0url-privacy url= -expand url-methods url-history url-cookie url-domsuf
=C2=A0url-util url= -parse auth-source gnus-util time-date mm-util mail-prsvr
=C2=A0password= -cache url-vars mailcap helm-utils compile comint regexp-opt
=C2=A0ansi-= color ring helm-help helm-types helm easy-mmode cl-macs gv
=C2=A0helm-so= urce eieio byte-opt bytecomp byte-compile cl-extra cconv
=C2=A0eieio-cor= e helm-multi-match helm-lib dired helm-config helm-easymenu
=C2=A0edmacr= o kmacro async-bytecomp advice help-fns async cl-loaddefs cl-lib
=C2=A0e= lec-pair info tool-bar easymenu package epg-config tooltip electric
=C2= =A0uniquify ediff-hook vc-hooks lisp-float-type tabulated-list newcomment=C2=A0lisp-mode prog-mode register page menu-bar rfn-eshadow timer select=
=C2=A0mouse jit-lock font-lock syntax facemenu font-core frame cham geo= rgian
=C2=A0utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao ko= rean
=C2=A0japanese hebrew greek romanian slovak czech european ethiopic= indian
=C2=A0cyrillic chinese case-table epa-hook jka-cmpr-hook help si= mple abbrev
=C2=A0minibuffer nadvice loaddefs button faces cus-face macr= oexp files
=C2=A0text-properties overlay sha1 md5 base64 format env code= -pages mule
=C2=A0custom widget hashtable-print-readable backquote make-= network-process
=C2=A0dbusbind gfilenotify multi-tty emacs)

Memor= y information:
=C2=A0((conses 16 493230 27709)
=C2=A0 (symbols 48 456= 71 8)
=C2=A0 (miscs 40 936 1876)
=C2=A0 (strings 32 102177 15065)
= =C2=A0 (string-bytes 1 3052221)
=C2=A0 (vectors 16 60425)
=C2=A0 (vec= tor-slots 8 931107 9519)
=C2=A0 (floats 8 234 1600)
=C2=A0 (intervals= 56 2997 0)
=C2=A0 (buffers 960 37)
=C2=A0 (heap 1024 48683 1909))
--
<= div>Colin Woodbury
Geotrellis Team @ Azavea
--001a11396814bf158b053320d52f-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 30 11:04:36 2016 Received: (at submit) by debbugs.gnu.org; 30 May 2016 15:04:36 +0000 Received: from localhost ([127.0.0.1]:47736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Ok7-0007Hr-Qd for submit@debbugs.gnu.org; Mon, 30 May 2016 11:04:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7Ok4-0007Hd-S5 for submit@debbugs.gnu.org; Mon, 30 May 2016 11:04:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Ojx-0002Vh-J5 for submit@debbugs.gnu.org; Mon, 30 May 2016 11:04:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,HTML_MESSAGE, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Ojx-0002VN-Fd for submit@debbugs.gnu.org; Mon, 30 May 2016 11:04:25 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Ojt-00077C-Qv for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 11:04:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Ojq-0002Ui-8S for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 11:04:20 -0400 Received: from mail-it0-x22c.google.com ([2607:f8b0:4001:c0b::22c]:38659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Ojp-0002Ub-RT for bug-gnu-emacs@gnu.org; Mon, 30 May 2016 11:04:18 -0400 Received: by mail-it0-x22c.google.com with SMTP id i127so9634217ita.1 for ; Mon, 30 May 2016 08:04:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azavea.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=CpHbxgoRoUs32/lNL1ZrF12PGHIxJ1+9rPsfeTyaR0M=; b=WsYZFY8V+6Avo2eEqw45ulOAtY+J+RL16aX50i41j8iQqkCSKk0yIMhxp4hQSpVCS+ tdbEz6fS+qFCWOyRHqdRabjExB69YDqqhDas56hekZX3Sb1DtH9byZ4n0dqc9tn8b8xH 1jC5SxOgVburlqhK14H26Joqj4oXkZAxeGjds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=CpHbxgoRoUs32/lNL1ZrF12PGHIxJ1+9rPsfeTyaR0M=; b=Vu/19kPf1QdR21mmmdQ77ktdiCKmD94Eoj4v1Pjh9bOsrD/yUi1jbvSWbeexCFpCMQ 8NfOk3AXaEVkbCrgC3h3KXUBssgzckKF6y4vSfkPdVJYBtiPKkl7FuG5/zZE7hqk/zBK e1xm8PmCTBiE2F5xi4iPecymhdsDPhksOIeINXjmk4ybAphY2+A8S8elep9MDu/0jvYE fNGAqiCT8fQNbjU/YEV815lkAvmeM2fQUPXlVZNg6/7u5KZSUiD0gjI+9Oj/a2TfLR0R sZMKXSxAwVk/fs2MDeRseN2z3uY2lmAWmNYJEdnyesAT++0H7LVGVjCN72+LkwIZY7d9 gKfQ== X-Gm-Message-State: ALyK8tKltytXgbm+3rZa5B2vdSLXBftqQ27n/DLTupmdky0qQd5BOW9vBCSuhCyi+yts96KeKCMqcG2x/d6azi6V MIME-Version: 1.0 X-Received: by 10.36.204.198 with SMTP id x189mr8605173itf.19.1464620656643; Mon, 30 May 2016 08:04:16 -0700 (PDT) Received: by 10.107.130.70 with HTTP; Mon, 30 May 2016 08:04:16 -0700 (PDT) In-Reply-To: References: Date: Mon, 30 May 2016 08:04:16 -0700 Message-ID: Subject: Re: 24.5; Overzealous underlining in emacs-nox From: Colin Woodbury To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=94eb2c0602fef868f3053410912d X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --94eb2c0602fef868f3053410912d Content-Type: text/plain; charset=UTF-8 Confirmed that this is definitely strictly a problem with emacs in the terminal. Has anyone had a chance to look at this? On Wed, May 18, 2016 at 10:03 AM, Colin Woodbury wrote: > I use ensime for Scala editing, and I've come across a strange display bug > which is only present in `emacs -nw`, `emacsclient -nw` or just `emacs` > from > the `emacs-nox` package. It has to do with some very jarring underlining > that occurs during ensime's "semantic highlighting". The issue does not > occur in normal GUI emacs. > > I've contacted the ensime maintainers, and while they can reproduce the > bug, they claim it isn't an ensime problem. Hence I'm here. > > The ensime bug report (with pictures and instructions to reproduce) can > be found here: > https://github.com/ensime/ensime-emacs/issues/440 > > Thanks for any help you can give. > > In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu) > of 2016-05-01 on svetlemodry > System Description: Arch Linux > > Configured using: > `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib > --localstatedir=/var --without-x --without-sound 'CFLAGS=-march=x86-64 > -mtune=generic -O2 -pipe -fstack-protector-strong' > CPPFLAGS=-D_FORTIFY_SOURCE=2 > LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' > > Important settings: > value of $LANG: en_US.UTF-8 > locale-coding-system: utf-8-unix > > Major mode: Scala > > Minor modes in effect: > yas-minor-mode: t > company-mode: t > diff-auto-refine-mode: t > ensime-mode: t > helm-mode: t > shell-dirtrack-mode: t > async-bytecomp-package-mode: t > electric-pair-mode: t > tooltip-mode: t > electric-indent-mode: t > menu-bar-mode: t > file-name-shadow-mode: t > global-font-lock-mode: t > font-lock-mode: t > auto-composition-mode: t > auto-encryption-mode: t > auto-compression-mode: t > column-number-mode: t > line-number-mode: t > transient-mark-mode: t > > Recent messages: > Wrote /home/colin/*message*-20160518-095148 > C-c k is undefined > C-c C-n is undefined > Mark saved where search started > Quit > ENSIME server starting... > Connecting to Swank on port 38005.. > Connected to ENSIME speaking protocol 0.8.20, please wait while the > project is loaded. > Initializing Analyzer. Please wait... > ENSIME ready. Colin, this could be the start of a beautiful program. > > Load-path shadows: > /home/colin/.emacs.d/elpa/helm-20160517.202/helm-multi-match hides > /home/colin/.emacs.d/elpa/helm-core-2\ > 0160516.2343/helm-multi-match > > Features: > (network-stream starttls tls ido vc-git ensime-company yasnippet company > pcase scala-mode scala-mode-prettify-symbols scala-mode-imenu > scala-mode-map scala-mode-fontlock scala-mode-indent > scala-mode-paragraph scala-mode-lib image-file misearch multi-isearch > shadow sort mail-extr emacsbug message idna rfc822 mml mml-sec mm-decode > mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader > sendmail rfc2047 rfc2045 ietf-drums mail-utils winner helm-command > helm-elisp helm-eval edebug eldoc help-mode org-clock diary-lib > diary-loaddefs cal-iso org-element org-rmail org-mhe org-irc org-info > org-gnus org-docview doc-view jka-compr image-mode image org-bibtex > bibtex org-bbdb org-w3m org-agenda org org-macro org-footnote > org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp > ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint > ob-core ob-eval org-compat org-macs org-loaddefs find-func cal-menu > calendar cal-loaddefs server ensime ensime-sbt sbt-mode sbt-mode-rgrep > grep sbt-mode-comint sbt-mode-buffer sbt-mode-project sbt-mode-vars > ensime-http ensime-ui ensime-semantic-highlight ensime-doc ensime-search > ensime-undo ensime-startup ensime-refactor diff-mode ensime-popup > ensime-notes ensime-model ensime-mode ensime-inspector imenu > ensime-goto-testfile ensime-editor popup ensime-debug gdb-mi bindat gud > ensime-stacktrace ensime-inf ensime-completion-util scala-mode-syntax > ensime-config ensime-util ensime-client ensime-vars s ucs-normalize > hideshow arc-mode archive-mode dash url-gw ensime-macros cl > haskell-interactive-mode haskell-presentation-mode haskell-collapse > haskell-process haskell-session json haskell-navigate-imports > haskell-compile haskell-mode haskell-cabal haskell-utils > haskell-font-lock haskell-indentation haskell-string > haskell-sort-imports haskell-lexeme haskell-align-imports haskell-compat > haskell-complete-module noutline outline flymake etags dabbrev > haskell-customize helm-mode helm-files rx image-dired tramp tramp-compat > tramp-loaddefs trampver shell pcomplete format-spec dired-x dired-aux > ffap thingatpt helm-buffers helm-elscreen helm-tags helm-bookmark > helm-adaptive helm-info bookmark pp helm-locate helm-grep helm-regexp > helm-plugin helm-external helm-net browse-url xml url url-proxy > url-privacy url-expand url-methods url-history url-cookie url-domsuf > url-util url-parse auth-source gnus-util time-date mm-util mail-prsvr > password-cache url-vars mailcap helm-utils compile comint regexp-opt > ansi-color ring helm-help helm-types helm easy-mmode cl-macs gv > helm-source eieio byte-opt bytecomp byte-compile cl-extra cconv > eieio-core helm-multi-match helm-lib dired helm-config helm-easymenu > edmacro kmacro async-bytecomp advice help-fns async cl-loaddefs cl-lib > elec-pair info tool-bar easymenu package epg-config tooltip electric > uniquify ediff-hook vc-hooks lisp-float-type tabulated-list newcomment > lisp-mode prog-mode register page menu-bar rfn-eshadow timer select > mouse jit-lock font-lock syntax facemenu font-core frame cham georgian > utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean > japanese hebrew greek romanian slovak czech european ethiopic indian > cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev > minibuffer nadvice loaddefs button faces cus-face macroexp files > text-properties overlay sha1 md5 base64 format env code-pages mule > custom widget hashtable-print-readable backquote make-network-process > dbusbind gfilenotify multi-tty emacs) > > Memory information: > ((conses 16 493230 27709) > (symbols 48 45671 8) > (miscs 40 936 1876) > (strings 32 102177 15065) > (string-bytes 1 3052221) > (vectors 16 60425) > (vector-slots 8 931107 9519) > (floats 8 234 1600) > (intervals 56 2997 0) > (buffers 960 37) > (heap 1024 48683 1909)) > > -- > Colin Woodbury > Geotrellis Team @ Azavea > -- Colin Woodbury Geotrellis Team @ Azavea --94eb2c0602fef868f3053410912d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Confirmed that this is definitely strictly a problem with = emacs in the terminal. Has anyone had a chance to look at this?

On Wed, May 18, 201= 6 at 10:03 AM, Colin Woodbury <cwoodbury@azavea.com> wrot= e:
I use ensime for Scal= a editing, and I've come across a strange display bug
=C2=A0which is= only present in `emacs -nw`, `emacsclient -nw` or just `emacs` from
=C2= =A0the `emacs-nox` package. It has to do with some very jarring underlining=
=C2=A0that occurs during ensime's "semantic highlighting"= . The issue does not
=C2=A0occur in normal GUI emacs.

=C2=A0I'= ;ve contacted the ensime maintainers, and while they can reproduce the
= =C2=A0bug, they claim it isn't an ensime problem. Hence I'm here.
=C2=A0The ensime bug report (with pictures and instructions to reprod= uce) can be found here:
=C2=A0https://github.com/ensime/ensime-emac= s/issues/440

=C2=A0Thanks for any help you can give.

=C2= =A0In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu)
=C2=A0 of 2016-05-01 o= n svetlemodry
=C2=A0System Description:=C2=A0=C2=A0=C2=A0=C2=A0 Arch Lin= ux

=C2=A0Configured using:
=C2=A0 `configure --prefix=3D/usr --sy= sconfdir=3D/etc --libexecdir=3D/usr/lib
=C2=A0 --localstatedir=3D/var --= without-x --without-sound 'CFLAGS=3D-march=3Dx86-64
=C2=A0 -mtune=3D= generic -O2 -pipe -fstack-protector-strong'
=C2=A0 CPPFLAGS=3D-D_FOR= TIFY_SOURCE=3D2
=C2=A0 LDFLAGS=3D-Wl,-O1,--sort-common,--as-needed,-z,re= lro'

=C2=A0Important settings:
=C2=A0=C2=A0 value of $LANG: e= n_US.UTF-8
=C2=A0=C2=A0 locale-coding-system: utf-8-unix

Major mo= de: Scala

=C2=A0Minor modes in effect:
=C2=A0=C2=A0 yas-minor-mod= e: t
=C2=A0=C2=A0 company-mode: t
=C2=A0=C2=A0 diff-auto-refine-mode:= t
=C2=A0=C2=A0 ensime-mode: t
=C2=A0=C2=A0 helm-mode: t
=C2=A0=C2= =A0 shell-dirtrack-mode: t
=C2=A0=C2=A0 async-bytecomp-package-mode: t=C2=A0=C2=A0 electric-pair-mode: t
=C2=A0=C2=A0 tooltip-mode: t
=C2= =A0=C2=A0 electric-indent-mode: t
=C2=A0=C2=A0 menu-bar-mode: t
=C2= =A0=C2=A0 file-name-shadow-mode: t
=C2=A0=C2=A0 global-font-lock-mode: t=
=C2=A0=C2=A0 font-lock-mode: t
=C2=A0=C2=A0 auto-composition-mode: t=
=C2=A0=C2=A0 auto-encryption-mode: t
=C2=A0=C2=A0 auto-compression-m= ode: t
=C2=A0=C2=A0 column-number-mode: t
=C2=A0=C2=A0 line-number-mo= de: t
=C2=A0=C2=A0 transient-mark-mode: t

=C2=A0Recent messages:<= br>=C2=A0Wrote /home/colin/*message*-20160518-095148
=C2=A0C-c k is unde= fined
=C2=A0C-c C-n is undefined
=C2=A0Mark saved where search starte= d
=C2=A0Quit
=C2=A0ENSIME server starting...
=C2=A0Connecting to S= wank on port 38005..
=C2=A0Connected to ENSIME speaking protocol 0.8.20,= please wait while the project is loaded.
=C2=A0Initializing Analyzer. P= lease wait...
=C2=A0ENSIME ready. Colin, this could be the start of a be= autiful program.

=C2=A0Load-path shadows:
=C2=A0/home/colin/.emac= s.d/elpa/helm-20160517.202/helm-multi-match hides /home/colin/.emacs.d/elpa= /helm-core-2\
=C2=A00160516.2343/helm-multi-match

=C2=A0Features:=
=C2=A0(network-stream starttls tls ido vc-git ensime-company yasnippet = company
=C2=A0pcase scala-mode scala-mode-prettify-symbols scala-mode-im= enu
=C2=A0scala-mode-map scala-mode-fontlock scala-mode-indent
=C2=A0= scala-mode-paragraph scala-mode-lib image-file misearch multi-isearch
= =C2=A0shadow sort mail-extr emacsbug message idna rfc822 mml mml-sec mm-dec= ode
=C2=A0mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils ma= ilheader
=C2=A0sendmail rfc2047 rfc2045 ietf-drums mail-utils winner hel= m-command
=C2=A0helm-elisp helm-eval edebug eldoc help-mode org-clock di= ary-lib
=C2=A0diary-loaddefs cal-iso org-element org-rmail org-mhe org-i= rc org-info
=C2=A0org-gnus org-docview doc-view jka-compr image-mode ima= ge org-bibtex
=C2=A0bibtex org-bbdb org-w3m org-agenda org org-macro org= -footnote
=C2=A0org-pcomplete org-list org-faces org-entities org-versio= n ob-emacs-lisp
=C2=A0ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src= ob-keys ob-comint
=C2=A0ob-core ob-eval org-compat org-macs org-loaddef= s find-func cal-menu
=C2=A0calendar cal-loaddefs server ensime ensime-sb= t sbt-mode sbt-mode-rgrep
=C2=A0grep sbt-mode-comint sbt-mode-buffer sbt= -mode-project sbt-mode-vars
=C2=A0ensime-http ensime-ui ensime-semantic-= highlight ensime-doc ensime-search
=C2=A0ensime-undo ensime-startup ensi= me-refactor diff-mode ensime-popup
=C2=A0ensime-notes ensime-model ensim= e-mode ensime-inspector imenu
=C2=A0ensime-goto-testfile ensime-editor p= opup ensime-debug gdb-mi bindat gud
=C2=A0ensime-stacktrace ensime-inf e= nsime-completion-util scala-mode-syntax
=C2=A0ensime-config ensime-util = ensime-client ensime-vars s ucs-normalize
=C2=A0hideshow arc-mode archiv= e-mode dash url-gw ensime-macros cl
=C2=A0haskell-interactive-mode haske= ll-presentation-mode haskell-collapse
=C2=A0haskell-process haskell-sess= ion json haskell-navigate-imports
=C2=A0haskell-compile haskell-mode has= kell-cabal haskell-utils
=C2=A0haskell-font-lock haskell-indentation has= kell-string
=C2=A0haskell-sort-imports haskell-lexeme haskell-align-impo= rts haskell-compat
=C2=A0haskell-complete-module noutline outline flymak= e etags dabbrev
=C2=A0haskell-customize helm-mode helm-files rx image-di= red tramp tramp-compat
=C2=A0tramp-loaddefs trampver shell pcomplete for= mat-spec dired-x dired-aux
=C2=A0ffap thingatpt helm-buffers helm-elscre= en helm-tags helm-bookmark
=C2=A0helm-adaptive helm-info bookmark pp hel= m-locate helm-grep helm-regexp
=C2=A0helm-plugin helm-external helm-net = browse-url xml url url-proxy
=C2=A0url-privacy url-expand url-methods ur= l-history url-cookie url-domsuf
=C2=A0url-util url-parse auth-source gnu= s-util time-date mm-util mail-prsvr
=C2=A0password-cache url-vars mailca= p helm-utils compile comint regexp-opt
=C2=A0ansi-color ring helm-help h= elm-types helm easy-mmode cl-macs gv
=C2=A0helm-source eieio byte-opt by= tecomp byte-compile cl-extra cconv
=C2=A0eieio-core helm-multi-match hel= m-lib dired helm-config helm-easymenu
=C2=A0edmacro kmacro async-bytecom= p advice help-fns async cl-loaddefs cl-lib
=C2=A0elec-pair info tool-bar= easymenu package epg-config tooltip electric
=C2=A0uniquify ediff-hook = vc-hooks lisp-float-type tabulated-list newcomment
=C2=A0lisp-mode prog-= mode register page menu-bar rfn-eshadow timer select
=C2=A0mouse jit-loc= k font-lock syntax facemenu font-core frame cham georgian
=C2=A0utf-8-la= ng misc-lang vietnamese tibetan thai tai-viet lao korean
=C2=A0japanese = hebrew greek romanian slovak czech european ethiopic indian
=C2=A0cyrill= ic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
=C2=A0mi= nibuffer nadvice loaddefs button faces cus-face macroexp files
=C2=A0tex= t-properties overlay sha1 md5 base64 format env code-pages mule
=C2=A0cu= stom widget hashtable-print-readable backquote make-network-process
=C2= =A0dbusbind gfilenotify multi-tty emacs)

Memory information:
=C2= =A0((conses 16 493230 27709)
=C2=A0 (symbols 48 45671 8)
=C2=A0 (misc= s 40 936 1876)
=C2=A0 (strings 32 102177 15065)
=C2=A0 (string-bytes = 1 3052221)
=C2=A0 (vectors 16 60425)
=C2=A0 (vector-slots 8 931107 95= 19)
=C2=A0 (floats 8 234 1600)
=C2=A0 (intervals 56 2997 0)
=C2=A0= (buffers 960 37)
=C2=A0 (heap 1024 48683 1909))<= font color=3D"#888888">

--
<= div>Colin Woodbury
Geotrellis Team @ Azavea



--
Colin Wood= bury
Geotrellis Team @ Azavea
--94eb2c0602fef868f3053410912d-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 03:48:14 2016 Received: (at 23574) by debbugs.gnu.org; 4 Jun 2016 07:48:14 +0000 Received: from localhost ([127.0.0.1]:53684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b96Ja-0002uG-8z for submit@debbugs.gnu.org; Sat, 04 Jun 2016 03:48:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b96JX-0002u3-1L for 23574@debbugs.gnu.org; Sat, 04 Jun 2016 03:48:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b96JN-0004Fo-Pe for 23574@debbugs.gnu.org; Sat, 04 Jun 2016 03:48:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b96JN-0004FV-MV; Sat, 04 Jun 2016 03:48:01 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2296 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b96JL-0001wY-SP; Sat, 04 Jun 2016 03:48:00 -0400 Date: Sat, 04 Jun 2016 10:48:28 +0300 Message-Id: <83porxwg1f.fsf@gnu.org> From: Eli Zaretskii To: Colin Woodbury In-reply-to: (message from Colin Woodbury on Mon, 30 May 2016 08:04:16 -0700) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Mon, 30 May 2016 08:04:16 -0700 > From: Colin Woodbury > > Confirmed that this is definitely strictly a problem with emacs in the terminal. Has anyone had a chance to > look at this? Given what I read in the original bug report you pointed to, I'm not convinced it's an Emacs bug (or even that there is a bug at all). There's an opinion there at the end that this is "strictly an Emacs issue", but the example shown is the intended behavior: Emacs always gives the empty screen space after the line end the same face as the last character on the line. You can easily see that by shift-selecting text that spans more than one line. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 12:20:27 2016 Received: (at 23574) by debbugs.gnu.org; 4 Jun 2016 16:20:27 +0000 Received: from localhost ([127.0.0.1]:54541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9EJH-000772-J2 for submit@debbugs.gnu.org; Sat, 04 Jun 2016 12:20:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9EJG-00076q-6m for 23574@debbugs.gnu.org; Sat, 04 Jun 2016 12:20:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9EJ6-0000Ss-3j for 23574@debbugs.gnu.org; Sat, 04 Jun 2016 12:20:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9EJ6-0000SO-0J; Sat, 04 Jun 2016 12:20:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2837 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9EJ3-00006I-Cu; Sat, 04 Jun 2016 12:20:14 -0400 Date: Sat, 04 Jun 2016 19:20:40 +0300 Message-Id: <83d1nxudrb.fsf@gnu.org> From: Eli Zaretskii To: Colin Woodbury In-reply-to: (message from Colin Woodbury on Sat, 4 Jun 2016 08:54:27 -0700) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Colin Woodbury > Date: Sat, 4 Jun 2016 08:54:27 -0700 > > Thanks for the response, Eli. If it's not a bug in terminal emacs, then why do GUI emacs and terminal emacs > display different things? Note from the images that the empty space in GUI is _not_ given the same > overlay/face as the text. > > Thoughts? If you show me some Lisp which produces these different effects in X and non-X sessions, I could try looking for the reason. All I've seen is a screenshot, from which I deduced (perhaps incorrectly) what was done to produce it. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 04 17:37:56 2016 Received: (at 23574) by debbugs.gnu.org; 4 Jun 2016 21:37:56 +0000 Received: from localhost ([127.0.0.1]:54659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9JGW-0005nY-06 for submit@debbugs.gnu.org; Sat, 04 Jun 2016 17:37:56 -0400 Received: from mail-yw0-f179.google.com ([209.85.161.179]:36783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9JGT-0005nK-Ei for 23574@debbugs.gnu.org; Sat, 04 Jun 2016 17:37:54 -0400 Received: by mail-yw0-f179.google.com with SMTP id x189so110418354ywe.3 for <23574@debbugs.gnu.org>; Sat, 04 Jun 2016 14:37:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8E/xmF2teEcGoxDCExwzlDCtmPgb812dzV/FJcHg2g8=; b=Xiq16EsiKwxlgFczW3fEbpFUkaFwsx7oape3/BF3iGxLjd+Fev0aj/1t481T0B4iyy bY3x9fI0VktGzb5aXsL20GiR3U3Gci104cLXplr0r+IEg8O0fcvv13UqNpZCt9f9M0jr YETGKDbChZLXL+nzTA+F43yUzMbQs7E2r5MtUrgMceMoqP7nUEwIoLOrBkhSwGHi1EgI +mf2Ma7sI3jiEAFk2Wv3XaN7keZMhoiSEOE7VfdfCgqNnAGpqCzO0dYKu2QPdLRzebJf tI/0qg3Rs2YSN4pDDb6DKLUW1rSbpPTvXaQa99CTlGEmkh1hEdv2Td1tWo4Lvv5zLSaZ ENVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8E/xmF2teEcGoxDCExwzlDCtmPgb812dzV/FJcHg2g8=; b=AIiHxwf1evWiDnRnAVsNE2vNpYYlNOB1ktCoeO9uJZj16Wx9VGY6+ENCx48SwmreAi X5QUKdZzMvt22MO7vXki40ziyqwp7Er0EECNXxyWfLA2PaEHP7+VrA7T9osEpb4BPf2B Sn/hrqrhF9S2RwrkVH1At/2UJlE6r9Zssqfz3dCN70qsWt5z0e4SwvjY0rOpwdDDHs5q e1vzyL55iopo5nqiSIkNXUZoO5rr+q7IDofQY2JE9A4EZx/bNyc7X+WXu9plpjtb7fMN ScprHrvIHGtr+9bG3rAso7x0E20mco8QheL7B4qHL5Qj7iIaiAJNjs0gkS2WcOTlNKFS y5Kg== X-Gm-Message-State: ALyK8tIeZqpG/AVSJHnL5shwEjtelJ9SKrYiUFU36uI3aFuCwwvSURRO6+nCdLL31Qpf0DYr81iw8ucQWUBgpw== X-Received: by 10.129.23.77 with SMTP id 74mr6802845ywx.127.1465076268005; Sat, 04 Jun 2016 14:37:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.94.137 with HTTP; Sat, 4 Jun 2016 14:37:28 -0700 (PDT) In-Reply-To: <83d1nxudrb.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> From: John Mastro Date: Sat, 4 Jun 2016 14:37:28 -0700 Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: 23574@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 23574 Cc: Eli Zaretskii , Colin Woodbury X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: >> Thanks for the response, Eli. If it's not a bug in terminal emacs, >> then why do GUI emacs and terminal emacs display different things? >> Note from the images that the empty space in GUI is _not_ given the >> same overlay/face as the text. > > If you show me some Lisp which produces these different effects in X > and non-X sessions, I could try looking for the reason. All I've seen > is a screenshot, from which I deduced (perhaps incorrectly) what was > done to produce it. Here's an example shows the effect Colin is seeing: (let (beg end ov) (defface example-underline-face '((t :underline t)) "Example face with underlining") (goto-char (point-max)) (newline) (setq beg (point)) (insert " foo\n bar\n") (setq end (point)) (setq ov (make-overlay beg end)) (overlay-put ov 'face 'example-underline-face)) The result is the same with text properties instead of an overlay: (progn (defface example-underline-face '((t :underline t)) "Example face with underlining") (goto-char (point-max)) (newline) (insert (propertize " foo\n bar\n" 'font-lock-face 'example-underline-face))) In a graphical frame, the underline only extends one character past the visible text (this one extra character presumably being the newline). However, in a text frame the underline extends all the way to the end of the window. John From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 11:54:03 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 15:54:03 +0000 Received: from localhost ([127.0.0.1]:55754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9aNH-0001Nx-1H for submit@debbugs.gnu.org; Sun, 05 Jun 2016 11:54:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9aNE-0001NM-Tm for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 11:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9aN8-0001Uu-Sj for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 11:53:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57454) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9aN3-0001T5-E3; Sun, 05 Jun 2016 11:53:49 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3377 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9aN2-0005nk-JJ; Sun, 05 Jun 2016 11:53:48 -0400 Date: Sun, 05 Jun 2016 18:54:20 +0300 Message-Id: <83wpm3tyvn.fsf@gnu.org> From: Eli Zaretskii To: John Mastro In-reply-to: (message from John Mastro on Sat, 4 Jun 2016 14:37:28 -0700) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: John Mastro > Date: Sat, 4 Jun 2016 14:37:28 -0700 > Cc: Eli Zaretskii , Colin Woodbury > > (progn > (defface example-underline-face > '((t :underline t)) > "Example face with underlining") > (goto-char (point-max)) > (newline) > (insert (propertize " foo\n bar\n" > 'font-lock-face > 'example-underline-face))) > > In a graphical frame, the underline only extends one character past the > visible text (this one extra character presumably being the newline). > However, in a text frame the underline extends all the way to the end of > the window. OK, then my guess was correct after all, and what you see is how Emacs behaved since v21 at least. If there is a problem here, it's in GUI frames, not in TTY frames. We always try to make the empty space after the end of a screen line have the same face as the last character of that line. With background color, this works in both TTY and GUI frames, but we cannot do that with underlining without actually drawing something in that empty space. While it should be possible to have GUI frames display underline all the way to window edge, no one has ever requested that, so we didn't bother. In sum, this is the intended behavior, and if the application doesn't like it, it should refrain from underlining more than one line. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 13:06:01 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 17:06:01 +0000 Received: from localhost ([127.0.0.1]:55768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9bUv-00035w-4s for submit@debbugs.gnu.org; Sun, 05 Jun 2016 13:06:01 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:34145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9bUt-00035k-F2 for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 13:06:00 -0400 Received: by mail-oi0-f53.google.com with SMTP id e72so195309966oib.1 for <23574@debbugs.gnu.org>; Sun, 05 Jun 2016 10:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=M2/GfA+OHBtiNWJmc4k0B+Slufa6ekK+t9B5uLspoRs=; b=tz2TrpHZo4ogVRTSCg+/5h9v3Wb4VZlR7d4uvuWFdZyUsgbMfutpPaMjwiGJagpOM+ 3CzgMQ7mvFt1bVk8vA81GJn3G6VxksLdNonXzRurhGiknIkq0AcDrRqobLzF1RCWASdD hCSG5fCqkJJ/g6zKxVKxXO9PPwVMTp6IGcw4OasjI6yU8Ls2GooLGBRd+t6wuir8ewEp lkZzXS5rgnKsf2NC8bG69eYuIzE0s/xEp+PB183zmmgO1zuF/IaKEshzLkKULO3jB/0a I8M0H+3JTSm/dy3h4Ao+dM6VD+jij8R3QUj9trTPTF7HONCdZ2A0nYHiRz0nO8V3ue/s pODA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=M2/GfA+OHBtiNWJmc4k0B+Slufa6ekK+t9B5uLspoRs=; b=FeFBt1quRaJHL+sbUl+G6OsqsoXvIm84+qFSU2IsmLtP3eyc8M0d7DGZoiRrRASiyG hIF2nqpm/LP2qnlAX7dyxQX8WNwyzSmzE+4u+IYNaidsiwOq0TcLXmGEQY3vTy/9fYWH 9JqdcPHaCOhiIAJWQnjvmu1dpNyJvvhMXOyS2e5b50OfWFV+G9JkldsxF7iRI4tdruAB JzhuTlxWuzx+AsDYECBMFNbCrCKD6hQGlqji43yId04NpXdb13o+KiOGLbvjJm53DK9z VJpPfZJ2VlW6D16bd5qplbnhe+e+bBb2jtdOriHpjSrWfcuGUhhT/Ul3hse24MvHYTKv SYTg== X-Gm-Message-State: ALyK8tIDw5HraA1R6FBjGOpuuedy5xl+ULzXxG6zb6qKK3gmPeH2ydJks0PrqNYhkalJeSJirO2mkmtUjpf4Jw== X-Received: by 10.202.77.129 with SMTP id a123mr5473123oib.143.1465146354000; Sun, 05 Jun 2016 10:05:54 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sun, 5 Jun 2016 10:05:53 -0700 (PDT) In-Reply-To: <83wpm3tyvn.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> From: Noam Postavsky Date: Sun, 5 Jun 2016 13:05:53 -0400 X-Google-Sender-Auth: ojVCg41zkNd6yXn4Qcs2u6C9kik Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, John Mastro , cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: > We always try to make the empty space > after the end of a screen line have the same face as the last > character of that line. Just to clarify, "last character of that line" refers to the newline character or the one before it? > While it should be > possible to have GUI frames display underline all the way to window > edge, no one has ever requested that, so we didn't bother. I think this would have been useful for magit to simplify the use of overlays to display the region with horizontal lines. In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you suggested a way using :align-to which turned out to have a bunch of complications and magit ended up not using it (see https://github.com/magit/magit/pull/2293). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 13:56:23 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 17:56:24 +0000 Received: from localhost ([127.0.0.1]:55850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cHf-0000PQ-J3 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 13:56:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34381) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cHd-0000PD-Tz for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 13:56:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9cHX-0007IZ-K7 for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 13:56:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59598) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9cHS-0007IE-L6; Sun, 05 Jun 2016 13:56:10 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3533 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9cHP-0007xo-2u; Sun, 05 Jun 2016 13:56:09 -0400 Date: Sun, 05 Jun 2016 20:56:28 +0300 Message-Id: <83twh7tt83.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sun, 5 Jun 2016 13:05:53 -0400) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Sun, 5 Jun 2016 13:05:53 -0400 > Cc: John Mastro , 23574@debbugs.gnu.org, cwoodbury@azavea.com > > On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: > > We always try to make the empty space > > after the end of a screen line have the same face as the last > > character of that line. > > Just to clarify, "last character of that line" refers to the newline > character or the one before it? The last displayed character of the line. The newline is not displayed, in the sense that it has no glyph, so it can have no face. > > While it should be > > possible to have GUI frames display underline all the way to window > > edge, no one has ever requested that, so we didn't bother. > > I think this would have been useful for magit to simplify the use of > overlays to display the region with horizontal lines. This is doable (and in fact we already do that in R2L paragraphs, which you can observe if you change the recipe's text to use R2L characters). But note that the OP in this bug report wants the exact opposite: to NOT have the underlining extended on TTYs. So clearly there's no "one size fits all" solution here. > In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you > suggested a way using :align-to which turned out to have a bunch of > complications and magit ended up not using it (see > https://github.com/magit/magit/pull/2293). Did you try using the box attribute of a face? From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 14:20:33 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 18:20:33 +0000 Received: from localhost ([127.0.0.1]:55876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cf3-0004CQ-10 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 14:20:33 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:35955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cf0-0004CA-Qf for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 14:20:31 -0400 Received: by mail-lf0-f42.google.com with SMTP id b73so82098676lfb.3 for <23574@debbugs.gnu.org>; Sun, 05 Jun 2016 11:20:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azavea.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=XK8D0EB2YB8tZiddM0VdljYm+e71u5FUsyvpWJGQMqg=; b=kwSGqUGax8YwC24Mf5QhkvNxyFPC86W3Y06+2lI26/ZntTwIKoEFzpA+IiOTNmy/y6 V+NS3spId3BjGtck6h6yXisJ/uleCM0HLtYUwLBJ50bCNCZaYN/wVsLludBG0ShWN0dp TcDHO+2VqRPXSlpKXYFUvvo8Nk0g7OlrBssO0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=XK8D0EB2YB8tZiddM0VdljYm+e71u5FUsyvpWJGQMqg=; b=GM82R6JuVsqYNcLubNofFdC3MMGz5jZzwKDCcMMvZvYct2PJFN32gJ3T3O3ZN/RBUF Xj2FiY4vxsEM+87D/5nAZLeLcsulAY7DvnVAlnbL7uOdMAswb4D7cvzwstkzyntu3TP+ lMJfqr/56T5TzKHPp1uG+modskn9Lw1taXCuzC73iIYLRS0DAW4rUA8Imd6tcDBgbnTw KBx0woR3+TFYf0KShMTAHj+ZPmHsdByq4xEJ7EqFZHmFKqn4Ol67vkNI1N7YWBZspMXO PJY9LciHvASf0yVPkcuJzi7mWPiFf17CWfYPszC878ZfDF0cdcTXUUHYjo5mNEa7r5wE dtFQ== X-Gm-Message-State: ALyK8tK7oGAtW91V+PjUyze0y6iwRm6MdZXtpm3whnMQ4EyKO9xrAtKmRrZ9/R7JcT+pVCVsT4ehB80MBORfsW2d X-Received: by 10.25.215.30 with SMTP id o30mr379762lfg.132.1465150824784; Sun, 05 Jun 2016 11:20:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.32.212 with HTTP; Sun, 5 Jun 2016 11:20:24 -0700 (PDT) In-Reply-To: <83twh7tt83.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> From: Colin Woodbury Date: Sun, 5 Jun 2016 11:20:24 -0700 Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: multipart/alternative; boundary=001a1140e420743c7205348c02d2 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1140e420743c7205348c02d2 Content-Type: text/plain; charset=UTF-8 Interesting that you consider the the GUI _not_ displaying the face all the way to end of screen to be a bug. I think only displaying to the end of the characters (as shown in images in the Github issue) is the expected behaviour. Otherwise, the screen (at least with underlining) gets quite noisy. On Sun, Jun 5, 2016 at 10:56 AM, Eli Zaretskii wrote: > > From: Noam Postavsky > > Date: Sun, 5 Jun 2016 13:05:53 -0400 > > Cc: John Mastro , 23574@debbugs.gnu.org, > cwoodbury@azavea.com > > > > On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: > > > We always try to make the empty space > > > after the end of a screen line have the same face as the last > > > character of that line. > > > > Just to clarify, "last character of that line" refers to the newline > > character or the one before it? > > The last displayed character of the line. The newline is not > displayed, in the sense that it has no glyph, so it can have no face. > > > > While it should be > > > possible to have GUI frames display underline all the way to window > > > edge, no one has ever requested that, so we didn't bother. > > > > I think this would have been useful for magit to simplify the use of > > overlays to display the region with horizontal lines. > > This is doable (and in fact we already do that in R2L paragraphs, > which you can observe if you change the recipe's text to use R2L > characters). But note that the OP in this bug report wants the exact > opposite: to NOT have the underlining extended on TTYs. So clearly > there's no "one size fits all" solution here. > > > In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you > > suggested a way using :align-to which turned out to have a bunch of > > complications and magit ended up not using it (see > > https://github.com/magit/magit/pull/2293). > > Did you try using the box attribute of a face? > -- Colin Woodbury Geotrellis Team @ Azavea --001a1140e420743c7205348c02d2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Interesting that you consider the the GUI _not_ displaying= the face all the way to end of screen to be a bug. I think only displaying= to the end of the characters (as shown in images in the Github issue) is t= he expected behaviour. Otherwise, the screen (at least with underlining) ge= ts quite noisy.

On Sun, Jun 5, 2016 at 10:56 AM, Eli Zaretskii &l= t;eliz@gnu.org> wrote:
> From: Noam Postavsky <= ;npostavs@users.sourcefor= ge.net>
> Date: Sun, 5 Jun 2016 13:05:53 -0400
> Cc: John Mastro <john.b.= mastro@gmail.com>, 23574@de= bbugs.gnu.org, cwoodbury@azavea= .com
>
> On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > We always try to make the empty space
> > after the end of a screen line have the same face as the last
> > character of that line.
>
> Just to clarify, "last character of that line" refers to the= newline
> character or the one before it?

The last displayed character of the line.=C2=A0 The newline is not displayed, in the sense that it has no glyph, so it can have no face.

> > While it should be
> > possible to have GUI frames display underline all the way to wind= ow
> > edge, no one has ever requested that, so we didn't bother. >
> I think this would have been useful for magit to simplify the use of > overlays to display the region with horizontal lines.

This is doable (and in fact we already do that in R2L paragraphs, which you can observe if you change the recipe's text to use R2L
characters).=C2=A0 But note that the OP in this bug report wants the exact<= br> opposite: to NOT have the underlining extended on TTYs.=C2=A0 So clearly there's no "one size fits all" solution here.

> In http://debbugs.gnu.org/cgi/bugreport.= cgi?bug=3D21468#43 you
> suggested a way using :align-to which turned out to have a bunch of > complications and magit ended up not using it (see
> https://github.com/magit/magit/pull/2293).

Did you try using the box attribute of a face?



--
Colin Wood= bury
Geotrellis Team @ Azavea
--001a1140e420743c7205348c02d2-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 14:36:01 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 18:36:01 +0000 Received: from localhost ([127.0.0.1]:55883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9cu1-0004ZF-I6 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 14:36:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9ctz-0004Z2-CP for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 14:35:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9ctq-0000PQ-R0 for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 14:35:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:60637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9ctq-0000PF-OM; Sun, 05 Jun 2016 14:35:50 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3545 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9ctn-0006Ep-NV; Sun, 05 Jun 2016 14:35:50 -0400 Date: Sun, 05 Jun 2016 21:36:01 +0300 Message-Id: <83shwrtre6.fsf@gnu.org> From: Eli Zaretskii To: Colin Woodbury In-reply-to: (message from Colin Woodbury on Sun, 5 Jun 2016 11:20:24 -0700) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Colin Woodbury > Date: Sun, 5 Jun 2016 11:20:24 -0700 > Cc: Noam Postavsky , john.b.mastro@gmail.com, > 23574@debbugs.gnu.org > > Interesting that you consider the the GUI _not_ displaying the face all the way to end of screen to be a bug. It's not a bug, it's the intended behavior. On GUI frames, the display engine only makes sure to extend the face if it has one or more of the following attributes: . background color . stipple . box > I think only displaying to the end of the characters (as shown in images in the Github issue) is the expected > behaviour. Otherwise, the screen (at least with underlining) gets quite noisy. Why would you have underlining span several lines if you don't want that effect? (I admit I didn't really understand the original use case which prompted this report.) Anyway, you've just heard of another application which would like the GUI frames behave like TTYs, not the other way around. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 15:13:08 2016 Received: (at 23574) by debbugs.gnu.org; 5 Jun 2016 19:13:09 +0000 Received: from localhost ([127.0.0.1]:55892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9dTw-0005W0-KK for submit@debbugs.gnu.org; Sun, 05 Jun 2016 15:13:08 -0400 Received: from mail-oi0-f45.google.com ([209.85.218.45]:34232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9dTu-0005VU-DH for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 15:13:06 -0400 Received: by mail-oi0-f45.google.com with SMTP id e72so197767175oib.1 for <23574@debbugs.gnu.org>; Sun, 05 Jun 2016 12:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=5h6N3Xu3EdMPmNm61OXuM+EE5EnOiax2HdnoMlhq8ZQ=; b=aKt6iJb8DuI8/pwnsmjFP5cLnuXsZcsuiWfZPPa9tORLz9NF7bAZxWjvTVh3vJJXNr xdDJCuoPIaeBaac8Xx7pONZ7qGyNLfP2tDojWHCXrHFOmp0HFKH3mYpkjseGJ3J9gizC HWs4hs51Bo8hyHhVIgor274PFWXu7m9M9T85DGxf9T/ZSxiYv4qw5dWu4iRyIgtHPicx uO/nj9qudkUa7ojswqBzqIZuBWuTRwK1a6pJ2+WzDiXy6fgLyX3TkknO241j3ryfOWL8 D1JnO8PyKN8FQckvSBvFh3mglXbutgXpzdPVSYNV2A5YcKdW5DuOyy9jUNkl21CNcusJ jLhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=5h6N3Xu3EdMPmNm61OXuM+EE5EnOiax2HdnoMlhq8ZQ=; b=PXd6fg3RzFp4C84+PptZfVSlZ85UK0n2Da7kfJgln1SwyurjrCUPT676jg5sr1ERB4 HhXbDbvwdoHKm3pYaN1NUk8CfFMyhBmFgPeEjMAWIik8Gyl0/hTYBsZWQFoGFw5lbxEU N090cMMqCjxJuW6v1bxduQ3CsU54XoePvDXV4DfcGl33Ql60BjT9YQSm7u2bX0J9m6kd aF7Tiwa/Oc02fSnW4K1sgIXx0ZwuZeD0O3l186TXaRNZdAjREKn+tJyVo2E208Atvisl A8UvsTEy8VsbvDwIiTUUoXi3cqu3PhFYFtOtCXdipZlz0NsjdJVgpy224Oej8b4yX1ZZ AgvQ== X-Gm-Message-State: ALyK8tLSBL+53XoRtOGeEup2xdbrWYP9RHC12ot7897BvZMQVHqs8i+IqWJnkRZMA/yS6NV51XGSjHDCJpU9Qw== X-Received: by 10.157.23.195 with SMTP id j61mr7557183otj.92.1465153980816; Sun, 05 Jun 2016 12:13:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Sun, 5 Jun 2016 12:13:00 -0700 (PDT) In-Reply-To: <83twh7tt83.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> From: Noam Postavsky Date: Sun, 5 Jun 2016 15:13:00 -0400 X-Google-Sender-Auth: cesdxdjJB5omYNezSYsAbmNn63Q Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, John Mastro , cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sun, Jun 5, 2016 at 1:56 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Sun, 5 Jun 2016 13:05:53 -0400 >> Cc: John Mastro , 23574@debbugs.gnu.org, cwoodbury@azavea.com >> >> On Sun, Jun 5, 2016 at 11:54 AM, Eli Zaretskii wrote: >> > We always try to make the empty space >> > after the end of a screen line have the same face as the last >> > character of that line. >> >> Just to clarify, "last character of that line" refers to the newline >> character or the one before it? > > The last displayed character of the line. The newline is not > displayed, in the sense that it has no glyph, so it can have no face. That doesn't seem to be the case, with the following modification to the recipe so that the newline characters are not underlined, the underlining does not continue to the edge of the screen: (let (beg end ov) (defface example-underline-face '((t :underline t)) "Example face with underlining") (goto-char (point-max)) (newline) (setq beg (point)) (insert " foo") (setq end (point)) (setq ov (make-overlay beg end)) (overlay-put ov 'face 'example-underline-face) (insert "\n") (setq beg (point)) (insert " bar") (setq end (point)) (setq ov (make-overlay beg end)) (overlay-put ov 'face 'example-underline-face) (insert "\n")) > >> > While it should be >> > possible to have GUI frames display underline all the way to window >> > edge, no one has ever requested that, so we didn't bother. >> >> I think this would have been useful for magit to simplify the use of >> overlays to display the region with horizontal lines. > > This is doable (and in fact we already do that in R2L paragraphs, > which you can observe if you change the recipe's text to use R2L > characters). Yes (though it seems R2L is disabled in programming modes by default, needed to use fundamental-mode buffer to see the effect). >> In http://debbugs.gnu.org/cgi/bugreport.cgi?bug=21468#43 you >> suggested a way using :align-to which turned out to have a bunch of >> complications and magit ended up not using it (see >> https://github.com/magit/magit/pull/2293). > > Did you try using the box attribute of a face? Yes, but magit actually wants a multiline box (without internal lines), so it didn't really work out (anyway, this is getting off-topic for this bug). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 05 22:26:48 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 02:26:48 +0000 Received: from localhost ([127.0.0.1]:56051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9kFc-0000Nd-J9 for submit@debbugs.gnu.org; Sun, 05 Jun 2016 22:26:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9kFY-0000NP-PA for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 22:26:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9kFS-0008Pp-BX for 23574@debbugs.gnu.org; Sun, 05 Jun 2016 22:26:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9kFN-0008PF-Dp; Sun, 05 Jun 2016 22:26:33 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3766 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9kFL-0004Qr-Fg; Sun, 05 Jun 2016 22:26:31 -0400 Date: Mon, 06 Jun 2016 05:27:04 +0300 Message-Id: <83r3cbt5l3.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sun, 5 Jun 2016 15:13:00 -0400) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Sun, 5 Jun 2016 15:13:00 -0400 > Cc: John Mastro , 23574@debbugs.gnu.org, cwoodbury@azavea.com > > >> Just to clarify, "last character of that line" refers to the newline > >> character or the one before it? > > > > The last displayed character of the line. The newline is not > > displayed, in the sense that it has no glyph, so it can have no face. > > That doesn't seem to be the case, with the following modification to > the recipe so that the newline characters are not underlined, the > underlining does not continue to the edge of the screen: When the newline does not have the underline attribute, the underline is not contiguous, so you are radically changing the use case. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 07:42:47 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 11:42:48 +0000 Received: from localhost ([127.0.0.1]:56222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9svf-0001wx-Nv for submit@debbugs.gnu.org; Mon, 06 Jun 2016 07:42:47 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:33812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9svb-0001wh-Of for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 07:42:46 -0400 Received: by mail-oi0-f68.google.com with SMTP id r4so4789308oib.1 for <23574@debbugs.gnu.org>; Mon, 06 Jun 2016 04:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=ijYzpp9OSc6XRb0h3UzAr3IlxHW+z3X6l3p16i23mSw=; b=GH+pfdyRCThiRMvs9lm1O/U/PEJTEUlkuDaSfjPuHdJMH8IPkydZ/6IUKvMUf1b4UI +PH4lGXosw9m7VjmMd8xbau/U0iv6XNCQb3aOJJZw5laOFfe1YOyTSCkFWo4D35Hgwfy zckVyeefDO3bHTQfv+SHU9u6zlBbspxJUX5FARrBkyxb23Asv/9/LYMZkBw4IGEU43kb Rn4ZI1uxOF6O9D8zXSQhgnhJCb2fw3BaE+BXz5IvorcQdgVYkYqKFkmGVh4q1ll3DMdJ FWizxhl5QeEGePQYZOUMikG5IsamTuUR4R/kpBXYnF4d7ZB5/jLLxeA3CguHibooFm06 8E3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=ijYzpp9OSc6XRb0h3UzAr3IlxHW+z3X6l3p16i23mSw=; b=Td4FplERWoYYViBDaerGb5Un/WiTjt5fZ+blIHnokAaZYDxSKTyqHB4dd1F68j3e8r 4Az9zWR6Vgmwq3LWxp8/rVjC1CasMrgEn0ozz+l7IduZmffM/usEDf2OE7WPlWvIXP5U 2qxrCsq/g5yInXlSvpnu4xKbtqigm2fSjRvMazV8H8o8wK4RwJ/pv7xh3PXvHeLs3TUc uv0vPAUVvWj0it8yvQX9Qggxiw/EK3b3R12oBiDIzyU5bqf9I1JK/fBdwTSoJ233ugAn i8xJUaXAjS90o2pTBSaPTfnjWkWdOGY6dD1DRX924ezYEJbwanQiIAyikbNNFcBg/fe3 z5tA== X-Gm-Message-State: ALyK8tIz5lGiGu3VJhqTmnP24sM0jHyGSjDzQ78Kpgug0QUihWqOnnEBwqqmD6EL9rHSauwXntJhFoi8Ni/qjg== X-Received: by 10.157.1.11 with SMTP id 11mr8791465otu.17.1465213358098; Mon, 06 Jun 2016 04:42:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Mon, 6 Jun 2016 04:42:37 -0700 (PDT) In-Reply-To: <83r3cbt5l3.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> From: Noam Postavsky Date: Mon, 6 Jun 2016 07:42:37 -0400 X-Google-Sender-Auth: kmR8_Bg1BQFL1EMRn0psiW3-Lxo Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, John Mastro , cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tag 23574 + notabug quit On Sun, Jun 5, 2016 at 10:27 PM, Eli Zaretskii wrote: >> That doesn't seem to be the case, with the following modification to >> the recipe so that the newline characters are not underlined, the >> underlining does not continue to the edge of the screen: > > When the newline does not have the underline attribute, the underline > is not contiguous, so you are radically changing the use case. Yes. However, I believe that this is what the original ensime code intended to do; it only underlines the newlines themselves because it's easier to make 1 overlay for all the lines at once and the programmer didn't notice it was wrong because it happens to give the desired effect in GUI mode. Regardless, by experimentation I find that the space at the edge of the screen takes the face from the final newline, not the last displayed glyph character in the line. Is this documented anywhere? From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 11:03:57 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 15:03:57 +0000 Received: from localhost ([127.0.0.1]:56900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9w4K-0008Vi-Ph for submit@debbugs.gnu.org; Mon, 06 Jun 2016 11:03:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51735) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9w4J-0008VV-Fi for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 11:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9w4D-0004Sj-CF for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 11:03:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9w49-0004OO-5C; Mon, 06 Jun 2016 11:03:45 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9w46-0007dk-Tj; Mon, 06 Jun 2016 11:03:43 -0400 Date: Mon, 06 Jun 2016 18:04:16 +0300 Message-Id: <83h9d6tl3j.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Mon, 6 Jun 2016 07:42:37 -0400) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Mon, 6 Jun 2016 07:42:37 -0400 > Cc: John Mastro , 23574@debbugs.gnu.org, cwoodbury@azavea.com > > > When the newline does not have the underline attribute, the underline > > is not contiguous, so you are radically changing the use case. > > Yes. However, I believe that this is what the original ensime code > intended to do; it only underlines the newlines themselves because > it's easier to make 1 overlay for all the lines at once and the > programmer didn't notice it was wrong because it happens to give the > desired effect in GUI mode. I don't see how the effect on GUI frames could be considered "desired". What about the fact that the underline extends one space beyond the line's text? So on GUI frames we see the same problem, just of smaller dimensions. Or am I missing something? > Regardless, by experimentation I find that the space at the edge of > the screen takes the face from the final newline, not the last > displayed glyph character in the line. Is this documented anywhere? That space at the edge of the line is not a space at all, although it looks like one. It is a special glyph produced by the display engine, primarily so that we could display the cursor at the end of the line. Its attributes are invented by the display engine out of thin air for its own purposes; for example, the buffer position recorded in that glyph is zero, not the position of the newline. As for your conclusion, I believe there's a misunderstanding here. You are talking about the face of a buffer position, while I was talking about the glyphs on the screen. Other that this minor disconnect, I don't see any contradiction between what we say. Also note that the display engine doesn't examine each character's face when it produces glyphs for display, it only examines the faces where they change. Which in this case means that the face of the newline is immaterial; what matters is whether it is identical to that of preceding characters. To be precise, the face used for extension is the one loaded into the iterator object when it hits the end of the line. As there are too many ways to specify faces in Emacs, I won't risk confirming that your conclusion is 100% correct ;-) My description is correct, but perhaps less useful to a Lisp programmer. As for documentation: these all are fine details of the display engine that are not documented anywhere except in the code comments. Even the face extension itself isn't mentioned anywhere, I believe simply because the effect is natural and expected, whereas its accurate documentation is not simple at all. Does it really make sense to document just this specific subtlety? IOW, if you are interested in these details, you should be hacking the display engine code long ago ;-) Going back to the bug report, there's still one issue to consider: should we add underline (and then also overline and strikethrough) to the list of face attributes that cause face extension on GUI frames. The logic behind the current code seems to be to extend attributes that are related to background of the text. The above 3 seem to be a kind-of background, so maybe we should add them. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 12:55:12 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 16:55:12 +0000 Received: from localhost ([127.0.0.1]:56968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9xnz-0002f6-RC for submit@debbugs.gnu.org; Mon, 06 Jun 2016 12:55:12 -0400 Received: from mout.gmx.net ([212.227.15.19]:65289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9xny-0002es-OQ for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 12:55:11 -0400 Received: from [192.168.1.100] ([212.95.7.21]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MDymt-1bFiQp3xQV-00HPO6; Mon, 06 Jun 2016 18:54:49 +0200 Message-ID: <5755AACE.8030303@gmx.at> Date: Mon, 06 Jun 2016 18:54:38 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii , Noam Postavsky Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> In-Reply-To: <83h9d6tl3j.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:AvxGRgta28484ynJfZKp03uRHh9+60K0WsnQCuNWtbctZQntyKV obgVrGcZgTpAZ0NNSYGZo4F71B8Q6syVr0ckrTEwwKdsq3mSYnnvnfOE0PaD+p0ejMiazA5 fENb2AinBxJ2iuv9LWssq/fZR4Ww4XTRnO46Vd15rqzLcch3pH7w7bjcNKcXDmo9REKRA4+ 8GKtgsAo84KoHbG3OlyCg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nrhlqB4OooY=:XiZEwqY2hxCIKrZ7UJla7I 9l5YlmepekxJZ34FrW1c+JoNkSy8WQV+ncvu0Bm3ioAcRNvYN7pvcooi7ZfQadlikkvdRU4VD cXiAML0/DrBMfosjNIaBBRlkzAI1pTum52D9Ar9tDLDDpYXYtdElswnyawJ+tro69TkrdgGTa EvhsQsEnEoGOgvZ/EwvkHCgSiUTrZ0xTZiradgkx5nr5gO4VMHPjZ0zekZ2nVqaN+kaPGWx4z kxWC5LTv/KTZ9bkZ7GgEVONvaZ82apLWa0RdTqKzOG2Bfpx8FihxwmyVwxhjsSzL+7DEHhQux xjevna08plrN0GwpGhgA4oRbfhUXDL0cUdOKJB2B7LS0NV3TJK1GZ2RyJcrjOn5dWh91OX/Yn NjCZ0UA9MWgvBPP+W7VkTxd+Ty5X/kPq2IiiTcOXW9ALLdl4SNI78QKlstETUKfNh5VLBN9ON UGtAiFWMVDk9IBw6MehWLxqDIKPspCzBtqjBifW+fJPbVa0khmgxU8sr9q3W52Mm7XUHzU/Pv aQxJ58iGN2Tvp1iZUrhPtmTG3MOd96NiNj6SMxR3cPmXyTbnA/SnpQPu6ssbR1nLd05VqUzIX w8AHgw9mZZnAjnHP5dDvAE9NpO9GgyNT4rtmuBlr7DQ67rg59PQ4FscOLtVNnMt2Ua3GL2vRZ prO3vlu00mQi+qwxzIxYRmhuj0xWtbP1tAFAwWt+fh/OqpZzZWZJRn5Lp1fOdGploxFGvjKwv 1vIvuvN5zGhbUz/rOOuCW57A29A5SA0nMG7Ym4KELX1MzzWNFg5NPCGsVje+GVMhKJSamjPHh 5EV1+lvAk58Rk1iQ4nc7606icCQPg== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > Going back to the bug report, there's still one issue to consider: > should we add underline (and then also overline and strikethrough) to > the list of face attributes that cause face extension on GUI frames. > The logic behind the current code seems to be to extend attributes > that are related to background of the text. The above 3 seem to be a > kind-of background, so maybe we should add them. It would make my life much easier if face extension were, in general, customizable. I would immediately turn it off everywhere. My motivation is that I have font-lock distinguish things like comments and strings mainly by their background face. Since these look awful when extending to the end of a window, I have to provide my own =E2=80=98font-lock-fontify-syntactically-region=E2=80=99 function which a= ssures that newline characters within strings and comments never get the corresponding face. This consumes resources and, for example, disallows using text properties to skip the rest of a comment or a string. It goes without saying, that my version of this function is never in synch with the one of the repository. I also use separate background colors for editable fields, buttons, links and the like which also look awful when spanning two or more lines. No font-locking can help me here. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 14:25:45 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 18:25:45 +0000 Received: from localhost ([127.0.0.1]:57015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9zDc-0006T7-NH for submit@debbugs.gnu.org; Mon, 06 Jun 2016 14:25:45 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:35977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9zDZ-0006Sq-DG for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 14:25:43 -0400 Received: by mail-lf0-f46.google.com with SMTP id b73so100086148lfb.3 for <23574@debbugs.gnu.org>; Mon, 06 Jun 2016 11:25:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=azavea.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N0gbSWtguH7VIauXQSYveePOBZQeMXJJbaijpUiOAqI=; b=iz0hq1GTjENt4HH/TYxYk4EaH8VFX42flpioETuK9CGZ14nHd5UYvFiF/ei5Y81cUd PMzNjRTqL/OCz6Kvzem/fifLJSLeab7yzrZ2kmiNLuygy/8Aq5ldXY+bc5uw0VDVz5ie f/tGYX05LiwpbdJaVNQvFYK0aAhH5o9jno0VU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N0gbSWtguH7VIauXQSYveePOBZQeMXJJbaijpUiOAqI=; b=NJd7A/0roiBFn2Efrz5bCjgYTo1TGRLXi/H+5h/9OT2LRsNlANgy18hg7ewufjLgT2 Quk2lhZNT9y7SOBHlhTdPksjJv/crpfpmHBfJ6BOHYoF4Ri5JXpzig6RRBENDOmfOsp7 GyI1DAtYCESHVLwJ59bGWPBDOKhz+YxPqBy2NV+U7CbUl9l3lWfPfYYUO1HAvBKoBN79 2E2fQdXNOhU8GqSaICOYJZBBPAZvEovSohveToIMR+DLgYWrf2JqDYws1IltEzUv6I35 xrxI+RlrHV+RF3Rvr9ZSQrRofbU15Zs+V6Ho7U8LPdmpgh5bzeN53T96yhmkBkfl/HDG Vrcw== X-Gm-Message-State: ALyK8tIUovG97N8wI5xhf3Tj5UbhuwPOZ2YgNzYIQngZ5JHpf14tIcgrOusdhOk4aDzjmXDkrR85tK39wTZZ57Yp X-Received: by 10.25.170.140 with SMTP id t134mr1367497lfe.17.1465237535382; Mon, 06 Jun 2016 11:25:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.32.212 with HTTP; Mon, 6 Jun 2016 11:25:34 -0700 (PDT) In-Reply-To: <5755AACE.8030303@gmx.at> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> From: Colin Woodbury Date: Mon, 6 Jun 2016 11:25:34 -0700 Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: martin rudalics Content-Type: multipart/alternative; boundary=001a1141146acef5a90534a03207 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, John Mastro , Eli Zaretskii , Noam Postavsky X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1141146acef5a90534a03207 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable > Yes. However, I believe that this is what the original ensime code > intended to do; it only underlines the newlines themselves because > it's easier to make 1 overlay for all the lines at once and the > programmer didn't notice it was wrong because it happens to give the > desired effect in GUI mode. I think that's the case. The purpose of the underlining is to show where "Scala implicits" are occuring. An implicit is some code brought into scope through imports, often used for silent conversion to inject methods into preexisting datatypes. Essentially that with "traits" are how Scala hacks Haskell typeclasses. If your statement that uses an implicit happens to span multiple lines, ensime (I believe) just finds the starting and ending points of the statement and applies the face to the entire area. In the GUI, this happens to produce the desired effect of only underlining where characters are (with the newline as well, as mentioned previously). In TTY this places the face over everything, which we don't agree is a bug or not. On Mon, Jun 6, 2016 at 9:54 AM, martin rudalics wrote: > > Going back to the bug report, there's still one issue to consider: > > should we add underline (and then also overline and strikethrough) to > > the list of face attributes that cause face extension on GUI frames. > > The logic behind the current code seems to be to extend attributes > > that are related to background of the text. The above 3 seem to be a > > kind-of background, so maybe we should add them. > > It would make my life much easier if face extension were, in general, > customizable. I would immediately turn it off everywhere. > > My motivation is that I have font-lock distinguish things like comments > and strings mainly by their background face. Since these look awful > when extending to the end of a window, I have to provide my own > =E2=80=98font-lock-fontify-syntactically-region=E2=80=99 function which a= ssures that > newline characters within strings and comments never get the > corresponding face. This consumes resources and, for example, disallows > using text properties to skip the rest of a comment or a string. It > goes without saying, that my version of this function is never in synch > with the one of the repository. > > I also use separate background colors for editable fields, buttons, > links and the like which also look awful when spanning two or more > lines. No font-locking can help me here. > > martin > > --=20 Colin Woodbury Geotrellis Team @ Azavea --001a1141146acef5a90534a03207 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
> Yes. However, I believe that this is what t= he original ensime code
> intended to do; it only underlines the newlines themselves because
> it's easier to make 1 overlay for all the lines at once and the > programmer didn't notice it was wrong because it happens to give t= he
> desired effect in GUI mode.

I think that's the case. = The purpose of the underlining is to show where "Scala implicits"= are occuring. An implicit is some code brought into scope through imports,= often used for silent conversion to inject methods into preexisting dataty= pes. Essentially that with "traits" are how Scala hacks Haskell t= ypeclasses.

If your statement that uses an implicit happens t= o span multiple lines, ensime (I believe) just finds the starting and endin= g points of the statement and applies the face to the entire area. In the G= UI, this happens to produce the desired effect of only underlining where ch= aracters are (with the newline as well, as mentioned previously). In TTY th= is places the face over everything, which we don't agree is a bug or no= t.

On Mo= n, Jun 6, 2016 at 9:54 AM, martin rudalics <rudalics@gmx.at> w= rote:
> Going back to= the bug report, there's still one issue to consider:
> should we add underline (and then also overline and strikethrough) to<= br> > the list of face attributes that cause face extension on GUI frames. > The logic behind the current code seems to be to extend attributes
> that are related to background of the text.=C2=A0 The above 3 seem to = be a
> kind-of background, so maybe we should add them.

 It would make my life much easier if face extension were, in general,
customizable.=C2=A0 I would immediately turn it off everywhere.

My motivation is that I have font-lock distinguish things like comments
and strings mainly by their background face.=C2=A0 Since these look awful when extending to the end of a window, I have to provide my own
=E2=80=98font-lock-fontify-syntactically-region=E2=80=99 function which ass= ures that
newline characters within strings and comments never get the
corresponding face.=C2=A0 This consumes resources and, for example, disallo= ws
using text properties to skip the rest of a comment or a string.=C2=A0 It goes without saying, that my version of this function is never in synch
with the one of the repository.

I also use separate background colors for editable fields, buttons,
links and the like which also look awful when spanning two or more
lines.=C2=A0 No font-locking can help me here.

martin




--
<= div>Colin Woodbury
Geotrellis Team @ Azavea
--001a1141146acef5a90534a03207-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 14:55:14 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 18:55:14 +0000 Received: from localhost ([127.0.0.1]:57030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9zg9-0007Ae-O6 for submit@debbugs.gnu.org; Mon, 06 Jun 2016 14:55:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b9zg8-0007AS-8F for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 14:55:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9zfy-00032c-B0 for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 14:55:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9zfm-0002zT-Qn; Mon, 06 Jun 2016 14:54:50 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4148 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1b9zfi-0006ki-Us; Mon, 06 Jun 2016 14:54:49 -0400 Date: Mon, 06 Jun 2016 21:55:10 +0300 Message-Id: <831t4ataep.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5755AACE.8030303@gmx.at> (message from martin rudalics on Mon, 06 Jun 2016 18:54:38 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Mon, 06 Jun 2016 18:54:38 +0200 > From: martin rudalics > CC: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com > > > Going back to the bug report, there's still one issue to consider: > > should we add underline (and then also overline and strikethrough) to > > the list of face attributes that cause face extension on GUI frames. > > The logic behind the current code seems to be to extend attributes > > that are related to background of the text. The above 3 seem to be a > > kind-of background, so maybe we should add them. > > It would make my life much easier if face extension were, in general, > customizable. I would immediately turn it off everywhere. Can you suggest a defcustom for that (what type? which values mean what? etc)? Then we can talk how hard it is to implement that. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 15:18:18 2016 Received: (at 23574) by debbugs.gnu.org; 6 Jun 2016 19:18:18 +0000 Received: from localhost ([127.0.0.1]:57063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA02U-0007ih-F1 for submit@debbugs.gnu.org; Mon, 06 Jun 2016 15:18:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA02S-0007iV-WB for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 15:18:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bA02M-0002e8-LJ for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 15:18:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57824) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bA02H-0002ZC-JC; Mon, 06 Jun 2016 15:18:05 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4155 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bA02E-0003o9-Co; Mon, 06 Jun 2016 15:18:04 -0400 Date: Mon, 06 Jun 2016 22:18:33 +0300 Message-Id: <83vb1mrura.fsf@gnu.org> From: Eli Zaretskii To: Colin Woodbury In-reply-to: (message from Colin Woodbury on Mon, 6 Jun 2016 11:25:34 -0700) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, rudalics@gmx.at, john.b.mastro@gmail.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Colin Woodbury > Date: Mon, 6 Jun 2016 11:25:34 -0700 > Cc: Eli Zaretskii , Noam Postavsky , 23574@debbugs.gnu.org, > John Mastro > > If your statement that uses an implicit happens to span multiple lines, ensime (I believe) just finds the starting > and ending points of the statement and applies the face to the entire area. In the GUI, this happens to produce > the desired effect of only underlining where characters are (with the newline as well, as mentioned > previously). Once again, there _is_ no newline. It is not displayed. What you see is an empty character cell produced for displaying the cursor. It has no direct relation to the newline. And I don't think what you get is the desired effect, you just get a side effect of a particular implementation detail. E.g., what happens if a line fits exactly on a line, i.e. the cursor at its end will be displayed on the fringe? > In TTY this places the face over everything, which we don't agree is a bug or not. It isn't a bug, because that's how the display engine was coded to work. Of course, we can make it behave differently if we want. From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 06 20:18:15 2016 Received: (at 23574) by debbugs.gnu.org; 7 Jun 2016 00:18:15 +0000 Received: from localhost ([127.0.0.1]:57275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA4ik-0001A5-Un for submit@debbugs.gnu.org; Mon, 06 Jun 2016 20:18:15 -0400 Received: from mail-oi0-f44.google.com ([209.85.218.44]:33272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bA4ii-00019r-SS for 23574@debbugs.gnu.org; Mon, 06 Jun 2016 20:18:13 -0400 Received: by mail-oi0-f44.google.com with SMTP id k23so252381724oih.0 for <23574@debbugs.gnu.org>; Mon, 06 Jun 2016 17:18:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lY/4c4xQKk1IABch08vPmPd0HxEjECVI+gKbPefmoIw=; b=p6Cn8dVJapvHle7oCAhS7RB6ajHRS0oMQpXHA1i4Mm6UEfSbL3HOveZX9IE7K7/I4y 0wg4tr78xhlkrryy9BSZPkTms2Zl4dsPo2LhBdN1IyEcNA5W8ppieZrrHltF+yyoWRyQ ifiPxd+sEJLWL8v5xKVAIAZNyRqeBJTf9YdEN0JpK4VQjvIbjHlxbG2Q607d0oUk+52x lS+3FNIowhsCb7tW4eVotCUnng7CgriMpiC0MkR+L8DnQ+LYu+sUgBIIjjtn1SAqZ/tZ /w9VDcuRepUAHW2Id7BSokTr0LnmxMk2+/WftZJ9YsnFfkXj0WBNPstOkQSxjfXnnbTg pzng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lY/4c4xQKk1IABch08vPmPd0HxEjECVI+gKbPefmoIw=; b=DfXUqUPiVwyOmXKqImGjaKiJh/y+GXaI++5D3ZTs/s9Tcqi5pQtvdFUYHZFzpBEFe/ KLuInqMfKPu1opy/ElviF1F5ZpgiB547AlFt1UkFeB/HIc28XzDEmc/dmoB/vpGDe7wm num89YNmVQML90avQ/2h2EUwT2clTIlYfqw9ubJqY6XSd8NaXObd2sOrR1iNVfdPA7Z3 49pknBkbh/p1ZORS3cgIahyjBTzwzCStezcSKyL4pWxaQAaj7VQs6P2XhcQHUHK87j/D tDt+zAEtoyEtsbbhX2PNs5w2nMOytD8HZwRC9Ur3D9H4IlgBkeEGulhXqczN9oTQsjP4 jt2A== X-Gm-Message-State: ALyK8tKUDtvXqK8yzhCqhylnYpt24hYma8mZyyD+60IFxKSG9Z2S6T+1nKYgFSQOomUkg+v1uW0urHkPzlr/Rg== X-Received: by 10.157.51.74 with SMTP id u10mr10665399otd.124.1465258687201; Mon, 06 Jun 2016 17:18:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Mon, 6 Jun 2016 17:18:06 -0700 (PDT) In-Reply-To: <83vb1mrura.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <83vb1mrura.fsf@gnu.org> From: Noam Postavsky Date: Mon, 6 Jun 2016 20:18:06 -0400 X-Google-Sender-Auth: 1sL_VSZYkO1GLN1XzTYSZuQMuWk Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, martin rudalics , Colin Woodbury , John Mastro X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Mon, Jun 6, 2016 at 3:18 PM, Eli Zaretskii wrote: > And I don't think what you get is the desired effect, you just get a > side effect of a particular implementation detail. E.g., what happens > if a line fits exactly on a line, i.e. the cursor at its end will be > displayed on the fringe? The underlining does reach the end of the screen in this case, but it still looks okay because the underlining doesn't extend too far away from the text. > >> In TTY this places the face over everything, which we don't agree is a bug or not. > > It isn't a bug, because that's how the display engine was coded to > work. Of course, we can make it behave differently if we want. I think it makes sense to not do the face extension by default. If I take a sheet of paper and underline lines 3 to 10, I'm going to stop drawing at the end of the text, not go all the way to end of the paper. For the case I mentioned earlier, magit isn't actually underlining text, it just wants to make some horizontal lines. It would be nice to have some way to ask the display engine to do this directly. From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 05:11:03 2016 Received: (at 23574) by debbugs.gnu.org; 7 Jun 2016 09:11:03 +0000 Received: from localhost ([127.0.0.1]:57436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAD2N-0006w3-2F for submit@debbugs.gnu.org; Tue, 07 Jun 2016 05:11:03 -0400 Received: from mout.gmx.net ([212.227.15.18]:49355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAD2M-0006vT-1N for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 05:11:02 -0400 Received: from [192.168.1.100] ([212.95.7.102]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MVvB2-1azK1Y0vu4-00X6Cs; Tue, 07 Jun 2016 11:10:40 +0200 Message-ID: <57568F86.8040902@gmx.at> Date: Tue, 07 Jun 2016 11:10:30 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> In-Reply-To: <831t4ataep.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/TNFOiuAWjzpbdf3dhcyo6hSWcdNAQgIHm7eALnC+0EzJqT0rVZ nSKTIQmPTvnMGGNNCk0uRShXlDVtBpX83vbs5FNqerV7lyhihgJipamyMZTTeleMBBkCznX KHE4+GXJinaQCapeIDHnj7Oheiljc3m2HVd1Axj7UC0P+WzsQ3okfqrXARSQOaiNdU25Ivp e7EvotUQRsYqcPrZYKNmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:MRavQ8UYyNU=:E2u5TzbgLHIF0WF+MEGitQ 1bJh7OlCI0aQqiD1eVTxIeLAVZzARRsKvBk1XSbpXE5cbE2ySPcWBHMmwPQ5h3oweKLLrl5Yi 0hVWkZvQPxiZTio8DcmU6uHHqOFt35q9PIgWUhiOh0By9dqKQl/N8moROXNDF2jhgSTC9lj1u Mc329DUVCIb/zQ4uYcez4mvWeef/Y2QpcKrrDFl7Lu3ByOaNHWj40JcPKwUHOawFjUE2MXqtO kggYVy3FFQLeijrmNlVRHNZnMZm7YqCvFj7KVeE4/ZmkqxUy17qDnWcEMS6l1B2vI8nAmimMi r5lMvQmQPR+k/dfY0zBe/lcqe7+ab6LIsyRZpd4zd4tlw9sN7XQ2amLFRCwHUFZk4fqWdGxog KqLCslIAe3kDJeBBQMweLUc3gpo0yXJ/7tCM1PVshJZseW5i20AfKCDPXazj86ezImzYR+GRc IvVVuSPSHJqgPitrT7ggXg0nP4jr0ZuuDy3T33rsXJ0tue/Rd6DCKChc+4tPlBBBKro/6ZXXO t1XJwPCPSv0Gq7huozZxrgw2723YrDllHxWhD7Xv1zg9JMSQoe3gDit7fKeMN8PAwCniThVxm aMWnQ4IeieAjqgjxfwnnX6aLwydoJzh6rHst1XBWTesaTqJducrjV9E89UgSph0MQ0jIMuwgW n2SS0NLfWP4DOQewQFwaV0DvY4m40JeBXJ+IWi8NXE5xKIjGHNFURZLTjYDSYgCBFBhTtx6kW p8melaP2tjllf7KzQm4CJTpPrTGUdbKKybUrqKnsRDEaRE7x4fpWEY+ZcsBDRHkSPuZhrt3DX v4KsRgto845QfSZxfac6rroMO2zPA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Can you suggest a defcustom for that (what type? which values mean > what? etc)? Then we can talk how hard it is to implement that. (defcustom face-extend-to-window-edge nil "Non-nil means extend face of last character on line to window edge. This variable specifies whether the space following the last character on a line is decorated using properties of that character. nil means do not extend any properties of that character. t means extend all properties of that character. A property list means to determine the value of any such property from that list. If a property is not on that list, that property is not extended. The special value 'inherit' means to inherit the value for that property from the last character on the line. A function specifies the function to return the value of that property. Any other value means to extend that as value for that property.") martin From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 11:50:08 2016 Received: (at 23574) by debbugs.gnu.org; 7 Jun 2016 15:50:08 +0000 Received: from localhost ([127.0.0.1]:58903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAJGa-00020Y-7e for submit@debbugs.gnu.org; Tue, 07 Jun 2016 11:50:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAJGY-000200-1B for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 11:50:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAJGR-00054q-ME for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 11:50:00 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51786) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAJGK-00053Q-3y; Tue, 07 Jun 2016 11:49:52 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4677 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAJGH-0001q9-Jh; Tue, 07 Jun 2016 11:49:50 -0400 Date: Tue, 07 Jun 2016 18:50:25 +0300 Message-Id: <83eg89roam.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <57568F86.8040902@gmx.at> (message from martin rudalics on Tue, 07 Jun 2016 11:10:30 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Tue, 07 Jun 2016 11:10:30 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > (defcustom face-extend-to-window-edge nil > "Non-nil means extend face of last character on line to window edge. > This variable specifies whether the space following the last > character on a line is decorated using properties of that > character. nil means do not extend any properties of that > character. t means extend all properties of that character. > > A property list means to determine the value of any such property > from that list. If a property is not on that list, that property > is not extended. The special value 'inherit' means to inherit > the value for that property from the last character on the line. > A function specifies the function to return the value of that > property. Any other value means to extend that as value for that > property.") Talk about over-specification ;-) I hope you realize how some of that will make redisplay much more expensive? How about the following more modest alternative? (defcustom face-extend-to-window-edge t "Non-nil means extend face of last character on line to window edge. Certain face attributes, if present in the face of the last character of a line and different from those of the default face, cause the empty space following the end of text on the line to be drawn with those attributes, to give the empty space appearance similar to that of the preceding text. These attributes are those which affect the background of a face: `:background', `:stipple', `:box', `:underline', `:overline', and `:strike-through'. By default, if the face of a line's last character has any of these attributes, and the value is different from that of the default face, the empty space following the line's text will be drawn in the face of the last character. This variable allows fine-tuning which attributes trigger the face extension. The default value of t means any of the mentioned attributes will cause face extension. The value of nil means face extension is turned off. A value that is a list of attributes will extend the face only if any of the attributes from the list are present in the last character's face. Note that only attributes from the above list are meaningful in list values of this variable.") From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 11:55:34 2016 Received: (at 23574) by debbugs.gnu.org; 7 Jun 2016 15:55:34 +0000 Received: from localhost ([127.0.0.1]:58911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAJLq-000285-5n for submit@debbugs.gnu.org; Tue, 07 Jun 2016 11:55:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAJLo-00027t-Oq for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 11:55:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAJLi-0006B0-PB for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 11:55:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAJLd-0006Ac-BB; Tue, 07 Jun 2016 11:55:21 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4680 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAJLb-0002b6-DE; Tue, 07 Jun 2016 11:55:19 -0400 Date: Tue, 07 Jun 2016 18:55:55 +0300 Message-Id: <83bn3dro1g.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Mon, 6 Jun 2016 20:18:06 -0400) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <83vb1mrura.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, rudalics@gmx.at, cwoodbury@azavea.com, john.b.mastro@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Mon, 6 Jun 2016 20:18:06 -0400 > Cc: Colin Woodbury , martin rudalics , 23574@debbugs.gnu.org, > John Mastro > > I think it makes sense to not do the face extension by default. Not even for the background color? Or are you talking only about the underline? > For the case I mentioned earlier, magit isn't actually underlining > text, it just wants to make some horizontal lines. It would be nice to > have some way to ask the display engine to do this directly. There's a way of doing that which we use in the VC commit log buffer, I believe it uses the line-height property. (I thought magit was using that as well, no?) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 22:52:34 2016 Received: (at 23574) by debbugs.gnu.org; 8 Jun 2016 02:52:34 +0000 Received: from localhost ([127.0.0.1]:59355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bATbd-0000qW-Nq for submit@debbugs.gnu.org; Tue, 07 Jun 2016 22:52:33 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:34965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bATbc-0000qK-1U for 23574@debbugs.gnu.org; Tue, 07 Jun 2016 22:52:32 -0400 Received: by mail-oi0-f53.google.com with SMTP id s139so68499202oie.2 for <23574@debbugs.gnu.org>; Tue, 07 Jun 2016 19:52:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=psa68JqwEQICRwaXxZZsVMaCc4rNQpQSV7Qld792UfU=; b=iBgLpzjXSC7skC/6aYfw41jtfO2DO6e4cWsag1dUy23WDSIKfP9NTjAS0YI0lywFaO uP4TaZ7cn4IjofY1xYpUeGxxexVarbTjDSs4FbUWFuMUO6LLGXabH5gHSMU9oQSHZRpf JZ4lRElPrJJ3425vjMyUSi3pp6PugRtxVbdtBpy98k89MgejEixXvjZDgFrRvIdjjvAn XUW4qdw6mfxCt6mpuHhw1mivbSsE3cI7KpCi6BfSLqQ5KzQoIi+xpnKKrgfZ1rDlLWUl MbNWwIfoFVx8KQmTBcCpI1gXQA6WPyuXc+nzy2lZEEQkPoQDOFbS5WOLGYq1hFRA8pD+ gliw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=psa68JqwEQICRwaXxZZsVMaCc4rNQpQSV7Qld792UfU=; b=c0HJ93euelAoXmZnPSfI4ZzYaVseiEOrCv1KaHk56Fr16HvtBAHzXidn5EJsnsoyTf MP4uyPnsjkLdrVzoGbWi1glEeZXvrjLILDh2cjpEmV2hlUcm59ejEiHmfkxS4IxWCr9S 1VxiFgPV7O5mEXf6kaC4sVDnpsMGdRX9Ml0EZrQIFoqu1LnJZVEPQks9I44wfc+S9DQX vznIWlTutyuRQ2IicvlwEB8NQV6W03jTDnN/MDNbxWn567dMxNDpFyLXyWQjFBsxDnkF flSs4O75xVyMlFGPlOtlCsUQcMfsEbAirAOh1oHxVPKz+kKOFU2Vr8713BWSYAMWWVTu HgGQ== X-Gm-Message-State: ALyK8tJ1KlBEL0GnacAOwJ02B4rLmekDtY0cIo2uA29TlevWsbQ9EG/vvVI+sirNtqs8ljQLrIosE1I9SXos7Q== X-Received: by 10.202.168.131 with SMTP id r125mr1613934oie.40.1465354346384; Tue, 07 Jun 2016 19:52:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.5.168 with HTTP; Tue, 7 Jun 2016 19:52:25 -0700 (PDT) In-Reply-To: <83bn3dro1g.fsf@gnu.org> References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <83vb1mrura.fsf@gnu.org> <83bn3dro1g.fsf@gnu.org> From: Noam Postavsky Date: Tue, 7 Jun 2016 22:52:25 -0400 X-Google-Sender-Auth: 3W4sKS_7YIdCLvbdZsfkapP_nMA Message-ID: Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, martin rudalics , Colin Woodbury , John Mastro X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Tue, Jun 7, 2016 at 11:55 AM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Mon, 6 Jun 2016 20:18:06 -0400 >> Cc: Colin Woodbury , martin rudalics , 23574@debbugs.gnu.org, >> John Mastro >> >> I think it makes sense to not do the face extension by default. > > Not even for the background color? Or are you talking only about the > underline? Well, I was thinking mostly about underlining, but imagining a scenario with paper again, if I'm highlighting text with a marker, I wouldn't go to edge of the page there either. For some applications, the intention is to colour a whole block, not just the text. So I think it's better to let the code making the faces have a way to indicate which scenario is intended rather than relying on user customization. > >> For the case I mentioned earlier, magit isn't actually underlining >> text, it just wants to make some horizontal lines. It would be nice to >> have some way to ask the display engine to do this directly. > > There's a way of doing that which we use in the VC commit log buffer, > I believe it uses the line-height property. (I thought magit was > using that as well, no?) Yes, and it caused some problems with cursor movement that you weren't so happy about fixing. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 02:34:05 2016 Received: (at 23574) by debbugs.gnu.org; 8 Jun 2016 06:34:05 +0000 Received: from localhost ([127.0.0.1]:59627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAX41-0004V0-J5 for submit@debbugs.gnu.org; Wed, 08 Jun 2016 02:34:05 -0400 Received: from mout.gmx.net ([212.227.15.15]:54487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAX3y-0004UX-NP for 23574@debbugs.gnu.org; Wed, 08 Jun 2016 02:34:03 -0400 Received: from [192.168.1.100] ([212.95.7.45]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lrviw-1bbMol1IVi-013e49; Wed, 08 Jun 2016 08:33:41 +0200 Message-ID: <5757BC3A.5070402@gmx.at> Date: Wed, 08 Jun 2016 08:33:30 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> In-Reply-To: <83eg89roam.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:wDZl+GVu88MScdqVgzCgpDq8k9dGnWRjCuQyEOl/ngVw5EIxx/G xn97dd3tVUGwzNvP9m03L/K+n11iGjMBuIW4vSZbl/7QNtl8/zwebxkiQ5mwgJutTj9E34N quDGJLkSl1/sP7zVerHCGCEWDSUVt6GIEutRSbkhLY7YSFK1aKSekoPguPNYue2RB1LaKUX GO/OEzAhH+Bezpu1oivuA== X-UI-Out-Filterresults: notjunk:1;V01:K0:2du28GkSw5Y=:9UY4LZ02m9Sv32sSa2/k/6 BZGXbM9FI0MyvmzPKMlmdt8yDbJc4/QysGtBllHzV1t2uixO46IJZj9Z2YWHlK9HUtapcjncT YSPq9ksedvX621xSXNWXLKppPf5FyKYtc2seyNlMwVeUWZx1lEOTNaAKrRiOwybNUszpBOxk/ uTCjzV6Fzoe2DN3Hf7OT9JuGPEXlVxOoR11/i4SWVhVWybWlWd4sdIUe2vc8CGlDY+lFOtbUo tIA2qRlw67IVPj7s8aesbroJ2yMd4xYxg+82mMXi9cCjtD0lcDTkA80i30/NI7SfNjCTOTMbO nseXyDtUha3ppn9XahM8X4Q/g7I3SGk2jFTbslGc612Z8bD44itx3JKJIRueF7/trEEjdpExh /JiRLvPY2CNWkCTqqAjRf50VXr1AuVxi8YhPUQON+7C6ppQbwx/yH1FqFv3BuDfMxPgxEGmMV 4Pzc+foHPkWwoLZtbbp1dWAGN6JGv4MYqUBh1k9D30v4Qp9ojvi3C3gAjyoIm8czackdDzDPE zW1m6p822BLJuxtDrzcDp1QhR+/E+U44p3eCjFSAcU8yj97IF/TXUkF2owiiHmO5V1X16/r8Q ykpIOq40T87bfZz+0BH60vjIhzG1GV7e+3UqQdbDOVDkUivGrwJszrPymECPGm0CYCevQUu/s p9kQBPKhTYa8HW6b7VfGY4Jm9xL07/U+2+NsArkANu2uh/z5p8jvnkSyjEiunXrMyeIoN0sKU rXMuahCQeUwuPVLPyrYOMOv6OpQtu/lr/TuBZLW9yjVMVlMYXKRkkU0xsMCEPb7oxMROwPz5Y bbXM2HTPfvUV9rykOIE399w3esMNg== X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) > Talk about over-specification ;-) > > I hope you realize how some of that will make redisplay much more > expensive? Yes. But the only value I really care about is nil ;-) > How about the following more modest alternative? > > (defcustom face-extend-to-window-edge t > "Non-nil means extend face of last character on line to window edg= e. > > Certain face attributes, if present in the face of the last character > of a line and different from those of the default face, cause the > empty space following the end of text on the line to be drawn with > those attributes, to give the empty space appearance similar to that > of the preceding text. These attributes are those which affect the > background of a face: `:background', `:stipple', `:box', `:underline',= > `:overline', and `:strike-through'. By default, if the face of a > line's last character has any of these attributes, and the value is > different from that of the default face, the empty space following the= > line's text will be drawn in the face of the last character. > > This variable allows fine-tuning which attributes trigger the face > extension. The default value of t means any of the mentioned > attributes will cause face extension. The value of nil means face > extension is turned off. A value that is a list of attributes will > extend the face only if any of the attributes from the list are > present in the last character's face. Note that only attributes from > the above list are meaningful in list values of this variable.") This has the advantage of a much better doc-string. The only details missing are whether the last character of a line is the newline character, whether a non-printable character's attributes count, how invisible characters are treated and whether the :display attribute has any impact. Since I have no good idea about all of these I deliberately did not try to cover them. I'm not sure whether your proposal (it obviously was my first idea as well) is less expensive, though. If the value of our variable is a list, the display engine has to go through the properties of the last character and compare them against the members of this list. Or go through all members of the list and compare them against the character's properties - neither of these approaches is cheap even if optimizations are applied. And then I thought about the - possibly silly idea - that a user might want to put a property like :background on all lines displayed, regardless of the last character's attributes. Such a user would have to, before displaying the relevant buffer parts, go through all these lines and add that property to the newline (?) character of each line. Now I bet that the greater part of such users would put the property on all newline characters of the buffer instead of using something like =E2=80=98pre-redisplay-functions=E2=80=99 where even I couldn't tell whet= her it gets the window's start and end positions always right. martin From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 13:05:18 2016 Received: (at 23574) by debbugs.gnu.org; 8 Jun 2016 17:05:18 +0000 Received: from localhost ([127.0.0.1]:33056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAgus-0007np-8n for submit@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAguq-0007nd-FW for 23574@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAguh-00051K-80 for 23574@debbugs.gnu.org; Wed, 08 Jun 2016 13:05:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAguX-0004z4-Oj; Wed, 08 Jun 2016 13:04:57 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1391 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAguV-0004gX-P4; Wed, 08 Jun 2016 13:04:56 -0400 Date: Wed, 08 Jun 2016 20:05:34 +0300 Message-Id: <83lh2fr4pt.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <5757BC3A.5070402@gmx.at> (message from martin rudalics on Wed, 08 Jun 2016 08:33:30 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Wed, 08 Jun 2016 08:33:30 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > This has the advantage of a much better doc-string. The only details > missing are whether the last character of a line is the newline > character, whether a non-printable character's attributes count, how > invisible characters are treated and whether the :display attribute has > any impact. Since I have no good idea about all of these I deliberately > did not try to cover them. I do know about these, but I don't thunk we should document all those details, since there are too many possible variations, and it's too easy to be inaccurate. "the last face used on the line" is good enough, I think. > I'm not sure whether your proposal (it obviously was my first idea as > well) is less expensive, though. If the value of our variable is a > list, the display engine has to go through the properties of the last > character and compare them against the members of this list. Or go > through all members of the list and compare them against the character's > properties - neither of these approaches is cheap even if optimizations > are applied. No, it need not do any of that. The list is fixed for each redisplay cycle of each buffer, so the list can be processed only once into a bitmap of flags that tell which face attributes trigger face extension. Then all redisplay needs to do is compare the attributes of the face loaded into the iterator object at end of each line with these flags. > And then I thought about the - possibly silly idea - that a user might > want to put a property like :background on all lines displayed, > regardless of the last character's attributes. Such a user would have > to, before displaying the relevant buffer parts, go through all these > lines and add that property to the newline (?) character of each line. > Now I bet that the greater part of such users would put the property on > all newline characters of the buffer instead of using something like > ‘pre-redisplay-functions’ where even I couldn't tell whether it gets the > window's start and end positions always right. Hmm.. not sure how this is related. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 04:39:13 2016 Received: (at 23574) by debbugs.gnu.org; 9 Jun 2016 08:39:13 +0000 Received: from localhost ([127.0.0.1]:33323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAvUe-0002zP-Qj for submit@debbugs.gnu.org; Thu, 09 Jun 2016 04:39:13 -0400 Received: from mout.gmx.net ([212.227.15.18]:59004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAvUd-0002zC-E9 for 23574@debbugs.gnu.org; Thu, 09 Jun 2016 04:39:11 -0400 Received: from [192.168.1.100] ([212.95.7.79]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0McmS9-1at7WK17sP-00HsW8; Thu, 09 Jun 2016 10:38:49 +0200 Message-ID: <57592B18.2030808@gmx.at> Date: Thu, 09 Jun 2016 10:38:48 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> In-Reply-To: <83lh2fr4pt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:9KihE5VrqtvgVwXun6iO85627svTViVhpW/y8eEVC5zaOiV8i/B Pm9jZ+enh5lS0w2e1nB98zD7URIKcwbC5NeHD8JQiN/tv11vA7qAtpqt1kImU12Z9WmDv2s l/N/mmkjmeQiMoDMq9k9NA0XnPUdLbY1xEKh9B7YBCCuGc4Vx3qU4AiwvW0OYsBvsr0fhw+ my5XWRha7uhvd6wM3L/gw== X-UI-Out-Filterresults: notjunk:1;V01:K0:b9GaH4ILVPQ=:9HIFoFo6UYaz9fdldQjmwI 0xtkv8osIMt/f3UbBitxtlQwEdpz8c2uTJrAssEh34ki3TE6HwQ7+vfrP4dXJ6deMSTHwXjxL chyWigGD4JCa9l6qRz9gN9Lpav4PaX8N578NeTQ3ihlRuBuy/hZXn+kOJ9Sp7R7GIy7kzqfgA Ty5RbHgV6AJYqDWTCsUpqkW9j5cBtiPjMFANkz8F5T79YnaOjFZyo92cnjloa+0mGJuqOwTo8 1IEDUYxFxo8wJi3KJpRfmK6I/L3iCrAz8GfWOgGcMxAWzTIRyPeyYJBN4JF6TI6cwsUozBq9z bkSHX6bg6N/0iKHSuS09P0cbZqynjzLTHVMNygt7BrvKZk147XLeNFJiYcm3yNbmhVJ3XRkec vgIcBczI9tAFBSi/Qd0gn1Xw3N3A3dZSpsgUVUKgnM7gno8vkVIO9dXcZAhTkLADR8dXa7v1F pIsKuuJfP6l1hKWsO0iUGcDSu1glSgX5Rt45+huwzpKmUwohRpG5COOH8FdPqgQZsc6Kkw5CQ /eqN9K0QXrQfkWG68ZKfGo2FqQYiB3SoGqRhOB5pFREDtLAcC5mmR31llJw/4Tc/913Xk3Zz6 PxTmHn01JcpIRwPc4A7xBb2Vg4iEoTTR//NMPVWkBGtpJkoM45jPl5Ky2rvJetQ1gg+vPDSea aVEf4JaDRu/LkYGHlqk6MzS8Cpsefv1bPRtpx5pGo9x3FlIb7EoM8POV7Lmjvc9bdPKglhtu6 UtgBNkXa2YCa4nZ0KzHclI6cUuHBE88R6vAlAmlFy3TdH/apAZ5OKacOnZ8anWImJV268Ggmr JPpsXxfaGvFKODAPCSoMfBnT54SGQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > I do know about these, but I don't thunk we should document all those > details, since there are too many possible variations, and it's too > easy to be inaccurate. "the last face used on the line" is good > enough, I think. Including the quotation marks? > No, it need not do any of that. The list is fixed for each redisplay > cycle of each buffer, so the list can be processed only once into a > bitmap of flags that tell which face attributes trigger face > extension. Then all redisplay needs to do is compare the attributes > of the face loaded into the iterator object at end of each line with > these flags. OK. But with my property list approach a once calculated bitmap would have simply overridden the face of the iterator object. Yet cheaper but less versatile. >> And then I thought about the - possibly silly idea - that a user migh= t >> want to put a property like :background on all lines displayed, >> regardless of the last character's attributes. Such a user would hav= e >> to, before displaying the relevant buffer parts, go through all these= >> lines and add that property to the newline (?) character of each line= =2E >> Now I bet that the greater part of such users would put the property = on >> all newline characters of the buffer instead of using something like >> =E2=80=98pre-redisplay-functions=E2=80=99 where even I couldn't tell = whether it gets the >> window's start and end positions always right. > > Hmm.. not sure how this is related. Suppose a user wants to use the same background for all spaces at the ends of all lines of a buffer regardless of "the last face used on the line". How would she specify that? martin From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 09 08:25:41 2016 Received: (at 23574) by debbugs.gnu.org; 9 Jun 2016 12:25:41 +0000 Received: from localhost ([127.0.0.1]:33410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAz1o-0001UL-V3 for submit@debbugs.gnu.org; Thu, 09 Jun 2016 08:25:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAz1m-0001U7-Oy for 23574@debbugs.gnu.org; Thu, 09 Jun 2016 08:25:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAz1g-0007lM-JO for 23574@debbugs.gnu.org; Thu, 09 Jun 2016 08:25:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34961) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAz1a-0007kn-HC; Thu, 09 Jun 2016 08:25:26 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2831 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bAz1Y-0004Ty-6s; Thu, 09 Jun 2016 08:25:24 -0400 Date: Thu, 09 Jun 2016 15:26:04 +0300 Message-Id: <83bn3ar1k3.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <57592B18.2030808@gmx.at> (message from martin rudalics on Thu, 09 Jun 2016 10:38:48 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Thu, 09 Jun 2016 10:38:48 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > > No, it need not do any of that. The list is fixed for each redisplay > > cycle of each buffer, so the list can be processed only once into a > > bitmap of flags that tell which face attributes trigger face > > extension. Then all redisplay needs to do is compare the attributes > > of the face loaded into the iterator object at end of each line with > > these flags. > > OK. But with my property list approach a once calculated bitmap would > have simply overridden the face of the iterator object. Your suggestion included a function, which could well return different values on each call. And creating new faces from arbitrary sets of attributes is no fun, either. > Suppose a user wants to use the same background for all spaces at the > ends of all lines of a buffer regardless of "the last face used on the > line". How would she specify that? By putting the proper face property on the newline. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 03:16:27 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 07:16:27 +0000 Received: from localhost ([127.0.0.1]:35080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBGg6-0003GA-RC for submit@debbugs.gnu.org; Fri, 10 Jun 2016 03:16:27 -0400 Received: from mout.gmx.net ([212.227.17.20]:54691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBGg5-0003Fw-G1 for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 03:16:25 -0400 Received: from [192.168.1.101] ([212.95.7.51]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Lj4xG-1bix473j82-00dD8c; Fri, 10 Jun 2016 09:16:06 +0200 Message-ID: <575A6932.70908@gmx.at> Date: Fri, 10 Jun 2016 09:16:02 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> In-Reply-To: <83bn3ar1k3.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:vI86+rVKmO5/7MvVdmzF73QW5Xn44EDcFtURp8b58QXE6IcOm9Q DFTm4ZgpBzLsFKV71pJTSjF6mr5WD5GxKTb352P4GduTdwypAqzQiGtQ+p2EWLHD82nkb1G 7hMj+XL0oaJ+o9IbqLqluyK84gIaM1Z+qMdwcwfefl7Cn3G86+pMvVMasg4Aej9AQrNqLTR ZIA5CjWRN21T60XYCFWXw== X-UI-Out-Filterresults: notjunk:1;V01:K0:BQOiHxgwmZ8=:CCV4aDoZOB7mvFpTvIIH6B Mk9vG+j0Cnr6U4TpWcVVN4C9xuj/cbPgbViMq+/Ufimt8jiHdFbSmoLI5XTV7aLL+lKOOm3TI 4N/msX7UwH7qeLWMboiYZcG4RQ/EPDJIkp1WrBzjGKl3Fx5IhBuQGn0RdL+tHfrRqpfBUDGYI 5fzeUGHovgrxe4erTmFbyxjgwC3Z55bNONI7A+MH/Nfz8avzvMRHIRLG2QCozW/TarvqmdMsX ys+URYWpdANP7/ntFdl6lpLHaNVJCcgW+nLOMw3uVNAsyiMQPvWUEEmBbQafMXiqPMwCj62wb s4/Btcsmk+GwU6zAGDVffArD1XFt5EwqDSxIq9dJ0qjavtuzrfDkEnBS9sqAVuRmes2psA+/3 U25FUBTD3B+gXYxhZwfxXtomNXYIm5/orb8wShd2CrRTB9rqK+NHWA0nlSrNTdRbgVY2044mb auyJlpjvE3mETdE8uohnfQSJJcOTIrZNgdDlRgBXr9zs3Sc4UyDyodJn/SOnn9NdMVOgyowHb 9xwkxX0hn3xdm3pwjg64hH850ttScw7keQtxAU2uBmla1OyObhNO4OcH4QWZS6S9AJE1bzPSe fY4gQDsKyfncg0skkCWIE0/4SXbaFGLyJD1B89P1PzCKK/I3/55DYx7q8QpPo+p6s0ymqoxU5 q8aEHAurgP2W6helNJC9uOQWqVq4jPRndpekh+tTVoqwtG48D2jaiIpfa3hOXFKipRPEhi9mI 2ZW91FED6BFnf/Im1C7qCZvMTJc9zboCIZt3dXuEJqH5RzXPgy83yO05Pi7btIHauZm6uUiKI CU0/DuSP2yJHqdLpvgqvbbC1UpvZw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> OK. But with my property list approach a once calculated bitmap woul= d >> have simply overridden the face of the iterator object. > > Your suggestion included a function, which could well return different= > values on each call. > > And creating new faces from arbitrary sets of attributes is no fun, > either. OK. I was not fond of my proposal anyway. >> Suppose a user wants to use the same background for all spaces at the= >> ends of all lines of a buffer regardless of "the last face used on th= e >> line". How would she specify that? > > By putting the proper face property on the newline. Which gets me back to my initial concern: If our user does that eagerly for the entire buffer, the overhead might be non-negligible. A more lazy solution would require to hook into =E2=80=98pre-redisplay-functions= =E2=80=99 or something the like in order to know which lines get displayed. Would =E2=80=98pre-redisplay-functions=E2=80=99 be a suitable place for that? martin A loosely related question: Does for R2L text row->pixel_width for each glyph row indicate the width of that row occupied by text as it does for L2R text? Suppose we have a L2R line with dots indicating the empty space at the end of that line: TTTTTTTTTTTTT.... R2L this line would appear as =2E...TTTTTTTTTTTTT Would these two lines have the same row->pixel_width? Or, would the length of the stretch glyph added at the left of the R2L line be that of =E2=80=98window-text-width=E2=80=99 minus row->pixel_width? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 04:10:05 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 08:10:05 +0000 Received: from localhost ([127.0.0.1]:35095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBHW1-0004XX-Ei for submit@debbugs.gnu.org; Fri, 10 Jun 2016 04:10:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBHVz-0004Wx-RU for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 04:10:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBHVt-0006Dw-Ic for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 04:09:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBHVn-0006Bg-HM; Fri, 10 Jun 2016 04:09:51 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4278 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBHVl-0007tj-Hd; Fri, 10 Jun 2016 04:09:49 -0400 Date: Fri, 10 Jun 2016 11:10:31 +0300 Message-Id: <83r3c5piq0.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <575A6932.70908@gmx.at> (message from martin rudalics on Fri, 10 Jun 2016 09:16:02 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> <575A6932.70908@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Fri, 10 Jun 2016 09:16:02 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > >> Suppose a user wants to use the same background for all spaces at the > >> ends of all lines of a buffer regardless of "the last face used on the > >> line". How would she specify that? > > > > By putting the proper face property on the newline. > > Which gets me back to my initial concern: If our user does that eagerly > for the entire buffer, the overhead might be non-negligible. I don't see why. Redisplay only considers the visible portion of the buffer. > A loosely related question: Does for R2L text row->pixel_width for each > glyph row indicate the width of that row occupied by text as it does for > L2R text? row->pixel_width doesn't count text glyphs, it counts all of the glyphs in a glyph row, including the glyphs produced by the display engine for its own purposes. E.g., it always includes the space glyph produced at the end of a line, which is needed for displaying the cursor. In the R2L case the width includes the stretch glyph prepended on the left. > Suppose we have a L2R line with dots indicating the empty space at > the end of that line: > > TTTTTTTTTTTTT.... > > R2L this line would appear as > > ....TTTTTTTTTTTTT > > Would these two lines have the same row->pixel_width? Or, would the > length of the stretch glyph added at the left of the R2L line be that of > ‘window-text-width’ minus row->pixel_width? The latter. row->pixel_width is computed in compute_line_metrics, after the stretch glyph (and any other glyphs needed for line display) were already inserted. compute_line_metrics doesn't care about what glyphs are there, it counts them all. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 04:25:02 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 08:25:02 +0000 Received: from localhost ([127.0.0.1]:35106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBHkP-0004vo-1e for submit@debbugs.gnu.org; Fri, 10 Jun 2016 04:25:02 -0400 Received: from mout.gmx.net ([212.227.17.21]:52902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBHkN-0004va-Cl for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 04:24:55 -0400 Received: from [192.168.1.101] ([212.95.7.51]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MCwbX-1bJmCW0rgZ-009gDC; Fri, 10 Jun 2016 10:24:35 +0200 Message-ID: <575A793E.7090302@gmx.at> Date: Fri, 10 Jun 2016 10:24:30 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> <575A6932.70908@gmx.at> <83r3c5piq0.fsf@gnu.org> In-Reply-To: <83r3c5piq0.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:lz3oALff6mYD6zUlrTOe/qiBeqmrMMXU/mKmd+P3NCLYCAgU09z 3ZySD1XoXzlZjMvJTh5gED4QVdfEPi8JGaNb83dJsse4EuQdBY2JU3fMhxTYfpHq7xdQh+y 1SdAxFkN+xJ4PE1d8pjwr33c0gCmopvvQeDEGA9ATMXJdS0nFvaciC7H3gceeiI23aYcDWa 28a2fJsxf5/zDmjcf/UpQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Vf4lR3FC3f0=:Mda+dfs588KMtLPj4T3FR+ nklDXrdF1J0Y9VkwsRU+ELpVLG1hP8djTFwI6xJBs7PPEMLA3uXjWC3Ev/dE1vzy/0UI0/BPI GfBDd9013p9rYjlz6YtL0XQaUXYnfJ5SDc68wGRih60ChlV/7ANvCX6NUVcLsC7peSlAYPNRc rhabz/4xoZFjAc5gnxAwwR7E3T6iroJVM8cPgNMK3gSyhjT60uFSHJItcsQubNH+7IO+VeP7j ZbRnn+35mpD+PmOe4zVnL2zz2zTGZ/g4N6G37k8REZMUFzJzRuu8PV7yfBjMnnsqKyVgOEfzg 12dlsy7j765HvHY2b7mjGyr+iix/quMmGIEmNb19fAbT5t6QqAi60juRmk9TW4WJ1ENlkVnuK 0pzn0u+6oangMp5tmTnSek8qfM5NurqIf4EC9LO64iZ/0j3jF8wC7VhL8zCXEG7TAf/t0Mxcq aN/JFaJvJBRhPQvE/fSR49ygSjVpPd4RqsSCd2+77knK+c+HlxLkWZxrSkQ4M03fX3NfAJh6L zoUgWXMAVm8G1hwfwJ68G/C4Qizm8laPZOVoY4hOq8KgapitnIcKB6ZRd+QBHwH/hGUr9baPs IANaP3dg3mVINVsxWbbm8ADkVonxh5YenSPtaphrXLxfyXWnojVHUWa9mkPGaDiNuLp+5wfan Uc7tFDMiwaSqllr+FebYsIQpxr6mf7E9AoNcURkWqG1QCItHKRT/WZ94lCRXM5aWq1UYrkwMD DZoFt1Dx8AdyPttHQ2zXKI7nU/Fxt/ZO0kGveUg3k94lK+d2lfynjvRJ2xGxD2/MIG0PKGydx rzTSNP7ONyCX4an15mpm4kPCxcGAA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> Which gets me back to my initial concern: If our user does that eagerly >> for the entire buffer, the overhead might be non-negligible. > > I don't see why. Redisplay only considers the visible portion of the > buffer. I meant the overhead for adding the text property to every newline character in the buffer. > row->pixel_width doesn't count text glyphs, it counts all of the > glyphs in a glyph row, including the glyphs produced by the display > engine for its own purposes. E.g., it always includes the space glyph > produced at the end of a line, which is needed for displaying the > cursor. Are there any other significant objects but that space glyph? Is there any other way to get the size of the empty space after text on each row? > row->pixel_width is computed in compute_line_metrics, > after the stretch glyph (and any other glyphs needed for line display) > were already inserted. compute_line_metrics doesn't care about what > glyphs are there, it counts them all. Hmm... How would I get the width of that stretch glyph then? martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 05:50:13 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 09:50:13 +0000 Received: from localhost ([127.0.0.1]:35172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJ4v-0001oH-8j for submit@debbugs.gnu.org; Fri, 10 Jun 2016 05:50:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44887) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJ4s-0001o1-T3 for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 05:50:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBJ4j-0005Sh-8k for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 05:50:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJ4b-0005Qw-LX; Fri, 10 Jun 2016 05:49:53 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4438 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBJ4Z-0003R0-KI; Fri, 10 Jun 2016 05:49:52 -0400 Date: Fri, 10 Jun 2016 12:50:33 +0300 Message-Id: <83k2hxpe3a.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <575A793E.7090302@gmx.at> (message from martin rudalics on Fri, 10 Jun 2016 10:24:30 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> <575A6932.70908@gmx.at> <83r3c5piq0.fsf@gnu.org> <575A793E.7090302@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Fri, 10 Jun 2016 10:24:30 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > >> Which gets me back to my initial concern: If our user does that eagerly > >> for the entire buffer, the overhead might be non-negligible. > > > > I don't see why. Redisplay only considers the visible portion of the > > buffer. > > I meant the overhead for adding the text property to every newline > character in the buffer. You mean, memory overhead? I don't think it's significant. > > row->pixel_width doesn't count text glyphs, it counts all of the > > glyphs in a glyph row, including the glyphs produced by the display > > engine for its own purposes. E.g., it always includes the space glyph > > produced at the end of a line, which is needed for displaying the > > cursor. > > Are there any other significant objects but that space glyph? Yes, a few. Look at the comments at the beginning of 'struct glyph' definition in dispextern.h. > Is there any other way to get the size of the empty space after text > on each row? "Other way"? other than what? > > row->pixel_width is computed in compute_line_metrics, > > after the stretch glyph (and any other glyphs needed for line display) > > were already inserted. compute_line_metrics doesn't care about what > > glyphs are there, it counts them all. > > Hmm... How would I get the width of that stretch glyph then? It's recorded in the glyph's pixel_width. Or maybe I don't understand the problem you are trying to solve. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 10:00:11 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 14:00:11 +0000 Received: from localhost ([127.0.0.1]:35898 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBMyp-00017q-1V for submit@debbugs.gnu.org; Fri, 10 Jun 2016 10:00:11 -0400 Received: from mout.gmx.net ([212.227.17.21]:61387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBMyn-00016r-L4 for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 10:00:10 -0400 Received: from [192.168.1.101] ([212.95.7.51]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MHH3P-1bFXhy3Mvb-00E350; Fri, 10 Jun 2016 15:59:45 +0200 Message-ID: <575AC7CD.1030506@gmx.at> Date: Fri, 10 Jun 2016 15:59:41 +0200 From: martin rudalics MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> <575A6932.70908@gmx.at> <83r3c5piq0.fsf@gnu.org> <575A793E.7090302@gmx.at> <83k2hxpe3a.fsf@gnu.org> In-Reply-To: <83k2hxpe3a.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:0DauoN2nVTg6Yu1Ejag1fl/igdriIM44JCIvz7tSbkkacnaW73B 1z2wGSW0XnU0OxQqXp2P6WY+yvKBnFIu/j5sWKQRHTRfNIhp3CDYSOjHWU9NMEbat0TMUyF MbXIr1JuQLivoy9lVcsVF9m4ltVY1k6Q36lHWDQrpXZoTlGy2hM4xlHjeLAkncZ4/+131kn hmcN270kcll13cy8v67tA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Hw/6FTHyD/A=:WwAAeBud8BuUwCnNBDRseS 8EsgRjYq6w1utwqQ+0uqAhmuJBqt7HJW2wB7AhdBLPc0SGZ5ccGwDBegeua/Cn5FfaWJkyZy9 ciVFLWG9OLIKdTmoq7xl9yD4FfUCbgtyyXZQJb8CFCY3K5yZIZiCCIpJCi6TzK0Qdo8968Vjl v0H0jnXpLmh9+g8sSvv6jw2oRDYBboNnzp5lYxFuWNj5u7NnLxrzJyOE0lyt+9BAx+7D+hOiW HGe+nwIS+b3jdd/gMJrRUEuEuWybF7t/g8JvUxA0eAZgEZVYX17o0CTeDSok4hjBt6NVEPQqZ zH15hlr9rWX2Edp0COOZlVfwIm4bD/NuKvgpWEXtSubJCZaaMEPGswoZoTkKJBtAXrc9luzVq 5/GrAVdGBooHlKEJ71+SSGMmwFxI41DtVu23dfbbK1IuSoDSXhbXOtJUVBijnC9+s9gmzCL4H mxxJT25rstCmJg9v2fKsZQ0A+dMAcWHy/UjKxcNZUvJyGDrxRPdsNi7kREp0QGqJE/JHKhv2S guvgk8NtJJ+vXX4T0LK+eIySNPvxlj5qfOnrLrRvhYlEPyKOl5qrcq1S4S7v0R9rtFy/ZcG5B SlrNbbr5Hi3Y10SQm4KKfwWhdH1oU7Mvl9t3gqMdPz4+7eTYBCtyv87SuSWsHXeNdkgg4nXmZ FJOtfjLAVjCK94SWA4vL9I0M11XWMG0RqYTUa21M0RvaVUIiRzaTdiio6bTCcHLx2qUtgP7BL 0TSWd9seKRFZJIS1NAzCqzMxwe2+WBw5f9CsVSfxl+6YmCR7Mf2N0A4wr4OCfNH+13BJvtojw HMSbeUNi0Sf5YX++L2plseFpPyRQQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) >> I meant the overhead for adding the text property to every newline >> character in the buffer. > > You mean, memory overhead? I don't think it's significant. I meant the time overhead to find each newline (or the character before it) in the buffer and put the property on it. > Yes, a few. Look at the comments at the beginning of 'struct glyph' > definition in dispextern.h. These ones glyph standing for newline at end of line 0 empty space after the end of the line -1 overlay arrow on a TTY -1 ... ? >> Is there any other way to get the size of the empty space after text >> on each row? > > "Other way"? other than what? Other than subtracting the pixel_width from the window text width. I obviously want to just retrieve a calculated value, not recalculate it. >> > row->pixel_width is computed in compute_line_metrics, >> > after the stretch glyph (and any other glyphs needed for line display) >> > were already inserted. compute_line_metrics doesn't care about what >> > glyphs are there, it counts them all. >> >> Hmm... How would I get the width of that stretch glyph then? > > It's recorded in the glyph's pixel_width. So for R2L text to get the width of the empty space on the left of a row I have to calculate the pixel_width of the leftmost character on that row. Something like the following for a given row? struct glyph *glyph = row->glyphs[TEXT_AREA]; width = glyph->pixel_width; > Or maybe I don't understand > the problem you are trying to solve. I want to put a mini-frame in the empty space on the right side of a L2R window and accordingly on the left side of a R2L window. I more or less know how to do the former but have not yet tried the latter. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 10 10:24:15 2016 Received: (at 23574) by debbugs.gnu.org; 10 Jun 2016 14:24:15 +0000 Received: from localhost ([127.0.0.1]:35906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBNM7-0001gh-0T for submit@debbugs.gnu.org; Fri, 10 Jun 2016 10:24:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBNM5-0001gT-3H for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 10:24:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBNLy-00052Z-SX for 23574@debbugs.gnu.org; Fri, 10 Jun 2016 10:24:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBNLs-00051N-Tl; Fri, 10 Jun 2016 10:24:00 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4575 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBNLq-0008T4-Hw; Fri, 10 Jun 2016 10:23:59 -0400 Date: Fri, 10 Jun 2016 17:24:39 +0300 Message-Id: <83eg85p1eg.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-reply-to: <575AC7CD.1030506@gmx.at> (message from martin rudalics on Fri, 10 Jun 2016 15:59:41 +0200) Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <83porxwg1f.fsf@gnu.org> <83d1nxudrb.fsf@gnu.org> <83wpm3tyvn.fsf@gnu.org> <83twh7tt83.fsf@gnu.org> <83r3cbt5l3.fsf@gnu.org> <83h9d6tl3j.fsf@gnu.org> <5755AACE.8030303@gmx.at> <831t4ataep.fsf@gnu.org> <57568F86.8040902@gmx.at> <83eg89roam.fsf@gnu.org> <5757BC3A.5070402@gmx.at> <83lh2fr4pt.fsf@gnu.org> <57592B18.2030808@gmx.at> <83bn3ar1k3.fsf@gnu.org> <575A6932.70908@gmx.at> <83r3c5piq0.fsf@gnu.org> <575A793E.7090302@gmx.at> <83k2hxpe3a.fsf@gnu.org> <575AC7CD.1030506@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, john.b.mastro@gmail.com, cwoodbury@azavea.com, npostavs@users.sourceforge.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > Date: Fri, 10 Jun 2016 15:59:41 +0200 > From: martin rudalics > CC: npostavs@users.sourceforge.net, 23574@debbugs.gnu.org, > john.b.mastro@gmail.com, cwoodbury@azavea.com > > I meant the time overhead to find each newline (or the character before > it) in the buffer and put the property on it. If they decide to do this, they get what they deserve, no? > > Yes, a few. Look at the comments at the beginning of 'struct glyph' > > definition in dispextern.h. > > These ones > > glyph standing for newline at end of line 0 > empty space after the end of the line -1 > overlay arrow on a TTY -1 > ... > > ? Yes. > >> Is there any other way to get the size of the empty space after text > >> on each row? > > > > "Other way"? other than what? > > Other than subtracting the pixel_width from the window text width. I > obviously want to just retrieve a calculated value, not recalculate it. I guess that's the natural way, yes. Of course, you can only use it when the display is up to date, otherwise the glyph matrix cannot be trusted, and you need the move_it_* functions instead. > >> > row->pixel_width is computed in compute_line_metrics, > >> > after the stretch glyph (and any other glyphs needed for line display) > >> > were already inserted. compute_line_metrics doesn't care about what > >> > glyphs are there, it counts them all. > >> > >> Hmm... How would I get the width of that stretch glyph then? > > > > It's recorded in the glyph's pixel_width. > > So for R2L text to get the width of the empty space on the left of a row > I have to calculate the pixel_width of the leftmost character on that > row. Something like the following for a given row? > > struct glyph *glyph = row->glyphs[TEXT_AREA]; > width = glyph->pixel_width; Yes, modulo the usual caveats of hscroll etc. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 21 07:49:46 2019 Received: (at 23574) by debbugs.gnu.org; 21 Oct 2019 11:49:46 +0000 Received: from localhost ([127.0.0.1]:55828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMWC2-0001FB-Fc for submit@debbugs.gnu.org; Mon, 21 Oct 2019 07:49:46 -0400 Received: from sonic310-57.consmr.mail.ir2.yahoo.com ([77.238.177.30]:35084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMWC0-0001Ex-DI for 23574@debbugs.gnu.org; Mon, 21 Oct 2019 07:49:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1571658577; bh=ueVW8If02fFslICjRGuZL9ibTkciK2F+OtbG8F7QeLM=; h=Date:From:To:Cc:Subject:From:Subject; b=Qil6yebCmenLuQ+cw66hwnOcWKg32pBa1o2YwQ+o3JxsKAgENeBgvU4OBx55YoaCSBel9mC1RRxHMZxCnlXvtLXGuE9iqTSpvhU/5FOm+m59XYGAtC1sT6fNHY8PQ/Gm+u9Lo/JZJCOgCV0DBy83/cPH6dIzx5tDMcn27R0dgnXDockz/9LwuTGbsfimR0sSnMXipTyWzfywh4alRWfJkxBiTHeT1oK5efjz2odOF0l3Kq5qcsBikwCuzkH1U+wHM9P3UZX4j/nMcJCkl53xZCdV2SaCuFY4ZvJehshsWT1BwFIvJhtncZLRgERgnNyo6d1nPqiieXo48EZtXR6ICA== X-YMail-OSG: agKkFygVM1mofZ0ZB7mJzAIzfOd9Wj0Chjocw8mml6LXuBLBQ26Ughjg2LgxOYE kUCbiFQYuPUDddPiZbIiTi.nwB37aLM_4A1XfmdEr_jKJ7AOSN67k5a2mvZZFN8Fl0OB7NhabRjc xOBxSpTaGdVZBU88EBtBQYJTehYwd2EMj81uhfuR2K1BeiWxOxK9Kg5XZxFkqJitBNf.c.IoG52n PvGaqaZZkE9iAsrMp07H0wk0amwpHCLHzVISlmc5J4I5pGw69cYRv7_b2Zk6fR.PkGM1SBsu5rSp QArwsHtB0S2N2JubfuL9sl7KgBhlTRhSv.fl5leqEmFEaAYXvAFMFQ_68AtDHqTnz_PVdeXrDSsu x0le1mp607HTal232HT3fpLqoXRXte82rgUseHzGIhPyggebCQz9P_j6.LtVMuyD7s8rPoc4Tp6U uHFHJesvJj4ODhOFdRrohWxjuCr8PVYobkY.ADFCft_Npd3E8tzpOETBUX3RmbAjoe2IRPbcEJWU vGQG_bmy3Xma_uC6aY3gAKfoE6air9UGn2Fhv58v70ybFFftoBUY1JPz5aJehcsaLb4R8PT6D4MX 32s4tkOA6ij7QUiOfGagQfJm8w85BOiqMVXl_T_SDQIRqN3U7R4.feu.auXm9FvbSbq3Ke5lPYyU iMOj3R1NkroOxnuozZPlcyHw7Rl5YX99PAgnTee3ZKbr7pd3YYOycdtPXuqsCpA2UfRklz3hVUH7 VNouj9rEBRZ67mGy3ubQeQwJXWLrl.xZn_SYimPJtgNeEoODocnLxp63J0UGFuHUikBTHnJMgmms 3ztQGKdPgkG3ArG7WChOJOfJBnnqPVgONe_LSK10QScLU9CYWECFRVzxpneK4tvl.NlKod0OYEfL mh3C4cd9oP69vEz4liKK36vZhZCPeVPqZLT14lgU1gHg0AVRLaP6qMOG.VKwKsw8Q3e606YQZNvb i3smjCebxiVB38adCJM38y1.5gqFT6BR8UBkdBvaRCIa2_z5CVgBhYRSOKCU_kJ_PFK4J1AG9SiD GYqJASLEntUqQaQYRXhEo6w6j5JmfgoOG9nWjdSeQ1GV827I5n1GbJl1FD3FeYQyp3mtsQBOZbh6 Ca6EYmJWVrn.2ujCfCXYOLNzW1O_dLe3fMplTxZP8rk5A.WTsFq9yHGzYLH.vQYI7Vw4k3dAUc4l ooe.ZJhTr0lQpR9niiEqQwEqblbePKmLMsD3WJQRlsI9Qh8BPuvrEqrudGBD9Fk4z0LiWKKjvsi3 ga1SVLYK_tZhE18xZ7RNZjawxOcAE.cCwggj9vFH6a.HGdvzcKU7CGW2AUkm7pj33MQzT46qYyjB 8odCGs7tNUwx4Zi4kEQo- Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ir2.yahoo.com with HTTP; Mon, 21 Oct 2019 11:49:37 +0000 Received: by smtp419.mail.ir2.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID d9eb15be8e2e960213fbe2ae3a6e0a6a; Mon, 21 Oct 2019 11:49:33 +0000 (UTC) Date: Mon, 21 Oct 2019 13:49:19 +0200 From: Ergus To: cwoodbury@azavea.com Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox Message-ID: <20191021114919.mj23tkx7sxm37kte@Ergus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: NeoMutt/20180716 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi: In the new master branch there is a new feature (:extend attribute for faces) that seems to fix also this issue. Could you try it to confirm if we can close this as fixed?? Best, Ergus From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 00:32:44 2021 Received: (at 23574) by debbugs.gnu.org; 8 Nov 2021 05:32:44 +0000 Received: from localhost ([127.0.0.1]:55706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjxGt-0003z4-Gd for submit@debbugs.gnu.org; Mon, 08 Nov 2021 00:32:43 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjxGc-0003it-Lj for 23574@debbugs.gnu.org; Mon, 08 Nov 2021 00:32:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gDl1bFjTELfTjejbKIp328XYAYwaxqZ/R363AhXvN0I=; b=Vbui3dagiBeBr7SZ+3dXRwXAOd 0EE3Hv5FvtLMJMtDtxubWzqjMFTa/cckQOyJ+DByuoSNGxJzphl6PiUxKsfDCx66zuKo5NDuZg0Tp XXsL4zo3xIxYn+zOKznSqp3ON5XvBaKLN3xd5zQz9MvbjYrwI3uR+IlWYwHifgd0P7Oo=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjxGT-0007Xz-QA; Mon, 08 Nov 2021 06:32:20 +0100 From: Lars Ingebrigtsen To: Ergus Subject: Re: bug#23574: 24.5; Overzealous underlining in emacs-nox References: <20191021114919.mj23tkx7sxm37kte@Ergus> X-Now-Playing: Sly & The Family Stone's _There's a Riot Goin' On_: "Africa Talks To You "The Asphalt Jungle"" Date: Mon, 08 Nov 2021 06:32:14 +0100 In-Reply-To: <20191021114919.mj23tkx7sxm37kte@Ergus> (Ergus's message of "Mon, 21 Oct 2019 13:49:19 +0200") Message-ID: <874k8nb4bl.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Ergus writes: > In the new master branch there is a new feature (:extend attribute for > faces) that seems to fix also this issue. Could you try it to confirm if > we can close this as fixed?? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23574 Cc: 23574@debbugs.gnu.org, cwoodbury@azavea.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ergus writes: > In the new master branch there is a new feature (:extend attribute for > faces) that seems to fix also this issue. Could you try it to confirm if > we can close this as fixed?? This was two years ago, and there was no response. From skimming this thread, I think the :extend attribute should have fixed the issue. So I'm closing this bug report. If there's more to be done, please respond to the debbugs address and we'll reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 08 00:32:35 2021 Received: (at control) by debbugs.gnu.org; 8 Nov 2021 05:32:35 +0000 Received: from localhost ([127.0.0.1]:55704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjxGl-0003tq-8Q for submit@debbugs.gnu.org; Mon, 08 Nov 2021 00:32:35 -0500 Received: from quimby.gnus.org ([95.216.78.240]:42792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjxGh-0003mZ-Ih for control@debbugs.gnu.org; Mon, 08 Nov 2021 00:32:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VvtM7DwAfzff+glor0w/jXuSGFrAZO+3MjcZQVnZqh0=; b=kJHM1XRoq0JjCKmWLc7lNDCWKV LxtfGM6A4u3i6TbSSQrRvaqn4NVKjlbVACOJz5jj/QVlbI6xNTrX8Gxj65NFHc1RCDepQyZQKv29r e/ca10tA4Iujx4/odpwKi098AtmXZ6I7Aqa+JfUTjLmwu+tZJkFvnopnhUlTZNEC7Q/k=; Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjxGZ-0007Y9-PS for control@debbugs.gnu.org; Mon, 08 Nov 2021 06:32:26 +0100 Date: Mon, 08 Nov 2021 06:32:23 +0100 Message-Id: <8735o7b4bc.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #23574 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 23574 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 23574 quit From unknown Mon Jun 16 23:42:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 Dec 2021 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator