From unknown Mon Jun 23 18:29:46 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2357: imenu-add-menubar-index fails in Objective-C mode Reply-To: Juanma Barranquero , 2357@debbugs.gnu.org Resent-From: Juanma Barranquero Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , owner@debbugs.gnu.org Resent-Date: Tue, 17 Feb 2009 12:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 2357 X-Emacs-PR-Package: emacs,cc-mode X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123487334622273 (code B ref -1); Tue, 17 Feb 2009 12:30:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Feb 2009 12:22:26 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.9 required=4.0 tests=FOURLA,FVGT_m_MULTI_ODD,GMAIL, HAS_PACKAGE autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.173]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1HCMMDB022267 for ; Tue, 17 Feb 2009 04:22:24 -0800 Received: by ug-out-1314.google.com with SMTP id u2so183138uge.14 for ; Tue, 17 Feb 2009 04:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=gagkWOoSsRQn2SJgG+fhvclnK8cf2ohYqgzbjDSypR4=; b=uhQ3ZiKpZNRiMFA6e0h+zINFI2uCqsS+8wVGM8B8uo6MvvAqWMFPAmwYNGc7ccnhRU oMj9had+rt0q01sfQl6Rn0c7DUqYipQrZF0kqounvr3mLFyJ/PkzToGjbj0rO8xHj+sG BSbwj8JL2NXU+5ONVop25JMl2+f34GRfUa0BQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=JtTA+8HS1yxmGEbBNu6Tq8mCM+UqVGpptNT3+QkhNIpp6rUAPzdgw/3aysCFLfAG9J /vDW0HG5aHpywLUS8tHYgCaGCCIDbLL4cMe/GJJF0KTbW/pqLghybffDHmoZApb7BBY8 QiNXpVl+kWcMZuNKGq7I+pvToefov0xr3FiqM= MIME-Version: 1.0 Received: by 10.210.129.19 with SMTP id b19mr210573ebd.190.1234873341908; Tue, 17 Feb 2009 04:22:21 -0800 (PST) Date: Tue, 17 Feb 2009 13:22:21 +0100 Message-ID: From: Juanma Barranquero To: Emacs Bug Tracker Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Package: emacs,cc-mode [This part is a bugfix] emacs -Q --visit nsfns.m --f imenu-add-menubar-index =3D> Error in menu-bar-update-hook: (invalid-function imenu-progress-messa= ge) The reason is that progmodes/cc-menus.el does (cc-bytecomp-defun imenu-progress-message) to avoid loading imenu.el, and then uses `imenu-progress-message' in Objective-C specific code (cc-imenu-objc-function). But it is a macro, so it fails. I think the best way to fix it is just removing the cc-bytecomp-defun and all calls to imenu-progress-message from cc-menus.el. That macro has been defined as a no-op since 2004-10-27 and I don't think it is worth jumping around hoops just to make cc-menus.el successfully define something that goes unused. [This part is not a bugfix, so not needed now] Additionally, there are useless calls to `imenu-progress-message' in imenu.el, erc/erc-imenu.el and net/smtp-mode.el. For the latter two, removing the macro calls would also remove the need to require imenu. Juanma 2009-02-17 Juanma Barranquero * progmodes/cc-menus.el (imenu-progress-message): Remove (bogus and useless) cc-bytecomp-defun. (cc-imenu-objc-function): Don't call `imenu-progress-message'. Don't let-bind unused variable `stupid'. Index: lisp/progmodes/cc-menus.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/progmodes/cc-menus.el,v retrieving revision 1.42 diff -u -2 -r1.42 cc-menus.el --- lisp/progmodes/cc-menus.el 17 Feb 2009 10:59:14 -0000 1.42 +++ lisp/progmodes/cc-menus.el 17 Feb 2009 11:51:30 -0000 @@ -48,5 +48,4 @@ (cc-bytecomp-defvar imenu-generic-expression) (cc-bytecomp-defvar imenu-create-index-function) -(cc-bytecomp-defun imenu-progress-message) =0C @@ -317,5 +316,4 @@ (classcount 0) toplist - stupid str str2 @@ -331,8 +329,6 @@ 'buffer-substring))) (goto-char (point-max)) - (imenu-progress-message stupid 0) ;; (while (re-search-backward cc-imenu-objc-generic-expression nil t) - (imenu-progress-message stupid) (setq langnum (if (match-beginning OBJC) OBJC @@ -386,5 +382,4 @@ methodlist nil)))) ;; - (imenu-progress-message stupid 100) (if (eq (car toplist) nil) (setq toplist (cdr toplist))) From rgm@gnu.org Tue Feb 17 09:52:10 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Feb 2009 17:52:11 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=VALID_BTS_CONTROL autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1HHq8ZE008111 for ; Tue, 17 Feb 2009 09:52:09 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LZU53-0008WO-VU; Tue, 17 Feb 2009 12:50:01 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18842.63689.889659.707874@fencepost.gnu.org> Date: Tue, 17 Feb 2009 12:50:01 -0500 From: Glenn Morris To: control Subject: control message tags 2303 moreinfo tags 2282 moreinfo unreproducible merge 1638 2357 reassign 2358 spam severity 2353 wishlist From unknown Mon Jun 23 18:29:46 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#2357: imenu-add-menubar-index fails in Objective-C mode Reply-To: Stefan Monnier , 2357@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , owner@debbugs.gnu.org Resent-Date: Wed, 18 Feb 2009 03:05:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 2357 X-Emacs-PR-Package: emacs,cc-mode X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12349258644991 (code B ref -1); Wed, 18 Feb 2009 03:05:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 18 Feb 2009 02:57:44 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1I2vY0O004954; Tue, 17 Feb 2009 18:57:36 -0800 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAFQHm0lMCpTK/2dsb2JhbACBbtIUhBMGgzU X-IronPort-AV: E=Sophos;i="4.38,225,1233550800"; d="scan'208";a="34015526" Received: from 76-10-148-202.dsl.teksavvy.com (HELO ceviche.home) ([76.10.148.202]) by ironport2-out.teksavvy.com with ESMTP; 17 Feb 2009 21:57:28 -0500 Received: by ceviche.home (Postfix, from userid 20848) id A807CB4123; Tue, 17 Feb 2009 21:57:28 -0500 (EST) From: Stefan Monnier To: Juanma Barranquero Cc: 2357@debbugs.gnu.org, Emacs Bug Tracker Message-ID: References: Date: Tue, 17 Feb 2009 21:57:28 -0500 In-Reply-To: (Juanma Barranquero's message of "Tue, 17 Feb 2009 13:22:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > -(cc-bytecomp-defun imenu-progress-message) Removing uses of cc-bytecomp-* is always a reason for rejoycing. Stefan