From debbugs-submit-bounces@debbugs.gnu.org Tue May 17 21:37:04 2016 Received: (at submit) by debbugs.gnu.org; 18 May 2016 01:37:04 +0000 Received: from localhost ([127.0.0.1]:56366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2qQ4-0006lF-Aq for submit@debbugs.gnu.org; Tue, 17 May 2016 21:37:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b2qQ1-0006kj-0n for submit@debbugs.gnu.org; Tue, 17 May 2016 21:37:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2qPu-0005xW-AG for submit@debbugs.gnu.org; Tue, 17 May 2016 21:36:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qPu-0005xH-5x for submit@debbugs.gnu.org; Tue, 17 May 2016 21:36:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2qPp-0005xc-O5 for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 21:36:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2nBp-0004SO-3f for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 18:10:12 -0400 Received: from mxout3.interscholz.de ([85.236.196.238]:42960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2nBo-0004PY-TY for bug-gnu-emacs@gnu.org; Tue, 17 May 2016 18:10:09 -0400 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id 3AC6020F53 for ; Wed, 18 May 2016 00:10:06 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 0606E202D9 for ; Wed, 18 May 2016 00:10:04 +0200 (CEST) Received: from linux-qg7d.fritz.box (p4FFBE6E1.dip0.t-ipconnect.de [79.251.230.225]) by server.web01.interscholz.net (Postfix) with ESMTPSA id E7405340098; Wed, 18 May 2016 00:10:01 +0200 (CEST) From: Rolf Ade To: bug-gnu-emacs@gnu.org Subject: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable Date: Wed, 18 May 2016 00:10:01 +0200 Message-ID: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Recipt: - Start emacs -Q - Open some buffer and enable tcl-mode (M-x tcl-mode). Copy the following tcl code into it: proc bad {{value ""}} { # do something } proc good {value} { # do something } This is valid tcl code, creating two functions (or procedures, als Tcl also calls them). The first function has an optional argument. If that argument isn't given, the argument variable 'value' will have the default value ("" in the bad example) given in the proc definition. The second is an example for a function. that always expects one argument. - Put the point at the beginning of the proc bad and call tcl-end-of-defun (which is an alias of end-of-defun, therefor all keybindings to that will work). Now the point is (marked as: _P_ proc bad {{value ""}} _P_{ # do something } This is wrong, this is not the end of the proc. In general, tcl-end-of-defun does work. Look at the proc good. Placing the point at the beginning of proc good and calling tcl-end-of-defun, the point is where expected: proc good {value} { # do something }_P_ This is only an example of the mis-functioning. It seems always to show up, if a proc definition has the syntax for one ore more optional arguments with the empty string (given as "" in the code) as default value. Since tcl-eval-defun is implemented with the help of end-of-defun, it suffers from this, too. In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2015-04-11 on linux-qg7d Windowing system distributor `The X.Org Foundation', version 11.0.11203000 From debbugs-submit-bounces@debbugs.gnu.org Wed May 18 08:41:04 2016 Received: (at 23565) by debbugs.gnu.org; 18 May 2016 12:41:04 +0000 Received: from localhost ([127.0.0.1]:56607 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b30me-00078o-JR for submit@debbugs.gnu.org; Wed, 18 May 2016 08:41:04 -0400 Received: from mxout3.interscholz.de ([85.236.196.238]:48926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b30mc-00078E-RN for 23565@debbugs.gnu.org; Wed, 18 May 2016 08:41:03 -0400 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id 289FE21D88 for <23565@debbugs.gnu.org>; Wed, 18 May 2016 14:40:55 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 9648320138 for <23565@debbugs.gnu.org>; Wed, 18 May 2016 14:40:54 +0200 (CEST) Received: from linux-qg7d.site (p4FFBE4BD.dip0.t-ipconnect.de [79.251.228.189]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 0155234016E for <23565@debbugs.gnu.org>; Wed, 18 May 2016 14:40:53 +0200 (CEST) Message-ID: <573C62D4.8050302@pointsman.de> Date: Wed, 18 May 2016 14:40:52 +0200 From: Rolf Ade User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: 23565@debbugs.gnu.org Subject: Re: bug#23565: Acknowledgement (24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable) References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23565 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I missed to note, that the reported misbehavior is still there in emacs 25.0.94.1. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 16 23:55:11 2016 Received: (at 23565) by debbugs.gnu.org; 17 Jun 2016 03:55:11 +0000 Received: from localhost ([127.0.0.1]:43698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDksB-0000FC-3J for submit@debbugs.gnu.org; Thu, 16 Jun 2016 23:55:11 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:34868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDks9-0000Eo-N2 for 23565@debbugs.gnu.org; Thu, 16 Jun 2016 23:55:09 -0400 Received: by mail-oi0-f66.google.com with SMTP id u201so11552100oie.2 for <23565@debbugs.gnu.org>; Thu, 16 Jun 2016 20:55:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:cc; bh=ifiX5MmaXAxN05iiXQaILlwTz3OGtER3azCimsxVutE=; b=x8c54NIeoV32cDKIPXXlTnCcvkAQxhfN4J1cVWRHEp5ykYNlSlAhhAkXZf4z7BA4tm 8gtw10JcmhQq+/P1BUCHbknVeCXWsEOfkovfqJg+rdvmjtCdwNa5PAJBF1G7VPjh7ent dwgrFu4pjh+k3T2HKmAbliwGqGcr2wmKbB8SiI4UmVVttC8pyjC6oLebOv5M965oUJPZ aSymT20O0M56kqityuW3vOz3Vju+OH3iHH/n7ZNW3c6MA5iCYaIZAaqXRAUb3jzSkST7 DuzlylRKCYNkRrf06GpphcVmsGNetZ0WPqutw6HA7AxYodk3kHZ9wQSJ8RPYsK4aGkbp jU2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:cc; bh=ifiX5MmaXAxN05iiXQaILlwTz3OGtER3azCimsxVutE=; b=dzQr2jdfC8pdZSo/fGAsX0zB6j54iJPIaS6tJ/wEcI+vNLdB/FY9ejCyXRJ8apliLV ym30kk8XalSSXIexXfxJEtFWx5F3PsrwCg5PwebfeLfxLF3Aa8b9OYUTST9WaId6fLPD tbh81ljc3hPBcPK+W/PPByPAVXWrsClwo52fucfdXaBubHDkgu+3S/0O6OBAstHMV6yD c1S1OxVu7eCd8FkE3O4L+7BWfIS0I5siOL5aVlnlPBtQKjeX2ji6qUsIOLjpE2H23Zrf dcJJp7mUeqr5xw6kewtMZY3ueq5xA+j8RRw2S3P76q9E2wl0DSgTEuvL7H2VEkEmk0xU Z5lA== X-Gm-Message-State: ALyK8tK1lDP1PAkB/FtWAayN1FgY3K+6UOWxfjR5LVGDsqx0BDDkTps49I3Xjtebk75beloMks52jU4gEqMGKA== X-Received: by 10.202.197.137 with SMTP id v131mr3970204oif.178.1466135701296; Thu, 16 Jun 2016 20:55:01 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Thu, 16 Jun 2016 20:55:00 -0700 (PDT) From: Noam Postavsky Date: Thu, 16 Jun 2016 23:55:00 -0400 X-Google-Sender-Auth: UBP62jt6muqhFWWj_NGDWgTO3bc Message-ID: Subject: Re: bug#23565: (24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable) To: 23565@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23565 Cc: Rolf Ade X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tag 23565 + confirmed quit It has to do with the tcl-omit-ws-regexp which is used to set the buffer local value of defun-prompt-regexp (why isn't it called tcl-defun-prompt-regexp?). The current setting, along with commentary is: ;; Here's another stab. I think this one actually works. ;; We have to be careful that the open-brace following this regexp ;; is indeed the one corresponding to the function's body so ;; that end-of-defun works correctly. Tricky cases are: ;; proc foo { {arg1 def} arg2 } { ;; as well as ;; proc foo { \n {arg1 def} \n arg2 } { ;; The current setting handles the first case properly but not the second. ;; It also fails if `proc' is not in column-0 (e.g. it's in a namespace). (defconst tcl-omit-ws-regexp "^[^]\" \t\n#}][^\n\"#]+[ \t]+") If I remove the " from the second character set, then the examples given in this bug report work, but probably some others might break (I don't know tcl well enough to come up with any). ;; this works for given examples (defconst tcl-omit-ws-regexp "^[^]\" \t\n#}][^\n#]+[ \t]+") A regexp based approach is probably always doomed to have some bad cases, so perhaps the real fix is to define a beginning-of-defun-function for tcl-mode. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 24 13:35:09 2018 Received: (at 23565) by debbugs.gnu.org; 24 Jun 2018 17:35:09 +0000 Received: from localhost ([127.0.0.1]:34067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX8uq-0002nX-Ti for submit@debbugs.gnu.org; Sun, 24 Jun 2018 13:35:09 -0400 Received: from gateway21.websitewelcome.com ([192.185.46.113]:36552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fX8uo-0002nO-Jv for 23565@debbugs.gnu.org; Sun, 24 Jun 2018 13:35:07 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway21.websitewelcome.com (Postfix) with ESMTP id 08639400CB9B6 for <23565@debbugs.gnu.org>; Sun, 24 Jun 2018 12:35:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id X8umfIQFIRPojX8umfuuFJ; Sun, 24 Jun 2018 12:35:05 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vCpCjSTVR45GJytmeppkJPXE2DjHiFghlgVFPiYgrKE=; b=TMuIWG1XWJ9EJNolImtWwwfIKO YkUB/iyyBwSYq7xSY2L9c8d+5g+svpoaP0orVKRSPEMuMo94sUwMfW1RMcvoONZpd5jXjfcEbVuPn 31kgrL7V8m9aFBf2a+Fv7DuBg; Received: from 75-166-79-120.hlrn.qwest.net ([75.166.79.120]:60290 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fX8um-000BKN-Ny; Sun, 24 Jun 2018 12:35:04 -0500 From: Tom Tromey To: Rolf Ade Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> X-Attribution: Tom Date: Sun, 24 Jun 2018 11:35:03 -0600 In-Reply-To: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> (Rolf Ade's message of "Wed, 18 May 2016 00:10:01 +0200") Message-ID: <871scw3x6g.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.79.120 X-Source-L: No X-Exim-ID: 1fX8um-000BKN-Ny X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-79-120.hlrn.qwest.net (bapiya) [75.166.79.120]:60290 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I've checked in a fix for the tcl-end-of-defun problem. I think it should fix tcl-eval-defun as well, but I didn't test this. Tom From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 02 08:04:23 2018 Received: (at 23565) by debbugs.gnu.org; 2 Jul 2018 12:04:23 +0000 Received: from localhost ([127.0.0.1]:42663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZxZ9-0007k8-Bx for submit@debbugs.gnu.org; Mon, 02 Jul 2018 08:04:23 -0400 Received: from mxout3.interscholz.de ([85.236.196.238]:52427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fZxZ6-0007jt-Mc for 23565@debbugs.gnu.org; Mon, 02 Jul 2018 08:04:21 -0400 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id C66AB21690; Mon, 2 Jul 2018 14:04:14 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 3181C20F15; Mon, 2 Jul 2018 14:04:14 +0200 (CEST) Received: from linux-qg7d (p5B317AFA.dip0.t-ipconnect.de [91.49.122.250]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 9CE3CF0001; Mon, 2 Jul 2018 14:04:13 +0200 (CEST) From: Rolf Ade To: Tom Tromey Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> Date: Mon, 02 Jul 2018 14:04:13 +0200 In-Reply-To: <871scw3x6g.fsf@tromey.com> (Tom Tromey's message of "Sun, 24 Jun 2018 11:35:03 -0600") Message-ID: <87zhz99742.fsf@pointsman.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I'm sorry for the delay in replying; I was on vacation and saw your mail just this day, after comming back. Thank you for taking care! Tom Tromey writes: > I've checked in a fix for the tcl-end-of-defun problem. > I think it should fix tcl-eval-defun as well, but I didn't test this. I've build current master and did a few tests. Yes, it seems, that tcl-end-of-defun as well as tcl-eval-defun now work for me as expected, even in the reported-as-broken cases. I'll copy masters tcl-mode.el over to my currently used 26.1 installation (and bytecompile, of course) and give it a try in my daily Tcl coding, for a few days, to see, if I stumble over any unexpected side-effect of the changes. I'll report in a week or at most two (it varies a bit how much Tcl coding I have to do and this is driven by others). rolf From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 18:10:31 2018 Received: (at 23565) by debbugs.gnu.org; 4 Jul 2018 22:10:31 +0000 Received: from localhost ([127.0.0.1]:47056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fapyn-00039x-Ec for submit@debbugs.gnu.org; Wed, 04 Jul 2018 18:10:31 -0400 Received: from mxout3.interscholz.de ([85.236.196.238]:55304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fapyj-00039l-Hl for 23565@debbugs.gnu.org; Wed, 04 Jul 2018 18:10:27 -0400 Received: from localhost (mxout3 [127.0.0.1]) by mxout3.interscholz.de (Postfix) with ESMTP id 358F522288; Thu, 5 Jul 2018 00:10:24 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout3.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout3.interscholz.de (Postfix) with ESMTP id 8D28B21471; Thu, 5 Jul 2018 00:10:23 +0200 (CEST) Received: from linux-qg7d (p5B3177C9.dip0.t-ipconnect.de [91.49.119.201]) by server.web01.interscholz.net (Postfix) with ESMTPSA id E65C1F0001; Thu, 5 Jul 2018 00:10:22 +0200 (CEST) From: Rolf Ade To: Tom Tromey Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> Date: Thu, 05 Jul 2018 00:10:22 +0200 In-Reply-To: <87zhz99742.fsf@pointsman.de> (Rolf Ade's message of "Mon, 02 Jul 2018 14:04:13 +0200") Message-ID: <87woua8xf5.fsf@pointsman.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Rolf Ade writes: > Tom Tromey writes: >> I've checked in a fix for the tcl-end-of-defun problem. >> I think it should fix tcl-eval-defun as well, but I didn't test this. > > I've build current master and did a few tests. Yes, it seems, that > tcl-end-of-defun as well as tcl-eval-defun now work for me as expected, > even in the reported-as-broken cases. > > I'll copy masters tcl-mode.el over to my currently used 26.1 > installation (and bytecompile, of course) and give it a try in my daily > Tcl coding, for a few days, to see, if I stumble over any unexpected > side-effect of the changes. > > I'll report in a week or at most two (it varies a bit how much Tcl > coding I have to do and this is driven by others). Well, beside the improvement (tcl-end-of-defun and tcl-eval-defun does work better), which I again confirm I see one more (unexpected and unwanted) effect. With emacs 26.1: - emacs -Q - M-x tcl-mode - Insert do { foo Indent the second line ("foo") with and you get do { foo Do the same with master and you get do { foo the second line ("foo") does not get indented with . Something is special with "proc". If there is a proc before such code as above the indentation works even with master, e.g. with proc do {script} { eval $script } do { foo the line "foo" will be indented by with 26.1 and master. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 05 09:08:39 2018 Received: (at 23565) by debbugs.gnu.org; 5 Jul 2018 13:08:39 +0000 Received: from localhost ([127.0.0.1]:47324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fb3zy-0003Qp-Nu for submit@debbugs.gnu.org; Thu, 05 Jul 2018 09:08:38 -0400 Received: from gateway22.websitewelcome.com ([192.185.46.225]:34944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fb3zw-0003Qh-Ry for 23565@debbugs.gnu.org; Thu, 05 Jul 2018 09:08:37 -0400 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 2D9B47299 for <23565@debbugs.gnu.org>; Thu, 5 Jul 2018 08:08:34 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id b3zLfGFuCRPojb3zgfqePV; Thu, 05 Jul 2018 08:08:33 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Urgtw1v5MBN7E3dfhojROfcCfFII5DngCnwsWnbFKQ4=; b=x//uVXwyg2w49Hr7+A4J5v1SVO F0lOaV8FqmJD5EoPK0m+p27pkZcprM5y9sqMC6uulV6CCS75gwheU3vVlQHsvNBhSPv8qzO+Iz4zB c1Y6/tSfjfEA9TyTnFSl9usiq; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:50856 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fb3zK-000ruJ-PV; Thu, 05 Jul 2018 08:07:58 -0500 From: Tom Tromey To: Rolf Ade Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> X-Attribution: Tom Date: Thu, 05 Jul 2018 07:07:58 -0600 In-Reply-To: <87woua8xf5.fsf@pointsman.de> (Rolf Ade's message of "Thu, 05 Jul 2018 00:10:22 +0200") Message-ID: <87muv5n841.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.85.72 X-Source-L: No X-Exim-ID: 1fb3zK-000ruJ-PV X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-85-72.hlrn.qwest.net (pokyo) [75.166.85.72]:50856 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org, Tom Tromey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> "Rolf" == Rolf Ade writes: Rolf> Indent the second line ("foo") with and you get Rolf> do { Rolf> foo Thanks for trying this. I suppose instead of the fix for the "namespace" thing, tcl-mode should maybe just looking at brace depth for indentation. I will take a deeper look. Tom From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 30 18:46:08 2019 Received: (at 23565) by debbugs.gnu.org; 30 Jul 2019 22:46:08 +0000 Received: from localhost ([127.0.0.1]:51352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsash-0007TM-NZ for submit@debbugs.gnu.org; Tue, 30 Jul 2019 18:46:07 -0400 Received: from mxout5.interscholz.de ([85.236.196.72]:53647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsasd-0007S5-2b for 23565@debbugs.gnu.org; Tue, 30 Jul 2019 18:46:04 -0400 Received: from localhost (mxout5 [127.0.0.1]) by mxout5.interscholz.de (Postfix) with ESMTP id 5A38225A6C; Wed, 31 Jul 2019 00:45:51 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout5.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout5.interscholz.de (Postfix) with ESMTP id 7A7212094D; Wed, 31 Jul 2019 00:45:47 +0200 (CEST) Received: from pointsman2 (p5B317A9C.dip0.t-ipconnect.de [91.49.122.156]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 046A2340371; Wed, 31 Jul 2019 00:45:53 +0200 (CEST) From: Rolf Ade To: Tom Tromey Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> <87muv5n841.fsf@tromey.com> Date: Wed, 31 Jul 2019 00:45:54 +0200 In-Reply-To: <87muv5n841.fsf@tromey.com> (Tom Tromey's message of "Thu, 05 Jul 2018 07:07:58 -0600") Message-ID: <87d0hruonx.fsf@pointsman.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Tom Tromey writes: >>>>>> "Rolf" == Rolf Ade writes: > > Rolf> Indent the second line ("foo") with and you get > Rolf> do { > Rolf> foo > > Thanks for trying this. > I suppose instead of the fix for the "namespace" thing, tcl-mode should > maybe just looking at brace depth for indentation. I will take a deeper > look. Despite #32035 this is still open with master of today (but not with 26.2). Completely legal and commen code at the beginning befor the first word out of tcl-proc-list are not indented as expected. Examples: do { something } if {$argc != 0} { puts stderr "usage: $argv0" } set options { -foo "default" -bar "bardefault" } Expected indentation would be of course something like: do { something } if {$argc != 0} { puts stderr "usage: $argv0" } set options { -foo "default" -bar "bardefault" } After the first word out of tcl-proc-list in the buffer all that examples above will be indented as expected, no misbehaviour any more. I happily confirm again, that master hasn't the original problem of this bug report. And I'd really love to see that fixed, after it has plagued me for 20 years. But I'm afraid that the cure (current behavior of master) is worse than the problem (26.2). From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 27 20:21:09 2019 Received: (at 23565) by debbugs.gnu.org; 28 Sep 2019 00:21:09 +0000 Received: from localhost ([127.0.0.1]:48848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE0U1-0001cX-5A for submit@debbugs.gnu.org; Fri, 27 Sep 2019 20:21:09 -0400 Received: from mxout5.interscholz.de ([85.236.196.72]:51893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iE0Ty-0001bY-46 for 23565@debbugs.gnu.org; Fri, 27 Sep 2019 20:21:07 -0400 Received: from localhost (mxout5 [127.0.0.1]) by mxout5.interscholz.de (Postfix) with ESMTP id CD59225D3A; Sat, 28 Sep 2019 02:20:44 +0200 (CEST) X-Virus-Scanned: interscholz amavisd-new at mxout5.interscholz.de Received: from server.web01.interscholz.net (server.web01.interscholz.net [85.236.196.138]) by mxout5.interscholz.de (Postfix) with ESMTP id 26B5F20C11; Sat, 28 Sep 2019 02:20:42 +0200 (CEST) Received: from pointsman2 (p5B317A9C.dip0.t-ipconnect.de [91.49.122.156]) by server.web01.interscholz.net (Postfix) with ESMTPSA id 4433B340099; Sat, 28 Sep 2019 02:20:54 +0200 (CEST) From: Rolf Ade To: Tom Tromey Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> <87muv5n841.fsf@tromey.com> <87d0hruonx.fsf@pointsman.de> Date: Sat, 28 Sep 2019 02:20:54 +0200 In-Reply-To: <87d0hruonx.fsf@pointsman.de> (Rolf Ade's message of "Wed, 31 Jul 2019 00:45:54 +0200") Message-ID: <874l0xmftl.fsf@pointsman.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Rolf Ade writes: > Tom Tromey writes: >>>>>>> "Rolf" == Rolf Ade writes: >> >> Rolf> Indent the second line ("foo") with and you get >> Rolf> do { >> Rolf> foo >> >> Thanks for trying this. >> I suppose instead of the fix for the "namespace" thing, tcl-mode should >> maybe just looking at brace depth for indentation. I will take a deeper >> look. > > Despite #32035 this is still open with master of today (but not with > 26.2). Completely legal and commen code at the beginning befor the first > word out of tcl-proc-list are not indented as expected. Examples: > > do { > something > } > > if {$argc != 0} { > puts stderr "usage: $argv0" > } > > set options { > -foo "default" > -bar "bardefault" > } > > > Expected indentation would be of course something like: > > do { > something > } > > if {$argc != 0} { > puts stderr "usage: $argv0" > } > > set options { > -foo "default" > -bar "bardefault" > } > > > After the first word out of tcl-proc-list in the buffer all that > examples above will be indented as expected, no misbehaviour any more. > > I happily confirm again, that master hasn't the original problem of this > bug report. And I'd really love to see that fixed, after it has plagued > me for 20 years. > > But I'm afraid that the cure (current behavior of master) is worse than > the problem (26.2). (I'm getting nervous - emacs-dev already talks about cutting an emacs-27 branch ... I'd really love to see this long standing bug to be fixed. Let me recapitulate.) The original bug of this report was fixed by commit cd5bb4bf3dbad8941d25823f398b595b8f0edbb9 Author: Tom Tromey Date: Sun Jun 24 11:18:19 2018 -0600 This fix introduced a new unwanted indentation behaviour. Any code at the beginning of a buffer in tcl-mode before the first word that match an element out of tcl-proc-list (or so it looks like, I haven't really understand all details but I've provided some examples earlier in the thread) will not be indented as typically expected. I'm afraid the behaviour of current master is more worse than it was before of cd5bb4bf3dbad8941d25823f398b595b8f0edbb9. E.g. work with a notable fraction of the tcl files included in the tcl core distribution (https://core.tcl-lang.org/tcl/download) would suffer from this. So before release of emacs 27 this commit should be reverted. Or, much better, because the commit fixes the original problem (which I really love to see fixed), it should be improved. I came up with the following. The simple idea is to keep the new behaviour where it shines and fall back to the old way otherwise. Commit message: Fix tcl-mode indentation after fix of bug#23565 * lisp/progmodes/tcl.el (tcl-calculate-indent) Fall back to old indentation method for tcl code at the start of the buffer before the first word matching an element out of tcl-proc-list. Copyright-paperwork-exempt: yes diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el index 0fd3d6d1bf..db97230480 100644 --- a/lisp/progmodes/tcl.el +++ b/lisp/progmodes/tcl.el @@ -817,7 +817,9 @@ tcl-calculate-indent found-next-line) (if parse-start (goto-char parse-start) - (beginning-of-defun)) + (if (not (beginning-of-defun)) + (let ((beginning-of-defun-function nil)) + (beginning-of-defun)))) (while (< (point) indent-point) (setq parse-start (point)) (setq state (parse-partial-sexp (point) indent-point 0)) From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 28 13:47:26 2019 Received: (at 23565) by debbugs.gnu.org; 28 Sep 2019 17:47:26 +0000 Received: from localhost ([127.0.0.1]:51142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEGoX-0005KY-U4 for submit@debbugs.gnu.org; Sat, 28 Sep 2019 13:47:26 -0400 Received: from quimby.gnus.org ([80.91.231.51]:33194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iEGoU-0005KN-4i for 23565@debbugs.gnu.org; Sat, 28 Sep 2019 13:47:24 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iEGoP-0004yJ-TK; Sat, 28 Sep 2019 19:47:20 +0200 From: Lars Ingebrigtsen To: Rolf Ade Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> <87muv5n841.fsf@tromey.com> <87d0hruonx.fsf@pointsman.de> <874l0xmftl.fsf@pointsman.de> Date: Sat, 28 Sep 2019 19:47:17 +0200 In-Reply-To: <874l0xmftl.fsf@pointsman.de> (Rolf Ade's message of "Sat, 28 Sep 2019 02:20:54 +0200") Message-ID: <87lfu8uxcq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Rolf Ade writes: > * lisp/progmodes/tcl.el (tcl-calculate-indent) Fall back to old > indentation method for tcl code at the start of the buffer before the > first word matching an element out of tcl-proc-list. > > Cop [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org, Tom Tromey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Rolf Ade writes: > * lisp/progmodes/tcl.el (tcl-calculate-indent) Fall back to old > indentation method for tcl code at the start of the buffer before the > first word matching an element out of tcl-proc-list. > > Copyright-paperwork-exempt: yes > > diff --git a/lisp/progmodes/tcl.el b/lisp/progmodes/tcl.el > index 0fd3d6d1bf..db97230480 100644 > --- a/lisp/progmodes/tcl.el > +++ b/lisp/progmodes/tcl.el > @@ -817,7 +817,9 @@ tcl-calculate-indent > found-next-line) > (if parse-start > (goto-char parse-start) > - (beginning-of-defun)) > + (if (not (beginning-of-defun)) > + (let ((beginning-of-defun-function nil)) > + (beginning-of-defun)))) Hm... This does fix the indentation issue, but I wonder whether tcl-beginning-of-defun-function should be fixed instead so that the movement commands work better? I don't use TCL, but the problem is that top-level (outside of functions) that tcl-beginning-of-defun-function doesn't go to the start of forms like: if {$argc != 0} { puts stderr "usage: $argv0" } But what should beginning-of-defun do outside of functions? It's not documented in the doc string of that function... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 23:19:20 2019 Received: (at 23565) by debbugs.gnu.org; 13 Oct 2019 03:19:20 +0000 Received: from localhost ([127.0.0.1]:34696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUPg-0006uR-Gm for submit@debbugs.gnu.org; Sat, 12 Oct 2019 23:19:20 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUPe-0006uJ-VB for 23565@debbugs.gnu.org; Sat, 12 Oct 2019 23:19:19 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJUPa-0003sO-32; Sun, 13 Oct 2019 05:19:18 +0200 From: Lars Ingebrigtsen To: Rolf Ade Subject: Re: bug#23565: 24.5; tcl-end-of-defun and tcl-eval-defun doesn't work reliable References: <87mvnoe3pi.fsf@linux-qg7d.fritz.box> <871scw3x6g.fsf@tromey.com> <87zhz99742.fsf@pointsman.de> <87woua8xf5.fsf@pointsman.de> <87muv5n841.fsf@tromey.com> <87d0hruonx.fsf@pointsman.de> <874l0xmftl.fsf@pointsman.de> <87lfu8uxcq.fsf@gnus.org> Date: Sun, 13 Oct 2019 05:19:13 +0200 In-Reply-To: <87lfu8uxcq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 28 Sep 2019 19:47:17 +0200") Message-ID: <87o8ylcoy6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > Hm... This does fix the indentation issue, but I wonder whether > tcl-beginning-of-defun-function should be fixed instead so that the > movement commands work better? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 23565 Cc: 23565@debbugs.gnu.org, Tom Tromey X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > Hm... This does fix the indentation issue, but I wonder whether > tcl-beginning-of-defun-function should be fixed instead so that the > movement commands work better? There were no comments in two weeks, and the patch does fix the problem at hand, so I've now applied it to Emacs 27. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 12 23:19:30 2019 Received: (at control) by debbugs.gnu.org; 13 Oct 2019 03:19:30 +0000 Received: from localhost ([127.0.0.1]:34699 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUPp-0006up-WB for submit@debbugs.gnu.org; Sat, 12 Oct 2019 23:19:30 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJUPp-0006ui-10 for control@debbugs.gnu.org; Sat, 12 Oct 2019 23:19:29 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJUPm-0003sY-8u for control@debbugs.gnu.org; Sun, 13 Oct 2019 05:19:28 +0200 Date: Sun, 13 Oct 2019 05:19:25 +0200 Message-Id: <87mue5coxu.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #23565 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 23565 fixed close 23565 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 23565 fixed close 23565 27.1 quit From unknown Sat Aug 16 16:18:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Nov 2019 12:24:14 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator