GNU bug report logs - #23533
24.5; test-completion with completion-regexp-list

Previous Next

Full log

View this message in rfc822 format

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ynyaaa <at> gmail.com, 23533 <at> debbugs.gnu.org
Subject: bug#23533: 24.5; test-completion with completion-regexp-list
Date: Sat, 18 Jun 2016 13:40:04 -0400

On Sat, Jun 18, 2016 at 1:29 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Noam Postavsky <npostavs <at> users.sourceforge.net>
>> Date: Sat, 18 Jun 2016 13:14:59 -0400
>> Cc: 23533 <at> debbugs.gnu.org, ynyaaa <at> gmail.com
>>
>> On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> > I'm not sure this is a bug.
>>
>> I  think it's pretty clearly a bug, because the docs explain that
>> test-completion takes the same arguments as all-completions and
>> try-completions, which do handle an alist COLLECTION with a non-nil
>> completion-regexp-list.
>
> When code contradicts the documentation, it's not immediately clear
> that the code should be fixed.

Independently of the documentation, I also think it makes no sense to
have test-completion be inconsistent with all-completions and
try-completion.

>
> Anyway, I don't consider myself an expert on completion, so I feel
> uneasy about makings this change without any of the experts voicing
> their opinions on the change.

Okay, I will wait another week before pushing to master in case anyone
has some objections/comments.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.