From debbugs-submit-bounces@debbugs.gnu.org Fri May 13 13:09:00 2016 Received: (at submit) by debbugs.gnu.org; 13 May 2016 17:09:00 +0000 Received: from localhost ([127.0.0.1]:50193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1GaC-0001Y0-Ax for submit@debbugs.gnu.org; Fri, 13 May 2016 13:09:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b1GPI-0001GL-VU for submit@debbugs.gnu.org; Fri, 13 May 2016 12:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1GPC-0004I7-Ps for submit@debbugs.gnu.org; Fri, 13 May 2016 12:57:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1GPC-0004I3-N3 for submit@debbugs.gnu.org; Fri, 13 May 2016 12:57:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40878) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1GPB-0004Ey-FG for bug-gnu-emacs@gnu.org; Fri, 13 May 2016 12:57:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b1GP8-0004HZ-1y for bug-gnu-emacs@gnu.org; Fri, 13 May 2016 12:57:37 -0400 Received: from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:36569) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b1GP7-0004HV-Ry for bug-gnu-emacs@gnu.org; Fri, 13 May 2016 12:57:33 -0400 Received: by mail-pf0-x234.google.com with SMTP id c189so45763557pfb.3 for ; Fri, 13 May 2016 09:57:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version; bh=R5Os9mOaQbVo4Z1dxOAVEeFSTUl3Tv+w5bDPJUeWE/E=; b=zENYdlZbkFSZRucRRMIvndAY2pZR6VmZh3X8oOV0Kdl+pV3dWs5hWRVYvc3h43hhv+ Wv/W2ut9bRTyveUERpfczUuANBYwF8OyHZQc2dXY41qA+EGfn68OA4VwlIQummlA7ucU 2K2H6A3DlfTebBQgnARjja1nXzMPcMWpAC3YybRy8KJCmeSop2iF4/Of1VnutWRBPLqm O6mUaIUpqPHVz1ivpscSOk9vC/jLLATJH6baExQqP5o/YnlPWRyZ9aEocivpbHh8dp+X zNAmDhOvb6MMupb0HgSK5yA7ATh3IuW5gQdZB57BK+H/71KjhQy8eEoIf8eQGK7rsUVf 57XQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=R5Os9mOaQbVo4Z1dxOAVEeFSTUl3Tv+w5bDPJUeWE/E=; b=Lv8OcbCJWq6HcXojIN93pIPmH76rbAMfcRir+7/t3X11zKLWo8Lpql8z+UZh8BpGGR /L9CYvUnDGB5nPR0naITW0I15rginDpvkyBqM+RBAH4p7OSPzY7DirnG7aRU9+QABYHS IrSA+pRD2XhpAl8IJagLSA1RUDuaeWUS7Hko/EHtwBLjqJWpCNJ+ZedbzrAeN8OVwGST MvEtxvAUhPvWfnMqoTxVan8acjFtrLLFe0eyDxYPbtoqxaBDWZmQNBA6jBv7VEjj3e87 OjmdGhUhMkBy9iEYl3hOCwpt0eFarQmSNYePTGQnAqUf0JKwj2fcTBUiTnMuG81nQRvr gT4g== X-Gm-Message-State: AOPr4FUCoB9vcf1+dIeggpe5FMasBoRHdw21iBssKbF1vcl4OpZi8E9f+z37k4+Xxlw0+A== X-Received: by 10.98.89.28 with SMTP id n28mr24765442pfb.41.1463158652497; Fri, 13 May 2016 09:57:32 -0700 (PDT) Received: from PNUT-PC (east24-p39.eaccess.hi-ho.ne.jp. [218.42.167.40]) by smtp.gmail.com with ESMTPSA id ve11sm28750368pab.21.2016.05.13.09.57.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 May 2016 09:57:32 -0700 (PDT) From: ynyaaa@gmail.com To: bug-gnu-emacs@gnu.org Subject: 24.5; test-completion with completion-regexp-list Date: Sat, 14 May 2016 01:57:26 +0900 Message-ID: <87bn497v61.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 13 May 2016 13:08:59 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Calling `test-completion' with non-empty `completion-regexp-list' may cause an error. (let ((completion-regexp-list '(""))) (test-completion "XXX" '(("XXX")))) error-> Wrong type argument: stringp, ("XXX") In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.0.6002 Configured using: `configure --prefix=/c/usr --host=i686-pc-mingw32' Important settings: value of $LANG: JPN locale-coding-system: cp932 Major mode: Fundamental Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent messages: Load-path shadows: None found. Features: (advice rect debug help-mode pp shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date japan-util tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32notify w32 multi-tty emacs) Memory information: ((conses 8 79804 16234) (symbols 32 17797 0) (miscs 32 58 258) (strings 16 11770 3224) (string-bytes 1 298070) (vectors 8 10732) (vector-slots 4 468507 13202) (floats 8 62 414) (intervals 28 270 193) (buffers 508 20)) From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 00:06:52 2016 Received: (at 23533) by debbugs.gnu.org; 17 Jun 2016 04:06:52 +0000 Received: from localhost ([127.0.0.1]:43704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDl3U-00028I-4X for submit@debbugs.gnu.org; Fri, 17 Jun 2016 00:06:52 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:34583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bDl3R-000283-VE for 23533@debbugs.gnu.org; Fri, 17 Jun 2016 00:06:50 -0400 Received: by mail-oi0-f67.google.com with SMTP id a64so11671795oii.1 for <23533@debbugs.gnu.org>; Thu, 16 Jun 2016 21:06:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:cc; bh=vCa17oEB/nqhupRYpHn5EOV6AtarrZkkEX5sLVW5Ot4=; b=XIxe1oeBnor9dRCbRXsVB2tWWyazFgIscUMqiR4nctkePXgAQhb0xoy+NvjRgJXAR+ VWU0JQqOGeAkvC9GkYnMO+dtNZ5N6knYJCzLhIIMWQ9kRRTIFSvkWOP3QF/oZOV9TAgn jGmwMbOHkmKzOtMCRLFrgqqkFz/5DbbPPg1kvxI5BA5ELHmO70/CcvTSpGLNqfQAm77Q /UzWYmAR0eFyW9PQi/3Yz5VMnaYOsQMa85jKuT9ZVgMI1R/BefcNUCEnIG8BW2MQvocS YSAx3daN0qDSvi/HncyuhEZBipAN2SaueZJnDV+ZGD/dyOevrNcRpE5soHiW1Wn0lmJ2 0UhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:cc; bh=vCa17oEB/nqhupRYpHn5EOV6AtarrZkkEX5sLVW5Ot4=; b=P0XSWzfEKPi+8IlrbbcXVOUGHnoca64uytFBe0Eg2oBpSy7h/NEXATmRfSG/xDJpY5 V22XcgXdirHzEwllceRsCezoFNJwv4yecgIG9u5FEP5dlsHGpavAMCAO+hosdNKBFW8D nblEUFTEclJPnnDhi3rokYrLswAnMWUWId3n2zI022MclBi6vDJYXG0QJHQa/PujLJi+ 7apURoP3q8k5XeA5u/Ko1AFasGYdAz9JQZqSEPxT8EKWfy61XMCg7gMJqEpViqlgJ2Dk ElGBwWnhdJuZiM0WERo4rSy3isAr4/wVJR/UgQqSH7HlkYx7KgDUjD1DmK/i3nAo+Vmb 9aJA== X-Gm-Message-State: ALyK8tIQnh6zPnqipdrhRofeMmHDOKElApV/iS55DmuOxgrhUWNuGjcpIaHNvfrvRcp8HzrLERnQYfGiPhedjQ== X-Received: by 10.157.22.179 with SMTP id c48mr291364ote.35.1466136404426; Thu, 16 Jun 2016 21:06:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Thu, 16 Jun 2016 21:06:44 -0700 (PDT) From: Noam Postavsky Date: Fri, 17 Jun 2016 00:06:44 -0400 X-Google-Sender-Auth: RxhrEKcvoOlqABh3fbSVLODfge4 Message-ID: Subject: 24.5; test-completion with completion-regexp-list To: 23533@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) found 23533 25.0.95 tag 23533 + confirmed patch quit Yup, test-completion doesn't handle testing an alist against completion-regexp-list. Easy to fix: diff --git i/src/minibuf.c w/src/minibuf.c index d85a7a9..74be5d8 100644 --- i/src/minibuf.c +++ w/src/minibuf.c @@ -1665,6 +1665,8 @@ DEFUN ("test-completion", Ftest_completion, Stest_completion, 2, 3, 0, tem = Fassoc_string (string, collection, completion_ignore_case ? Qt : Qnil); if (NILP (tem)) return Qnil; + else if (CONSP (tem)) + tem = XCDR (tem); } else if (VECTORP (collection)) { From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 17 21:01:09 2016 Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 01:01:09 +0000 Received: from localhost ([127.0.0.1]:44593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE4dJ-0006eb-1L for submit@debbugs.gnu.org; Fri, 17 Jun 2016 21:01:09 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:34331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bE4dH-0006eK-UZ for 23533@debbugs.gnu.org; Fri, 17 Jun 2016 21:01:08 -0400 Received: by mail-oi0-f49.google.com with SMTP id d132so140294626oig.1 for <23533@debbugs.gnu.org>; Fri, 17 Jun 2016 18:01:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=hTxDXaVje+NPpRImWxaQ7gaVQRB2VIui8pe24MmRhWw=; b=PGuu+XB1KCs7+4RBEOzdidTb8NR8Y5nZzr3dtNLPuCsiLscWoCg3nH5rcrzlosz+Fc TdTYGXeKtx0RVdlThZXhR4KbkR0Lkx/z1181IkbAlX0PtLNNbx3smyKfRScH/HYMuv20 RZ8kkNIs+QIh9dbnnpOOVv2qRg8mns5d21hp6yLbD90MT+eNw6AunNAjni/jTLfl3ZH3 heBKjfASEd4E770WlGax7N8CmbYmMcULCRkte6DpMEV17Z4FwJCns3bsQ/pI7Qt8FacB ZnAKUfvwsdP00yMTgRhc4snHkuKrVyTxWgmb7raNRXxgTG88q/Hc0PMgCY6Psso5x28q TsJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=hTxDXaVje+NPpRImWxaQ7gaVQRB2VIui8pe24MmRhWw=; b=a4i5wSvRMF0UM1yxegB7TOhd3G/+fbfhOAOvvsTDvUDTIqN03NBbClZuzO7GToFN5f s6mwsLQAs9xcta+hVPJBDeA4upDum/UhNAhHrsIF2xjlDZZxKNXnAjLhPGPVSWaaFLtf uUCfio3lgUueG4zPeSIwHYot+FFD7xo/LZu/Lao7cB9Lx0CFyKX0JWtC7WdhJCiUVJqv 2AO5K/jq5Sq/q59q6uCjFa23xlQdhnYYPk3FZzFeypSGezJlrRRg3JVswxWu9Pecnk8H d3hVyIN2qCysJ8R8CIieQRwp2O4XK2j4I7zXqO3eN2KP7unQF2ygiUAb9N6I0rNG8Eef lSfw== X-Gm-Message-State: ALyK8tK3lwGnaiBzWT7VtUXX3szmmc03qymFU5ygFCRlJU1lmJfdj0fkM0DBuo2YimwM9U+ndCJ2uKFRsC+kgA== X-Received: by 10.157.38.185 with SMTP id l54mr3469199otb.112.1466211662034; Fri, 17 Jun 2016 18:01:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.44.103 with HTTP; Fri, 17 Jun 2016 18:01:01 -0700 (PDT) In-Reply-To: References: <87bn497v61.fsf@gmail.com> From: Noam Postavsky Date: Fri, 17 Jun 2016 21:01:01 -0400 X-Google-Sender-Auth: 3N_5aVfhrRevTidtOiOoCVMAcJ4 Message-ID: Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list To: 23533@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Fri, Jun 17, 2016 at 12:06 AM, Noam Postavsky wrote: > + else if (CONSP (tem)) > + tem = XCDR (tem); Of course that should be XCAR, not XCDR. Should this go to master or emacs-25? The fix is simple (though I managed to get it wrong once) and localized; on the other hand, it's not a critical bug. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 04:07:52 2016 Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 08:07:52 +0000 Received: from localhost ([127.0.0.1]:44702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEBIG-0008B5-50 for submit@debbugs.gnu.org; Sat, 18 Jun 2016 04:07:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEBIE-0008Ar-41 for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 04:07:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEBI8-0006nS-3d for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 04:07:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEBI4-0006mZ-BY; Sat, 18 Jun 2016 04:07:40 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEBI2-0004kX-AT; Sat, 18 Jun 2016 04:07:38 -0400 Date: Sat, 18 Jun 2016 11:08:42 +0300 Message-Id: <83a8iic41h.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Fri, 17 Jun 2016 21:01:01 -0400) Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list References: <87bn497v61.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Fri, 17 Jun 2016 21:01:01 -0400 > Cc: ynyaaa@gmail.com > > On Fri, Jun 17, 2016 at 12:06 AM, Noam Postavsky > wrote: > > + else if (CONSP (tem)) > > + tem = XCDR (tem); > > Of course that should be XCAR, not XCDR. > > Should this go to master or emacs-25? The fix is simple (though I > managed to get it wrong once) and localized; on the other hand, it's > not a critical bug. I'm not sure this is a bug. But if we want to allow this, the fix should go to master. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 13:15:06 2016 Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 17:15:06 +0000 Received: from localhost ([127.0.0.1]:45333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEJpq-0001Ag-DH for submit@debbugs.gnu.org; Sat, 18 Jun 2016 13:15:06 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEJpp-00019v-K8 for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 13:15:05 -0400 Received: by mail-oi0-f43.google.com with SMTP id d132so158457330oig.1 for <23533@debbugs.gnu.org>; Sat, 18 Jun 2016 10:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=llfvbZuhyHAAr1Qf8KWWhSeKY1h0jJMF/LV0gjEEg6I=; b=j+cgxg8i14VW3aN9YOmGitKdcw9v7LXXT23BunzruDFyh9zTF8Gm2st+L/4qm7qTUf Bvk/ToFH1C1cfVxAxDZBOLiLw/G+pH8tj2SmY/BNQSXA4Ttjvuprsj31t1DANTWnyopm rp2gmBx4starVKe3iOOOQXEBQmSSd5RZuuS7tU6lMAB/ixnpVMJoiOJequDLT3J/cWU7 SfonB7z1XQeeWxsOCWyhzaqScQbqjIpuSceX+mcBDF2CireZcWMULqoJkB/jSXokyeY3 bpnDHlZz7XPd0F0egBSeYeXsSotW4euRT6CQri6PTIpYTjYHMndrFfE+i0YjhFUI83BG Y/VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=llfvbZuhyHAAr1Qf8KWWhSeKY1h0jJMF/LV0gjEEg6I=; b=Wtn/1YYexCVYuYEXFoWgQGLPGXdOdJWT53P0VVXo5qkc5mkaYcuUwFLG++DwhlPG0x R7rzZXDJiOGfotKbpRdikZgN+OhsOoo1pY8F93OzngvDMQ7BmqVwIUlw9jdZu2sJiE0f alIGMnADojTHsDvQM6XFckbpefvTRogb6qzOcnNbiL/s07K6aPTAu+91aWdnvYigCwuU WzIv/ODXDrox8JWt+x70qIzDYCrmzSL2nWqTTTNhX9R8XbKcDDRfC9kDUrj7yPPbKPFj O3zs056E3Tb4MV8HAXDDrLXu4ik8crtD+PfcjBpUgA/n0/wJEE4NsBnaKfvFxf/Kb9ul xsBw== X-Gm-Message-State: ALyK8tK4LnrhFlng0EUbXmQ2bNSY4zXmX4VflwzeW0PdMC7XEuwLj5IGma7/QwMnb1UmvXkOvWNUwTzLpwh3dQ== X-Received: by 10.202.195.70 with SMTP id t67mr3893707oif.88.1466270100158; Sat, 18 Jun 2016 10:15:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sat, 18 Jun 2016 10:14:59 -0700 (PDT) In-Reply-To: <83a8iic41h.fsf@gnu.org> References: <87bn497v61.fsf@gmail.com> <83a8iic41h.fsf@gnu.org> From: Noam Postavsky Date: Sat, 18 Jun 2016 13:14:59 -0400 X-Google-Sender-Auth: I3LRAVsP4XLZiKZU6SNZe-eDQF4 Message-ID: Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii wrote: > I'm not sure this is a bug. I think it's pretty clearly a bug, because the docs explain that test-completion takes the same arguments as all-completions and try-completions, which do handle an alist COLLECTION with a non-nil completion-regexp-list. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 13:28:49 2016 Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 17:28:50 +0000 Received: from localhost ([127.0.0.1]:45354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEK37-0001WH-M6 for submit@debbugs.gnu.org; Sat, 18 Jun 2016 13:28:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEK35-0001W5-K1 for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 13:28:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bEK2z-0005Pl-LI for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 13:28:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bEK2v-0005N6-61; Sat, 18 Jun 2016 13:28:37 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1892 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bEK2t-0003ak-3Z; Sat, 18 Jun 2016 13:28:35 -0400 Date: Sat, 18 Jun 2016 20:29:39 +0300 Message-Id: <83r3bu9zi4.fsf@gnu.org> From: Eli Zaretskii To: Noam Postavsky In-reply-to: (message from Noam Postavsky on Sat, 18 Jun 2016 13:14:59 -0400) Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list References: <87bn497v61.fsf@gmail.com> <83a8iic41h.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.4 (------) > From: Noam Postavsky > Date: Sat, 18 Jun 2016 13:14:59 -0400 > Cc: 23533@debbugs.gnu.org, ynyaaa@gmail.com > > On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii wrote: > > I'm not sure this is a bug. > > I think it's pretty clearly a bug, because the docs explain that > test-completion takes the same arguments as all-completions and > try-completions, which do handle an alist COLLECTION with a non-nil > completion-regexp-list. When code contradicts the documentation, it's not immediately clear that the code should be fixed. Anyway, I don't consider myself an expert on completion, so I feel uneasy about makings this change without any of the experts voicing their opinions on the change. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 18 13:40:12 2016 Received: (at 23533) by debbugs.gnu.org; 18 Jun 2016 17:40:12 +0000 Received: from localhost ([127.0.0.1]:45364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEKE8-0001pg-1I for submit@debbugs.gnu.org; Sat, 18 Jun 2016 13:40:12 -0400 Received: from mail-oi0-f43.google.com ([209.85.218.43]:34149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bEKE6-0001pR-UR for 23533@debbugs.gnu.org; Sat, 18 Jun 2016 13:40:11 -0400 Received: by mail-oi0-f43.google.com with SMTP id d132so158939553oig.1 for <23533@debbugs.gnu.org>; Sat, 18 Jun 2016 10:40:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=cBEaNQDkTSDYzYPGOopyRrsPb0W60YicTAfF57ShMeQ=; b=NVbJ5M4hgnhb2etVvAmeQHSLDZ25dSomw5YzfFUOHU87eEGfC/gk6JE56zHaiVsFaI XG22C+Mb3f6ZrwIKuLlAHyWXcyTpEm07FMEI9Ce461IumGRB4mEeFawSZ4MxJyt/ALWp RblI23tmRuBrpjS/l9t01ZHoTSpNb1QJI8QN553Z7ho50aNqlqqjXuuxMwYcaDhqNm+R Am6DMtABkzH8MGBIvZPo4Gwa3ixESOrvM++jnUwwD/466GJBcP2Q4jdgAJPishkAmK1h X7GKTLbKsP3Z3/mGQ73sEXL3mb+JB61RLBn6U/BHT7eVIum0Fh0JxKYi+4V5u4jImZ3w t0GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=cBEaNQDkTSDYzYPGOopyRrsPb0W60YicTAfF57ShMeQ=; b=ClQKSCCQEg83iqfN1v0AhtITdearo7PS80GbKR48bN8p31c/WR6MRJyoWe8UZ9c06f iWsPbxtYJtwyB3oIlPt+IWlxBdcsY3gOd9cBqylsctw7nxoMW+5S3kJRaFFSLcPsRuFh uePGRl9iBcZIByGXQ5VzlF3Z9AteGaCnvZJbmWSGVVIsjTCEfjXlW1cllj+kKM2wODVs EErJPOlejfPcWRNZPgO1LO+r6BEFTblAM1SJTIz0d37iholYApZLHEKHf6W6l1JdBdXD zhHT1ySWjrQuEmvwTq7bkj9eXZcnZ/udUzjDkCWnE3LIL+kAvSD21hbR0xUNADVXmo+c 1Nsg== X-Gm-Message-State: ALyK8tIpa60QZoAfp0lRKZDh+PfULqHobScjWe5IjqYHs5PxIy6efrNOPf9ZXo/KiSL2LSL2XhLAcAH+l4NAQw== X-Received: by 10.157.36.227 with SMTP id z90mr5084970ota.124.1466271605395; Sat, 18 Jun 2016 10:40:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sat, 18 Jun 2016 10:40:04 -0700 (PDT) In-Reply-To: <83r3bu9zi4.fsf@gnu.org> References: <87bn497v61.fsf@gmail.com> <83a8iic41h.fsf@gnu.org> <83r3bu9zi4.fsf@gnu.org> From: Noam Postavsky Date: Sat, 18 Jun 2016 13:40:04 -0400 X-Google-Sender-Auth: yiLX-r2radOCeNfAERX0NYk4kFQ Message-ID: Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list To: Eli Zaretskii Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 23533 Cc: ynyaaa@gmail.com, 23533@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Sat, Jun 18, 2016 at 1:29 PM, Eli Zaretskii wrote: >> From: Noam Postavsky >> Date: Sat, 18 Jun 2016 13:14:59 -0400 >> Cc: 23533@debbugs.gnu.org, ynyaaa@gmail.com >> >> On Sat, Jun 18, 2016 at 4:08 AM, Eli Zaretskii wrote: >> > I'm not sure this is a bug. >> >> I think it's pretty clearly a bug, because the docs explain that >> test-completion takes the same arguments as all-completions and >> try-completions, which do handle an alist COLLECTION with a non-nil >> completion-regexp-list. > > When code contradicts the documentation, it's not immediately clear > that the code should be fixed. Independently of the documentation, I also think it makes no sense to have test-completion be inconsistent with all-completions and try-completion. > > Anyway, I don't consider myself an expert on completion, so I feel > uneasy about makings this change without any of the experts voicing > their opinions on the change. Okay, I will wait another week before pushing to master in case anyone has some objections/comments. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 26 21:14:53 2016 Received: (at 23533-done) by debbugs.gnu.org; 27 Jun 2016 01:14:53 +0000 Received: from localhost ([127.0.0.1]:57184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHL8X-00034D-9j for submit@debbugs.gnu.org; Sun, 26 Jun 2016 21:14:53 -0400 Received: from mail-oi0-f53.google.com ([209.85.218.53]:36232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHL8W-000341-6L for 23533-done@debbugs.gnu.org; Sun, 26 Jun 2016 21:14:52 -0400 Received: by mail-oi0-f53.google.com with SMTP id f189so181924387oig.3 for <23533-done@debbugs.gnu.org>; Sun, 26 Jun 2016 18:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=YOfQaWBkJjsibH+Fma+lCeHrJOpgxq9ywLgXFdA+ugM=; b=FbUERtvwifctzra4++kL0xKTm4xwNwgVMIM6yW/TNR31erodbpyGIg5MmjWZUcxsXR FUEFeEaXA4QQjOskJB4UJjUAxWlSroTPOmPSWz9rlWyaxW8hYTohTFrcn7NryUpX9z5r /7afdqyiESaUU05fuSKkBwJ4fe6io/WT0GbU52jEFX5xhywIuEfwyxS2FqwiqsgOezqU nyjLEkws1oKNV6qwctEwAiOhSrJvpQoQKVK1DVqmCmXlQ72WZS0na1ZlMEsAumnoyztX YR5sE5yS21YHdnHr1kqmZ42MBmNTLfLAabxF6CgLs3DIioolgwJOryjRMhra0itNYCU+ KcZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=YOfQaWBkJjsibH+Fma+lCeHrJOpgxq9ywLgXFdA+ugM=; b=Rb9Tjwg/gA3dpL0SojtIiL/YaKqDNbLS3Cu5+u2VuZ2COQp7VtiZRrSEyjHhC9sF9B Ioyv5GJpW0rQT2AK8aMlhLR3YmZhLa4sdulk1uG2FU4NB/8O/f+phP7Sn+Xw9IQw7yJj rd/G6GLaNPndDwusfwOapOqH44mpZDeHy+jLw9Du69DocSHxY5OjRdICpa4/nR3zzTAc 96UtCqYA5R7SIFvQX6xY6bCgUSuHQVLAb0zf0tqFfnu/PWiA95/QVE56Nvyx+xWaKpQQ s1IM0bFdW4kUtGYX7K/QhNjacUDJ3N0hvxuVmDaalrarlOkfzJpNaMT3ah6LYO6yp7Ut /KRw== X-Gm-Message-State: ALyK8tIKrLmYlEqpTJeCHYbtaFl7uV0H5Jxkby+yENoL5EtNTzM+7Eayrv/jMjJs2/Wnjh/v0WY7H8H796iW0g== X-Received: by 10.157.38.185 with SMTP id l54mr9947022otb.112.1466990086776; Sun, 26 Jun 2016 18:14:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Sun, 26 Jun 2016 18:14:46 -0700 (PDT) In-Reply-To: References: <87bn497v61.fsf@gmail.com> <83a8iic41h.fsf@gnu.org> <83r3bu9zi4.fsf@gnu.org> From: Noam Postavsky Date: Sun, 26 Jun 2016 21:14:46 -0400 X-Google-Sender-Auth: YP9nUAAt3SUAZm4eiqssrjeRmaQ Message-ID: Subject: Re: bug#23533: 24.5; test-completion with completion-regexp-list To: 23533-done@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 23533-done Cc: ynyaaa@gmail.com, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 25.2 On Sat, Jun 18, 2016 at 1:40 PM, Noam Postavsky wrote: > Okay, I will wait another week before pushing to master in case anyone > has some objections/comments. Pushed as dd98ee89 From unknown Thu Sep 11 09:18:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 25 Jul 2016 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 20 23:23:36 2016 Received: (at control) by debbugs.gnu.org; 21 Nov 2016 04:23:36 +0000 Received: from localhost ([127.0.0.1]:36575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8g8m-0002eh-3L for submit@debbugs.gnu.org; Sun, 20 Nov 2016 23:23:36 -0500 Received: from mail-io0-f176.google.com ([209.85.223.176]:35733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c8g8k-0002eN-ST; Sun, 20 Nov 2016 23:23:35 -0500 Received: by mail-io0-f176.google.com with SMTP id n13so30591488ioe.2; Sun, 20 Nov 2016 20:23:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=5cqR65E6h35csSuCgvc2q7AEE1s/Xb8DcctlG1hoDoM=; b=BoPCW+G1F4c8+IOsLAAFw+/Nb+9Rjfm6lN0qYNHGha32aG6du8eut2QoeWnDN+K42A 0KKgYY34PkVCxEy+ED5FRlTJ3ciKFQW//gNu4ZM7cOi62I1NIfdgYcIWFCWiZMTk3k4y P7zyGWN33QqDj3urdMWS7MKpPclPS5hj+0DcaooQT1eI2T72kWgLKrY5A0f/gD1jE8vG ty1PCUzD3IhV5veOFbD/DsqX44i/kqTKILvKEwrzB7RcQHQkfOUubQkOv4Kti/UzpZT/ tN+FPVyTr0w+ov8Vw+6812lEdGrgKNPBzJz2C5Hu48dng/2/E2J5z2vG16M43s+iIr9R sF1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=5cqR65E6h35csSuCgvc2q7AEE1s/Xb8DcctlG1hoDoM=; b=KLq1XAW3F4ZA0VEGjFwvnvu9hos//SnFzbOyn3t30Xm2yr1O9MHwahfpejYuhoqF4u jV5f73d1oXRvJKDPZtokLJNkDgvUKuqfBFl+sR3D/JH5CA4YYivkfAVdN+FIWGr+tr39 587LxsOqnXD8nWS5VDM7dLDEcgtu37eBw/9N0hJlH8e4QPZ9EmBS9HL5/YpVJFEQwzh0 uSRsHK8DouB+tZNr2pe/uldFK4fcxtIR+TeIaSGD9BbCxcdOfQiMt8IBjpN8p3ePVaQq FQIsfIORYDYdaCv9lmoMX0yCuD/BttTJZ8p9RDy46wdsgft0mzNfjhbUaSHOHQvzGiwu Qw2Q== X-Gm-Message-State: AKaTC035Er3AarucpdkkqO+3/+K+20s9JDtLYAmsc0xnzPTcOC/juwyN7EjGSeU1cU/18Q== X-Received: by 10.107.190.6 with SMTP id o6mr9371412iof.95.1479702209103; Sun, 20 Nov 2016 20:23:29 -0800 (PST) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id x190sm5479557ite.14.2016.11.20.20.23.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Nov 2016 20:23:27 -0800 (PST) From: npostavs@users.sourceforge.net To: Mark Oteiza Subject: Re: bug#24966: 26.0.50; References: <87shqnpxym.fsf@udel.edu> Date: Sun, 20 Nov 2016 23:24:19 -0500 In-Reply-To: <87shqnpxym.fsf@udel.edu> (Mark Oteiza's message of "Sat, 19 Nov 2016 05:26:25 -0500") Message-ID: <87fumljw98.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control Cc: 24966@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) unarchive 23533 # It was marked for 25.2 before master was renumbered to 26 notfixed 23533 25.2 fixed 23533 26.0.50 retitle 24966 26.0.50; test-completion with alist COLLECTION calls PREDICATE incorrectly tags 24966 confirmed quit Mark Oteiza writes: > Hi, > > dd98ee8992c3246861e44 appears to be the culprit for breaking the > following from -Q: Yup, I didn't fix test-completion correctly. > > 1. C-x C-f /tmp/foo.tex > 2. M-x reftex-mode > 3. Insert the following: \label{foobar} > 4. M-x reftex-goto-label > > and, when attempting to complete, a wrong-type-argument error occurs. > > Debugger entered--Lisp error: (wrong-type-argument listp "argh") > #[(x) "@;\207" [x] 1]("argh") > test-completion("argh" ((xr nil "\\\\\\\\\\\\") (index-tags) (is-multi nil) (bibview-cache) (master-dir . "/tmp/") (label-numbers) (bof "/tmp/lol.tex") ("argh" "s" " " "/tmp/lol.tex" nil) (eof "/tmp/lol.tex")) #[(x) "@;\207" [x] 1]) I tentatively suggest the patch below, but I want to add some tests before commiting anything. diff --git i/src/minibuf.c w/src/minibuf.c index 57eea05..fe187b3 100644 --- i/src/minibuf.c +++ w/src/minibuf.c @@ -1686,8 +1686,6 @@ DEFUN ("test-completion", Ftest_completion, Stest_completion, 2, 3, 0, tem = Fassoc_string (string, collection, completion_ignore_case ? Qt : Qnil); if (NILP (tem)) return Qnil; - else if (CONSP (tem)) - tem = XCAR (tem); } else if (VECTORP (collection)) { @@ -1765,14 +1763,16 @@ DEFUN ("test-completion", Ftest_completion, Stest_completion, 2, 3, 0, /* Reject this element if it fails to match all the regexps. */ if (CONSP (Vcompletion_regexp_list)) { + Lisp_Object temstr = (CONSP (tem)) ? XCAR (tem) : tem; + if (SYMBOLP (temstr)) + temstr = string; + ptrdiff_t count = SPECPDL_INDEX (); specbind (Qcase_fold_search, completion_ignore_case ? Qt : Qnil); for (regexps = Vcompletion_regexp_list; CONSP (regexps); regexps = XCDR (regexps)) { - if (NILP (Fstring_match (XCAR (regexps), - SYMBOLP (tem) ? string : tem, - Qnil))) + if (NILP (Fstring_match (XCAR (regexps), temstr, Qnil))) return unbind_to (count, Qnil); } unbind_to (count, Qnil); From unknown Thu Sep 11 09:18:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 19 Dec 2016 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator