From unknown Mon Jun 23 07:46:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#2352 <2352@debbugs.gnu.org> To: bug#2352 <2352@debbugs.gnu.org> Subject: Status: 23.0.90; Vertical window border on OS X Reply-To: bug#2352 <2352@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:46:45 +0000 retitle 2352 23.0.90; Vertical window border on OS X reassign 2352 emacs submitter 2352 Aaron Ecay severity 2352 normal tag 2352 patch thanks From aaronecay@gmail.com Mon Feb 16 19:52:07 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Feb 2009 03:52:07 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.1 required=4.0 tests=FOURLA,IMPRONONCABLE_2, MURPHY_DRUGS_REL8 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1H3q39A024844 for ; Mon, 16 Feb 2009 19:52:05 -0800 Received: from mx10.gnu.org ([199.232.76.166]:47322) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LZGy6-0004Iu-H6 for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:49:58 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LZH05-0000jU-SP for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:03 -0500 Received: from qw-out-1920.google.com ([74.125.92.149]:11541) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LZH05-0000jM-Fr for emacs-pretest-bug@gnu.org; Mon, 16 Feb 2009 22:52:01 -0500 Received: by qw-out-1920.google.com with SMTP id 4so631530qwk.24 for ; Mon, 16 Feb 2009 19:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mime-version:content-type:content-disposition:user-agent; bh=u20arzYQDeLr8Kn6xg80LTETzYJ1Gz/u2+BlO2SkK7E=; b=wrPs8C7vZlOr4i5s36+Z+qBsCimohYVJnn76NenilEqynIDMS6o3dByXQ+TcirOkNl YwAiCSxVacm9Dm4cirVbtUjYS843uwa7Pp8moNHpzUo0+ReQ/bgMkTUYkQ/GNxSQNQ0I L6dQ6DWq/GeNUMregemKOydLd6c/KW7Fqxck4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; b=Q4F5tuaYpzkYM4w/jJOtbzegwiA4MrMk/cPixv7yvmxvNkoipD939yybz2dUnouaMS ShhX2QAgr8EO+EAFYWEjxEusV4A9IStXoij9hh1zS0e/yjGzpAQc4ZahqvvuWqeMHFsK 6wK1/AuFMK8zm/mMx/jt6zeymoZGNa4D2AiJY= Received: by 10.224.28.144 with SMTP id m16mr2292408qac.86.1234842720211; Mon, 16 Feb 2009 19:52:00 -0800 (PST) Received: from localhost (dhcp0403.vpm.resnet.group.upenn.edu [165.123.165.237]) by mx.google.com with ESMTPS id 7sm11828839ywo.57.2009.02.16.19.51.58 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Feb 2009 19:51:59 -0800 (PST) Date: Mon, 16 Feb 2009 22:51:56 -0500 From: Aaron Ecay To: emacs-pretest-bug@gnu.org Subject: 23.0.90; Vertical window border on OS X Message-ID: <20090217035156.GI48993@awe.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: On the OS X (and presumably GNUstep) port, the drawing of a vertical border between two frames does not work. This currently uses the NSDrawGroove function from the Cocoa/GNUstep API. According to http://preview.tinyurl.com/c2flh9 (apologies for the shortening, the link goes to some Apple API documentation and the URL is gargantuan), the function NSDrawGroove "Draws a gray-filled rectangle with a groove border". This would not be desirable behavior in any case, as making the divider gray disregards the setting of the vertical-border face. And in any event, it appears to be a no-op on OS X.5 (Leopard) -- after doing a C-x 3, there is no vertical frame border apparent against either a dark or a white background. The function to use, IMHO, is NSRectFill; substituting this fn makes the border drawing happen. NSRectFill was used in Emacs 22 (`emacs22' branch in the git repo, src/nsterm.m line 2466). The patch below fixes this behavior. It also restores another bit of v.22 status quo, namely making the vertical window divider one pixel in width, instead of the current two. ####### BEGIN PATCH ####### diff --git a/src/nsterm.m b/src/nsterm.m index b674eda..c2ebf9f 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -2454,7 +2454,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) { struct frame *f = XFRAME (WINDOW_FRAME (w)); struct face *face; - NSRect r = NSMakeRect (x, y0, 2, y1-y0); + NSRect r = NSMakeRect (x, y0, 1, y1-y0); NSTRACE (ns_draw_vertical_window_border); @@ -2463,7 +2463,7 @@ ns_draw_vertical_window_border (struct window *w, int x, int y0, int y1) [ns_lookup_indexed_color(face->foreground, f) set]; ns_focus (f, &r, 1); - NSDrawGroove (r, r); + NSRectFill(r); ns_unfocus (f); } ####### END PATCH ####### If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /opt/src/emacs/nextstep/Emacs.app/Contents/Resources/etc/DEBUG for instructions. In GNU Emacs 23.0.90.7 (i386-apple-darwin9.6.0, NS apple-appkit-949.43) of 2009-02-15 on dhcp0403.vpm.resnet.group.upenn.edu Windowing system distributor `Apple', version 10.3.949 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: diff-auto-refine-mode: t paredit-mode: t auto-insert-mode: t desktop-save-mode: t mac-print-mode: t shell-dirtrack-mode: t show-paren-mode: t global-auto-complete-mode: t auto-complete-mode: t display-battery-mode: t icomplete-mode: t savehist-mode: t recentf-mode: t partial-completion-mode: t display-time-mode: t ns-extended-platform-support-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-r C-h C-g C-e # SPC T O D O : SPC f u n c t i o n SPC t o SPC e d i t SPC i n SPC t e r m i n a l SPC ( e ) C-x C-s C-h f r e p o r t - e m C-h v u s e r - m a s h i s h u u q h n n n n n n n s C-e C-e M-; T O O D : SPC D O : SPC m o v C-M-x C-x 3 C-x 0 C-x < M-x r e p o r t Recent messages: Mark saved where search started byte-code: End of buffer [3 times] byte-code: Beginning of buffer [3 times] Saving file /Users/aecay/home/.zshrc... Wrote /Users/aecay/home/.zshrc Type "q" to quit. [2 times] Entering debugger... Back to top level. Mark set From lekktu@gmail.com Tue Feb 17 02:36:23 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Feb 2009 10:36:23 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f10.google.com (mail-ew0-f10.google.com [209.85.219.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1HAaJw4028170 for ; Tue, 17 Feb 2009 02:36:21 -0800 Received: by ewy3 with SMTP id 3so2378509ewy.1 for ; Tue, 17 Feb 2009 02:36:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=Co3xSCh92CH6HaMeFfETBMNt6ZfVFtmMc5bPzuC4uFE=; b=CyfH/by0RlqFz5mqcp56uYWnOEgU0eLBCgXU7sEAkNY2tAZqzo+CWYFwSYgcreOHyv xevrlH3qwNRIxsO6XQzI8nDkQ+EAe5zqZ7wjiGGX6YNrDVn28C5p0jKVRuR3TYNfDxPc r9wf0qQGIB6NBu/xtXYZ9PKtR/+l0t+102BCQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=OUvgDKLGIQQs1z/wfRoZGnqLkZ+DSexrSg6Z/908eRYjyKTy2S4nVitLDLCF+Q5uue mtFRxlmpuL4RsUQw0Nkws5mOKs6kmFhGIb6QNPuCWAtx4r1uezsD/FtSe4Z/hfOOqrFj xJekwK86C+2V0rWbaO4KaLKAQNiBvrtiaFRkc= MIME-Version: 1.0 Received: by 10.210.92.11 with SMTP id p11mr53471ebb.24.1234866974227; Tue, 17 Feb 2009 02:36:14 -0800 (PST) Date: Tue, 17 Feb 2009 11:36:14 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 2338 emacs,ns reassign 2352 emacs,ns tags 2352 + patch merge 2352 2338 reassign 2351 spam quit From adrian.b.robert@gmail.com Fri Mar 6 07:31:57 2009 Received: (at 2352-done) by emacsbugs.donarmstrong.com; 6 Mar 2009 15:31:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n26FVrOJ018359 for <2352-done@emacsbugs.donarmstrong.com>; Fri, 6 Mar 2009 07:31:55 -0800 Received: by nf-out-0910.google.com with SMTP id d3so55710nfc.31 for <2352-done@emacsbugs.donarmstrong.com>; Fri, 06 Mar 2009 07:31:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:content-type :message-id:cc:content-transfer-encoding:from:subject:date:to :x-mailer; bh=PmanUDgJQeVJK75UByHO/VYQVqT3vbJ6fJsSClgmxpk=; b=jbEHI55kpgoYfkSb7C8d6EDw930brlQ7A1IqzJ5BH+kCJE68Zo5BkNd74NmBKPVMfi g6a4aTqLlPFJSNe4/JqHQIo+A8Y1Sn8DUHkEvtjK39f0wa21FgzTYlBiq+zhmZClmtE5 SbUdSI7u5cmCRBBP1ksUINV3h3fwtrGvd+Jd0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:content-type:message-id:cc:content-transfer-encoding :from:subject:date:to:x-mailer; b=b+fUN71PVF3nkDXEr1WSCIkCNGy9146n2yTF+k1stDklJXziwitOBUg5DfzjcpqhjJ zE2GxJPWN/in2utWN7hbRsBaGb1bczH44pRsiWELYAQu+brPuHLmOxGJHlUZ9Lh3Vn09 6COFBHHNyJuNK+JVX6v1/FvHIkY/EmUVd/NvI= Received: by 10.216.1.202 with SMTP id 52mr1288226wed.15.1236353513075; Fri, 06 Mar 2009 07:31:53 -0800 (PST) Received: from ?88.194.195.100? (gprs-prointernet-ffc3c200-100.dhcp.inet.fi [88.194.195.100]) by mx.google.com with ESMTPS id 5sm2485200nfv.21.2009.03.06.07.31.51 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 06 Mar 2009 07:31:52 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Cc: Aaron Ecay Content-Transfer-Encoding: 7bit From: Adrian Robert Subject: Re: 23.0.90; Vertical window border on OS X Date: Fri, 6 Mar 2009 17:32:33 +0200 To: 2352-done@debbugs.gnu.org X-Mailer: Apple Mail (2.753.1) Thanks, I've applied this patch and am closing the report. From lekktu@gmail.com Tue Mar 17 02:22:15 2009 Received: (at control) by emacsbugs.donarmstrong.com; 17 Mar 2009 09:22:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: ** X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=2.3 required=4.0 tests=MISSING_SUBJECT,NOSUBJECT, VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-ew0-f176.google.com (mail-ew0-f176.google.com [209.85.219.176]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2H9MCD0005523 for ; Tue, 17 Mar 2009 02:22:14 -0700 Received: by ewy24 with SMTP id 24so3991757ewy.1 for ; Tue, 17 Mar 2009 02:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type:content-transfer-encoding; bh=8kg3xZo7LkfeWm8/N+Bb5gCTHDvSowOAk/GT0NUKjNc=; b=sS/XKophFfzDqrpZxSKYexjpSHOEBgWFBIntADHTWgLQ7xAkX2LJay0VW5/a9alnYU JqK5mkqwrC9L2Iu+b+OHuLWMs4dh1ivw0p3TpVFe4KfkhmlI8VYyhAH9+vGdgV/V/aj8 ZjrZbQHD9z3NgdBNX9dcvrhXE1JDzicWFM4Uo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=epHiHh4jTH8hNQ3Z9W+sdmPMWG5K8t56w3EIXDv+nyc7uMUO0OebD87ssmj47nN/8V gEn2T5weZyGT7QqOtX3mDXQokeXZQjhWmeLaUkSzN5IXPiPJhZ8VSTSKiUUROU4m5YrP Wm9HxlDTvoTR98dZx15fhqd+5ewRn1t26NJDo= MIME-Version: 1.0 Received: by 10.210.139.15 with SMTP id m15mr4357553ebd.9.1237281726835; Tue, 17 Mar 2009 02:22:06 -0700 (PDT) Date: Tue, 17 Mar 2009 10:22:06 +0100 Message-ID: Subject: From: Juanma Barranquero To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit reassign 337 emacs,vc reassign 768 emacs,vc reassign 927 emacs,vc reassign 996 emacs,vc reassign 1098 emacs,vc reassign 1163 emacs,vc reassign 1256 emacs,vc reassign 1257 emacs,vc reassign 1408 emacs,vc reassign 1429 emacs,vc reassign 1589 emacs,vc reassign 1647 emacs,w32,vc reassign 1741 emacs,vc reassign 2093 emacs,vc reassign 2110 emacs,vc reassign 2117 emacs,vc reassign 2157 emacs,vc reassign 2338 emacs,vc reassign 2553 emacs,vc reassign 2598 emacs,vc reassign 2604 emacs,vc reassign 2612 emacs,vc reassign 2641 emacs,vc reassign 2652 emacs,vc reassign 2675 emacs,vc reassign 2676 emacs,vc reassign 2678 emacs,vc quit From unknown Mon Jun 23 07:46:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Apr 2009 14:24:05 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator