GNU bug report logs - #2349
23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2349 in the body.
You can then email your comments to 2349 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Xavier Maillard <xma <at> gnu.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.90; [PATCH]: report-emacs-bug - extend stickyness property region
Date: Mon, 16 Feb 2009 22:25:02 +0100

I think there is no need to let user modify the region going from
user report text to recent keys, thus I think we could extend the
sticky property to that region.

Users still can modify recent keys section (to hide security
details for example).

Here is the proposed patch:

diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index 7132da6..6dd7a6c 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -145,7 +145,6 @@ usually do not have translators to read other languages for them.\n\n")
       (if (file-readable-p debug-file)
 	  (insert "If you would like to further debug the crash, please read the file\n"
 		  debug-file " for instructions.\n")))
-    (add-text-properties (1+ user-point) (point) prompt-properties)
 
     (insert "\n\nIn " (emacs-version) "\n")
     (if (fboundp 'x-server-vendor)
@@ -180,6 +179,8 @@ usually do not have translators to read other languages for them.\n\n")
 	   (insert (format "  %s: %s\n" mode
 			   (buffer-local-value mode from-buffer)))))
     (insert "\n")
+    (add-text-properties (1+ user-point) (point) prompt-properties)
+
     (insert "Recent input:\n")
     (let ((before-keys (point)))
       (insert (mapconcat (lambda (key)

With this proposed ChangeLog entry:

2009-02-16  Xavier Maillard  <xma <at> gnu.org>

	* mail/emacsbug.el.new (report-emacs-bug): Extend stickiness
	property to major and minor modes section.
Recent input:
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> t o SPC M a j o <backspace> <backspace> 
<backspace> <backspace> m a j o r SPC a n d SPC m i 
n o r SPC m o d e s SPC d e t e c t i o n . C-x C-w 
C h a n <tab> <tab> . n e w <return> M-x e d i f f 
- d i <tab> i <tab> <return> m a i l <return> <up> 
<return> <return> M-x <up> C-e <backspace> <backspace> 
<backspace> <backspace> C-g M-x e d i <tab> f f <return> 
<return> <up> <backspace> <backspace> <backspace> <backspace> 
<return> ? D <switch-frame> <down> <up> <down> <down> 
<down> <down> D <switch-frame> C-x o C-x 1 M-x d i 
f f <tab> <tab> - e d <tab> <return> C-g M-x <up> C-e 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <tab> b u f f <tab> <return> <return> q 
C-x C-w C C-g M-k M-k M-k C-x C-w e m a c s b u <tab> 
<return> y M-x <up> <return> <return> q M-x v c - d 
i f <tab> <return> c M-x d i f f - u n i <tab> <return> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> q <down> = <backspace> 
<backspace> M-x <up> <return> M-x <up> <up> <up> <return> 
<return> c M-x <up> <up> <return> q C-x C-s M-x g i 
t <backspace> <backspace> <backspace> C-g M-x <up> 
<up> <up> <return> C-x h M-w M-x r e p o r t <tab> 
<return>

Recent messages:
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Buffer is read-only: #<buffer *vc-diff*>
Buffer is read-only: #<buffer *Diff*>
Saving file /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...
Wrote /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el
Quit
Finding changes in /home/xma/usr/src/GITed/emacs/lisp/mail/emacsbug.el...done
Mark set [2 times]


	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Message #14 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Xavier Maillard <xma <at> gnu.org>
To: 2349 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#2349: 23.0.90;
	[PATCH]: report-emacs-bug - extend stickyness property region
Date: Mon, 2 Mar 2009 02:25:11 +0100

There was a typo in the proposed ChangeLog entry. Here is the
correct one.

2009-02-16  Xavier Maillard  <xma <at> gnu.org>

	* mail/emacsbug.el (report-emacs-bug): Extend stickiness
	properties to major and minor modes detection.


Regards

	Xavier
-- 
http://www.gnu.org
http://www.april.org
http://www.lolica.org

Message #24 received at 2349-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 2349-done <at> debbugs.gnu.org
Subject: Re: Bug#2349: report-emacs-bug - extend stickyness property region
Date: Thu, 10 Dec 2009 20:21:48 -0500

Thanks for the patch, but it isn't appropriate. The propertized
regions are just used to mark non-interesting boilerplate text that is
automatically stripped before sending the bug report. These regions
should not be extended to cover potentially useful data.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.