GNU bug report logs - #23458
[PATCH] Support completion of HTML tags in CSS selectors

Previous Next

Package: emacs;

Reported by: Simen Heggestøyl <simenheg <at> gmail.com>

Date: Thu, 5 May 2016 12:34:01 UTC

Severity: wishlist

Tags: patch

Done: Simen Heggestøyl <simenheg <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 23458 in the body.
You can then email your comments to 23458 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Thu, 05 May 2016 12:34:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Simen Heggestøyl <simenheg <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 05 May 2016 12:34:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: [PATCH] Support completion of HTML tags in CSS selectors
Date: Thu, 05 May 2016 14:32:45 +0200
[Message part 1 (text/plain, inline)]
The attached patch adds support for completion of HTML tags in CSS
selectors for CSS- and SCSS mode.

-- Simen
[Message part 2 (text/html, inline)]
[0001-Support-completion-of-HTML-tags-in-CSS-selectors.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Thu, 05 May 2016 15:04:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: [PATCH] Support completion of HTML tags in CSS selectors
Date: Thu, 05 May 2016 11:02:28 -0400
> @@ -747,7 +749,7 @@ css--complete-property
>        (let ((start (point)))
>          (skip-chars-backward " \t\r\n")
>          (when (memq (char-before) '(?\{ ?\;))
> -          (list start pos css-property-ids))))))
> +          (list start pos css-property-ids :exclusive 'no))))))
> 
>  (defun css--complete-bang-rule ()
>    "Complete bang-rule at point."

It'd be better to avoid the :exclusive thingy, and use something like
completion-table-merge instead.

:exclusive basically prevents any completion style other than prefix
completion, so it's better avoid it when possible.  This said, it's not
a real objection.


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Thu, 05 May 2016 16:45:01 GMT) Full text and rfc822 format available.

Message #11 received at 23458 <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 23458 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23458: [PATCH] Support completion of HTML tags in CSS
 selectors
Date: Thu, 05 May 2016 18:44:35 +0200
[Message part 1 (text/plain, inline)]
On Thu, May 5, 2016 at 5:02 PM, Stefan Monnier 
<monnier <at> IRO.UMontreal.CA> wrote:
> It'd be better to avoid the :exclusive thingy, and use something like
> completion-table-merge instead.
> 
> :exclusive basically prevents any completion style other than prefix
> completion, so it's better avoid it when possible.  This said, it's 
> not
> a real objection.

Something along these lines?

-- Simen
[Message part 2 (text/html, inline)]
[0001-Support-completion-of-HTML-tags-in-CSS-selectors.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Thu, 05 May 2016 17:00:02 GMT) Full text and rfc822 format available.

Message #14 received at 23458 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 23458 <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23458: [PATCH] Support completion of HTML tags in CSS
 selectors
Date: Thu, 05 May 2016 12:59:07 -0400
> Something along these lines?

Yes.


        Stefan




Reply sent to Simen Heggestøyl <simenheg <at> gmail.com>:
You have taken responsibility. (Thu, 05 May 2016 19:25:01 GMT) Full text and rfc822 format available.

Notification sent to Simen Heggestøyl <simenheg <at> gmail.com>:
bug acknowledged by developer. (Thu, 05 May 2016 19:25:01 GMT) Full text and rfc822 format available.

Message #19 received at 23458-done <at> debbugs.gnu.org (full text, mbox):

From: Simen Heggestøyl <simenheg <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 23458-done <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23458: [PATCH] Support completion of HTML tags in CSS
 selectors
Date: Thu, 05 May 2016 21:24:43 +0200
[Message part 1 (text/plain, inline)]
On Thu, May 5, 2016 at 6:59 PM, Stefan Monnier 
<monnier <at> IRO.UMontreal.CA> wrote:
>>  Something along these lines?
> 
> Yes.

Good, thanks for taking a look.

I've installed the patch in master.

I think that by this, CSS mode's completion has finally reached
feature parity with company-css.

-- Simen
[Message part 2 (text/html, inline)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Thu, 05 May 2016 21:53:02 GMT) Full text and rfc822 format available.

Message #22 received at 23458-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: 23458-done <at> debbugs.gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#23458: [PATCH] Support completion of HTML tags in CSS
 selectors
Date: Thu, 05 May 2016 17:52:09 -0400
> Good, thanks for taking a look.

> I've installed the patch in master.

> I think that by this, CSS mode's completion has finally reached
> feature parity with company-css.

Great, thanks,


        Stefan




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#23458; Package emacs. (Sat, 07 May 2016 23:38:02 GMT) Full text and rfc822 format available.

Message #25 received at 23458 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: 23458 <at> debbugs.gnu.org, simenheg <at> gmail.com
Subject: Re: bug#23458: [PATCH] Support completion of HTML tags in CSS
 selectors
Date: Sun, 8 May 2016 02:37:19 +0300
On 05/05/2016 10:24 PM, Simen Heggestøyl wrote:

> I've installed the patch in master.
>
> I think that by this, CSS mode's completion has finally reached
> feature parity with company-css.

Great!

I'll have to remember to update the company-backends initvalue form when 
we finally decide which Emacs version the master will be released in.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 05 Jun 2016 11:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 9 years and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.