GNU bug report logs - #23453
25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 23453 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com
Subject: bug#23453: 25.0.93; dired-do-find-regexp does not work on Windows even after installing GNU find and grep
Date: Thu, 05 May 2016 05:44:39 +0300

> Cc: 23453 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Thu, 5 May 2016 01:15:37 +0300
> 
> Oops, thanks for catching this.
> 
> On 05/05/2016 12:39 AM, Kaushal Modi wrote:
> 
> > +   (shell-quote-argument dir)
> 
> This looks good.
> 
> > +   (xref--find-ignores-arguments ignores (shell-quote-argument dir))))
> 
> I'm not sure about this line, on the other hand. Is it actually 
> required? If yes, this quoting should be performed inside 
> xref--find-ignores-arguments, I think.

Indeed, it is IMO wrong to use shell-quote-argument anywhere except
immediately before invoking the shell command.  If this is what is
needed to fix the bug, the bug is elsewhere.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.